)]}'
{"manila_tempest_tests/tests/api/admin/test_share_servers.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"c97f0957adf81f459f4f78044f030f4208406cd1","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        # Remember name of server that was used by this test suite"},{"line_number":91,"context_line":"        # to be sure it will be still existing."},{"line_number":92,"context_line":"        for server in servers:"},{"line_number":93,"context_line":"            if server[\"share_network_name\"] in self.sn_name_and_id:"},{"line_number":94,"context_line":"                if not server[\"host\"]:"},{"line_number":95,"context_line":"                    msg \u003d (\"Server \u0027%s\u0027 has wrong value for host - \""},{"line_number":96,"context_line":"                           \"\u0027%s\u0027.\") % (server[\"id\"], server[\"host\"])"},{"line_number":97,"context_line":"                    raise lib_exc.InvalidContentType(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_972834e4","line":94,"range":{"start_line":93,"start_character":12,"end_line":94,"end_character":38},"updated":"2017-03-09 11:48:27.000000000","message":"if we assume that setup always creates share servers successfully, why is this condition still necessary? I am led to believe that if it is successfull \u0027host\u0027 field will never be empty.\n\nisn\u0027t the below code more appropriate?\n\nif server[\"share_network_name\"] not in self.sn_name_and_id:\n\n\n    msg \u003d (\"Server \u0027%s\u0027 has wrong value for host - \"\u0027%s\u0027.\") % (server[\"id\"], server[\"host\"])","commit_id":"46d499a85c0c40307172799a757193c50be0076f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4dd5e6cd44c2e9de26912812655b522535b3ab04","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        # Remember name of server that was used by this test suite"},{"line_number":91,"context_line":"        # to be sure it will be still existing."},{"line_number":92,"context_line":"        for server in servers:"},{"line_number":93,"context_line":"            if server[\"share_network_name\"] in self.sn_name_and_id:"},{"line_number":94,"context_line":"                if not server[\"host\"]:"},{"line_number":95,"context_line":"                    msg \u003d (\"Server \u0027%s\u0027 has wrong value for host - \""},{"line_number":96,"context_line":"                           \"\u0027%s\u0027.\") % (server[\"id\"], server[\"host\"])"},{"line_number":97,"context_line":"                    raise lib_exc.InvalidContentType(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_fa5dd515","line":94,"range":{"start_line":93,"start_character":12,"end_line":94,"end_character":38},"in_reply_to":"9a30ddce_972834e4","updated":"2017-03-09 12:02:50.000000000","message":"Rodrigo, I start worrying concretely about your reviews. It is second time you state that \"we assume it works, why we check it here?\". Rodrigo, it is test! We do not assume, we VERIFY.","commit_id":"46d499a85c0c40307172799a757193c50be0076f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"7ed58f83cec601770a46eb05182f195a21d717ae","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        # Remember name of server that was used by this test suite"},{"line_number":91,"context_line":"        # to be sure it will be still existing."},{"line_number":92,"context_line":"        for server in servers:"},{"line_number":93,"context_line":"            if server[\"share_network_name\"] in self.sn_name_and_id:"},{"line_number":94,"context_line":"                if not server[\"host\"]:"},{"line_number":95,"context_line":"                    msg \u003d (\"Server \u0027%s\u0027 has wrong value for host - \""},{"line_number":96,"context_line":"                           \"\u0027%s\u0027.\") % (server[\"id\"], server[\"host\"])"},{"line_number":97,"context_line":"                    raise lib_exc.InvalidContentType(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_fdb4ef35","line":94,"range":{"start_line":93,"start_character":12,"end_line":94,"end_character":38},"in_reply_to":"9a30ddce_fa5dd515","updated":"2017-03-09 12:42:04.000000000","message":"Valeriy, the scenario I described was a different one, and I thought it was not covered. It was about a non-empty \u0027host\u0027 value, which upon another glance I noticed it is covered in the for\u0027s else below.\n\nAlso, I asked a question so you could enlighten me on this matter and we could achieve a test that provides more coverage, not less coverage. I suspect that you have taken my comment the wrong way and I do not find your comment funny in any way. I would like to ask you to please focus on the questions and the scenario I was asking about.","commit_id":"46d499a85c0c40307172799a757193c50be0076f"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"560dad6b909fc62776c9f1bd39caadd5a9dd2b6e","unresolved":false,"context_lines":[{"line_number":90,"context_line":"        # Remember name of server that was used by this test suite"},{"line_number":91,"context_line":"        # to be sure it will be still existing."},{"line_number":92,"context_line":"        for server in servers:"},{"line_number":93,"context_line":"            if server[\"share_network_name\"] in self.sn_name_and_id:"},{"line_number":94,"context_line":"                if not server[\"host\"]:"},{"line_number":95,"context_line":"                    msg \u003d (\"Server \u0027%s\u0027 has wrong value for host - \""},{"line_number":96,"context_line":"                           \"\u0027%s\u0027.\") % (server[\"id\"], server[\"host\"])"},{"line_number":97,"context_line":"                    raise lib_exc.InvalidContentType(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":3,"id":"9a30ddce_00723c49","line":94,"range":{"start_line":93,"start_character":12,"end_line":94,"end_character":38},"in_reply_to":"9a30ddce_fdb4ef35","updated":"2017-03-09 13:34:21.000000000","message":"Coverage stays the same. Only bug got fixed. Proposed \"scenario\" is not complete, there is only init of var after condition. But, from my understanding, proposed part of code appeared because of idea to remove check for \"host\" value, that I opposed to in first comment.","commit_id":"46d499a85c0c40307172799a757193c50be0076f"}]}
