)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2cf5a38352376acc0eee59b5fa37237df859595b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Also apply following tempest plugin changes:"},{"line_number":13,"context_line":"- Add new \u0027capability_sg_consistent_snapshot_support\u0027 tempest config"},{"line_number":14,"context_line":"option, that will be used for creation of new share group types and used"},{"line_number":15,"context_line":"to prove that scheeduling works as expected."},{"line_number":16,"context_line":"- Fix some share group test attributes from \u0027only API involved\u0027 to"},{"line_number":17,"context_line":"  \u0027API and Backend are involved\u0027, because it is so indeed."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ffe62b97_62c2f935","line":15,"range":{"start_line":15,"start_character":14,"end_line":15,"end_character":25},"updated":"2017-03-25 03:01:37.000000000","message":"double e, double e","commit_id":"a1e57c60279d64c9747d377b953a3e7cfbc03440"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"507d053e1905ef543e97105326cf106cf1581a58","unresolved":false,"context_lines":[{"line_number":12,"context_line":"Also apply following tempest plugin changes:"},{"line_number":13,"context_line":"- Add new \u0027capability_sg_consistent_snapshot_support\u0027 tempest config"},{"line_number":14,"context_line":"option, that will be used for creation of new share group types and used"},{"line_number":15,"context_line":"to prove that scheeduling works as expected."},{"line_number":16,"context_line":"- Fix some share group test attributes from \u0027only API involved\u0027 to"},{"line_number":17,"context_line":"  \u0027API and Backend are involved\u0027, because it is so indeed."},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"dfeb2761_bbffeb32","line":15,"range":{"start_line":15,"start_character":14,"end_line":15,"end_character":25},"in_reply_to":"ffe62b97_62c2f935","updated":"2017-04-03 16:59:32.000000000","message":"Done","commit_id":"a1e57c60279d64c9747d377b953a3e7cfbc03440"}],"manila/scheduler/utils.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2cf5a38352376acc0eee59b5fa37237df859595b","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    extra_specs \u003d share_type.get(\u0027extra_specs\u0027, {})"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    share_group_type \u003d properties.get(\u0027share_group_type\u0027, {})"},{"line_number":66,"context_line":"    group_specs \u003d share_type.get(\u0027group_specs\u0027, {})"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    request_spec \u003d properties.get(\u0027request_spec\u0027, {})"},{"line_number":69,"context_line":"    share_stats \u003d request_spec.get(\u0027resource_properties\u0027, {})"}],"source_content_type":"text/x-python","patch_set":7,"id":"ffe62b97_4231350b","line":66,"range":{"start_line":66,"start_character":18,"end_line":66,"end_character":28},"updated":"2017-03-25 03:01:37.000000000","message":"s/ share_type / share_group_type","commit_id":"a1e57c60279d64c9747d377b953a3e7cfbc03440"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"507d053e1905ef543e97105326cf106cf1581a58","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    extra_specs \u003d share_type.get(\u0027extra_specs\u0027, {})"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    share_group_type \u003d properties.get(\u0027share_group_type\u0027, {})"},{"line_number":66,"context_line":"    group_specs \u003d share_type.get(\u0027group_specs\u0027, {})"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    request_spec \u003d properties.get(\u0027request_spec\u0027, {})"},{"line_number":69,"context_line":"    share_stats \u003d request_spec.get(\u0027resource_properties\u0027, {})"}],"source_content_type":"text/x-python","patch_set":7,"id":"dfeb2761_1bd257d3","line":66,"range":{"start_line":66,"start_character":18,"end_line":66,"end_character":28},"in_reply_to":"ffe62b97_4231350b","updated":"2017-04-03 16:59:32.000000000","message":"Done","commit_id":"a1e57c60279d64c9747d377b953a3e7cfbc03440"}],"manila_tempest_tests/config.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2cfe291af08d60c89c9862a11e23d3faf58b1265","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                     \"and will be used for setting up custom share type. \""},{"line_number":114,"context_line":"                     \"Defaults to the value of run_revert_to_snapshot_tests.\"),"},{"line_number":115,"context_line":"    cfg.StrOpt(\"capability_sg_consistent_snapshot_support\","},{"line_number":116,"context_line":"               choices\u003d[\"host\", \"pool\", None],"},{"line_number":117,"context_line":"               help\u003d\"Backend capability to create consistent snapshots of \""},{"line_number":118,"context_line":"                    \"share group members. Will be used with creation \""},{"line_number":119,"context_line":"                    \"of new share group types as group spec.\"),"}],"source_content_type":"text/x-python","patch_set":7,"id":"ffe62b97_46aa57d2","line":116,"range":{"start_line":116,"start_character":40,"end_line":116,"end_character":44},"updated":"2017-03-26 17:14:01.000000000","message":"What does None mean?\n\nAlso, instead of introducing yet another capability option, you should read the capability from the scheduler stats to determine what to send in your test.","commit_id":"a1e57c60279d64c9747d377b953a3e7cfbc03440"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"507d053e1905ef543e97105326cf106cf1581a58","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                     \"and will be used for setting up custom share type. \""},{"line_number":114,"context_line":"                     \"Defaults to the value of run_revert_to_snapshot_tests.\"),"},{"line_number":115,"context_line":"    cfg.StrOpt(\"capability_sg_consistent_snapshot_support\","},{"line_number":116,"context_line":"               choices\u003d[\"host\", \"pool\", None],"},{"line_number":117,"context_line":"               help\u003d\"Backend capability to create consistent snapshots of \""},{"line_number":118,"context_line":"                    \"share group members. Will be used with creation \""},{"line_number":119,"context_line":"                    \"of new share group types as group spec.\"),"}],"source_content_type":"text/x-python","patch_set":7,"id":"dfeb2761_bb848bb2","line":116,"range":{"start_line":116,"start_character":40,"end_line":116,"end_character":44},"in_reply_to":"ffe62b97_46aa57d2","updated":"2017-04-03 16:59:32.000000000","message":"\"None\" is one of allowed values for this group spec. I should not use scheduler stats, because I can have hosts of all types. Keeping as is.","commit_id":"a1e57c60279d64c9747d377b953a3e7cfbc03440"}],"manila_tempest_tests/tests/api/base.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"78b01a21996c430533f08f2e2fb8b57181fb4856","unresolved":false,"context_lines":[{"line_number":598,"context_line":""},{"line_number":599,"context_line":"        # Use special \u0027make_empty\u0027 key for \"group_specs\" argument, to be able"},{"line_number":600,"context_line":"        # to create share group types without any default group specs."},{"line_number":601,"context_line":"        if group_specs \u003d\u003d \u0027make_empty\u0027:"},{"line_number":602,"context_line":"            group_specs \u003d None"},{"line_number":603,"context_line":"        else:"},{"line_number":604,"context_line":"            if group_specs is None:"},{"line_number":605,"context_line":"                group_specs \u003d {}"}],"source_content_type":"text/x-python","patch_set":11,"id":"ff0f0b1f_35901c95","line":602,"range":{"start_line":601,"start_character":0,"end_line":602,"end_character":30},"updated":"2017-05-24 14:12:10.000000000","message":"Why can\u0027t group_specs be set to None directly?  I don\u0027t see why \u0027make_empty\u0027 needs to be introduced.  Even if you have to introduce this, \u0027make_empty\u0027 should be defined as a constant.","commit_id":"21befb97ea2c35604964d27215dc8c153fe68d70"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fa0a455f2ae88ba50e52821cac2b59c7a196776f","unresolved":false,"context_lines":[{"line_number":598,"context_line":""},{"line_number":599,"context_line":"        # Use special \u0027make_empty\u0027 key for \"group_specs\" argument, to be able"},{"line_number":600,"context_line":"        # to create share group types without any default group specs."},{"line_number":601,"context_line":"        if group_specs \u003d\u003d \u0027make_empty\u0027:"},{"line_number":602,"context_line":"            group_specs \u003d None"},{"line_number":603,"context_line":"        else:"},{"line_number":604,"context_line":"            if group_specs is None:"},{"line_number":605,"context_line":"                group_specs \u003d {}"}],"source_content_type":"text/x-python","patch_set":11,"id":"df140735_8b901d45","line":602,"range":{"start_line":601,"start_character":0,"end_line":602,"end_character":30},"in_reply_to":"ff0f0b1f_35901c95","updated":"2017-06-02 14:50:53.000000000","message":"Done","commit_id":"21befb97ea2c35604964d27215dc8c153fe68d70"}]}
