)]}'
{"devstack/plugin.sh":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"4096a61c589f52eb55a12e3da229b64d6882e010","unresolved":false,"context_lines":[{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    if is_service_enabled m-shr; then"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"        if [[ ! $(systemctl is-active nfs-ganesha.service) \u003d\u003d \u0027active\u0027 ]]; then"},{"line_number":665,"context_line":"            _install_nfs_and_samba"},{"line_number":666,"context_line":"        fi"},{"line_number":667,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"bff0334d_dca4290b","line":664,"range":{"start_line":664,"start_character":11,"end_line":664,"end_character":74},"updated":"2017-04-06 04:38:23.000000000","message":"redundant square brackets","commit_id":"ab778b3124699dc8f022dc8634e0b73b457c332e"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"5118a9b6f177aa6d02f99487e4b2fe50033cf2ef","unresolved":false,"context_lines":[{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    if is_service_enabled m-shr; then"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"        if [[ ! $(systemctl is-active nfs-ganesha.service) \u003d\u003d \u0027active\u0027 ]]; then"},{"line_number":665,"context_line":"            _install_nfs_and_samba"},{"line_number":666,"context_line":"        fi"},{"line_number":667,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"bff0334d_4ca3a79f","line":664,"range":{"start_line":664,"start_character":11,"end_line":664,"end_character":74},"in_reply_to":"bff0334d_1eaa65d1","updated":"2017-04-06 20:13:54.000000000","message":"I see, thanks for the reference.  It does say that many errors can be avoided by using them too though.  I guess I don\u0027t fully understand when to use them and when not.","commit_id":"ab778b3124699dc8f022dc8634e0b73b457c332e"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"c029a2ebfb916063f30a1a2264acabab561b2a25","unresolved":false,"context_lines":[{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    if is_service_enabled m-shr; then"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"        if [[ ! $(systemctl is-active nfs-ganesha.service) \u003d\u003d \u0027active\u0027 ]]; then"},{"line_number":665,"context_line":"            _install_nfs_and_samba"},{"line_number":666,"context_line":"        fi"},{"line_number":667,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"bff0334d_1eaa65d1","line":664,"range":{"start_line":664,"start_character":11,"end_line":664,"end_character":74},"in_reply_to":"bff0334d_72709973","updated":"2017-04-06 19:02:32.000000000","message":"Technically, zhongjun is correct. The test brackets are not strictly necessary (check http://www.tldp.org/LDP/abs/html/testconstructs.html#DBLBRACKETS). Still, I think it is a good practice.","commit_id":"ab778b3124699dc8f022dc8634e0b73b457c332e"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"fa20eed852d09863c8e0fa9979e2935381c4d680","unresolved":false,"context_lines":[{"line_number":661,"context_line":""},{"line_number":662,"context_line":"    if is_service_enabled m-shr; then"},{"line_number":663,"context_line":""},{"line_number":664,"context_line":"        if [[ ! $(systemctl is-active nfs-ganesha.service) \u003d\u003d \u0027active\u0027 ]]; then"},{"line_number":665,"context_line":"            _install_nfs_and_samba"},{"line_number":666,"context_line":"        fi"},{"line_number":667,"context_line":""}],"source_content_type":"text/x-sh","patch_set":2,"id":"bff0334d_72709973","line":664,"range":{"start_line":664,"start_character":11,"end_line":664,"end_character":74},"in_reply_to":"bff0334d_dca4290b","updated":"2017-04-06 10:51:12.000000000","message":"\u0027[[\u0027 is the extended test \"command\", not redundant use of the un-extended test command.  And actually it\u0027s a bash keyword rather than a command :D  See e.g. http://www.tldp.org/LDP/abs/html/testconstructs.html","commit_id":"ab778b3124699dc8f022dc8634e0b73b457c332e"}]}