)]}'
{"manila/share_group/api.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9de0b68ec72aa446d5b720fdb0986ad89c3deea5","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                for s in original_share_group[\u0027share_types\u0027]]"},{"line_number":75,"context_line":"            share_network_id \u003d original_share_group[\u0027share_network_id\u0027]"},{"line_number":76,"context_line":"            share_server_id \u003d original_share_group[\u0027share_server_id\u0027]"},{"line_number":77,"context_line":"            availability_zone_id \u003d original_share_group[\u0027availability_zone_id\u0027]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        # Get share_type_objects"},{"line_number":80,"context_line":"        share_type_objects \u003d []"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f044301_06759095","line":77,"range":{"start_line":77,"start_character":3,"end_line":77,"end_character":79},"updated":"2017-05-05 06:36:21.000000000","message":"How about if we input availability_zone_id in create function(code line 53), the availability_zone_id  value will be instead by original_share_group[\u0027availability_zone_id\u0027], and user cannot get any warning from this change. Is it ok?","commit_id":"480fb3113b4eb691d181b47fe8eedb5808a90b7c"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"948eddcc6f292e8e4a9307d1671f27edf70b64de","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                for s in original_share_group[\u0027share_types\u0027]]"},{"line_number":75,"context_line":"            share_network_id \u003d original_share_group[\u0027share_network_id\u0027]"},{"line_number":76,"context_line":"            share_server_id \u003d original_share_group[\u0027share_server_id\u0027]"},{"line_number":77,"context_line":"            availability_zone_id \u003d original_share_group[\u0027availability_zone_id\u0027]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        # Get share_type_objects"},{"line_number":80,"context_line":"        share_type_objects \u003d []"}],"source_content_type":"text/x-python","patch_set":9,"id":"ff0f0b1f_03162d56","line":77,"range":{"start_line":77,"start_character":3,"end_line":77,"end_character":79},"in_reply_to":"1f013ff3_a056d905","updated":"2017-05-23 12:08:19.000000000","message":"Fixed here: https://review.openstack.org/#/c/447070/10..11/manila/api/v2/share_groups.py\n\nIn the same way as it is done for other keys that are redefined.","commit_id":"480fb3113b4eb691d181b47fe8eedb5808a90b7c"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d7ad1460a03bd63241f104d3c24620a1c917ae3b","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                for s in original_share_group[\u0027share_types\u0027]]"},{"line_number":75,"context_line":"            share_network_id \u003d original_share_group[\u0027share_network_id\u0027]"},{"line_number":76,"context_line":"            share_server_id \u003d original_share_group[\u0027share_server_id\u0027]"},{"line_number":77,"context_line":"            availability_zone_id \u003d original_share_group[\u0027availability_zone_id\u0027]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        # Get share_type_objects"},{"line_number":80,"context_line":"        share_type_objects \u003d []"}],"source_content_type":"text/x-python","patch_set":9,"id":"3f044301_27083190","line":77,"range":{"start_line":77,"start_character":3,"end_line":77,"end_character":79},"in_reply_to":"3f044301_06759095","updated":"2017-05-10 13:45:13.000000000","message":"Code block on lines 62-77 redefines provided values for \"source\" share group snapshot values. So, it is not ok, it will be bug.","commit_id":"480fb3113b4eb691d181b47fe8eedb5808a90b7c"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2f7d8f2fda41e3363cf7dd13e857b3d3ead50612","unresolved":false,"context_lines":[{"line_number":74,"context_line":"                for s in original_share_group[\u0027share_types\u0027]]"},{"line_number":75,"context_line":"            share_network_id \u003d original_share_group[\u0027share_network_id\u0027]"},{"line_number":76,"context_line":"            share_server_id \u003d original_share_group[\u0027share_server_id\u0027]"},{"line_number":77,"context_line":"            availability_zone_id \u003d original_share_group[\u0027availability_zone_id\u0027]"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        # Get share_type_objects"},{"line_number":80,"context_line":"        share_type_objects \u003d []"}],"source_content_type":"text/x-python","patch_set":9,"id":"1f013ff3_a056d905","line":77,"range":{"start_line":77,"start_character":3,"end_line":77,"end_character":79},"in_reply_to":"3f044301_27083190","updated":"2017-05-23 01:42:15.000000000","message":"Do we need to let user know it(availability_zone) doesn\u0027t work if the user input availability_zone  and original_share_group in create share group API?  It(availability_zone) will redefines provided values for \"source\" share group snapshot values.","commit_id":"480fb3113b4eb691d181b47fe8eedb5808a90b7c"}]}
