)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"71bc020220fa2e3bd5182969bf024c0a8d57e1fb","unresolved":false,"context_lines":[{"line_number":10,"context_line":"should be shown to the user. And then the user could determine which"},{"line_number":11,"context_line":"is the recent access rule. As the design, the recent access-allow"},{"line_number":12,"context_line":"rule caused the error access-status of share instance."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Iad6070d60ec77b7de9cc9679cfa7478876084da1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7ffa3b31_1e0d023e","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":0},"updated":"2017-04-14 07:22:03.000000000","message":"Add flag in this message doc.\nAPIImpact\n\nCloses-Bug: #.....","commit_id":"b105a25d442b03c27463d4a8592c7efd4114e0e1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7e5f060ab83318e7e481a9756da6fa109c48c2fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"5ff73747_7ab6478d","updated":"2017-05-02 23:07:36.000000000","message":"This change is missing an API reference update. \nPlease add the two fields that you added to:\n\n api-ref/source/parameters.yaml\n\nand, add the API changes to:\n\n api-ref/source/share-actions.inc","commit_id":"7c4a2344180ddd85c270c221bc442bab206207b8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7e5f060ab83318e7e481a9756da6fa109c48c2fa","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change to share access list API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we do share-access-list, the \u0027create_at\u0027 and \u0027updated_at\u0027 time"},{"line_number":10,"context_line":"should be shown to the user. And then the user could determine which"},{"line_number":11,"context_line":"is the recent access rule. As the design, the recent access-allow"},{"line_number":12,"context_line":"rule caused the error access-status of share instance."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5ff73747_9af35374","line":9,"range":{"start_line":9,"start_character":35,"end_line":9,"end_character":61},"updated":"2017-05-02 23:07:36.000000000","message":"\"created_at\" and \"updated_at\"","commit_id":"7c4a2344180ddd85c270c221bc442bab206207b8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7e5f060ab83318e7e481a9756da6fa109c48c2fa","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change to share access list API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we do share-access-list, the \u0027create_at\u0027 and \u0027updated_at\u0027 time"},{"line_number":10,"context_line":"should be shown to the user. And then the user could determine which"},{"line_number":11,"context_line":"is the recent access rule. As the design, the recent access-allow"},{"line_number":12,"context_line":"rule caused the error access-status of share instance."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5ff73747_baee0f89","line":9,"range":{"start_line":9,"start_character":11,"end_line":9,"end_character":28},"updated":"2017-05-02 23:07:36.000000000","message":"nit: this isn\u0027t a CLI or an API, either use: `manila access-list` or the `access-list` API","commit_id":"7c4a2344180ddd85c270c221bc442bab206207b8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7e5f060ab83318e7e481a9756da6fa109c48c2fa","unresolved":false,"context_lines":[{"line_number":10,"context_line":"should be shown to the user. And then the user could determine which"},{"line_number":11,"context_line":"is the recent access rule. As the design, the recent access-allow"},{"line_number":12,"context_line":"rule caused the error access-status of share instance."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1682795"},{"line_number":15,"context_line":"Change-Id: Iad6070d60ec77b7de9cc9679cfa7478876084da1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5ff73747_7a9d2709","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":0},"updated":"2017-05-02 23:07:36.000000000","message":"please add the \"APIImpact\" flag:\n\nhttps://docs.openstack.org/developer/manila/devref/commit_message_tags.html","commit_id":"7c4a2344180ddd85c270c221bc442bab206207b8"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"3013204d2edddbfc4b5fab5cd95daf83064714e8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Change to share access list API"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When we do manila access-list, the \u0027create_at\u0027 and \u0027updated_at\u0027 time"},{"line_number":10,"context_line":"should be shown to the user. And then the user could determine which"},{"line_number":11,"context_line":"is the recent access rule. As the design, the recent access-allow"},{"line_number":12,"context_line":"rule caused the error access-status of share instance."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3f044301_b99aa86b","line":9,"range":{"start_line":9,"start_character":35,"end_line":9,"end_character":46},"updated":"2017-05-04 03:09:03.000000000","message":"s/create_at/created_at","commit_id":"594e1014a8333167107dbd425de54adb239f6865"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"18686f7f5ee5993fb479e64bc8ffaac367ea6cc1","unresolved":false,"context_lines":[{"line_number":11,"context_line":"is the recent access rule. As the design, the recent access-allow"},{"line_number":12,"context_line":"rule caused the error access-status of share instance."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"APIImpact: https://docs.openstack.org/developer/manila/devref/commit_message_tags.html"},{"line_number":15,"context_line":"Closes-Bug: #1682795"},{"line_number":16,"context_line":"Change-Id: Iad6070d60ec77b7de9cc9679cfa7478876084da1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"5ff73747_0f75a898","line":14,"range":{"start_line":14,"start_character":11,"end_line":14,"end_character":86},"updated":"2017-05-04 18:30:07.000000000","message":"In other words, the link is not necessary, the word \"APIImpact\" must be on a line by its own.","commit_id":"594e1014a8333167107dbd425de54adb239f6865"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"3013204d2edddbfc4b5fab5cd95daf83064714e8","unresolved":false,"context_lines":[{"line_number":11,"context_line":"is the recent access rule. As the design, the recent access-allow"},{"line_number":12,"context_line":"rule caused the error access-status of share instance."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"APIImpact: https://docs.openstack.org/developer/manila/devref/commit_message_tags.html"},{"line_number":15,"context_line":"Closes-Bug: #1682795"},{"line_number":16,"context_line":"Change-Id: Iad6070d60ec77b7de9cc9679cfa7478876084da1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"3f044301_5983a405","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":86},"updated":"2017-05-04 03:09:03.000000000","message":"s/APIImpact: https://docs.openstack.org/developer/manila/devref/commit_message_tags.html/ APIImpact","commit_id":"594e1014a8333167107dbd425de54adb239f6865"}],"manila/api/openstack/rest_api_version_history.rst":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"80095f35bb6795c6b34bea84cc2e71337c2a08d9","unresolved":false,"context_lines":[{"line_number":194,"context_line":""},{"line_number":195,"context_line":"2.33"},{"line_number":196,"context_line":"----"},{"line_number":197,"context_line":"  Added \u0027created_at\u0027 and \u0027updated_at\u0027 to filter results of share access list API."}],"source_content_type":"text/x-rst","patch_set":6,"id":"7ffa3b31_599a5d14","line":197,"range":{"start_line":197,"start_character":65,"end_line":197,"end_character":81},"updated":"2017-04-17 12:00:56.000000000","message":"please don\u0027t go beyond 79 chars","commit_id":"7518fca4b471ba3a827e18cc06c106972321ec47"}],"manila/api/views/share_accesses.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ecbe6fe44b15a7073d0a5e7e61f48221ed054219","unresolved":false,"context_lines":[{"line_number":40,"context_line":"            \u0027access_to\u0027: access.get(\u0027access_to\u0027),"},{"line_number":41,"context_line":"            \u0027access_type\u0027: access.get(\u0027access_type\u0027),"},{"line_number":42,"context_line":"            \u0027state\u0027: access.get(\u0027state\u0027),"},{"line_number":43,"context_line":"            \u0027created_at\u0027:access.get(\u0027created_at\u0027),"},{"line_number":44,"context_line":"            \u0027updated_at\u0027:access.get(\u0027updated_at\u0027),"},{"line_number":45,"context_line":"        }"},{"line_number":46,"context_line":"        self.update_versioned_resource_dict("},{"line_number":47,"context_line":"            request, access_dict, access)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_9e30f209","line":44,"range":{"start_line":43,"start_character":11,"end_line":44,"end_character":50},"updated":"2017-04-14 07:19:21.000000000","message":"This is also need to microversion\n\"\"\"\"\"\"\"\n@common.ViewBuilder.versioned_method(\"2.23\")\ndef add_access_....(self, context, access_dict, access):\naccess_dict[\u0027created_at\u0027] \u003d access.get(\u0027created_at\u0027)\naccess_dict[\u0027updated_at\u0027] \u003d access.get(\u0027updated_at\u0027)\n\"\"\"\"\"\"\"\n\nhttps://review.openstack.org/#/c/298115/22/manila/api/views/shares.py","commit_id":"b105a25d442b03c27463d4a8592c7efd4114e0e1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"18686f7f5ee5993fb479e64bc8ffaac367ea6cc1","unresolved":false,"context_lines":[{"line_number":25,"context_line":"    _detail_version_modifiers \u003d ["},{"line_number":26,"context_line":"        \"add_access_key\","},{"line_number":27,"context_line":"        \"translate_transitional_statuses\","},{"line_number":28,"context_line":"        \"add_create_at_and_updated_at\","},{"line_number":29,"context_line":"    ]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"    def list_view(self, request, accesses):"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f044301_2f1ab17c","line":28,"range":{"start_line":28,"start_character":13,"end_line":28,"end_character":19},"updated":"2017-05-04 18:30:07.000000000","message":"created","commit_id":"594e1014a8333167107dbd425de54adb239f6865"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"18686f7f5ee5993fb479e64bc8ffaac367ea6cc1","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        access_dict[\u0027access_key\u0027] \u003d access.get(\u0027access_key\u0027)"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    @common.ViewBuilder.versioned_method(\"2.33\")"},{"line_number":68,"context_line":"    def add_create_at_and_updated_at(self, context, access_dict, access):"},{"line_number":69,"context_line":"        access_dict[\u0027created_at\u0027] \u003d access.get(\u0027created_at\u0027)"},{"line_number":70,"context_line":"        access_dict[\u0027updated_at\u0027] \u003d access.get(\u0027updated_at\u0027)"},{"line_number":71,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"3f044301_ef13a965","line":68,"range":{"start_line":68,"start_character":12,"end_line":68,"end_character":18},"updated":"2017-05-04 18:30:07.000000000","message":"created","commit_id":"594e1014a8333167107dbd425de54adb239f6865"}],"manila/tests/api/v2/test_shares.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"80095f35bb6795c6b34bea84cc2e71337c2a08d9","unresolved":false,"context_lines":[{"line_number":1933,"context_line":"            \u0027clemsontigers\u0027, \u0027rw\u0027)"},{"line_number":1934,"context_line":""},{"line_number":1935,"context_line":"    @ddt.data(*itertools.product("},{"line_number":1936,"context_line":"        set([\u00272.33\u0027, api_version._MAX_API_VERSION]),"},{"line_number":1937,"context_line":"        (constants.SHARE_INSTANCE_RULES_ERROR,"},{"line_number":1938,"context_line":"         constants.SHARE_INSTANCE_RULES_SYNCING, constants.STATUS_ACTIVE)))"},{"line_number":1939,"context_line":"    @ddt.unpack"}],"source_content_type":"text/x-python","patch_set":6,"id":"7ffa3b31_a44a5452","line":1936,"range":{"start_line":1936,"start_character":16,"end_line":1936,"end_character":18},"updated":"2017-04-17 12:00:56.000000000","message":"this change is not necessary as you already added the condition below.","commit_id":"7518fca4b471ba3a827e18cc06c106972321ec47"}],"manila_tempest_tests/tests/api/test_rules.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7e5f060ab83318e7e481a9756da6fa109c48c2fa","unresolved":false,"context_lines":[{"line_number":499,"context_line":"            self.assertEqual(\"new\", rule[\u0027state\u0027])"},{"line_number":500,"context_line":"        else:"},{"line_number":501,"context_line":"            self.assertEqual(\"queued_to_apply\", rule[\u0027state\u0027])"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"        if utils.is_microversion_eq(version, \u00271.0\u0027):"},{"line_number":504,"context_line":"            self.shares_client.wait_for_access_rule_status("},{"line_number":505,"context_line":"                self.share[\"id\"], rule[\"id\"], \"active\")"}],"source_content_type":"text/x-python","patch_set":9,"id":"5ff73747_fa1ff7b4","line":502,"range":{"start_line":502,"start_character":0,"end_line":502,"end_character":0},"updated":"2017-05-02 23:07:36.000000000","message":"Add validation for the two fields to be present in \"rule\"... That will validate the create access rule API.\n\nLine 525-526 currently validate that the fields are available with the \"list rules\" API","commit_id":"7c4a2344180ddd85c270c221bc442bab206207b8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"18686f7f5ee5993fb479e64bc8ffaac367ea6cc1","unresolved":false,"context_lines":[{"line_number":497,"context_line":""},{"line_number":498,"context_line":"        # verify added rule keys since 2.33 when create rule"},{"line_number":499,"context_line":"        if utils.is_microversion_ge(version, \u00272.33\u0027):"},{"line_number":500,"context_line":"            self.assertIn(\u0027created_at\u0027, rule.keys())"},{"line_number":501,"context_line":"            self.assertIn(\u0027updated_at\u0027, rule.keys())"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"        # rules must start out in \u0027new\u0027 until 2.28 \u0026 \u0027queued_to_apply\u0027 after"}],"source_content_type":"text/x-python","patch_set":11,"id":"3f044301_5a193977","line":500,"range":{"start_line":500,"start_character":40,"end_line":500,"end_character":51},"updated":"2017-05-04 18:30:07.000000000","message":"Not py3 compatible... you\u0027ll get a view instead of a list that you\u0027re expecting, please change this to list(rule.keys()) to force that translation.","commit_id":"594e1014a8333167107dbd425de54adb239f6865"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"18686f7f5ee5993fb479e64bc8ffaac367ea6cc1","unresolved":false,"context_lines":[{"line_number":499,"context_line":"        if utils.is_microversion_ge(version, \u00272.33\u0027):"},{"line_number":500,"context_line":"            self.assertIn(\u0027created_at\u0027, rule.keys())"},{"line_number":501,"context_line":"            self.assertIn(\u0027updated_at\u0027, rule.keys())"},{"line_number":502,"context_line":""},{"line_number":503,"context_line":"        # rules must start out in \u0027new\u0027 until 2.28 \u0026 \u0027queued_to_apply\u0027 after"},{"line_number":504,"context_line":"        if utils.is_microversion_le(version, \"2.27\"):"},{"line_number":505,"context_line":"            self.assertEqual(\"new\", rule[\u0027state\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"5ff73747_2f186473","line":502,"range":{"start_line":502,"start_character":0,"end_line":502,"end_character":0},"updated":"2017-05-04 18:30:07.000000000","message":"else?\n\nPlease verify that these keys are not in the response.. \n\n  self.assertNotIn(\u0027created_at\u0027, list(rule.keys()))","commit_id":"594e1014a8333167107dbd425de54adb239f6865"}],"releasenotes/notes/bug-1682795-share-access-list-api-5b1e86218959f796.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"7e5f060ab83318e7e481a9756da6fa109c48c2fa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added \u0027created_at\u0027 and \u0027updated_at\u0027 to filter results of share"},{"line_number":4,"context_line":"    access list API."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5ff73747_9aca3318","line":4,"range":{"start_line":3,"start_character":43,"end_line":4,"end_character":20},"updated":"2017-05-02 23:07:36.000000000","message":"This API does not support filtering or pagination... (That needs to be enhanced)\nPlease rewrite this note, perhaps like follows:\n\n - Beginning in API version 2.33, share access APIs return\n   \"created_at\" and \"updated_at\" for each access rule as part\n   of the JSON response.","commit_id":"7c4a2344180ddd85c270c221bc442bab206207b8"},{"author":{"_account_id":17430,"name":"yangweiwei","email":"yangweiwei@cmss.chinamobile.com","username":"yangweiwei"},"change_message_id":"65f2252a30b80a4f84ff51b1462c1bf430962504","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added \u0027created_at\u0027 and \u0027updated_at\u0027 to filter results of share"},{"line_number":4,"context_line":"    access list API."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"5ff73747_40ca7a4f","line":4,"range":{"start_line":3,"start_character":43,"end_line":4,"end_character":20},"in_reply_to":"5ff73747_9aca3318","updated":"2017-05-03 01:02:41.000000000","message":"Ok, thanks, I will rewrite it.","commit_id":"7c4a2344180ddd85c270c221bc442bab206207b8"}]}
