)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"138e11f3c7044d5c19d1b6a6deced7adbfb1ce08","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Change ensure share to make startup faster"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This driver interface is currently being used wrong and needs a rewrite."},{"line_number":10,"context_line":"This spec adds the ability to solve the potential problem of slow start up,"},{"line_number":11,"context_line":"and deal with non-user-initiated state changes to shares."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implement BP ensure-share"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":29,"id":"ff346bd7_e6fe38ad","line":10,"range":{"start_line":10,"start_character":72,"end_line":10,"end_character":75},"updated":"2017-07-23 01:02:41.000000000","message":"Wrap up at 72 chars.","commit_id":"d704b1c803f4b31b3ce16fdcfc97d728ac024bca"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"55227cbde238e102f16551a7fa9b4ce097d971dc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Change ensure share to make startup faster"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This driver interface is currently being used wrong and needs a rewrite."},{"line_number":10,"context_line":"This spec adds the ability to solve the potential problem of slow start up,"},{"line_number":11,"context_line":"and deal with non-user-initiated state changes to shares."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implement BP ensure-share"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":29,"id":"ff346bd7_7b189a80","line":10,"range":{"start_line":10,"start_character":72,"end_line":10,"end_character":75},"in_reply_to":"ff346bd7_e6fe38ad","updated":"2017-07-24 02:30:29.000000000","message":"Done","commit_id":"d704b1c803f4b31b3ce16fdcfc97d728ac024bca"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"df074229c090bf54270fca2557848de6a736f068","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Change ensure share to make startup faster"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This driver interface is currently being used wrong and needs a rewrite."},{"line_number":10,"context_line":"This spec adds the ability to solve the potential problem of slow start"},{"line_number":11,"context_line":"up, and deal with non-user-initiated state changes to shares."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implement BP ensure-share"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":31,"id":"ff346bd7_10a33602","line":10,"range":{"start_line":10,"start_character":5,"end_line":10,"end_character":9},"updated":"2017-07-26 20:54:49.000000000","message":"change?  patch?","commit_id":"2a05d672ae18a3ce53885f6e0362b364e76538e2"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"df074229c090bf54270fca2557848de6a736f068","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This driver interface is currently being used wrong and needs a rewrite."},{"line_number":10,"context_line":"This spec adds the ability to solve the potential problem of slow start"},{"line_number":11,"context_line":"up, and deal with non-user-initiated state changes to shares."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implement BP ensure-share"},{"line_number":14,"context_line":"Change-Id: I704591446cd5f6ad2293c5a18eccf5412d488baf"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":31,"id":"ff346bd7_10f1f601","line":12,"updated":"2017-07-26 20:54:49.000000000","message":"DocImpact?  I think we need devref since driver authors will need to know how to interact with this feature.","commit_id":"2a05d672ae18a3ce53885f6e0362b364e76538e2"}],"manila/db/sqlalchemy/api.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8bdd34b93ec2c95fb4c67b80fbb9352e2aa14f4c","unresolved":false,"context_lines":[{"line_number":4895,"context_line":""},{"line_number":4896,"context_line":"    return result"},{"line_number":4897,"context_line":""},{"line_number":4898,"context_line":""},{"line_number":4899,"context_line":"def backend_info_create(context, host, value):"},{"line_number":4900,"context_line":"    session \u003d get_session()"},{"line_number":4901,"context_line":"    with session.begin():"}],"source_content_type":"text/x-python","patch_set":38,"id":"ff82abbf_afcaf34a","line":4898,"updated":"2017-11-25 14:08:18.000000000","message":"@require_context","commit_id":"2674740e2878d8771ae911fc25d4cbaac9d3f859"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d0d837d7abc0201f7c39fa4619e2fa1dddc82f79","unresolved":false,"context_lines":[{"line_number":4895,"context_line":""},{"line_number":4896,"context_line":"    return result"},{"line_number":4897,"context_line":""},{"line_number":4898,"context_line":""},{"line_number":4899,"context_line":"def backend_info_create(context, host, value):"},{"line_number":4900,"context_line":"    session \u003d get_session()"},{"line_number":4901,"context_line":"    with session.begin():"}],"source_content_type":"text/x-python","patch_set":38,"id":"ff82abbf_20ed8d8a","line":4898,"in_reply_to":"ff82abbf_afcaf34a","updated":"2017-11-27 02:15:26.000000000","message":"Done","commit_id":"2674740e2878d8771ae911fc25d4cbaac9d3f859"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8bdd34b93ec2c95fb4c67b80fbb9352e2aa14f4c","unresolved":false,"context_lines":[{"line_number":4905,"context_line":"        info_ref.save(session)"},{"line_number":4906,"context_line":"        return info_ref"},{"line_number":4907,"context_line":""},{"line_number":4908,"context_line":""},{"line_number":4909,"context_line":"def backend_info_update(context, host, value\u003dNone, delete_existing\u003dFalse):"},{"line_number":4910,"context_line":"    \"\"\"Remove backend info for host name.\"\"\""},{"line_number":4911,"context_line":"    session \u003d get_session()"}],"source_content_type":"text/x-python","patch_set":38,"id":"ff82abbf_4fc32739","line":4908,"updated":"2017-11-25 14:08:18.000000000","message":"@require_context","commit_id":"2674740e2878d8771ae911fc25d4cbaac9d3f859"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d0d837d7abc0201f7c39fa4619e2fa1dddc82f79","unresolved":false,"context_lines":[{"line_number":4905,"context_line":"        info_ref.save(session)"},{"line_number":4906,"context_line":"        return info_ref"},{"line_number":4907,"context_line":""},{"line_number":4908,"context_line":""},{"line_number":4909,"context_line":"def backend_info_update(context, host, value\u003dNone, delete_existing\u003dFalse):"},{"line_number":4910,"context_line":"    \"\"\"Remove backend info for host name.\"\"\""},{"line_number":4911,"context_line":"    session \u003d get_session()"}],"source_content_type":"text/x-python","patch_set":38,"id":"ff82abbf_c005c147","line":4908,"in_reply_to":"ff82abbf_4fc32739","updated":"2017-11-27 02:15:26.000000000","message":"Done","commit_id":"2674740e2878d8771ae911fc25d4cbaac9d3f859"}],"manila/share/driver.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"035f2619658e081de84e7cd247618fdc9e2c631f","unresolved":false,"context_lines":[{"line_number":2429,"context_line":"        Driver can use this method to get the special configuration info and"},{"line_number":2430,"context_line":"        return for assessment."},{"line_number":2431,"context_line":""},{"line_number":2432,"context_line":"        :return: A dictionary containing driver-specific info."},{"line_number":2433,"context_line":""},{"line_number":2434,"context_line":"            Example::"},{"line_number":2435,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"1f1a1f67_0addd8de","line":2432,"range":{"start_line":2432,"start_character":8,"end_line":2432,"end_character":16},"updated":"2017-07-19 21:04:08.000000000","message":":returns:","commit_id":"7139fb1d10c3a6ee3bef8a181dec61ce8c1dc163"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d7fdcf16d66311a010e0f309a390cc6ef1358582","unresolved":false,"context_lines":[{"line_number":2429,"context_line":"        Driver can use this method to get the special configuration info and"},{"line_number":2430,"context_line":"        return for assessment."},{"line_number":2431,"context_line":""},{"line_number":2432,"context_line":"        :return: A dictionary containing driver-specific info."},{"line_number":2433,"context_line":""},{"line_number":2434,"context_line":"            Example::"},{"line_number":2435,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"1f1a1f67_ef2986e5","line":2432,"range":{"start_line":2432,"start_character":8,"end_line":2432,"end_character":16},"in_reply_to":"1f1a1f67_0addd8de","updated":"2017-07-20 03:00:08.000000000","message":"Done","commit_id":"7139fb1d10c3a6ee3bef8a181dec61ce8c1dc163"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"035f2619658e081de84e7cd247618fdc9e2c631f","unresolved":false,"context_lines":[{"line_number":2450,"context_line":"        the shares if it changes. To do that, a dictionary of shares should"},{"line_number":2451,"context_line":"        be returned. :shares: None or a list of all shares for updates."},{"line_number":2452,"context_line":""},{"line_number":2453,"context_line":"        :return: None or a dictionary of updates in the format."},{"line_number":2454,"context_line":""},{"line_number":2455,"context_line":"            Example::"},{"line_number":2456,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"1f1a1f67_ead73cbe","line":2453,"range":{"start_line":2453,"start_character":8,"end_line":2453,"end_character":16},"updated":"2017-07-19 21:04:08.000000000","message":":returns:","commit_id":"7139fb1d10c3a6ee3bef8a181dec61ce8c1dc163"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d7fdcf16d66311a010e0f309a390cc6ef1358582","unresolved":false,"context_lines":[{"line_number":2450,"context_line":"        the shares if it changes. To do that, a dictionary of shares should"},{"line_number":2451,"context_line":"        be returned. :shares: None or a list of all shares for updates."},{"line_number":2452,"context_line":""},{"line_number":2453,"context_line":"        :return: None or a dictionary of updates in the format."},{"line_number":2454,"context_line":""},{"line_number":2455,"context_line":"            Example::"},{"line_number":2456,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"1f1a1f67_af1f0eb5","line":2453,"range":{"start_line":2453,"start_character":8,"end_line":2453,"end_character":16},"in_reply_to":"1f1a1f67_ead73cbe","updated":"2017-07-20 03:00:08.000000000","message":"Done","commit_id":"7139fb1d10c3a6ee3bef8a181dec61ce8c1dc163"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8bdd34b93ec2c95fb4c67b80fbb9352e2aa14f4c","unresolved":false,"context_lines":[{"line_number":2530,"context_line":""},{"line_number":2531,"context_line":"        Driver can use this method to update the list of export locations of"},{"line_number":2532,"context_line":"        the shares if it changes. To do that, a dictionary of shares should"},{"line_number":2533,"context_line":"        be returned. :shares: None or a list of all shares for updates."},{"line_number":2534,"context_line":""},{"line_number":2535,"context_line":"        :returns: None or a dictionary of updates in the format."},{"line_number":2536,"context_line":""}],"source_content_type":"text/x-python","patch_set":38,"id":"ff82abbf_0fdf5f0d","line":2533,"range":{"start_line":2533,"start_character":21,"end_line":2533,"end_character":71},"updated":"2017-11-25 14:08:18.000000000","message":"Should be on the next line.","commit_id":"2674740e2878d8771ae911fc25d4cbaac9d3f859"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d0d837d7abc0201f7c39fa4619e2fa1dddc82f79","unresolved":false,"context_lines":[{"line_number":2530,"context_line":""},{"line_number":2531,"context_line":"        Driver can use this method to update the list of export locations of"},{"line_number":2532,"context_line":"        the shares if it changes. To do that, a dictionary of shares should"},{"line_number":2533,"context_line":"        be returned. :shares: None or a list of all shares for updates."},{"line_number":2534,"context_line":""},{"line_number":2535,"context_line":"        :returns: None or a dictionary of updates in the format."},{"line_number":2536,"context_line":""}],"source_content_type":"text/x-python","patch_set":38,"id":"ff82abbf_e002453d","line":2533,"range":{"start_line":2533,"start_character":21,"end_line":2533,"end_character":71},"in_reply_to":"ff82abbf_0fdf5f0d","updated":"2017-11-27 02:15:26.000000000","message":"Done","commit_id":"2674740e2878d8771ae911fc25d4cbaac9d3f859"}],"manila/share/drivers/lvm.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"6b81907f78e36974886ad1b9cb7a1bb8d119194a","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            except OSError:"},{"line_number":261,"context_line":"                LOG.warning(\u0027Unable to delete %s\u0027, mount_path)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def ensure_shares(self, context, shares):"},{"line_number":264,"context_line":"        for share in shares:"},{"line_number":265,"context_line":"            self.ensure_share(context, share)"},{"line_number":266,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"3f1d235d_b54d619b","line":263,"range":{"start_line":263,"start_character":8,"end_line":263,"end_character":45},"updated":"2017-07-05 22:21:42.000000000","message":"The manager is expecting this method to return a list but it is returning None.","commit_id":"832f6c0b6942dc58618fa1e23a4e031a39e8b1ec"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"216b37730d871100162085dacfa30d465751d1f6","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            except OSError:"},{"line_number":261,"context_line":"                LOG.warning(\u0027Unable to delete %s\u0027, mount_path)"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"    def ensure_shares(self, context, shares):"},{"line_number":264,"context_line":"        for share in shares:"},{"line_number":265,"context_line":"            self.ensure_share(context, share)"},{"line_number":266,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"3f1d235d_56872963","line":263,"range":{"start_line":263,"start_character":8,"end_line":263,"end_character":45},"in_reply_to":"3f1d235d_b54d619b","updated":"2017-07-06 07:36:22.000000000","message":"Done","commit_id":"832f6c0b6942dc58618fa1e23a4e031a39e8b1ec"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"138e11f3c7044d5c19d1b6a6deced7adbfb1ce08","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        updates \u003d {}"},{"line_number":282,"context_line":"        for share in shares:"},{"line_number":283,"context_line":"            updates[share[\u0027id\u0027]] \u003d {"},{"line_number":284,"context_line":"                \u0027export_locations\u0027: self.ensure_share(context, share)}"},{"line_number":285,"context_line":"        return updates"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def ensure_share(self, ctx, share, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":29,"id":"ff346bd7_a60950de","line":284,"range":{"start_line":284,"start_character":36,"end_line":284,"end_character":69},"updated":"2017-07-23 01:02:41.000000000","message":"This function on lines 287-292 is not returning anything.","commit_id":"d704b1c803f4b31b3ce16fdcfc97d728ac024bca"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"55227cbde238e102f16551a7fa9b4ce097d971dc","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        updates \u003d {}"},{"line_number":282,"context_line":"        for share in shares:"},{"line_number":283,"context_line":"            updates[share[\u0027id\u0027]] \u003d {"},{"line_number":284,"context_line":"                \u0027export_locations\u0027: self.ensure_share(context, share)}"},{"line_number":285,"context_line":"        return updates"},{"line_number":286,"context_line":""},{"line_number":287,"context_line":"    def ensure_share(self, ctx, share, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":29,"id":"ff346bd7_3b0a1226","line":284,"range":{"start_line":284,"start_character":36,"end_line":284,"end_character":69},"in_reply_to":"ff346bd7_a60950de","updated":"2017-07-24 02:30:29.000000000","message":"Done","commit_id":"d704b1c803f4b31b3ce16fdcfc97d728ac024bca"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"7a1046fdd5d8aa5e41187626c0a34a2332e7c0cb","unresolved":false,"context_lines":[{"line_number":525,"context_line":""},{"line_number":526,"context_line":"    def get_backend_info(self, context):"},{"line_number":527,"context_line":"        return {"},{"line_number":528,"context_line":"            \u0027logicalportip\u0027: self.configuration.lvm_share_export_ip,"},{"line_number":529,"context_line":"            \u0027dbversion\u0027: utils.get_recent_db_migration_id(),"},{"line_number":530,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":43,"id":"df87a7cf_8bc3fa37","line":528,"range":{"start_line":528,"start_character":48,"end_line":528,"end_character":67},"updated":"2017-12-12 17:43:17.000000000","message":"\u0027,\u0027.join(lvm_share_export_ips)\n\nThe lvm_share_export_ip is deprecated.","commit_id":"a60142d35e8d1bd5a375ac6bc5700f0a2865cb54"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"7a1046fdd5d8aa5e41187626c0a34a2332e7c0cb","unresolved":false,"context_lines":[{"line_number":525,"context_line":""},{"line_number":526,"context_line":"    def get_backend_info(self, context):"},{"line_number":527,"context_line":"        return {"},{"line_number":528,"context_line":"            \u0027logicalportip\u0027: self.configuration.lvm_share_export_ip,"},{"line_number":529,"context_line":"            \u0027dbversion\u0027: utils.get_recent_db_migration_id(),"},{"line_number":530,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":43,"id":"df87a7cf_6be236d7","line":528,"range":{"start_line":528,"start_character":13,"end_line":528,"end_character":26},"updated":"2017-12-12 17:43:17.000000000","message":"I think \"export_ips\" is a better key than \"logicalportip\"","commit_id":"a60142d35e8d1bd5a375ac6bc5700f0a2865cb54"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"559bd38809e5eb0b9648ef7fd0f00feae517921e","unresolved":false,"context_lines":[{"line_number":525,"context_line":""},{"line_number":526,"context_line":"    def get_backend_info(self, context):"},{"line_number":527,"context_line":"        return {"},{"line_number":528,"context_line":"            \u0027logicalportip\u0027: self.configuration.lvm_share_export_ip,"},{"line_number":529,"context_line":"            \u0027dbversion\u0027: utils.get_recent_db_migration_id(),"},{"line_number":530,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":43,"id":"df87a7cf_cae4923f","line":528,"range":{"start_line":528,"start_character":13,"end_line":528,"end_character":26},"in_reply_to":"df87a7cf_6be236d7","updated":"2017-12-13 03:50:06.000000000","message":"Done","commit_id":"a60142d35e8d1bd5a375ac6bc5700f0a2865cb54"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"559bd38809e5eb0b9648ef7fd0f00feae517921e","unresolved":false,"context_lines":[{"line_number":525,"context_line":""},{"line_number":526,"context_line":"    def get_backend_info(self, context):"},{"line_number":527,"context_line":"        return {"},{"line_number":528,"context_line":"            \u0027logicalportip\u0027: self.configuration.lvm_share_export_ip,"},{"line_number":529,"context_line":"            \u0027dbversion\u0027: utils.get_recent_db_migration_id(),"},{"line_number":530,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":43,"id":"df87a7cf_eae1562c","line":528,"range":{"start_line":528,"start_character":48,"end_line":528,"end_character":67},"in_reply_to":"df87a7cf_8bc3fa37","updated":"2017-12-13 03:50:06.000000000","message":"Done","commit_id":"a60142d35e8d1bd5a375ac6bc5700f0a2865cb54"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"0d407843232e0f4de0cd43f6fee0c04b1ecf4963","unresolved":false,"context_lines":[{"line_number":525,"context_line":""},{"line_number":526,"context_line":"    def get_backend_info(self, context):"},{"line_number":527,"context_line":"        return {"},{"line_number":528,"context_line":"            \u0027logicalportip\u0027: self.configuration.lvm_share_export_ip,"},{"line_number":529,"context_line":"            \u0027dbversion\u0027: utils.get_recent_db_migration_id(),"},{"line_number":530,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":43,"id":"df87a7cf_ea5844fb","line":528,"range":{"start_line":528,"start_character":48,"end_line":528,"end_character":67},"in_reply_to":"df87a7cf_8bc3fa37","updated":"2017-12-14 16:16:35.000000000","message":"I changed lvm_share_export_ips to self.share_service[public_addresses], because we still can use  lvm_share_export_ip in lvm driver and it’s work .","commit_id":"a60142d35e8d1bd5a375ac6bc5700f0a2865cb54"}],"manila/share/manager.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"6b81907f78e36974886ad1b9cb7a1bb8d119194a","unresolved":false,"context_lines":[{"line_number":375,"context_line":"            self.db.backend_info_update("},{"line_number":376,"context_line":"                ctxt, self.host, new_backend_info_hash)"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"        for share_instance in update_share_instances:"},{"line_number":379,"context_line":"            self.db.share_instance_update("},{"line_number":380,"context_line":"                ctxt, share_instance[\u0027id\u0027],"},{"line_number":381,"context_line":"                {\u0027status\u0027: constants.STATUS_ERROR,"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f1d235d_d5533d38","line":378,"range":{"start_line":378,"start_character":8,"end_line":378,"end_character":53},"updated":"2017-07-05 22:21:42.000000000","message":"lvm driver is returning None as the value of update_share_instances which causes this traceback:\n\nhttp://logs.openstack.org/45/457545/21/check/gate-manila-tempest-minimal-dsvm-lvm-ubuntu-xenial/750781b/logs/screen-m-shr.txt.gz#_Jul_05_10_46_02_626244","commit_id":"832f6c0b6942dc58618fa1e23a4e031a39e8b1ec"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"216b37730d871100162085dacfa30d465751d1f6","unresolved":false,"context_lines":[{"line_number":375,"context_line":"            self.db.backend_info_update("},{"line_number":376,"context_line":"                ctxt, self.host, new_backend_info_hash)"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"        for share_instance in update_share_instances:"},{"line_number":379,"context_line":"            self.db.share_instance_update("},{"line_number":380,"context_line":"                ctxt, share_instance[\u0027id\u0027],"},{"line_number":381,"context_line":"                {\u0027status\u0027: constants.STATUS_ERROR,"}],"source_content_type":"text/x-python","patch_set":21,"id":"3f1d235d_f67f5563","line":378,"range":{"start_line":378,"start_character":8,"end_line":378,"end_character":53},"in_reply_to":"3f1d235d_d5533d38","updated":"2017-07-06 07:36:22.000000000","message":"Done","commit_id":"832f6c0b6942dc58618fa1e23a4e031a39e8b1ec"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"df074229c090bf54270fca2557848de6a736f068","unresolved":false,"context_lines":[{"line_number":328,"context_line":"        try:"},{"line_number":329,"context_line":"            new_backend_info \u003d self.driver.get_backend_info(ctxt)"},{"line_number":330,"context_line":"        except Exception as e:"},{"line_number":331,"context_line":"            if not isinstance(e, NotImplementedError):"},{"line_number":332,"context_line":"                LOG.exception("},{"line_number":333,"context_line":"                    (\"The driver could not get backend info %(host)s\"),"},{"line_number":334,"context_line":"                    {\u0027host\u0027: self.host})"}],"source_content_type":"text/x-python","patch_set":31,"id":"ff346bd7_9075e634","line":331,"range":{"start_line":331,"start_character":0,"end_line":331,"end_character":54},"updated":"2017-07-26 20:54:49.000000000","message":"Need test coverage for this path.\n\nMaybe we should LOG.debug when the driver hasn\u0027t implemented the method.","commit_id":"2a05d672ae18a3ce53885f6e0362b364e76538e2"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b3e62cf11f55426ad405ad88d564bba7216a47c2","unresolved":false,"context_lines":[{"line_number":328,"context_line":"        try:"},{"line_number":329,"context_line":"            new_backend_info \u003d self.driver.get_backend_info(ctxt)"},{"line_number":330,"context_line":"        except Exception as e:"},{"line_number":331,"context_line":"            if not isinstance(e, NotImplementedError):"},{"line_number":332,"context_line":"                LOG.exception("},{"line_number":333,"context_line":"                    (\"The driver could not get backend info %(host)s\"),"},{"line_number":334,"context_line":"                    {\u0027host\u0027: self.host})"}],"source_content_type":"text/x-python","patch_set":31,"id":"ff346bd7_187c691d","line":331,"range":{"start_line":331,"start_character":0,"end_line":331,"end_character":54},"in_reply_to":"ff346bd7_9075e634","updated":"2017-10-16 08:41:54.000000000","message":"Done","commit_id":"2a05d672ae18a3ce53885f6e0362b364e76538e2"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"df074229c090bf54270fca2557848de6a736f068","unresolved":false,"context_lines":[{"line_number":334,"context_line":"                    {\u0027host\u0027: self.host})"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        if new_backend_info:"},{"line_number":337,"context_line":"            new_backend_info_hash \u003d hash(frozenset(new_backend_info.items()))"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"        if (old_backend_info_hash and"},{"line_number":340,"context_line":"                old_backend_info_hash \u003d\u003d new_backend_info_hash):"}],"source_content_type":"text/x-python","patch_set":31,"id":"ff346bd7_b0a10a97","line":337,"range":{"start_line":337,"start_character":51,"end_line":337,"end_character":77},"updated":"2017-07-26 20:54:49.000000000","message":"Do we have to sort these to get them in a deterministic order?  If they can show up in different orders then we\u0027ll get different hash when there is no real difference.","commit_id":"2a05d672ae18a3ce53885f6e0362b364e76538e2"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"df074229c090bf54270fca2557848de6a736f068","unresolved":false,"context_lines":[{"line_number":334,"context_line":"                    {\u0027host\u0027: self.host})"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        if new_backend_info:"},{"line_number":337,"context_line":"            new_backend_info_hash \u003d hash(frozenset(new_backend_info.items()))"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"        if (old_backend_info_hash and"},{"line_number":340,"context_line":"                old_backend_info_hash \u003d\u003d new_backend_info_hash):"}],"source_content_type":"text/x-python","patch_set":31,"id":"ff346bd7_b368f4b8","line":337,"range":{"start_line":337,"start_character":11,"end_line":337,"end_character":77},"updated":"2017-07-26 20:54:49.000000000","message":"need test coverage for this path","commit_id":"2a05d672ae18a3ce53885f6e0362b364e76538e2"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b3e62cf11f55426ad405ad88d564bba7216a47c2","unresolved":false,"context_lines":[{"line_number":334,"context_line":"                    {\u0027host\u0027: self.host})"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        if new_backend_info:"},{"line_number":337,"context_line":"            new_backend_info_hash \u003d hash(frozenset(new_backend_info.items()))"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"        if (old_backend_info_hash and"},{"line_number":340,"context_line":"                old_backend_info_hash \u003d\u003d new_backend_info_hash):"}],"source_content_type":"text/x-python","patch_set":31,"id":"ff346bd7_f8c2c533","line":337,"range":{"start_line":337,"start_character":51,"end_line":337,"end_character":77},"in_reply_to":"ff346bd7_b0a10a97","updated":"2017-10-16 08:41:54.000000000","message":"Done","commit_id":"2a05d672ae18a3ce53885f6e0362b364e76538e2"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b3e62cf11f55426ad405ad88d564bba7216a47c2","unresolved":false,"context_lines":[{"line_number":334,"context_line":"                    {\u0027host\u0027: self.host})"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        if new_backend_info:"},{"line_number":337,"context_line":"            new_backend_info_hash \u003d hash(frozenset(new_backend_info.items()))"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"        if (old_backend_info_hash and"},{"line_number":340,"context_line":"                old_backend_info_hash \u003d\u003d new_backend_info_hash):"}],"source_content_type":"text/x-python","patch_set":31,"id":"ff346bd7_d8bf01a8","line":337,"range":{"start_line":337,"start_character":11,"end_line":337,"end_character":77},"in_reply_to":"ff346bd7_b368f4b8","updated":"2017-10-16 08:41:54.000000000","message":"Done","commit_id":"2a05d672ae18a3ce53885f6e0362b364e76538e2"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"df074229c090bf54270fca2557848de6a736f068","unresolved":false,"context_lines":[{"line_number":336,"context_line":"        if new_backend_info:"},{"line_number":337,"context_line":"            new_backend_info_hash \u003d hash(frozenset(new_backend_info.items()))"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"        if (old_backend_info_hash and"},{"line_number":340,"context_line":"                old_backend_info_hash \u003d\u003d new_backend_info_hash):"},{"line_number":341,"context_line":"            return"},{"line_number":342,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"ff346bd7_135580fa","line":339,"range":{"start_line":339,"start_character":0,"end_line":339,"end_character":1},"updated":"2017-07-26 20:54:49.000000000","message":"need test coverage for this path","commit_id":"2a05d672ae18a3ce53885f6e0362b364e76538e2"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b3e62cf11f55426ad405ad88d564bba7216a47c2","unresolved":false,"context_lines":[{"line_number":336,"context_line":"        if new_backend_info:"},{"line_number":337,"context_line":"            new_backend_info_hash \u003d hash(frozenset(new_backend_info.items()))"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"        if (old_backend_info_hash and"},{"line_number":340,"context_line":"                old_backend_info_hash \u003d\u003d new_backend_info_hash):"},{"line_number":341,"context_line":"            return"},{"line_number":342,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"ff346bd7_5837914e","line":339,"range":{"start_line":339,"start_character":0,"end_line":339,"end_character":1},"in_reply_to":"ff346bd7_135580fa","updated":"2017-10-16 08:41:54.000000000","message":"Done","commit_id":"2a05d672ae18a3ce53885f6e0362b364e76538e2"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"df074229c090bf54270fca2557848de6a736f068","unresolved":false,"context_lines":[{"line_number":371,"context_line":"            update_share_instances \u003d self.driver.ensure_shares("},{"line_number":372,"context_line":"                ctxt, share_instances)"},{"line_number":373,"context_line":"        except Exception as e:"},{"line_number":374,"context_line":"            if not isinstance(e, NotImplementedError):"},{"line_number":375,"context_line":"                LOG.exception(\"Caught exception trying ensure \""},{"line_number":376,"context_line":"                              \"share instances.\")"},{"line_number":377,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":31,"id":"ff346bd7_90d8461e","line":374,"range":{"start_line":374,"start_character":12,"end_line":374,"end_character":54},"updated":"2017-07-26 20:54:49.000000000","message":"Again I think we should LOG.debug for NotImplemented.","commit_id":"2a05d672ae18a3ce53885f6e0362b364e76538e2"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b3e62cf11f55426ad405ad88d564bba7216a47c2","unresolved":false,"context_lines":[{"line_number":371,"context_line":"            update_share_instances \u003d self.driver.ensure_shares("},{"line_number":372,"context_line":"                ctxt, share_instances)"},{"line_number":373,"context_line":"        except Exception as e:"},{"line_number":374,"context_line":"            if not isinstance(e, NotImplementedError):"},{"line_number":375,"context_line":"                LOG.exception(\"Caught exception trying ensure \""},{"line_number":376,"context_line":"                              \"share instances.\")"},{"line_number":377,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":31,"id":"ff346bd7_d3448249","line":374,"range":{"start_line":374,"start_character":12,"end_line":374,"end_character":54},"in_reply_to":"ff346bd7_90d8461e","updated":"2017-10-16 08:41:54.000000000","message":"Done","commit_id":"2a05d672ae18a3ce53885f6e0362b364e76538e2"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"df074229c090bf54270fca2557848de6a736f068","unresolved":false,"context_lines":[{"line_number":374,"context_line":"            if not isinstance(e, NotImplementedError):"},{"line_number":375,"context_line":"                LOG.exception(\"Caught exception trying ensure \""},{"line_number":376,"context_line":"                              \"share instances.\")"},{"line_number":377,"context_line":"            else:"},{"line_number":378,"context_line":"                for share_instance in share_instances:"},{"line_number":379,"context_line":"                    try:"},{"line_number":380,"context_line":"                        share_server \u003d self._get_share_server("},{"line_number":381,"context_line":"                            ctxt, share_instance)"},{"line_number":382,"context_line":"                        export_locations \u003d self.driver.ensure_share("},{"line_number":383,"context_line":"                            ctxt, share_instance, share_server\u003dshare_server)"},{"line_number":384,"context_line":"                    except Exception:"},{"line_number":385,"context_line":"                        LOG.exception(\"Caught exception trying ensure \""},{"line_number":386,"context_line":"                                      \"share \u0027%(s_id)s\u0027.\","},{"line_number":387,"context_line":"                                      {\u0027s_id\u0027: share_instance[\u0027id\u0027]})"},{"line_number":388,"context_line":"                        continue"},{"line_number":389,"context_line":"                    if export_locations:"},{"line_number":390,"context_line":"                        self.db.share_export_locations_update("},{"line_number":391,"context_line":"                            ctxt, share_instance[\u0027id\u0027], export_locations)"},{"line_number":392,"context_line":"        if new_backend_info:"},{"line_number":393,"context_line":"            self.db.backend_info_update("},{"line_number":394,"context_line":"                ctxt, self.host, new_backend_info_hash)"}],"source_content_type":"text/x-python","patch_set":31,"id":"ff346bd7_100c5692","line":391,"range":{"start_line":377,"start_character":12,"end_line":391,"end_character":73},"updated":"2017-07-26 20:54:49.000000000","message":"I think this legacy export locations update should be split out into a separate method that you call here.   That will make the code more readable and will make it easier to get rid of the legacy method when all drivers have implemented ensure_shares()","commit_id":"2a05d672ae18a3ce53885f6e0362b364e76538e2"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b3e62cf11f55426ad405ad88d564bba7216a47c2","unresolved":false,"context_lines":[{"line_number":374,"context_line":"            if not isinstance(e, NotImplementedError):"},{"line_number":375,"context_line":"                LOG.exception(\"Caught exception trying ensure \""},{"line_number":376,"context_line":"                              \"share instances.\")"},{"line_number":377,"context_line":"            else:"},{"line_number":378,"context_line":"                for share_instance in share_instances:"},{"line_number":379,"context_line":"                    try:"},{"line_number":380,"context_line":"                        share_server \u003d self._get_share_server("},{"line_number":381,"context_line":"                            ctxt, share_instance)"},{"line_number":382,"context_line":"                        export_locations \u003d self.driver.ensure_share("},{"line_number":383,"context_line":"                            ctxt, share_instance, share_server\u003dshare_server)"},{"line_number":384,"context_line":"                    except Exception:"},{"line_number":385,"context_line":"                        LOG.exception(\"Caught exception trying ensure \""},{"line_number":386,"context_line":"                                      \"share \u0027%(s_id)s\u0027.\","},{"line_number":387,"context_line":"                                      {\u0027s_id\u0027: share_instance[\u0027id\u0027]})"},{"line_number":388,"context_line":"                        continue"},{"line_number":389,"context_line":"                    if export_locations:"},{"line_number":390,"context_line":"                        self.db.share_export_locations_update("},{"line_number":391,"context_line":"                            ctxt, share_instance[\u0027id\u0027], export_locations)"},{"line_number":392,"context_line":"        if new_backend_info:"},{"line_number":393,"context_line":"            self.db.backend_info_update("},{"line_number":394,"context_line":"                ctxt, self.host, new_backend_info_hash)"}],"source_content_type":"text/x-python","patch_set":31,"id":"ff346bd7_d3980276","line":391,"range":{"start_line":377,"start_character":12,"end_line":391,"end_character":73},"in_reply_to":"ff346bd7_100c5692","updated":"2017-10-16 08:41:54.000000000","message":"Done","commit_id":"2a05d672ae18a3ce53885f6e0362b364e76538e2"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"df074229c090bf54270fca2557848de6a736f068","unresolved":false,"context_lines":[{"line_number":390,"context_line":"                        self.db.share_export_locations_update("},{"line_number":391,"context_line":"                            ctxt, share_instance[\u0027id\u0027], export_locations)"},{"line_number":392,"context_line":"        if new_backend_info:"},{"line_number":393,"context_line":"            self.db.backend_info_update("},{"line_number":394,"context_line":"                ctxt, self.host, new_backend_info_hash)"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        for share_instance in share_instances:"}],"source_content_type":"text/x-python","patch_set":31,"id":"ff346bd7_33a2c4fe","line":393,"range":{"start_line":393,"start_character":12,"end_line":393,"end_character":40},"updated":"2017-07-26 20:54:49.000000000","message":"Need test coverage for this path.","commit_id":"2a05d672ae18a3ce53885f6e0362b364e76538e2"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b3e62cf11f55426ad405ad88d564bba7216a47c2","unresolved":false,"context_lines":[{"line_number":390,"context_line":"                        self.db.share_export_locations_update("},{"line_number":391,"context_line":"                            ctxt, share_instance[\u0027id\u0027], export_locations)"},{"line_number":392,"context_line":"        if new_backend_info:"},{"line_number":393,"context_line":"            self.db.backend_info_update("},{"line_number":394,"context_line":"                ctxt, self.host, new_backend_info_hash)"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        for share_instance in share_instances:"}],"source_content_type":"text/x-python","patch_set":31,"id":"ff346bd7_33750e65","line":393,"range":{"start_line":393,"start_character":12,"end_line":393,"end_character":40},"in_reply_to":"ff346bd7_33a2c4fe","updated":"2017-10-16 08:41:54.000000000","message":"Done","commit_id":"2a05d672ae18a3ce53885f6e0362b364e76538e2"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"df074229c090bf54270fca2557848de6a736f068","unresolved":false,"context_lines":[{"line_number":393,"context_line":"            self.db.backend_info_update("},{"line_number":394,"context_line":"                ctxt, self.host, new_backend_info_hash)"},{"line_number":395,"context_line":""},{"line_number":396,"context_line":"        for share_instance in share_instances:"},{"line_number":397,"context_line":"            if share_instance[\u0027id\u0027] not in update_share_instances:"},{"line_number":398,"context_line":"                continue"},{"line_number":399,"context_line":"            if update_share_instances[share_instance[\u0027id\u0027]].get(\u0027status\u0027):"},{"line_number":400,"context_line":"                self.db.share_instance_update("},{"line_number":401,"context_line":"                    ctxt, share_instance[\u0027id\u0027],"},{"line_number":402,"context_line":"                    {\u0027status\u0027: ("},{"line_number":403,"context_line":"                        update_share_instances[share_instance[\u0027id\u0027]]."},{"line_number":404,"context_line":"                        get(\u0027status\u0027)),"},{"line_number":405,"context_line":"                     \u0027host\u0027: share_instance[\u0027host\u0027]}"},{"line_number":406,"context_line":"                )"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"            update_export_location \u003d ("},{"line_number":409,"context_line":"                update_share_instances[share_instance[\u0027id\u0027]]"},{"line_number":410,"context_line":"                .get(\u0027export_locations\u0027))"},{"line_number":411,"context_line":"            if update_export_location:"},{"line_number":412,"context_line":"                self.db.share_export_locations_update("},{"line_number":413,"context_line":"                    ctxt, share_instance[\u0027id\u0027], update_export_location)"},{"line_number":414,"context_line":""},{"line_number":415,"context_line":"            share_server \u003d self._get_share_server(ctxt, share_instance)"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"            if share_instance[\u0027access_rules_status\u0027] !\u003d ("},{"line_number":418,"context_line":"                    constants.STATUS_ACTIVE):"}],"source_content_type":"text/x-python","patch_set":31,"id":"ff346bd7_70296299","line":415,"range":{"start_line":396,"start_character":0,"end_line":415,"end_character":71},"updated":"2017-07-26 20:54:49.000000000","message":"Are you ignoring any model updates included in update_share_instances if they aren\u0027t export locations or status?","commit_id":"2a05d672ae18a3ce53885f6e0362b364e76538e2"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"61df8d53f8dfcd2e01a8aff863413fc17747b2a1","unresolved":false,"context_lines":[{"line_number":340,"context_line":"                    {\u0027host\u0027: self.host})"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"        if new_backend_info:"},{"line_number":343,"context_line":"            new_backend_info_hash \u003d six.text_type(hash("},{"line_number":344,"context_line":"                frozenset(sorted(new_backend_info.items()))))"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"        if (old_backend_info_hash and"}],"source_content_type":"text/x-python","patch_set":45,"id":"df87a7cf_28307407","line":343,"range":{"start_line":343,"start_character":50,"end_line":343,"end_character":54},"updated":"2017-12-14 17:44:14.000000000","message":"It look\u0027s like python\u0027s hash() method returns a 64-bit number, which is probably good enough for our needs, but a larger hash would be better and not hard to use here instead.\n\nDid you consider a 128-bit or larger hash, like MD5 or SHA-1?","commit_id":"19021fb4d17577a5d6e9e5d09f6529cb7843ef39"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2713e497ba66961763cf07e0f875aaf61d32f642","unresolved":false,"context_lines":[{"line_number":340,"context_line":"                    {\u0027host\u0027: self.host})"},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"        if new_backend_info:"},{"line_number":343,"context_line":"            new_backend_info_hash \u003d six.text_type(hash("},{"line_number":344,"context_line":"                frozenset(sorted(new_backend_info.items()))))"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"        if (old_backend_info_hash and"}],"source_content_type":"text/x-python","patch_set":45,"id":"df87a7cf_1b5e0e12","line":343,"range":{"start_line":343,"start_character":50,"end_line":343,"end_character":54},"in_reply_to":"df87a7cf_28307407","updated":"2017-12-15 06:40:43.000000000","message":"Done","commit_id":"19021fb4d17577a5d6e9e5d09f6529cb7843ef39"}],"manila/share/utils.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"8bdd34b93ec2c95fb4c67b80fbb9352e2aa14f4c","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from manila.db import migration"},{"line_number":23,"context_line":"from manila import rpc"},{"line_number":24,"context_line":"from manila import utils"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"DEFAULT_POOL_NAME \u003d \u0027_pool0\u0027"},{"line_number":28,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":38,"id":"ff82abbf_afcf5354","line":25,"updated":"2017-11-25 14:08:18.000000000","message":"I don\u0027t think this extra line is needed.","commit_id":"2674740e2878d8771ae911fc25d4cbaac9d3f859"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d0d837d7abc0201f7c39fa4619e2fa1dddc82f79","unresolved":false,"context_lines":[{"line_number":22,"context_line":"from manila.db import migration"},{"line_number":23,"context_line":"from manila import rpc"},{"line_number":24,"context_line":"from manila import utils"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"DEFAULT_POOL_NAME \u003d \u0027_pool0\u0027"},{"line_number":28,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":38,"id":"ff82abbf_609cf50e","line":25,"in_reply_to":"ff82abbf_afcf5354","updated":"2017-11-27 02:15:26.000000000","message":"Done","commit_id":"2674740e2878d8771ae911fc25d4cbaac9d3f859"}],"manila/tests/db/sqlalchemy/test_api.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"035f2619658e081de84e7cd247618fdc9e2c631f","unresolved":false,"context_lines":[{"line_number":2825,"context_line":"        result_ids \u003d [r.id for r in result]"},{"line_number":2826,"context_line":"        self.assertEqual(result_ids, ids)"},{"line_number":2827,"context_line":""},{"line_number":2828,"context_line":""},{"line_number":2829,"context_line":"    def test_cleanup_expired_messages(self):"},{"line_number":2830,"context_line":"        adm_context \u003d self.ctxt.elevated()"},{"line_number":2831,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"1f1a1f67_8a7b28f3","line":2828,"updated":"2017-07-19 21:04:08.000000000","message":"./manila/tests/db/sqlalchemy/test_api.py:2829:5: E303 too many blank lines (2)","commit_id":"7139fb1d10c3a6ee3bef8a181dec61ce8c1dc163"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d7fdcf16d66311a010e0f309a390cc6ef1358582","unresolved":false,"context_lines":[{"line_number":2825,"context_line":"        result_ids \u003d [r.id for r in result]"},{"line_number":2826,"context_line":"        self.assertEqual(result_ids, ids)"},{"line_number":2827,"context_line":""},{"line_number":2828,"context_line":""},{"line_number":2829,"context_line":"    def test_cleanup_expired_messages(self):"},{"line_number":2830,"context_line":"        adm_context \u003d self.ctxt.elevated()"},{"line_number":2831,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"1f1a1f67_6f7b36f4","line":2828,"in_reply_to":"1f1a1f67_8a7b28f3","updated":"2017-07-20 03:00:08.000000000","message":"Done","commit_id":"7139fb1d10c3a6ee3bef8a181dec61ce8c1dc163"}]}
