)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"511ad017617cb66e129bf5c6234ae04275ef87b0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     yanjun.fu \u003cyanjun.fu@easystack.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-05-08 14:33:39 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix tap device disappear after node restart"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"fixed the tap device will disappear after restart the node in generic,"},{"line_number":10,"context_line":"that will caused manila can not manage share that created by this manila-share service"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f044301_dcfd103b","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":1},"updated":"2017-05-08 09:04:58.000000000","message":"s/f/F","commit_id":"bf6676acf08283497e9341a4a8d856ca4d14d6c3"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"511ad017617cb66e129bf5c6234ae04275ef87b0","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"fix tap device disappear after node restart"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"fixed the tap device will disappear after restart the node in generic,"},{"line_number":10,"context_line":"that will caused manila can not manage share that created by this manila-share service"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I302f8ab5639b42ff99d12f9c6838ce0a84c65b0f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3f044301_bcf80449","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":1},"updated":"2017-05-08 09:04:58.000000000","message":"s/f/F","commit_id":"bf6676acf08283497e9341a4a8d856ca4d14d6c3"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"1e20a4eacf8c1b4519f01a774d31b6919427b9a6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"fix tap device disappear after node restart"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"fixed the tap device will disappear after restart the node in generic,"},{"line_number":10,"context_line":"that will caused manila can not manage share that created by this manila-share service"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I302f8ab5639b42ff99d12f9c6838ce0a84c65b0f"},{"line_number":13,"context_line":"Closes-Bug:#1688155"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3f044301_2c6eff00","line":10,"range":{"start_line":10,"start_character":61,"end_line":10,"end_character":86},"updated":"2017-05-10 10:34:15.000000000","message":"nit: wrap this line between \u0027this\u0027 and \u0027manila-share\u0027 so that it stays within line limits.","commit_id":"f7cdb8ee96aeb6d7f36768894b803fcc8bb464ab"}],"manila/share/drivers/generic.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"af563ec308fa88d30de4fe7b1471a2b2cb65ff8e","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        self.compute_api \u003d compute.API()"},{"line_number":178,"context_line":"        self.volume_api \u003d volume.API()"},{"line_number":179,"context_line":"        self._setup_helpers()"},{"line_number":180,"context_line":"\tself.service_instance_manager._get_network_helper().\\"},{"line_number":181,"context_line":"            setup_connectivity_with_service_instances()"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        common_sv_available \u003d False"},{"line_number":184,"context_line":"        share_server \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f044301_fbe69916","line":181,"range":{"start_line":180,"start_character":1,"end_line":181,"end_character":55},"updated":"2017-05-07 20:05:38.000000000","message":"The python 3.5 unit test will be happier if you do:\n\n  (self.service_instance_manager.get_network_helper().\n      setup_connectivity_with_service_instances())\n\nSpeaking of unit tests, you\u0027ve added code but not added any unit test coverage for the code.","commit_id":"d33aca98386189a713c9d932e867e86ae73cb36f"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"511ad017617cb66e129bf5c6234ae04275ef87b0","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        self.volume_api \u003d volume.API()"},{"line_number":179,"context_line":"        self._setup_helpers()"},{"line_number":180,"context_line":"        if self.driver_handles_share_servers:"},{"line_number":181,"context_line":"            (self.service_instance_manager._get_network_helper()."},{"line_number":182,"context_line":"             setup_connectivity_with_service_instances())"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        common_sv_available \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f044301_12d0ff1e","line":181,"range":{"start_line":181,"start_character":43,"end_line":181,"end_character":62},"updated":"2017-05-08 09:04:58.000000000","message":"The _get_network_helper have prefix \"_\", so it can only used in service_instance.py.","commit_id":"bf6676acf08283497e9341a4a8d856ca4d14d6c3"},{"author":{"_account_id":22650,"name":"yankee","email":"yankeefu@163.com","username":"yanjun.fu"},"change_message_id":"b0e2c359fdd0c2c66cc773643227790a8dafa21f","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        self.volume_api \u003d volume.API()"},{"line_number":179,"context_line":"        self._setup_helpers()"},{"line_number":180,"context_line":"        if self.driver_handles_share_servers:"},{"line_number":181,"context_line":"            (self.service_instance_manager._get_network_helper()."},{"line_number":182,"context_line":"             setup_connectivity_with_service_instances())"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        common_sv_available \u003d False"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f044301_387abd87","line":181,"range":{"start_line":181,"start_character":43,"end_line":181,"end_character":62},"in_reply_to":"3f044301_12d0ff1e","updated":"2017-05-08 09:30:29.000000000","message":"then how we can use it?","commit_id":"bf6676acf08283497e9341a4a8d856ca4d14d6c3"},{"author":{"_account_id":7582,"name":"Jan Provaznik","email":"jan.provaznik@gmail.com","username":"jprovazn"},"change_message_id":"2237d09c6127b04afd70ad194ea3103346593868","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        self.volume_api \u003d volume.API()"},{"line_number":179,"context_line":"        self._setup_helpers()"},{"line_number":180,"context_line":"        if self.driver_handles_share_servers:"},{"line_number":181,"context_line":"            (self.service_instance_manager._get_network_helper()."},{"line_number":182,"context_line":"             setup_connectivity_with_service_instances())"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        common_sv_available \u003d False"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f044301_a6a1ea48","line":181,"range":{"start_line":181,"start_character":43,"end_line":181,"end_character":64},"updated":"2017-05-10 10:07:35.000000000","message":"What zhongjun meant in the previous comment is that underscore methods should be considered as private methods and not accessed from outside of the class itself (https://docs.python.org/2/tutorial/classes.html#private-variables-and-class-local-references)\n\nIn this case you could use \"service_instance_manager.network_helper\" if really needed.","commit_id":"f7cdb8ee96aeb6d7f36768894b803fcc8bb464ab"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"1e20a4eacf8c1b4519f01a774d31b6919427b9a6","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        self.compute_api \u003d compute.API()"},{"line_number":178,"context_line":"        self.volume_api \u003d volume.API()"},{"line_number":179,"context_line":"        self._setup_helpers()"},{"line_number":180,"context_line":"        if self.driver_handles_share_servers:"},{"line_number":181,"context_line":"            (self.service_instance_manager._get_network_helper()."},{"line_number":182,"context_line":"             setup_connectivity_with_service_instances())"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        common_sv_available \u003d False"},{"line_number":185,"context_line":"        share_server \u003d None"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f044301_6c4d2799","line":182,"range":{"start_line":180,"start_character":8,"end_line":182,"end_character":57},"updated":"2017-05-10 10:34:15.000000000","message":"I agree with Zhongjun\u0027s remark in PS3 that the generic driver shouldn\u0027t know or care about the service_instance_manager\u0027s network helper or its methods.\n\nCan\u0027t you modify the last line of ServiceInstanceManager.__init__() to set self._network_helper to self.network_helper() and get the same result without having to use a private method from the service_instance_manager?","commit_id":"f7cdb8ee96aeb6d7f36768894b803fcc8bb464ab"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fe502a830019e8c821c4bb9b752baf40d6de8034","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        self.compute_api \u003d compute.API()"},{"line_number":178,"context_line":"        self.volume_api \u003d volume.API()"},{"line_number":179,"context_line":"        self._setup_helpers()"},{"line_number":180,"context_line":"        if self.driver_handles_share_servers:"},{"line_number":181,"context_line":"            (self.service_instance_manager.network_helper()."},{"line_number":182,"context_line":"             setup_connectivity_with_service_instances())"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        common_sv_available \u003d False"},{"line_number":185,"context_line":"        share_server \u003d None"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f044301_500c00eb","line":182,"range":{"start_line":180,"start_character":8,"end_line":182,"end_character":57},"updated":"2017-05-11 10:40:49.000000000","message":"Previous comments were correct. Init of manager should care about it. Not \"each\" driver that uses this manager. And \"generic\" is NOT the only driver that uses it. Windows driver is affected too.","commit_id":"8c9a0aca44c0dadd962ff1f04e4a52a5e7843fa2"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a51d1cff31bdc44365540005d70f3dc9332f1192","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        self.compute_api \u003d compute.API()"},{"line_number":178,"context_line":"        self.volume_api \u003d volume.API()"},{"line_number":179,"context_line":"        self._setup_helpers()"},{"line_number":180,"context_line":"        if self.driver_handles_share_servers:"},{"line_number":181,"context_line":"            (self.service_instance_manager.network_helper()."},{"line_number":182,"context_line":"             setup_connectivity_with_service_instances())"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        common_sv_available \u003d False"},{"line_number":185,"context_line":"        share_server \u003d None"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_ef0ade1d","line":182,"range":{"start_line":180,"start_character":8,"end_line":182,"end_character":57},"in_reply_to":"3f044301_500c00eb","updated":"2017-05-24 06:38:56.000000000","message":"+1","commit_id":"8c9a0aca44c0dadd962ff1f04e4a52a5e7843fa2"}],"manila/tests/share/drivers/test_generic.py":[{"author":{"_account_id":7582,"name":"Jan Provaznik","email":"jan.provaznik@gmail.com","username":"jprovazn"},"change_message_id":"2237d09c6127b04afd70ad194ea3103346593868","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        self.mock_object(compute, \u0027API\u0027)"},{"line_number":168,"context_line":"        self.mock_object(self._driver, \u0027_setup_helpers\u0027)"},{"line_number":169,"context_line":"        self.mock_object(self._driver.service_instance_manager,"},{"line_number":170,"context_line":"                         \u0027_get_network_helper()\u0027)"},{"line_number":171,"context_line":"        self.mock_object("},{"line_number":172,"context_line":"            self._driver,"},{"line_number":173,"context_line":"            \u0027_is_share_server_active\u0027, mock.Mock(return_value\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f044301_a6ba0a6b","line":170,"updated":"2017-05-10 10:07:35.000000000","message":"It would worth to also check that network connectivity was really set - at least check that the setup_connectivity_with_service_instances method was really called.","commit_id":"f7cdb8ee96aeb6d7f36768894b803fcc8bb464ab"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fe502a830019e8c821c4bb9b752baf40d6de8034","unresolved":false,"context_lines":[{"line_number":167,"context_line":"        self.mock_object(compute, \u0027API\u0027)"},{"line_number":168,"context_line":"        self.mock_object(self._driver, \u0027_setup_helpers\u0027)"},{"line_number":169,"context_line":"        self.mock_object(self._driver.service_instance_manager,"},{"line_number":170,"context_line":"                         \u0027network_helper()\u0027)"},{"line_number":171,"context_line":"        self.mock_object("},{"line_number":172,"context_line":"            self._driver,"},{"line_number":173,"context_line":"            \u0027_is_share_server_active\u0027, mock.Mock(return_value\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f044301_104c3840","line":170,"range":{"start_line":170,"start_character":40,"end_line":170,"end_character":42},"updated":"2017-05-11 10:40:49.000000000","message":"should be removed.","commit_id":"8c9a0aca44c0dadd962ff1f04e4a52a5e7843fa2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fe502a830019e8c821c4bb9b752baf40d6de8034","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        self.mock_object(compute, \u0027API\u0027)"},{"line_number":202,"context_line":"        self.mock_object(self._driver, \u0027_setup_helpers\u0027)"},{"line_number":203,"context_line":"        self.mock_object(self._driver.service_instance_manager,"},{"line_number":204,"context_line":"                         \u0027_get_network_helper()\u0027)"},{"line_number":205,"context_line":"        self.mock_object("},{"line_number":206,"context_line":"            self._driver,"},{"line_number":207,"context_line":"            \u0027_is_share_server_active\u0027, mock.Mock(side_effect\u003d[False, True]))"}],"source_content_type":"text/x-python","patch_set":7,"id":"3f044301_f048ac2d","line":204,"range":{"start_line":204,"start_character":45,"end_line":204,"end_character":47},"updated":"2017-05-11 10:40:49.000000000","message":"same here.","commit_id":"8c9a0aca44c0dadd962ff1f04e4a52a5e7843fa2"}],"releasenotes/notes/fix-tap-disappear-6543f0b99a02a284.yaml":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"511ad017617cb66e129bf5c6234ae04275ef87b0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Fix tap device disappear after node restart that can not reach into OVS to plug in to the integration bridge"},{"line_number":4,"context_line":"fixes:"},{"line_number":5,"context_line":"  - bug 1688155"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3f044301_3ca2b44c","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":112},"updated":"2017-05-08 09:04:58.000000000","message":"Please wrap it in 79 characters.","commit_id":"bf6676acf08283497e9341a4a8d856ca4d14d6c3"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a51d1cff31bdc44365540005d70f3dc9332f1192","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Fix tap device disappear after node restart that can not reach"},{"line_number":4,"context_line":"    into OVS to plug in to the integration bridge"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"ff0f0b1f_af6746e9","line":1,"range":{"start_line":1,"start_character":0,"end_line":1,"end_character":3},"updated":"2017-05-24 06:38:56.000000000","message":"Please see https://github.com/openstack/manila/blob/master/releasenotes/notes/bug-1578328-fix-replica-deletion-in-cDOT-7e4502fb50b69507.yaml","commit_id":"8c9a0aca44c0dadd962ff1f04e4a52a5e7843fa2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d7607738877108cd28d6f370564f3220ffef78b3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Fix tap device disappear after node restart that can not reach"},{"line_number":4,"context_line":"    into OVS to plug in to the integration bridge"},{"line_number":5,"context_line":"fixes:"},{"line_number":6,"context_line":"  - bug 1688155"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f044301_50c9a0a9","line":4,"range":{"start_line":2,"start_character":0,"end_line":4,"end_character":49},"updated":"2017-05-11 10:37:04.000000000","message":"It is not feature. It is only bugfix.","commit_id":"8c9a0aca44c0dadd962ff1f04e4a52a5e7843fa2"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d7607738877108cd28d6f370564f3220ffef78b3","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - Fix tap device disappear after node restart that can not reach"},{"line_number":4,"context_line":"    into OVS to plug in to the integration bridge"},{"line_number":5,"context_line":"fixes:"},{"line_number":6,"context_line":"  - bug 1688155"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f044301_903848a0","line":6,"range":{"start_line":6,"start_character":4,"end_line":6,"end_character":15},"updated":"2017-05-11 10:37:04.000000000","message":"Description should be here. You fix specific share driver. It should be mentioned explicitly.","commit_id":"8c9a0aca44c0dadd962ff1f04e4a52a5e7843fa2"}]}
