)]}'
{"manila/api/openstack/api_version_request.py":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"9c9769ac5a04e7274f8ffc1b6dddf7a8d954e451","unresolved":false,"context_lines":[{"line_number":102,"context_line":"             access_list API."},{"line_number":103,"context_line":"    * 2.34 - Added \u0027availability_zone_id\u0027 and \u0027consistent_snapshot_support\u0027"},{"line_number":104,"context_line":"             fields to \u0027share_group\u0027 object."},{"line_number":105,"context_line":"    * 2.36 - Add like filter support in ``shares``, ``snapshots``,"},{"line_number":106,"context_line":"             ``share-networks``, ``share-groups`` list APIs."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"\"\"\""},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3f1d235d_bd1aa314","line":106,"range":{"start_line":105,"start_character":4,"end_line":106,"end_character":60},"updated":"2017-06-29 07:10:08.000000000","message":"why is 2.36 not 2.35?","commit_id":"1050ad2235b38098dccd558173fdcba9c3eb7787"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ba28440cad0784d0619b9dd4889e655fccc3796f","unresolved":false,"context_lines":[{"line_number":102,"context_line":"             access_list API."},{"line_number":103,"context_line":"    * 2.34 - Added \u0027availability_zone_id\u0027 and \u0027consistent_snapshot_support\u0027"},{"line_number":104,"context_line":"             fields to \u0027share_group\u0027 object."},{"line_number":105,"context_line":"    * 2.36 - Add like filter support in ``shares``, ``snapshots``,"},{"line_number":106,"context_line":"             ``share-networks``, ``share-groups`` list APIs."},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"\"\"\""},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3f1d235d_c94ec1c0","line":106,"range":{"start_line":105,"start_character":4,"end_line":106,"end_character":60},"in_reply_to":"3f1d235d_bd1aa314","updated":"2017-06-29 09:12:13.000000000","message":"Because I think this will be merged after export location filter :)","commit_id":"1050ad2235b38098dccd558173fdcba9c3eb7787"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"3c1ff51a630273de3559a65c2a51008e7ae5f071","unresolved":false,"context_lines":[{"line_number":104,"context_line":"             fields to \u0027share_group\u0027 object."},{"line_number":105,"context_line":"    * 2.35 - Added support to retrieve shares filtered by export_location_id"},{"line_number":106,"context_line":"             and export_location_path."},{"line_number":107,"context_line":"    * 2.36 - Add like filter support in ``shares``, ``snapshots``,"},{"line_number":108,"context_line":"             ``share-networks``, ``share-groups`` list APIs."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":26,"id":"3f1d235d_7d089290","line":107,"range":{"start_line":107,"start_character":13,"end_line":107,"end_character":16},"updated":"2017-07-10 01:37:01.000000000","message":"nit: Added","commit_id":"f76a3acdb32e23a51e81909a88bb3e694d3a7726"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"093224f076fea6f03fdf491896740b30383c269c","unresolved":false,"context_lines":[{"line_number":104,"context_line":"             fields to \u0027share_group\u0027 object."},{"line_number":105,"context_line":"    * 2.35 - Added support to retrieve shares filtered by export_location_id"},{"line_number":106,"context_line":"             and export_location_path."},{"line_number":107,"context_line":"    * 2.36 - Add like filter support in ``shares``, ``snapshots``,"},{"line_number":108,"context_line":"             ``share-networks``, ``share-groups`` list APIs."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"\"\"\""}],"source_content_type":"text/x-python","patch_set":26,"id":"3f1d235d_9ef8e17c","line":107,"range":{"start_line":107,"start_character":13,"end_line":107,"end_character":16},"in_reply_to":"3f1d235d_7d089290","updated":"2017-07-10 03:03:17.000000000","message":"Done","commit_id":"f76a3acdb32e23a51e81909a88bb3e694d3a7726"}],"manila/api/openstack/rest_api_version_history.rst":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"9c9769ac5a04e7274f8ffc1b6dddf7a8d954e451","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"2.36"},{"line_number":205,"context_line":"----"},{"line_number":206,"context_line":" Added like filter support in ``shares``, ``snapshots``, ``share-networks``,"},{"line_number":207,"context_line":" ``share-groups`` list APIs."}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f1d235d_1de197ff","line":206,"range":{"start_line":206,"start_character":0,"end_line":206,"end_character":2},"updated":"2017-06-29 07:10:08.000000000","message":"one more blank space","commit_id":"1050ad2235b38098dccd558173fdcba9c3eb7787"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ba28440cad0784d0619b9dd4889e655fccc3796f","unresolved":false,"context_lines":[{"line_number":203,"context_line":""},{"line_number":204,"context_line":"2.36"},{"line_number":205,"context_line":"----"},{"line_number":206,"context_line":" Added like filter support in ``shares``, ``snapshots``, ``share-networks``,"},{"line_number":207,"context_line":" ``share-groups`` list APIs."}],"source_content_type":"text/x-rst","patch_set":16,"id":"3f1d235d_6967ad27","line":206,"range":{"start_line":206,"start_character":0,"end_line":206,"end_character":2},"in_reply_to":"3f1d235d_1de197ff","updated":"2017-06-29 09:12:13.000000000","message":"Done","commit_id":"1050ad2235b38098dccd558173fdcba9c3eb7787"}],"manila/api/v1/share_snapshots.py":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"9c9769ac5a04e7274f8ffc1b6dddf7a8d954e451","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    def _get_snapshots_search_options(self):"},{"line_number":126,"context_line":"        \"\"\"Return share snapshot search options allowed by non-admin.\"\"\""},{"line_number":127,"context_line":"        return (\u0027display_name\u0027, \u0027name\u0027, \u0027status\u0027, \u0027share_id\u0027, \u0027size\u0027,"},{"line_number":128,"context_line":"                \u0027name~\u0027, \u0027description~\u0027)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def update(self, req, id, body):"},{"line_number":131,"context_line":"        \"\"\"Update a snapshot.\"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"3f1d235d_9d9a476c","line":128,"range":{"start_line":128,"start_character":26,"end_line":128,"end_character":40},"updated":"2017-06-29 07:10:08.000000000","message":"As we gonna support \u0027description\u0027 for inexact match within this patch, how about add \u0027description\u0027 for exact match here?","commit_id":"1050ad2235b38098dccd558173fdcba9c3eb7787"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ba28440cad0784d0619b9dd4889e655fccc3796f","unresolved":false,"context_lines":[{"line_number":125,"context_line":"    def _get_snapshots_search_options(self):"},{"line_number":126,"context_line":"        \"\"\"Return share snapshot search options allowed by non-admin.\"\"\""},{"line_number":127,"context_line":"        return (\u0027display_name\u0027, \u0027name\u0027, \u0027status\u0027, \u0027share_id\u0027, \u0027size\u0027,"},{"line_number":128,"context_line":"                \u0027name~\u0027, \u0027description~\u0027)"},{"line_number":129,"context_line":""},{"line_number":130,"context_line":"    def update(self, req, id, body):"},{"line_number":131,"context_line":"        \"\"\"Update a snapshot.\"\"\""}],"source_content_type":"text/x-python","patch_set":16,"id":"3f1d235d_a9f9454e","line":128,"range":{"start_line":128,"start_character":26,"end_line":128,"end_character":40},"in_reply_to":"3f1d235d_9d9a476c","updated":"2017-06-29 09:12:13.000000000","message":"It will open another patch to do it.","commit_id":"1050ad2235b38098dccd558173fdcba9c3eb7787"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"3c1ff51a630273de3559a65c2a51008e7ae5f071","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        # NOTE(vponomaryov): Manila stores in DB key \u0027display_name\u0027, but"},{"line_number":99,"context_line":"        # allows to use both keys \u0027name\u0027 and \u0027display_name\u0027. It is leftover"},{"line_number":100,"context_line":"        # from Cinder v1 and v2 APIs."},{"line_number":101,"context_line":"        if \u0027name\u0027 in search_opts:"},{"line_number":102,"context_line":"            search_opts[\u0027display_name\u0027] \u003d search_opts.pop(\u0027name\u0027)"},{"line_number":103,"context_line":"        if \u0027name~\u0027 in search_opts:"},{"line_number":104,"context_line":"            search_opts[\u0027display_name~\u0027] \u003d search_opts.pop(\u0027name~\u0027)"},{"line_number":105,"context_line":"        if \u0027description~\u0027 in search_opts:"},{"line_number":106,"context_line":"            search_opts[\u0027display_description~\u0027] \u003d ("},{"line_number":107,"context_line":"                search_opts.pop(\u0027description~\u0027))"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        common.remove_invalid_options("},{"line_number":110,"context_line":"            context, search_opts, self._get_snapshots_search_options())"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f1d235d_5b2dbba6","line":107,"range":{"start_line":101,"start_character":8,"end_line":107,"end_character":48},"updated":"2017-07-10 01:37:01.000000000","message":"nit:\n```\nfor key, db_key in ((\u0027name\u0027, \u0027display_name\u0027), ...):\n   if key in search_opts:\n      search_opts[db_key] \u003d search_opts.pop(key)\n```","commit_id":"f76a3acdb32e23a51e81909a88bb3e694d3a7726"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"093224f076fea6f03fdf491896740b30383c269c","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        # NOTE(vponomaryov): Manila stores in DB key \u0027display_name\u0027, but"},{"line_number":99,"context_line":"        # allows to use both keys \u0027name\u0027 and \u0027display_name\u0027. It is leftover"},{"line_number":100,"context_line":"        # from Cinder v1 and v2 APIs."},{"line_number":101,"context_line":"        if \u0027name\u0027 in search_opts:"},{"line_number":102,"context_line":"            search_opts[\u0027display_name\u0027] \u003d search_opts.pop(\u0027name\u0027)"},{"line_number":103,"context_line":"        if \u0027name~\u0027 in search_opts:"},{"line_number":104,"context_line":"            search_opts[\u0027display_name~\u0027] \u003d search_opts.pop(\u0027name~\u0027)"},{"line_number":105,"context_line":"        if \u0027description~\u0027 in search_opts:"},{"line_number":106,"context_line":"            search_opts[\u0027display_description~\u0027] \u003d ("},{"line_number":107,"context_line":"                search_opts.pop(\u0027description~\u0027))"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"        common.remove_invalid_options("},{"line_number":110,"context_line":"            context, search_opts, self._get_snapshots_search_options())"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f1d235d_215f70e6","line":107,"range":{"start_line":101,"start_character":8,"end_line":107,"end_character":48},"in_reply_to":"3f1d235d_5b2dbba6","updated":"2017-07-10 03:03:17.000000000","message":"Done","commit_id":"f76a3acdb32e23a51e81909a88bb3e694d3a7726"}],"manila/api/v1/shares.py":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"9c9769ac5a04e7274f8ffc1b6dddf7a8d954e451","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            \u0027share_type_id\u0027, \u0027snapshot_id\u0027, \u0027host\u0027, \u0027share_network_id\u0027,"},{"line_number":165,"context_line":"            \u0027is_public\u0027, \u0027metadata\u0027, \u0027extra_specs\u0027, \u0027sort_key\u0027, \u0027sort_dir\u0027,"},{"line_number":166,"context_line":"            \u0027share_group_id\u0027, \u0027share_group_snapshot_id\u0027, \u0027name~\u0027,"},{"line_number":167,"context_line":"            \u0027description~\u0027"},{"line_number":168,"context_line":"        )"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def update(self, req, id, body):"}],"source_content_type":"text/x-python","patch_set":16,"id":"3f1d235d_7d13ebb9","line":167,"range":{"start_line":167,"start_character":12,"end_line":167,"end_character":26},"updated":"2017-06-29 07:10:08.000000000","message":"See the previous comment.","commit_id":"1050ad2235b38098dccd558173fdcba9c3eb7787"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ba28440cad0784d0619b9dd4889e655fccc3796f","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            \u0027share_type_id\u0027, \u0027snapshot_id\u0027, \u0027host\u0027, \u0027share_network_id\u0027,"},{"line_number":165,"context_line":"            \u0027is_public\u0027, \u0027metadata\u0027, \u0027extra_specs\u0027, \u0027sort_key\u0027, \u0027sort_dir\u0027,"},{"line_number":166,"context_line":"            \u0027share_group_id\u0027, \u0027share_group_snapshot_id\u0027, \u0027name~\u0027,"},{"line_number":167,"context_line":"            \u0027description~\u0027"},{"line_number":168,"context_line":"        )"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    def update(self, req, id, body):"}],"source_content_type":"text/x-python","patch_set":16,"id":"3f1d235d_a98ee5cd","line":167,"range":{"start_line":167,"start_character":12,"end_line":167,"end_character":26},"in_reply_to":"3f1d235d_7d13ebb9","updated":"2017-06-29 09:12:13.000000000","message":"above","commit_id":"1050ad2235b38098dccd558173fdcba9c3eb7787"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"3c1ff51a630273de3559a65c2a51008e7ae5f071","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            search_opts[\u0027extra_specs\u0027] \u003d ast.literal_eval("},{"line_number":135,"context_line":"                search_opts[\u0027extra_specs\u0027])"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        # NOTE(vponomaryov): Manila stores in DB key \u0027display_name\u0027, but"},{"line_number":138,"context_line":"        # allows to use both keys \u0027name\u0027 and \u0027display_name\u0027. It is leftover"},{"line_number":139,"context_line":"        # from Cinder v1 and v2 APIs."},{"line_number":140,"context_line":"        if \u0027name\u0027 in search_opts:"},{"line_number":141,"context_line":"            search_opts[\u0027display_name\u0027] \u003d search_opts.pop(\u0027name\u0027)"},{"line_number":142,"context_line":"        if \u0027name~\u0027 in search_opts:"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f1d235d_1b198387","line":139,"range":{"start_line":137,"start_character":7,"end_line":139,"end_character":37},"updated":"2017-07-10 01:37:01.000000000","message":"Update the Notes here.","commit_id":"f76a3acdb32e23a51e81909a88bb3e694d3a7726"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"093224f076fea6f03fdf491896740b30383c269c","unresolved":false,"context_lines":[{"line_number":134,"context_line":"            search_opts[\u0027extra_specs\u0027] \u003d ast.literal_eval("},{"line_number":135,"context_line":"                search_opts[\u0027extra_specs\u0027])"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        # NOTE(vponomaryov): Manila stores in DB key \u0027display_name\u0027, but"},{"line_number":138,"context_line":"        # allows to use both keys \u0027name\u0027 and \u0027display_name\u0027. It is leftover"},{"line_number":139,"context_line":"        # from Cinder v1 and v2 APIs."},{"line_number":140,"context_line":"        if \u0027name\u0027 in search_opts:"},{"line_number":141,"context_line":"            search_opts[\u0027display_name\u0027] \u003d search_opts.pop(\u0027name\u0027)"},{"line_number":142,"context_line":"        if \u0027name~\u0027 in search_opts:"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f1d235d_e13f3885","line":139,"range":{"start_line":137,"start_character":7,"end_line":139,"end_character":37},"in_reply_to":"3f1d235d_1b198387","updated":"2017-07-10 03:03:17.000000000","message":"Done","commit_id":"f76a3acdb32e23a51e81909a88bb3e694d3a7726"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"3c1ff51a630273de3559a65c2a51008e7ae5f071","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        # NOTE(vponomaryov): Manila stores in DB key \u0027display_name\u0027, but"},{"line_number":138,"context_line":"        # allows to use both keys \u0027name\u0027 and \u0027display_name\u0027. It is leftover"},{"line_number":139,"context_line":"        # from Cinder v1 and v2 APIs."},{"line_number":140,"context_line":"        if \u0027name\u0027 in search_opts:"},{"line_number":141,"context_line":"            search_opts[\u0027display_name\u0027] \u003d search_opts.pop(\u0027name\u0027)"},{"line_number":142,"context_line":"        if \u0027name~\u0027 in search_opts:"},{"line_number":143,"context_line":"            search_opts[\u0027display_name~\u0027] \u003d search_opts.pop(\u0027name~\u0027)"},{"line_number":144,"context_line":"        if \u0027description~\u0027 in search_opts:"},{"line_number":145,"context_line":"            search_opts[\u0027display_description~\u0027] \u003d ("},{"line_number":146,"context_line":"                search_opts.pop(\u0027description~\u0027))"},{"line_number":147,"context_line":"        if sort_key \u003d\u003d \u0027name\u0027:"},{"line_number":148,"context_line":"            sort_key \u003d \u0027display_name\u0027"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"3f1d235d_3b2aff8f","line":146,"range":{"start_line":140,"start_character":6,"end_line":146,"end_character":48},"updated":"2017-07-10 01:37:01.000000000","message":"ditto","commit_id":"f76a3acdb32e23a51e81909a88bb3e694d3a7726"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"093224f076fea6f03fdf491896740b30383c269c","unresolved":false,"context_lines":[{"line_number":137,"context_line":"        # NOTE(vponomaryov): Manila stores in DB key \u0027display_name\u0027, but"},{"line_number":138,"context_line":"        # allows to use both keys \u0027name\u0027 and \u0027display_name\u0027. It is leftover"},{"line_number":139,"context_line":"        # from Cinder v1 and v2 APIs."},{"line_number":140,"context_line":"        if \u0027name\u0027 in search_opts:"},{"line_number":141,"context_line":"            search_opts[\u0027display_name\u0027] \u003d search_opts.pop(\u0027name\u0027)"},{"line_number":142,"context_line":"        if \u0027name~\u0027 in search_opts:"},{"line_number":143,"context_line":"            search_opts[\u0027display_name~\u0027] \u003d search_opts.pop(\u0027name~\u0027)"},{"line_number":144,"context_line":"        if \u0027description~\u0027 in search_opts:"},{"line_number":145,"context_line":"            search_opts[\u0027display_description~\u0027] \u003d ("},{"line_number":146,"context_line":"                search_opts.pop(\u0027description~\u0027))"},{"line_number":147,"context_line":"        if sort_key \u003d\u003d \u0027name\u0027:"},{"line_number":148,"context_line":"            sort_key \u003d \u0027display_name\u0027"},{"line_number":149,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"3f1d235d_c1443c1e","line":146,"range":{"start_line":140,"start_character":6,"end_line":146,"end_character":48},"in_reply_to":"3f1d235d_3b2aff8f","updated":"2017-07-10 03:03:17.000000000","message":"Done","commit_id":"f76a3acdb32e23a51e81909a88bb3e694d3a7726"}],"manila/api/v2/share_networks.py":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"3c1ff51a630273de3559a65c2a51008e7ae5f071","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                                (value in network.get(key.rstrip(\u0027~\u0027))"},{"line_number":175,"context_line":"                                 if network.get(key.rstrip(\u0027~\u0027)) else ())]"},{"line_number":176,"context_line":"                else:"},{"line_number":177,"context_line":"                    networks \u003d [network for network in networks"},{"line_number":178,"context_line":"                                if network.get(key) \u003d\u003d value]"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        limited_list \u003d common.limited(networks, req)"},{"line_number":181,"context_line":"        return self._view_builder.build_share_networks("}],"source_content_type":"text/x-python","patch_set":26,"id":"3f1d235d_7e3745e5","line":178,"range":{"start_line":177,"start_character":20,"end_line":178,"end_character":61},"updated":"2017-07-10 01:37:01.000000000","message":"This code block is not easy to understand.\nHow about:\n```\nif (req.api_version_request \u003e\u003d api_version.APIVersionRequest(\"2.36\")) and key.endswith(\u0027~\u0027):\n   key \u003d key.rstrip(\u0027~\u0027)\n   networks \u003d [network for network in networks\n                                value in network.get(key)]\nelse:\n   networks \u003d [network for network in networks\n                                if network.get(key) \u003d\u003d value]\n```","commit_id":"f76a3acdb32e23a51e81909a88bb3e694d3a7726"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"093224f076fea6f03fdf491896740b30383c269c","unresolved":false,"context_lines":[{"line_number":174,"context_line":"                                (value in network.get(key.rstrip(\u0027~\u0027))"},{"line_number":175,"context_line":"                                 if network.get(key.rstrip(\u0027~\u0027)) else ())]"},{"line_number":176,"context_line":"                else:"},{"line_number":177,"context_line":"                    networks \u003d [network for network in networks"},{"line_number":178,"context_line":"                                if network.get(key) \u003d\u003d value]"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"        limited_list \u003d common.limited(networks, req)"},{"line_number":181,"context_line":"        return self._view_builder.build_share_networks("}],"source_content_type":"text/x-python","patch_set":26,"id":"3f1d235d_217890f6","line":178,"range":{"start_line":177,"start_character":20,"end_line":178,"end_character":61},"in_reply_to":"3f1d235d_7e3745e5","updated":"2017-07-10 03:03:17.000000000","message":"About the original code block. I think it could be easy understand what we should do when api version \u003e\u003d 2.36 or \u003c 2.36 (Two code branch). and save the original logic that we can run \"network for network in networks if network.get(key) \u003d\u003d value\" if key.endswith(\u0027~\u0027) is true.(Although we don\u0027t use it now)","commit_id":"f76a3acdb32e23a51e81909a88bb3e694d3a7726"}],"manila/db/sqlalchemy/api.py":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"3c1ff51a630273de3559a65c2a51008e7ae5f071","unresolved":false,"context_lines":[{"line_number":3903,"context_line":"        filters \u003d {}"},{"line_number":3904,"context_line":"    no_key \u003d \u0027key_is_absent\u0027"},{"line_number":3905,"context_line":"    for k, v in filters.items():"},{"line_number":3906,"context_line":"        temp_k \u003d k"},{"line_number":3907,"context_line":"        if k in constants.LIKE_FILTER:"},{"line_number":3908,"context_line":"            temp_k \u003d k.rstrip(\u0027~\u0027)"},{"line_number":3909,"context_line":"        filter_attr \u003d getattr(models.ShareGroup, temp_k, no_key)"},{"line_number":3910,"context_line":""},{"line_number":3911,"context_line":"        if filter_attr \u003d\u003d no_key:"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f1d235d_988a5c61","line":3908,"range":{"start_line":3906,"start_character":7,"end_line":3908,"end_character":34},"updated":"2017-07-10 01:37:01.000000000","message":"temp_k \u003d k.rstrip(\u0027~\u0027) if k in constants.LIKE_FILTER else k","commit_id":"f76a3acdb32e23a51e81909a88bb3e694d3a7726"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"093224f076fea6f03fdf491896740b30383c269c","unresolved":false,"context_lines":[{"line_number":3903,"context_line":"        filters \u003d {}"},{"line_number":3904,"context_line":"    no_key \u003d \u0027key_is_absent\u0027"},{"line_number":3905,"context_line":"    for k, v in filters.items():"},{"line_number":3906,"context_line":"        temp_k \u003d k"},{"line_number":3907,"context_line":"        if k in constants.LIKE_FILTER:"},{"line_number":3908,"context_line":"            temp_k \u003d k.rstrip(\u0027~\u0027)"},{"line_number":3909,"context_line":"        filter_attr \u003d getattr(models.ShareGroup, temp_k, no_key)"},{"line_number":3910,"context_line":""},{"line_number":3911,"context_line":"        if filter_attr \u003d\u003d no_key:"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f1d235d_fef35572","line":3908,"range":{"start_line":3906,"start_character":7,"end_line":3908,"end_character":34},"in_reply_to":"3f1d235d_988a5c61","updated":"2017-07-10 03:03:17.000000000","message":"Done","commit_id":"f76a3acdb32e23a51e81909a88bb3e694d3a7726"}],"manila/tests/api/v2/test_shares.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"4c8a9ebd8da9bf48533943227dbfc80e37221356","unresolved":false,"context_lines":[{"line_number":1525,"context_line":"            search_opts.update("},{"line_number":1526,"context_line":"                {\u0027display_name~\u0027: \u0027fake_name\u0027,"},{"line_number":1527,"context_line":"                 \u0027display_description~\u0027: \u0027fake_value\u0027})"},{"line_number":1528,"context_line":"        else:"},{"line_number":1529,"context_line":"            search_opts.update({\u0027name\u0027: \u0027fake_name\u0027})"},{"line_number":1530,"context_line":"        if use_admin_context:"},{"line_number":1531,"context_line":"            search_opts[\u0027host\u0027] \u003d \u0027fake_host\u0027"}],"source_content_type":"text/x-python","patch_set":24,"id":"3f1d235d_3d96e594","line":1528,"range":{"start_line":1528,"start_character":8,"end_line":1528,"end_character":13},"updated":"2017-07-05 16:36:44.000000000","message":"Well, the exact search is still valid with the microversion change, but you won\u0027t be testing it in the new microversion.","commit_id":"9bb1861a9771c39d010c08602db20de349057dd3"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ae75e973c39b533c122ef4d0ae53c23c44b2bf0b","unresolved":false,"context_lines":[{"line_number":1525,"context_line":"            search_opts.update("},{"line_number":1526,"context_line":"                {\u0027display_name~\u0027: \u0027fake_name\u0027,"},{"line_number":1527,"context_line":"                 \u0027display_description~\u0027: \u0027fake_value\u0027})"},{"line_number":1528,"context_line":"        else:"},{"line_number":1529,"context_line":"            search_opts.update({\u0027name\u0027: \u0027fake_name\u0027})"},{"line_number":1530,"context_line":"        if use_admin_context:"},{"line_number":1531,"context_line":"            search_opts[\u0027host\u0027] \u003d \u0027fake_host\u0027"}],"source_content_type":"text/x-python","patch_set":24,"id":"3f1d235d_720118af","line":1528,"range":{"start_line":1528,"start_character":8,"end_line":1528,"end_character":13},"in_reply_to":"3f1d235d_3d96e594","updated":"2017-07-06 03:39:16.000000000","message":"Done","commit_id":"9bb1861a9771c39d010c08602db20de349057dd3"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"4c8a9ebd8da9bf48533943227dbfc80e37221356","unresolved":false,"context_lines":[{"line_number":1562,"context_line":"                search_opts[\u0027export_location_id\u0027])"},{"line_number":1563,"context_line":"            search_opts_expected[\u0027export_location_path\u0027] \u003d ("},{"line_number":1564,"context_line":"                search_opts[\u0027export_location_path\u0027])"},{"line_number":1565,"context_line":"        if (api_version.APIVersionRequest(version) \u003e\u003d"},{"line_number":1566,"context_line":"                api_version.APIVersionRequest(\u00272.36\u0027)):"},{"line_number":1567,"context_line":"            search_opts_expected.update("},{"line_number":1568,"context_line":"                {\u0027display_name~\u0027: \u0027fake_name\u0027,"},{"line_number":1569,"context_line":"                 \u0027display_description~\u0027: \u0027fake_value\u0027})"},{"line_number":1570,"context_line":"        else:"},{"line_number":1571,"context_line":"            search_opts_expected.update({\u0027display_name\u0027: search_opts[\u0027name\u0027]})"},{"line_number":1572,"context_line":""},{"line_number":1573,"context_line":"        if use_admin_context:"},{"line_number":1574,"context_line":"            search_opts_expected.update({\u0027fake_key\u0027: \u0027fake_value\u0027})"}],"source_content_type":"text/x-python","patch_set":24,"id":"3f1d235d_fd8bcd64","line":1571,"range":{"start_line":1565,"start_character":0,"end_line":1571,"end_character":78},"updated":"2017-07-05 16:36:44.000000000","message":"ditto","commit_id":"9bb1861a9771c39d010c08602db20de349057dd3"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ae75e973c39b533c122ef4d0ae53c23c44b2bf0b","unresolved":false,"context_lines":[{"line_number":1562,"context_line":"                search_opts[\u0027export_location_id\u0027])"},{"line_number":1563,"context_line":"            search_opts_expected[\u0027export_location_path\u0027] \u003d ("},{"line_number":1564,"context_line":"                search_opts[\u0027export_location_path\u0027])"},{"line_number":1565,"context_line":"        if (api_version.APIVersionRequest(version) \u003e\u003d"},{"line_number":1566,"context_line":"                api_version.APIVersionRequest(\u00272.36\u0027)):"},{"line_number":1567,"context_line":"            search_opts_expected.update("},{"line_number":1568,"context_line":"                {\u0027display_name~\u0027: \u0027fake_name\u0027,"},{"line_number":1569,"context_line":"                 \u0027display_description~\u0027: \u0027fake_value\u0027})"},{"line_number":1570,"context_line":"        else:"},{"line_number":1571,"context_line":"            search_opts_expected.update({\u0027display_name\u0027: search_opts[\u0027name\u0027]})"},{"line_number":1572,"context_line":""},{"line_number":1573,"context_line":"        if use_admin_context:"},{"line_number":1574,"context_line":"            search_opts_expected.update({\u0027fake_key\u0027: \u0027fake_value\u0027})"}],"source_content_type":"text/x-python","patch_set":24,"id":"3f1d235d_52fcdcb3","line":1571,"range":{"start_line":1565,"start_character":0,"end_line":1571,"end_character":78},"in_reply_to":"3f1d235d_fd8bcd64","updated":"2017-07-06 03:39:16.000000000","message":"Done","commit_id":"9bb1861a9771c39d010c08602db20de349057dd3"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"48778c1eb36e403fe8397ad99d16074db3767958","unresolved":false,"context_lines":[{"line_number":1523,"context_line":"            \u0027export_location_id\u0027: \u0027fake_export_location_id\u0027,"},{"line_number":1524,"context_line":"            \u0027export_location_path\u0027: \u0027fake_export_location_path\u0027,"},{"line_number":1525,"context_line":"        }"},{"line_number":1526,"context_line":"        if (api_version.APIVersionRequest(version) \u003e\u003d"},{"line_number":1527,"context_line":"                api_version.APIVersionRequest(\u00272.36\u0027)):"},{"line_number":1528,"context_line":"            search_opts.update("},{"line_number":1529,"context_line":"                {\u0027display_name~\u0027: \u0027fake\u0027,"},{"line_number":1530,"context_line":"                 \u0027display_description~\u0027: \u0027fake\u0027})"},{"line_number":1531,"context_line":"        if use_admin_context:"},{"line_number":1532,"context_line":"            search_opts[\u0027host\u0027] \u003d \u0027fake_host\u0027"},{"line_number":1533,"context_line":"        # fake_key should be filtered for non-admin"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f1d235d_3047c3bf","line":1530,"range":{"start_line":1526,"start_character":0,"end_line":1530,"end_character":49},"updated":"2017-07-08 17:46:46.000000000","message":"Hmmm, my earlier point was that even when microversion is 2.36 or higher you should cover the exact match cases as well as the inexact match cases.  What you seem to have done is remove the exact match cases altogether, for all microversions.","commit_id":"f76a3acdb32e23a51e81909a88bb3e694d3a7726"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"093224f076fea6f03fdf491896740b30383c269c","unresolved":false,"context_lines":[{"line_number":1523,"context_line":"            \u0027export_location_id\u0027: \u0027fake_export_location_id\u0027,"},{"line_number":1524,"context_line":"            \u0027export_location_path\u0027: \u0027fake_export_location_path\u0027,"},{"line_number":1525,"context_line":"        }"},{"line_number":1526,"context_line":"        if (api_version.APIVersionRequest(version) \u003e\u003d"},{"line_number":1527,"context_line":"                api_version.APIVersionRequest(\u00272.36\u0027)):"},{"line_number":1528,"context_line":"            search_opts.update("},{"line_number":1529,"context_line":"                {\u0027display_name~\u0027: \u0027fake\u0027,"},{"line_number":1530,"context_line":"                 \u0027display_description~\u0027: \u0027fake\u0027})"},{"line_number":1531,"context_line":"        if use_admin_context:"},{"line_number":1532,"context_line":"            search_opts[\u0027host\u0027] \u003d \u0027fake_host\u0027"},{"line_number":1533,"context_line":"        # fake_key should be filtered for non-admin"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f1d235d_e1e5f8dd","line":1530,"range":{"start_line":1526,"start_character":0,"end_line":1530,"end_character":49},"in_reply_to":"3f1d235d_3047c3bf","updated":"2017-07-10 03:03:17.000000000","message":"Hi Tom, please see code line 1510. We will test exact match cases for all microversions. so even when microversion is 2.36 or higher we cover the exact match cases.","commit_id":"f76a3acdb32e23a51e81909a88bb3e694d3a7726"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"48778c1eb36e403fe8397ad99d16074db3767958","unresolved":false,"context_lines":[{"line_number":1564,"context_line":"                search_opts[\u0027export_location_id\u0027])"},{"line_number":1565,"context_line":"            search_opts_expected[\u0027export_location_path\u0027] \u003d ("},{"line_number":1566,"context_line":"                search_opts[\u0027export_location_path\u0027])"},{"line_number":1567,"context_line":"        if (api_version.APIVersionRequest(version) \u003e\u003d"},{"line_number":1568,"context_line":"                api_version.APIVersionRequest(\u00272.36\u0027)):"},{"line_number":1569,"context_line":"            search_opts_expected.update("},{"line_number":1570,"context_line":"                {\u0027display_name~\u0027: search_opts[\u0027display_name~\u0027],"},{"line_number":1571,"context_line":"                 \u0027display_description~\u0027: search_opts[\u0027display_description~\u0027]})"},{"line_number":1572,"context_line":""},{"line_number":1573,"context_line":"        if use_admin_context:"},{"line_number":1574,"context_line":"            search_opts_expected.update({\u0027fake_key\u0027: \u0027fake_value\u0027})"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f1d235d_1044c7b6","line":1571,"range":{"start_line":1567,"start_character":0,"end_line":1571,"end_character":78},"updated":"2017-07-08 17:46:46.000000000","message":"ditto","commit_id":"f76a3acdb32e23a51e81909a88bb3e694d3a7726"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"093224f076fea6f03fdf491896740b30383c269c","unresolved":false,"context_lines":[{"line_number":1564,"context_line":"                search_opts[\u0027export_location_id\u0027])"},{"line_number":1565,"context_line":"            search_opts_expected[\u0027export_location_path\u0027] \u003d ("},{"line_number":1566,"context_line":"                search_opts[\u0027export_location_path\u0027])"},{"line_number":1567,"context_line":"        if (api_version.APIVersionRequest(version) \u003e\u003d"},{"line_number":1568,"context_line":"                api_version.APIVersionRequest(\u00272.36\u0027)):"},{"line_number":1569,"context_line":"            search_opts_expected.update("},{"line_number":1570,"context_line":"                {\u0027display_name~\u0027: search_opts[\u0027display_name~\u0027],"},{"line_number":1571,"context_line":"                 \u0027display_description~\u0027: search_opts[\u0027display_description~\u0027]})"},{"line_number":1572,"context_line":""},{"line_number":1573,"context_line":"        if use_admin_context:"},{"line_number":1574,"context_line":"            search_opts_expected.update({\u0027fake_key\u0027: \u0027fake_value\u0027})"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f1d235d_a1f8207c","line":1571,"range":{"start_line":1567,"start_character":0,"end_line":1571,"end_character":78},"in_reply_to":"3f1d235d_1044c7b6","updated":"2017-07-10 03:03:17.000000000","message":"Please see code line 1551","commit_id":"f76a3acdb32e23a51e81909a88bb3e694d3a7726"}],"manila/tests/db/sqlalchemy/test_api.py":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"3c1ff51a630273de3559a65c2a51008e7ae5f071","unresolved":false,"context_lines":[{"line_number":816,"context_line":"    def test_share_group_get_all_by_like_filter(self):"},{"line_number":817,"context_line":"        expected_group \u003d db_utils.create_share_group("},{"line_number":818,"context_line":"            name\u003d\u0027test1\u0027, description\u003d\u0027test1\u0027)"},{"line_number":819,"context_line":"        db_utils.create_share_group()"},{"line_number":820,"context_line":""},{"line_number":821,"context_line":"        groups \u003d db_api.share_group_get_all("},{"line_number":822,"context_line":"            self.ctxt, detailed\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f1d235d_feec752a","line":819,"range":{"start_line":819,"start_character":8,"end_line":819,"end_character":37},"updated":"2017-07-10 01:37:01.000000000","message":"Create some share group which doesn\u0027t meet your requirement explicitly.","commit_id":"f76a3acdb32e23a51e81909a88bb3e694d3a7726"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"093224f076fea6f03fdf491896740b30383c269c","unresolved":false,"context_lines":[{"line_number":816,"context_line":"    def test_share_group_get_all_by_like_filter(self):"},{"line_number":817,"context_line":"        expected_group \u003d db_utils.create_share_group("},{"line_number":818,"context_line":"            name\u003d\u0027test1\u0027, description\u003d\u0027test1\u0027)"},{"line_number":819,"context_line":"        db_utils.create_share_group()"},{"line_number":820,"context_line":""},{"line_number":821,"context_line":"        groups \u003d db_api.share_group_get_all("},{"line_number":822,"context_line":"            self.ctxt, detailed\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f1d235d_012c7497","line":819,"range":{"start_line":819,"start_character":8,"end_line":819,"end_character":37},"in_reply_to":"3f1d235d_feec752a","updated":"2017-07-10 03:03:17.000000000","message":"Done","commit_id":"f76a3acdb32e23a51e81909a88bb3e694d3a7726"}],"manila_tempest_tests/tests/api/test_shares_actions.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"55b256326f25ad5b33c850f7a0dd53748c61a860","unresolved":false,"context_lines":[{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":340,"context_line":"    @base.skip_if_microversion_lt(\"2.36\")"},{"line_number":341,"context_line":"    def test_list_shares_with_detail_filter_by_unexisted_name(self):"},{"line_number":342,"context_line":"        # list shares by name, at least one share is expected"},{"line_number":343,"context_line":"        params \u003d {\"name~\": \u0027tempest-share\u0027}"},{"line_number":344,"context_line":"        shares \u003d self.shares_v2_client.list_shares_with_detail(params)"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f1d235d_89555ffd","line":341,"range":{"start_line":341,"start_character":47,"end_line":341,"end_character":56},"updated":"2017-07-09 14:47:24.000000000","message":"Change to nonexistent or not_exist","commit_id":"f76a3acdb32e23a51e81909a88bb3e694d3a7726"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"093224f076fea6f03fdf491896740b30383c269c","unresolved":false,"context_lines":[{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":340,"context_line":"    @base.skip_if_microversion_lt(\"2.36\")"},{"line_number":341,"context_line":"    def test_list_shares_with_detail_filter_by_unexisted_name(self):"},{"line_number":342,"context_line":"        # list shares by name, at least one share is expected"},{"line_number":343,"context_line":"        params \u003d {\"name~\": \u0027tempest-share\u0027}"},{"line_number":344,"context_line":"        shares \u003d self.shares_v2_client.list_shares_with_detail(params)"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f1d235d_5e7fe9aa","line":341,"range":{"start_line":341,"start_character":47,"end_line":341,"end_character":56},"in_reply_to":"3f1d235d_89555ffd","updated":"2017-07-10 03:03:17.000000000","message":"Done","commit_id":"f76a3acdb32e23a51e81909a88bb3e694d3a7726"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"bc6b1eadd21b9c813716de8f6a79ce705252e8e4","unresolved":false,"context_lines":[{"line_number":338,"context_line":""},{"line_number":339,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":340,"context_line":"    @base.skip_if_microversion_lt(\"2.36\")"},{"line_number":341,"context_line":"    def test_list_shares_with_detail_filter_by_nonexistent_name(self):"},{"line_number":342,"context_line":"        # list shares by name, at least one share is expected"},{"line_number":343,"context_line":"        params \u003d {\"name~\": \u0027tempest-share\u0027}"},{"line_number":344,"context_line":"        shares \u003d self.shares_v2_client.list_shares_with_detail(params)"}],"source_content_type":"text/x-python","patch_set":29,"id":"1f1a1f67_79b52dee","line":341,"range":{"start_line":341,"start_character":8,"end_line":341,"end_character":63},"updated":"2017-07-12 16:53:19.000000000","message":"Wrong test name. You filter by incomplete EXISTING name.","commit_id":"c96df66823b8b0ee327636834f76bf6a68f090e9"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"bc6b1eadd21b9c813716de8f6a79ce705252e8e4","unresolved":false,"context_lines":[{"line_number":341,"context_line":"    def test_list_shares_with_detail_filter_by_nonexistent_name(self):"},{"line_number":342,"context_line":"        # list shares by name, at least one share is expected"},{"line_number":343,"context_line":"        params \u003d {\"name~\": \u0027tempest-share\u0027}"},{"line_number":344,"context_line":"        shares \u003d self.shares_v2_client.list_shares_with_detail(params)"},{"line_number":345,"context_line":"        for share in shares:"},{"line_number":346,"context_line":"            self.assertIn(\u0027tempest-share\u0027, share[\"name\"])"},{"line_number":347,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"1f1a1f67_39cfb580","line":344,"range":{"start_line":344,"start_character":8,"end_line":344,"end_character":14},"updated":"2017-07-12 16:53:19.000000000","message":"Need to check that shares has values else you will not enter loop below.","commit_id":"c96df66823b8b0ee327636834f76bf6a68f090e9"}],"manila_tempest_tests/tests/api/test_shares_actions_negative.py":[{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"3c1ff51a630273de3559a65c2a51008e7ae5f071","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":170,"context_line":"    @base.skip_if_microversion_not_supported(\"2.35\")"},{"line_number":171,"context_line":"    def test_list_shares_with_like_filter_and_invalid_version(self):"},{"line_number":172,"context_line":"        # In API versions \u003cv2.36, querying the share API by inexact"},{"line_number":173,"context_line":"        # filter (name or description) should have no effect. Those"},{"line_number":174,"context_line":"        # filters were supported from v2.36"},{"line_number":175,"context_line":"        filters \u003d {"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f1d235d_decad99f","line":172,"range":{"start_line":172,"start_character":27,"end_line":172,"end_character":32},"updated":"2017-07-10 01:37:01.000000000","message":"nit: Missing empty space here.","commit_id":"f76a3acdb32e23a51e81909a88bb3e694d3a7726"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"093224f076fea6f03fdf491896740b30383c269c","unresolved":false,"context_lines":[{"line_number":169,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":170,"context_line":"    @base.skip_if_microversion_not_supported(\"2.35\")"},{"line_number":171,"context_line":"    def test_list_shares_with_like_filter_and_invalid_version(self):"},{"line_number":172,"context_line":"        # In API versions \u003cv2.36, querying the share API by inexact"},{"line_number":173,"context_line":"        # filter (name or description) should have no effect. Those"},{"line_number":174,"context_line":"        # filters were supported from v2.36"},{"line_number":175,"context_line":"        filters \u003d {"}],"source_content_type":"text/x-python","patch_set":26,"id":"3f1d235d_3e7c2db4","line":172,"range":{"start_line":172,"start_character":27,"end_line":172,"end_character":32},"in_reply_to":"3f1d235d_decad99f","updated":"2017-07-10 03:03:17.000000000","message":"Done","commit_id":"f76a3acdb32e23a51e81909a88bb3e694d3a7726"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"460ac8afbe0e8710b82b6f9bd92f6e8b3dbed20a","unresolved":false,"context_lines":[{"line_number":168,"context_line":""},{"line_number":169,"context_line":"    @tc.attr(base.TAG_NEGATIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":170,"context_line":"    @base.skip_if_microversion_not_supported(\"2.35\")"},{"line_number":171,"context_line":"    def test_list_shares_with_like_filter_and_invalid_version(self):"},{"line_number":172,"context_line":"        # In API versions \u003c v2.36, querying the share API by inexact"},{"line_number":173,"context_line":"        # filter (name or description) should have no effect. Those"},{"line_number":174,"context_line":"        # filters were supported from v2.36"}],"source_content_type":"text/x-python","patch_set":29,"id":"1f1a1f67_79aacd85","line":171,"range":{"start_line":171,"start_character":46,"end_line":171,"end_character":61},"updated":"2017-07-12 16:55:10.000000000","message":"Version is valid, just not supported for feature. Need to rename it.","commit_id":"c96df66823b8b0ee327636834f76bf6a68f090e9"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"460ac8afbe0e8710b82b6f9bd92f6e8b3dbed20a","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        # filter (name or description) should have no effect. Those"},{"line_number":174,"context_line":"        # filters were supported from v2.36"},{"line_number":175,"context_line":"        filters \u003d {"},{"line_number":176,"context_line":"            \u0027name~\u0027: \u0027fake\u0027,"},{"line_number":177,"context_line":"            \u0027description~\u0027: \u0027fake\u0027,"},{"line_number":178,"context_line":"        }"},{"line_number":179,"context_line":"        shares \u003d self.shares_v2_client.list_shares("},{"line_number":180,"context_line":"            params\u003dfilters, version\u003d\"2.35\")"}],"source_content_type":"text/x-python","patch_set":29,"id":"1f1a1f67_f99dbd66","line":177,"range":{"start_line":176,"start_character":12,"end_line":177,"end_character":35},"updated":"2017-07-12 16:55:10.000000000","message":"It is fragile to you such simple names that could be used by hands on the same lab. Better to use some random str-sequence generator.","commit_id":"c96df66823b8b0ee327636834f76bf6a68f090e9"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"d493ad64236d4b60fea5178227c097893471c997","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        # filter (name or description) should have no effect. Those"},{"line_number":174,"context_line":"        # filters were supported from v2.36"},{"line_number":175,"context_line":"        filters \u003d {"},{"line_number":176,"context_line":"            \u0027name~\u0027: \u0027fake\u0027,"},{"line_number":177,"context_line":"            \u0027description~\u0027: \u0027fake\u0027,"},{"line_number":178,"context_line":"        }"},{"line_number":179,"context_line":"        shares \u003d self.shares_v2_client.list_shares("},{"line_number":180,"context_line":"            params\u003dfilters, version\u003d\"2.35\")"}],"source_content_type":"text/x-python","patch_set":29,"id":"1f1a1f67_d973214d","line":177,"range":{"start_line":176,"start_character":12,"end_line":177,"end_character":35},"in_reply_to":"1f1a1f67_f99dbd66","updated":"2017-07-12 16:56:48.000000000","message":"s/to you/to use/","commit_id":"c96df66823b8b0ee327636834f76bf6a68f090e9"}]}
