)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"06e45b3e19d44e91c6c70be7b2bcad662bdfe04c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Refactoring for neatness and maintainability"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib74feeb0e01df9cb1e9d51b4897675562986b7f6"},{"line_number":13,"context_line":"Closes-Bug: #1688605"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f044301_520e878d","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":20},"updated":"2017-05-08 09:57:06.000000000","message":"It is not like a bug, it looks more like a blueprint.","commit_id":"b6864f13199dd4faeca2eb5e73f7e0598a1a2588"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"562a445d74e1eea24eee36d58343224108228737","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Refactoring for neatness and maintainability"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ib74feeb0e01df9cb1e9d51b4897675562986b7f6"},{"line_number":13,"context_line":"Closes-Bug: #1688605"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f044301_ff99d46d","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":20},"in_reply_to":"3f044301_520e878d","updated":"2017-05-08 17:35:32.000000000","message":"I can change this if refactoring would be considered a blueprint.  Please advise.","commit_id":"b6864f13199dd4faeca2eb5e73f7e0598a1a2588"}],"manila/share/drivers/dell_emc/common/enas/utils.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"c400226cbad00b5ec9360a39f2c7dbb3403687df","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_e77c3773","line":1,"updated":"2017-05-24 14:36:18.000000000","message":"Copyright header should not be changed as this is not a new file.","commit_id":"9700d5f22b6e897ae4c8a0f9e7fcdc5c93ff8915"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"da6aad7e367a8d2e74f7ff747092fd6156e80579","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_a7e99fe6","line":1,"in_reply_to":"ff0f0b1f_e77c3773","updated":"2017-05-24 14:42:32.000000000","message":"Thank Xing, we will change this and the others back to \n# Copyright (c) 2014 EMC Corporation.","commit_id":"9700d5f22b6e897ae4c8a0f9e7fcdc5c93ff8915"}],"manila/share/drivers/dell_emc/plugins/unity/connection.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"027d044ec013318c2f35aace7a8877f388200207","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from manila.common import constants as const"},{"line_number":29,"context_line":"from manila import exception"},{"line_number":30,"context_line":"from manila.i18n import _"},{"line_number":31,"context_line":"from manila.share.drivers.dell_emc.common.enas import utils as emc_utils"},{"line_number":32,"context_line":"from manila.share.drivers.dell_emc.plugins import base as driver"},{"line_number":33,"context_line":"from manila.share.drivers.dell_emc.plugins.unity import client"},{"line_number":34,"context_line":"from manila.share.drivers.dell_emc.plugins.unity import utils as unity_utils"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f231b9d_9a74669b","line":31,"updated":"2017-06-12 12:09:51.000000000","message":"You can change this to enas_utils to be consistent with vnx/connection.py.\n\nThere are only a couple of references to this lib in this file so it should be easy to replace.","commit_id":"9f98d9444e3e7a18a6d856b38594470deb82674a"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"ddcc82eb06471d35007aa24958d22349c0ececb3","unresolved":false,"context_lines":[{"line_number":28,"context_line":"from manila.common import constants as const"},{"line_number":29,"context_line":"from manila import exception"},{"line_number":30,"context_line":"from manila.i18n import _"},{"line_number":31,"context_line":"from manila.share.drivers.dell_emc.common.enas import utils as emc_utils"},{"line_number":32,"context_line":"from manila.share.drivers.dell_emc.plugins import base as driver"},{"line_number":33,"context_line":"from manila.share.drivers.dell_emc.plugins.unity import client"},{"line_number":34,"context_line":"from manila.share.drivers.dell_emc.plugins.unity import utils as unity_utils"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f201791_2c90634e","line":31,"in_reply_to":"7f231b9d_9a74669b","updated":"2017-06-22 10:28:23.000000000","message":"Sure. I will change it here.  Thank you","commit_id":"9f98d9444e3e7a18a6d856b38594470deb82674a"}],"manila/share/drivers/dell_emc/plugins/vmax/object_manager.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"06e45b3e19d44e91c6c70be7b2bcad662bdfe04c","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from manila.i18n import _"},{"line_number":28,"context_line":"from manila.share.drivers.dell_emc.common.enas import connector"},{"line_number":29,"context_line":"from manila.share.drivers.dell_emc.common.enas import constants"},{"line_number":30,"context_line":"from manila.share.drivers.dell_emc.common.enas import utils as vmax_utils"},{"line_number":31,"context_line":"from manila.share.drivers.dell_emc.common.enas import xml_api_parser as parser"},{"line_number":32,"context_line":"from manila import utils"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f044301_d207371c","line":30,"range":{"start_line":30,"start_character":62,"end_line":30,"end_character":67},"updated":"2017-05-08 09:57:06.000000000","message":"Why don\u0027t changed to enas?","commit_id":"b6864f13199dd4faeca2eb5e73f7e0598a1a2588"},{"author":{"_account_id":22021,"name":"Unana Okpoyo","email":"tomitu@yahoo.com","username":"UnanaOkpoyo"},"change_message_id":"354da5cb900c3166c0a68b498bd81bd3c3834c07","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from manila.i18n import _"},{"line_number":28,"context_line":"from manila.share.drivers.dell_emc.common.enas import connector"},{"line_number":29,"context_line":"from manila.share.drivers.dell_emc.common.enas import constants"},{"line_number":30,"context_line":"from manila.share.drivers.dell_emc.common.enas import utils as vmax_utils"},{"line_number":31,"context_line":"from manila.share.drivers.dell_emc.common.enas import xml_api_parser as parser"},{"line_number":32,"context_line":"from manila import utils"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f044301_bbd8077f","line":30,"range":{"start_line":30,"start_character":62,"end_line":30,"end_character":67},"in_reply_to":"3f044301_d207371c","updated":"2017-05-08 10:32:02.000000000","message":"Will update and resubmit","commit_id":"b6864f13199dd4faeca2eb5e73f7e0598a1a2588"}],"manila/share/drivers/dell_emc/plugins/vnx/connection.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"06e45b3e19d44e91c6c70be7b2bcad662bdfe04c","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from manila import exception"},{"line_number":27,"context_line":"from manila.i18n import _"},{"line_number":28,"context_line":"from manila.share.drivers.dell_emc.common.enas import constants"},{"line_number":29,"context_line":"from manila.share.drivers.dell_emc.common.enas import utils as vnx_utils"},{"line_number":30,"context_line":"from manila.share.drivers.dell_emc.plugins import base as driver"},{"line_number":31,"context_line":"from manila.share.drivers.dell_emc.plugins.vnx import object_manager as manager"},{"line_number":32,"context_line":"from manila.share import utils as share_utils"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f044301_3803dd0f","line":29,"range":{"start_line":29,"start_character":63,"end_line":29,"end_character":66},"updated":"2017-05-08 09:57:06.000000000","message":"Why don\u0027t change to enas?","commit_id":"b6864f13199dd4faeca2eb5e73f7e0598a1a2588"},{"author":{"_account_id":22021,"name":"Unana Okpoyo","email":"tomitu@yahoo.com","username":"UnanaOkpoyo"},"change_message_id":"354da5cb900c3166c0a68b498bd81bd3c3834c07","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from manila import exception"},{"line_number":27,"context_line":"from manila.i18n import _"},{"line_number":28,"context_line":"from manila.share.drivers.dell_emc.common.enas import constants"},{"line_number":29,"context_line":"from manila.share.drivers.dell_emc.common.enas import utils as vnx_utils"},{"line_number":30,"context_line":"from manila.share.drivers.dell_emc.plugins import base as driver"},{"line_number":31,"context_line":"from manila.share.drivers.dell_emc.plugins.vnx import object_manager as manager"},{"line_number":32,"context_line":"from manila.share import utils as share_utils"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f044301_fbf68ff9","line":29,"range":{"start_line":29,"start_character":63,"end_line":29,"end_character":66},"in_reply_to":"3f044301_3803dd0f","updated":"2017-05-08 10:32:02.000000000","message":"Will update and resubmit","commit_id":"b6864f13199dd4faeca2eb5e73f7e0598a1a2588"},{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"67f9590752ce16ef854caf1f203ee6c3683d8094","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from manila import exception"},{"line_number":27,"context_line":"from manila.i18n import _"},{"line_number":28,"context_line":"from manila.share.drivers.dell_emc.common.enas import constants"},{"line_number":29,"context_line":"from manila.share.drivers.dell_emc.common.enas import utils as enas_utils"},{"line_number":30,"context_line":"from manila.share.drivers.dell_emc.plugins import base as driver"},{"line_number":31,"context_line":"from manila.share.drivers.dell_emc.plugins.vnx import object_manager as manager"},{"line_number":32,"context_line":"from manila.share import utils as share_utils"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_beccaf61","line":29,"range":{"start_line":29,"start_character":63,"end_line":29,"end_character":73},"updated":"2017-06-02 01:08:52.000000000","message":"how about change to emc_utils to keep the consistent with unity/connection.py?","commit_id":"9f98d9444e3e7a18a6d856b38594470deb82674a"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"3c1ef9655457133f84da1465029c0c43f5c52009","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from manila import exception"},{"line_number":27,"context_line":"from manila.i18n import _"},{"line_number":28,"context_line":"from manila.share.drivers.dell_emc.common.enas import constants"},{"line_number":29,"context_line":"from manila.share.drivers.dell_emc.common.enas import utils as enas_utils"},{"line_number":30,"context_line":"from manila.share.drivers.dell_emc.plugins import base as driver"},{"line_number":31,"context_line":"from manila.share.drivers.dell_emc.plugins.vnx import object_manager as manager"},{"line_number":32,"context_line":"from manila.share import utils as share_utils"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f231b9d_3a1c3269","line":29,"range":{"start_line":29,"start_character":63,"end_line":29,"end_character":73},"in_reply_to":"df140735_6c4dedc2","updated":"2017-06-12 12:07:22.000000000","message":"Actually enas_utils makes more sense because this file is utils.py under the enas folder.","commit_id":"9f98d9444e3e7a18a6d856b38594470deb82674a"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"8ad75cdb881925552f54a51d0e5fe1df1a44cbc0","unresolved":false,"context_lines":[{"line_number":26,"context_line":"from manila import exception"},{"line_number":27,"context_line":"from manila.i18n import _"},{"line_number":28,"context_line":"from manila.share.drivers.dell_emc.common.enas import constants"},{"line_number":29,"context_line":"from manila.share.drivers.dell_emc.common.enas import utils as enas_utils"},{"line_number":30,"context_line":"from manila.share.drivers.dell_emc.plugins import base as driver"},{"line_number":31,"context_line":"from manila.share.drivers.dell_emc.plugins.vnx import object_manager as manager"},{"line_number":32,"context_line":"from manila.share import utils as share_utils"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_6c4dedc2","line":29,"range":{"start_line":29,"start_character":63,"end_line":29,"end_character":73},"in_reply_to":"ff0f0b1f_beccaf61","updated":"2017-06-02 09:20:31.000000000","message":"Hi Jay,\nWe already changed the name from vmax_utils to enas_utils based on feedback. As we are no longer EMC (now Dell EMC), we are inclined not to change it to emc_utils. I hope this is ok.  Thank you","commit_id":"9f98d9444e3e7a18a6d856b38594470deb82674a"}],"manila/tests/share/drivers/dell_emc/common/enas/fakes.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"c400226cbad00b5ec9360a39f2c7dbb3403687df","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_e7a317ff","line":1,"updated":"2017-05-24 14:36:18.000000000","message":"Copyright header should not be changed as this is not a new file.","commit_id":"9700d5f22b6e897ae4c8a0f9e7fcdc5c93ff8915"}],"manila/tests/share/drivers/dell_emc/common/enas/test_connector.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"1a689d045b7dd43a868374e27e32a0f0b6e1aa53","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from manila.share.drivers.dell_emc.common.enas import connector"},{"line_number":25,"context_line":"from manila import test"},{"line_number":26,"context_line":"from manila.tests.share.drivers.dell_emc.common.enas import fakes"},{"line_number":27,"context_line":"from manila.tests.share.drivers.dell_emc.common.enas import utils as emc_utils"},{"line_number":28,"context_line":"from manila import utils"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f013ff3_8ceb1caf","line":27,"range":{"start_line":27,"start_character":69,"end_line":27,"end_character":78},"updated":"2017-05-15 10:01:25.000000000","message":"The emc has been changed to dell. :)","commit_id":"b3a2e000fb629567469081a43f713857cb3cedff"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"1a689d045b7dd43a868374e27e32a0f0b6e1aa53","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from manila.share.drivers.dell_emc.common.enas import connector"},{"line_number":25,"context_line":"from manila import test"},{"line_number":26,"context_line":"from manila.tests.share.drivers.dell_emc.common.enas import fakes"},{"line_number":27,"context_line":"from manila.tests.share.drivers.dell_emc.common.enas import utils as emc_utils"},{"line_number":28,"context_line":"from manila import utils"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f013ff3_6ca2109d","line":27,"range":{"start_line":27,"start_character":69,"end_line":27,"end_character":72},"updated":"2017-05-15 10:01:25.000000000","message":"enas_utils?","commit_id":"b3a2e000fb629567469081a43f713857cb3cedff"},{"author":{"_account_id":22021,"name":"Unana Okpoyo","email":"tomitu@yahoo.com","username":"UnanaOkpoyo"},"change_message_id":"c1990c7a59fd6fdbedd70756a775c8a83af0333b","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from manila.share.drivers.dell_emc.common.enas import connector"},{"line_number":25,"context_line":"from manila import test"},{"line_number":26,"context_line":"from manila.tests.share.drivers.dell_emc.common.enas import fakes"},{"line_number":27,"context_line":"from manila.tests.share.drivers.dell_emc.common.enas import utils as emc_utils"},{"line_number":28,"context_line":"from manila import utils"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"1f013ff3_c0c205ea","line":27,"range":{"start_line":27,"start_character":69,"end_line":27,"end_character":78},"in_reply_to":"1f013ff3_8ceb1caf","updated":"2017-05-15 14:17:02.000000000","message":"It has indeed...Will change to dell_emc_utils","commit_id":"b3a2e000fb629567469081a43f713857cb3cedff"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"c400226cbad00b5ec9360a39f2c7dbb3403687df","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_279eafb8","line":1,"updated":"2017-05-24 14:36:18.000000000","message":"Copyright header should not be changed as this is not a new file.","commit_id":"9700d5f22b6e897ae4c8a0f9e7fcdc5c93ff8915"}],"manila/tests/share/drivers/dell_emc/common/enas/test_utils.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"c400226cbad00b5ec9360a39f2c7dbb3403687df","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2016 Dell Inc. or its subsidiaries."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_6749475e","line":1,"updated":"2017-05-24 14:36:18.000000000","message":"Copyright header should not be changed as this is not a new file.","commit_id":"9700d5f22b6e897ae4c8a0f9e7fcdc5c93ff8915"}],"manila/tests/share/drivers/dell_emc/common/enas/utils.py":[{"author":{"_account_id":11637,"name":"jay.xu","email":"jay.xu@emc.com","username":"jay.xu"},"change_message_id":"67f9590752ce16ef854caf1f203ee6c3683d8094","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        return True"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"def patch_get_managed_ports(*arg, **kwargs):"},{"line_number":165,"context_line":"    return mock.patch(\u0027manila.share.drivers.dell_emc.plugins.vnx.connection.\u0027"},{"line_number":166,"context_line":"                      \u0027VNXStorageConnection.get_managed_ports\u0027,"},{"line_number":167,"context_line":"                      mock.Mock(*arg, **kwargs))"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff0f0b1f_1e3a7be6","line":164,"updated":"2017-06-02 01:08:52.000000000","message":"how about change to patch_get_managed_ports_vnx as well?","commit_id":"9f98d9444e3e7a18a6d856b38594470deb82674a"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"8ad75cdb881925552f54a51d0e5fe1df1a44cbc0","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        return True"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"def patch_get_managed_ports(*arg, **kwargs):"},{"line_number":165,"context_line":"    return mock.patch(\u0027manila.share.drivers.dell_emc.plugins.vnx.connection.\u0027"},{"line_number":166,"context_line":"                      \u0027VNXStorageConnection.get_managed_ports\u0027,"},{"line_number":167,"context_line":"                      mock.Mock(*arg, **kwargs))"}],"source_content_type":"text/x-python","patch_set":5,"id":"df140735_ece7bdab","line":164,"in_reply_to":"ff0f0b1f_1e3a7be6","updated":"2017-06-02 09:20:31.000000000","message":"Sure, we can change this.  Thank you","commit_id":"9f98d9444e3e7a18a6d856b38594470deb82674a"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"eeb2a02f2560da6737d3c5c463241d08d9ce6551","unresolved":false,"context_lines":[{"line_number":161,"context_line":"        return True"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"def patch_get_managed_ports(*arg, **kwargs):"},{"line_number":165,"context_line":"    return mock.patch(\u0027manila.share.drivers.dell_emc.plugins.vnx.connection.\u0027"},{"line_number":166,"context_line":"                      \u0027VNXStorageConnection.get_managed_ports\u0027,"},{"line_number":167,"context_line":"                      mock.Mock(*arg, **kwargs))"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_7cc0fa2a","line":164,"range":{"start_line":164,"start_character":4,"end_line":164,"end_character":27},"updated":"2017-06-26 11:33:16.000000000","message":"ideally this should be renamed to patch_get_managed_ports_vnx","commit_id":"994cc4f5d9242b214034965c23999f966b24dbf6"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"eeb2a02f2560da6737d3c5c463241d08d9ce6551","unresolved":false,"context_lines":[{"line_number":162,"context_line":""},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"def patch_get_managed_ports(*arg, **kwargs):"},{"line_number":165,"context_line":"    return mock.patch(\u0027manila.share.drivers.dell_emc.plugins.vnx.connection.\u0027"},{"line_number":166,"context_line":"                      \u0027VNXStorageConnection.get_managed_ports\u0027,"},{"line_number":167,"context_line":"                      mock.Mock(*arg, **kwargs))"},{"line_number":168,"context_line":""},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"def patch_get_managed_ports_vmax(*arg, **kwargs):"},{"line_number":171,"context_line":"    return mock.patch(\u0027manila.share.drivers.dell_emc.plugins.vmax.connection.\u0027"},{"line_number":172,"context_line":"                      \u0027VMAXStorageConnection.get_managed_ports\u0027,"},{"line_number":173,"context_line":"                      mock.Mock(*arg, **kwargs))"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_3c328260","line":173,"range":{"start_line":165,"start_character":22,"end_line":173,"end_character":48},"updated":"2017-06-26 11:33:16.000000000","message":"but better yet, these 2 methods are the same. You could have a parameter that chooses which variation you want.","commit_id":"994cc4f5d9242b214034965c23999f966b24dbf6"}],"manila/tests/share/drivers/dell_emc/plugins/vmax/test_connection.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"7d3c746bce4f732d9adff5ed55ca7c58c49e9465","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 EMC Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_ed6be681","line":1,"range":{"start_line":1,"start_character":1,"end_line":1,"end_character":37},"updated":"2017-07-06 22:16:37.000000000","message":"bad rebase?","commit_id":"e7cb370829fa32b7f344bad81396ef4bece28113"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"0ea1f87ef9b038acda04da2d7e17c36a64b079aa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2015 EMC Corporation."},{"line_number":2,"context_line":"# All Rights Reserved."},{"line_number":3,"context_line":"#"},{"line_number":4,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_6dcfd628","line":1,"range":{"start_line":1,"start_character":1,"end_line":1,"end_character":37},"in_reply_to":"3f1d235d_ed6be681","updated":"2017-07-06 22:32:53.000000000","message":"Possibly so. I will change it","commit_id":"e7cb370829fa32b7f344bad81396ef4bece28113"}],"manila/tests/share/drivers/dell_emc/plugins/vmax/test_object_manager.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"eeb2a02f2560da6737d3c5c463241d08d9ce6551","unresolved":false,"context_lines":[{"line_number":489,"context_line":"                                     self.fs.src_fileystems_name,"},{"line_number":490,"context_line":"                                     self.pool.pool_name,"},{"line_number":491,"context_line":"                                     self.vdm.vdm_name,"},{"line_number":492,"context_line":"                                     self.mover.interconnect_id, )"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"        ssh_calls \u003d ["},{"line_number":495,"context_line":"            mock.call(self.fs.cmd_create_from_ckpt(), False),"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_3cce022e","line":492,"range":{"start_line":492,"start_character":63,"end_line":492,"end_character":65},"updated":"2017-06-26 11:33:16.000000000","message":"?","commit_id":"994cc4f5d9242b214034965c23999f966b24dbf6"}]}
