)]}'
{"manila/share/drivers/lvm.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f23735902254541459c86947b363c88fea7e921d","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":276,"context_line":"            LOG.warning(\"Can\u0027t remove share %r\", share[\u0027id\u0027])"},{"line_number":277,"context_line":"        except exception.InvalidShare as exc:"},{"line_number":278,"context_line":"            LOG.warning(str(exc))"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    def update_access(self, context, share, access_rules, add_rules,"},{"line_number":281,"context_line":"                      delete_rules, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f044301_c0c52c3e","line":278,"range":{"start_line":278,"start_character":1,"end_line":278,"end_character":33},"updated":"2017-05-07 19:03:55.000000000","message":"Should we be using six.text_type() instead of str() here?","commit_id":"9932c83c648256084ab8317ec6f9f8774f751d04"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b3b412430e83891b7687e447b3d79a620bd99c2a","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":276,"context_line":"            LOG.warning(\"Can\u0027t remove share %r\", share[\u0027id\u0027])"},{"line_number":277,"context_line":"        except exception.InvalidShare as exc:"},{"line_number":278,"context_line":"            LOG.warning(str(exc))"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    def update_access(self, context, share, access_rules, add_rules,"},{"line_number":281,"context_line":"                      delete_rules, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f044301_30777bd7","line":278,"range":{"start_line":278,"start_character":1,"end_line":278,"end_character":33},"in_reply_to":"3f044301_0dd8ec7c","updated":"2017-05-08 02:53:44.000000000","message":"About str and six.text_type:\n\n\nWe don\u0027t need a third party library conversion for str() when str is overridden for the BaseException: https://www.python.org/dev/peps/pep-0352/\nSo, if you str(some_exception), you\u0027ll get the equivalent of python2\u0027s some_exception.message... The \"message\" attribute doesn\u0027t exist in python 3.5, so, without this fix, we\u0027d fail if we ran this under \u003e\u003dpython3.5\n\nThe differences between py2 and py3 afaik are regarding byte/bytearrays where python2 \"str\" represented both string and byte, and in python3 we have bytes and bytearray as separate types. Since we set the message in InvalidShare ourselves (\n\n\n  $ python3\n  Python 3.5.2 (default, Nov 17 2016, 17:05:23)\n  [GCC 5.4.0 20160609] on linux\n  Type \"help\", \"copyright\", \"credits\" or \"license\" for more information.\n  \u003e\u003e\u003e class SampleException(Exception):\n  ...     def __init__(self, *args):\n  ...             super(SampleException, self).__init__(args)\n  ...\n  \u003e\u003e\u003e a \u003d SampleException(\"Test\")\n  \u003e\u003e\u003e a.message\n  Traceback (most recent call last):\n  File \"\u003cstdin\u003e\", line 1, in \u003cmodule\u003e\n  AttributeError: \u0027SampleException\u0027 object has no attribute \u0027message\u0027\n  \u003e\u003e\u003e str(a)\n  \"(\u0027Test\u0027,)\"\n\n $ python\n Python 2.7.13 (default, Feb 17 2017, 16:29:41)\n [GCC 4.2.1 Compatible Apple LLVM 8.0.0 (clang-800.0.42.1)] on darwin\n Type \"help\", \"copyright\", \"credits\" or \"license\" for more information.\n \u003e\u003e\u003e class SampleException(Exception):\n ...     def __init__(self, *args):\n ...             super(SampleException, self).__init__(args)\n ...\n \u003e\u003e\u003e a \u003d SampleException(\"Test\")\n \u003e\u003e\u003e a.message\n (\u0027Test\u0027,)\n \u003e\u003e\u003e str(a)\n \"(\u0027Test\u0027,)\"","commit_id":"9932c83c648256084ab8317ec6f9f8774f751d04"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6f319c2fbbe21f62805d7f26a9dc0aa0d2677f50","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":276,"context_line":"            LOG.warning(\"Can\u0027t remove share %r\", share[\u0027id\u0027])"},{"line_number":277,"context_line":"        except exception.InvalidShare as exc:"},{"line_number":278,"context_line":"            LOG.warning(str(exc))"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    def update_access(self, context, share, access_rules, add_rules,"},{"line_number":281,"context_line":"                      delete_rules, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f044301_d054d723","line":278,"range":{"start_line":278,"start_character":1,"end_line":278,"end_character":33},"in_reply_to":"3f044301_30777bd7","updated":"2017-05-08 02:56:42.000000000","message":"Missed links: https://github.com/openstack/manila/blob/d9f2f595/manila/share/drivers/lvm.py#L315\nhttps://github.com/openstack/manila/blob/d9f2f595/manila/exception.py#L242\nhttps://github.com/openstack/manila/blob/d9f2f595/manila/exception.py#L70\n\n^ The message we set in InvalidShare is not a bytearray..","commit_id":"9932c83c648256084ab8317ec6f9f8774f751d04"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"1664382e4b0182b579ac2a42361b7212748c791e","unresolved":false,"context_lines":[{"line_number":275,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":276,"context_line":"            LOG.warning(\"Can\u0027t remove share %r\", share[\u0027id\u0027])"},{"line_number":277,"context_line":"        except exception.InvalidShare as exc:"},{"line_number":278,"context_line":"            LOG.warning(str(exc))"},{"line_number":279,"context_line":""},{"line_number":280,"context_line":"    def update_access(self, context, share, access_rules, add_rules,"},{"line_number":281,"context_line":"                      delete_rules, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f044301_0dd8ec7c","line":278,"range":{"start_line":278,"start_character":1,"end_line":278,"end_character":33},"in_reply_to":"3f044301_c0c52c3e","updated":"2017-05-07 22:06:29.000000000","message":"I believe so, the use of \"str\" should be avoided as its behavior is different in python 2 and python 3","commit_id":"9932c83c648256084ab8317ec6f9f8774f751d04"}]}
