)]}'
{"manila/share/driver.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"0e57f3fb0d03845477f7d4620a66e8205d83a0b7","unresolved":false,"context_lines":[{"line_number":2429,"context_line":"        Driver can use this method to update the share usage size of"},{"line_number":2430,"context_line":"        the shares. To do that, a dictionary of shares should be"},{"line_number":2431,"context_line":"        returned."},{"line_number":2432,"context_line":"        :shares: None or a list of all shares for updates."},{"line_number":2433,"context_line":"        :return None or a dictionary of updates in the format::"},{"line_number":2434,"context_line":""},{"line_number":2435,"context_line":"            ["}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_52ee6eb4","line":2432,"range":{"start_line":2432,"start_character":8,"end_line":2432,"end_character":16},"updated":"2017-07-12 01:38:31.000000000","message":":param shares:","commit_id":"0f67870c8e17159f134860a35066aaf22a7aa3e9"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"eece36b83f3f761a47c53f14a8810d95f58cc5c4","unresolved":false,"context_lines":[{"line_number":2429,"context_line":"        Driver can use this method to update the share usage size of"},{"line_number":2430,"context_line":"        the shares. To do that, a dictionary of shares should be"},{"line_number":2431,"context_line":"        returned."},{"line_number":2432,"context_line":"        :shares: None or a list of all shares for updates."},{"line_number":2433,"context_line":"        :return None or a dictionary of updates in the format::"},{"line_number":2434,"context_line":""},{"line_number":2435,"context_line":"            ["}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_f2457a71","line":2432,"range":{"start_line":2432,"start_character":8,"end_line":2432,"end_character":16},"in_reply_to":"3f1d235d_52ee6eb4","updated":"2017-07-12 02:02:29.000000000","message":"Done","commit_id":"0f67870c8e17159f134860a35066aaf22a7aa3e9"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"0e57f3fb0d03845477f7d4620a66e8205d83a0b7","unresolved":false,"context_lines":[{"line_number":2430,"context_line":"        the shares. To do that, a dictionary of shares should be"},{"line_number":2431,"context_line":"        returned."},{"line_number":2432,"context_line":"        :shares: None or a list of all shares for updates."},{"line_number":2433,"context_line":"        :return None or a dictionary of updates in the format::"},{"line_number":2434,"context_line":""},{"line_number":2435,"context_line":"            ["},{"line_number":2436,"context_line":"                {"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_12091694","line":2433,"range":{"start_line":2433,"start_character":24,"end_line":2433,"end_character":36},"updated":"2017-07-12 01:38:31.000000000","message":"a list of dictionary of ...","commit_id":"0f67870c8e17159f134860a35066aaf22a7aa3e9"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"0e57f3fb0d03845477f7d4620a66e8205d83a0b7","unresolved":false,"context_lines":[{"line_number":2430,"context_line":"        the shares. To do that, a dictionary of shares should be"},{"line_number":2431,"context_line":"        returned."},{"line_number":2432,"context_line":"        :shares: None or a list of all shares for updates."},{"line_number":2433,"context_line":"        :return None or a dictionary of updates in the format::"},{"line_number":2434,"context_line":""},{"line_number":2435,"context_line":"            ["},{"line_number":2436,"context_line":"                {"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_92f40689","line":2433,"range":{"start_line":2433,"start_character":8,"end_line":2433,"end_character":15},"updated":"2017-07-12 01:38:31.000000000","message":"s/:return/:returns:","commit_id":"0f67870c8e17159f134860a35066aaf22a7aa3e9"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"eece36b83f3f761a47c53f14a8810d95f58cc5c4","unresolved":false,"context_lines":[{"line_number":2430,"context_line":"        the shares. To do that, a dictionary of shares should be"},{"line_number":2431,"context_line":"        returned."},{"line_number":2432,"context_line":"        :shares: None or a list of all shares for updates."},{"line_number":2433,"context_line":"        :return None or a dictionary of updates in the format::"},{"line_number":2434,"context_line":""},{"line_number":2435,"context_line":"            ["},{"line_number":2436,"context_line":"                {"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_d23ddedd","line":2433,"range":{"start_line":2433,"start_character":24,"end_line":2433,"end_character":36},"in_reply_to":"3f1d235d_12091694","updated":"2017-07-12 02:02:29.000000000","message":"Done","commit_id":"0f67870c8e17159f134860a35066aaf22a7aa3e9"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"eece36b83f3f761a47c53f14a8810d95f58cc5c4","unresolved":false,"context_lines":[{"line_number":2430,"context_line":"        the shares. To do that, a dictionary of shares should be"},{"line_number":2431,"context_line":"        returned."},{"line_number":2432,"context_line":"        :shares: None or a list of all shares for updates."},{"line_number":2433,"context_line":"        :return None or a dictionary of updates in the format::"},{"line_number":2434,"context_line":""},{"line_number":2435,"context_line":"            ["},{"line_number":2436,"context_line":"                {"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_f23a1ae5","line":2433,"range":{"start_line":2433,"start_character":8,"end_line":2433,"end_character":15},"in_reply_to":"3f1d235d_92f40689","updated":"2017-07-12 02:02:29.000000000","message":"Done","commit_id":"0f67870c8e17159f134860a35066aaf22a7aa3e9"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"0231123ba34e971b2d6bd8f395ae242fb494c993","unresolved":false,"context_lines":[{"line_number":2430,"context_line":"        the shares. To do that, a dictionary of shares should be"},{"line_number":2431,"context_line":"        returned."},{"line_number":2432,"context_line":"        :param shares: None or a list of all shares for updates."},{"line_number":2433,"context_line":"        :returns: None or a list of dictionary of updates in the format::"},{"line_number":2434,"context_line":""},{"line_number":2435,"context_line":"            ["},{"line_number":2436,"context_line":"                {"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f1a1f67_8bbf6afa","line":2433,"range":{"start_line":2433,"start_character":8,"end_line":2433,"end_character":73},"updated":"2017-07-13 14:54:12.000000000","message":"In lvm driver and dummy driver you return an empty list instead of None.  That seems the right thing to do and this comment should be changed.","commit_id":"0812466c4d8d8eff6463c93683df833d68ed6d6c"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"eccaab9097d86c73bd49409c4c987f7af7452c30","unresolved":false,"context_lines":[{"line_number":2430,"context_line":"        the shares. To do that, a dictionary of shares should be"},{"line_number":2431,"context_line":"        returned."},{"line_number":2432,"context_line":"        :param shares: None or a list of all shares for updates."},{"line_number":2433,"context_line":"        :returns: None or a list of dictionary of updates in the format::"},{"line_number":2434,"context_line":""},{"line_number":2435,"context_line":"            ["},{"line_number":2436,"context_line":"                {"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f1a1f67_f0e114fe","line":2433,"range":{"start_line":2433,"start_character":8,"end_line":2433,"end_character":73},"in_reply_to":"1f1a1f67_8bbf6afa","updated":"2017-07-14 03:40:50.000000000","message":"Done","commit_id":"0812466c4d8d8eff6463c93683df833d68ed6d6c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fac7fb022e41d817dae9499fa952d249cac1d5cd","unresolved":false,"context_lines":[{"line_number":2437,"context_line":"                {"},{"line_number":2438,"context_line":"                    \u0027id\u0027: \u002709960614-8574-4e03-89cf-7cf267b0bd08\u0027:"},{"line_number":2439,"context_line":"                    \u0027used_size\u0027: \u0027200\u0027,"},{"line_number":2440,"context_line":"                    \u0027gather_at\u0027: datetime.datetime(2017, 8, 10, 15, 14, 6),"},{"line_number":2441,"context_line":"                },"},{"line_number":2442,"context_line":"            ]"},{"line_number":2443,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1f1a1f67_e30af0cf","line":2440,"range":{"start_line":2440,"start_character":21,"end_line":2440,"end_character":30},"updated":"2017-07-19 00:09:38.000000000","message":"gathered_at","commit_id":"ddbd4c13f145f5690068d62e9aec94effbdb40b6"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"aa0d1fa89d5f91268178f01dbd1227790191e12e","unresolved":false,"context_lines":[{"line_number":2437,"context_line":"                {"},{"line_number":2438,"context_line":"                    \u0027id\u0027: \u002709960614-8574-4e03-89cf-7cf267b0bd08\u0027:"},{"line_number":2439,"context_line":"                    \u0027used_size\u0027: \u0027200\u0027,"},{"line_number":2440,"context_line":"                    \u0027gather_at\u0027: datetime.datetime(2017, 8, 10, 15, 14, 6),"},{"line_number":2441,"context_line":"                },"},{"line_number":2442,"context_line":"            ]"},{"line_number":2443,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1f1a1f67_8c42490e","line":2440,"range":{"start_line":2440,"start_character":21,"end_line":2440,"end_character":30},"in_reply_to":"1f1a1f67_e30af0cf","updated":"2017-07-19 03:15:56.000000000","message":"Done","commit_id":"ddbd4c13f145f5690068d62e9aec94effbdb40b6"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"7dbab1417ea41ae35e0d2e39039ad78a2e1d8104","unresolved":false,"context_lines":[{"line_number":2442,"context_line":"            ]"},{"line_number":2443,"context_line":""},{"line_number":2444,"context_line":"        \"\"\""},{"line_number":2445,"context_line":"        raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":24,"id":"1f1a1f67_75367205","line":2445,"updated":"2017-07-19 18:51:33.000000000","message":"This will cause a problem for drivers that haven\u0027t yet implemented the corresponding method.  If a cloud operator has multiple backends where one (say lvm) has implemented this method and another (say huawei) hasn\u0027t yet, they are going to get an alarming traceback in their logs every time this method is run because the huawei backend hasn\u0027t implemented the method yet.  That assumes that they\u0027ve set the config option to collect usage to True because they want to get the stats for the driver that supports it.\n\n\nProbably better to LOG here and not raise the error.","commit_id":"488a2976f9914e2a0b299aa52642f07078afe27e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"8bab3ac2e695d6911b684992c640ee0430268fc7","unresolved":false,"context_lines":[{"line_number":2442,"context_line":"            ]"},{"line_number":2443,"context_line":""},{"line_number":2444,"context_line":"        \"\"\""},{"line_number":2445,"context_line":"        raise NotImplementedError()"}],"source_content_type":"text/x-python","patch_set":24,"id":"1f1a1f67_07202649","line":2445,"in_reply_to":"1f1a1f67_75367205","updated":"2017-07-20 07:03:15.000000000","message":"Done","commit_id":"488a2976f9914e2a0b299aa52642f07078afe27e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2dda47f1258fb78c20e69e33135baed7211b8832","unresolved":false,"context_lines":[{"line_number":1060,"context_line":"        return True"},{"line_number":1061,"context_line":""},{"line_number":1062,"context_line":"    @property"},{"line_number":1063,"context_line":"    def snapshots_are_supported(self):"},{"line_number":1064,"context_line":"        if not hasattr(self, \u0027_snapshots_are_supported\u0027):"},{"line_number":1065,"context_line":"            methods \u003d (\u0027create_snapshot\u0027, \u0027delete_snapshot\u0027)"},{"line_number":1066,"context_line":"            # NOTE(vponomaryov): calculate default value for"},{"line_number":1067,"context_line":"            # stat \u0027snapshot_support\u0027 based on implementation of"},{"line_number":1068,"context_line":"            # appropriate methods of this base driver class."},{"line_number":1069,"context_line":"            self._snapshots_are_supported \u003d self._has_redefined_driver_methods("},{"line_number":1070,"context_line":"                methods)"},{"line_number":1071,"context_line":"        return self._snapshots_are_supported"},{"line_number":1072,"context_line":""},{"line_number":1073,"context_line":"    @property"},{"line_number":1074,"context_line":"    def creating_shares_from_snapshots_is_supported(self):"}],"source_content_type":"text/x-python","patch_set":26,"id":"ff346bd7_806cf408","line":1071,"range":{"start_line":1063,"start_character":0,"end_line":1071,"end_character":44},"updated":"2017-07-23 01:59:21.000000000","message":"See this example for how to determine if a driver has implemented a method..","commit_id":"102b5c20cde11db22ef72b5aba125ed84bdd7e02"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"abae4553f53e528e0a5e50fdd2ac25c0a152c056","unresolved":false,"context_lines":[{"line_number":1060,"context_line":"        return True"},{"line_number":1061,"context_line":""},{"line_number":1062,"context_line":"    @property"},{"line_number":1063,"context_line":"    def snapshots_are_supported(self):"},{"line_number":1064,"context_line":"        if not hasattr(self, \u0027_snapshots_are_supported\u0027):"},{"line_number":1065,"context_line":"            methods \u003d (\u0027create_snapshot\u0027, \u0027delete_snapshot\u0027)"},{"line_number":1066,"context_line":"            # NOTE(vponomaryov): calculate default value for"},{"line_number":1067,"context_line":"            # stat \u0027snapshot_support\u0027 based on implementation of"},{"line_number":1068,"context_line":"            # appropriate methods of this base driver class."},{"line_number":1069,"context_line":"            self._snapshots_are_supported \u003d self._has_redefined_driver_methods("},{"line_number":1070,"context_line":"                methods)"},{"line_number":1071,"context_line":"        return self._snapshots_are_supported"},{"line_number":1072,"context_line":""},{"line_number":1073,"context_line":"    @property"},{"line_number":1074,"context_line":"    def creating_shares_from_snapshots_is_supported(self):"}],"source_content_type":"text/x-python","patch_set":26,"id":"ff346bd7_c9e8e717","line":1071,"range":{"start_line":1063,"start_character":0,"end_line":1071,"end_character":44},"in_reply_to":"ff346bd7_806cf408","updated":"2017-07-23 03:44:23.000000000","message":"https://review.openstack.org/#/c/465055/26/manila/share/manager.py@121","commit_id":"102b5c20cde11db22ef72b5aba125ed84bdd7e02"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2dda47f1258fb78c20e69e33135baed7211b8832","unresolved":false,"context_lines":[{"line_number":2442,"context_line":"            ]"},{"line_number":2443,"context_line":""},{"line_number":2444,"context_line":"        \"\"\""},{"line_number":2445,"context_line":"        LOG.error(\"Gather share usage size failure, because share backend \""},{"line_number":2446,"context_line":"                  \"does not support it.\")"},{"line_number":2447,"context_line":"        return []"}],"source_content_type":"text/x-python","patch_set":26,"id":"ff346bd7_60d590b9","line":2447,"range":{"start_line":2445,"start_character":8,"end_line":2447,"end_character":17},"updated":"2017-07-23 01:59:21.000000000","message":"why not\n\n raise NotImplementedError\n\n\nHave you considered trying to gather share_usage_size on driver start up, if NotImplementedError, do not add a periodic task, that way you can avoid the repeated log messages?","commit_id":"102b5c20cde11db22ef72b5aba125ed84bdd7e02"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d9f0a0dad3886d88a11f93b30f141f19ab09cb2b","unresolved":false,"context_lines":[{"line_number":2442,"context_line":"            ]"},{"line_number":2443,"context_line":""},{"line_number":2444,"context_line":"        \"\"\""},{"line_number":2445,"context_line":"        LOG.error(\"Gather share usage size failure, because share backend \""},{"line_number":2446,"context_line":"                  \"does not support it.\")"},{"line_number":2447,"context_line":"        return []"}],"source_content_type":"text/x-python","patch_set":26,"id":"ff346bd7_e7b74fd8","line":2447,"range":{"start_line":2445,"start_character":8,"end_line":2447,"end_character":17},"in_reply_to":"ff346bd7_09c94f77","updated":"2017-07-23 16:41:30.000000000","message":"Done","commit_id":"102b5c20cde11db22ef72b5aba125ed84bdd7e02"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"abae4553f53e528e0a5e50fdd2ac25c0a152c056","unresolved":false,"context_lines":[{"line_number":2442,"context_line":"            ]"},{"line_number":2443,"context_line":""},{"line_number":2444,"context_line":"        \"\"\""},{"line_number":2445,"context_line":"        LOG.error(\"Gather share usage size failure, because share backend \""},{"line_number":2446,"context_line":"                  \"does not support it.\")"},{"line_number":2447,"context_line":"        return []"}],"source_content_type":"text/x-python","patch_set":26,"id":"ff346bd7_c9834756","line":2447,"range":{"start_line":2445,"start_character":8,"end_line":2447,"end_character":17},"in_reply_to":"ff346bd7_60d590b9","updated":"2017-07-23 03:44:23.000000000","message":"From Tom: This will cause a problem for drivers that haven\u0027t yet implemented the corresponding method.  If a cloud operator has multiple backends where one (say lvm) has implemented this method and another (say huawei) hasn\u0027t yet, they are going to get an alarming traceback in their logs every time this method is run because the huawei backend hasn\u0027t implemented the method yet.  That assumes that they\u0027ve set the config option to collect usage to True because they want to get the stats for the driver that supports it.\n\nProbably better to LOG here and not raise the error.\n\nhttps://review.openstack.org/#/c/465055/24/manila/share/driver.py@2445\n\nhttps://review.openstack.org/#/c/465055/26/manila/share/manager.py@121","commit_id":"102b5c20cde11db22ef72b5aba125ed84bdd7e02"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"69e376d88d14845ff29409d40d6ebff3524cf331","unresolved":false,"context_lines":[{"line_number":2442,"context_line":"            ]"},{"line_number":2443,"context_line":""},{"line_number":2444,"context_line":"        \"\"\""},{"line_number":2445,"context_line":"        LOG.error(\"Gather share usage size failure, because share backend \""},{"line_number":2446,"context_line":"                  \"does not support it.\")"},{"line_number":2447,"context_line":"        return []"}],"source_content_type":"text/x-python","patch_set":26,"id":"ff346bd7_09c94f77","line":2447,"range":{"start_line":2445,"start_character":8,"end_line":2447,"end_character":17},"in_reply_to":"ff346bd7_c9834756","updated":"2017-07-23 04:28:02.000000000","message":"Yes. He\u0027s right, you shouldn\u0027t log the traceback... You should be able to log a warning or an error one time, at startup and not run the periodic task at all for backends that don\u0027t support share usage tracking..","commit_id":"102b5c20cde11db22ef72b5aba125ed84bdd7e02"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3663213b1c7a952cfdf8e25d386dbda521bccb3e","unresolved":false,"context_lines":[{"line_number":2436,"context_line":"            ["},{"line_number":2437,"context_line":"                {"},{"line_number":2438,"context_line":"                    \u0027id\u0027: \u002709960614-8574-4e03-89cf-7cf267b0bd08\u0027:"},{"line_number":2439,"context_line":"                    \u0027used_size\u0027: \u0027200\u0027,"},{"line_number":2440,"context_line":"                    \u0027gathered_at\u0027: datetime.datetime(2017, 8, 10, 15, 14, 6),"},{"line_number":2441,"context_line":"                },"},{"line_number":2442,"context_line":"            ]"}],"source_content_type":"text/x-python","patch_set":37,"id":"ff346bd7_92906d50","line":2439,"range":{"start_line":2439,"start_character":34,"end_line":2439,"end_character":37},"updated":"2017-07-26 03:43:35.000000000","message":"Can this be a Floating point number, also, please clarify what the unit would be?","commit_id":"cd67fa96a4df598f6df77fec653cd62c7d4dbfdd"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3663213b1c7a952cfdf8e25d386dbda521bccb3e","unresolved":false,"context_lines":[{"line_number":2442,"context_line":"            ]"},{"line_number":2443,"context_line":""},{"line_number":2444,"context_line":"        \"\"\""},{"line_number":2445,"context_line":"        LOG.debug(\"Gather share usage size failure, because share backend \""},{"line_number":2446,"context_line":"                  \"does not support it.\")"},{"line_number":2447,"context_line":"        return []"}],"source_content_type":"text/x-python","patch_set":37,"id":"ff346bd7_52c5655a","line":2446,"range":{"start_line":2445,"start_character":19,"end_line":2446,"end_character":39},"updated":"2017-07-26 03:43:35.000000000","message":"This backend does not support gathering \"used_size\" of shares created on it.","commit_id":"cd67fa96a4df598f6df77fec653cd62c7d4dbfdd"}],"manila/share/drivers/lvm.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"0231123ba34e971b2d6bd8f395ae242fb494c993","unresolved":false,"context_lines":[{"line_number":450,"context_line":"        for share in shares:"},{"line_number":451,"context_line":"            mount_path \u003d self._get_mount_path(share)"},{"line_number":452,"context_line":"            if os.path.exists(mount_path):"},{"line_number":453,"context_line":"                out, err \u003d self._execute("},{"line_number":454,"context_line":"                    \u0027df\u0027, \u0027-kh\u0027, \u0027-l\u0027, \u0027--output\u003dtarget,used\u0027,"},{"line_number":455,"context_line":"                    \u0027--block-size\u003dg\u0027, run_as_root\u003dTrue)"},{"line_number":456,"context_line":"                used_size \u003d re.findall("},{"line_number":457,"context_line":"                    mount_path + \"\\s*[0-9.]+G\", out)[0].split(\u0027 \u0027)[-1][:-1]"},{"line_number":458,"context_line":"                update_shares.append({\u0027id\u0027: share[\u0027id\u0027],"},{"line_number":459,"context_line":"                                      \u0027used_size\u0027: used_size})"},{"line_number":460,"context_line":"        return update_shares"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f1a1f67_eb2c9e48","line":459,"range":{"start_line":453,"start_character":0,"end_line":459,"end_character":62},"updated":"2017-07-13 14:54:12.000000000","message":"We probably need error handling for failures on these other commands too.","commit_id":"0812466c4d8d8eff6463c93683df833d68ed6d6c"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"eccaab9097d86c73bd49409c4c987f7af7452c30","unresolved":false,"context_lines":[{"line_number":450,"context_line":"        for share in shares:"},{"line_number":451,"context_line":"            mount_path \u003d self._get_mount_path(share)"},{"line_number":452,"context_line":"            if os.path.exists(mount_path):"},{"line_number":453,"context_line":"                out, err \u003d self._execute("},{"line_number":454,"context_line":"                    \u0027df\u0027, \u0027-kh\u0027, \u0027-l\u0027, \u0027--output\u003dtarget,used\u0027,"},{"line_number":455,"context_line":"                    \u0027--block-size\u003dg\u0027, run_as_root\u003dTrue)"},{"line_number":456,"context_line":"                used_size \u003d re.findall("},{"line_number":457,"context_line":"                    mount_path + \"\\s*[0-9.]+G\", out)[0].split(\u0027 \u0027)[-1][:-1]"},{"line_number":458,"context_line":"                update_shares.append({\u0027id\u0027: share[\u0027id\u0027],"},{"line_number":459,"context_line":"                                      \u0027used_size\u0027: used_size})"},{"line_number":460,"context_line":"        return update_shares"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f1a1f67_f3d59eb8","line":459,"range":{"start_line":453,"start_character":0,"end_line":459,"end_character":62},"in_reply_to":"1f1a1f67_eb2c9e48","updated":"2017-07-14 03:40:50.000000000","message":"Do you mean we need catch _execute error, then continue to gather other shares usage size? \nI think it we raise error to manage.py if the _execute(...) or other commands failure, then we don\u0027t need to gather other shares usage size, and the manage function will log gathering share usage size failure.\nDis I missing something, please let me know.","commit_id":"0812466c4d8d8eff6463c93683df833d68ed6d6c"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"43627ee47936404703c9c861285c7f2eed3a4833","unresolved":false,"context_lines":[{"line_number":445,"context_line":"                             snapshot[\u0027name\u0027], access_rules,"},{"line_number":446,"context_line":"                             add_rules\u003dadd_rules, delete_rules\u003ddelete_rules)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    def update_share_usage_size(self, context, shares):"},{"line_number":449,"context_line":"        update_shares \u003d []"},{"line_number":450,"context_line":"        for share in shares:"},{"line_number":451,"context_line":"            mount_path \u003d self._get_mount_path(share)"},{"line_number":452,"context_line":"            if os.path.exists(mount_path):"},{"line_number":453,"context_line":"                out, err \u003d self._execute("},{"line_number":454,"context_line":"                    \u0027df\u0027, \u0027-kh\u0027, \u0027-l\u0027, \u0027--output\u003dtarget,used\u0027,"},{"line_number":455,"context_line":"                    \u0027--block-size\u003dg\u0027, run_as_root\u003dTrue)"},{"line_number":456,"context_line":"                used_size \u003d re.findall("},{"line_number":457,"context_line":"                    mount_path + \"\\s*[0-9.]+G\", out)[0].split(\u0027 \u0027)[-1][:-1]"},{"line_number":458,"context_line":"                update_shares.append({\u0027id\u0027: share[\u0027id\u0027],"},{"line_number":459,"context_line":"                                      \u0027used_size\u0027: used_size})"},{"line_number":460,"context_line":"        return update_shares"}],"source_content_type":"text/x-python","patch_set":14,"id":"1f1a1f67_88818292","line":459,"range":{"start_line":448,"start_character":0,"end_line":459,"end_character":62},"updated":"2017-07-14 16:59:24.000000000","message":"\"Do you mean we need catch _execute error, then continue to gather other shares usage size?\"\n\nYes, it seems bad to fail collection of usage on all the shares just because of a failure running one of these commands to collect usage on one share.  I was thinking we should catch failures here and LOG an error but continue to try to collect usage for the other shares.\n\nWhat do you think?","commit_id":"2840ea9b354687259df2192ca8f3b980a8c07e57"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"665b882ef2b53060dbb8d2ddd58be34035d187d8","unresolved":false,"context_lines":[{"line_number":445,"context_line":"                             snapshot[\u0027name\u0027], access_rules,"},{"line_number":446,"context_line":"                             add_rules\u003dadd_rules, delete_rules\u003ddelete_rules)"},{"line_number":447,"context_line":""},{"line_number":448,"context_line":"    def update_share_usage_size(self, context, shares):"},{"line_number":449,"context_line":"        update_shares \u003d []"},{"line_number":450,"context_line":"        for share in shares:"},{"line_number":451,"context_line":"            mount_path \u003d self._get_mount_path(share)"},{"line_number":452,"context_line":"            if os.path.exists(mount_path):"},{"line_number":453,"context_line":"                out, err \u003d self._execute("},{"line_number":454,"context_line":"                    \u0027df\u0027, \u0027-kh\u0027, \u0027-l\u0027, \u0027--output\u003dtarget,used\u0027,"},{"line_number":455,"context_line":"                    \u0027--block-size\u003dg\u0027, run_as_root\u003dTrue)"},{"line_number":456,"context_line":"                used_size \u003d re.findall("},{"line_number":457,"context_line":"                    mount_path + \"\\s*[0-9.]+G\", out)[0].split(\u0027 \u0027)[-1][:-1]"},{"line_number":458,"context_line":"                update_shares.append({\u0027id\u0027: share[\u0027id\u0027],"},{"line_number":459,"context_line":"                                      \u0027used_size\u0027: used_size})"},{"line_number":460,"context_line":"        return update_shares"}],"source_content_type":"text/x-python","patch_set":14,"id":"1f1a1f67_a90c29ec","line":459,"range":{"start_line":448,"start_character":0,"end_line":459,"end_character":62},"in_reply_to":"1f1a1f67_88818292","updated":"2017-07-16 15:55:14.000000000","message":"Done","commit_id":"2840ea9b354687259df2192ca8f3b980a8c07e57"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"10823da6fa652341a4ffcc3cec69c484177ea0ec","unresolved":false,"context_lines":[{"line_number":449,"context_line":"        update_shares \u003d []"},{"line_number":450,"context_line":"        for share in shares:"},{"line_number":451,"context_line":"            mount_path \u003d self._get_mount_path(share)"},{"line_number":452,"context_line":"            if os.path.exists(mount_path):"},{"line_number":453,"context_line":"                try:"},{"line_number":454,"context_line":"                    out, err \u003d self._execute("},{"line_number":455,"context_line":"                        \u0027df\u0027, \u0027-kh\u0027, \u0027-l\u0027, \u0027--output\u003dtarget,used\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"1f1a1f67_affad7b9","line":452,"range":{"start_line":452,"start_character":12,"end_line":452,"end_character":42},"updated":"2017-07-17 14:05:13.000000000","message":"Why would we just go on ahead without logging anything if the mount path for the share doesn\u0027t exist?  Is that somehow different than the other errors that you are now covering?  I guess what I\u0027m wondering is why you don\u0027t have:\n\n for share in shares:\n     try:\n        .... \u003call the processing for one share \u003e\n     except:\n        LOG.warning ...\n return update_shares\n\nI might be missing something here though ...","commit_id":"0bc7e89a0f827eae293b417abb618c0a0bf35129"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"eeabda833151eb8935b8cf53584aa60fdf5b4bbd","unresolved":false,"context_lines":[{"line_number":449,"context_line":"        update_shares \u003d []"},{"line_number":450,"context_line":"        for share in shares:"},{"line_number":451,"context_line":"            mount_path \u003d self._get_mount_path(share)"},{"line_number":452,"context_line":"            if os.path.exists(mount_path):"},{"line_number":453,"context_line":"                try:"},{"line_number":454,"context_line":"                    out, err \u003d self._execute("},{"line_number":455,"context_line":"                        \u0027df\u0027, \u0027-kh\u0027, \u0027-l\u0027, \u0027--output\u003dtarget,used\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"1f1a1f67_7445af42","line":452,"range":{"start_line":452,"start_character":12,"end_line":452,"end_character":42},"in_reply_to":"1f1a1f67_affad7b9","updated":"2017-07-17 15:54:07.000000000","message":"Done","commit_id":"0bc7e89a0f827eae293b417abb618c0a0bf35129"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"d1df2a2a65497395a5c074f18da2961ea8ac7ebd","unresolved":false,"context_lines":[{"line_number":452,"context_line":"                mount_path \u003d self._get_mount_path(share)"},{"line_number":453,"context_line":"                if os.path.exists(mount_path):"},{"line_number":454,"context_line":"                    out, err \u003d self._execute("},{"line_number":455,"context_line":"                        \u0027df\u0027, \u0027-kh\u0027, \u0027-l\u0027, \u0027--output\u003dtarget,used\u0027,"},{"line_number":456,"context_line":"                        \u0027--block-size\u003dg\u0027, run_as_root\u003dTrue)"},{"line_number":457,"context_line":"                    used_size \u003d (re.findall("},{"line_number":458,"context_line":"                        mount_path + \"\\s*[0-9.]+G\", out)[0]."}],"source_content_type":"text/x-python","patch_set":18,"id":"1f1a1f67_520763cb","line":455,"updated":"2017-07-17 16:43:13.000000000","message":"-k is like --block-size\u003d1K, we can remove this flag.\n--output\u003dtarget,used,total, shall we add total?","commit_id":"3d4ff1f7fa5b29c690c8bf4413d964c99f47e8d2"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"e052a36fc1d97f221cb2bc08cb3910bc42372337","unresolved":false,"context_lines":[{"line_number":452,"context_line":"                mount_path \u003d self._get_mount_path(share)"},{"line_number":453,"context_line":"                if os.path.exists(mount_path):"},{"line_number":454,"context_line":"                    out, err \u003d self._execute("},{"line_number":455,"context_line":"                        \u0027df\u0027, \u0027-kh\u0027, \u0027-l\u0027, \u0027--output\u003dtarget,used\u0027,"},{"line_number":456,"context_line":"                        \u0027--block-size\u003dg\u0027, run_as_root\u003dTrue)"},{"line_number":457,"context_line":"                    used_size \u003d (re.findall("},{"line_number":458,"context_line":"                        mount_path + \"\\s*[0-9.]+G\", out)[0]."}],"source_content_type":"text/x-python","patch_set":18,"id":"1f1a1f67_f0253dc3","line":455,"in_reply_to":"1f1a1f67_520763cb","updated":"2017-07-18 01:27:03.000000000","message":"Hi Victoria Martinez de la Cruz, we don\u0027t need to add total. Because the total size will not be changed after we create, extend, shrink ... share, and we can get total share size since we added notification in those code logic(create,extend,shrink share). So we don\u0027t need to do redundant things. thanks","commit_id":"3d4ff1f7fa5b29c690c8bf4413d964c99f47e8d2"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"211da838c88411bbfd747940e5d7981c018e87dc","unresolved":false,"context_lines":[{"line_number":452,"context_line":"                mount_path \u003d self._get_mount_path(share)"},{"line_number":453,"context_line":"                if os.path.exists(mount_path):"},{"line_number":454,"context_line":"                    out, err \u003d self._execute("},{"line_number":455,"context_line":"                        \u0027df\u0027, \u0027-kh\u0027, \u0027-l\u0027, \u0027--output\u003dtarget,used\u0027,"},{"line_number":456,"context_line":"                        \u0027--block-size\u003dg\u0027, run_as_root\u003dTrue)"},{"line_number":457,"context_line":"                    used_size \u003d (re.findall("},{"line_number":458,"context_line":"                        mount_path + \"\\s*[0-9.]+G\", out)[0]."}],"source_content_type":"text/x-python","patch_set":18,"id":"1f1a1f67_73a257b0","line":455,"in_reply_to":"1f1a1f67_520763cb","updated":"2017-07-18 01:47:55.000000000","message":"There isn\u0027t a parameter named \"total\"\n# df -l  --output\u003dtarget,used,total\ndf: option --output: field ‘total’ unknown\nTry \u0027df --help\u0027 for more information.","commit_id":"3d4ff1f7fa5b29c690c8bf4413d964c99f47e8d2"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"0226939bc57549963806433d14cdb8ade02d983f","unresolved":false,"context_lines":[{"line_number":452,"context_line":"                mount_path \u003d self._get_mount_path(share)"},{"line_number":453,"context_line":"                if os.path.exists(mount_path):"},{"line_number":454,"context_line":"                    out, err \u003d self._execute("},{"line_number":455,"context_line":"                        \u0027df\u0027, \u0027-kh\u0027, \u0027-l\u0027, \u0027--output\u003dtarget,used\u0027,"},{"line_number":456,"context_line":"                        \u0027--block-size\u003dg\u0027, run_as_root\u003dTrue)"},{"line_number":457,"context_line":"                    used_size \u003d (re.findall("},{"line_number":458,"context_line":"                        mount_path + \"\\s*[0-9.]+G\", out)[0]."}],"source_content_type":"text/x-python","patch_set":18,"id":"1f1a1f67_18c44e90","line":455,"in_reply_to":"1f1a1f67_73a257b0","updated":"2017-07-18 12:34:07.000000000","message":"My bad, the name of the param I was thinking is \"size\".\n\n[vkmc@bellatrix ~]$ df -l --output\u003dtarget,used -h --block-size\u003dg \nMounted on      Used\n/dev              0G\n/dev/shm          1G\n/run              1G\n/sys/fs/cgroup    0G\n/                26G\n/tmp              1G\n/boot             1G\n/data            42G\n/home           110G\n/run/user/42      1G\n/run/user/1000    1G\n\n[vkmc@bellatrix ~]$ df -l --output\u003dtarget,used,size -h --block-size\u003dg \nMounted on      Used 1G-blocks\n/dev              0G        8G\n/dev/shm          1G        8G\n/run              1G        8G\n/sys/fs/cgroup    0G        8G\n/                26G       50G\n/tmp              1G        8G\n/boot             1G        1G\n/data            42G      197G\n/home           110G      663G\n/run/user/42      1G        2G\n/run/user/1000    1G        2G","commit_id":"3d4ff1f7fa5b29c690c8bf4413d964c99f47e8d2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fac7fb022e41d817dae9499fa952d249cac1d5cd","unresolved":false,"context_lines":[{"line_number":449,"context_line":"    def update_share_usage_size(self, context, shares):"},{"line_number":450,"context_line":"        update_shares \u003d []"},{"line_number":451,"context_line":"        out, err \u003d self._execute("},{"line_number":452,"context_line":"            \u0027df\u0027, \u0027-l\u0027, \u0027--output\u003dtarget,used\u0027,"},{"line_number":453,"context_line":"            \u0027--block-size\u003dg\u0027, run_as_root\u003dTrue)"},{"line_number":454,"context_line":"        gather_at \u003d timeutils.utcnow()"},{"line_number":455,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1f1a1f67_43ef64e8","line":452,"range":{"start_line":452,"start_character":12,"end_line":452,"end_character":47},"updated":"2017-07-19 00:09:38.000000000","message":"this should be added to rootwrap?","commit_id":"ddbd4c13f145f5690068d62e9aec94effbdb40b6"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"aa0d1fa89d5f91268178f01dbd1227790191e12e","unresolved":false,"context_lines":[{"line_number":449,"context_line":"    def update_share_usage_size(self, context, shares):"},{"line_number":450,"context_line":"        update_shares \u003d []"},{"line_number":451,"context_line":"        out, err \u003d self._execute("},{"line_number":452,"context_line":"            \u0027df\u0027, \u0027-l\u0027, \u0027--output\u003dtarget,used\u0027,"},{"line_number":453,"context_line":"            \u0027--block-size\u003dg\u0027, run_as_root\u003dTrue)"},{"line_number":454,"context_line":"        gather_at \u003d timeutils.utcnow()"},{"line_number":455,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1f1a1f67_97a01244","line":452,"range":{"start_line":452,"start_character":12,"end_line":452,"end_character":47},"in_reply_to":"1f1a1f67_43ef64e8","updated":"2017-07-19 03:15:56.000000000","message":"Done","commit_id":"ddbd4c13f145f5690068d62e9aec94effbdb40b6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fac7fb022e41d817dae9499fa952d249cac1d5cd","unresolved":false,"context_lines":[{"line_number":451,"context_line":"        out, err \u003d self._execute("},{"line_number":452,"context_line":"            \u0027df\u0027, \u0027-l\u0027, \u0027--output\u003dtarget,used\u0027,"},{"line_number":453,"context_line":"            \u0027--block-size\u003dg\u0027, run_as_root\u003dTrue)"},{"line_number":454,"context_line":"        gather_at \u003d timeutils.utcnow()"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        for share in shares:"},{"line_number":457,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":21,"id":"1f1a1f67_4301a4ae","line":454,"range":{"start_line":454,"start_character":8,"end_line":454,"end_character":17},"updated":"2017-07-19 00:09:38.000000000","message":"gathered_at","commit_id":"ddbd4c13f145f5690068d62e9aec94effbdb40b6"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"aa0d1fa89d5f91268178f01dbd1227790191e12e","unresolved":false,"context_lines":[{"line_number":451,"context_line":"        out, err \u003d self._execute("},{"line_number":452,"context_line":"            \u0027df\u0027, \u0027-l\u0027, \u0027--output\u003dtarget,used\u0027,"},{"line_number":453,"context_line":"            \u0027--block-size\u003dg\u0027, run_as_root\u003dTrue)"},{"line_number":454,"context_line":"        gather_at \u003d timeutils.utcnow()"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        for share in shares:"},{"line_number":457,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":21,"id":"1f1a1f67_6c76cd72","line":454,"range":{"start_line":454,"start_character":8,"end_line":454,"end_character":17},"in_reply_to":"1f1a1f67_4301a4ae","updated":"2017-07-19 03:15:56.000000000","message":"Done","commit_id":"ddbd4c13f145f5690068d62e9aec94effbdb40b6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fac7fb022e41d817dae9499fa952d249cac1d5cd","unresolved":false,"context_lines":[{"line_number":462,"context_line":"                        split(\u0027 \u0027)[-1][:-1])"},{"line_number":463,"context_line":"                    update_shares.append({\u0027id\u0027: share[\u0027id\u0027],"},{"line_number":464,"context_line":"                                          \u0027used_size\u0027: used_size,"},{"line_number":465,"context_line":"                                          \u0027gather_at\u0027: gather_at})"},{"line_number":466,"context_line":"                else:"},{"line_number":467,"context_line":"                    raise exception.NotFound("},{"line_number":468,"context_line":"                        \"Share %s could not be found.\" % mount_path)"}],"source_content_type":"text/x-python","patch_set":21,"id":"1f1a1f67_a3299837","line":465,"range":{"start_line":465,"start_character":43,"end_line":465,"end_character":52},"updated":"2017-07-19 00:09:38.000000000","message":"gathered_at","commit_id":"ddbd4c13f145f5690068d62e9aec94effbdb40b6"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"aa0d1fa89d5f91268178f01dbd1227790191e12e","unresolved":false,"context_lines":[{"line_number":462,"context_line":"                        split(\u0027 \u0027)[-1][:-1])"},{"line_number":463,"context_line":"                    update_shares.append({\u0027id\u0027: share[\u0027id\u0027],"},{"line_number":464,"context_line":"                                          \u0027used_size\u0027: used_size,"},{"line_number":465,"context_line":"                                          \u0027gather_at\u0027: gather_at})"},{"line_number":466,"context_line":"                else:"},{"line_number":467,"context_line":"                    raise exception.NotFound("},{"line_number":468,"context_line":"                        \"Share %s could not be found.\" % mount_path)"}],"source_content_type":"text/x-python","patch_set":21,"id":"1f1a1f67_4c71d175","line":465,"range":{"start_line":465,"start_character":43,"end_line":465,"end_character":52},"in_reply_to":"1f1a1f67_a3299837","updated":"2017-07-19 03:15:56.000000000","message":"Done","commit_id":"ddbd4c13f145f5690068d62e9aec94effbdb40b6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fac7fb022e41d817dae9499fa952d249cac1d5cd","unresolved":false,"context_lines":[{"line_number":464,"context_line":"                                          \u0027used_size\u0027: used_size,"},{"line_number":465,"context_line":"                                          \u0027gather_at\u0027: gather_at})"},{"line_number":466,"context_line":"                else:"},{"line_number":467,"context_line":"                    raise exception.NotFound("},{"line_number":468,"context_line":"                        \"Share %s could not be found.\" % mount_path)"},{"line_number":469,"context_line":"            except Exception:"},{"line_number":470,"context_line":"                LOG.exception(\"Gather share usage size failure.\")"},{"line_number":471,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1f1a1f67_431ac416","line":468,"range":{"start_line":467,"start_character":20,"end_line":468,"end_character":68},"updated":"2017-07-19 00:09:38.000000000","message":"Why would you raise and bail out? Why not log and go on to the next share?","commit_id":"ddbd4c13f145f5690068d62e9aec94effbdb40b6"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"aa0d1fa89d5f91268178f01dbd1227790191e12e","unresolved":false,"context_lines":[{"line_number":464,"context_line":"                                          \u0027used_size\u0027: used_size,"},{"line_number":465,"context_line":"                                          \u0027gather_at\u0027: gather_at})"},{"line_number":466,"context_line":"                else:"},{"line_number":467,"context_line":"                    raise exception.NotFound("},{"line_number":468,"context_line":"                        \"Share %s could not be found.\" % mount_path)"},{"line_number":469,"context_line":"            except Exception:"},{"line_number":470,"context_line":"                LOG.exception(\"Gather share usage size failure.\")"},{"line_number":471,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1f1a1f67_d7368a03","line":468,"range":{"start_line":467,"start_character":20,"end_line":468,"end_character":68},"in_reply_to":"1f1a1f67_431ac416","updated":"2017-07-19 03:15:56.000000000","message":"Because we would not log the same info(code line 470) in this place, and we can get the consistent LOG.exception(..) info  when we got some exception in code line 458~468.","commit_id":"ddbd4c13f145f5690068d62e9aec94effbdb40b6"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"20cb3c1451add894ec62139f65d9bbdc045ee5e5","unresolved":false,"context_lines":[{"line_number":464,"context_line":"                                          \u0027used_size\u0027: used_size,"},{"line_number":465,"context_line":"                                          \u0027gathered_at\u0027: gathered_at})"},{"line_number":466,"context_line":"                else:"},{"line_number":467,"context_line":"                    raise exception.NotFound("},{"line_number":468,"context_line":"                        \"Share %s could not be found.\" % mount_path)"},{"line_number":469,"context_line":"            except Exception:"},{"line_number":470,"context_line":"                LOG.exception(\"Gather share %s usage size failure.\","},{"line_number":471,"context_line":"                              share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":23,"id":"1f1a1f67_6f859506","line":468,"range":{"start_line":467,"start_character":0,"end_line":468,"end_character":68},"updated":"2017-07-19 09:41:14.000000000","message":"Need unit test coverage of this path: http://logs.openstack.org/55/465055/23/check/manila-coverage-ubuntu-xenial-nv/bda40ae/cover/manila_share_drivers_lvm_py.html#n467","commit_id":"9be94aa52692bf7f9a2980e4aab7aba080ffd26b"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b97eca349af7efe5443fd99adc4c90e2a960d36a","unresolved":false,"context_lines":[{"line_number":464,"context_line":"                                          \u0027used_size\u0027: used_size,"},{"line_number":465,"context_line":"                                          \u0027gathered_at\u0027: gathered_at})"},{"line_number":466,"context_line":"                else:"},{"line_number":467,"context_line":"                    raise exception.NotFound("},{"line_number":468,"context_line":"                        \"Share %s could not be found.\" % mount_path)"},{"line_number":469,"context_line":"            except Exception:"},{"line_number":470,"context_line":"                LOG.exception(\"Gather share %s usage size failure.\","},{"line_number":471,"context_line":"                              share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":23,"id":"1f1a1f67_8281dbc5","line":468,"range":{"start_line":467,"start_character":0,"end_line":468,"end_character":68},"in_reply_to":"1f1a1f67_6f859506","updated":"2017-07-19 16:24:39.000000000","message":"Done","commit_id":"9be94aa52692bf7f9a2980e4aab7aba080ffd26b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"ba14a87ce12b276160cf20cda265ca627f81dacc","unresolved":false,"context_lines":[{"line_number":465,"context_line":"                                          \u0027gathered_at\u0027: gathered_at})"},{"line_number":466,"context_line":"                else:"},{"line_number":467,"context_line":"                    raise exception.NotFound("},{"line_number":468,"context_line":"                        \"Share %s could not be found.\" % mount_path)"},{"line_number":469,"context_line":"            except Exception:"},{"line_number":470,"context_line":"                LOG.exception(\"Gather share %s usage size failure.\","},{"line_number":471,"context_line":"                              share[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":25,"id":"ff346bd7_c6bea2fe","line":468,"range":{"start_line":468,"start_character":24,"end_line":468,"end_character":54},"updated":"2017-07-21 20:01:46.000000000","message":"This msg should be wrapped with _().","commit_id":"d8fe790d108d06c382aadb247c7755a351f56664"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2dda47f1258fb78c20e69e33135baed7211b8832","unresolved":false,"context_lines":[{"line_number":447,"context_line":"                             add_rules\u003dadd_rules, delete_rules\u003ddelete_rules)"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"    def update_share_usage_size(self, context, shares):"},{"line_number":450,"context_line":"        update_shares \u003d []"},{"line_number":451,"context_line":"        out, err \u003d self._execute("},{"line_number":452,"context_line":"            \u0027df\u0027, \u0027-l\u0027, \u0027--output\u003dtarget,used\u0027,"},{"line_number":453,"context_line":"            \u0027--block-size\u003dg\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"ff346bd7_60eeb089","line":450,"range":{"start_line":450,"start_character":8,"end_line":450,"end_character":21},"updated":"2017-07-23 01:59:21.000000000","message":"updated_shares","commit_id":"102b5c20cde11db22ef72b5aba125ed84bdd7e02"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"abae4553f53e528e0a5e50fdd2ac25c0a152c056","unresolved":false,"context_lines":[{"line_number":447,"context_line":"                             add_rules\u003dadd_rules, delete_rules\u003ddelete_rules)"},{"line_number":448,"context_line":""},{"line_number":449,"context_line":"    def update_share_usage_size(self, context, shares):"},{"line_number":450,"context_line":"        update_shares \u003d []"},{"line_number":451,"context_line":"        out, err \u003d self._execute("},{"line_number":452,"context_line":"            \u0027df\u0027, \u0027-l\u0027, \u0027--output\u003dtarget,used\u0027,"},{"line_number":453,"context_line":"            \u0027--block-size\u003dg\u0027)"}],"source_content_type":"text/x-python","patch_set":26,"id":"ff346bd7_e9460b50","line":450,"range":{"start_line":450,"start_character":8,"end_line":450,"end_character":21},"in_reply_to":"ff346bd7_60eeb089","updated":"2017-07-23 03:44:23.000000000","message":"Done","commit_id":"102b5c20cde11db22ef72b5aba125ed84bdd7e02"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2dda47f1258fb78c20e69e33135baed7211b8832","unresolved":false,"context_lines":[{"line_number":468,"context_line":"                        _(\"Share mount path %s could not be \""},{"line_number":469,"context_line":"                          \"found.\") % mount_path)"},{"line_number":470,"context_line":"            except Exception:"},{"line_number":471,"context_line":"                LOG.exception(\"Gather share %s usage size failure.\","},{"line_number":472,"context_line":"                              share[\u0027id\u0027])"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"        return update_shares"}],"source_content_type":"text/x-python","patch_set":26,"id":"ff346bd7_80e99481","line":471,"range":{"start_line":471,"start_character":31,"end_line":471,"end_character":65},"updated":"2017-07-23 01:59:21.000000000","message":"Failed to gather \"used_size\" for share %s","commit_id":"102b5c20cde11db22ef72b5aba125ed84bdd7e02"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"abae4553f53e528e0a5e50fdd2ac25c0a152c056","unresolved":false,"context_lines":[{"line_number":468,"context_line":"                        _(\"Share mount path %s could not be \""},{"line_number":469,"context_line":"                          \"found.\") % mount_path)"},{"line_number":470,"context_line":"            except Exception:"},{"line_number":471,"context_line":"                LOG.exception(\"Gather share %s usage size failure.\","},{"line_number":472,"context_line":"                              share[\u0027id\u0027])"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"        return update_shares"}],"source_content_type":"text/x-python","patch_set":26,"id":"ff346bd7_69a9fbdd","line":471,"range":{"start_line":471,"start_character":31,"end_line":471,"end_character":65},"in_reply_to":"ff346bd7_80e99481","updated":"2017-07-23 03:44:23.000000000","message":"Done","commit_id":"102b5c20cde11db22ef72b5aba125ed84bdd7e02"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"715d61745c715b966b08b219e0e546742565aa3a","unresolved":false,"context_lines":[{"line_number":468,"context_line":"                        _(\"Share mount path %s could not be \""},{"line_number":469,"context_line":"                          \"found.\") % mount_path)"},{"line_number":470,"context_line":"            except Exception:"},{"line_number":471,"context_line":"                LOG.exception(\"Failed to gather \"used_size\" for share %s.\","},{"line_number":472,"context_line":"                              share[\u0027id\u0027])"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"        return updated_shares"}],"source_content_type":"text/x-python","patch_set":27,"id":"ff346bd7_4921974d","line":471,"range":{"start_line":471,"start_character":30,"end_line":471,"end_character":74},"updated":"2017-07-23 04:19:18.000000000","message":"\"Failed to gather \u0027used_size\u0027 for share %s.\"","commit_id":"8da1b8a3fd3d13435aa4eecf532c02c45f2c87e3"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"541a73cb6aefa49a7b21babb3feda352c215e94f","unresolved":false,"context_lines":[{"line_number":468,"context_line":"                        _(\"Share mount path %s could not be \""},{"line_number":469,"context_line":"                          \"found.\") % mount_path)"},{"line_number":470,"context_line":"            except Exception:"},{"line_number":471,"context_line":"                LOG.exception(\"Failed to gather \"used_size\" for share %s.\","},{"line_number":472,"context_line":"                              share[\u0027id\u0027])"},{"line_number":473,"context_line":""},{"line_number":474,"context_line":"        return updated_shares"}],"source_content_type":"text/x-python","patch_set":27,"id":"ff346bd7_f4fca23f","line":471,"range":{"start_line":471,"start_character":30,"end_line":471,"end_character":74},"in_reply_to":"ff346bd7_4921974d","updated":"2017-07-23 16:41:22.000000000","message":"Done","commit_id":"8da1b8a3fd3d13435aa4eecf532c02c45f2c87e3"}],"manila/share/manager.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ecc9c39673410df85b29e533cd7a4cd8070098be","unresolved":false,"context_lines":[{"line_number":108,"context_line":"               default\u003d60,"},{"line_number":109,"context_line":"               help\u003d\u0027This value, specified in seconds, determines how often \u0027"},{"line_number":110,"context_line":"                    \u0027the share manager will poll the driver to update the \u0027"},{"line_number":111,"context_line":"                    \u0027share usage size in the storage backend, for a share.\u0027),"},{"line_number":112,"context_line":"    cfg.BoolOpt(\u0027gather_share_usage_size\u0027,"},{"line_number":113,"context_line":"                default\u003dFalse,"},{"line_number":114,"context_line":"                help\u003d\u0027If set to True, then Manila will gather all share \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_7379acfa","line":111,"range":{"start_line":111,"start_character":62,"end_line":111,"end_character":73},"updated":"2017-06-30 11:29:08.000000000","message":"for shares in that backend.","commit_id":"86316c2dff90ed939783219a15960cc0a075fde2"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c75a9967059da8e6acfae59a1cf5907b06274e3e","unresolved":false,"context_lines":[{"line_number":108,"context_line":"               default\u003d60,"},{"line_number":109,"context_line":"               help\u003d\u0027This value, specified in seconds, determines how often \u0027"},{"line_number":110,"context_line":"                    \u0027the share manager will poll the driver to update the \u0027"},{"line_number":111,"context_line":"                    \u0027share usage size in the storage backend, for a share.\u0027),"},{"line_number":112,"context_line":"    cfg.BoolOpt(\u0027gather_share_usage_size\u0027,"},{"line_number":113,"context_line":"                default\u003dFalse,"},{"line_number":114,"context_line":"                help\u003d\u0027If set to True, then Manila will gather all share \u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_02fa0474","line":111,"range":{"start_line":111,"start_character":62,"end_line":111,"end_character":73},"in_reply_to":"3f1d235d_7379acfa","updated":"2017-07-03 03:26:25.000000000","message":"Done","commit_id":"86316c2dff90ed939783219a15960cc0a075fde2"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ecc9c39673410df85b29e533cd7a4cd8070098be","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                    \u0027share usage size in the storage backend, for a share.\u0027),"},{"line_number":112,"context_line":"    cfg.BoolOpt(\u0027gather_share_usage_size\u0027,"},{"line_number":113,"context_line":"                default\u003dFalse,"},{"line_number":114,"context_line":"                help\u003d\u0027If set to True, then Manila will gather all share \u0027"},{"line_number":115,"context_line":"                     \u0027usage size from the driver .\u0027"},{"line_number":116,"context_line":"                     \u0027If set to False - gather share usage size will be\u0027"},{"line_number":117,"context_line":"                     \u0027 disabled.\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_93f0c892","line":114,"range":{"start_line":114,"start_character":62,"end_line":114,"end_character":66},"updated":"2017-06-30 11:29:08.000000000","message":"remove","commit_id":"86316c2dff90ed939783219a15960cc0a075fde2"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c75a9967059da8e6acfae59a1cf5907b06274e3e","unresolved":false,"context_lines":[{"line_number":111,"context_line":"                    \u0027share usage size in the storage backend, for a share.\u0027),"},{"line_number":112,"context_line":"    cfg.BoolOpt(\u0027gather_share_usage_size\u0027,"},{"line_number":113,"context_line":"                default\u003dFalse,"},{"line_number":114,"context_line":"                help\u003d\u0027If set to True, then Manila will gather all share \u0027"},{"line_number":115,"context_line":"                     \u0027usage size from the driver .\u0027"},{"line_number":116,"context_line":"                     \u0027If set to False - gather share usage size will be\u0027"},{"line_number":117,"context_line":"                     \u0027 disabled.\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_e2f4a889","line":114,"range":{"start_line":114,"start_character":62,"end_line":114,"end_character":66},"in_reply_to":"3f1d235d_93f0c892","updated":"2017-07-03 03:26:25.000000000","message":"Done","commit_id":"86316c2dff90ed939783219a15960cc0a075fde2"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ecc9c39673410df85b29e533cd7a4cd8070098be","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    cfg.BoolOpt(\u0027gather_share_usage_size\u0027,"},{"line_number":113,"context_line":"                default\u003dFalse,"},{"line_number":114,"context_line":"                help\u003d\u0027If set to True, then Manila will gather all share \u0027"},{"line_number":115,"context_line":"                     \u0027usage size from the driver .\u0027"},{"line_number":116,"context_line":"                     \u0027If set to False - gather share usage size will be\u0027"},{"line_number":117,"context_line":"                     \u0027 disabled.\u0027),"},{"line_number":118,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_f3d01cfa","line":115,"range":{"start_line":115,"start_character":48,"end_line":115,"end_character":49},"updated":"2017-06-30 11:29:08.000000000","message":"remove this space","commit_id":"86316c2dff90ed939783219a15960cc0a075fde2"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c75a9967059da8e6acfae59a1cf5907b06274e3e","unresolved":false,"context_lines":[{"line_number":112,"context_line":"    cfg.BoolOpt(\u0027gather_share_usage_size\u0027,"},{"line_number":113,"context_line":"                default\u003dFalse,"},{"line_number":114,"context_line":"                help\u003d\u0027If set to True, then Manila will gather all share \u0027"},{"line_number":115,"context_line":"                     \u0027usage size from the driver .\u0027"},{"line_number":116,"context_line":"                     \u0027If set to False - gather share usage size will be\u0027"},{"line_number":117,"context_line":"                     \u0027 disabled.\u0027),"},{"line_number":118,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_a2eeb0b1","line":115,"range":{"start_line":115,"start_character":48,"end_line":115,"end_character":49},"in_reply_to":"3f1d235d_f3d01cfa","updated":"2017-07-03 03:26:25.000000000","message":"Done","commit_id":"86316c2dff90ed939783219a15960cc0a075fde2"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ecc9c39673410df85b29e533cd7a4cd8070098be","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                default\u003dFalse,"},{"line_number":114,"context_line":"                help\u003d\u0027If set to True, then Manila will gather all share \u0027"},{"line_number":115,"context_line":"                     \u0027usage size from the driver .\u0027"},{"line_number":116,"context_line":"                     \u0027If set to False - gather share usage size will be\u0027"},{"line_number":117,"context_line":"                     \u0027 disabled.\u0027),"},{"line_number":118,"context_line":"]"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_732becea","line":116,"range":{"start_line":116,"start_character":40,"end_line":116,"end_character":46},"updated":"2017-06-30 11:29:08.000000000","message":"gathering","commit_id":"86316c2dff90ed939783219a15960cc0a075fde2"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c75a9967059da8e6acfae59a1cf5907b06274e3e","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                default\u003dFalse,"},{"line_number":114,"context_line":"                help\u003d\u0027If set to True, then Manila will gather all share \u0027"},{"line_number":115,"context_line":"                     \u0027usage size from the driver .\u0027"},{"line_number":116,"context_line":"                     \u0027If set to False - gather share usage size will be\u0027"},{"line_number":117,"context_line":"                     \u0027 disabled.\u0027),"},{"line_number":118,"context_line":"]"},{"line_number":119,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_822bb4e9","line":116,"range":{"start_line":116,"start_character":40,"end_line":116,"end_character":46},"in_reply_to":"3f1d235d_732becea","updated":"2017-07-03 03:26:25.000000000","message":"Done","commit_id":"86316c2dff90ed939783219a15960cc0a075fde2"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ecc9c39673410df85b29e533cd7a4cd8070098be","unresolved":false,"context_lines":[{"line_number":3867,"context_line":"    @utils.require_driver_initialized"},{"line_number":3868,"context_line":"    def update_share_usage_size(self, context):"},{"line_number":3869,"context_line":"        \"\"\"Invokes driver to gather usage size of shares.\"\"\""},{"line_number":3870,"context_line":"        shares \u003d self.db.share_get_all(context)"},{"line_number":3871,"context_line":"        try:"},{"line_number":3872,"context_line":"            update_shares \u003d self.driver.update_share_usage_size("},{"line_number":3873,"context_line":"                context, shares)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_b3e4e4ad","line":3870,"range":{"start_line":3870,"start_character":8,"end_line":3870,"end_character":47},"updated":"2017-06-30 11:29:08.000000000","message":"won\u0027t this get all shares? including the shares that are not related to this backend?","commit_id":"86316c2dff90ed939783219a15960cc0a075fde2"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c75a9967059da8e6acfae59a1cf5907b06274e3e","unresolved":false,"context_lines":[{"line_number":3867,"context_line":"    @utils.require_driver_initialized"},{"line_number":3868,"context_line":"    def update_share_usage_size(self, context):"},{"line_number":3869,"context_line":"        \"\"\"Invokes driver to gather usage size of shares.\"\"\""},{"line_number":3870,"context_line":"        shares \u003d self.db.share_get_all(context)"},{"line_number":3871,"context_line":"        try:"},{"line_number":3872,"context_line":"            update_shares \u003d self.driver.update_share_usage_size("},{"line_number":3873,"context_line":"                context, shares)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_621778a5","line":3870,"range":{"start_line":3870,"start_character":8,"end_line":3870,"end_character":47},"in_reply_to":"3f1d235d_b3e4e4ad","updated":"2017-07-03 03:26:25.000000000","message":"Done","commit_id":"86316c2dff90ed939783219a15960cc0a075fde2"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ecc9c39673410df85b29e533cd7a4cd8070098be","unresolved":false,"context_lines":[{"line_number":3870,"context_line":"        shares \u003d self.db.share_get_all(context)"},{"line_number":3871,"context_line":"        try:"},{"line_number":3872,"context_line":"            update_shares \u003d self.driver.update_share_usage_size("},{"line_number":3873,"context_line":"                context, shares)"},{"line_number":3874,"context_line":"        except Exception:"},{"line_number":3875,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":3876,"context_line":"                LOG.error(\"Gather share usage size fail.\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_93fa0840","line":3873,"range":{"start_line":3873,"start_character":25,"end_line":3873,"end_character":31},"updated":"2017-06-30 11:29:08.000000000","message":"I believe that we usually pass share_instances to drivers, not actual shares.","commit_id":"86316c2dff90ed939783219a15960cc0a075fde2"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c75a9967059da8e6acfae59a1cf5907b06274e3e","unresolved":false,"context_lines":[{"line_number":3870,"context_line":"        shares \u003d self.db.share_get_all(context)"},{"line_number":3871,"context_line":"        try:"},{"line_number":3872,"context_line":"            update_shares \u003d self.driver.update_share_usage_size("},{"line_number":3873,"context_line":"                context, shares)"},{"line_number":3874,"context_line":"        except Exception:"},{"line_number":3875,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":3876,"context_line":"                LOG.error(\"Gather share usage size fail.\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_0228c4df","line":3873,"range":{"start_line":3873,"start_character":25,"end_line":3873,"end_character":31},"in_reply_to":"3f1d235d_93fa0840","updated":"2017-07-03 03:26:25.000000000","message":"Done","commit_id":"86316c2dff90ed939783219a15960cc0a075fde2"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ecc9c39673410df85b29e533cd7a4cd8070098be","unresolved":false,"context_lines":[{"line_number":3875,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":3876,"context_line":"                LOG.error(\"Gather share usage size fail.\")"},{"line_number":3877,"context_line":"        for s in update_shares:"},{"line_number":3878,"context_line":"            share \u003d self.db.share_get(context, s[\u0027id\u0027])"},{"line_number":3879,"context_line":"            share_instance \u003d self._get_share_instance("},{"line_number":3880,"context_line":"                context, share.instance[\u0027id\u0027])"},{"line_number":3881,"context_line":"            self._notify_about_share_usage("}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_f3881cc7","line":3878,"range":{"start_line":3878,"start_character":47,"end_line":3878,"end_character":54},"updated":"2017-06-30 11:29:08.000000000","message":"be careful here if you change to pass share instances to drivers","commit_id":"86316c2dff90ed939783219a15960cc0a075fde2"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c75a9967059da8e6acfae59a1cf5907b06274e3e","unresolved":false,"context_lines":[{"line_number":3875,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":3876,"context_line":"                LOG.error(\"Gather share usage size fail.\")"},{"line_number":3877,"context_line":"        for s in update_shares:"},{"line_number":3878,"context_line":"            share \u003d self.db.share_get(context, s[\u0027id\u0027])"},{"line_number":3879,"context_line":"            share_instance \u003d self._get_share_instance("},{"line_number":3880,"context_line":"                context, share.instance[\u0027id\u0027])"},{"line_number":3881,"context_line":"            self._notify_about_share_usage("}],"source_content_type":"text/x-python","patch_set":4,"id":"3f1d235d_e2226801","line":3878,"range":{"start_line":3878,"start_character":47,"end_line":3878,"end_character":54},"in_reply_to":"3f1d235d_f3881cc7","updated":"2017-07-03 03:26:25.000000000","message":"Done","commit_id":"86316c2dff90ed939783219a15960cc0a075fde2"},{"author":{"_account_id":20382,"name":"YuYang","email":"yuyangwang1985@gmail.com","username":"YuYangWang"},"change_message_id":"7983406e4ca99d68f2d82c27d3652d202c4ed7b3","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                    \u0027the share manager will poll the driver to perform the \u0027"},{"line_number":105,"context_line":"                    \u0027next step of migration in the storage backend, for a \u0027"},{"line_number":106,"context_line":"                    \u0027migrating share.\u0027),"},{"line_number":107,"context_line":"    cfg.IntOpt(\u0027share_usage_size_update_interval\u0027,"},{"line_number":108,"context_line":"               default\u003d60,"},{"line_number":109,"context_line":"               help\u003d\u0027This value, specified in seconds, determines how often \u0027"},{"line_number":110,"context_line":"                    \u0027the share manager will poll the driver to update the \u0027"},{"line_number":111,"context_line":"                    \u0027share usage size in the storage backend, for shares in \u0027"},{"line_number":112,"context_line":"                    \u0027that backend.\u0027),"},{"line_number":113,"context_line":"    cfg.BoolOpt(\u0027enable_gather_share_usage_size\u0027,"},{"line_number":114,"context_line":"                default\u003dFalse,"},{"line_number":115,"context_line":"                help\u003d\u0027If set to True, then Manila will gather share \u0027"},{"line_number":116,"context_line":"                     \u0027usage size from the driver.\u0027"},{"line_number":117,"context_line":"                     \u0027If set to False - gathering share usage size will be\u0027"},{"line_number":118,"context_line":"                     \u0027 disabled.\u0027),"},{"line_number":119,"context_line":"]"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_d085b2d0","line":118,"range":{"start_line":107,"start_character":0,"end_line":118,"end_character":35},"updated":"2017-07-05 03:33:45.000000000","message":"hi,this config is synchronize to the config file?https://docs.openstack.org/newton/config-reference/shared-file-systems/api.html","commit_id":"0f67870c8e17159f134860a35066aaf22a7aa3e9"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"eece36b83f3f761a47c53f14a8810d95f58cc5c4","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                    \u0027the share manager will poll the driver to perform the \u0027"},{"line_number":105,"context_line":"                    \u0027next step of migration in the storage backend, for a \u0027"},{"line_number":106,"context_line":"                    \u0027migrating share.\u0027),"},{"line_number":107,"context_line":"    cfg.IntOpt(\u0027share_usage_size_update_interval\u0027,"},{"line_number":108,"context_line":"               default\u003d60,"},{"line_number":109,"context_line":"               help\u003d\u0027This value, specified in seconds, determines how often \u0027"},{"line_number":110,"context_line":"                    \u0027the share manager will poll the driver to update the \u0027"},{"line_number":111,"context_line":"                    \u0027share usage size in the storage backend, for shares in \u0027"},{"line_number":112,"context_line":"                    \u0027that backend.\u0027),"},{"line_number":113,"context_line":"    cfg.BoolOpt(\u0027enable_gather_share_usage_size\u0027,"},{"line_number":114,"context_line":"                default\u003dFalse,"},{"line_number":115,"context_line":"                help\u003d\u0027If set to True, then Manila will gather share \u0027"},{"line_number":116,"context_line":"                     \u0027usage size from the driver.\u0027"},{"line_number":117,"context_line":"                     \u0027If set to False - gathering share usage size will be\u0027"},{"line_number":118,"context_line":"                     \u0027 disabled.\u0027),"},{"line_number":119,"context_line":"]"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_722e0aa6","line":118,"range":{"start_line":107,"start_character":0,"end_line":118,"end_character":35},"in_reply_to":"3f1d235d_d085b2d0","updated":"2017-07-12 02:02:29.000000000","message":"Yes, it will synchronize to the config file.","commit_id":"0f67870c8e17159f134860a35066aaf22a7aa3e9"},{"author":{"_account_id":20382,"name":"YuYang","email":"yuyangwang1985@gmail.com","username":"YuYangWang"},"change_message_id":"9c56823929e8bb0cfb53f000ed2671983747d84c","unresolved":false,"context_lines":[{"line_number":3889,"context_line":"                    context, update_share_instances)"},{"line_number":3890,"context_line":"        except Exception:"},{"line_number":3891,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":3892,"context_line":"                LOG.error(\"Gather share usage size fail.\")"},{"line_number":3893,"context_line":""},{"line_number":3894,"context_line":"        for si in update_share_instances:"},{"line_number":3895,"context_line":"            share_instance \u003d self._get_share_instance(context, si[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_30c066e1","line":3892,"range":{"start_line":3892,"start_character":16,"end_line":3892,"end_character":58},"updated":"2017-07-05 03:41:20.000000000","message":"does this add the error msg?thanks!","commit_id":"0f67870c8e17159f134860a35066aaf22a7aa3e9"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"eece36b83f3f761a47c53f14a8810d95f58cc5c4","unresolved":false,"context_lines":[{"line_number":3889,"context_line":"                    context, update_share_instances)"},{"line_number":3890,"context_line":"        except Exception:"},{"line_number":3891,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":3892,"context_line":"                LOG.error(\"Gather share usage size fail.\")"},{"line_number":3893,"context_line":""},{"line_number":3894,"context_line":"        for si in update_share_instances:"},{"line_number":3895,"context_line":"            share_instance \u003d self._get_share_instance(context, si[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f1d235d_d5802849","line":3892,"range":{"start_line":3892,"start_character":16,"end_line":3892,"end_character":58},"in_reply_to":"3f1d235d_30c066e1","updated":"2017-07-12 02:02:29.000000000","message":"Sorry, I am not sure what do you mean.","commit_id":"0f67870c8e17159f134860a35066aaf22a7aa3e9"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"0231123ba34e971b2d6bd8f395ae242fb494c993","unresolved":false,"context_lines":[{"line_number":3873,"context_line":"            context, host\u003dself.host, with_share_data\u003dTrue)"},{"line_number":3874,"context_line":""},{"line_number":3875,"context_line":"        for share_instance in share_instances:"},{"line_number":3876,"context_line":"            if share_instance[\u0027status\u0027] !\u003d constants.STATUS_AVAILABLE:"},{"line_number":3877,"context_line":"                LOG.info("},{"line_number":3878,"context_line":"                    \"Share instance %(id)s: skipping export, \""},{"line_number":3879,"context_line":"                    \"because it has \u0027%(status)s\u0027 status.\","}],"source_content_type":"text/x-python","patch_set":11,"id":"1f1a1f67_0be7dae6","line":3876,"range":{"start_line":3876,"start_character":0,"end_line":3876,"end_character":70},"updated":"2017-07-13 14:54:12.000000000","message":"Did we think this through and cover it in the spec?  Can we not check usage if the shrae isn\u0027t AVAILABLE?","commit_id":"0812466c4d8d8eff6463c93683df833d68ed6d6c"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"eccaab9097d86c73bd49409c4c987f7af7452c30","unresolved":false,"context_lines":[{"line_number":3873,"context_line":"            context, host\u003dself.host, with_share_data\u003dTrue)"},{"line_number":3874,"context_line":""},{"line_number":3875,"context_line":"        for share_instance in share_instances:"},{"line_number":3876,"context_line":"            if share_instance[\u0027status\u0027] !\u003d constants.STATUS_AVAILABLE:"},{"line_number":3877,"context_line":"                LOG.info("},{"line_number":3878,"context_line":"                    \"Share instance %(id)s: skipping export, \""},{"line_number":3879,"context_line":"                    \"because it has \u0027%(status)s\u0027 status.\","}],"source_content_type":"text/x-python","patch_set":11,"id":"1f1a1f67_d3e4e2ae","line":3876,"range":{"start_line":3876,"start_character":0,"end_line":3876,"end_character":70},"in_reply_to":"1f1a1f67_0be7dae6","updated":"2017-07-14 03:40:50.000000000","message":"Done","commit_id":"0812466c4d8d8eff6463c93683df833d68ed6d6c"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"0231123ba34e971b2d6bd8f395ae242fb494c993","unresolved":false,"context_lines":[{"line_number":3875,"context_line":"        for share_instance in share_instances:"},{"line_number":3876,"context_line":"            if share_instance[\u0027status\u0027] !\u003d constants.STATUS_AVAILABLE:"},{"line_number":3877,"context_line":"                LOG.info("},{"line_number":3878,"context_line":"                    \"Share instance %(id)s: skipping export, \""},{"line_number":3879,"context_line":"                    \"because it has \u0027%(status)s\u0027 status.\","},{"line_number":3880,"context_line":"                    {\u0027id\u0027: share_instance[\u0027id\u0027],"},{"line_number":3881,"context_line":"                     \u0027status\u0027: share_instance[\u0027status\u0027]},"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f1a1f67_2bd85651","line":3878,"range":{"start_line":3878,"start_character":0,"end_line":3878,"end_character":62},"updated":"2017-07-13 14:54:12.000000000","message":"We\u0027re not doing an export here :D","commit_id":"0812466c4d8d8eff6463c93683df833d68ed6d6c"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"eccaab9097d86c73bd49409c4c987f7af7452c30","unresolved":false,"context_lines":[{"line_number":3875,"context_line":"        for share_instance in share_instances:"},{"line_number":3876,"context_line":"            if share_instance[\u0027status\u0027] !\u003d constants.STATUS_AVAILABLE:"},{"line_number":3877,"context_line":"                LOG.info("},{"line_number":3878,"context_line":"                    \"Share instance %(id)s: skipping export, \""},{"line_number":3879,"context_line":"                    \"because it has \u0027%(status)s\u0027 status.\","},{"line_number":3880,"context_line":"                    {\u0027id\u0027: share_instance[\u0027id\u0027],"},{"line_number":3881,"context_line":"                     \u0027status\u0027: share_instance[\u0027status\u0027]},"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f1a1f67_93f0aa69","line":3878,"range":{"start_line":3878,"start_character":0,"end_line":3878,"end_character":62},"in_reply_to":"1f1a1f67_2bd85651","updated":"2017-07-14 03:40:50.000000000","message":"Done","commit_id":"0812466c4d8d8eff6463c93683df833d68ed6d6c"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"0231123ba34e971b2d6bd8f395ae242fb494c993","unresolved":false,"context_lines":[{"line_number":3889,"context_line":"                    context, update_share_instances)"},{"line_number":3890,"context_line":"        except Exception:"},{"line_number":3891,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":3892,"context_line":"                LOG.error(\"Gather share usage size fail.\")"},{"line_number":3893,"context_line":""},{"line_number":3894,"context_line":"        for si in update_share_instances:"},{"line_number":3895,"context_line":"            share_instance \u003d self._get_share_instance(context, si[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f1a1f67_0b00fa66","line":3892,"range":{"start_line":3892,"start_character":51,"end_line":3892,"end_character":55},"updated":"2017-07-13 14:54:12.000000000","message":"s/fail/failure/","commit_id":"0812466c4d8d8eff6463c93683df833d68ed6d6c"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"eccaab9097d86c73bd49409c4c987f7af7452c30","unresolved":false,"context_lines":[{"line_number":3889,"context_line":"                    context, update_share_instances)"},{"line_number":3890,"context_line":"        except Exception:"},{"line_number":3891,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":3892,"context_line":"                LOG.error(\"Gather share usage size fail.\")"},{"line_number":3893,"context_line":""},{"line_number":3894,"context_line":"        for si in update_share_instances:"},{"line_number":3895,"context_line":"            share_instance \u003d self._get_share_instance(context, si[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f1a1f67_73f3ce74","line":3892,"range":{"start_line":3892,"start_character":51,"end_line":3892,"end_character":55},"in_reply_to":"1f1a1f67_0b00fa66","updated":"2017-07-14 03:40:50.000000000","message":"Done","commit_id":"0812466c4d8d8eff6463c93683df833d68ed6d6c"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"8832b5ebff4b64ddcdf6d99c5bb85d42e7fbaa3f","unresolved":false,"context_lines":[{"line_number":3873,"context_line":"            context, host\u003dself.host, with_share_data\u003dTrue)"},{"line_number":3874,"context_line":""},{"line_number":3875,"context_line":"        try:"},{"line_number":3876,"context_line":"            if share_instances:"},{"line_number":3877,"context_line":"                update_share_instances \u003d self.driver.update_share_usage_size("},{"line_number":3878,"context_line":"                    context, share_instances)"},{"line_number":3879,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":15,"id":"1f1a1f67_b16fe3fa","line":3876,"range":{"start_line":3876,"start_character":11,"end_line":3876,"end_character":31},"updated":"2017-07-17 10:58:25.000000000","message":"why are we not collecting data only for available shares anymore?","commit_id":"0bc7e89a0f827eae293b417abb618c0a0bf35129"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"05a0240e48ce6f64411adee9cd0ed26af1c832c2","unresolved":false,"context_lines":[{"line_number":3873,"context_line":"            context, host\u003dself.host, with_share_data\u003dTrue)"},{"line_number":3874,"context_line":""},{"line_number":3875,"context_line":"        try:"},{"line_number":3876,"context_line":"            if share_instances:"},{"line_number":3877,"context_line":"                update_share_instances \u003d self.driver.update_share_usage_size("},{"line_number":3878,"context_line":"                    context, share_instances)"},{"line_number":3879,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":15,"id":"1f1a1f67_75c7f665","line":3876,"range":{"start_line":3876,"start_character":11,"end_line":3876,"end_character":31},"in_reply_to":"1f1a1f67_b16fe3fa","updated":"2017-07-17 11:20:06.000000000","message":"Because I think we can still use the share(such as: writing data to the share or something else) even if share status change to some status, such as: extending, shrinking, migrating. We also need to gather share usage size and bill it.\nManila service is the control level.It means we can not control the real share data operate, it also means we could write data to the share even if the share status has been changed to extending_error, error or something else.So the share usage size could still increasing. So we need to send all shares to driver and let driver to do it.","commit_id":"0bc7e89a0f827eae293b417abb618c0a0bf35129"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fac7fb022e41d817dae9499fa952d249cac1d5cd","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                    \u0027next step of migration in the storage backend, for a \u0027"},{"line_number":106,"context_line":"                    \u0027migrating share.\u0027),"},{"line_number":107,"context_line":"    cfg.IntOpt(\u0027share_usage_size_update_interval\u0027,"},{"line_number":108,"context_line":"               default\u003d60,"},{"line_number":109,"context_line":"               help\u003d\u0027This value, specified in seconds, determines how often \u0027"},{"line_number":110,"context_line":"                    \u0027the share manager will poll the driver to update the \u0027"},{"line_number":111,"context_line":"                    \u0027share usage size in the storage backend, for shares in \u0027"}],"source_content_type":"text/x-python","patch_set":21,"id":"1f1a1f67_2398e872","line":108,"range":{"start_line":108,"start_character":23,"end_line":108,"end_character":25},"updated":"2017-07-19 00:09:38.000000000","message":"? Every minute? Why not every 300 seconds? \n\nhttp://specs.openstack.org/openstack/manila-specs/specs/pike/gather_share_usage_size.html doesn\u0027t have this default value identified.","commit_id":"ddbd4c13f145f5690068d62e9aec94effbdb40b6"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"aa0d1fa89d5f91268178f01dbd1227790191e12e","unresolved":false,"context_lines":[{"line_number":105,"context_line":"                    \u0027next step of migration in the storage backend, for a \u0027"},{"line_number":106,"context_line":"                    \u0027migrating share.\u0027),"},{"line_number":107,"context_line":"    cfg.IntOpt(\u0027share_usage_size_update_interval\u0027,"},{"line_number":108,"context_line":"               default\u003d60,"},{"line_number":109,"context_line":"               help\u003d\u0027This value, specified in seconds, determines how often \u0027"},{"line_number":110,"context_line":"                    \u0027the share manager will poll the driver to update the \u0027"},{"line_number":111,"context_line":"                    \u0027share usage size in the storage backend, for shares in \u0027"}],"source_content_type":"text/x-python","patch_set":21,"id":"1f1a1f67_d7656ab6","line":108,"range":{"start_line":108,"start_character":23,"end_line":108,"end_character":25},"in_reply_to":"1f1a1f67_2398e872","updated":"2017-07-19 03:15:56.000000000","message":"There are many values, I just choose one, it could be a little rush billing. I will add default value in spec.","commit_id":"ddbd4c13f145f5690068d62e9aec94effbdb40b6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fac7fb022e41d817dae9499fa952d249cac1d5cd","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                    \u0027that backend.\u0027),"},{"line_number":113,"context_line":"    cfg.BoolOpt(\u0027enable_gather_share_usage_size\u0027,"},{"line_number":114,"context_line":"                default\u003dFalse,"},{"line_number":115,"context_line":"                help\u003d\u0027If set to True, then Manila will gather share \u0027"},{"line_number":116,"context_line":"                     \u0027usage size from the driver.\u0027"},{"line_number":117,"context_line":"                     \u0027If set to False - gathering share usage size will be\u0027"},{"line_number":118,"context_line":"                     \u0027 disabled.\u0027),"},{"line_number":119,"context_line":"]"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":21,"id":"1f1a1f67_63a02091","line":118,"range":{"start_line":115,"start_character":38,"end_line":118,"end_character":32},"updated":"2017-07-19 00:09:38.000000000","message":"share usage size will be polled for in the interval specified with \"share_usage_size_update_interval\". Usage data can be consumed\nby telemetry integration. If telemetry is not configured, this option\nmust be set to False.","commit_id":"ddbd4c13f145f5690068d62e9aec94effbdb40b6"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"aa0d1fa89d5f91268178f01dbd1227790191e12e","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                    \u0027that backend.\u0027),"},{"line_number":113,"context_line":"    cfg.BoolOpt(\u0027enable_gather_share_usage_size\u0027,"},{"line_number":114,"context_line":"                default\u003dFalse,"},{"line_number":115,"context_line":"                help\u003d\u0027If set to True, then Manila will gather share \u0027"},{"line_number":116,"context_line":"                     \u0027usage size from the driver.\u0027"},{"line_number":117,"context_line":"                     \u0027If set to False - gathering share usage size will be\u0027"},{"line_number":118,"context_line":"                     \u0027 disabled.\u0027),"},{"line_number":119,"context_line":"]"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":21,"id":"1f1a1f67_77d33605","line":118,"range":{"start_line":115,"start_character":38,"end_line":118,"end_character":32},"in_reply_to":"1f1a1f67_63a02091","updated":"2017-07-19 03:15:56.000000000","message":"Done","commit_id":"ddbd4c13f145f5690068d62e9aec94effbdb40b6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fac7fb022e41d817dae9499fa952d249cac1d5cd","unresolved":false,"context_lines":[{"line_number":3876,"context_line":"            if share_instances:"},{"line_number":3877,"context_line":"                update_share_instances \u003d self.driver.update_share_usage_size("},{"line_number":3878,"context_line":"                    context, share_instances)"},{"line_number":3879,"context_line":"        except Exception:"},{"line_number":3880,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":3881,"context_line":"                LOG.error(\"Gather share usage size failure.\")"},{"line_number":3882,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1f1a1f67_e3e2f0d4","line":3879,"range":{"start_line":3879,"start_character":15,"end_line":3879,"end_character":24},"updated":"2017-07-19 00:09:38.000000000","message":"specific exception are you expecting?","commit_id":"ddbd4c13f145f5690068d62e9aec94effbdb40b6"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"aa0d1fa89d5f91268178f01dbd1227790191e12e","unresolved":false,"context_lines":[{"line_number":3876,"context_line":"            if share_instances:"},{"line_number":3877,"context_line":"                update_share_instances \u003d self.driver.update_share_usage_size("},{"line_number":3878,"context_line":"                    context, share_instances)"},{"line_number":3879,"context_line":"        except Exception:"},{"line_number":3880,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":3881,"context_line":"                LOG.error(\"Gather share usage size failure.\")"},{"line_number":3882,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1f1a1f67_37349edd","line":3879,"range":{"start_line":3879,"start_character":15,"end_line":3879,"end_character":24},"in_reply_to":"1f1a1f67_e3e2f0d4","updated":"2017-07-19 03:15:56.000000000","message":"No, it just got all exception from driver and raise, we can get error message from log, and get real exception from driver.","commit_id":"ddbd4c13f145f5690068d62e9aec94effbdb40b6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fac7fb022e41d817dae9499fa952d249cac1d5cd","unresolved":false,"context_lines":[{"line_number":3877,"context_line":"                update_share_instances \u003d self.driver.update_share_usage_size("},{"line_number":3878,"context_line":"                    context, share_instances)"},{"line_number":3879,"context_line":"        except Exception:"},{"line_number":3880,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":3881,"context_line":"                LOG.error(\"Gather share usage size failure.\")"},{"line_number":3882,"context_line":""},{"line_number":3883,"context_line":"        for si in update_share_instances:"},{"line_number":3884,"context_line":"            share_instance \u003d self._get_share_instance(context, si[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":21,"id":"1f1a1f67_63c94057","line":3881,"range":{"start_line":3880,"start_character":12,"end_line":3881,"end_character":61},"updated":"2017-07-19 00:09:38.000000000","message":"why not just let the exception be raised? or just say:","commit_id":"ddbd4c13f145f5690068d62e9aec94effbdb40b6"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"aa0d1fa89d5f91268178f01dbd1227790191e12e","unresolved":false,"context_lines":[{"line_number":3877,"context_line":"                update_share_instances \u003d self.driver.update_share_usage_size("},{"line_number":3878,"context_line":"                    context, share_instances)"},{"line_number":3879,"context_line":"        except Exception:"},{"line_number":3880,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":3881,"context_line":"                LOG.error(\"Gather share usage size failure.\")"},{"line_number":3882,"context_line":""},{"line_number":3883,"context_line":"        for si in update_share_instances:"},{"line_number":3884,"context_line":"            share_instance \u003d self._get_share_instance(context, si[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":21,"id":"1f1a1f67_ace8657b","line":3881,"range":{"start_line":3880,"start_character":12,"end_line":3881,"end_character":61},"in_reply_to":"1f1a1f67_63c94057","updated":"2017-07-19 03:15:56.000000000","message":"Done","commit_id":"ddbd4c13f145f5690068d62e9aec94effbdb40b6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fac7fb022e41d817dae9499fa952d249cac1d5cd","unresolved":false,"context_lines":[{"line_number":3885,"context_line":"            share_id \u003d share_instance.get(\u0027share_id\u0027)"},{"line_number":3886,"context_line":"            share \u003d self.db.share_get(context, share_id)"},{"line_number":3887,"context_line":"            self._notify_about_share_usage("},{"line_number":3888,"context_line":"                context, share, share_instance, \"gather.size\","},{"line_number":3889,"context_line":"                extra_usage_info\u003d{\u0027used_size\u0027: si[\u0027used_size\u0027],"},{"line_number":3890,"context_line":"                                  \u0027gather_at\u0027: si[\u0027gather_at\u0027]})"}],"source_content_type":"text/x-python","patch_set":21,"id":"1f1a1f67_432084f7","line":3888,"range":{"start_line":3888,"start_character":49,"end_line":3888,"end_character":60},"updated":"2017-07-19 00:09:38.000000000","message":"???\n\nconsumed.size?","commit_id":"ddbd4c13f145f5690068d62e9aec94effbdb40b6"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"aa0d1fa89d5f91268178f01dbd1227790191e12e","unresolved":false,"context_lines":[{"line_number":3885,"context_line":"            share_id \u003d share_instance.get(\u0027share_id\u0027)"},{"line_number":3886,"context_line":"            share \u003d self.db.share_get(context, share_id)"},{"line_number":3887,"context_line":"            self._notify_about_share_usage("},{"line_number":3888,"context_line":"                context, share, share_instance, \"gather.size\","},{"line_number":3889,"context_line":"                extra_usage_info\u003d{\u0027used_size\u0027: si[\u0027used_size\u0027],"},{"line_number":3890,"context_line":"                                  \u0027gather_at\u0027: si[\u0027gather_at\u0027]})"}],"source_content_type":"text/x-python","patch_set":21,"id":"1f1a1f67_8c8489d4","line":3888,"range":{"start_line":3888,"start_character":49,"end_line":3888,"end_character":60},"in_reply_to":"1f1a1f67_432084f7","updated":"2017-07-19 03:15:56.000000000","message":"Done","commit_id":"ddbd4c13f145f5690068d62e9aec94effbdb40b6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fac7fb022e41d817dae9499fa952d249cac1d5cd","unresolved":false,"context_lines":[{"line_number":3887,"context_line":"            self._notify_about_share_usage("},{"line_number":3888,"context_line":"                context, share, share_instance, \"gather.size\","},{"line_number":3889,"context_line":"                extra_usage_info\u003d{\u0027used_size\u0027: si[\u0027used_size\u0027],"},{"line_number":3890,"context_line":"                                  \u0027gather_at\u0027: si[\u0027gather_at\u0027]})"}],"source_content_type":"text/x-python","patch_set":21,"id":"1f1a1f67_63cee05a","line":3890,"range":{"start_line":3890,"start_character":35,"end_line":3890,"end_character":44},"updated":"2017-07-19 00:09:38.000000000","message":"gathered_at","commit_id":"ddbd4c13f145f5690068d62e9aec94effbdb40b6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fac7fb022e41d817dae9499fa952d249cac1d5cd","unresolved":false,"context_lines":[{"line_number":3887,"context_line":"            self._notify_about_share_usage("},{"line_number":3888,"context_line":"                context, share, share_instance, \"gather.size\","},{"line_number":3889,"context_line":"                extra_usage_info\u003d{\u0027used_size\u0027: si[\u0027used_size\u0027],"},{"line_number":3890,"context_line":"                                  \u0027gather_at\u0027: si[\u0027gather_at\u0027]})"}],"source_content_type":"text/x-python","patch_set":21,"id":"1f1a1f67_a3e878b2","line":3890,"range":{"start_line":3890,"start_character":51,"end_line":3890,"end_character":60},"updated":"2017-07-19 00:09:38.000000000","message":"gathered_at","commit_id":"ddbd4c13f145f5690068d62e9aec94effbdb40b6"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"aa0d1fa89d5f91268178f01dbd1227790191e12e","unresolved":false,"context_lines":[{"line_number":3887,"context_line":"            self._notify_about_share_usage("},{"line_number":3888,"context_line":"                context, share, share_instance, \"gather.size\","},{"line_number":3889,"context_line":"                extra_usage_info\u003d{\u0027used_size\u0027: si[\u0027used_size\u0027],"},{"line_number":3890,"context_line":"                                  \u0027gather_at\u0027: si[\u0027gather_at\u0027]})"}],"source_content_type":"text/x-python","patch_set":21,"id":"1f1a1f67_ec7bfdf1","line":3890,"range":{"start_line":3890,"start_character":35,"end_line":3890,"end_character":44},"in_reply_to":"1f1a1f67_63cee05a","updated":"2017-07-19 03:15:56.000000000","message":"Done","commit_id":"ddbd4c13f145f5690068d62e9aec94effbdb40b6"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"aa0d1fa89d5f91268178f01dbd1227790191e12e","unresolved":false,"context_lines":[{"line_number":3887,"context_line":"            self._notify_about_share_usage("},{"line_number":3888,"context_line":"                context, share, share_instance, \"gather.size\","},{"line_number":3889,"context_line":"                extra_usage_info\u003d{\u0027used_size\u0027: si[\u0027used_size\u0027],"},{"line_number":3890,"context_line":"                                  \u0027gather_at\u0027: si[\u0027gather_at\u0027]})"}],"source_content_type":"text/x-python","patch_set":21,"id":"1f1a1f67_ac8185c5","line":3890,"range":{"start_line":3890,"start_character":51,"end_line":3890,"end_character":60},"in_reply_to":"1f1a1f67_a3e878b2","updated":"2017-07-19 03:15:56.000000000","message":"Done","commit_id":"ddbd4c13f145f5690068d62e9aec94effbdb40b6"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"20cb3c1451add894ec62139f65d9bbdc045ee5e5","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                     \u0027the interval specified with \u0027"},{"line_number":117,"context_line":"                     \u0027\"share_usage_size_update_interval\". Usage data can be \u0027"},{"line_number":118,"context_line":"                     \u0027consumed by telemetry integration. If telemetry is not \u0027"},{"line_number":119,"context_line":"                     \u0027configured, this option must be set to False.\u0027"},{"line_number":120,"context_line":"                     \u0027If set to False - gathering share usage size will be\u0027"},{"line_number":121,"context_line":"                     \u0027 disabled.\u0027),"},{"line_number":122,"context_line":"]"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"1f1a1f67_2b28b294","line":120,"range":{"start_line":119,"start_character":61,"end_line":120,"end_character":24},"updated":"2017-07-19 09:41:14.000000000","message":"space needed between \u0027False.\u0027 and \u0027If\u0027","commit_id":"9be94aa52692bf7f9a2980e4aab7aba080ffd26b"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b97eca349af7efe5443fd99adc4c90e2a960d36a","unresolved":false,"context_lines":[{"line_number":116,"context_line":"                     \u0027the interval specified with \u0027"},{"line_number":117,"context_line":"                     \u0027\"share_usage_size_update_interval\". Usage data can be \u0027"},{"line_number":118,"context_line":"                     \u0027consumed by telemetry integration. If telemetry is not \u0027"},{"line_number":119,"context_line":"                     \u0027configured, this option must be set to False.\u0027"},{"line_number":120,"context_line":"                     \u0027If set to False - gathering share usage size will be\u0027"},{"line_number":121,"context_line":"                     \u0027 disabled.\u0027),"},{"line_number":122,"context_line":"]"},{"line_number":123,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"1f1a1f67_c76245ae","line":120,"range":{"start_line":119,"start_character":61,"end_line":120,"end_character":24},"in_reply_to":"1f1a1f67_2b28b294","updated":"2017-07-19 16:24:39.000000000","message":"Done","commit_id":"9be94aa52692bf7f9a2980e4aab7aba080ffd26b"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"20cb3c1451add894ec62139f65d9bbdc045ee5e5","unresolved":false,"context_lines":[{"line_number":3879,"context_line":"            if share_instances:"},{"line_number":3880,"context_line":"                update_share_instances \u003d self.driver.update_share_usage_size("},{"line_number":3881,"context_line":"                    context, share_instances)"},{"line_number":3882,"context_line":"        except Exception:"},{"line_number":3883,"context_line":"            LOG.exception(\"Gather share usage size failure.\")"},{"line_number":3884,"context_line":"            raise"},{"line_number":3885,"context_line":""},{"line_number":3886,"context_line":"        for si in update_share_instances:"},{"line_number":3887,"context_line":"            share_instance \u003d self._get_share_instance(context, si[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":23,"id":"1f1a1f67_8fe591de","line":3884,"range":{"start_line":3882,"start_character":0,"end_line":3884,"end_character":17},"updated":"2017-07-19 09:41:14.000000000","message":"Need unit test coverage of this path: http://logs.openstack.org/55/465055/23/check/manila-coverage-ubuntu-xenial-nv/bda40ae/cover/manila_share_manager_py.html#n3882","commit_id":"9be94aa52692bf7f9a2980e4aab7aba080ffd26b"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b97eca349af7efe5443fd99adc4c90e2a960d36a","unresolved":false,"context_lines":[{"line_number":3879,"context_line":"            if share_instances:"},{"line_number":3880,"context_line":"                update_share_instances \u003d self.driver.update_share_usage_size("},{"line_number":3881,"context_line":"                    context, share_instances)"},{"line_number":3882,"context_line":"        except Exception:"},{"line_number":3883,"context_line":"            LOG.exception(\"Gather share usage size failure.\")"},{"line_number":3884,"context_line":"            raise"},{"line_number":3885,"context_line":""},{"line_number":3886,"context_line":"        for si in update_share_instances:"},{"line_number":3887,"context_line":"            share_instance \u003d self._get_share_instance(context, si[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":23,"id":"1f1a1f67_62847fd3","line":3884,"range":{"start_line":3882,"start_character":0,"end_line":3884,"end_character":17},"in_reply_to":"1f1a1f67_8fe591de","updated":"2017-07-19 16:24:39.000000000","message":"Done","commit_id":"9be94aa52692bf7f9a2980e4aab7aba080ffd26b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2dda47f1258fb78c20e69e33135baed7211b8832","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                    \u0027the share manager will poll the driver to update the \u0027"},{"line_number":111,"context_line":"                    \u0027share usage size in the storage backend, for shares in \u0027"},{"line_number":112,"context_line":"                    \u0027that backend.\u0027),"},{"line_number":113,"context_line":"    cfg.BoolOpt(\u0027enable_gather_share_usage_size\u0027,"},{"line_number":114,"context_line":"                default\u003dFalse,"},{"line_number":115,"context_line":"                help\u003d\u0027If set to True, share usage size will be polled for in \u0027"},{"line_number":116,"context_line":"                     \u0027the interval specified with \u0027"}],"source_content_type":"text/x-python","patch_set":26,"id":"ff346bd7_4003ac43","line":113,"range":{"start_line":113,"start_character":24,"end_line":113,"end_character":30},"updated":"2017-07-23 01:59:21.000000000","message":"gathering","commit_id":"102b5c20cde11db22ef72b5aba125ed84bdd7e02"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"abae4553f53e528e0a5e50fdd2ac25c0a152c056","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                    \u0027the share manager will poll the driver to update the \u0027"},{"line_number":111,"context_line":"                    \u0027share usage size in the storage backend, for shares in \u0027"},{"line_number":112,"context_line":"                    \u0027that backend.\u0027),"},{"line_number":113,"context_line":"    cfg.BoolOpt(\u0027enable_gather_share_usage_size\u0027,"},{"line_number":114,"context_line":"                default\u003dFalse,"},{"line_number":115,"context_line":"                help\u003d\u0027If set to True, share usage size will be polled for in \u0027"},{"line_number":116,"context_line":"                     \u0027the interval specified with \u0027"}],"source_content_type":"text/x-python","patch_set":26,"id":"ff346bd7_091caf68","line":113,"range":{"start_line":113,"start_character":24,"end_line":113,"end_character":30},"in_reply_to":"ff346bd7_4003ac43","updated":"2017-07-23 03:44:23.000000000","message":"Done","commit_id":"102b5c20cde11db22ef72b5aba125ed84bdd7e02"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2dda47f1258fb78c20e69e33135baed7211b8832","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                     \u0027consumed by telemetry integration. If telemetry is not \u0027"},{"line_number":119,"context_line":"                     \u0027configured, this option must be set to False. \u0027"},{"line_number":120,"context_line":"                     \u0027If set to False - gathering share usage size will be\u0027"},{"line_number":121,"context_line":"                     \u0027 disabled.\u0027),"},{"line_number":122,"context_line":"]"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":26,"id":"ff346bd7_a6e150d3","line":121,"range":{"start_line":121,"start_character":0,"end_line":121,"end_character":35},"updated":"2017-07-23 01:59:21.000000000","message":"What section do you set these options in?\nIf using multi-backend, and i set these options in the backend section, they don\u0027t seem to have any effect.\n\nI\u0027m trying to turn off share usage updates for a backend, and enable it only for LVM..","commit_id":"102b5c20cde11db22ef72b5aba125ed84bdd7e02"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"69e376d88d14845ff29409d40d6ebff3524cf331","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                     \u0027consumed by telemetry integration. If telemetry is not \u0027"},{"line_number":119,"context_line":"                     \u0027configured, this option must be set to False. \u0027"},{"line_number":120,"context_line":"                     \u0027If set to False - gathering share usage size will be\u0027"},{"line_number":121,"context_line":"                     \u0027 disabled.\u0027),"},{"line_number":122,"context_line":"]"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":26,"id":"ff346bd7_89b53ff1","line":121,"range":{"start_line":121,"start_character":0,"end_line":121,"end_character":35},"in_reply_to":"ff346bd7_290f732f","updated":"2017-07-23 04:28:02.000000000","message":"\"Is there a use case for share usage updates for a backend and enable it for another backend if thoes backend are support share usage update?\"\n\nMultibackend is a well supported feature in manila. Usage tracking will only be supported by LVM. What if I want to use LVM and Ceph in my installation? I want to provide LVM to certain customers, so i design a share type for that customer and enable usage tracking in manila using the options you\u0027re adding... But this will make the CEPH driver log errors.. \n\nI didn\u0027t expect this behavior when i tested this patch. I thought I could specify these options in the backend section for LVM and the other backend (NetApp in my case) will work just fine, but i started seeing LOG.errors every time the usage tracking occurred for LVM.\n\n\nAlso, if a backend doesn\u0027t support usage tracking, why log all the time at all? Can\u0027t we just log it at start time?","commit_id":"102b5c20cde11db22ef72b5aba125ed84bdd7e02"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"abae4553f53e528e0a5e50fdd2ac25c0a152c056","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                     \u0027consumed by telemetry integration. If telemetry is not \u0027"},{"line_number":119,"context_line":"                     \u0027configured, this option must be set to False. \u0027"},{"line_number":120,"context_line":"                     \u0027If set to False - gathering share usage size will be\u0027"},{"line_number":121,"context_line":"                     \u0027 disabled.\u0027),"},{"line_number":122,"context_line":"]"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":26,"id":"ff346bd7_290f732f","line":121,"range":{"start_line":121,"start_character":0,"end_line":121,"end_character":35},"in_reply_to":"ff346bd7_a6e150d3","updated":"2017-07-23 03:44:23.000000000","message":"Is there a use case for share usage updates for a backend and enable it for another backend if thoes backend are support share usage update?\nThe user doesn\u0027t care about they create a share in which backend. If the admin want to billing by share usage size, they must want to gather share usage size in all backend. If the backend doesn\u0027t support gather share usage size, then we need to keep log it and let the admin known it. If we only log the error in beginning, it could let admin ignore it.","commit_id":"102b5c20cde11db22ef72b5aba125ed84bdd7e02"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2dda47f1258fb78c20e69e33135baed7211b8832","unresolved":false,"context_lines":[{"line_number":3871,"context_line":"    @utils.require_driver_initialized"},{"line_number":3872,"context_line":"    def update_share_usage_size(self, context):"},{"line_number":3873,"context_line":"        \"\"\"Invokes driver to gather usage size of shares.\"\"\""},{"line_number":3874,"context_line":"        update_share_instances \u003d []"},{"line_number":3875,"context_line":"        share_instances \u003d self.db.share_instances_get_all_by_host("},{"line_number":3876,"context_line":"            context, host\u003dself.host, with_share_data\u003dTrue)"},{"line_number":3877,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"ff346bd7_a066d850","line":3874,"range":{"start_line":3874,"start_character":8,"end_line":3874,"end_character":30},"updated":"2017-07-23 01:59:21.000000000","message":"updated_share_instances","commit_id":"102b5c20cde11db22ef72b5aba125ed84bdd7e02"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"abae4553f53e528e0a5e50fdd2ac25c0a152c056","unresolved":false,"context_lines":[{"line_number":3871,"context_line":"    @utils.require_driver_initialized"},{"line_number":3872,"context_line":"    def update_share_usage_size(self, context):"},{"line_number":3873,"context_line":"        \"\"\"Invokes driver to gather usage size of shares.\"\"\""},{"line_number":3874,"context_line":"        update_share_instances \u003d []"},{"line_number":3875,"context_line":"        share_instances \u003d self.db.share_instances_get_all_by_host("},{"line_number":3876,"context_line":"            context, host\u003dself.host, with_share_data\u003dTrue)"},{"line_number":3877,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"ff346bd7_e9184b76","line":3874,"range":{"start_line":3874,"start_character":8,"end_line":3874,"end_character":30},"in_reply_to":"ff346bd7_a066d850","updated":"2017-07-23 03:44:23.000000000","message":"Done","commit_id":"102b5c20cde11db22ef72b5aba125ed84bdd7e02"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2dda47f1258fb78c20e69e33135baed7211b8832","unresolved":false,"context_lines":[{"line_number":3875,"context_line":"        share_instances \u003d self.db.share_instances_get_all_by_host("},{"line_number":3876,"context_line":"            context, host\u003dself.host, with_share_data\u003dTrue)"},{"line_number":3877,"context_line":""},{"line_number":3878,"context_line":"        try:"},{"line_number":3879,"context_line":"            if share_instances:"},{"line_number":3880,"context_line":"                update_share_instances \u003d self.driver.update_share_usage_size("},{"line_number":3881,"context_line":"                    context, share_instances)"}],"source_content_type":"text/x-python","patch_set":26,"id":"ff346bd7_805bd485","line":3878,"range":{"start_line":3878,"start_character":8,"end_line":3878,"end_character":12},"updated":"2017-07-23 01:59:21.000000000","message":"try except must be inside the condition..","commit_id":"102b5c20cde11db22ef72b5aba125ed84bdd7e02"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"abae4553f53e528e0a5e50fdd2ac25c0a152c056","unresolved":false,"context_lines":[{"line_number":3875,"context_line":"        share_instances \u003d self.db.share_instances_get_all_by_host("},{"line_number":3876,"context_line":"            context, host\u003dself.host, with_share_data\u003dTrue)"},{"line_number":3877,"context_line":""},{"line_number":3878,"context_line":"        try:"},{"line_number":3879,"context_line":"            if share_instances:"},{"line_number":3880,"context_line":"                update_share_instances \u003d self.driver.update_share_usage_size("},{"line_number":3881,"context_line":"                    context, share_instances)"}],"source_content_type":"text/x-python","patch_set":26,"id":"ff346bd7_e9316bee","line":3878,"range":{"start_line":3878,"start_character":8,"end_line":3878,"end_character":12},"in_reply_to":"ff346bd7_805bd485","updated":"2017-07-23 03:44:23.000000000","message":"Done","commit_id":"102b5c20cde11db22ef72b5aba125ed84bdd7e02"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2dda47f1258fb78c20e69e33135baed7211b8832","unresolved":false,"context_lines":[{"line_number":3877,"context_line":""},{"line_number":3878,"context_line":"        try:"},{"line_number":3879,"context_line":"            if share_instances:"},{"line_number":3880,"context_line":"                update_share_instances \u003d self.driver.update_share_usage_size("},{"line_number":3881,"context_line":"                    context, share_instances)"},{"line_number":3882,"context_line":"        except Exception:"},{"line_number":3883,"context_line":"            LOG.exception(\"Gather share usage size failure.\")"}],"source_content_type":"text/x-python","patch_set":26,"id":"ff346bd7_c061dc3b","line":3880,"range":{"start_line":3880,"start_character":16,"end_line":3880,"end_character":38},"updated":"2017-07-23 01:59:21.000000000","message":"updated_share_instances","commit_id":"102b5c20cde11db22ef72b5aba125ed84bdd7e02"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"abae4553f53e528e0a5e50fdd2ac25c0a152c056","unresolved":false,"context_lines":[{"line_number":3877,"context_line":""},{"line_number":3878,"context_line":"        try:"},{"line_number":3879,"context_line":"            if share_instances:"},{"line_number":3880,"context_line":"                update_share_instances \u003d self.driver.update_share_usage_size("},{"line_number":3881,"context_line":"                    context, share_instances)"},{"line_number":3882,"context_line":"        except Exception:"},{"line_number":3883,"context_line":"            LOG.exception(\"Gather share usage size failure.\")"}],"source_content_type":"text/x-python","patch_set":26,"id":"ff346bd7_a92c8399","line":3880,"range":{"start_line":3880,"start_character":16,"end_line":3880,"end_character":38},"in_reply_to":"ff346bd7_c061dc3b","updated":"2017-07-23 03:44:23.000000000","message":"Done","commit_id":"102b5c20cde11db22ef72b5aba125ed84bdd7e02"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2dda47f1258fb78c20e69e33135baed7211b8832","unresolved":false,"context_lines":[{"line_number":3880,"context_line":"                update_share_instances \u003d self.driver.update_share_usage_size("},{"line_number":3881,"context_line":"                    context, share_instances)"},{"line_number":3882,"context_line":"        except Exception:"},{"line_number":3883,"context_line":"            LOG.exception(\"Gather share usage size failure.\")"},{"line_number":3884,"context_line":"            raise"},{"line_number":3885,"context_line":""},{"line_number":3886,"context_line":"        for si in update_share_instances:"},{"line_number":3887,"context_line":"            share_instance \u003d self._get_share_instance(context, si[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":26,"id":"ff346bd7_4055ec4f","line":3884,"range":{"start_line":3883,"start_character":12,"end_line":3884,"end_character":17},"updated":"2017-07-23 01:59:21.000000000","message":"No need to raise the exception.. just log it and return.","commit_id":"102b5c20cde11db22ef72b5aba125ed84bdd7e02"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"abae4553f53e528e0a5e50fdd2ac25c0a152c056","unresolved":false,"context_lines":[{"line_number":3880,"context_line":"                update_share_instances \u003d self.driver.update_share_usage_size("},{"line_number":3881,"context_line":"                    context, share_instances)"},{"line_number":3882,"context_line":"        except Exception:"},{"line_number":3883,"context_line":"            LOG.exception(\"Gather share usage size failure.\")"},{"line_number":3884,"context_line":"            raise"},{"line_number":3885,"context_line":""},{"line_number":3886,"context_line":"        for si in update_share_instances:"},{"line_number":3887,"context_line":"            share_instance \u003d self._get_share_instance(context, si[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":26,"id":"ff346bd7_69269bba","line":3884,"range":{"start_line":3883,"start_character":12,"end_line":3884,"end_character":17},"in_reply_to":"ff346bd7_4055ec4f","updated":"2017-07-23 03:44:23.000000000","message":"Done","commit_id":"102b5c20cde11db22ef72b5aba125ed84bdd7e02"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2dda47f1258fb78c20e69e33135baed7211b8832","unresolved":false,"context_lines":[{"line_number":3885,"context_line":""},{"line_number":3886,"context_line":"        for si in update_share_instances:"},{"line_number":3887,"context_line":"            share_instance \u003d self._get_share_instance(context, si[\u0027id\u0027])"},{"line_number":3888,"context_line":"            share_id \u003d share_instance.get(\u0027share_id\u0027)"},{"line_number":3889,"context_line":"            share \u003d self.db.share_get(context, share_id)"},{"line_number":3890,"context_line":"            self._notify_about_share_usage("},{"line_number":3891,"context_line":"                context, share, share_instance, \"consumed.size\","}],"source_content_type":"text/x-python","patch_set":26,"id":"ff346bd7_e04bc0ad","line":3888,"range":{"start_line":3888,"start_character":12,"end_line":3888,"end_character":53},"updated":"2017-07-23 01:59:21.000000000","message":"remove","commit_id":"102b5c20cde11db22ef72b5aba125ed84bdd7e02"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"abae4553f53e528e0a5e50fdd2ac25c0a152c056","unresolved":false,"context_lines":[{"line_number":3885,"context_line":""},{"line_number":3886,"context_line":"        for si in update_share_instances:"},{"line_number":3887,"context_line":"            share_instance \u003d self._get_share_instance(context, si[\u0027id\u0027])"},{"line_number":3888,"context_line":"            share_id \u003d share_instance.get(\u0027share_id\u0027)"},{"line_number":3889,"context_line":"            share \u003d self.db.share_get(context, share_id)"},{"line_number":3890,"context_line":"            self._notify_about_share_usage("},{"line_number":3891,"context_line":"                context, share, share_instance, \"consumed.size\","}],"source_content_type":"text/x-python","patch_set":26,"id":"ff346bd7_493bd7d0","line":3888,"range":{"start_line":3888,"start_character":12,"end_line":3888,"end_character":53},"in_reply_to":"ff346bd7_e04bc0ad","updated":"2017-07-23 03:44:23.000000000","message":"Done","commit_id":"102b5c20cde11db22ef72b5aba125ed84bdd7e02"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2dda47f1258fb78c20e69e33135baed7211b8832","unresolved":false,"context_lines":[{"line_number":3886,"context_line":"        for si in update_share_instances:"},{"line_number":3887,"context_line":"            share_instance \u003d self._get_share_instance(context, si[\u0027id\u0027])"},{"line_number":3888,"context_line":"            share_id \u003d share_instance.get(\u0027share_id\u0027)"},{"line_number":3889,"context_line":"            share \u003d self.db.share_get(context, share_id)"},{"line_number":3890,"context_line":"            self._notify_about_share_usage("},{"line_number":3891,"context_line":"                context, share, share_instance, \"consumed.size\","},{"line_number":3892,"context_line":"                extra_usage_info\u003d{\u0027used_size\u0027: si[\u0027used_size\u0027],"}],"source_content_type":"text/x-python","patch_set":26,"id":"ff346bd7_80d074cb","line":3889,"range":{"start_line":3889,"start_character":47,"end_line":3889,"end_character":55},"updated":"2017-07-23 01:59:21.000000000","message":"share_instance[\u0027share_id\u0027]","commit_id":"102b5c20cde11db22ef72b5aba125ed84bdd7e02"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"abae4553f53e528e0a5e50fdd2ac25c0a152c056","unresolved":false,"context_lines":[{"line_number":3886,"context_line":"        for si in update_share_instances:"},{"line_number":3887,"context_line":"            share_instance \u003d self._get_share_instance(context, si[\u0027id\u0027])"},{"line_number":3888,"context_line":"            share_id \u003d share_instance.get(\u0027share_id\u0027)"},{"line_number":3889,"context_line":"            share \u003d self.db.share_get(context, share_id)"},{"line_number":3890,"context_line":"            self._notify_about_share_usage("},{"line_number":3891,"context_line":"                context, share, share_instance, \"consumed.size\","},{"line_number":3892,"context_line":"                extra_usage_info\u003d{\u0027used_size\u0027: si[\u0027used_size\u0027],"}],"source_content_type":"text/x-python","patch_set":26,"id":"ff346bd7_293893d1","line":3889,"range":{"start_line":3889,"start_character":47,"end_line":3889,"end_character":55},"in_reply_to":"ff346bd7_80d074cb","updated":"2017-07-23 03:44:23.000000000","message":"Done","commit_id":"102b5c20cde11db22ef72b5aba125ed84bdd7e02"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"715d61745c715b966b08b219e0e546742565aa3a","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                    \u0027the share manager will poll the driver to perform the \u0027"},{"line_number":105,"context_line":"                    \u0027next step of migration in the storage backend, for a \u0027"},{"line_number":106,"context_line":"                    \u0027migrating share.\u0027),"},{"line_number":107,"context_line":"    cfg.IntOpt(\u0027share_gathering_size_update_interval\u0027,"},{"line_number":108,"context_line":"               default\u003d300,"},{"line_number":109,"context_line":"               help\u003d\u0027This value, specified in seconds, determines how often \u0027"},{"line_number":110,"context_line":"                    \u0027the share manager will poll the driver to update the \u0027"}],"source_content_type":"text/x-python","patch_set":27,"id":"ff346bd7_c92d8747","line":107,"range":{"start_line":107,"start_character":22,"end_line":107,"end_character":31},"updated":"2017-07-23 04:19:18.000000000","message":"usage","commit_id":"8da1b8a3fd3d13435aa4eecf532c02c45f2c87e3"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"ede36738d8acb599526522314d8102a626e5c6f0","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                    \u0027the share manager will poll the driver to perform the \u0027"},{"line_number":105,"context_line":"                    \u0027next step of migration in the storage backend, for a \u0027"},{"line_number":106,"context_line":"                    \u0027migrating share.\u0027),"},{"line_number":107,"context_line":"    cfg.IntOpt(\u0027share_gathering_size_update_interval\u0027,"},{"line_number":108,"context_line":"               default\u003d300,"},{"line_number":109,"context_line":"               help\u003d\u0027This value, specified in seconds, determines how often \u0027"},{"line_number":110,"context_line":"                    \u0027the share manager will poll the driver to update the \u0027"}],"source_content_type":"text/x-python","patch_set":27,"id":"ff346bd7_343eaa29","line":107,"range":{"start_line":107,"start_character":22,"end_line":107,"end_character":31},"in_reply_to":"ff346bd7_c92d8747","updated":"2017-07-23 08:30:40.000000000","message":"+1","commit_id":"8da1b8a3fd3d13435aa4eecf532c02c45f2c87e3"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"541a73cb6aefa49a7b21babb3feda352c215e94f","unresolved":false,"context_lines":[{"line_number":104,"context_line":"                    \u0027the share manager will poll the driver to perform the \u0027"},{"line_number":105,"context_line":"                    \u0027next step of migration in the storage backend, for a \u0027"},{"line_number":106,"context_line":"                    \u0027migrating share.\u0027),"},{"line_number":107,"context_line":"    cfg.IntOpt(\u0027share_gathering_size_update_interval\u0027,"},{"line_number":108,"context_line":"               default\u003d300,"},{"line_number":109,"context_line":"               help\u003d\u0027This value, specified in seconds, determines how often \u0027"},{"line_number":110,"context_line":"                    \u0027the share manager will poll the driver to update the \u0027"}],"source_content_type":"text/x-python","patch_set":27,"id":"ff346bd7_54d5aeb8","line":107,"range":{"start_line":107,"start_character":22,"end_line":107,"end_character":31},"in_reply_to":"ff346bd7_c92d8747","updated":"2017-07-23 16:41:22.000000000","message":"Done","commit_id":"8da1b8a3fd3d13435aa4eecf532c02c45f2c87e3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"715d61745c715b966b08b219e0e546742565aa3a","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                    \u0027the share manager will poll the driver to update the \u0027"},{"line_number":111,"context_line":"                    \u0027share usage size in the storage backend, for shares in \u0027"},{"line_number":112,"context_line":"                    \u0027that backend.\u0027),"},{"line_number":113,"context_line":"    cfg.BoolOpt(\u0027enable_gather_share_usage_size\u0027,"},{"line_number":114,"context_line":"                default\u003dFalse,"},{"line_number":115,"context_line":"                help\u003d\u0027If set to True, share usage size will be polled for in \u0027"},{"line_number":116,"context_line":"                     \u0027the interval specified with \u0027"}],"source_content_type":"text/x-python","patch_set":27,"id":"ff346bd7_a93243a6","line":113,"range":{"start_line":113,"start_character":24,"end_line":113,"end_character":30},"updated":"2017-07-23 04:19:18.000000000","message":"gathering","commit_id":"8da1b8a3fd3d13435aa4eecf532c02c45f2c87e3"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"ede36738d8acb599526522314d8102a626e5c6f0","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                    \u0027the share manager will poll the driver to update the \u0027"},{"line_number":111,"context_line":"                    \u0027share usage size in the storage backend, for shares in \u0027"},{"line_number":112,"context_line":"                    \u0027that backend.\u0027),"},{"line_number":113,"context_line":"    cfg.BoolOpt(\u0027enable_gather_share_usage_size\u0027,"},{"line_number":114,"context_line":"                default\u003dFalse,"},{"line_number":115,"context_line":"                help\u003d\u0027If set to True, share usage size will be polled for in \u0027"},{"line_number":116,"context_line":"                     \u0027the interval specified with \u0027"}],"source_content_type":"text/x-python","patch_set":27,"id":"ff346bd7_143ba638","line":113,"range":{"start_line":113,"start_character":24,"end_line":113,"end_character":30},"in_reply_to":"ff346bd7_a93243a6","updated":"2017-07-23 08:30:40.000000000","message":"+1","commit_id":"8da1b8a3fd3d13435aa4eecf532c02c45f2c87e3"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"541a73cb6aefa49a7b21babb3feda352c215e94f","unresolved":false,"context_lines":[{"line_number":110,"context_line":"                    \u0027the share manager will poll the driver to update the \u0027"},{"line_number":111,"context_line":"                    \u0027share usage size in the storage backend, for shares in \u0027"},{"line_number":112,"context_line":"                    \u0027that backend.\u0027),"},{"line_number":113,"context_line":"    cfg.BoolOpt(\u0027enable_gather_share_usage_size\u0027,"},{"line_number":114,"context_line":"                default\u003dFalse,"},{"line_number":115,"context_line":"                help\u003d\u0027If set to True, share usage size will be polled for in \u0027"},{"line_number":116,"context_line":"                     \u0027the interval specified with \u0027"}],"source_content_type":"text/x-python","patch_set":27,"id":"ff346bd7_34da2ae9","line":113,"range":{"start_line":113,"start_character":24,"end_line":113,"end_character":30},"in_reply_to":"ff346bd7_a93243a6","updated":"2017-07-23 16:41:22.000000000","message":"Done","commit_id":"8da1b8a3fd3d13435aa4eecf532c02c45f2c87e3"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ad156b5c4e3da2c3b256d4fe373d128f6ab4a2d9","unresolved":false,"context_lines":[{"line_number":3863,"context_line":"        if not self.driver.enable_gathering_share_usage_size:"},{"line_number":3864,"context_line":"            if \u0027update_share_usage_size\u0027 in self._periodic_last_run:"},{"line_number":3865,"context_line":"                self._periodic_last_run.pop(\u0027update_share_usage_size\u0027)"},{"line_number":3866,"context_line":"            for task in self._periodic_tasks:"},{"line_number":3867,"context_line":"                if \u0027update_share_usage_size\u0027 in task:"},{"line_number":3868,"context_line":"                    self._periodic_tasks.remove(task)"},{"line_number":3869,"context_line":"            return"},{"line_number":3870,"context_line":"        updated_share_instances \u003d []"},{"line_number":3871,"context_line":"        share_instances \u003d self.db.share_instances_get_all_by_host("}],"source_content_type":"text/x-python","patch_set":35,"id":"ff346bd7_ace451ad","line":3868,"range":{"start_line":3866,"start_character":0,"end_line":3868,"end_character":53},"updated":"2017-07-25 12:53:20.000000000","message":"where is self._periodic_tasks instantiated?\n\npylint fails here: \n\n2017-07-25 11:48:55.011626 | manila/share/manager.py:4040: [E1101, ShareManager.update_share_usage_size] Instance of \u0027ShareManager\u0027 has no \u0027_periodic_tasks\u0027 member\n2017-07-25 11:48:55.011652 | \n2017-07-25 11:48:55.011697 | manila/share/manager.py:4042: [E1101, ShareManager.update_share_usage_size] Instance of \u0027ShareManager\u0027 has no \u0027_periodic_tasks\u0027 member","commit_id":"caa62035021d6af3ac0abe27c6e47a72c14c729d"}],"manila/tests/share/drivers/dummy.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fac7fb022e41d817dae9499fa952d249cac1d5cd","unresolved":false,"context_lines":[{"line_number":632,"context_line":"    def update_share_usage_size(self, context, shares):"},{"line_number":633,"context_line":"        share_updates \u003d []"},{"line_number":634,"context_line":"        for s in shares:"},{"line_number":635,"context_line":"            share_updates.append({\u0027id\u0027: s.get(\u0027id\u0027), \u0027used_size\u0027:  1})"},{"line_number":636,"context_line":"        return share_updates"}],"source_content_type":"text/x-python","patch_set":21,"id":"1f1a1f67_836fbc29","line":635,"range":{"start_line":635,"start_character":67,"end_line":635,"end_character":68},"updated":"2017-07-19 00:09:38.000000000","message":"share[\u0027size\u0027] + 1","commit_id":"ddbd4c13f145f5690068d62e9aec94effbdb40b6"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"aa0d1fa89d5f91268178f01dbd1227790191e12e","unresolved":false,"context_lines":[{"line_number":632,"context_line":"    def update_share_usage_size(self, context, shares):"},{"line_number":633,"context_line":"        share_updates \u003d []"},{"line_number":634,"context_line":"        for s in shares:"},{"line_number":635,"context_line":"            share_updates.append({\u0027id\u0027: s.get(\u0027id\u0027), \u0027used_size\u0027:  1})"},{"line_number":636,"context_line":"        return share_updates"}],"source_content_type":"text/x-python","patch_set":21,"id":"1f1a1f67_b7a30e00","line":635,"range":{"start_line":635,"start_character":67,"end_line":635,"end_character":68},"in_reply_to":"1f1a1f67_836fbc29","updated":"2017-07-19 03:15:56.000000000","message":"The used_size cannot larger than share[\u0027size\u0027](total size of one share). The minimum share size is 1G when we want to create a new share. So I set it to 1 in this place.","commit_id":"ddbd4c13f145f5690068d62e9aec94effbdb40b6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2dda47f1258fb78c20e69e33135baed7211b8832","unresolved":false,"context_lines":[{"line_number":632,"context_line":"    def update_share_usage_size(self, context, shares):"},{"line_number":633,"context_line":"        share_updates \u003d []"},{"line_number":634,"context_line":"        for s in shares:"},{"line_number":635,"context_line":"            share_updates.append({\u0027id\u0027: s.get(\u0027id\u0027), \u0027used_size\u0027:  1})"},{"line_number":636,"context_line":"        return share_updates"}],"source_content_type":"text/x-python","patch_set":26,"id":"ff346bd7_208548ae","line":635,"range":{"start_line":635,"start_character":41,"end_line":635,"end_character":45},"updated":"2017-07-23 01:59:21.000000000","message":"use []\nwhen you know the key will exist","commit_id":"102b5c20cde11db22ef72b5aba125ed84bdd7e02"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"abae4553f53e528e0a5e50fdd2ac25c0a152c056","unresolved":false,"context_lines":[{"line_number":632,"context_line":"    def update_share_usage_size(self, context, shares):"},{"line_number":633,"context_line":"        share_updates \u003d []"},{"line_number":634,"context_line":"        for s in shares:"},{"line_number":635,"context_line":"            share_updates.append({\u0027id\u0027: s.get(\u0027id\u0027), \u0027used_size\u0027:  1})"},{"line_number":636,"context_line":"        return share_updates"}],"source_content_type":"text/x-python","patch_set":26,"id":"ff346bd7_c94c6778","line":635,"range":{"start_line":635,"start_character":41,"end_line":635,"end_character":45},"in_reply_to":"ff346bd7_208548ae","updated":"2017-07-23 03:44:23.000000000","message":"Done","commit_id":"102b5c20cde11db22ef72b5aba125ed84bdd7e02"}],"manila/tests/share/drivers/test_lvm.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"20cb3c1451add894ec62139f65d9bbdc045ee5e5","unresolved":false,"context_lines":[{"line_number":595,"context_line":"            access_rules, add_rules\u003dadd_rules, delete_rules\u003ddelete_rules))"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"    @mock.patch.object(timeutils, \u0027utcnow\u0027, mock.Mock("},{"line_number":598,"context_line":"                       return_value\u003ddatetime.datetime("},{"line_number":599,"context_line":"                           2017, 7, 18, 16, 59, 33, 33124)))"},{"line_number":600,"context_line":"    def test_update_share_usage_size(self):"},{"line_number":601,"context_line":"        mount_path \u003d self._get_mount_path(self.share)"},{"line_number":602,"context_line":"        self._os.path.exists.return_value \u003d True"}],"source_content_type":"text/x-python","patch_set":23,"id":"1f1a1f67_ab472277","line":599,"range":{"start_line":598,"start_character":36,"end_line":599,"end_character":57},"updated":"2017-07-19 09:41:14.000000000","message":"You repeat this datetime value a number of times so it would make sense to set fake_datetime \u003d ... and use fake_datetime in those occurrences.","commit_id":"9be94aa52692bf7f9a2980e4aab7aba080ffd26b"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"b97eca349af7efe5443fd99adc4c90e2a960d36a","unresolved":false,"context_lines":[{"line_number":595,"context_line":"            access_rules, add_rules\u003dadd_rules, delete_rules\u003ddelete_rules))"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"    @mock.patch.object(timeutils, \u0027utcnow\u0027, mock.Mock("},{"line_number":598,"context_line":"                       return_value\u003ddatetime.datetime("},{"line_number":599,"context_line":"                           2017, 7, 18, 16, 59, 33, 33124)))"},{"line_number":600,"context_line":"    def test_update_share_usage_size(self):"},{"line_number":601,"context_line":"        mount_path \u003d self._get_mount_path(self.share)"},{"line_number":602,"context_line":"        self._os.path.exists.return_value \u003d True"}],"source_content_type":"text/x-python","patch_set":23,"id":"1f1a1f67_e26f6f25","line":599,"range":{"start_line":598,"start_character":36,"end_line":599,"end_character":57},"in_reply_to":"1f1a1f67_ab472277","updated":"2017-07-19 16:24:39.000000000","message":"Done","commit_id":"9be94aa52692bf7f9a2980e4aab7aba080ffd26b"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"a6b180f2356106078b9cc2f9ab951d012a300f80","unresolved":false,"context_lines":[{"line_number":594,"context_line":"            access_rules, add_rules\u003dadd_rules, delete_rules\u003ddelete_rules))"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"    @mock.patch.object(timeutils, \u0027utcnow\u0027, mock.Mock("},{"line_number":597,"context_line":"                       return_value\u003d\u0027fake_date\u0027))"},{"line_number":598,"context_line":"    def test_update_share_usage_size(self):"},{"line_number":599,"context_line":"        mount_path \u003d self._get_mount_path(self.share)"},{"line_number":600,"context_line":"        self._os.path.exists.return_value \u003d True"}],"source_content_type":"text/x-python","patch_set":24,"id":"1f1a1f67_a762a4ac","line":597,"range":{"start_line":597,"start_character":36,"end_line":597,"end_character":47},"updated":"2017-07-19 17:43:29.000000000","message":"I meant set:\n   fake_date \u003d datetime.datetime(2017, 7, 18, 16, 59, 33, 33124)\n   and then do\n      return_value\u003dfake_date\nBut I guess this is OK :D","commit_id":"488a2976f9914e2a0b299aa52642f07078afe27e"}],"releasenotes/notes/add-gathering-usage-size-8454sd45deopb14e.yaml":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"a5d23988db8c31661c49a083647cb237993af43c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added perodic task to gathering share usage size."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f1d235d_891d0dbf","line":3,"range":{"start_line":3,"start_character":26,"end_line":3,"end_character":35},"updated":"2017-07-03 12:23:44.000000000","message":"gather","commit_id":"f38bd9d9588d9ad58f2e1a0368abf37376893fb5"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"bc6cfde910455a130ee17891c326cd6cc264d74a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added perodic task to gather share usage size."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f1d235d_3ebde901","line":3,"range":{"start_line":3,"start_character":10,"end_line":3,"end_character":17},"updated":"2017-07-04 12:44:03.000000000","message":"periodic","commit_id":"af445cc94ab198057f8b939238b85583d0759b7b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fac7fb022e41d817dae9499fa952d249cac1d5cd","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added periodic task to gather share usage size."}],"source_content_type":"text/x-yaml","patch_set":21,"id":"1f1a1f67_a3d2b8cf","line":3,"range":{"start_line":2,"start_character":0,"end_line":3,"end_character":51},"updated":"2017-07-19 00:09:38.000000000","message":"you also added two new configuration options. What are these options and what can they do, please create an \"upgrade\" section and call these options out.","commit_id":"ddbd4c13f145f5690068d62e9aec94effbdb40b6"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"aa0d1fa89d5f91268178f01dbd1227790191e12e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added periodic task to gather share usage size."}],"source_content_type":"text/x-yaml","patch_set":21,"id":"1f1a1f67_37e5be38","line":3,"range":{"start_line":2,"start_character":0,"end_line":3,"end_character":51},"in_reply_to":"1f1a1f67_a3d2b8cf","updated":"2017-07-19 03:15:56.000000000","message":"Done","commit_id":"ddbd4c13f145f5690068d62e9aec94effbdb40b6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"17c716bce46f52c441e624747034263e51b81952","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added periodic task to gather share usage size."},{"line_number":4,"context_line":"upgrades:"},{"line_number":5,"context_line":"  - Added enable_gathering_share_usage_size and"},{"line_number":6,"context_line":"    share_usage_size_update_interval options in the"},{"line_number":7,"context_line":"    manila.conf file to allow configuration of gathering"}],"source_content_type":"text/x-yaml","patch_set":37,"id":"ff346bd7_b2db71eb","line":4,"range":{"start_line":4,"start_character":0,"end_line":4,"end_character":8},"updated":"2017-07-26 03:55:40.000000000","message":"upgrade","commit_id":"cd67fa96a4df598f6df77fec653cd62c7d4dbfdd"}]}
