)]}'
{"doc/source/devref/share_back_ends_feature_support_mapping.rst":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"62bdbc345bc9d6170866405f29287b8389d0daad","unresolved":false,"context_lines":[{"line_number":85,"context_line":"+----------------------------------------+-----------------------+-----------------------+--------------+--------------+------------------------+----------------------------+--------------------------+--------------------+--------------------+"},{"line_number":86,"context_line":"|                  QNAP                  |           O           |           O           |       O      |      \\-      |            O           |              O             |             O            |          \\-        |          \\-        |"},{"line_number":87,"context_line":"+----------------------------------------+-----------------------+-----------------------+--------------+--------------+------------------------+----------------------------+--------------------------+--------------------+--------------------+"},{"line_number":88,"context_line":"|               Infortrend               |           P           |           P           |       P      |      \\-      |            \\-          |             \\-             |            \\-            |          \\-        |          \\-        |"},{"line_number":89,"context_line":"+----------------------------------------+-----------------------+-----------------------+--------------+--------------+------------------------+----------------------------+--------------------------+--------------------+--------------------+"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Mapping of share drivers and share access rules support"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ff0f0b1f_d9567307","line":88,"range":{"start_line":88,"start_character":111,"end_line":88,"end_character":114},"updated":"2017-05-18 07:38:26.000000000","message":"Your driver support shrink share. You can change \\- to P.","commit_id":"ace5f05d9fa783fdb4e44a10d759994fc94a58e3"},{"author":{"_account_id":19191,"name":"JohnnyChou","email":"johnny800503.work@gmail.com","username":"JohnnyChou"},"change_message_id":"8097a199b75038f410d8930165a8807c876c2b8f","unresolved":false,"context_lines":[{"line_number":85,"context_line":"+----------------------------------------+-----------------------+-----------------------+--------------+--------------+------------------------+----------------------------+--------------------------+--------------------+--------------------+"},{"line_number":86,"context_line":"|                  QNAP                  |           O           |           O           |       O      |      \\-      |            O           |              O             |             O            |          \\-        |          \\-        |"},{"line_number":87,"context_line":"+----------------------------------------+-----------------------+-----------------------+--------------+--------------+------------------------+----------------------------+--------------------------+--------------------+--------------------+"},{"line_number":88,"context_line":"|               Infortrend               |           P           |           P           |       P      |      \\-      |            \\-          |             \\-             |            \\-            |          \\-        |          \\-        |"},{"line_number":89,"context_line":"+----------------------------------------+-----------------------+-----------------------+--------------+--------------+------------------------+----------------------------+--------------------------+--------------------+--------------------+"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"Mapping of share drivers and share access rules support"}],"source_content_type":"text/x-rst","patch_set":1,"id":"ff0f0b1f_bf74bf9a","line":88,"range":{"start_line":88,"start_character":111,"end_line":88,"end_character":114},"in_reply_to":"ff0f0b1f_d9567307","updated":"2017-05-18 08:34:06.000000000","message":"Done","commit_id":"ace5f05d9fa783fdb4e44a10d759994fc94a58e3"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9ddfa9dcd3da53b04f72fb7f07f560fa97c64dbe","unresolved":false,"context_lines":[{"line_number":272,"context_line":"+----------------------------------------+-----------+------------+--------+-------------+-------------------+--------------------+-----+----------------------------+--------------------+--------------------+"},{"line_number":273,"context_line":"|                  QNAP                  |     \\-    |      O     |   \\-   |      \\-     |         O         |          \\-        | \\-  |              O             |          \\-        |          \\-        |"},{"line_number":274,"context_line":"+----------------------------------------+-----------+------------+--------+-------------+-------------------+--------------------+-----+----------------------------+--------------------+--------------------+"},{"line_number":275,"context_line":"|               Infortrend               |     \\-    |      P     |   \\-   |      \\-     |        \\-         |          \\-        | \\-  |             \\-             |          \\-        |          \\-        |"},{"line_number":276,"context_line":"+----------------------------------------+-----------+------------+--------+-------------+-------------------+--------------------+-----+----------------------------+--------------------+--------------------+"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ff0f0b1f_080a0c20","line":275,"range":{"start_line":275,"start_character":117,"end_line":275,"end_character":124},"updated":"2017-05-20 09:18:30.000000000","message":"s/ \\- / P","commit_id":"b0c043613f2cba6779c70de95fc5e665252b514d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3687bd10f4895277ab448a69023442d9916e31fc","unresolved":false,"context_lines":[{"line_number":272,"context_line":"+----------------------------------------+-----------+------------+--------+-------------+-------------------+--------------------+-----+----------------------------+--------------------+--------------------+"},{"line_number":273,"context_line":"|                  QNAP                  |     \\-    |      O     |   \\-   |      \\-     |         O         |          \\-        | \\-  |              O             |          \\-        |          \\-        |"},{"line_number":274,"context_line":"+----------------------------------------+-----------+------------+--------+-------------+-------------------+--------------------+-----+----------------------------+--------------------+--------------------+"},{"line_number":275,"context_line":"|               Infortrend               |     \\-    |      P     |   \\-   |      \\-     |        \\-         |          \\-        | \\-  |             \\-             |          \\-        |          \\-        |"},{"line_number":276,"context_line":"+----------------------------------------+-----------+------------+--------+-------------+-------------------+--------------------+-----+----------------------------+--------------------+--------------------+"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ff0f0b1f_21acd49e","line":275,"range":{"start_line":275,"start_character":98,"end_line":275,"end_character":124},"updated":"2017-12-05 01:07:29.000000000","message":"which one is it?","commit_id":"b0c043613f2cba6779c70de95fc5e665252b514d"},{"author":{"_account_id":19191,"name":"JohnnyChou","email":"johnny800503.work@gmail.com","username":"JohnnyChou"},"change_message_id":"b654288bba7ea6af3558f8f56af912d4df05840a","unresolved":false,"context_lines":[{"line_number":272,"context_line":"+----------------------------------------+-----------+------------+--------+-------------+-------------------+--------------------+-----+----------------------------+--------------------+--------------------+"},{"line_number":273,"context_line":"|                  QNAP                  |     \\-    |      O     |   \\-   |      \\-     |         O         |          \\-        | \\-  |              O             |          \\-        |          \\-        |"},{"line_number":274,"context_line":"+----------------------------------------+-----------+------------+--------+-------------+-------------------+--------------------+-----+----------------------------+--------------------+--------------------+"},{"line_number":275,"context_line":"|               Infortrend               |     \\-    |      P     |   \\-   |      \\-     |        \\-         |          \\-        | \\-  |             \\-             |          \\-        |          \\-        |"},{"line_number":276,"context_line":"+----------------------------------------+-----------+------------+--------+-------------+-------------------+--------------------+-----+----------------------------+--------------------+--------------------+"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":".. note::"}],"source_content_type":"text/x-rst","patch_set":7,"id":"ff0f0b1f_18cfcc29","line":275,"range":{"start_line":275,"start_character":117,"end_line":275,"end_character":124},"in_reply_to":"ff0f0b1f_080a0c20","updated":"2017-05-23 03:53:17.000000000","message":"Done","commit_id":"b0c043613f2cba6779c70de95fc5e665252b514d"}],"manila/share/drivers/infortrend/driver.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"62bdbc345bc9d6170866405f29287b8389d0daad","unresolved":false,"context_lines":[{"line_number":197,"context_line":"    def create_share(self, context, share, share_server\u003dNone):"},{"line_number":198,"context_line":"        \"\"\"Is called to create share.\"\"\""},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        LOG.debug(\u0027Creating share: %s.\u0027 % dict(share))"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        return self.ift_nas.create_share(share, share_server)"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_960d6840","line":200,"range":{"start_line":200,"start_character":42,"end_line":200,"end_character":53},"updated":"2017-05-18 07:38:26.000000000","message":"This include many information,it will be so long when you debug this info. Why don\u0027t you just debug the share id.","commit_id":"ace5f05d9fa783fdb4e44a10d759994fc94a58e3"},{"author":{"_account_id":19191,"name":"JohnnyChou","email":"johnny800503.work@gmail.com","username":"JohnnyChou"},"change_message_id":"8097a199b75038f410d8930165a8807c876c2b8f","unresolved":false,"context_lines":[{"line_number":197,"context_line":"    def create_share(self, context, share, share_server\u003dNone):"},{"line_number":198,"context_line":"        \"\"\"Is called to create share.\"\"\""},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        LOG.debug(\u0027Creating share: %s.\u0027 % dict(share))"},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"        return self.ift_nas.create_share(share, share_server)"},{"line_number":203,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_1f284b84","line":200,"range":{"start_line":200,"start_character":42,"end_line":200,"end_character":53},"in_reply_to":"ff0f0b1f_960d6840","updated":"2017-05-18 08:34:06.000000000","message":"Done","commit_id":"ace5f05d9fa783fdb4e44a10d759994fc94a58e3"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"62bdbc345bc9d6170866405f29287b8389d0daad","unresolved":false,"context_lines":[{"line_number":204,"context_line":"    def delete_share(self, context, share, share_server\u003dNone):"},{"line_number":205,"context_line":"        \"\"\"Is called to remove share.\"\"\""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        LOG.debug(\u0027Deleting share: %s.\u0027 % dict(share))"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        return self.ift_nas.delete_share(share, share_server)"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_19ff4b02","line":207,"range":{"start_line":207,"start_character":42,"end_line":207,"end_character":53},"updated":"2017-05-18 07:38:26.000000000","message":"Above","commit_id":"ace5f05d9fa783fdb4e44a10d759994fc94a58e3"},{"author":{"_account_id":19191,"name":"JohnnyChou","email":"johnny800503.work@gmail.com","username":"JohnnyChou"},"change_message_id":"8097a199b75038f410d8930165a8807c876c2b8f","unresolved":false,"context_lines":[{"line_number":204,"context_line":"    def delete_share(self, context, share, share_server\u003dNone):"},{"line_number":205,"context_line":"        \"\"\"Is called to remove share.\"\"\""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"        LOG.debug(\u0027Deleting share: %s.\u0027 % dict(share))"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        return self.ift_nas.delete_share(share, share_server)"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_3f19cf78","line":207,"range":{"start_line":207,"start_character":42,"end_line":207,"end_character":53},"in_reply_to":"ff0f0b1f_19ff4b02","updated":"2017-05-18 08:34:06.000000000","message":"Done","commit_id":"ace5f05d9fa783fdb4e44a10d759994fc94a58e3"},{"author":{"_account_id":19191,"name":"JohnnyChou","email":"johnny800503.work@gmail.com","username":"JohnnyChou"},"change_message_id":"ad77b9924d0cdbf89f762309c80eb12b2c358be5","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"infortrend_nas_opts \u003d ["},{"line_number":27,"context_line":"    cfg.StrOpt(\u0027infortrend_nas_ip\u0027,"},{"line_number":28,"context_line":"               default\u003dNone,"},{"line_number":29,"context_line":"               help\u003d\u0027Infortrend nas ip. \u0027"},{"line_number":30,"context_line":"               \u0027It is the ip for management.\u0027),"},{"line_number":31,"context_line":"    cfg.StrOpt(\u0027infortrend_nas_user\u0027,"},{"line_number":32,"context_line":"               default\u003d\u0027manila\u0027,"},{"line_number":33,"context_line":"               help\u003d\u0027Infortrend nas username.\u0027),"},{"line_number":34,"context_line":"    cfg.StrOpt(\u0027infortrend_nas_password\u0027,"},{"line_number":35,"context_line":"               default\u003dNone,"},{"line_number":36,"context_line":"               help\u003d\u0027Infortrend nas password. \u0027"},{"line_number":37,"context_line":"               \u0027This is not necessary \u0027"},{"line_number":38,"context_line":"               \u0027if infortrend_nas_ssh_key is set.\u0027),"},{"line_number":39,"context_line":"    cfg.StrOpt(\u0027infortrend_nas_ssh_key\u0027,"},{"line_number":40,"context_line":"               default\u003dNone,"},{"line_number":41,"context_line":"               help\u003d\u0027Infortrend nas ssh key. \u0027"},{"line_number":42,"context_line":"               \u0027This is not necessary \u0027"},{"line_number":43,"context_line":"               \u0027if infortrend_nas_password is set.\u0027),"},{"line_number":44,"context_line":"    cfg.StrOpt(\u0027infortrend_share_pools\u0027,"},{"line_number":45,"context_line":"               default\u003dNone,"},{"line_number":46,"context_line":"               help\u003d\u0027Infortrend nas pool name list. \u0027"},{"line_number":47,"context_line":"               \u0027It is separated with comma.\u0027),"},{"line_number":48,"context_line":"    cfg.StrOpt(\u0027infortrend_share_channels\u0027,"},{"line_number":49,"context_line":"               default\u003dNone,"},{"line_number":50,"context_line":"               help\u003d\u0027Infortrend channels for file service. \u0027"},{"line_number":51,"context_line":"               \u0027It is separated with comma.\u0027),"},{"line_number":52,"context_line":"    cfg.IntOpt(\u0027infortrend_cli_max_retries\u0027,"},{"line_number":53,"context_line":"               default\u003d5,"},{"line_number":54,"context_line":"               help\u003d\u0027Maximum retry times for cli.\u0027),"},{"line_number":55,"context_line":"    cfg.IntOpt(\u0027infortrend_cli_timeout\u0027,"},{"line_number":56,"context_line":"               default\u003d30,"},{"line_number":57,"context_line":"               help\u003d\u0027CLI timeout in seconds.\u0027),"},{"line_number":58,"context_line":"]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"CONF \u003d cfg.CONF"},{"line_number":61,"context_line":"CONF.register_opts(infortrend_nas_opts)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_903b2837","line":58,"range":{"start_line":26,"start_character":0,"end_line":58,"end_character":1},"updated":"2017-05-18 09:59:39.000000000","message":"Hi YuYang,\ndo you mean this section?","commit_id":"64661acdd9b74bb9b4cfa00fe212bfe0af32582b"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9ddfa9dcd3da53b04f72fb7f07f560fa97c64dbe","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    cfg.StrOpt(\u0027infortrend_nas_password\u0027,"},{"line_number":35,"context_line":"               default\u003dNone,"},{"line_number":36,"context_line":"               help\u003d\u0027Infortrend nas password. \u0027"},{"line_number":37,"context_line":"               \u0027This is not necessary \u0027"},{"line_number":38,"context_line":"               \u0027if infortrend_nas_ssh_key is set.\u0027),"},{"line_number":39,"context_line":"    cfg.StrOpt(\u0027infortrend_nas_ssh_key\u0027,"},{"line_number":40,"context_line":"               default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_68186874","line":37,"range":{"start_line":37,"start_character":15,"end_line":37,"end_character":16},"updated":"2017-05-20 09:18:30.000000000","message":"Please describe infortrend_nas_password itself.","commit_id":"b0c043613f2cba6779c70de95fc5e665252b514d"},{"author":{"_account_id":19191,"name":"JohnnyChou","email":"johnny800503.work@gmail.com","username":"JohnnyChou"},"change_message_id":"b654288bba7ea6af3558f8f56af912d4df05840a","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    cfg.StrOpt(\u0027infortrend_nas_password\u0027,"},{"line_number":35,"context_line":"               default\u003dNone,"},{"line_number":36,"context_line":"               help\u003d\u0027Infortrend nas password. \u0027"},{"line_number":37,"context_line":"               \u0027This is not necessary \u0027"},{"line_number":38,"context_line":"               \u0027if infortrend_nas_ssh_key is set.\u0027),"},{"line_number":39,"context_line":"    cfg.StrOpt(\u0027infortrend_nas_ssh_key\u0027,"},{"line_number":40,"context_line":"               default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_333871ed","line":37,"range":{"start_line":37,"start_character":15,"end_line":37,"end_character":16},"in_reply_to":"ff0f0b1f_68186874","updated":"2017-05-23 03:53:17.000000000","message":"Done","commit_id":"b0c043613f2cba6779c70de95fc5e665252b514d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9ddfa9dcd3da53b04f72fb7f07f560fa97c64dbe","unresolved":false,"context_lines":[{"line_number":38,"context_line":"               \u0027if infortrend_nas_ssh_key is set.\u0027),"},{"line_number":39,"context_line":"    cfg.StrOpt(\u0027infortrend_nas_ssh_key\u0027,"},{"line_number":40,"context_line":"               default\u003dNone,"},{"line_number":41,"context_line":"               help\u003d\u0027Infortrend nas ssh key. \u0027"},{"line_number":42,"context_line":"               \u0027This is not necessary \u0027"},{"line_number":43,"context_line":"               \u0027if infortrend_nas_password is set.\u0027),"},{"line_number":44,"context_line":"    cfg.StrOpt(\u0027infortrend_share_pools\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_282cb097","line":41,"range":{"start_line":41,"start_character":14,"end_line":41,"end_character":20},"updated":"2017-05-20 09:18:30.000000000","message":"above","commit_id":"b0c043613f2cba6779c70de95fc5e665252b514d"},{"author":{"_account_id":19191,"name":"JohnnyChou","email":"johnny800503.work@gmail.com","username":"JohnnyChou"},"change_message_id":"b654288bba7ea6af3558f8f56af912d4df05840a","unresolved":false,"context_lines":[{"line_number":38,"context_line":"               \u0027if infortrend_nas_ssh_key is set.\u0027),"},{"line_number":39,"context_line":"    cfg.StrOpt(\u0027infortrend_nas_ssh_key\u0027,"},{"line_number":40,"context_line":"               default\u003dNone,"},{"line_number":41,"context_line":"               help\u003d\u0027Infortrend nas ssh key. \u0027"},{"line_number":42,"context_line":"               \u0027This is not necessary \u0027"},{"line_number":43,"context_line":"               \u0027if infortrend_nas_password is set.\u0027),"},{"line_number":44,"context_line":"    cfg.StrOpt(\u0027infortrend_share_pools\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_f33d59dd","line":41,"range":{"start_line":41,"start_character":14,"end_line":41,"end_character":20},"in_reply_to":"ff0f0b1f_282cb097","updated":"2017-05-23 03:53:17.000000000","message":"Done","commit_id":"b0c043613f2cba6779c70de95fc5e665252b514d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9ddfa9dcd3da53b04f72fb7f07f560fa97c64dbe","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            \u0027access_rules: %(access_rules)s, \u0027"},{"line_number":176,"context_line":"            \u0027add_rules: %(add_rules)s, \u0027"},{"line_number":177,"context_line":"            \u0027delete_rules: %(delete_rules)s\u0027, {"},{"line_number":178,"context_line":"                \u0027share\u0027: dict(share),"},{"line_number":179,"context_line":"                \u0027access_rules\u0027: self._list_of_dict(access_rules),"},{"line_number":180,"context_line":"                \u0027add_rules\u0027: self._list_of_dict(add_rules),"},{"line_number":181,"context_line":"                \u0027delete_rules\u0027: self._list_of_dict(delete_rules),"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_2864b0b8","line":178,"range":{"start_line":178,"start_character":25,"end_line":178,"end_character":36},"updated":"2017-05-20 09:18:30.000000000","message":"This include many information,it will be so long when you debug this info. Why don\u0027t you just debug the share id.","commit_id":"b0c043613f2cba6779c70de95fc5e665252b514d"},{"author":{"_account_id":19191,"name":"JohnnyChou","email":"johnny800503.work@gmail.com","username":"JohnnyChou"},"change_message_id":"b654288bba7ea6af3558f8f56af912d4df05840a","unresolved":false,"context_lines":[{"line_number":175,"context_line":"            \u0027access_rules: %(access_rules)s, \u0027"},{"line_number":176,"context_line":"            \u0027add_rules: %(add_rules)s, \u0027"},{"line_number":177,"context_line":"            \u0027delete_rules: %(delete_rules)s\u0027, {"},{"line_number":178,"context_line":"                \u0027share\u0027: dict(share),"},{"line_number":179,"context_line":"                \u0027access_rules\u0027: self._list_of_dict(access_rules),"},{"line_number":180,"context_line":"                \u0027add_rules\u0027: self._list_of_dict(add_rules),"},{"line_number":181,"context_line":"                \u0027delete_rules\u0027: self._list_of_dict(delete_rules),"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_d326d5ce","line":178,"range":{"start_line":178,"start_character":25,"end_line":178,"end_character":36},"in_reply_to":"ff0f0b1f_2864b0b8","updated":"2017-05-23 03:53:17.000000000","message":"Done","commit_id":"b0c043613f2cba6779c70de95fc5e665252b514d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9ddfa9dcd3da53b04f72fb7f07f560fa97c64dbe","unresolved":false,"context_lines":[{"line_number":273,"context_line":"        \"\"\""},{"line_number":274,"context_line":"        LOG.debug("},{"line_number":275,"context_line":"            \u0027Unmanage share: %(share)s\u0027, {"},{"line_number":276,"context_line":"                \u0027share\u0027: dict(share),"},{"line_number":277,"context_line":"            })"},{"line_number":278,"context_line":"        return self.ift_nas.unmanage(share)"},{"line_number":279,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_c874146b","line":276,"range":{"start_line":276,"start_character":25,"end_line":276,"end_character":36},"updated":"2017-05-20 09:18:30.000000000","message":"above","commit_id":"b0c043613f2cba6779c70de95fc5e665252b514d"},{"author":{"_account_id":19191,"name":"JohnnyChou","email":"johnny800503.work@gmail.com","username":"JohnnyChou"},"change_message_id":"b654288bba7ea6af3558f8f56af912d4df05840a","unresolved":false,"context_lines":[{"line_number":273,"context_line":"        \"\"\""},{"line_number":274,"context_line":"        LOG.debug("},{"line_number":275,"context_line":"            \u0027Unmanage share: %(share)s\u0027, {"},{"line_number":276,"context_line":"                \u0027share\u0027: dict(share),"},{"line_number":277,"context_line":"            })"},{"line_number":278,"context_line":"        return self.ift_nas.unmanage(share)"},{"line_number":279,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_932cddac","line":276,"range":{"start_line":276,"start_character":25,"end_line":276,"end_character":36},"in_reply_to":"ff0f0b1f_c874146b","updated":"2017-05-23 03:53:17.000000000","message":"Done","commit_id":"b0c043613f2cba6779c70de95fc5e665252b514d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4164ce9afaf76967a72541a0f8607814a5fcf442","unresolved":false,"context_lines":[{"line_number":24,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"infortrend_nas_opts \u003d ["},{"line_number":27,"context_line":"    cfg.StrOpt(\u0027infortrend_nas_ip\u0027,"},{"line_number":28,"context_line":"               default\u003dNone,"},{"line_number":29,"context_line":"               help\u003d\u0027Infortrend nas ip. \u0027"},{"line_number":30,"context_line":"               \u0027It is the ip for management.\u0027),"}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_1ec28834","line":27,"range":{"start_line":27,"start_character":16,"end_line":27,"end_character":33},"updated":"2017-05-30 09:29:23.000000000","message":"It is correct to say that driver will use always the same interface for management of storage and exporting shares?","commit_id":"ecf44139ad4eaf7c061935ae2bc5266752719380"},{"author":{"_account_id":19191,"name":"JohnnyChou","email":"johnny800503.work@gmail.com","username":"JohnnyChou"},"change_message_id":"f93d890c11d0f5ea67d77b4cdcb724cf16ca9832","unresolved":false,"context_lines":[{"line_number":24,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"infortrend_nas_opts \u003d ["},{"line_number":27,"context_line":"    cfg.StrOpt(\u0027infortrend_nas_ip\u0027,"},{"line_number":28,"context_line":"               default\u003dNone,"},{"line_number":29,"context_line":"               help\u003d\u0027Infortrend nas ip. \u0027"},{"line_number":30,"context_line":"               \u0027It is the ip for management.\u0027),"}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_729cdabf","line":27,"range":{"start_line":27,"start_character":16,"end_line":27,"end_character":33},"in_reply_to":"df140735_1ec28834","updated":"2017-06-01 02:13:53.000000000","message":"It\u0027ll use the same interface for management, but exporting shares by other ports. (Line:277)","commit_id":"ecf44139ad4eaf7c061935ae2bc5266752719380"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4164ce9afaf76967a72541a0f8607814a5fcf442","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    def _update_share_stats(self):"},{"line_number":135,"context_line":"        \"\"\"Retrieve stats info from share group.\"\"\""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        LOG.debug(\u0027Updating Infortrend share stats.\u0027)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        data \u003d dict(share_backend_name\u003dself.backend_name,"},{"line_number":140,"context_line":"                    vendor_name\u003d\u0027Infortrend\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_9e1218b1","line":137,"range":{"start_line":137,"start_character":8,"end_line":137,"end_character":53},"updated":"2017-05-30 09:29:23.000000000","message":"Better to provide here name of \"backend\" in case you have more than one process.","commit_id":"ecf44139ad4eaf7c061935ae2bc5266752719380"},{"author":{"_account_id":19191,"name":"JohnnyChou","email":"johnny800503.work@gmail.com","username":"JohnnyChou"},"change_message_id":"f93d890c11d0f5ea67d77b4cdcb724cf16ca9832","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    def _update_share_stats(self):"},{"line_number":135,"context_line":"        \"\"\"Retrieve stats info from share group.\"\"\""},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        LOG.debug(\u0027Updating Infortrend share stats.\u0027)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        data \u003d dict(share_backend_name\u003dself.backend_name,"},{"line_number":140,"context_line":"                    vendor_name\u003d\u0027Infortrend\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_529f96b3","line":137,"range":{"start_line":137,"start_character":8,"end_line":137,"end_character":53},"in_reply_to":"df140735_9e1218b1","updated":"2017-06-01 02:13:53.000000000","message":"Done","commit_id":"ecf44139ad4eaf7c061935ae2bc5266752719380"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"0299796dc981d3f6654c1cafb61acaa4b4543e86","unresolved":false,"context_lines":[{"line_number":222,"context_line":"        \"\"\""},{"line_number":223,"context_line":"        return self.ift_nas.ensure_share(share, share_server)"},{"line_number":224,"context_line":""},{"line_number":225,"context_line":"    def allow_access(self, context, share, access, share_server\u003dNone):"},{"line_number":226,"context_line":"        \"\"\"Allow access to the share.\"\"\""},{"line_number":227,"context_line":"        return self.ift_nas.allow_access(share, access, share_server)"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"    def deny_access(self, context, share, access, share_server\u003dNone):"},{"line_number":230,"context_line":"        \"\"\"Deny access to the share.\"\"\""},{"line_number":231,"context_line":"        return self.ift_nas.deny_access(share, access, share_server)"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"    def manage_existing(self, share, driver_options):"},{"line_number":234,"context_line":"        \"\"\"Brings an existing share under Manila management."}],"source_content_type":"text/x-python","patch_set":10,"id":"df87a7cf_05c6ad49","line":231,"range":{"start_line":225,"start_character":0,"end_line":231,"end_character":68},"updated":"2017-12-05 10:12:04.000000000","message":"These driver interfaces are deprecated, only update_access() is required/necessary.","commit_id":"8c617af1b020f44fb073a32e7d2ef6b2ea8191b3"}],"manila/share/drivers/infortrend/infortrend_nas.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"62bdbc345bc9d6170866405f29287b8389d0daad","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        self._ensure_protocol_on(share_path, share_proto, display_name)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        LOG.info(\u0027Create Share [%(share)s] completed.\u0027, {"},{"line_number":284,"context_line":"            \u0027share\u0027: share[\u0027display_name\u0027]})"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        return self._export_location(share, share_proto, pool_path)"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_79cc0789","line":284,"range":{"start_line":284,"start_character":21,"end_line":284,"end_character":42},"updated":"2017-05-18 07:38:26.000000000","message":"The display_name could be the same in different shares. You\u0027d better log share id. The share id is unique.","commit_id":"ace5f05d9fa783fdb4e44a10d759994fc94a58e3"},{"author":{"_account_id":19191,"name":"JohnnyChou","email":"johnny800503.work@gmail.com","username":"JohnnyChou"},"change_message_id":"8097a199b75038f410d8930165a8807c876c2b8f","unresolved":false,"context_lines":[{"line_number":281,"context_line":"        self._ensure_protocol_on(share_path, share_proto, display_name)"},{"line_number":282,"context_line":""},{"line_number":283,"context_line":"        LOG.info(\u0027Create Share [%(share)s] completed.\u0027, {"},{"line_number":284,"context_line":"            \u0027share\u0027: share[\u0027display_name\u0027]})"},{"line_number":285,"context_line":""},{"line_number":286,"context_line":"        return self._export_location(share, share_proto, pool_path)"},{"line_number":287,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_5fb80329","line":284,"range":{"start_line":284,"start_character":21,"end_line":284,"end_character":42},"in_reply_to":"ff0f0b1f_79cc0789","updated":"2017-05-18 08:34:06.000000000","message":"Done","commit_id":"ace5f05d9fa783fdb4e44a10d759994fc94a58e3"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"62bdbc345bc9d6170866405f29287b8389d0daad","unresolved":false,"context_lines":[{"line_number":351,"context_line":"        rc, subfolders \u003d self._execute(command_line)"},{"line_number":352,"context_line":"        for subfolder in subfolders:"},{"line_number":353,"context_line":"            if subfolder[\u0027name\u0027] \u003d\u003d share_name:"},{"line_number":354,"context_line":"                share_exist \u003d True"},{"line_number":355,"context_line":"        return share_exist"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"    def update_access(self, share, access_rules, add_rules,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_99a23b9a","line":354,"range":{"start_line":354,"start_character":16,"end_line":354,"end_character":34},"updated":"2017-05-18 07:38:26.000000000","message":"return True\n\nYou can stop cycle when you find share on array.","commit_id":"ace5f05d9fa783fdb4e44a10d759994fc94a58e3"},{"author":{"_account_id":19191,"name":"JohnnyChou","email":"johnny800503.work@gmail.com","username":"JohnnyChou"},"change_message_id":"8097a199b75038f410d8930165a8807c876c2b8f","unresolved":false,"context_lines":[{"line_number":351,"context_line":"        rc, subfolders \u003d self._execute(command_line)"},{"line_number":352,"context_line":"        for subfolder in subfolders:"},{"line_number":353,"context_line":"            if subfolder[\u0027name\u0027] \u003d\u003d share_name:"},{"line_number":354,"context_line":"                share_exist \u003d True"},{"line_number":355,"context_line":"        return share_exist"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"    def update_access(self, share, access_rules, add_rules,"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_7f1e270d","line":354,"range":{"start_line":354,"start_character":16,"end_line":354,"end_character":34},"in_reply_to":"ff0f0b1f_99a23b9a","updated":"2017-05-18 08:34:06.000000000","message":"Done","commit_id":"ace5f05d9fa783fdb4e44a10d759994fc94a58e3"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"62bdbc345bc9d6170866405f29287b8389d0daad","unresolved":false,"context_lines":[{"line_number":352,"context_line":"        for subfolder in subfolders:"},{"line_number":353,"context_line":"            if subfolder[\u0027name\u0027] \u003d\u003d share_name:"},{"line_number":354,"context_line":"                share_exist \u003d True"},{"line_number":355,"context_line":"        return share_exist"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"    def update_access(self, share, access_rules, add_rules,"},{"line_number":358,"context_line":"                      delete_rules, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_59aca38b","line":355,"range":{"start_line":355,"start_character":7,"end_line":355,"end_character":26},"updated":"2017-05-18 07:38:26.000000000","message":"return False","commit_id":"ace5f05d9fa783fdb4e44a10d759994fc94a58e3"},{"author":{"_account_id":19191,"name":"JohnnyChou","email":"johnny800503.work@gmail.com","username":"JohnnyChou"},"change_message_id":"8097a199b75038f410d8930165a8807c876c2b8f","unresolved":false,"context_lines":[{"line_number":352,"context_line":"        for subfolder in subfolders:"},{"line_number":353,"context_line":"            if subfolder[\u0027name\u0027] \u003d\u003d share_name:"},{"line_number":354,"context_line":"                share_exist \u003d True"},{"line_number":355,"context_line":"        return share_exist"},{"line_number":356,"context_line":""},{"line_number":357,"context_line":"    def update_access(self, share, access_rules, add_rules,"},{"line_number":358,"context_line":"                      delete_rules, share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ff0f0b1f_ffd7d722","line":355,"range":{"start_line":355,"start_character":7,"end_line":355,"end_character":26},"in_reply_to":"ff0f0b1f_59aca38b","updated":"2017-05-18 08:34:06.000000000","message":"Done","commit_id":"ace5f05d9fa783fdb4e44a10d759994fc94a58e3"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"8a8f96e8917d0a818adc4306a40c2afe16a9d08f","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def retry_cli(func):"},{"line_number":33,"context_line":"    def inner(self, *args, **kwargs):"},{"line_number":34,"context_line":"        total_retry_time \u003d self.cli_retry_time"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        if total_retry_time is None:"},{"line_number":37,"context_line":"            total_retry_time \u003d DEFAULT_RETRY_TIME"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        retry_time \u003d 0"},{"line_number":40,"context_line":"        while retry_time \u003c total_retry_time:"},{"line_number":41,"context_line":"            rc, out \u003d func(self, *args, **kwargs)"},{"line_number":42,"context_line":"            retry_time +\u003d 1"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"            if rc \u003d\u003d 0:"},{"line_number":45,"context_line":"                break"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"            LOG.error("},{"line_number":48,"context_line":"                \u0027Retry %(retry)s times: %(command)s Failed \u0027"},{"line_number":49,"context_line":"                \u0027%(rc)s: %(reason)s\u0027, {"},{"line_number":50,"context_line":"                    \u0027retry\u0027: retry_time,"},{"line_number":51,"context_line":"                    \u0027command\u0027: args,"},{"line_number":52,"context_line":"                    \u0027rc\u0027: rc,"},{"line_number":53,"context_line":"                    \u0027reason\u0027: out})"},{"line_number":54,"context_line":"        LOG.debug("},{"line_number":55,"context_line":"            \u0027Command: %(command)s Return Code: %(rc)s \u0027"},{"line_number":56,"context_line":"            \u0027Output: %(out)s\u0027, {"},{"line_number":57,"context_line":"                \u0027command\u0027: args, \u0027rc\u0027: rc, \u0027out\u0027: out})"},{"line_number":58,"context_line":"        return rc, out"},{"line_number":59,"context_line":"    return inner"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_a51db074","line":58,"range":{"start_line":34,"start_character":8,"end_line":58,"end_character":22},"updated":"2017-05-19 02:59:21.000000000","message":"You could use @utils.retry instead of self retry code.\n\nhttps://github.com/openstack/manila/blob/master/manila/utils.py#L406","commit_id":"64661acdd9b74bb9b4cfa00fe212bfe0af32582b"},{"author":{"_account_id":19191,"name":"JohnnyChou","email":"johnny800503.work@gmail.com","username":"JohnnyChou"},"change_message_id":"566441a85c445c9fd7f877113adbab17dd08893d","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"def retry_cli(func):"},{"line_number":33,"context_line":"    def inner(self, *args, **kwargs):"},{"line_number":34,"context_line":"        total_retry_time \u003d self.cli_retry_time"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"        if total_retry_time is None:"},{"line_number":37,"context_line":"            total_retry_time \u003d DEFAULT_RETRY_TIME"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        retry_time \u003d 0"},{"line_number":40,"context_line":"        while retry_time \u003c total_retry_time:"},{"line_number":41,"context_line":"            rc, out \u003d func(self, *args, **kwargs)"},{"line_number":42,"context_line":"            retry_time +\u003d 1"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"            if rc \u003d\u003d 0:"},{"line_number":45,"context_line":"                break"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"            LOG.error("},{"line_number":48,"context_line":"                \u0027Retry %(retry)s times: %(command)s Failed \u0027"},{"line_number":49,"context_line":"                \u0027%(rc)s: %(reason)s\u0027, {"},{"line_number":50,"context_line":"                    \u0027retry\u0027: retry_time,"},{"line_number":51,"context_line":"                    \u0027command\u0027: args,"},{"line_number":52,"context_line":"                    \u0027rc\u0027: rc,"},{"line_number":53,"context_line":"                    \u0027reason\u0027: out})"},{"line_number":54,"context_line":"        LOG.debug("},{"line_number":55,"context_line":"            \u0027Command: %(command)s Return Code: %(rc)s \u0027"},{"line_number":56,"context_line":"            \u0027Output: %(out)s\u0027, {"},{"line_number":57,"context_line":"                \u0027command\u0027: args, \u0027rc\u0027: rc, \u0027out\u0027: out})"},{"line_number":58,"context_line":"        return rc, out"},{"line_number":59,"context_line":"    return inner"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_abec6129","line":58,"range":{"start_line":34,"start_character":8,"end_line":58,"end_character":22},"in_reply_to":"ff0f0b1f_a51db074","updated":"2017-05-19 03:56:48.000000000","message":"Done","commit_id":"64661acdd9b74bb9b4cfa00fe212bfe0af32582b"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"8a8f96e8917d0a818adc4306a40c2afe16a9d08f","unresolved":false,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def create_share(self, share, share_server\u003dNone):"},{"line_number":268,"context_line":"        pool_name \u003d share_utils.extract_host(share[\u0027host\u0027], level\u003d\u0027pool\u0027)"},{"line_number":269,"context_line":"        pool_id \u003d self.pool_dict[pool_name][\u0027id\u0027]"},{"line_number":270,"context_line":"        pool_path \u003d self.pool_dict[pool_name][\u0027path\u0027]"},{"line_number":271,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027].lower()"},{"line_number":272,"context_line":"        share_path \u003d pool_path + share[\u0027share_id\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_68f64ffc","line":269,"range":{"start_line":269,"start_character":32,"end_line":269,"end_character":43},"updated":"2017-05-19 02:59:21.000000000","message":"How about if pool_name don\u0027t exist in pool_dict. You will get KeyError: \u0027pool_name...\u0027. This is not exact warning. You could log it when pool name don\u0027t exist in pool_dict.","commit_id":"64661acdd9b74bb9b4cfa00fe212bfe0af32582b"},{"author":{"_account_id":19191,"name":"JohnnyChou","email":"johnny800503.work@gmail.com","username":"JohnnyChou"},"change_message_id":"566441a85c445c9fd7f877113adbab17dd08893d","unresolved":false,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def create_share(self, share, share_server\u003dNone):"},{"line_number":268,"context_line":"        pool_name \u003d share_utils.extract_host(share[\u0027host\u0027], level\u003d\u0027pool\u0027)"},{"line_number":269,"context_line":"        pool_id \u003d self.pool_dict[pool_name][\u0027id\u0027]"},{"line_number":270,"context_line":"        pool_path \u003d self.pool_dict[pool_name][\u0027path\u0027]"},{"line_number":271,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027].lower()"},{"line_number":272,"context_line":"        share_path \u003d pool_path + share[\u0027share_id\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_eb8c9980","line":269,"range":{"start_line":269,"start_character":32,"end_line":269,"end_character":43},"in_reply_to":"ff0f0b1f_68f64ffc","updated":"2017-05-19 03:56:48.000000000","message":"I see. I\u0027ll add the check.","commit_id":"64661acdd9b74bb9b4cfa00fe212bfe0af32582b"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"8a8f96e8917d0a818adc4306a40c2afe16a9d08f","unresolved":false,"context_lines":[{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    def delete_share(self, share, share_server\u003dNone):"},{"line_number":333,"context_line":"        pool_name \u003d share_utils.extract_host(share[\u0027host\u0027], level\u003d\u0027pool\u0027)"},{"line_number":334,"context_line":"        pool_id \u003d self.pool_dict[pool_name][\u0027id\u0027]"},{"line_number":335,"context_line":""},{"line_number":336,"context_line":"        if self._check_share_exist(pool_name, share[\u0027share_id\u0027]):"},{"line_number":337,"context_line":"            command_line \u003d [\u0027folder\u0027, \u0027options\u0027, pool_id,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_68b9afe7","line":334,"range":{"start_line":334,"start_character":32,"end_line":334,"end_character":43},"updated":"2017-05-19 02:59:21.000000000","message":"above","commit_id":"64661acdd9b74bb9b4cfa00fe212bfe0af32582b"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"8a8f96e8917d0a818adc4306a40c2afe16a9d08f","unresolved":false,"context_lines":[{"line_number":432,"context_line":"                 \u0027level [%(level)s] protocol [%(share_proto)s] completed.\u0027, {"},{"line_number":433,"context_line":"                     \u0027share\u0027: share[\u0027share_id\u0027],"},{"line_number":434,"context_line":"                     \u0027access_to\u0027: access_to,"},{"line_number":435,"context_line":"                     \u0027level\u0027: access_level,"},{"line_number":436,"context_line":"                     \u0027share_proto\u0027: share_proto})"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    def _ensure_protocol_on(self, share_path, share_proto, cifs_name):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_a892274a","line":435,"range":{"start_line":435,"start_character":30,"end_line":435,"end_character":42},"updated":"2017-05-19 02:59:21.000000000","message":"access[\u0027access_level\u0027]  In code line 419~422, access_level value has been changed.","commit_id":"64661acdd9b74bb9b4cfa00fe212bfe0af32582b"},{"author":{"_account_id":19191,"name":"JohnnyChou","email":"johnny800503.work@gmail.com","username":"JohnnyChou"},"change_message_id":"566441a85c445c9fd7f877113adbab17dd08893d","unresolved":false,"context_lines":[{"line_number":432,"context_line":"                 \u0027level [%(level)s] protocol [%(share_proto)s] completed.\u0027, {"},{"line_number":433,"context_line":"                     \u0027share\u0027: share[\u0027share_id\u0027],"},{"line_number":434,"context_line":"                     \u0027access_to\u0027: access_to,"},{"line_number":435,"context_line":"                     \u0027level\u0027: access_level,"},{"line_number":436,"context_line":"                     \u0027share_proto\u0027: share_proto})"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    def _ensure_protocol_on(self, share_path, share_proto, cifs_name):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_cb843561","line":435,"range":{"start_line":435,"start_character":30,"end_line":435,"end_character":42},"in_reply_to":"ff0f0b1f_a892274a","updated":"2017-05-19 03:56:48.000000000","message":"Done","commit_id":"64661acdd9b74bb9b4cfa00fe212bfe0af32582b"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"8a8f96e8917d0a818adc4306a40c2afe16a9d08f","unresolved":false,"context_lines":[{"line_number":634,"context_line":"        return ip, ift_share_name"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":"    def _check_channel_ip(self, channel_ip):"},{"line_number":637,"context_line":"        channel_ip_exist \u003d False"},{"line_number":638,"context_line":"        for ch, ip in self.channel_dict.items():"},{"line_number":639,"context_line":"            if ip \u003d\u003d channel_ip:"},{"line_number":640,"context_line":"                channel_ip_exist \u003d True"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_483f0b25","line":637,"range":{"start_line":637,"start_character":8,"end_line":637,"end_character":32},"updated":"2017-05-19 02:59:21.000000000","message":"remove","commit_id":"64661acdd9b74bb9b4cfa00fe212bfe0af32582b"},{"author":{"_account_id":19191,"name":"JohnnyChou","email":"johnny800503.work@gmail.com","username":"JohnnyChou"},"change_message_id":"566441a85c445c9fd7f877113adbab17dd08893d","unresolved":false,"context_lines":[{"line_number":634,"context_line":"        return ip, ift_share_name"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":"    def _check_channel_ip(self, channel_ip):"},{"line_number":637,"context_line":"        channel_ip_exist \u003d False"},{"line_number":638,"context_line":"        for ch, ip in self.channel_dict.items():"},{"line_number":639,"context_line":"            if ip \u003d\u003d channel_ip:"},{"line_number":640,"context_line":"                channel_ip_exist \u003d True"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_cb9b15c7","line":637,"range":{"start_line":637,"start_character":8,"end_line":637,"end_character":32},"in_reply_to":"ff0f0b1f_483f0b25","updated":"2017-05-19 03:56:48.000000000","message":"Done","commit_id":"64661acdd9b74bb9b4cfa00fe212bfe0af32582b"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"8a8f96e8917d0a818adc4306a40c2afe16a9d08f","unresolved":false,"context_lines":[{"line_number":637,"context_line":"        channel_ip_exist \u003d False"},{"line_number":638,"context_line":"        for ch, ip in self.channel_dict.items():"},{"line_number":639,"context_line":"            if ip \u003d\u003d channel_ip:"},{"line_number":640,"context_line":"                channel_ip_exist \u003d True"},{"line_number":641,"context_line":"                break"},{"line_number":642,"context_line":"        return channel_ip_exist"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":"    def unmanage(self, share):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_88352349","line":641,"range":{"start_line":640,"start_character":16,"end_line":641,"end_character":21},"updated":"2017-05-19 02:59:21.000000000","message":"return True","commit_id":"64661acdd9b74bb9b4cfa00fe212bfe0af32582b"},{"author":{"_account_id":19191,"name":"JohnnyChou","email":"johnny800503.work@gmail.com","username":"JohnnyChou"},"change_message_id":"566441a85c445c9fd7f877113adbab17dd08893d","unresolved":false,"context_lines":[{"line_number":637,"context_line":"        channel_ip_exist \u003d False"},{"line_number":638,"context_line":"        for ch, ip in self.channel_dict.items():"},{"line_number":639,"context_line":"            if ip \u003d\u003d channel_ip:"},{"line_number":640,"context_line":"                channel_ip_exist \u003d True"},{"line_number":641,"context_line":"                break"},{"line_number":642,"context_line":"        return channel_ip_exist"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":"    def unmanage(self, share):"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_ab9ea1b5","line":641,"range":{"start_line":640,"start_character":16,"end_line":641,"end_character":21},"in_reply_to":"ff0f0b1f_88352349","updated":"2017-05-19 03:56:48.000000000","message":"Done","commit_id":"64661acdd9b74bb9b4cfa00fe212bfe0af32582b"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"8a8f96e8917d0a818adc4306a40c2afe16a9d08f","unresolved":false,"context_lines":[{"line_number":639,"context_line":"            if ip \u003d\u003d channel_ip:"},{"line_number":640,"context_line":"                channel_ip_exist \u003d True"},{"line_number":641,"context_line":"                break"},{"line_number":642,"context_line":"        return channel_ip_exist"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":"    def unmanage(self, share):"},{"line_number":645,"context_line":"        pool_name \u003d share_utils.extract_host(share[\u0027host\u0027], level\u003d\u0027pool\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_68388f3c","line":642,"range":{"start_line":642,"start_character":8,"end_line":642,"end_character":31},"updated":"2017-05-19 02:59:21.000000000","message":"return False","commit_id":"64661acdd9b74bb9b4cfa00fe212bfe0af32582b"},{"author":{"_account_id":19191,"name":"JohnnyChou","email":"johnny800503.work@gmail.com","username":"JohnnyChou"},"change_message_id":"566441a85c445c9fd7f877113adbab17dd08893d","unresolved":false,"context_lines":[{"line_number":639,"context_line":"            if ip \u003d\u003d channel_ip:"},{"line_number":640,"context_line":"                channel_ip_exist \u003d True"},{"line_number":641,"context_line":"                break"},{"line_number":642,"context_line":"        return channel_ip_exist"},{"line_number":643,"context_line":""},{"line_number":644,"context_line":"    def unmanage(self, share):"},{"line_number":645,"context_line":"        pool_name \u003d share_utils.extract_host(share[\u0027host\u0027], level\u003d\u0027pool\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff0f0b1f_8ba51d07","line":642,"range":{"start_line":642,"start_character":8,"end_line":642,"end_character":31},"in_reply_to":"ff0f0b1f_68388f3c","updated":"2017-05-19 03:56:48.000000000","message":"Done","commit_id":"64661acdd9b74bb9b4cfa00fe212bfe0af32582b"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9ddfa9dcd3da53b04f72fb7f07f560fa97c64dbe","unresolved":false,"context_lines":[{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        return pool_quota_used"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    def _get_share_pool_id(self, pool_name):"},{"line_number":236,"context_line":"        if not pool_name:"},{"line_number":237,"context_line":"            msg \u003d _(\"Pool is not available in the share host.\")"},{"line_number":238,"context_line":"            raise exception.InvalidHost(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_089a0c62","line":235,"range":{"start_line":235,"start_character":8,"end_line":235,"end_character":26},"updated":"2017-05-20 09:18:30.000000000","message":"It could just get share pool","commit_id":"b0c043613f2cba6779c70de95fc5e665252b514d"},{"author":{"_account_id":19191,"name":"JohnnyChou","email":"johnny800503.work@gmail.com","username":"JohnnyChou"},"change_message_id":"b654288bba7ea6af3558f8f56af912d4df05840a","unresolved":false,"context_lines":[{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        return pool_quota_used"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"    def _get_share_pool_id(self, pool_name):"},{"line_number":236,"context_line":"        if not pool_name:"},{"line_number":237,"context_line":"            msg \u003d _(\"Pool is not available in the share host.\")"},{"line_number":238,"context_line":"            raise exception.InvalidHost(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_8e1a726c","line":235,"range":{"start_line":235,"start_character":8,"end_line":235,"end_character":26},"in_reply_to":"ff0f0b1f_089a0c62","updated":"2017-05-23 03:53:17.000000000","message":"Done","commit_id":"b0c043613f2cba6779c70de95fc5e665252b514d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9ddfa9dcd3da53b04f72fb7f07f560fa97c64dbe","unresolved":false,"context_lines":[{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    def allow_access(self, share, access, share_server\u003dNone):"},{"line_number":379,"context_line":"        pool_name \u003d share_utils.extract_host(share[\u0027host\u0027], level\u003d\u0027pool\u0027)"},{"line_number":380,"context_line":"        pool_path \u003d self.pool_dict[pool_name][\u0027path\u0027]"},{"line_number":381,"context_line":"        share_name \u003d share[\u0027share_id\u0027].replace(\u0027-\u0027, \u0027\u0027)"},{"line_number":382,"context_line":"        share_path \u003d pool_path + share_name"},{"line_number":383,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027].lower()"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_48900444","line":380,"range":{"start_line":380,"start_character":34,"end_line":380,"end_character":45},"updated":"2017-05-20 09:18:30.000000000","message":"It is still need to check the pool_name.","commit_id":"b0c043613f2cba6779c70de95fc5e665252b514d"},{"author":{"_account_id":19191,"name":"JohnnyChou","email":"johnny800503.work@gmail.com","username":"JohnnyChou"},"change_message_id":"b654288bba7ea6af3558f8f56af912d4df05840a","unresolved":false,"context_lines":[{"line_number":377,"context_line":""},{"line_number":378,"context_line":"    def allow_access(self, share, access, share_server\u003dNone):"},{"line_number":379,"context_line":"        pool_name \u003d share_utils.extract_host(share[\u0027host\u0027], level\u003d\u0027pool\u0027)"},{"line_number":380,"context_line":"        pool_path \u003d self.pool_dict[pool_name][\u0027path\u0027]"},{"line_number":381,"context_line":"        share_name \u003d share[\u0027share_id\u0027].replace(\u0027-\u0027, \u0027\u0027)"},{"line_number":382,"context_line":"        share_path \u003d pool_path + share_name"},{"line_number":383,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027].lower()"}],"source_content_type":"text/x-python","patch_set":7,"id":"ff0f0b1f_6e171e47","line":380,"range":{"start_line":380,"start_character":34,"end_line":380,"end_character":45},"in_reply_to":"ff0f0b1f_48900444","updated":"2017-05-23 03:53:17.000000000","message":"Done","commit_id":"b0c043613f2cba6779c70de95fc5e665252b514d"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4164ce9afaf76967a72541a0f8607814a5fcf442","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                    \u0027dedupe\u0027: False,"},{"line_number":213,"context_line":"                    \u0027compression\u0027: False,"},{"line_number":214,"context_line":"                    \u0027snapshot_support\u0027: False,"},{"line_number":215,"context_line":"                    \u0027thin_provisioning\u0027: False,"},{"line_number":216,"context_line":"                    \u0027replication_type\u0027: None,"},{"line_number":217,"context_line":"                }"},{"line_number":218,"context_line":"                pools.append(pool)"}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_1e45e8b3","line":215,"range":{"start_line":215,"start_character":20,"end_line":215,"end_character":47},"updated":"2017-05-30 09:29:23.000000000","message":"\"thick_provisioning\" is set as True in doc file, why it is not set here, in stats?","commit_id":"ecf44139ad4eaf7c061935ae2bc5266752719380"},{"author":{"_account_id":19191,"name":"JohnnyChou","email":"johnny800503.work@gmail.com","username":"JohnnyChou"},"change_message_id":"f93d890c11d0f5ea67d77b4cdcb724cf16ca9832","unresolved":false,"context_lines":[{"line_number":212,"context_line":"                    \u0027dedupe\u0027: False,"},{"line_number":213,"context_line":"                    \u0027compression\u0027: False,"},{"line_number":214,"context_line":"                    \u0027snapshot_support\u0027: False,"},{"line_number":215,"context_line":"                    \u0027thin_provisioning\u0027: False,"},{"line_number":216,"context_line":"                    \u0027replication_type\u0027: None,"},{"line_number":217,"context_line":"                }"},{"line_number":218,"context_line":"                pools.append(pool)"}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_b26ef292","line":215,"range":{"start_line":215,"start_character":20,"end_line":215,"end_character":47},"in_reply_to":"df140735_1e45e8b3","updated":"2017-06-01 02:13:53.000000000","message":"I should add \u0027thick_provisioning\u0027: True here?","commit_id":"ecf44139ad4eaf7c061935ae2bc5266752719380"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4164ce9afaf76967a72541a0f8607814a5fcf442","unresolved":false,"context_lines":[{"line_number":525,"context_line":"                     \u0027new_size\u0027: new_size})"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"    def shrink_share(self, share, new_size, share_server\u003dNone):"},{"line_number":528,"context_line":"        pool_name \u003d share_utils.extract_host(share[\u0027host\u0027], level\u003d\u0027pool\u0027)"},{"line_number":529,"context_line":"        pool_data \u003d self._get_share_pool_data(pool_name)"},{"line_number":530,"context_line":"        pool_id \u003d pool_data[\u0027id\u0027]"},{"line_number":531,"context_line":"        share_name \u003d share[\u0027share_id\u0027].replace(\u0027-\u0027, \u0027\u0027)"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"        command_line \u003d [\u0027fquota\u0027, \u0027status\u0027, pool_id,"},{"line_number":534,"context_line":"                        pool_name, \u0027-t\u0027, \u0027folder\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_9ea33850","line":531,"range":{"start_line":528,"start_character":8,"end_line":531,"end_character":55},"updated":"2017-05-30 09:29:23.000000000","message":"It is repeated lots of times in separate methods. Better to combine it to separate single private method.","commit_id":"ecf44139ad4eaf7c061935ae2bc5266752719380"},{"author":{"_account_id":19191,"name":"JohnnyChou","email":"johnny800503.work@gmail.com","username":"JohnnyChou"},"change_message_id":"f93d890c11d0f5ea67d77b4cdcb724cf16ca9832","unresolved":false,"context_lines":[{"line_number":525,"context_line":"                     \u0027new_size\u0027: new_size})"},{"line_number":526,"context_line":""},{"line_number":527,"context_line":"    def shrink_share(self, share, new_size, share_server\u003dNone):"},{"line_number":528,"context_line":"        pool_name \u003d share_utils.extract_host(share[\u0027host\u0027], level\u003d\u0027pool\u0027)"},{"line_number":529,"context_line":"        pool_data \u003d self._get_share_pool_data(pool_name)"},{"line_number":530,"context_line":"        pool_id \u003d pool_data[\u0027id\u0027]"},{"line_number":531,"context_line":"        share_name \u003d share[\u0027share_id\u0027].replace(\u0027-\u0027, \u0027\u0027)"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"        command_line \u003d [\u0027fquota\u0027, \u0027status\u0027, pool_id,"},{"line_number":534,"context_line":"                        pool_name, \u0027-t\u0027, \u0027folder\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_1287ded9","line":531,"range":{"start_line":528,"start_character":8,"end_line":531,"end_character":55},"in_reply_to":"df140735_9ea33850","updated":"2017-06-01 02:13:53.000000000","message":"Because not every function uses all these data, but I can reduce some lines.","commit_id":"ecf44139ad4eaf7c061935ae2bc5266752719380"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4164ce9afaf76967a72541a0f8607814a5fcf442","unresolved":false,"context_lines":[{"line_number":644,"context_line":"                \u0027share_name\u0027: share_name})"},{"line_number":645,"context_line":"            return"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"        LOG.info(\u0027Successfully Unmanage Share [%(share)s].\u0027, {"},{"line_number":648,"context_line":"            \u0027share\u0027: share[\u0027share_id\u0027]})"}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_3e766c08","line":647,"range":{"start_line":647,"start_character":31,"end_line":647,"end_character":39},"updated":"2017-05-30 09:29:23.000000000","message":"unmanaged?","commit_id":"ecf44139ad4eaf7c061935ae2bc5266752719380"},{"author":{"_account_id":19191,"name":"JohnnyChou","email":"johnny800503.work@gmail.com","username":"JohnnyChou"},"change_message_id":"f93d890c11d0f5ea67d77b4cdcb724cf16ca9832","unresolved":false,"context_lines":[{"line_number":644,"context_line":"                \u0027share_name\u0027: share_name})"},{"line_number":645,"context_line":"            return"},{"line_number":646,"context_line":""},{"line_number":647,"context_line":"        LOG.info(\u0027Successfully Unmanage Share [%(share)s].\u0027, {"},{"line_number":648,"context_line":"            \u0027share\u0027: share[\u0027share_id\u0027]})"}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_f26d8a32","line":647,"range":{"start_line":647,"start_character":31,"end_line":647,"end_character":39},"in_reply_to":"df140735_3e766c08","updated":"2017-06-01 02:13:53.000000000","message":"Done","commit_id":"ecf44139ad4eaf7c061935ae2bc5266752719380"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"0299796dc981d3f6654c1cafb61acaa4b4543e86","unresolved":false,"context_lines":[{"line_number":208,"context_line":"                    \u0027total_capacity_gb\u0027: total_capacity_gb,"},{"line_number":209,"context_line":"                    \u0027free_capacity_gb\u0027: free_capacity_gb,"},{"line_number":210,"context_line":"                    \u0027reserved_percentage\u0027: 0,"},{"line_number":211,"context_line":"                    \u0027qos\u0027: False,"},{"line_number":212,"context_line":"                    \u0027dedupe\u0027: False,"},{"line_number":213,"context_line":"                    \u0027compression\u0027: False,"},{"line_number":214,"context_line":"                    \u0027snapshot_support\u0027: False,"},{"line_number":215,"context_line":"                    \u0027thin_provisioning\u0027: False,"},{"line_number":216,"context_line":"                    \u0027thick_provisioning\u0027: True,"},{"line_number":217,"context_line":"                    \u0027replication_type\u0027: None,"}],"source_content_type":"text/x-python","patch_set":10,"id":"df87a7cf_456d9530","line":214,"range":{"start_line":211,"start_character":19,"end_line":214,"end_character":46},"updated":"2017-12-05 10:12:04.000000000","message":"Those capability default value is False, you could just remove them.","commit_id":"8c617af1b020f44fb073a32e7d2ef6b2ea8191b3"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"0299796dc981d3f6654c1cafb61acaa4b4543e86","unresolved":false,"context_lines":[{"line_number":213,"context_line":"                    \u0027compression\u0027: False,"},{"line_number":214,"context_line":"                    \u0027snapshot_support\u0027: False,"},{"line_number":215,"context_line":"                    \u0027thin_provisioning\u0027: False,"},{"line_number":216,"context_line":"                    \u0027thick_provisioning\u0027: True,"},{"line_number":217,"context_line":"                    \u0027replication_type\u0027: None,"},{"line_number":218,"context_line":"                }"},{"line_number":219,"context_line":"                pools.append(pool)"}],"source_content_type":"text/x-python","patch_set":10,"id":"df87a7cf_a51101af","line":216,"range":{"start_line":216,"start_character":20,"end_line":216,"end_character":47},"updated":"2017-12-05 10:12:04.000000000","message":"We don\u0027t have thick_provisioning capability, if \u0027thin_provisioning\u0027 is set to False, it means you only provide thick provisioning.","commit_id":"8c617af1b020f44fb073a32e7d2ef6b2ea8191b3"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"0299796dc981d3f6654c1cafb61acaa4b4543e86","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        pool_name \u003d share_utils.extract_host(share[\u0027host\u0027], level\u003d\u0027pool\u0027)"},{"line_number":251,"context_line":"        pool_data \u003d self._get_share_pool_data(pool_name)"},{"line_number":252,"context_line":"        share_proto \u003d share[\u0027share_proto\u0027].lower()"},{"line_number":253,"context_line":"        share_name \u003d share[\u0027share_id\u0027].replace(\u0027-\u0027, \u0027\u0027)"},{"line_number":254,"context_line":"        share_path \u003d pool_data[\u0027path\u0027] + share_name"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"        command_line \u003d [\u0027folder\u0027, \u0027options\u0027, pool_data[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":10,"id":"df87a7cf_f891f09a","line":253,"range":{"start_line":253,"start_character":21,"end_line":253,"end_character":38},"updated":"2017-12-05 10:12:04.000000000","message":"The share[\u0027share_id\u0027] is not the unique value, the share[\u0027id\u0027] is the unique value, if you use \"share_id\" as your share name, you could meet some problem when you run migration other functions. One share(\u0027share_id\u0027) can have multiple share instances(\u0027id\u0027).","commit_id":"8c617af1b020f44fb073a32e7d2ef6b2ea8191b3"}],"manila/tests/share/drivers/infortrend/test_infortrend_nas.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4164ce9afaf76967a72541a0f8607814a5fcf442","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from manila import test"},{"line_number":25,"context_line":"from manila.tests.share.drivers.infortrend import fake_infortrend_manila_data"},{"line_number":26,"context_line":"from manila.tests.share.drivers.infortrend import fake_infortrend_nas_data"},{"line_number":27,"context_line":"from oslo_config import cfg"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"CONF \u003d cfg.CONF"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_c1831104","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":27},"updated":"2017-05-30 09:29:23.000000000","message":"This module is from second group of imports. - third-party libs\n\nSee https://docs.openstack.org/developer/hacking/#imports\n\nSo, it should be located after \"mock\".","commit_id":"ecf44139ad4eaf7c061935ae2bc5266752719380"},{"author":{"_account_id":19191,"name":"JohnnyChou","email":"johnny800503.work@gmail.com","username":"JohnnyChou"},"change_message_id":"f93d890c11d0f5ea67d77b4cdcb724cf16ca9832","unresolved":false,"context_lines":[{"line_number":24,"context_line":"from manila import test"},{"line_number":25,"context_line":"from manila.tests.share.drivers.infortrend import fake_infortrend_manila_data"},{"line_number":26,"context_line":"from manila.tests.share.drivers.infortrend import fake_infortrend_nas_data"},{"line_number":27,"context_line":"from oslo_config import cfg"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"CONF \u003d cfg.CONF"},{"line_number":30,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_924beeae","line":27,"range":{"start_line":27,"start_character":0,"end_line":27,"end_character":27},"in_reply_to":"df140735_c1831104","updated":"2017-06-01 02:13:53.000000000","message":"Thanks for the info!","commit_id":"ecf44139ad4eaf7c061935ae2bc5266752719380"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4164ce9afaf76967a72541a0f8607814a5fcf442","unresolved":false,"context_lines":[{"line_number":28,"context_line":""},{"line_number":29,"context_line":"CONF \u003d cfg.CONF"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"SUCCEED \u003d (0, [])"},{"line_number":32,"context_line":"FAILED \u003d (-1, None)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_c1b551f0","line":31,"range":{"start_line":31,"start_character":0,"end_line":31,"end_character":7},"updated":"2017-05-30 09:29:23.000000000","message":"it is in present tense","commit_id":"ecf44139ad4eaf7c061935ae2bc5266752719380"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"4164ce9afaf76967a72541a0f8607814a5fcf442","unresolved":false,"context_lines":[{"line_number":29,"context_line":"CONF \u003d cfg.CONF"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"SUCCEED \u003d (0, [])"},{"line_number":32,"context_line":"FAILED \u003d (-1, None)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_61cc4589","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":6},"updated":"2017-05-30 09:29:23.000000000","message":"But this one is in past tense. Is it intended?","commit_id":"ecf44139ad4eaf7c061935ae2bc5266752719380"},{"author":{"_account_id":19191,"name":"JohnnyChou","email":"johnny800503.work@gmail.com","username":"JohnnyChou"},"change_message_id":"f93d890c11d0f5ea67d77b4cdcb724cf16ca9832","unresolved":false,"context_lines":[{"line_number":29,"context_line":"CONF \u003d cfg.CONF"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"SUCCEED \u003d (0, [])"},{"line_number":32,"context_line":"FAILED \u003d (-1, None)"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"@ddt.ddt"}],"source_content_type":"text/x-python","patch_set":8,"id":"df140735_f2046a4c","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":6},"in_reply_to":"df140735_61cc4589","updated":"2017-06-01 02:13:53.000000000","message":"I missed it.","commit_id":"ecf44139ad4eaf7c061935ae2bc5266752719380"}]}
