)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"31553329469c44f22b0ac58fa4ed1447826c55f5","unresolved":false,"context_lines":[{"line_number":11,"context_line":"We are using datetime.datetime.isoformat() instead[1]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"[1]http://docs.openstack.org/developer/oslo.utils/api/timeutils.html#oslo_utils.timeutils.isotime"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I2feb85b7f698ae456493d02a118bb3fb969835da"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"df140735_7fee2c89","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":0},"updated":"2017-05-29 16:58:53.000000000","message":"Please create a launchpad bug so we can track this\n\n  datetime.datetime.utcfromtimestamp(time.time()).isoformat() \n\ndoes not give you the same output as   \n\n  oslo_utils.timeutils.isotime(datetime.datetime.utcfromtimestamp(time.time()))\n\n\nWhile the latter gives you timezone information \"Z\", the former just gives you a timestamp.... So, for end users, this is regression, as far as this API is concerned. However, we have stated in the documentation that all timestamps within manila APIs may not provide timezone information (sadly). So, your fix will make this timestamp be no different in format than the rest of the timestamps manila emits.\n\nAlso, please add the APIImpact flag: https://docs.openstack.org/developer/manila/devref/commit_message_tags.html","commit_id":"1b05450367a609a89abe2550b4a08963a52b1c98"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"10822ea730ae56b106b6818cd4fd0f5fcec73f0a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Replace oslo_utils.timeutils.isotime"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Function \u0027oslo_utils.timeutils.isotime()\u0027 is deprecated in version \u00271.6\u0027"},{"line_number":10,"context_line":"and will be removed in a future version. We cant\u0027t use"},{"line_number":11,"context_line":"datetime.datetime.isoformat() instead. Because the format of the string"},{"line_number":12,"context_line":"generated by isoformat isn\u0027t the same as the format of the string"},{"line_number":13,"context_line":"generated by isotime. The string is used in tokens and other public"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df140735_774ac727","line":10,"range":{"start_line":10,"start_character":44,"end_line":10,"end_character":50},"updated":"2017-05-30 10:50:18.000000000","message":"can\u0027t","commit_id":"759bef483ce653cc9fa7b5e21590fd0e5cf61587"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"10822ea730ae56b106b6818cd4fd0f5fcec73f0a","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"For more informations:"},{"line_number":20,"context_line":"http://docs.openstack.org/developer/oslo.utils/api/timeutils.html#oslo_utils.timeutils.isotime"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Closes-Bug: #1694352"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I2feb85b7f698ae456493d02a118bb3fb969835da"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"df140735_5747c31e","line":21,"updated":"2017-05-30 10:50:18.000000000","message":"APIImpact","commit_id":"759bef483ce653cc9fa7b5e21590fd0e5cf61587"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"1a9049b75c563eb435516d8c24bc56c8f378c039","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"For more informations:"},{"line_number":20,"context_line":"http://docs.openstack.org/developer/oslo.utils/api/timeutils.html#oslo_utils.timeutils.isotime"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Closes-Bug: #1694352"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I2feb85b7f698ae456493d02a118bb3fb969835da"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"df140735_481cbe69","line":21,"updated":"2017-05-30 12:45:18.000000000","message":"Replace oslo_utils.timeutils.isotime\n\nFunction \u0027oslo_utils.timeutils.isotime()\u0027 is deprecated in version \u00271.6\u0027 and will be removed in a future version. We can\u0027t use datetime.datetime.isoformat() instead. Because the format of the string generated by isoformat isn\u0027t the same as the format of the string generated by isotime. The string is used in tokens and other public APIs and we can\u0027t change it without potentially breaking clients.\n\nSo the workaround is to copy the current implementation from\noslo_utils.timeutils.isotime() to utils.py\n\nFor more informations:\nhttp://docs.openstack.org/developer/oslo.utils/api/timeutils.html#oslo_utils.timeutils.isotime\n\nAPIImpact\n\nCloses-Bug: #1694352\nChange-Id: I2feb85b7f698ae456493d02a118bb3fb969835da","commit_id":"7d0e360b8babfca1f179a104a38dac8e34aac483"},{"author":{"_account_id":22255,"name":"Tuan","email":"tuanla@vn.fujitsu.com","username":"Tuan"},"change_message_id":"90e8be7f40ace0868b70315621eb8c60ecd5aa20","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"For more informations:"},{"line_number":20,"context_line":"http://docs.openstack.org/developer/oslo.utils/api/timeutils.html#oslo_utils.timeutils.isotime"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Closes-Bug: #1694352"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"Change-Id: I2feb85b7f698ae456493d02a118bb3fb969835da"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"df140735_88ae56e5","line":21,"in_reply_to":"df140735_481cbe69","updated":"2017-05-30 12:49:25.000000000","message":"Done, Thanks for your help","commit_id":"7d0e360b8babfca1f179a104a38dac8e34aac483"}],"manila/api/views/limits.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"37011b051343b592e2861f9aa780fcca20dad0c7","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            \"value\": rate_limit[\"value\"],"},{"line_number":98,"context_line":"            \"remaining\": int(rate_limit[\"remaining\"]),"},{"line_number":99,"context_line":"            \"unit\": rate_limit[\"unit\"],"},{"line_number":100,"context_line":"            \"next-available\": datetime.datetime.isoformat(at\u003dnext_avail),"},{"line_number":101,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_733e6d2a","line":100,"range":{"start_line":100,"start_character":30,"end_line":100,"end_character":72},"updated":"2017-05-29 13:55:17.000000000","message":"isformat() isn\u0027t liking (at\u003dnext_avail).  See:\n\nhttp://logs.openstack.org/24/468824/1/check/gate-manila-python27-ubuntu-xenial/d1a851b/console.html#_2017-05-29_09_39_39_618682\n\nI think you can just do datetime.datetime.isoformat(next_avail) since isoformat doesn\u0027t modifiy next_avail.","commit_id":"a99807a636795ada79bacafba2922dfab3601982"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8b51710fc0f456c4287ed51aecf4ae639299b14b","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            \"value\": rate_limit[\"value\"],"},{"line_number":98,"context_line":"            \"remaining\": int(rate_limit[\"remaining\"]),"},{"line_number":99,"context_line":"            \"unit\": rate_limit[\"unit\"],"},{"line_number":100,"context_line":"            \"next-available\": datetime.datetime.isoformat(next_avail),"},{"line_number":101,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_e461913b","line":100,"range":{"start_line":100,"start_character":30,"end_line":100,"end_character":69},"updated":"2017-05-29 16:18:52.000000000","message":"next_avail is a datetime object, so:\n\n next_avail.iso_format() \n\nshould be sufficient.","commit_id":"1b05450367a609a89abe2550b4a08963a52b1c98"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a4302bac974ceea4b41e40fa950e2fe1570e1287","unresolved":false,"context_lines":[{"line_number":97,"context_line":"            \"value\": rate_limit[\"value\"],"},{"line_number":98,"context_line":"            \"remaining\": int(rate_limit[\"remaining\"]),"},{"line_number":99,"context_line":"            \"unit\": rate_limit[\"unit\"],"},{"line_number":100,"context_line":"            \"next-available\": datetime.datetime.isoformat(next_avail),"},{"line_number":101,"context_line":"        }"}],"source_content_type":"text/x-python","patch_set":2,"id":"df140735_7fa98cdd","line":100,"range":{"start_line":100,"start_character":30,"end_line":100,"end_character":69},"in_reply_to":"df140735_e461913b","updated":"2017-05-29 16:52:27.000000000","message":"the \"resetTime\" attribute is python\u0027s time.time() which is timezone independent and is just a time from epoch. Epoch however is exactly: 1970-01-01T00:00:00Z ISO 8601\nSee: https://github.com/openstack/manila/blob/16bfc82/manila/api/v1/limits.py#L153\n\ndatetime.utcfromtimestamp gives you the utc, so that seems correct... \n\nThe API reference for this API shows that timezone could be returned, but only in the format: +/-XX:XX:\nhttps://developer.openstack.org/api-ref/shared-file-systems/?expanded\u003dlist-share-limits-detail\n\nSo, the unit test seems wrong... \"+00:00\" should have been returned instead of \"Z\" (Zulu), since that\u0027s proper iso8601. \n\nSo, I think we should fix the unit test and get rid of \"Z\" (and add a release note calling out this bug fix)\n\nUniversally, all timestamps returned by the Manila API would be utc, and as far as i can tell, none of them return +00:00 to validate that.","commit_id":"1b05450367a609a89abe2550b4a08963a52b1c98"}]}