)]}'
{"devstack/plugin.sh":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b66a8a3d556c09162c274a9532227ccbb6c45a23","unresolved":false,"context_lines":[{"line_number":810,"context_line":""},{"line_number":811,"context_line":"# start_manila_api - starts manila API services and checks its availability"},{"line_number":812,"context_line":"function start_manila_api {"},{"line_number":813,"context_line":"    if [ $(trueorfalse \"uwsgi\" MANILA_USE_WSGI_MODE) \u003d\u003d \"uwsgi\" ]; then"},{"line_number":814,"context_line":"        run_process manila-api \"$MANILA_BIN_DIR/uwsgi --ini $MANILA_API_UWSGI_CONF\" \"\""},{"line_number":815,"context_line":"            if ! wait_for_service $SERVICE_TIMEOUT $MANILA_API_ENDPOINT; then"},{"line_number":816,"context_line":"                die $LINENO \"manila-api uwsgi did not start\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"df140735_43fe9337","line":813,"range":{"start_line":813,"start_character":11,"end_line":813,"end_character":22},"updated":"2017-06-01 16:29:26.000000000","message":"this func is useful for \"boolean\"-like vars.","commit_id":"2e1335f2badf7996414c7080597bdefdfd16bb23"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"e2f778b4cc9cf065cec3859668c126ad2b284513","unresolved":false,"context_lines":[{"line_number":810,"context_line":""},{"line_number":811,"context_line":"# start_manila_api - starts manila API services and checks its availability"},{"line_number":812,"context_line":"function start_manila_api {"},{"line_number":813,"context_line":"    if [ $(trueorfalse \"uwsgi\" MANILA_USE_WSGI_MODE) \u003d\u003d \"uwsgi\" ]; then"},{"line_number":814,"context_line":"        run_process manila-api \"$MANILA_BIN_DIR/uwsgi --ini $MANILA_API_UWSGI_CONF\" \"\""},{"line_number":815,"context_line":"            if ! wait_for_service $SERVICE_TIMEOUT $MANILA_API_ENDPOINT; then"},{"line_number":816,"context_line":"                die $LINENO \"manila-api uwsgi did not start\""}],"source_content_type":"text/x-sh","patch_set":2,"id":"df140735_21c029e1","line":813,"range":{"start_line":813,"start_character":11,"end_line":813,"end_character":22},"in_reply_to":"df140735_43fe9337","updated":"2017-06-02 03:00:01.000000000","message":"Done","commit_id":"2e1335f2badf7996414c7080597bdefdfd16bb23"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b66a8a3d556c09162c274a9532227ccbb6c45a23","unresolved":false,"context_lines":[{"line_number":815,"context_line":"            if ! wait_for_service $SERVICE_TIMEOUT $MANILA_API_ENDPOINT; then"},{"line_number":816,"context_line":"                die $LINENO \"manila-api uwsgi did not start\""},{"line_number":817,"context_line":"        fi"},{"line_number":818,"context_line":"    elif [[ MANILA_USE_WSGI_MODE \u003d\u003d \"wsgi\" ]]; then"},{"line_number":819,"context_line":"        install_apache_wsgi"},{"line_number":820,"context_line":"        enable_apache_site manila-api"},{"line_number":821,"context_line":"        restart_apache_server"}],"source_content_type":"text/x-sh","patch_set":2,"id":"df140735_23f95f4c","line":818,"range":{"start_line":818,"start_character":4,"end_line":818,"end_character":51},"updated":"2017-06-01 16:29:26.000000000","message":"It is always false. You compare two explicit strings here.","commit_id":"2e1335f2badf7996414c7080597bdefdfd16bb23"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"e2f778b4cc9cf065cec3859668c126ad2b284513","unresolved":false,"context_lines":[{"line_number":815,"context_line":"            if ! wait_for_service $SERVICE_TIMEOUT $MANILA_API_ENDPOINT; then"},{"line_number":816,"context_line":"                die $LINENO \"manila-api uwsgi did not start\""},{"line_number":817,"context_line":"        fi"},{"line_number":818,"context_line":"    elif [[ MANILA_USE_WSGI_MODE \u003d\u003d \"wsgi\" ]]; then"},{"line_number":819,"context_line":"        install_apache_wsgi"},{"line_number":820,"context_line":"        enable_apache_site manila-api"},{"line_number":821,"context_line":"        restart_apache_server"}],"source_content_type":"text/x-sh","patch_set":2,"id":"df140735_e1b5917f","line":818,"range":{"start_line":818,"start_character":4,"end_line":818,"end_character":51},"in_reply_to":"df140735_23f95f4c","updated":"2017-06-02 03:00:01.000000000","message":"Done","commit_id":"2e1335f2badf7996414c7080597bdefdfd16bb23"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b66a8a3d556c09162c274a9532227ccbb6c45a23","unresolved":false,"context_lines":[{"line_number":852,"context_line":"# stop_manila - Stop running processes"},{"line_number":853,"context_line":"function stop_manila {"},{"line_number":854,"context_line":"    # Disable manila api service"},{"line_number":855,"context_line":"    if [ $(trueorfalse \"uwsgi\" MANILA_USE_WSGI_MODE) \u003d\u003d \"uwsgi\" ]; then"},{"line_number":856,"context_line":"        remove_uwsgi_config \"$MANILA_API_UWSGI_CONF\" \"$MANILA_API_UWSGI\""},{"line_number":857,"context_line":"        stop_process karbor-api"},{"line_number":858,"context_line":"    elif [[ MANILA_USE_WSGI_MODE \u003d\u003d \"wsgi\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"df140735_231ddfbc","line":855,"range":{"start_line":855,"start_character":4,"end_line":855,"end_character":71},"updated":"2017-06-01 16:29:26.000000000","message":"if [[ $WSGI_MODE \u003d\u003d \"uwsgi\" ]]; then","commit_id":"2e1335f2badf7996414c7080597bdefdfd16bb23"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"e2f778b4cc9cf065cec3859668c126ad2b284513","unresolved":false,"context_lines":[{"line_number":852,"context_line":"# stop_manila - Stop running processes"},{"line_number":853,"context_line":"function stop_manila {"},{"line_number":854,"context_line":"    # Disable manila api service"},{"line_number":855,"context_line":"    if [ $(trueorfalse \"uwsgi\" MANILA_USE_WSGI_MODE) \u003d\u003d \"uwsgi\" ]; then"},{"line_number":856,"context_line":"        remove_uwsgi_config \"$MANILA_API_UWSGI_CONF\" \"$MANILA_API_UWSGI\""},{"line_number":857,"context_line":"        stop_process karbor-api"},{"line_number":858,"context_line":"    elif [[ MANILA_USE_WSGI_MODE \u003d\u003d \"wsgi\" ]]; then"}],"source_content_type":"text/x-sh","patch_set":2,"id":"df140735_c1ba8d6c","line":855,"range":{"start_line":855,"start_character":4,"end_line":855,"end_character":71},"in_reply_to":"df140735_231ddfbc","updated":"2017-06-02 03:00:01.000000000","message":"Done","commit_id":"2e1335f2badf7996414c7080597bdefdfd16bb23"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b66a8a3d556c09162c274a9532227ccbb6c45a23","unresolved":false,"context_lines":[{"line_number":854,"context_line":"    # Disable manila api service"},{"line_number":855,"context_line":"    if [ $(trueorfalse \"uwsgi\" MANILA_USE_WSGI_MODE) \u003d\u003d \"uwsgi\" ]; then"},{"line_number":856,"context_line":"        remove_uwsgi_config \"$MANILA_API_UWSGI_CONF\" \"$MANILA_API_UWSGI\""},{"line_number":857,"context_line":"        stop_process karbor-api"},{"line_number":858,"context_line":"    elif [[ MANILA_USE_WSGI_MODE \u003d\u003d \"wsgi\" ]]; then"},{"line_number":859,"context_line":"        disable_apache_site manila-api"},{"line_number":860,"context_line":"        restart_apache_server"}],"source_content_type":"text/x-sh","patch_set":2,"id":"df140735_0363fb43","line":857,"range":{"start_line":857,"start_character":21,"end_line":857,"end_character":27},"updated":"2017-06-01 16:29:26.000000000","message":"karbor? really? )","commit_id":"2e1335f2badf7996414c7080597bdefdfd16bb23"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"e2f778b4cc9cf065cec3859668c126ad2b284513","unresolved":false,"context_lines":[{"line_number":854,"context_line":"    # Disable manila api service"},{"line_number":855,"context_line":"    if [ $(trueorfalse \"uwsgi\" MANILA_USE_WSGI_MODE) \u003d\u003d \"uwsgi\" ]; then"},{"line_number":856,"context_line":"        remove_uwsgi_config \"$MANILA_API_UWSGI_CONF\" \"$MANILA_API_UWSGI\""},{"line_number":857,"context_line":"        stop_process karbor-api"},{"line_number":858,"context_line":"    elif [[ MANILA_USE_WSGI_MODE \u003d\u003d \"wsgi\" ]]; then"},{"line_number":859,"context_line":"        disable_apache_site manila-api"},{"line_number":860,"context_line":"        restart_apache_server"}],"source_content_type":"text/x-sh","patch_set":2,"id":"df140735_e143516b","line":857,"range":{"start_line":857,"start_character":21,"end_line":857,"end_character":27},"in_reply_to":"df140735_0363fb43","updated":"2017-06-02 03:00:01.000000000","message":"Done","commit_id":"2e1335f2badf7996414c7080597bdefdfd16bb23"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b66a8a3d556c09162c274a9532227ccbb6c45a23","unresolved":false,"context_lines":[{"line_number":855,"context_line":"    if [ $(trueorfalse \"uwsgi\" MANILA_USE_WSGI_MODE) \u003d\u003d \"uwsgi\" ]; then"},{"line_number":856,"context_line":"        remove_uwsgi_config \"$MANILA_API_UWSGI_CONF\" \"$MANILA_API_UWSGI\""},{"line_number":857,"context_line":"        stop_process karbor-api"},{"line_number":858,"context_line":"    elif [[ MANILA_USE_WSGI_MODE \u003d\u003d \"wsgi\" ]]; then"},{"line_number":859,"context_line":"        disable_apache_site manila-api"},{"line_number":860,"context_line":"        restart_apache_server"},{"line_number":861,"context_line":"    else"}],"source_content_type":"text/x-sh","patch_set":2,"id":"df140735_4350d35d","line":858,"range":{"start_line":858,"start_character":4,"end_line":858,"end_character":51},"updated":"2017-06-01 16:29:26.000000000","message":"It is always false. You compare two explicit strings here.","commit_id":"2e1335f2badf7996414c7080597bdefdfd16bb23"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"e2f778b4cc9cf065cec3859668c126ad2b284513","unresolved":false,"context_lines":[{"line_number":855,"context_line":"    if [ $(trueorfalse \"uwsgi\" MANILA_USE_WSGI_MODE) \u003d\u003d \"uwsgi\" ]; then"},{"line_number":856,"context_line":"        remove_uwsgi_config \"$MANILA_API_UWSGI_CONF\" \"$MANILA_API_UWSGI\""},{"line_number":857,"context_line":"        stop_process karbor-api"},{"line_number":858,"context_line":"    elif [[ MANILA_USE_WSGI_MODE \u003d\u003d \"wsgi\" ]]; then"},{"line_number":859,"context_line":"        disable_apache_site manila-api"},{"line_number":860,"context_line":"        restart_apache_server"},{"line_number":861,"context_line":"    else"}],"source_content_type":"text/x-sh","patch_set":2,"id":"df140735_21338916","line":858,"range":{"start_line":858,"start_character":4,"end_line":858,"end_character":51},"in_reply_to":"df140735_4350d35d","updated":"2017-06-02 03:00:01.000000000","message":"Done","commit_id":"2e1335f2badf7996414c7080597bdefdfd16bb23"}],"devstack/settings":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b66a8a3d556c09162c274a9532227ccbb6c45a23","unresolved":false,"context_lines":[{"line_number":103,"context_line":"# \u0027governance\u0027 project. See:"},{"line_number":104,"context_line":"# https://governance.openstack.org/tc/goals/pike/deploy-api-in-wsgi.html#completion-criteria"},{"line_number":105,"context_line":"# https://docs.openstack.org/developer/keystone/apache-httpd.html"},{"line_number":106,"context_line":"MANILA_USE_WSGI_MODE\u003d${MANILA_USE_WSGI_MODE:-\"uwsgi\"}"},{"line_number":107,"context_line":"MANILA_API_UWSGI_CONF\u003d$MANILA_CONF_DIR/manila-uwsgi.ini"},{"line_number":108,"context_line":"MANILA_API_UWSGI\u003d$MANILA_BIN_DIR/manila-wsgi"},{"line_number":109,"context_line":"MANILA_SERVICE_TYPE\u003dfile-share-service "}],"source_content_type":"application/octet-stream","patch_set":2,"id":"df140735_c3b2a3e6","line":106,"range":{"start_line":106,"start_character":0,"end_line":106,"end_character":20},"updated":"2017-06-01 16:29:26.000000000","message":"Word \"use\" in name assumes we have boolean. But it is not so looking at its value.\n\nThen, I guess, we should reuse devstack\u0027s var \"WSGI_MODE\" [1]\n\n[1] https://review.openstack.org/#/c/456344/15/stackrc","commit_id":"2e1335f2badf7996414c7080597bdefdfd16bb23"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"e2f778b4cc9cf065cec3859668c126ad2b284513","unresolved":false,"context_lines":[{"line_number":103,"context_line":"# \u0027governance\u0027 project. See:"},{"line_number":104,"context_line":"# https://governance.openstack.org/tc/goals/pike/deploy-api-in-wsgi.html#completion-criteria"},{"line_number":105,"context_line":"# https://docs.openstack.org/developer/keystone/apache-httpd.html"},{"line_number":106,"context_line":"MANILA_USE_WSGI_MODE\u003d${MANILA_USE_WSGI_MODE:-\"uwsgi\"}"},{"line_number":107,"context_line":"MANILA_API_UWSGI_CONF\u003d$MANILA_CONF_DIR/manila-uwsgi.ini"},{"line_number":108,"context_line":"MANILA_API_UWSGI\u003d$MANILA_BIN_DIR/manila-wsgi"},{"line_number":109,"context_line":"MANILA_SERVICE_TYPE\u003dfile-share-service "}],"source_content_type":"application/octet-stream","patch_set":2,"id":"df140735_1c86ac67","line":106,"range":{"start_line":106,"start_character":0,"end_line":106,"end_character":20},"in_reply_to":"df140735_c3b2a3e6","updated":"2017-06-02 03:00:01.000000000","message":"Done","commit_id":"2e1335f2badf7996414c7080597bdefdfd16bb23"}]}