)]}'
{"manila/api/common.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"664fe10ecbc91d97a5503f45460b4da98e5b3d05","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"    if \u0027marker\u0027 in request.GET:"},{"line_number":80,"context_line":"        params[\u0027marker\u0027] \u003d _get_marker_param(request)"},{"line_number":81,"context_line":"    else:"},{"line_number":82,"context_line":"        params[\u0027marker\u0027] \u003d None"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    return params"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_6cb6968d","line":82,"range":{"start_line":81,"start_character":1,"end_line":82,"end_character":31},"updated":"2017-06-07 02:07:23.000000000","message":"Do we really need this? If marker is not exist in params, we will also get None.","commit_id":"3250024a47ab3de1e32182901059f4d5f3e8587a"}],"manila/api/v2/messages.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"664fe10ecbc91d97a5503f45460b4da98e5b3d05","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        messages \u003d self.message_api.get_all("},{"line_number":89,"context_line":"            context, search_opts\u003dsearch_opts, sort_dir\u003dsort_dir,"},{"line_number":90,"context_line":"            sort_key\u003dsort_key, limit\u003dparams[\u0027limit\u0027], marker\u003dparams[\u0027marker\u0027]"},{"line_number":91,"context_line":"        )"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        return self._view_builder.index(req, messages)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_6c445675","line":90,"range":{"start_line":90,"start_character":37,"end_line":90,"end_character":52},"updated":"2017-06-07 02:07:23.000000000","message":"s/params[\u0027limit\u0027]/params.get(\u0027limit\u0027)","commit_id":"3250024a47ab3de1e32182901059f4d5f3e8587a"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"664fe10ecbc91d97a5503f45460b4da98e5b3d05","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        messages \u003d self.message_api.get_all("},{"line_number":89,"context_line":"            context, search_opts\u003dsearch_opts, sort_dir\u003dsort_dir,"},{"line_number":90,"context_line":"            sort_key\u003dsort_key, limit\u003dparams[\u0027limit\u0027], marker\u003dparams[\u0027marker\u0027]"},{"line_number":91,"context_line":"        )"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        return self._view_builder.index(req, messages)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_4c499289","line":90,"range":{"start_line":90,"start_character":54,"end_line":90,"end_character":77},"updated":"2017-06-07 02:07:23.000000000","message":"s/params[\u0027marker\u0027]/params.get(\u0027marker\u0027)","commit_id":"3250024a47ab3de1e32182901059f4d5f3e8587a"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"233649230b685e839e629758f05374aaba663f17","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        \"\"\"Returns a list of messages, transformed through view builder.\"\"\""},{"line_number":75,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        search_opts \u003d {}"},{"line_number":78,"context_line":"        search_opts.update(req.GET)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        # Remove keys that are not related to message attrs"},{"line_number":81,"context_line":"        search_opts.pop(\u0027limit\u0027, None)"},{"line_number":82,"context_line":"        search_opts.pop(\u0027marker\u0027, None)"},{"line_number":83,"context_line":"        sort_key \u003d search_opts.pop(\u0027sort_key\u0027, \u0027created_at\u0027)"},{"line_number":84,"context_line":"        sort_dir \u003d search_opts.pop(\u0027sort_dir\u0027, \u0027desc\u0027)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        messages \u003d self.message_api.get_all("},{"line_number":87,"context_line":"            context, search_opts\u003dsearch_opts, sort_dir\u003dsort_dir,"},{"line_number":88,"context_line":"            sort_key\u003dsort_key)"},{"line_number":89,"context_line":"        limited_list \u003d common.limited(messages, req)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        return self._view_builder.index(req, limited_list)"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_2944151b","line":89,"range":{"start_line":77,"start_character":8,"end_line":89,"end_character":52},"updated":"2017-06-29 02:20:54.000000000","message":"This is API change about add some new parameters. Why we don\u0027t need api microversion?\nhttps://github.com/openstack/manila/blob/master/doc/source/devref/api_microversion_dev.rst","commit_id":"b8ab4a5fff2d8534d31e40dcd9bec318bac702d8"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4c0ed70aa6e58e16b8408192115e560ac7e1ce76","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        \"\"\"Returns a list of messages, transformed through view builder.\"\"\""},{"line_number":75,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        search_opts \u003d {}"},{"line_number":78,"context_line":"        search_opts.update(req.GET)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        # Remove keys that are not related to message attrs"},{"line_number":81,"context_line":"        search_opts.pop(\u0027limit\u0027, None)"},{"line_number":82,"context_line":"        search_opts.pop(\u0027marker\u0027, None)"},{"line_number":83,"context_line":"        sort_key \u003d search_opts.pop(\u0027sort_key\u0027, \u0027created_at\u0027)"},{"line_number":84,"context_line":"        sort_dir \u003d search_opts.pop(\u0027sort_dir\u0027, \u0027desc\u0027)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        messages \u003d self.message_api.get_all("},{"line_number":87,"context_line":"            context, search_opts\u003dsearch_opts, sort_dir\u003dsort_dir,"},{"line_number":88,"context_line":"            sort_key\u003dsort_key)"},{"line_number":89,"context_line":"        limited_list \u003d common.limited(messages, req)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        return self._view_builder.index(req, limited_list)"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f1d235d_c1743c9c","line":89,"range":{"start_line":77,"start_character":8,"end_line":89,"end_character":52},"in_reply_to":"3f1d235d_4f186e80","updated":"2017-06-30 00:36:48.000000000","message":"+1 agree with the points here. Lets squash as discussed.","commit_id":"b8ab4a5fff2d8534d31e40dcd9bec318bac702d8"},{"author":{"_account_id":7582,"name":"Jan Provaznik","email":"jan.provaznik@gmail.com","username":"jprovazn"},"change_message_id":"74b7be9b50cd6394b6b6aa97770320336270160e","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        \"\"\"Returns a list of messages, transformed through view builder.\"\"\""},{"line_number":75,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        search_opts \u003d {}"},{"line_number":78,"context_line":"        search_opts.update(req.GET)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        # Remove keys that are not related to message attrs"},{"line_number":81,"context_line":"        search_opts.pop(\u0027limit\u0027, None)"},{"line_number":82,"context_line":"        search_opts.pop(\u0027marker\u0027, None)"},{"line_number":83,"context_line":"        sort_key \u003d search_opts.pop(\u0027sort_key\u0027, \u0027created_at\u0027)"},{"line_number":84,"context_line":"        sort_dir \u003d search_opts.pop(\u0027sort_dir\u0027, \u0027desc\u0027)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        messages \u003d self.message_api.get_all("},{"line_number":87,"context_line":"            context, search_opts\u003dsearch_opts, sort_dir\u003dsort_dir,"},{"line_number":88,"context_line":"            sort_key\u003dsort_key)"},{"line_number":89,"context_line":"        limited_list \u003d common.limited(messages, req)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        return self._view_builder.index(req, limited_list)"},{"line_number":92,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"3f1d235d_4f186e80","line":89,"range":{"start_line":77,"start_character":8,"end_line":89,"end_character":52},"in_reply_to":"5f201791_2944151b","updated":"2017-06-29 11:38:23.000000000","message":"Although it\u0027s true that a new microversion should be used with change of params, I consider such requirement in this case as not reasonable. This patch depends on the \"user messages\" patch which is not merged yet (so not used yet), the main reason to split it out from the \"user messages\" patch was:\n1) user messages patch was originally written by Alex, I prefer to minimize mixing of authorship if possible (both because of keeping his credit but also to avoid blaming him for bugs in code he didn\u0027t write)\n2) this is a logical chunk which makes it easier to review\n\nI will not use 2 new microversions in 2 closely-related unmerged patches. If the consensus is to follow https://github.com/openstack/manila/blob/master/doc/source/devref/api_microversion_dev.rst in this case, I\u0027ll rather squash this with the original \"user messages\" patch.","commit_id":"b8ab4a5fff2d8534d31e40dcd9bec318bac702d8"}],"manila/db/sqlalchemy/api.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"664fe10ecbc91d97a5503f45460b4da98e5b3d05","unresolved":false,"context_lines":[{"line_number":4533,"context_line":""},{"line_number":4534,"context_line":""},{"line_number":4535,"context_line":"@require_context"},{"line_number":4536,"context_line":"def message_get_all(context, filters\u003dNone, sort_key\u003d\u0027created_at\u0027,"},{"line_number":4537,"context_line":"                    sort_dir\u003d\u0027asc\u0027, limit\u003dNone, marker\u003dNone):"},{"line_number":4538,"context_line":"    messages \u003d models.Message"},{"line_number":4539,"context_line":"    query \u003d model_query(context,"},{"line_number":4540,"context_line":"                        messages,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df140735_c75e9d11","line":4537,"range":{"start_line":4536,"start_character":43,"end_line":4537,"end_character":35},"updated":"2017-06-07 02:07:23.000000000","message":"The default will be None if we don\u0027t input sort_key and sort_dir. The manila/db/api.py api parameter value will cover this default value. It could be better if we set the default value in function or change the api parameter default value.\nhttps://review.openstack.org/#/c/471438/1/manila/db/api.py  code line 1272","commit_id":"3250024a47ab3de1e32182901059f4d5f3e8587a"}],"manila_tempest_tests/tests/api/admin/test_user_messages.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"ee2b4cd6dd75a5ae1c8ea5b9cbaa4b2def8f3680","unresolved":false,"context_lines":[{"line_number":83,"context_line":"    @test.attr(type\u003d[base.TAG_POSITIVE, base.TAG_API])"},{"line_number":84,"context_line":"    def test_list_messages_sorted(self):"},{"line_number":85,"context_line":"        message2_id \u003d self._create_user_message()"},{"line_number":86,"context_line":"        params \u003d {\u0027search_key\u0027: \u0027created_at\u0027, \u0027sort_dir\u0027 \u0027asc\u0027}"},{"line_number":87,"context_line":"        body \u003d self.shares_v2_client.list_messages(params\u003dparams)"},{"line_number":88,"context_line":"        self.assertIsInstance(body, list)"},{"line_number":89,"context_line":"        ids \u003d [x[\u0027id\u0027] for x in body]"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f201791_97434d3f","line":86,"range":{"start_line":86,"start_character":46,"end_line":86,"end_character":62},"updated":"2017-06-28 19:56:39.000000000","message":"jenkins saw the missing colon that my eyes missed :)","commit_id":"b8ab4a5fff2d8534d31e40dcd9bec318bac702d8"}]}