)]}'
{"manila/api/views/security_service.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2061ce01788487cf365146b90c36ec47c473070c","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @common.ViewBuilder.versioned_method(\"2.41\")"},{"line_number":64,"context_line":"    def add_ou_to_security_service("},{"line_number":65,"context_line":"            self, context, ss_dict, ss):"},{"line_number":66,"context_line":"        ss_dict[\u0027ou\u0027] \u003d ss.get(\u0027ou\u0027)"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def _list_view(self, func, request, security_services):"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f2577a7_32573c29","line":65,"range":{"start_line":65,"start_character":12,"end_line":65,"end_character":40},"updated":"2017-09-17 00:37:06.000000000","message":"nit: can be on previous line","commit_id":"e68d53ce30df9c3769360904f81e45fa5ea2eb38"}],"manila/db/migrations/alembic/versions/0274d20c560f_add_ou_to_security_service.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"b6da1b4c02784029986114245adcb141bf02a46f","unresolved":false,"context_lines":[{"line_number":20,"context_line":""},{"line_number":21,"context_line":"# revision identifiers, used by Alembic."},{"line_number":22,"context_line":"revision \u003d \u00270274d20c560f\u0027"},{"line_number":23,"context_line":"down_revision \u003d \u0027221a83cfd85b\u0027"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from alembic import op"},{"line_number":26,"context_line":"import sqlalchemy as sa"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_5194818b","line":23,"range":{"start_line":23,"start_character":17,"end_line":23,"end_character":29},"updated":"2017-06-08 10:06:49.000000000","message":"It should be latest one","commit_id":"c3274eb125109ee91b8ee867cda04e8c793c8625"}],"manila_tempest_tests/services/share/v2/json/shares_client.py":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"51503694b0e985e2a49386bb6adfb1d3ec6c0420","unresolved":false,"context_lines":[{"line_number":1736,"context_line":""},{"line_number":1737,"context_line":"    def create_security_service(self, ss_type\u003d\"ldap\","},{"line_number":1738,"context_line":"                                version\u003dLATEST_MICROVERSION, **kwargs):"},{"line_number":1739,"context_line":"        # ss_type: ldap, kerberos, active_directory"},{"line_number":1740,"context_line":"        # kwargs: name, description, dns_ip, server, ou, domain, user, password"},{"line_number":1741,"context_line":"        post_body \u003d {\"type\": ss_type}"},{"line_number":1742,"context_line":"        post_body.update(kwargs)"},{"line_number":1743,"context_line":"        body \u003d json.dumps({\"security_service\": post_body})"}],"source_content_type":"text/x-python","patch_set":20,"id":"7f515b1d_f89c3d5e","line":1740,"range":{"start_line":1739,"start_character":8,"end_line":1740,"end_character":79},"updated":"2017-09-26 08:51:05.000000000","message":"better to make this docstrings","commit_id":"17f7a749c7714cc544db35457e0b50dd65870c05"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"51503694b0e985e2a49386bb6adfb1d3ec6c0420","unresolved":false,"context_lines":[{"line_number":1747,"context_line":""},{"line_number":1748,"context_line":"    def update_security_service(self, ss_id, version\u003dLATEST_MICROVERSION,"},{"line_number":1749,"context_line":"                                **kwargs):"},{"line_number":1750,"context_line":"        # ss_id - id of security-service entity"},{"line_number":1751,"context_line":"        # kwargs: dns_ip, server, ou, domain, user, password, name, description"},{"line_number":1752,"context_line":"        # for \u0027active\u0027 status can be changed"},{"line_number":1753,"context_line":"        # only \u0027name\u0027 and \u0027description\u0027 fields"},{"line_number":1754,"context_line":"        body \u003d json.dumps({\"security_service\": kwargs})"},{"line_number":1755,"context_line":"        resp, body \u003d self.put(\"security-services/%s\" % ss_id, body,"},{"line_number":1756,"context_line":"                              version\u003dversion)"}],"source_content_type":"text/x-python","patch_set":20,"id":"7f515b1d_d8a3c19d","line":1753,"range":{"start_line":1750,"start_character":8,"end_line":1753,"end_character":46},"updated":"2017-09-26 08:51:05.000000000","message":"here too","commit_id":"17f7a749c7714cc544db35457e0b50dd65870c05"}],"manila_tempest_tests/tests/api/base.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c7d3ec3fe8a86aa9ae0aee223a7188637112b065","unresolved":false,"context_lines":[{"line_number":937,"context_line":"            \"user\": data_utils.rand_name(\"ss-user\"),"},{"line_number":938,"context_line":"            \"password\": data_utils.rand_name(\"ss-password\"),"},{"line_number":939,"context_line":"        }"},{"line_number":940,"context_line":"        if v2:"},{"line_number":941,"context_line":"            data[\"ou\"] \u003d data_utils.rand_name(\"ss-ou\")"},{"line_number":942,"context_line":""},{"line_number":943,"context_line":"        return data"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f231b9d_f1195f22","line":940,"range":{"start_line":940,"start_character":8,"end_line":940,"end_character":14},"updated":"2017-06-20 02:29:47.000000000","message":"The v2 API means from 2.0 api version  to current version(2.35)\n\nThe \u0027ou\u0027 added in 2.35 version, it doesn\u0027t added in v2.\n\nSo, we shouldn\u0027t use \u0027v2\u0027 as parameter. We could use \u0027ou\u0027 or \u0027**kwargs\u0027 as parameter\u0027s name.","commit_id":"f92cebc1b1ab2c4aeb680bb5c08d70f5161698cf"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"358cf60e668983f789bb14c54c37d6f7ce407aa1","unresolved":false,"context_lines":[{"line_number":937,"context_line":"            \"user\": data_utils.rand_name(\"ss-user\"),"},{"line_number":938,"context_line":"            \"password\": data_utils.rand_name(\"ss-password\"),"},{"line_number":939,"context_line":"        }"},{"line_number":940,"context_line":"        if kwargs.get(\u0027ou\u0027):"},{"line_number":941,"context_line":"            data[\"ou\"] \u003d data_utils.rand_name(\"ss-ou\")"},{"line_number":942,"context_line":""},{"line_number":943,"context_line":"        return data"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f201791_3a5530c7","line":940,"range":{"start_line":940,"start_character":8,"end_line":940,"end_character":28},"updated":"2017-06-22 14:44:48.000000000","message":"Why you use kwargs here? It would be much more obvious if we define here, for example, \"set_ou\" arg. That will be only boolean without need to read method logic.","commit_id":"60feb58f45da6b9f5d6ab604a2b3bc5bb5a84b47"}],"manila_tempest_tests/tests/api/test_security_services.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7650e80819a1b371e2defd084afc75c6d93bff12","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            \u0027domain\u0027: \u0027fake_domain_1\u0027,"},{"line_number":91,"context_line":"            \u0027ou\u0027: \u0027OU\u003dfake_unit_1\u0027,"},{"line_number":92,"context_line":"        }"},{"line_number":93,"context_line":"        listed \u003d self.shares_client.list_security_services("},{"line_number":94,"context_line":"            detailed\u003dTrue,"},{"line_number":95,"context_line":"            params\u003dsearch_opts)"},{"line_number":96,"context_line":"        self.assertTrue(any(self.ss_ldap[\u0027id\u0027] \u003d\u003d ss[\u0027id\u0027] for ss in listed))"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f0e0f27_80b77cd9","line":93,"range":{"start_line":93,"start_character":22,"end_line":93,"end_character":35},"updated":"2017-06-09 09:11:13.000000000","message":"It only added ou in v2(shares_v2_client).","commit_id":"9f642629800528acf1caf8486ff6e0ad871da5c5"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"82895aae020ee8862ad9d0d3a9dc3425ecb4ba63","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":42,"context_line":"    def test_list_security_services_with_detail(self):"},{"line_number":43,"context_line":"        listed \u003d self.shares_client.list_security_services(detailed\u003dTrue)"},{"line_number":44,"context_line":"        self.assertTrue(any(self.ss_ldap[\u0027id\u0027] \u003d\u003d ss[\u0027id\u0027] for ss in listed))"},{"line_number":45,"context_line":"        self.assertTrue(any(self.ss_kerberos[\u0027id\u0027] \u003d\u003d ss[\u0027id\u0027]"},{"line_number":46,"context_line":"                            for ss in listed))"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f231b9d_eabc84dd","line":43,"range":{"start_line":43,"start_character":22,"end_line":43,"end_character":35},"updated":"2017-06-13 09:06:04.000000000","message":"You added ou in V2 API, The shares_client is V1 API client. It should be changed to shares_v2_client.","commit_id":"7bc47387bc1ce970d79e4532f492c46b7d5ac8ca"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c7d3ec3fe8a86aa9ae0aee223a7188637112b065","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        # verify ou is in v2"},{"line_number":57,"context_line":"        listed_v2 \u003d self.shares_v2_client.list_security_services(detailed\u003dTrue)"},{"line_number":58,"context_line":"        for s_s_v2 in listed_v2:"},{"line_number":59,"context_line":"            self.assertIn(\"ou\", s_s_v2.keys())"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":62,"context_line":"    @testtools.skipIf("}],"source_content_type":"text/x-python","patch_set":8,"id":"7f231b9d_7158aff9","line":59,"range":{"start_line":58,"start_character":8,"end_line":59,"end_character":46},"updated":"2017-06-20 02:29:47.000000000","message":"We only support it when the api version \u003e\u003d 2.35, so please add @base.skip_if_microversion_lt(\"2.35\")  or utils.is_microversion_ge(\"2.35\",.....)","commit_id":"f92cebc1b1ab2c4aeb680bb5c08d70f5161698cf"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c7d3ec3fe8a86aa9ae0aee223a7188637112b065","unresolved":false,"context_lines":[{"line_number":102,"context_line":"            self.assertTrue(all(ss[key] \u003d\u003d value for key, value"},{"line_number":103,"context_line":"                                in search_opts.items()))"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # v2 API"},{"line_number":106,"context_line":"        search_opts[\u0027ou\u0027] \u003d \u0027OU\u003dfake_unit_1\u0027"},{"line_number":107,"context_line":"        listed_v2 \u003d self.shares_v2_client.list_security_services("},{"line_number":108,"context_line":"            detailed\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f231b9d_d168a388","line":105,"range":{"start_line":105,"start_character":8,"end_line":105,"end_character":16},"updated":"2017-06-20 02:29:47.000000000","message":"v2 API means from 2.0 api version  to current version(2.35)\n\nSo it should add the current version in this annotation","commit_id":"f92cebc1b1ab2c4aeb680bb5c08d70f5161698cf"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c7d3ec3fe8a86aa9ae0aee223a7188637112b065","unresolved":false,"context_lines":[{"line_number":103,"context_line":"                                in search_opts.items()))"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # v2 API"},{"line_number":106,"context_line":"        search_opts[\u0027ou\u0027] \u003d \u0027OU\u003dfake_unit_1\u0027"},{"line_number":107,"context_line":"        listed_v2 \u003d self.shares_v2_client.list_security_services("},{"line_number":108,"context_line":"            detailed\u003dTrue,"},{"line_number":109,"context_line":"            params\u003dsearch_opts)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f231b9d_515db3e7","line":106,"range":{"start_line":106,"start_character":7,"end_line":106,"end_character":44},"updated":"2017-06-20 02:29:47.000000000","message":"above","commit_id":"f92cebc1b1ab2c4aeb680bb5c08d70f5161698cf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2061ce01788487cf365146b90c36ec47c473070c","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        get \u003d self.shares_client.get_security_service(ss[\"id\"])"},{"line_number":154,"context_line":"        self.assertDictContainsSubset(data, get)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"    @base.skip_if_microversion_lt(\"2.41\")"},{"line_number":157,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":158,"context_line":"    def test_get_security_service_with_ou(self):"},{"line_number":159,"context_line":"        data \u003d self.generate_security_service_data(set_ou\u003dTrue)"},{"line_number":160,"context_line":"        ss \u003d self.create_security_service("},{"line_number":161,"context_line":"            client\u003dself.shares_v2_client, **data)"},{"line_number":162,"context_line":"        self.assertDictContainsSubset(data, ss)"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"        get \u003d self.shares_v2_client.get_security_service(ss[\"id\"])"},{"line_number":165,"context_line":"        self.assertDictContainsSubset(data, get)"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API)"},{"line_number":168,"context_line":"    def test_update_security_service(self):"}],"source_content_type":"text/x-python","patch_set":15,"id":"5f2577a7_15542a20","line":165,"range":{"start_line":156,"start_character":0,"end_line":165,"end_character":48},"updated":"2017-09-17 00:37:06.000000000","message":"We typically test the microversion border (like you have done below), so you can rewrite the test above to do this for you:\n\n    LATEST_MICROVERSION \u003d CONF.share.max_api_microversion\n\n    @tc.attr(base.TAG_POSITIVE, base.TAG_API)\n    @ddt.data(*set([\u00271.0\u0027, \u00272.40\u0027, \u00272.41\u0027, LATEST_MICROVERSION]))\n    def test_get_security_service(self, version):\n\n        with_ou \u003d True if utils.is_microversion_ge(version, \u00272.41\u0027) else False\n        data \u003d self.generate_security_service_data(set_ou\u003dwith_ou)\n        ss \u003d self.create_security_service(**data)\n        self.assertDictContainsSubset(data, ss)\n        self.assertEqual(with_ou, \u0027ou\u0027 in ss)\n\n        get \u003d self.shares_client.get_security_service(ss[\"id\"])\n        self.assertDictContainsSubset(data, get)\n        self.assertEqual(with_ou, \u0027ou\u0027 in ss)","commit_id":"e68d53ce30df9c3769360904f81e45fa5ea2eb38"}],"releasenotes/notes/bug-1696669-add-ou-to-security-service-06b69615bd417d40.yaml":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"51503694b0e985e2a49386bb6adfb1d3ec6c0420","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added \u0027ou\u0027 field to \u0027security_service\u0027 object to be able to configure in"},{"line_number":4,"context_line":"    which organizational unit the share ends up."}],"source_content_type":"text/x-yaml","patch_set":20,"id":"7f515b1d_98cae96a","line":3,"updated":"2017-09-26 08:51:05.000000000","message":"add a | here to indicate multiple lines :D","commit_id":"17f7a749c7714cc544db35457e0b50dd65870c05"}]}
