)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2017-06-08 15:26:04 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Veritas Access driver for manila"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I60de5f9e598e32f853804cd3d7807aaacdde273b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bf091321_2a1bd61b","line":8,"updated":"2017-06-08 11:39:20.000000000","message":"add a description and a blueprint","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"beee04614ef22da0e1b7282236cd0d934803313d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This driver implements all the minimum required features for manila."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"DocImpact"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I60de5f9e598e32f853804cd3d7807aaacdde273b"},{"line_number":14,"context_line":"Implement: blueprint veritas-manila-driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":32,"id":"7f287b81_f8bd41b7","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":9},"updated":"2017-09-06 20:19:50.000000000","message":"Please be aware that this tag creates a bug in https://bugs.launchpad.net/manila when this change merges. \n\nYou will need to add documentation in the in-tree:\n\n- Feature support matrix: https://github.com/openstack/manila/blob/9006072/doc/source/contributor/share_back_ends_feature_support_mapping.rst\n- Configuration reference: https://github.com/openstack/manila/tree/master/doc/source/configuration/shared-file-systems","commit_id":"d743a7ada8644265400df5e50b22e460d7e0c2b9"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"b40ab344307ff6d2932df7de9fd6721650b8282e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This driver implements all the minimum required features for manila."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"DocImpact"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I60de5f9e598e32f853804cd3d7807aaacdde273b"},{"line_number":14,"context_line":"Implement: blueprint veritas-manila-driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":32,"id":"7f287b81_a24c0dc8","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":9},"in_reply_to":"7f287b81_f8bd41b7","updated":"2017-09-07 13:19:30.000000000","message":"Thanks for your comments Goutham.\nI have Removed the \u0027DocImpact\u0027 tag.\nWorking on documentation part.","commit_id":"d743a7ada8644265400df5e50b22e460d7e0c2b9"}],"manila/share/drivers/veritas/veritas_isa.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"901a28ff02b759427f125b9130a7a7e6bee55085","unresolved":false,"context_lines":[{"line_number":21,"context_line":"3) IP based access-control"},{"line_number":22,"context_line":"\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import binascii"},{"line_number":25,"context_line":"import json"},{"line_number":26,"context_line":"import requests"},{"line_number":27,"context_line":"from requests.auth import AuthBase"},{"line_number":28,"context_line":"from six.moves import http_client"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from manila.common import constants as const"},{"line_number":31,"context_line":"from manila import exception"},{"line_number":32,"context_line":"from manila.share import driver"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"from oslo_config import cfg"},{"line_number":35,"context_line":"from oslo_log import log as logging"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"from random import shuffle"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"import six"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1f1a1f67_73637743","line":39,"range":{"start_line":24,"start_character":0,"end_line":39,"end_character":10},"updated":"2017-07-18 01:54:35.000000000","message":"Please see this link: https://docs.openstack.org/hacking/latest/user/hacking.html#imports\nWe should change the order","commit_id":"4ba5c054a1cbb9569f879d312fb05663fc1e19e2"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"6124be40f3b724027981489e58c55d0f4c751eb4","unresolved":false,"context_lines":[{"line_number":21,"context_line":"3) IP based access-control"},{"line_number":22,"context_line":"\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import binascii"},{"line_number":25,"context_line":"import json"},{"line_number":26,"context_line":"import requests"},{"line_number":27,"context_line":"from requests.auth import AuthBase"},{"line_number":28,"context_line":"from six.moves import http_client"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"from manila.common import constants as const"},{"line_number":31,"context_line":"from manila import exception"},{"line_number":32,"context_line":"from manila.share import driver"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"from oslo_config import cfg"},{"line_number":35,"context_line":"from oslo_log import log as logging"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"from random import shuffle"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"import six"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":21,"id":"1f1a1f67_ce2f353d","line":39,"range":{"start_line":24,"start_character":0,"end_line":39,"end_character":10},"in_reply_to":"1f1a1f67_73637743","updated":"2017-07-18 10:33:27.000000000","message":"Done","commit_id":"4ba5c054a1cbb9569f879d312fb05663fc1e19e2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b811834dc4e3197975c56535fe0e5367169bd07d","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Limitation:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"1) single tenant"},{"line_number":20,"context_line":"2) only NFS exports"},{"line_number":21,"context_line":"3) IP based access-control"},{"line_number":22,"context_line":"\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import hashlib"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_bb0b3022","line":21,"range":{"start_line":20,"start_character":0,"end_line":21,"end_character":26},"updated":"2017-08-27 05:41:50.000000000","message":"These aren\u0027t limitations; NFS drivers should only ever allow IP based access rules.","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"951c131b76258254e403f4afe9708765c073a2bb","unresolved":false,"context_lines":[{"line_number":17,"context_line":"Limitation:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"1) single tenant"},{"line_number":20,"context_line":"2) only NFS exports"},{"line_number":21,"context_line":"3) IP based access-control"},{"line_number":22,"context_line":"\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import hashlib"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_1ed2c0d1","line":21,"range":{"start_line":20,"start_character":0,"end_line":21,"end_character":26},"in_reply_to":"7f287b81_bb0b3022","updated":"2017-08-31 14:48:46.000000000","message":"Removed","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b811834dc4e3197975c56535fe0e5367169bd07d","unresolved":false,"context_lines":[{"line_number":21,"context_line":"3) IP based access-control"},{"line_number":22,"context_line":"\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import hashlib"},{"line_number":25,"context_line":"import json"},{"line_number":26,"context_line":"from oslo_config import cfg"},{"line_number":27,"context_line":"from oslo_log import log as logging"},{"line_number":28,"context_line":"from random import shuffle"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_5b1a0c6f","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":11},"updated":"2017-08-27 05:41:50.000000000","message":"Separate stdlib imports and third party imports with a blank line:\n\nhttps://docs.openstack.org/hacking/latest/user/hacking.html#import-order-template","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"951c131b76258254e403f4afe9708765c073a2bb","unresolved":false,"context_lines":[{"line_number":21,"context_line":"3) IP based access-control"},{"line_number":22,"context_line":"\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import hashlib"},{"line_number":25,"context_line":"import json"},{"line_number":26,"context_line":"from oslo_config import cfg"},{"line_number":27,"context_line":"from oslo_log import log as logging"},{"line_number":28,"context_line":"from random import shuffle"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_9edd90de","line":25,"range":{"start_line":24,"start_character":0,"end_line":25,"end_character":11},"in_reply_to":"7f287b81_5b1a0c6f","updated":"2017-08-31 14:48:46.000000000","message":"Done","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b811834dc4e3197975c56535fe0e5367169bd07d","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from oslo_log import log as logging"},{"line_number":28,"context_line":"from random import shuffle"},{"line_number":29,"context_line":"import requests"},{"line_number":30,"context_line":"from requests.auth import AuthBase"},{"line_number":31,"context_line":"import six"},{"line_number":32,"context_line":"from six.moves import http_client"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_9b14f445","line":30,"range":{"start_line":30,"start_character":26,"end_line":30,"end_character":34},"updated":"2017-08-27 05:41:50.000000000","message":"Don\u0027t import objects, import modules:\n\nhttps://docs.openstack.org/hacking/latest/user/hacking.html#imports","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"951c131b76258254e403f4afe9708765c073a2bb","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from oslo_log import log as logging"},{"line_number":28,"context_line":"from random import shuffle"},{"line_number":29,"context_line":"import requests"},{"line_number":30,"context_line":"from requests.auth import AuthBase"},{"line_number":31,"context_line":"import six"},{"line_number":32,"context_line":"from six.moves import http_client"},{"line_number":33,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_3ee8dc79","line":30,"range":{"start_line":30,"start_character":26,"end_line":30,"end_character":34},"in_reply_to":"7f287b81_9b14f445","updated":"2017-08-31 14:48:46.000000000","message":"Done","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b811834dc4e3197975c56535fe0e5367169bd07d","unresolved":false,"context_lines":[{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"va_share_opts \u003d ["},{"line_number":42,"context_line":"    cfg.StrOpt(\u0027va_server_ip\u0027,"},{"line_number":43,"context_line":"               help\u003d\u0027Console IP of Veritas Access server.\u0027),"},{"line_number":44,"context_line":"    cfg.IntOpt(\u0027va_port\u0027,"},{"line_number":45,"context_line":"               default\u003d14161,"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_3b174048","line":42,"range":{"start_line":42,"start_character":8,"end_line":42,"end_character":14},"updated":"2017-08-27 05:41:50.000000000","message":"HostAddressOpt","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b811834dc4e3197975c56535fe0e5367169bd07d","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    cfg.StrOpt(\u0027va_pool\u0027,"},{"line_number":53,"context_line":"               help\u003d\u0027Veritas Access storage pool from which\u0027"},{"line_number":54,"context_line":"                    \u0027shares are served.\u0027),"},{"line_number":55,"context_line":"    cfg.StrOpt(\u0027va_fstype\u0027,"},{"line_number":56,"context_line":"               help\u003d\u0027Type of file system to be created.\u0027),"},{"line_number":57,"context_line":"    cfg.BoolOpt(\u0027va_ssl\u0027, default\u003dNone, help\u003d\u0027SSL\u0027)"},{"line_number":58,"context_line":"]"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_bb2450b0","line":56,"range":{"start_line":55,"start_character":0,"end_line":56,"end_character":57},"updated":"2017-08-27 05:41:50.000000000","message":"any options, or examples?","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"951c131b76258254e403f4afe9708765c073a2bb","unresolved":false,"context_lines":[{"line_number":52,"context_line":"    cfg.StrOpt(\u0027va_pool\u0027,"},{"line_number":53,"context_line":"               help\u003d\u0027Veritas Access storage pool from which\u0027"},{"line_number":54,"context_line":"                    \u0027shares are served.\u0027),"},{"line_number":55,"context_line":"    cfg.StrOpt(\u0027va_fstype\u0027,"},{"line_number":56,"context_line":"               help\u003d\u0027Type of file system to be created.\u0027),"},{"line_number":57,"context_line":"    cfg.BoolOpt(\u0027va_ssl\u0027, default\u003dNone, help\u003d\u0027SSL\u0027)"},{"line_number":58,"context_line":"]"},{"line_number":59,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_9e8b50be","line":56,"range":{"start_line":55,"start_character":0,"end_line":56,"end_character":57},"in_reply_to":"7f287b81_bb2450b0","updated":"2017-08-31 14:48:46.000000000","message":"Added \u0027default\u0027","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b811834dc4e3197975c56535fe0e5367169bd07d","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                    \u0027shares are served.\u0027),"},{"line_number":55,"context_line":"    cfg.StrOpt(\u0027va_fstype\u0027,"},{"line_number":56,"context_line":"               help\u003d\u0027Type of file system to be created.\u0027),"},{"line_number":57,"context_line":"    cfg.BoolOpt(\u0027va_ssl\u0027, default\u003dNone, help\u003d\u0027SSL\u0027)"},{"line_number":58,"context_line":"]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_9b3d14c6","line":57,"range":{"start_line":57,"start_character":46,"end_line":57,"end_character":49},"updated":"2017-08-27 05:41:50.000000000","message":"Expand, what does this mean?","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"951c131b76258254e403f4afe9708765c073a2bb","unresolved":false,"context_lines":[{"line_number":54,"context_line":"                    \u0027shares are served.\u0027),"},{"line_number":55,"context_line":"    cfg.StrOpt(\u0027va_fstype\u0027,"},{"line_number":56,"context_line":"               help\u003d\u0027Type of file system to be created.\u0027),"},{"line_number":57,"context_line":"    cfg.BoolOpt(\u0027va_ssl\u0027, default\u003dNone, help\u003d\u0027SSL\u0027)"},{"line_number":58,"context_line":"]"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_feb37496","line":57,"range":{"start_line":57,"start_character":46,"end_line":57,"end_character":49},"in_reply_to":"7f287b81_9b3d14c6","updated":"2017-08-31 14:48:46.000000000","message":"Removed, not much required","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b811834dc4e3197975c56535fe0e5367169bd07d","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        shuffle(vip)"},{"line_number":202,"context_line":"        return six.text_type(vip[0])"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"#    def ensure_share(self, context, share, share_server\u003dNone):"},{"line_number":205,"context_line":"#        \"\"\"Might not be needed?\"\"\""},{"line_number":206,"context_line":"#        pass"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def delete_share(self, context, share, share_server\u003dNone):"},{"line_number":209,"context_line":"        \"\"\"Delete a share from ACCESS.\"\"\""}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_1b4fe46b","line":206,"range":{"start_line":204,"start_character":0,"end_line":206,"end_character":13},"updated":"2017-08-27 05:41:50.000000000","message":"Not needed, if you don\u0027t need it. Currently it is meant to update export_locations on driver restarts... We\u0027ll be changing this driver interface soon, so you may choose to implement the new interface.","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"951c131b76258254e403f4afe9708765c073a2bb","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        shuffle(vip)"},{"line_number":202,"context_line":"        return six.text_type(vip[0])"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"#    def ensure_share(self, context, share, share_server\u003dNone):"},{"line_number":205,"context_line":"#        \"\"\"Might not be needed?\"\"\""},{"line_number":206,"context_line":"#        pass"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"    def delete_share(self, context, share, share_server\u003dNone):"},{"line_number":209,"context_line":"        \"\"\"Delete a share from ACCESS.\"\"\""}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_fe7814c4","line":206,"range":{"start_line":204,"start_character":0,"end_line":206,"end_character":13},"in_reply_to":"7f287b81_1b4fe46b","updated":"2017-08-31 14:48:46.000000000","message":"Done","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b811834dc4e3197975c56535fe0e5367169bd07d","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        LOG.debug(\"ACCESSShareDriver delete_share %s called\","},{"line_number":214,"context_line":"                  sharename)"},{"line_number":215,"context_line":"        if share[\u0027snapshot_id\u0027]:"},{"line_number":216,"context_line":"            message \u003d ((\u0027ACCESSShareDriver delete share %s\u0027"},{"line_number":217,"context_line":"                        \u0027early return\u0027), sharename)"},{"line_number":218,"context_line":"            LOG.debug(message)"},{"line_number":219,"context_line":"            return"},{"line_number":220,"context_line":"        path \u003d self._fs_delete_str"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_fb53f815","line":217,"range":{"start_line":216,"start_character":58,"end_line":217,"end_character":25},"updated":"2017-08-27 05:41:50.000000000","message":"space before early","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"951c131b76258254e403f4afe9708765c073a2bb","unresolved":false,"context_lines":[{"line_number":213,"context_line":"        LOG.debug(\"ACCESSShareDriver delete_share %s called\","},{"line_number":214,"context_line":"                  sharename)"},{"line_number":215,"context_line":"        if share[\u0027snapshot_id\u0027]:"},{"line_number":216,"context_line":"            message \u003d ((\u0027ACCESSShareDriver delete share %s\u0027"},{"line_number":217,"context_line":"                        \u0027early return\u0027), sharename)"},{"line_number":218,"context_line":"            LOG.debug(message)"},{"line_number":219,"context_line":"            return"},{"line_number":220,"context_line":"        path \u003d self._fs_delete_str"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_be7e0cac","line":217,"range":{"start_line":216,"start_character":58,"end_line":217,"end_character":25},"in_reply_to":"7f287b81_fb53f815","updated":"2017-08-31 14:48:46.000000000","message":"Done","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b811834dc4e3197975c56535fe0e5367169bd07d","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        provider \u003d \u0027%s:%s\u0027 % (self.host, self._port)"},{"line_number":222,"context_line":"        data \u003d {}"},{"line_number":223,"context_line":"        data[\"fs_name\"] \u003d va_sharename"},{"line_number":224,"context_line":"        result \u003d self._access_api(self.session, provider, path,"},{"line_number":225,"context_line":"                                  json.dumps(data), \u0027POST\u0027)"},{"line_number":226,"context_line":"        if not result:"},{"line_number":227,"context_line":"            message \u003d ((\u0027ACCESSShareDriver delete share failed %s\u0027), sharename)"},{"line_number":228,"context_line":"            LOG.error(message)"},{"line_number":229,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        data2 \u003d {\"type\": \"FS\", \"key\": \"manila\"}"},{"line_number":232,"context_line":"        data2[\"id\"] \u003d va_sharename"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_db54bc00","line":229,"range":{"start_line":224,"start_character":0,"end_line":229,"end_character":62},"updated":"2017-08-27 05:41:50.000000000","message":"Is there a possibility the share can already be deleted on the backend? if yes, you should treat NotFound different from other errors. Deleting a share already deleted must not result in an error","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"951c131b76258254e403f4afe9708765c073a2bb","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        provider \u003d \u0027%s:%s\u0027 % (self.host, self._port)"},{"line_number":222,"context_line":"        data \u003d {}"},{"line_number":223,"context_line":"        data[\"fs_name\"] \u003d va_sharename"},{"line_number":224,"context_line":"        result \u003d self._access_api(self.session, provider, path,"},{"line_number":225,"context_line":"                                  json.dumps(data), \u0027POST\u0027)"},{"line_number":226,"context_line":"        if not result:"},{"line_number":227,"context_line":"            message \u003d ((\u0027ACCESSShareDriver delete share failed %s\u0027), sharename)"},{"line_number":228,"context_line":"            LOG.error(message)"},{"line_number":229,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        data2 \u003d {\"type\": \"FS\", \"key\": \"manila\"}"},{"line_number":232,"context_line":"        data2[\"id\"] \u003d va_sharename"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_1e3c00df","line":229,"range":{"start_line":224,"start_character":0,"end_line":229,"end_character":62},"in_reply_to":"7f287b81_db54bc00","updated":"2017-08-31 14:48:46.000000000","message":"Added \u0027_is_item_exist_at_va_backend\u0027 functionality to check if share is present at backend.","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b811834dc4e3197975c56535fe0e5367169bd07d","unresolved":false,"context_lines":[{"line_number":251,"context_line":"            LOG.error(message)"},{"line_number":252,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"        LOG.debug(\u0027ACCESSShareDriver extend share successfully %s\u0027, sharename)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def shrink_share(self, share, new_size, share_server\u003dNone):"},{"line_number":257,"context_line":"        \"\"\"Shrink existing share to new size.\"\"\""}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_7b3f08b4","line":254,"range":{"start_line":254,"start_character":37,"end_line":254,"end_character":43},"updated":"2017-08-27 05:41:50.000000000","message":"extended?","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"951c131b76258254e403f4afe9708765c073a2bb","unresolved":false,"context_lines":[{"line_number":251,"context_line":"            LOG.error(message)"},{"line_number":252,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"        LOG.debug(\u0027ACCESSShareDriver extend share successfully %s\u0027, sharename)"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    def shrink_share(self, share, new_size, share_server\u003dNone):"},{"line_number":257,"context_line":"        \"\"\"Shrink existing share to new size.\"\"\""}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_5e1f286b","line":254,"range":{"start_line":254,"start_character":37,"end_line":254,"end_character":43},"in_reply_to":"7f287b81_7b3f08b4","updated":"2017-08-31 14:48:46.000000000","message":"Done","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b811834dc4e3197975c56535fe0e5367169bd07d","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            LOG.error(message)"},{"line_number":271,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        LOG.debug(\u0027ACCESSShareDriver shrink share successfully %s\u0027, sharename)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    def allow_access(self, context, share, access, share_server\u003dNone):"},{"line_number":276,"context_line":"        \"\"\"Give access of a share to an IP.\"\"\""}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_5b48cc5a","line":273,"range":{"start_line":273,"start_character":37,"end_line":273,"end_character":43},"updated":"2017-08-27 05:41:50.000000000","message":"shrunk","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"951c131b76258254e403f4afe9708765c073a2bb","unresolved":false,"context_lines":[{"line_number":270,"context_line":"            LOG.error(message)"},{"line_number":271,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        LOG.debug(\u0027ACCESSShareDriver shrink share successfully %s\u0027, sharename)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    def allow_access(self, context, share, access, share_server\u003dNone):"},{"line_number":276,"context_line":"        \"\"\"Give access of a share to an IP.\"\"\""}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_3907d61a","line":273,"range":{"start_line":273,"start_character":37,"end_line":273,"end_character":43},"in_reply_to":"7f287b81_5b48cc5a","updated":"2017-08-31 14:48:46.000000000","message":"Done","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b811834dc4e3197975c56535fe0e5367169bd07d","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        LOG.debug(\u0027ACCESSShareDriver shrink share successfully %s\u0027, sharename)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    def allow_access(self, context, share, access, share_server\u003dNone):"},{"line_number":276,"context_line":"        \"\"\"Give access of a share to an IP.\"\"\""},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"        access_type \u003d access[\u0027access_type\u0027]"},{"line_number":279,"context_line":"        server \u003d access[\u0027access_to\u0027]"},{"line_number":280,"context_line":"        if access_type !\u003d \u0027ip\u0027:"},{"line_number":281,"context_line":"            raise exception.InvalidShareAccess(\u0027Only ip access type \u0027"},{"line_number":282,"context_line":"                                               \u0027supported.\u0027)"},{"line_number":283,"context_line":"        access_level \u003d access[\u0027access_level\u0027]"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        if access_level not in (const.ACCESS_LEVEL_RW, const.ACCESS_LEVEL_RO):"},{"line_number":286,"context_line":"            raise exception.InvalidShareAccessLevel(level\u003daccess_level)"},{"line_number":287,"context_line":"        export_path \u003d share[\u0027export_locations\u0027][0][\u0027path\u0027].split(\u0027:\u0027, 1)"},{"line_number":288,"context_line":"        va_sharepath \u003d six.text_type(export_path[1])"},{"line_number":289,"context_line":"        access_level \u003d \u0027%s,%s\u0027 % (six.text_type(access_level),"},{"line_number":290,"context_line":"                                  \u0027sync,no_root_squash\u0027)"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        path \u003d self._nfs_add_str"},{"line_number":293,"context_line":"        provider \u003d \u0027%s:%s\u0027 % (self.host, self._port)"},{"line_number":294,"context_line":"        data \u003d {}"},{"line_number":295,"context_line":"        str1 \u003d (\"{\\\"share\\\":[{\\\"fileSystemPath\\\":\\\"\"+va_sharepath +"},{"line_number":296,"context_line":"                \"\\\",\\\"shareType\\\":\\\"NFS\\\",\\\"shareDetails\\\":\" +"},{"line_number":297,"context_line":"                \"[{\\\"client\\\":\\\"\"+server+\"\\\",\\\"exportOptions\\\":\\\"\" +"},{"line_number":298,"context_line":"                access_level+\"\\\"}]}]}\")"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"        data[\"shareDetails\"] \u003d str1"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        result \u003d self._access_api(self.session, provider, path,"},{"line_number":303,"context_line":"                                  json.dumps(data), \u0027POST\u0027)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"        if not result:"},{"line_number":306,"context_line":"            message \u003d ((\u0027ACCESSShareDriver access failed sharepath %s\u0027"},{"line_number":307,"context_line":"                        \u0027server %s\u0027),"},{"line_number":308,"context_line":"                       va_sharepath,"},{"line_number":309,"context_line":"                       server)"},{"line_number":310,"context_line":"            LOG.error(message)"},{"line_number":311,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        LOG.debug(\"ACCESSShareDriver allow_access sharepath %s server %s\","},{"line_number":314,"context_line":"                  va_sharepath, server)"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        data2 \u003d {\"type\": \"SHARE\", \"key\": \"manila\"}"},{"line_number":317,"context_line":"        data2[\"id\"] \u003d va_sharepath"},{"line_number":318,"context_line":"        data2[\"value\"] \u003d \u0027manila_share\u0027"},{"line_number":319,"context_line":"        path \u003d self._update_object"},{"line_number":320,"context_line":"        result \u003d self._access_api(self.session, provider, path,"},{"line_number":321,"context_line":"                                  json.dumps(data2), \u0027POST\u0027)"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    def deny_access(self, context, share, access, share_server\u003dNone):"},{"line_number":324,"context_line":"        \"\"\"Deny access to the share.\"\"\""},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"        server \u003d access[\u0027access_to\u0027]"},{"line_number":327,"context_line":"        export_path \u003d share[\u0027export_locations\u0027][0][\u0027path\u0027].split(\u0027:\u0027, 1)"},{"line_number":328,"context_line":"        va_sharepath \u003d six.text_type(export_path[1])"},{"line_number":329,"context_line":"        LOG.debug(\"ACCESSShareDriver deny_access sharepath %s server %s\","},{"line_number":330,"context_line":"                  va_sharepath, server)"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"        path \u003d self._nfs_delete_str"},{"line_number":333,"context_line":"        provider \u003d \u0027%s:%s\u0027 % (self.host, self._port)"},{"line_number":334,"context_line":"        data \u003d {}"},{"line_number":335,"context_line":"        str1 \u003d (\"{\\\"share\\\":[{\\\"fileSystemPath\\\":\\\"\"+va_sharepath +"},{"line_number":336,"context_line":"                \"\\\",\\\"shareType\\\":\\\"NFS\\\",\\\"shareDetails\\\":\" +"},{"line_number":337,"context_line":"                \"[{\\\"client\\\":\\\"\"+server+\"\\\"}]}]}\")"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"        data[\"shareDetails\"] \u003d str1"},{"line_number":340,"context_line":"        result \u003d self._access_api(self.session, provider, path,"},{"line_number":341,"context_line":"                                  json.dumps(data), \u0027DELETE\u0027)"},{"line_number":342,"context_line":"        if not result:"},{"line_number":343,"context_line":"            message \u003d ((\u0027ACCESSShareDriver deny failed\u0027"},{"line_number":344,"context_line":"                        \u0027sharepath %s server %s\u0027),"},{"line_number":345,"context_line":"                       va_sharepath,"},{"line_number":346,"context_line":"                       server)"},{"line_number":347,"context_line":"            LOG.error(message)"},{"line_number":348,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"        LOG.debug(\"ACCESSShareDriver deny_access sharepath %s server %s\","},{"line_number":351,"context_line":"                  va_sharepath, server)"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"        data2 \u003d {\"type\": \"SHARE\", \"key\": \"manila\"}"},{"line_number":354,"context_line":"        data2[\"id\"] \u003d va_sharepath"},{"line_number":355,"context_line":"        path \u003d self._update_object"},{"line_number":356,"context_line":"        result \u003d self._access_api(self.session, provider, path,"},{"line_number":357,"context_line":"                                  json.dumps(data2), \u0027DELETE\u0027)"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":360,"context_line":"        \"\"\"create snapshot of a share.\"\"\""}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_3b450044","line":357,"range":{"start_line":275,"start_character":4,"end_line":357,"end_character":62},"updated":"2017-08-27 05:41:50.000000000","message":"Both these interfaces have been deprecated in favor of update_access. Please implement that interface instead.","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"951c131b76258254e403f4afe9708765c073a2bb","unresolved":false,"context_lines":[{"line_number":272,"context_line":""},{"line_number":273,"context_line":"        LOG.debug(\u0027ACCESSShareDriver shrink share successfully %s\u0027, sharename)"},{"line_number":274,"context_line":""},{"line_number":275,"context_line":"    def allow_access(self, context, share, access, share_server\u003dNone):"},{"line_number":276,"context_line":"        \"\"\"Give access of a share to an IP.\"\"\""},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"        access_type \u003d access[\u0027access_type\u0027]"},{"line_number":279,"context_line":"        server \u003d access[\u0027access_to\u0027]"},{"line_number":280,"context_line":"        if access_type !\u003d \u0027ip\u0027:"},{"line_number":281,"context_line":"            raise exception.InvalidShareAccess(\u0027Only ip access type \u0027"},{"line_number":282,"context_line":"                                               \u0027supported.\u0027)"},{"line_number":283,"context_line":"        access_level \u003d access[\u0027access_level\u0027]"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        if access_level not in (const.ACCESS_LEVEL_RW, const.ACCESS_LEVEL_RO):"},{"line_number":286,"context_line":"            raise exception.InvalidShareAccessLevel(level\u003daccess_level)"},{"line_number":287,"context_line":"        export_path \u003d share[\u0027export_locations\u0027][0][\u0027path\u0027].split(\u0027:\u0027, 1)"},{"line_number":288,"context_line":"        va_sharepath \u003d six.text_type(export_path[1])"},{"line_number":289,"context_line":"        access_level \u003d \u0027%s,%s\u0027 % (six.text_type(access_level),"},{"line_number":290,"context_line":"                                  \u0027sync,no_root_squash\u0027)"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"        path \u003d self._nfs_add_str"},{"line_number":293,"context_line":"        provider \u003d \u0027%s:%s\u0027 % (self.host, self._port)"},{"line_number":294,"context_line":"        data \u003d {}"},{"line_number":295,"context_line":"        str1 \u003d (\"{\\\"share\\\":[{\\\"fileSystemPath\\\":\\\"\"+va_sharepath +"},{"line_number":296,"context_line":"                \"\\\",\\\"shareType\\\":\\\"NFS\\\",\\\"shareDetails\\\":\" +"},{"line_number":297,"context_line":"                \"[{\\\"client\\\":\\\"\"+server+\"\\\",\\\"exportOptions\\\":\\\"\" +"},{"line_number":298,"context_line":"                access_level+\"\\\"}]}]}\")"},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"        data[\"shareDetails\"] \u003d str1"},{"line_number":301,"context_line":""},{"line_number":302,"context_line":"        result \u003d self._access_api(self.session, provider, path,"},{"line_number":303,"context_line":"                                  json.dumps(data), \u0027POST\u0027)"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"        if not result:"},{"line_number":306,"context_line":"            message \u003d ((\u0027ACCESSShareDriver access failed sharepath %s\u0027"},{"line_number":307,"context_line":"                        \u0027server %s\u0027),"},{"line_number":308,"context_line":"                       va_sharepath,"},{"line_number":309,"context_line":"                       server)"},{"line_number":310,"context_line":"            LOG.error(message)"},{"line_number":311,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":312,"context_line":""},{"line_number":313,"context_line":"        LOG.debug(\"ACCESSShareDriver allow_access sharepath %s server %s\","},{"line_number":314,"context_line":"                  va_sharepath, server)"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"        data2 \u003d {\"type\": \"SHARE\", \"key\": \"manila\"}"},{"line_number":317,"context_line":"        data2[\"id\"] \u003d va_sharepath"},{"line_number":318,"context_line":"        data2[\"value\"] \u003d \u0027manila_share\u0027"},{"line_number":319,"context_line":"        path \u003d self._update_object"},{"line_number":320,"context_line":"        result \u003d self._access_api(self.session, provider, path,"},{"line_number":321,"context_line":"                                  json.dumps(data2), \u0027POST\u0027)"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    def deny_access(self, context, share, access, share_server\u003dNone):"},{"line_number":324,"context_line":"        \"\"\"Deny access to the share.\"\"\""},{"line_number":325,"context_line":""},{"line_number":326,"context_line":"        server \u003d access[\u0027access_to\u0027]"},{"line_number":327,"context_line":"        export_path \u003d share[\u0027export_locations\u0027][0][\u0027path\u0027].split(\u0027:\u0027, 1)"},{"line_number":328,"context_line":"        va_sharepath \u003d six.text_type(export_path[1])"},{"line_number":329,"context_line":"        LOG.debug(\"ACCESSShareDriver deny_access sharepath %s server %s\","},{"line_number":330,"context_line":"                  va_sharepath, server)"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"        path \u003d self._nfs_delete_str"},{"line_number":333,"context_line":"        provider \u003d \u0027%s:%s\u0027 % (self.host, self._port)"},{"line_number":334,"context_line":"        data \u003d {}"},{"line_number":335,"context_line":"        str1 \u003d (\"{\\\"share\\\":[{\\\"fileSystemPath\\\":\\\"\"+va_sharepath +"},{"line_number":336,"context_line":"                \"\\\",\\\"shareType\\\":\\\"NFS\\\",\\\"shareDetails\\\":\" +"},{"line_number":337,"context_line":"                \"[{\\\"client\\\":\\\"\"+server+\"\\\"}]}]}\")"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"        data[\"shareDetails\"] \u003d str1"},{"line_number":340,"context_line":"        result \u003d self._access_api(self.session, provider, path,"},{"line_number":341,"context_line":"                                  json.dumps(data), \u0027DELETE\u0027)"},{"line_number":342,"context_line":"        if not result:"},{"line_number":343,"context_line":"            message \u003d ((\u0027ACCESSShareDriver deny failed\u0027"},{"line_number":344,"context_line":"                        \u0027sharepath %s server %s\u0027),"},{"line_number":345,"context_line":"                       va_sharepath,"},{"line_number":346,"context_line":"                       server)"},{"line_number":347,"context_line":"            LOG.error(message)"},{"line_number":348,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":349,"context_line":""},{"line_number":350,"context_line":"        LOG.debug(\"ACCESSShareDriver deny_access sharepath %s server %s\","},{"line_number":351,"context_line":"                  va_sharepath, server)"},{"line_number":352,"context_line":""},{"line_number":353,"context_line":"        data2 \u003d {\"type\": \"SHARE\", \"key\": \"manila\"}"},{"line_number":354,"context_line":"        data2[\"id\"] \u003d va_sharepath"},{"line_number":355,"context_line":"        path \u003d self._update_object"},{"line_number":356,"context_line":"        result \u003d self._access_api(self.session, provider, path,"},{"line_number":357,"context_line":"                                  json.dumps(data2), \u0027DELETE\u0027)"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":360,"context_line":"        \"\"\"create snapshot of a share.\"\"\""}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_a00c1041","line":357,"range":{"start_line":275,"start_character":4,"end_line":357,"end_character":62},"in_reply_to":"7f287b81_3b450044","updated":"2017-08-31 14:48:46.000000000","message":"Done","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b811834dc4e3197975c56535fe0e5367169bd07d","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        data \u003d {}"},{"line_number":404,"context_line":"        data[\"name\"] \u003d va_snapname"},{"line_number":405,"context_line":"        data[\"fsName\"] \u003d va_sharename"},{"line_number":406,"context_line":"        data_to_send \u003d {\"snapShotDetails\": {\"snapshot\": [data]}}"},{"line_number":407,"context_line":"        result \u003d self._access_api(self.session, provider, path,"},{"line_number":408,"context_line":"                                  json.dumps(data_to_send), \u0027DELETE\u0027)"},{"line_number":409,"context_line":"        if not result:"},{"line_number":410,"context_line":"            message \u003d ((\u0027ACCESSShareDriver delete snapshot failed snapname %s\u0027"},{"line_number":411,"context_line":"                        \u0027 sharename %s\u0027),"},{"line_number":412,"context_line":"                       snapname,"},{"line_number":413,"context_line":"                       va_sharename)"},{"line_number":414,"context_line":"            LOG.error(message)"},{"line_number":415,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"        data2 \u003d {\"type\": \"SNAPSHOT\", \"key\": \"manila\"}"},{"line_number":418,"context_line":"        data2[\"id\"] \u003d va_snapname"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_1b9da4bb","line":415,"range":{"start_line":406,"start_character":0,"end_line":415,"end_character":62},"updated":"2017-08-27 05:41:50.000000000","message":"same question as delete_share, can you discern if the snapshot is missing from your backend and swallow the error if the snapshot has already been deleted.","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"951c131b76258254e403f4afe9708765c073a2bb","unresolved":false,"context_lines":[{"line_number":403,"context_line":"        data \u003d {}"},{"line_number":404,"context_line":"        data[\"name\"] \u003d va_snapname"},{"line_number":405,"context_line":"        data[\"fsName\"] \u003d va_sharename"},{"line_number":406,"context_line":"        data_to_send \u003d {\"snapShotDetails\": {\"snapshot\": [data]}}"},{"line_number":407,"context_line":"        result \u003d self._access_api(self.session, provider, path,"},{"line_number":408,"context_line":"                                  json.dumps(data_to_send), \u0027DELETE\u0027)"},{"line_number":409,"context_line":"        if not result:"},{"line_number":410,"context_line":"            message \u003d ((\u0027ACCESSShareDriver delete snapshot failed snapname %s\u0027"},{"line_number":411,"context_line":"                        \u0027 sharename %s\u0027),"},{"line_number":412,"context_line":"                       snapname,"},{"line_number":413,"context_line":"                       va_sharename)"},{"line_number":414,"context_line":"            LOG.error(message)"},{"line_number":415,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"        data2 \u003d {\"type\": \"SNAPSHOT\", \"key\": \"manila\"}"},{"line_number":418,"context_line":"        data2[\"id\"] \u003d va_snapname"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_792afe7e","line":415,"range":{"start_line":406,"start_character":0,"end_line":415,"end_character":62},"in_reply_to":"7f287b81_1b9da4bb","updated":"2017-08-31 14:48:46.000000000","message":"Added \u0027_is_item_exist_at_va_backend\u0027 functionality to check if snapshot is present at backend.","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b811834dc4e3197975c56535fe0e5367169bd07d","unresolved":false,"context_lines":[{"line_number":420,"context_line":"        result \u003d self._access_api(self.session, provider, path,"},{"line_number":421,"context_line":"                                  json.dumps(data2), \u0027DELETE\u0027)"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    def get_network_allocations_number(self):"},{"line_number":424,"context_line":"        return 0"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    def create_share_from_snapshot(self, ctx, share, snapshot,"},{"line_number":427,"context_line":"                                   share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_fba1b8f9","line":424,"range":{"start_line":423,"start_character":0,"end_line":424,"end_character":16},"updated":"2017-08-27 05:41:50.000000000","message":"Not required for a DHSS\u003dFalse driver","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"951c131b76258254e403f4afe9708765c073a2bb","unresolved":false,"context_lines":[{"line_number":420,"context_line":"        result \u003d self._access_api(self.session, provider, path,"},{"line_number":421,"context_line":"                                  json.dumps(data2), \u0027DELETE\u0027)"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    def get_network_allocations_number(self):"},{"line_number":424,"context_line":"        return 0"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    def create_share_from_snapshot(self, ctx, share, snapshot,"},{"line_number":427,"context_line":"                                   share_server\u003dNone):"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_d938d2d3","line":424,"range":{"start_line":423,"start_character":0,"end_line":424,"end_character":16},"in_reply_to":"7f287b81_fba1b8f9","updated":"2017-08-31 14:48:46.000000000","message":"Removed","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b811834dc4e3197975c56535fe0e5367169bd07d","unresolved":false,"context_lines":[{"line_number":523,"context_line":"            \u0027free_capacity_gb\u0027: free_capacity,"},{"line_number":524,"context_line":"            \u0027reserved_percentage\u0027: 0,"},{"line_number":525,"context_line":"            \u0027QoS_support\u0027: False,"},{"line_number":526,"context_line":"            \u0027snapshot_support\u0027: True"},{"line_number":527,"context_line":"        }"},{"line_number":528,"context_line":"        super(ACCESSShareDriver, self)._update_share_stats(data)"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_9b9994c5","line":526,"range":{"start_line":526,"start_character":12,"end_line":526,"end_character":36},"updated":"2017-08-27 05:41:50.000000000","message":"\u0027create_share_from_snapshot_support\u0027: True,","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"951c131b76258254e403f4afe9708765c073a2bb","unresolved":false,"context_lines":[{"line_number":523,"context_line":"            \u0027free_capacity_gb\u0027: free_capacity,"},{"line_number":524,"context_line":"            \u0027reserved_percentage\u0027: 0,"},{"line_number":525,"context_line":"            \u0027QoS_support\u0027: False,"},{"line_number":526,"context_line":"            \u0027snapshot_support\u0027: True"},{"line_number":527,"context_line":"        }"},{"line_number":528,"context_line":"        super(ACCESSShareDriver, self)._update_share_stats(data)"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_395596fa","line":526,"range":{"start_line":526,"start_character":12,"end_line":526,"end_character":36},"in_reply_to":"7f287b81_9b9994c5","updated":"2017-08-31 14:48:46.000000000","message":"Done","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6789b181d6769ffccaad70c6a81f4726ce4768c2","unresolved":false,"context_lines":[{"line_number":267,"context_line":"            LOG.error(message)"},{"line_number":268,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        LOG.debug(\u0027ACCESSShareDriver extended share\u0027"},{"line_number":271,"context_line":"                  \u0027successfully %s\u0027, sharename)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    def shrink_share(self, share, new_size, share_server\u003dNone):"},{"line_number":274,"context_line":"        \"\"\"Shrink existing share to new size.\"\"\""}],"source_content_type":"text/x-python","patch_set":30,"id":"7f287b81_c4545724","line":271,"range":{"start_line":270,"start_character":51,"end_line":271,"end_character":19},"updated":"2017-09-01 03:50:18.000000000","message":"space","commit_id":"6dad01d23b92376f51ec4abcbbec695a78ee37d1"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"375befffe9e894f8a9aed17db418768fd8e28576","unresolved":false,"context_lines":[{"line_number":267,"context_line":"            LOG.error(message)"},{"line_number":268,"context_line":"            raise exception.ShareBackendException(msg\u003dmessage)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"        LOG.debug(\u0027ACCESSShareDriver extended share\u0027"},{"line_number":271,"context_line":"                  \u0027successfully %s\u0027, sharename)"},{"line_number":272,"context_line":""},{"line_number":273,"context_line":"    def shrink_share(self, share, new_size, share_server\u003dNone):"},{"line_number":274,"context_line":"        \"\"\"Shrink existing share to new size.\"\"\""}],"source_content_type":"text/x-python","patch_set":30,"id":"7f287b81_3caafa18","line":271,"range":{"start_line":270,"start_character":51,"end_line":271,"end_character":19},"in_reply_to":"7f287b81_c4545724","updated":"2017-09-02 17:35:33.000000000","message":"Done","commit_id":"6dad01d23b92376f51ec4abcbbec695a78ee37d1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e631d0e72965a1062cda270af6c0d9a2dbb6b69f","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    def _get_va_share_path(self, name):"},{"line_number":151,"context_line":"        return self.VA_SHARE_PATH_STR + name"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def _is_item_exist_at_va_backend(self, item_name, path_given):"},{"line_number":154,"context_line":"        \"\"\"Check given share is exists on backend\"\"\""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        path \u003d path_given"}],"source_content_type":"text/x-python","patch_set":31,"id":"7f287b81_7c23e2bf","line":153,"range":{"start_line":153,"start_character":9,"end_line":153,"end_character":11},"updated":"2017-09-02 19:13:02.000000000","message":"nit: does","commit_id":"f7c47fe297a9e755699a7467655ab556620b98a5"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"d52f20ce4fea779d96e59d71645bea0c2624ee59","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    def _get_va_share_path(self, name):"},{"line_number":151,"context_line":"        return self.VA_SHARE_PATH_STR + name"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def _is_item_exist_at_va_backend(self, item_name, path_given):"},{"line_number":154,"context_line":"        \"\"\"Check given share is exists on backend\"\"\""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        path \u003d path_given"}],"source_content_type":"text/x-python","patch_set":31,"id":"7f287b81_a85319e2","line":153,"range":{"start_line":153,"start_character":9,"end_line":153,"end_character":11},"in_reply_to":"7f287b81_7c23e2bf","updated":"2017-09-05 11:29:34.000000000","message":"Done","commit_id":"f7c47fe297a9e755699a7467655ab556620b98a5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0cdfa8a11074c2739be3c3609fa6f015ad8b145c","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    def _get_va_share_path(self, name):"},{"line_number":151,"context_line":"        return self.VA_SHARE_PATH_STR + name"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def _is_item_exist_at_va_backend(self, item_name, path_given):"},{"line_number":154,"context_line":"        \"\"\"Check given share is exists on backend\"\"\""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        path \u003d path_given"},{"line_number":157,"context_line":"        provider \u003d \u0027%s:%s\u0027 % (self.host, self._port)"},{"line_number":158,"context_line":"        data \u003d {}"},{"line_number":159,"context_line":"        item_list \u003d self._access_api(self.session, provider, path,"},{"line_number":160,"context_line":"                                     json.dumps(data), \u0027GET\u0027)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        for item in item_list:"},{"line_number":163,"context_line":"            if item[\u0027name\u0027] \u003d\u003d item_name:"},{"line_number":164,"context_line":"                return True"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        return False"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def create_share(self, ctx, share, share_server\u003dNone):"},{"line_number":169,"context_line":"        \"\"\"Create an ACCESS file system that will be represented as share.\"\"\""}],"source_content_type":"text/x-python","patch_set":31,"id":"7f287b81_ed871a61","line":166,"range":{"start_line":153,"start_character":0,"end_line":166,"end_character":20},"updated":"2017-09-03 00:09:59.000000000","message":"Missing unit test coverage: \n\n http://logs.openstack.org/90/472190/31/check/manila-coverage-ubuntu-xenial-nv/512e432/cover/manila_share_drivers_veritas_veritas_isa_py.html#n153","commit_id":"f7c47fe297a9e755699a7467655ab556620b98a5"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"d52f20ce4fea779d96e59d71645bea0c2624ee59","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    def _get_va_share_path(self, name):"},{"line_number":151,"context_line":"        return self.VA_SHARE_PATH_STR + name"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"    def _is_item_exist_at_va_backend(self, item_name, path_given):"},{"line_number":154,"context_line":"        \"\"\"Check given share is exists on backend\"\"\""},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"        path \u003d path_given"},{"line_number":157,"context_line":"        provider \u003d \u0027%s:%s\u0027 % (self.host, self._port)"},{"line_number":158,"context_line":"        data \u003d {}"},{"line_number":159,"context_line":"        item_list \u003d self._access_api(self.session, provider, path,"},{"line_number":160,"context_line":"                                     json.dumps(data), \u0027GET\u0027)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        for item in item_list:"},{"line_number":163,"context_line":"            if item[\u0027name\u0027] \u003d\u003d item_name:"},{"line_number":164,"context_line":"                return True"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        return False"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"    def create_share(self, ctx, share, share_server\u003dNone):"},{"line_number":169,"context_line":"        \"\"\"Create an ACCESS file system that will be represented as share.\"\"\""}],"source_content_type":"text/x-python","patch_set":31,"id":"7f287b81_486275af","line":166,"range":{"start_line":153,"start_character":0,"end_line":166,"end_character":20},"in_reply_to":"7f287b81_ed871a61","updated":"2017-09-05 11:29:34.000000000","message":"Done","commit_id":"f7c47fe297a9e755699a7467655ab556620b98a5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e631d0e72965a1062cda270af6c0d9a2dbb6b69f","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        va_fs_type \u003d self._fstype"},{"line_number":179,"context_line":"        path \u003d self._fs_create_str"},{"line_number":180,"context_line":"        provider \u003d \u0027%s:%s\u0027 % (self.host, self._port)"},{"line_number":181,"context_line":"        data1 \u003d {\"largefs\": \"no\", \"blkSize\": \"blksize\u003d8192\","},{"line_number":182,"context_line":"                 \"pdirEnable\": \"pdir_enable\u003dyes\"}"},{"line_number":183,"context_line":"        data1[\"layout\"] \u003d va_fs_type"},{"line_number":184,"context_line":"        data1[\"fs_name\"] \u003d va_sharename"},{"line_number":185,"context_line":"        data1[\"fs_size\"] \u003d sizestr"}],"source_content_type":"text/x-python","patch_set":31,"id":"7f287b81_fc18f284","line":182,"range":{"start_line":181,"start_character":16,"end_line":182,"end_character":49},"updated":"2017-09-02 19:13:02.000000000","message":"nit: dictionaries must be wrapped if multi-line \n\nhttps://docs.openstack.org/hacking/latest/user/hacking.html#dictionaries-lists","commit_id":"f7c47fe297a9e755699a7467655ab556620b98a5"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"d52f20ce4fea779d96e59d71645bea0c2624ee59","unresolved":false,"context_lines":[{"line_number":178,"context_line":"        va_fs_type \u003d self._fstype"},{"line_number":179,"context_line":"        path \u003d self._fs_create_str"},{"line_number":180,"context_line":"        provider \u003d \u0027%s:%s\u0027 % (self.host, self._port)"},{"line_number":181,"context_line":"        data1 \u003d {\"largefs\": \"no\", \"blkSize\": \"blksize\u003d8192\","},{"line_number":182,"context_line":"                 \"pdirEnable\": \"pdir_enable\u003dyes\"}"},{"line_number":183,"context_line":"        data1[\"layout\"] \u003d va_fs_type"},{"line_number":184,"context_line":"        data1[\"fs_name\"] \u003d va_sharename"},{"line_number":185,"context_line":"        data1[\"fs_size\"] \u003d sizestr"}],"source_content_type":"text/x-python","patch_set":31,"id":"7f287b81_e872417c","line":182,"range":{"start_line":181,"start_character":16,"end_line":182,"end_character":49},"in_reply_to":"7f287b81_fc18f284","updated":"2017-09-05 11:29:34.000000000","message":"Done","commit_id":"f7c47fe297a9e755699a7467655ab556620b98a5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e631d0e72965a1062cda270af6c0d9a2dbb6b69f","unresolved":false,"context_lines":[{"line_number":339,"context_line":""},{"line_number":340,"context_line":"    def _deny_access(self, context, share, access, share_server\u003dNone):"},{"line_number":341,"context_line":"        \"\"\"Deny access to the share.\"\"\""},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        server \u003d access[\u0027access_to\u0027]"},{"line_number":344,"context_line":"        export_path \u003d share[\u0027export_locations\u0027][0][\u0027path\u0027].split(\u0027:\u0027, 1)"},{"line_number":345,"context_line":"        va_sharepath \u003d six.text_type(export_path[1])"}],"source_content_type":"text/x-python","patch_set":31,"id":"7f287b81_3c067a22","line":342,"range":{"start_line":342,"start_character":0,"end_line":342,"end_character":0},"updated":"2017-09-02 19:13:02.000000000","message":"How does line 357 behave with an invalid access-type?\nIf it raises an error on line 359, i suggest checking early if invalid access-type, i.e, user, cephx etc, and returning without raising an exception. \n\nThat way, you can allow a user recovering from an error.\n\nSee:\n\nhttps://github.com/openstack/manila/blob/fb17422/manila/share/driver.py#L707\nhttps://github.com/openstack/manila/blob/fb17422/manila/share/driver.py#L768","commit_id":"f7c47fe297a9e755699a7467655ab556620b98a5"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"d52f20ce4fea779d96e59d71645bea0c2624ee59","unresolved":false,"context_lines":[{"line_number":339,"context_line":""},{"line_number":340,"context_line":"    def _deny_access(self, context, share, access, share_server\u003dNone):"},{"line_number":341,"context_line":"        \"\"\"Deny access to the share.\"\"\""},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        server \u003d access[\u0027access_to\u0027]"},{"line_number":344,"context_line":"        export_path \u003d share[\u0027export_locations\u0027][0][\u0027path\u0027].split(\u0027:\u0027, 1)"},{"line_number":345,"context_line":"        va_sharepath \u003d six.text_type(export_path[1])"}],"source_content_type":"text/x-python","patch_set":31,"id":"7f287b81_280e09e5","line":342,"range":{"start_line":342,"start_character":0,"end_line":342,"end_character":0},"in_reply_to":"7f287b81_3c067a22","updated":"2017-09-05 11:29:34.000000000","message":"Done","commit_id":"f7c47fe297a9e755699a7467655ab556620b98a5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e631d0e72965a1062cda270af6c0d9a2dbb6b69f","unresolved":false,"context_lines":[{"line_number":378,"context_line":"        \"\"\"Update access to the share.\"\"\""},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"        # deleting rules"},{"line_number":381,"context_line":"        for rule in delete_rules:"},{"line_number":382,"context_line":"            self._deny_access(context, share, rule, share_server)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        # adding rules"},{"line_number":385,"context_line":"        for rule in add_rules:"},{"line_number":386,"context_line":"            self._allow_access(context, share, rule, share_server)"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":389,"context_line":"        \"\"\"create snapshot of a share.\"\"\""}],"source_content_type":"text/x-python","patch_set":31,"id":"7f287b81_8f2bee2e","line":386,"range":{"start_line":381,"start_character":0,"end_line":386,"end_character":66},"updated":"2017-09-02 19:13:02.000000000","message":"When migrating, the share manager will call the driver to cast all existing access rules to read-only. In that situation, \"add_rules\" and \"delete_rules\" will be empty.. and \"access_rules\" will contain all the existing access rules, modified to \"ro\". \n\nSo, you\u0027ll need to compensate for that in the driver. Can you change a rule from rw to ro without disruption, i.e, is your API idempotent? \n\nEx:\n     IP address 10.45.66.187 has r/w access\n\n    Administrator decides to migrate the share\n    manila asks the driver to switch  10.45.66.187 to r/o access","commit_id":"f7c47fe297a9e755699a7467655ab556620b98a5"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"d52f20ce4fea779d96e59d71645bea0c2624ee59","unresolved":false,"context_lines":[{"line_number":378,"context_line":"        \"\"\"Update access to the share.\"\"\""},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"        # deleting rules"},{"line_number":381,"context_line":"        for rule in delete_rules:"},{"line_number":382,"context_line":"            self._deny_access(context, share, rule, share_server)"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"        # adding rules"},{"line_number":385,"context_line":"        for rule in add_rules:"},{"line_number":386,"context_line":"            self._allow_access(context, share, rule, share_server)"},{"line_number":387,"context_line":""},{"line_number":388,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":389,"context_line":"        \"\"\"create snapshot of a share.\"\"\""}],"source_content_type":"text/x-python","patch_set":31,"id":"7f287b81_682d3145","line":386,"range":{"start_line":381,"start_character":0,"end_line":386,"end_character":66},"in_reply_to":"7f287b81_8f2bee2e","updated":"2017-09-05 11:29:34.000000000","message":"Included \u0027_fetch_existing_rule\u0027 and \u0027return_access_lists_difference\u0027 functionality to cover this","commit_id":"f7c47fe297a9e755699a7467655ab556620b98a5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0cdfa8a11074c2739be3c3609fa6f015ad8b145c","unresolved":false,"context_lines":[{"line_number":499,"context_line":"                                   json.dumps(data), \u0027GET\u0027)"},{"line_number":500,"context_line":"        return ip_list"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"    def _authenticate_access(self, address, username, password):"},{"line_number":503,"context_line":"        session \u003d requests.session()"},{"line_number":504,"context_line":"        session.verify \u003d False"},{"line_number":505,"context_line":"        session.auth \u003d NoAuth()"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"        response \u003d session.post(\u0027https://%s:%s/api/rest/authenticate\u0027"},{"line_number":508,"context_line":"                                % (address, self._port),"},{"line_number":509,"context_line":"                                data\u003d{\u0027username\u0027: username,"},{"line_number":510,"context_line":"                                      \u0027password\u0027: password})"},{"line_number":511,"context_line":"        if response.status_code !\u003d http_client.OK:"},{"line_number":512,"context_line":"            LOG.debug((\u0027failed to authenticate to remote cluster at %s as %s\u0027),"},{"line_number":513,"context_line":"                      address, username)"},{"line_number":514,"context_line":"            raise exception.NotAuthorized(\u0027Authentication failure.\u0027)"},{"line_number":515,"context_line":"        result \u003d response.json()"},{"line_number":516,"context_line":"        session.headers.update({\u0027Authorization\u0027: \u0027Bearer {}\u0027"},{"line_number":517,"context_line":"                                .format(result[\u0027token\u0027])})"},{"line_number":518,"context_line":"        session.headers.update({\u0027Content-Type\u0027: \u0027application/json\u0027})"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"        return session"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    def _get_access_pool_details(self):"},{"line_number":523,"context_line":"        \"\"\"Get access pool details.\"\"\""}],"source_content_type":"text/x-python","patch_set":31,"id":"7f287b81_cd7c5e74","line":520,"range":{"start_line":502,"start_character":0,"end_line":520,"end_character":22},"updated":"2017-09-03 00:09:59.000000000","message":"Missing unit test coverage:\n\n http://logs.openstack.org/90/472190/31/check/manila-coverage-ubuntu-xenial-nv/512e432/cover/manila_share_drivers_veritas_veritas_isa_py.html#n502","commit_id":"f7c47fe297a9e755699a7467655ab556620b98a5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0e1e86b66be3d2673ac22102b153dbd929e437a6","unresolved":false,"context_lines":[{"line_number":499,"context_line":"                                   json.dumps(data), \u0027GET\u0027)"},{"line_number":500,"context_line":"        return ip_list"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"    def _authenticate_access(self, address, username, password):"},{"line_number":503,"context_line":"        session \u003d requests.session()"},{"line_number":504,"context_line":"        session.verify \u003d False"},{"line_number":505,"context_line":"        session.auth \u003d NoAuth()"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"        response \u003d session.post(\u0027https://%s:%s/api/rest/authenticate\u0027"},{"line_number":508,"context_line":"                                % (address, self._port),"},{"line_number":509,"context_line":"                                data\u003d{\u0027username\u0027: username,"},{"line_number":510,"context_line":"                                      \u0027password\u0027: password})"},{"line_number":511,"context_line":"        if response.status_code !\u003d http_client.OK:"},{"line_number":512,"context_line":"            LOG.debug((\u0027failed to authenticate to remote cluster at %s as %s\u0027),"},{"line_number":513,"context_line":"                      address, username)"},{"line_number":514,"context_line":"            raise exception.NotAuthorized(\u0027Authentication failure.\u0027)"},{"line_number":515,"context_line":"        result \u003d response.json()"},{"line_number":516,"context_line":"        session.headers.update({\u0027Authorization\u0027: \u0027Bearer {}\u0027"},{"line_number":517,"context_line":"                                .format(result[\u0027token\u0027])})"},{"line_number":518,"context_line":"        session.headers.update({\u0027Content-Type\u0027: \u0027application/json\u0027})"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"        return session"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    def _get_access_pool_details(self):"},{"line_number":523,"context_line":"        \"\"\"Get access pool details.\"\"\""}],"source_content_type":"text/x-python","patch_set":31,"id":"7f287b81_98287de2","line":520,"range":{"start_line":502,"start_character":0,"end_line":520,"end_character":22},"in_reply_to":"7f287b81_a8ab1973","updated":"2017-09-06 20:22:52.000000000","message":"Thanks for the clarification. We require a minimum of 90% code line coverage by unit tests, but your driver has ~96%, so that\u0027s pretty good for me.","commit_id":"f7c47fe297a9e755699a7467655ab556620b98a5"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"d52f20ce4fea779d96e59d71645bea0c2624ee59","unresolved":false,"context_lines":[{"line_number":499,"context_line":"                                   json.dumps(data), \u0027GET\u0027)"},{"line_number":500,"context_line":"        return ip_list"},{"line_number":501,"context_line":""},{"line_number":502,"context_line":"    def _authenticate_access(self, address, username, password):"},{"line_number":503,"context_line":"        session \u003d requests.session()"},{"line_number":504,"context_line":"        session.verify \u003d False"},{"line_number":505,"context_line":"        session.auth \u003d NoAuth()"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"        response \u003d session.post(\u0027https://%s:%s/api/rest/authenticate\u0027"},{"line_number":508,"context_line":"                                % (address, self._port),"},{"line_number":509,"context_line":"                                data\u003d{\u0027username\u0027: username,"},{"line_number":510,"context_line":"                                      \u0027password\u0027: password})"},{"line_number":511,"context_line":"        if response.status_code !\u003d http_client.OK:"},{"line_number":512,"context_line":"            LOG.debug((\u0027failed to authenticate to remote cluster at %s as %s\u0027),"},{"line_number":513,"context_line":"                      address, username)"},{"line_number":514,"context_line":"            raise exception.NotAuthorized(\u0027Authentication failure.\u0027)"},{"line_number":515,"context_line":"        result \u003d response.json()"},{"line_number":516,"context_line":"        session.headers.update({\u0027Authorization\u0027: \u0027Bearer {}\u0027"},{"line_number":517,"context_line":"                                .format(result[\u0027token\u0027])})"},{"line_number":518,"context_line":"        session.headers.update({\u0027Content-Type\u0027: \u0027application/json\u0027})"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"        return session"},{"line_number":521,"context_line":""},{"line_number":522,"context_line":"    def _get_access_pool_details(self):"},{"line_number":523,"context_line":"        \"\"\"Get access pool details.\"\"\""}],"source_content_type":"text/x-python","patch_set":31,"id":"7f287b81_a8ab1973","line":520,"range":{"start_line":502,"start_character":0,"end_line":520,"end_character":22},"in_reply_to":"7f287b81_cd7c5e74","updated":"2017-09-05 11:29:34.000000000","message":"Mocked this function in \u0027def setUp\u0027 itself. So dont know how to cover this.","commit_id":"f7c47fe297a9e755699a7467655ab556620b98a5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e631d0e72965a1062cda270af6c0d9a2dbb6b69f","unresolved":false,"context_lines":[{"line_number":529,"context_line":""},{"line_number":530,"context_line":"        for pool in pool_details:"},{"line_number":531,"context_line":"            if pool[\u0027device_group_name\u0027] \u003d\u003d six.text_type(self._pool):"},{"line_number":532,"context_line":"                total_capacity \u003d (int(pool[\u0027capacity\u0027]) / 1073741824)"},{"line_number":533,"context_line":"                used_size \u003d (int(pool[\u0027used_size\u0027]) / 1073741824)"},{"line_number":534,"context_line":"                return (total_capacity, (total_capacity - used_size))"},{"line_number":535,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"7f287b81_cfbfb6ce","line":532,"range":{"start_line":532,"start_character":58,"end_line":532,"end_character":68},"updated":"2017-09-02 19:13:02.000000000","message":"oslo has this:\n\n from oslo_utils import units\n\n total_capacity \u003d (int(pool[\u0027capacity\u0027]) / units.Gi)","commit_id":"f7c47fe297a9e755699a7467655ab556620b98a5"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"d52f20ce4fea779d96e59d71645bea0c2624ee59","unresolved":false,"context_lines":[{"line_number":529,"context_line":""},{"line_number":530,"context_line":"        for pool in pool_details:"},{"line_number":531,"context_line":"            if pool[\u0027device_group_name\u0027] \u003d\u003d six.text_type(self._pool):"},{"line_number":532,"context_line":"                total_capacity \u003d (int(pool[\u0027capacity\u0027]) / 1073741824)"},{"line_number":533,"context_line":"                used_size \u003d (int(pool[\u0027used_size\u0027]) / 1073741824)"},{"line_number":534,"context_line":"                return (total_capacity, (total_capacity - used_size))"},{"line_number":535,"context_line":""}],"source_content_type":"text/x-python","patch_set":31,"id":"7f287b81_68d2d136","line":532,"range":{"start_line":532,"start_character":58,"end_line":532,"end_character":68},"in_reply_to":"7f287b81_cfbfb6ce","updated":"2017-09-05 11:29:34.000000000","message":"Done","commit_id":"f7c47fe297a9e755699a7467655ab556620b98a5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e631d0e72965a1062cda270af6c0d9a2dbb6b69f","unresolved":false,"context_lines":[{"line_number":553,"context_line":"            \u0027total_capacity_gb\u0027: total_capacity,"},{"line_number":554,"context_line":"            \u0027free_capacity_gb\u0027: free_capacity,"},{"line_number":555,"context_line":"            \u0027reserved_percentage\u0027: 0,"},{"line_number":556,"context_line":"            \u0027QoS_support\u0027: False,"},{"line_number":557,"context_line":"            \u0027create_share_from_snapshot_support\u0027: True"},{"line_number":558,"context_line":"        }"},{"line_number":559,"context_line":"        super(ACCESSShareDriver, self)._update_share_stats(data)"}],"source_content_type":"text/x-python","patch_set":31,"id":"7f287b81_afb46af3","line":556,"range":{"start_line":556,"start_character":32,"end_line":556,"end_character":33},"updated":"2017-09-02 19:13:02.000000000","message":"\u0027snapshot_support\u0027: True,","commit_id":"f7c47fe297a9e755699a7467655ab556620b98a5"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"d52f20ce4fea779d96e59d71645bea0c2624ee59","unresolved":false,"context_lines":[{"line_number":553,"context_line":"            \u0027total_capacity_gb\u0027: total_capacity,"},{"line_number":554,"context_line":"            \u0027free_capacity_gb\u0027: free_capacity,"},{"line_number":555,"context_line":"            \u0027reserved_percentage\u0027: 0,"},{"line_number":556,"context_line":"            \u0027QoS_support\u0027: False,"},{"line_number":557,"context_line":"            \u0027create_share_from_snapshot_support\u0027: True"},{"line_number":558,"context_line":"        }"},{"line_number":559,"context_line":"        super(ACCESSShareDriver, self)._update_share_stats(data)"}],"source_content_type":"text/x-python","patch_set":31,"id":"7f287b81_48d5d51a","line":556,"range":{"start_line":556,"start_character":32,"end_line":556,"end_character":33},"in_reply_to":"7f287b81_afb46af3","updated":"2017-09-05 11:29:34.000000000","message":"Done","commit_id":"f7c47fe297a9e755699a7467655ab556620b98a5"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"5ee69b2c9a9ed2166609addd0bb01b692baaca22","unresolved":false,"context_lines":[{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        sharename \u003d share[\u0027name\u0027]"},{"line_number":214,"context_line":"        sizestr \u003d \u0027%sg\u0027 % share[\u0027size\u0027]"},{"line_number":215,"context_line":"        LOG.debug(\"ACCESSShareDriver create_share sharename %r sizestr %r\","},{"line_number":216,"context_line":"                  sharename, sizestr)"},{"line_number":217,"context_line":"        va_sharename \u003d self._get_va_share_name(sharename)"},{"line_number":218,"context_line":"        va_sharepath \u003d self._get_va_share_path(va_sharename)"}],"source_content_type":"text/x-python","patch_set":33,"id":"5f2577a7_e6c6e949","line":215,"range":{"start_line":215,"start_character":59,"end_line":215,"end_character":63},"updated":"2017-09-13 09:19:23.000000000","message":"The sharename is a string, why don\u0027t just use %s?","commit_id":"dd615b71e182b03505caffe7fffd33d22e2e9057"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"1b381f816ce7f8e6423610fd47f0563e5d9db2df","unresolved":false,"context_lines":[{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        sharename \u003d share[\u0027name\u0027]"},{"line_number":214,"context_line":"        sizestr \u003d \u0027%sg\u0027 % share[\u0027size\u0027]"},{"line_number":215,"context_line":"        LOG.debug(\"ACCESSShareDriver create_share sharename %r sizestr %r\","},{"line_number":216,"context_line":"                  sharename, sizestr)"},{"line_number":217,"context_line":"        va_sharename \u003d self._get_va_share_name(sharename)"},{"line_number":218,"context_line":"        va_sharepath \u003d self._get_va_share_path(va_sharename)"}],"source_content_type":"text/x-python","patch_set":33,"id":"5f2577a7_fd0c333c","line":215,"range":{"start_line":215,"start_character":59,"end_line":215,"end_character":63},"in_reply_to":"5f2577a7_e6c6e949","updated":"2017-09-13 14:13:25.000000000","message":"Done","commit_id":"dd615b71e182b03505caffe7fffd33d22e2e9057"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"5ee69b2c9a9ed2166609addd0bb01b692baaca22","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        data1[\"layout\"] \u003d va_fs_type"},{"line_number":229,"context_line":"        data1[\"fs_name\"] \u003d va_sharename"},{"line_number":230,"context_line":"        data1[\"fs_size\"] \u003d sizestr"},{"line_number":231,"context_line":"        data1[\"pool_disks\"] \u003d va_pool"},{"line_number":232,"context_line":"        result \u003d self._access_api(self.session, provider, path,"},{"line_number":233,"context_line":"                                  json.dumps(data1), \u0027POST\u0027)"},{"line_number":234,"context_line":"        if not result:"}],"source_content_type":"text/x-python","patch_set":33,"id":"5f2577a7_26eab1ab","line":231,"range":{"start_line":231,"start_character":30,"end_line":231,"end_character":37},"updated":"2017-09-13 09:19:23.000000000","message":"It only used it once, you could just use self._pool","commit_id":"dd615b71e182b03505caffe7fffd33d22e2e9057"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"1b381f816ce7f8e6423610fd47f0563e5d9db2df","unresolved":false,"context_lines":[{"line_number":228,"context_line":"        data1[\"layout\"] \u003d va_fs_type"},{"line_number":229,"context_line":"        data1[\"fs_name\"] \u003d va_sharename"},{"line_number":230,"context_line":"        data1[\"fs_size\"] \u003d sizestr"},{"line_number":231,"context_line":"        data1[\"pool_disks\"] \u003d va_pool"},{"line_number":232,"context_line":"        result \u003d self._access_api(self.session, provider, path,"},{"line_number":233,"context_line":"                                  json.dumps(data1), \u0027POST\u0027)"},{"line_number":234,"context_line":"        if not result:"}],"source_content_type":"text/x-python","patch_set":33,"id":"5f2577a7_5d00e701","line":231,"range":{"start_line":231,"start_character":30,"end_line":231,"end_character":37},"in_reply_to":"5f2577a7_26eab1ab","updated":"2017-09-13 14:13:25.000000000","message":"Done","commit_id":"dd615b71e182b03505caffe7fffd33d22e2e9057"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"5ee69b2c9a9ed2166609addd0bb01b692baaca22","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        data2[\"id\"] \u003d va_sharename"},{"line_number":241,"context_line":"        data2[\"value\"] \u003d \u0027manila_fs\u0027"},{"line_number":242,"context_line":"        path \u003d self._update_object"},{"line_number":243,"context_line":"        result \u003d self._access_api(self.session, provider, path,"},{"line_number":244,"context_line":"                                  json.dumps(data2), \u0027POST\u0027)"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        vip \u003d self._get_vip()"}],"source_content_type":"text/x-python","patch_set":33,"id":"5f2577a7_e6cb8947","line":243,"range":{"start_line":243,"start_character":8,"end_line":243,"end_character":14},"updated":"2017-09-13 09:19:23.000000000","message":"Do you need to check the result again?","commit_id":"dd615b71e182b03505caffe7fffd33d22e2e9057"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"1b381f816ce7f8e6423610fd47f0563e5d9db2df","unresolved":false,"context_lines":[{"line_number":240,"context_line":"        data2[\"id\"] \u003d va_sharename"},{"line_number":241,"context_line":"        data2[\"value\"] \u003d \u0027manila_fs\u0027"},{"line_number":242,"context_line":"        path \u003d self._update_object"},{"line_number":243,"context_line":"        result \u003d self._access_api(self.session, provider, path,"},{"line_number":244,"context_line":"                                  json.dumps(data2), \u0027POST\u0027)"},{"line_number":245,"context_line":""},{"line_number":246,"context_line":"        vip \u003d self._get_vip()"}],"source_content_type":"text/x-python","patch_set":33,"id":"5f2577a7_61654345","line":243,"range":{"start_line":243,"start_character":8,"end_line":243,"end_character":14},"in_reply_to":"5f2577a7_e6cb8947","updated":"2017-09-13 14:13:25.000000000","message":"No need to check result here again. We are deliberately  not checking here.","commit_id":"dd615b71e182b03505caffe7fffd33d22e2e9057"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"5ee69b2c9a9ed2166609addd0bb01b692baaca22","unresolved":false,"context_lines":[{"line_number":354,"context_line":"        path \u003d self._nfs_add_str"},{"line_number":355,"context_line":"        provider \u003d \u0027%s:%s\u0027 % (self.host, self._port)"},{"line_number":356,"context_line":"        data \u003d {}"},{"line_number":357,"context_line":"        str1 \u003d (\"{\\\"share\\\":[{\\\"fileSystemPath\\\":\\\"\"+va_sharepath +"},{"line_number":358,"context_line":"                \"\\\",\\\"shareType\\\":\\\"NFS\\\",\\\"shareDetails\\\":\" +"},{"line_number":359,"context_line":"                \"[{\\\"client\\\":\\\"\"+server+\"\\\",\\\"exportOptions\\\":\\\"\" +"},{"line_number":360,"context_line":"                access_level+\"\\\"}]}]}\")"}],"source_content_type":"text/x-python","patch_set":33,"id":"5f2577a7_6609d993","line":357,"range":{"start_line":357,"start_character":8,"end_line":357,"end_character":12},"updated":"2017-09-13 09:19:23.000000000","message":"Could you change it to a real mean name?","commit_id":"dd615b71e182b03505caffe7fffd33d22e2e9057"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"1b381f816ce7f8e6423610fd47f0563e5d9db2df","unresolved":false,"context_lines":[{"line_number":354,"context_line":"        path \u003d self._nfs_add_str"},{"line_number":355,"context_line":"        provider \u003d \u0027%s:%s\u0027 % (self.host, self._port)"},{"line_number":356,"context_line":"        data \u003d {}"},{"line_number":357,"context_line":"        str1 \u003d (\"{\\\"share\\\":[{\\\"fileSystemPath\\\":\\\"\"+va_sharepath +"},{"line_number":358,"context_line":"                \"\\\",\\\"shareType\\\":\\\"NFS\\\",\\\"shareDetails\\\":\" +"},{"line_number":359,"context_line":"                \"[{\\\"client\\\":\\\"\"+server+\"\\\",\\\"exportOptions\\\":\\\"\" +"},{"line_number":360,"context_line":"                access_level+\"\\\"}]}]}\")"}],"source_content_type":"text/x-python","patch_set":33,"id":"5f2577a7_dd13b75b","line":357,"range":{"start_line":357,"start_character":8,"end_line":357,"end_character":12},"in_reply_to":"5f2577a7_6609d993","updated":"2017-09-13 14:13:25.000000000","message":"Done","commit_id":"dd615b71e182b03505caffe7fffd33d22e2e9057"}],"manila/share/drivers/veritas_isa.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright 2016 Veritas Technologies LLC."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_e72757b6","line":1,"range":{"start_line":1,"start_character":12,"end_line":1,"end_character":16},"updated":"2017-06-08 11:39:20.000000000","message":"2017?","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":"\"\"\""},{"line_number":15,"context_line":"InfoScale Access Driver for Manila shares."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Config Requirements:"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_2a54f6c9","line":15,"range":{"start_line":15,"start_character":28,"end_line":15,"end_character":29},"updated":"2017-06-08 11:39:20.000000000","message":"m","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":14,"context_line":"\"\"\""},{"line_number":15,"context_line":"InfoScale Access Driver for Manila shares."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Config Requirements:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Limitation:"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_aa400609","line":17,"range":{"start_line":17,"start_character":0,"end_line":17,"end_character":20},"updated":"2017-06-08 11:39:20.000000000","message":"there is nothing within this list, so either remove it or add some contents","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"01610972c95e87f1ccf52b39a9a7f18ebd37ecff","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"from manila import exception"},{"line_number":39,"context_line":"from manila import utils"},{"line_number":40,"context_line":"from manila.i18n import _, _LE, _LI"},{"line_number":41,"context_line":"from manila.share import driver"},{"line_number":42,"context_line":"from manila.common import constants as const"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_751e34bb","line":40,"range":{"start_line":40,"start_character":27,"end_line":40,"end_character":35},"updated":"2017-06-09 03:03:46.000000000","message":"These have been removed","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":45,"context_line":"from oslo_concurrency import processutils"},{"line_number":46,"context_line":"from oslo_serialization import jsonutils"},{"line_number":47,"context_line":"from oslo_utils import excutils"},{"line_number":48,"context_line":"#from oslo_utils import importutils"},{"line_number":49,"context_line":"from oslo_utils import units"},{"line_number":50,"context_line":"from oslo_log import log as logging"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_c72c539b","line":48,"range":{"start_line":48,"start_character":0,"end_line":48,"end_character":35},"updated":"2017-06-08 11:39:20.000000000","message":"remove this if it is not used","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":62,"context_line":""},{"line_number":63,"context_line":"isa_share_opts \u003d ["},{"line_number":64,"context_line":"    cfg.StrOpt(\u0027isa_server_ip\u0027,"},{"line_number":65,"context_line":"               default\u003dNone,"},{"line_number":66,"context_line":"               help\u003d\u0027Console IP of InfoScale Access server\u0027),"},{"line_number":67,"context_line":"    cfg.IntOpt(\u0027isa_port\u0027,"},{"line_number":68,"context_line":"               default\u003d22,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_e74cf777","line":65,"range":{"start_line":65,"start_character":15,"end_line":65,"end_character":28},"updated":"2017-06-08 11:39:20.000000000","message":"no need to set this default","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":63,"context_line":"isa_share_opts \u003d ["},{"line_number":64,"context_line":"    cfg.StrOpt(\u0027isa_server_ip\u0027,"},{"line_number":65,"context_line":"               default\u003dNone,"},{"line_number":66,"context_line":"               help\u003d\u0027Console IP of InfoScale Access server\u0027),"},{"line_number":67,"context_line":"    cfg.IntOpt(\u0027isa_port\u0027,"},{"line_number":68,"context_line":"               default\u003d22,"},{"line_number":69,"context_line":"               help\u003d\u0027InfoScale Access server REST port.\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_67cfc77f","line":66,"range":{"start_line":66,"start_character":57,"end_line":66,"end_character":59},"updated":"2017-06-08 11:39:20.000000000","message":"period","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":68,"context_line":"               default\u003d22,"},{"line_number":69,"context_line":"               help\u003d\u0027InfoScale Access server REST port.\u0027),"},{"line_number":70,"context_line":"    cfg.StrOpt(\u0027isa_user\u0027,"},{"line_number":71,"context_line":"               default\u003dNone,"},{"line_number":72,"context_line":"               help\u003d\u0027InfoScale Access server REST manila login name.\u0027),"},{"line_number":73,"context_line":"    cfg.StrOpt(\u0027isa_pwd\u0027,"},{"line_number":74,"context_line":"               default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_a756ff05","line":71,"range":{"start_line":71,"start_character":15,"end_line":71,"end_character":28},"updated":"2017-06-08 11:39:20.000000000","message":"no need to set this default","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":71,"context_line":"               default\u003dNone,"},{"line_number":72,"context_line":"               help\u003d\u0027InfoScale Access server REST manila login name.\u0027),"},{"line_number":73,"context_line":"    cfg.StrOpt(\u0027isa_pwd\u0027,"},{"line_number":74,"context_line":"               default\u003dNone,"},{"line_number":75,"context_line":"               secret\u003dTrue,"},{"line_number":76,"context_line":"               help\u003d\u0027InfoScale Access server manila password.\u0027),"},{"line_number":77,"context_line":"    cfg.StrOpt(\u0027isa_pool\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_274aef54","line":74,"range":{"start_line":74,"start_character":15,"end_line":74,"end_character":27},"updated":"2017-06-08 11:39:20.000000000","message":"no need to set this default","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":75,"context_line":"               secret\u003dTrue,"},{"line_number":76,"context_line":"               help\u003d\u0027InfoScale Access server manila password.\u0027),"},{"line_number":77,"context_line":"    cfg.StrOpt(\u0027isa_pool\u0027,"},{"line_number":78,"context_line":"               default\u003dNone,"},{"line_number":79,"context_line":"               help\u003d\u0027InfoScale Access storage pool from which shares are served \u0027),"},{"line_number":80,"context_line":"    cfg.StrOpt(\u0027isa_fstype\u0027,"},{"line_number":81,"context_line":"               default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_c77a1387","line":78,"range":{"start_line":78,"start_character":15,"end_line":78,"end_character":28},"updated":"2017-06-08 11:39:20.000000000","message":"no need to set this default","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":76,"context_line":"               help\u003d\u0027InfoScale Access server manila password.\u0027),"},{"line_number":77,"context_line":"    cfg.StrOpt(\u0027isa_pool\u0027,"},{"line_number":78,"context_line":"               default\u003dNone,"},{"line_number":79,"context_line":"               help\u003d\u0027InfoScale Access storage pool from which shares are served \u0027),"},{"line_number":80,"context_line":"    cfg.StrOpt(\u0027isa_fstype\u0027,"},{"line_number":81,"context_line":"               default\u003dNone,"},{"line_number":82,"context_line":"               help\u003d\u0027Type of file system to be created\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_a7a4bf09","line":79,"range":{"start_line":79,"start_character":72,"end_line":79,"end_character":83},"updated":"2017-06-08 11:39:20.000000000","message":"don\u0027t go beyond 79 chars, and add a period","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":78,"context_line":"               default\u003dNone,"},{"line_number":79,"context_line":"               help\u003d\u0027InfoScale Access storage pool from which shares are served \u0027),"},{"line_number":80,"context_line":"    cfg.StrOpt(\u0027isa_fstype\u0027,"},{"line_number":81,"context_line":"               default\u003dNone,"},{"line_number":82,"context_line":"               help\u003d\u0027Type of file system to be created\u0027),"},{"line_number":83,"context_line":"    cfg.BoolOpt(\u0027isa_ssl\u0027, default\u003dNone, help\u003d\u0027SSL\u0027)"},{"line_number":84,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_476603f0","line":81,"range":{"start_line":81,"start_character":15,"end_line":81,"end_character":28},"updated":"2017-06-08 11:39:20.000000000","message":"no need to set this default","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":79,"context_line":"               help\u003d\u0027InfoScale Access storage pool from which shares are served \u0027),"},{"line_number":80,"context_line":"    cfg.StrOpt(\u0027isa_fstype\u0027,"},{"line_number":81,"context_line":"               default\u003dNone,"},{"line_number":82,"context_line":"               help\u003d\u0027Type of file system to be created\u0027),"},{"line_number":83,"context_line":"    cfg.BoolOpt(\u0027isa_ssl\u0027, default\u003dNone, help\u003d\u0027SSL\u0027)"},{"line_number":84,"context_line":"]"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_87badbdb","line":82,"range":{"start_line":82,"start_character":53,"end_line":82,"end_character":55},"updated":"2017-06-08 11:39:20.000000000","message":"period","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":88,"context_line":"CONF.register_opts(isa_share_opts)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"class NoAuth(requests.auth.AuthBase):"},{"line_number":91,"context_line":"    \u0027\u0027\u0027This \"authentication\" handler exists for use with custom authentication"},{"line_number":92,"context_line":"    systems, such as the one for the Access API.  It simply passes the"},{"line_number":93,"context_line":"    Authorization header as-is.  The default authentication handler for"},{"line_number":94,"context_line":"    requests will clobber the Authorization header.\u0027\u0027\u0027"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def __call__(self, r):"},{"line_number":97,"context_line":"        return r"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_67c5878e","line":94,"range":{"start_line":91,"start_character":4,"end_line":94,"end_character":54},"updated":"2017-06-08 11:39:20.000000000","message":"this should be a one liner and then a paragraph below (if such paragraph is need, in this case it looks like it is)","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":99,"context_line":""},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"class ACCESSShareDriver(driver.ExecuteMixin, driver.ShareDriver):"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    \"\"\"ACCESS Share Driver."},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"    Executes commands relating to Manila Shares."}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_27b8af28","line":102,"updated":"2017-06-08 11:39:20.000000000","message":"remove this extra line","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":111,"context_line":"    \"\"\""},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":114,"context_line":"        \"\"\"Do initialization.\"\"\""},{"line_number":115,"context_line":"        super(ACCESSShareDriver, self).__init__(False, *args, **kwargs)"},{"line_number":116,"context_line":"        self.configuration.append_config_values(isa_share_opts)"},{"line_number":117,"context_line":"        self.backend_name \u003d self.configuration.safe_get("}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_e73637b5","line":114,"updated":"2017-06-08 11:39:20.000000000","message":"add an empty line here","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":151,"context_line":"        self._port \u003d self.configuration.isa_port"},{"line_number":152,"context_line":"        self._ssl \u003d self.configuration.isa_ssl"},{"line_number":153,"context_line":"        self._fstype \u003d self.configuration.isa_fstype"},{"line_number":154,"context_line":"        self.session \u003d self._authenticate_access(self._isa_ip, self._user, self._pwd)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def _get_isa_share_name(self, name):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_674a2728","line":154,"range":{"start_line":154,"start_character":72,"end_line":154,"end_character":85},"updated":"2017-06-08 11:39:20.000000000","message":"don\u0027t go beyond 79 chars","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        self._fstype \u003d self.configuration.isa_fstype"},{"line_number":154,"context_line":"        self.session \u003d self._authenticate_access(self._isa_ip, self._user, self._pwd)"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"    def _get_isa_share_name(self, name):"},{"line_number":158,"context_line":"        length \u003d len(name)"},{"line_number":159,"context_line":"        name1 \u003d name[:length / 2]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_27542fca","line":156,"updated":"2017-06-08 11:39:20.000000000","message":"extra line here","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        isa_pool \u003d self._pool"},{"line_number":181,"context_line":"        path \u003d self._fs_create_str"},{"line_number":182,"context_line":"        provider \u003d \u0027%s:%s\u0027 % (self.host, self._port)"},{"line_number":183,"context_line":"        data1 \u003d {\"layout\":\"simple\", \"largefs\": \"no\",\"blkSize\":\"blksize\u003d1024\",\"pdirEnable\":\"pdir_enable\u003dyes\",\"manila\":\"yes\"}"},{"line_number":184,"context_line":"        data1[\"fs_name\"] \u003d isa_sharename"},{"line_number":185,"context_line":"        data1[\"fs_size\"] \u003d sizestr"},{"line_number":186,"context_line":"        data1[\"pool_disks\"] \u003d isa_pool"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_c76453bc","line":183,"range":{"start_line":183,"start_character":64,"end_line":183,"end_character":101},"updated":"2017-06-08 11:39:20.000000000","message":"don\u0027t go beyond 79 chars","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":184,"context_line":"        data1[\"fs_name\"] \u003d isa_sharename"},{"line_number":185,"context_line":"        data1[\"fs_size\"] \u003d sizestr"},{"line_number":186,"context_line":"        data1[\"pool_disks\"] \u003d isa_pool"},{"line_number":187,"context_line":"        result \u003d self._access_api(self.session, provider, path, json.dumps(data1), \u0027POST\u0027)"},{"line_number":188,"context_line":"        if not result:"},{"line_number":189,"context_line":"            message \u003d ("},{"line_number":190,"context_line":"                _(\u0027VeritasNFSDriver delete share failed %s\u0027),sharename)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_a7595fff","line":187,"range":{"start_line":187,"start_character":66,"end_line":187,"end_character":90},"updated":"2017-06-08 11:39:20.000000000","message":"same as above","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        return location"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def _get_vip(self):"},{"line_number":200,"context_line":"        \"\"\"get a virtual IP from ACCESS\"\"\""},{"line_number":201,"context_line":"        ip_list \u003d self._get_access_ips(self.session, self.host)"},{"line_number":202,"context_line":"        for ips in ip_list:"},{"line_number":203,"context_line":"            if ips[\u0027type\u0027] \u003d\u003d \u0027Virtual\u0027 and ips[\u0027status\u0027] \u003d\u003d \u0027ONLINE\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_e7bbd7e2","line":200,"range":{"start_line":200,"start_character":11,"end_line":200,"end_character":12},"updated":"2017-06-08 11:39:20.000000000","message":"G","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":197,"context_line":"        return location"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    def _get_vip(self):"},{"line_number":200,"context_line":"        \"\"\"get a virtual IP from ACCESS\"\"\""},{"line_number":201,"context_line":"        ip_list \u003d self._get_access_ips(self.session, self.host)"},{"line_number":202,"context_line":"        for ips in ip_list:"},{"line_number":203,"context_line":"            if ips[\u0027type\u0027] \u003d\u003d \u0027Virtual\u0027 and ips[\u0027status\u0027] \u003d\u003d \u0027ONLINE\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_279e6f63","line":200,"range":{"start_line":200,"start_character":37,"end_line":200,"end_character":42},"updated":"2017-06-08 11:39:20.000000000","message":"period","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":202,"context_line":"        for ips in ip_list:"},{"line_number":203,"context_line":"            if ips[\u0027type\u0027] \u003d\u003d \u0027Virtual\u0027 and ips[\u0027status\u0027] \u003d\u003d \u0027ONLINE\u0027:"},{"line_number":204,"context_line":"                return str(ips[\u0027ip\u0027])"},{"line_number":205,"context_line":"            "},{"line_number":206,"context_line":"#    def ensure_share(self, context, share, share_server\u003dNone):"},{"line_number":207,"context_line":"#        \"\"\"Might not be needed?\"\"\""},{"line_number":208,"context_line":"#        pass"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_276d4f98","line":205,"range":{"start_line":205,"start_character":3,"end_line":205,"end_character":8},"updated":"2017-06-08 11:39:20.000000000","message":"remove those trailing spaces","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":203,"context_line":"            if ips[\u0027type\u0027] \u003d\u003d \u0027Virtual\u0027 and ips[\u0027status\u0027] \u003d\u003d \u0027ONLINE\u0027:"},{"line_number":204,"context_line":"                return str(ips[\u0027ip\u0027])"},{"line_number":205,"context_line":"            "},{"line_number":206,"context_line":"#    def ensure_share(self, context, share, share_server\u003dNone):"},{"line_number":207,"context_line":"#        \"\"\"Might not be needed?\"\"\""},{"line_number":208,"context_line":"#        pass"},{"line_number":209,"context_line":"#"},{"line_number":210,"context_line":"    def delete_share(self, context, share, share_server\u003dNone):"},{"line_number":211,"context_line":"        \"\"\"Delete a share from ACCESS\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_67f8e7c3","line":208,"range":{"start_line":206,"start_character":0,"end_line":208,"end_character":13},"updated":"2017-06-08 11:39:20.000000000","message":"this method is being refactored in this release, you should take a look at the ensure share spec: https://github.com/openstack/manila-specs/blob/master/specs/pike/ensure-share.rst","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":208,"context_line":"#        pass"},{"line_number":209,"context_line":"#"},{"line_number":210,"context_line":"    def delete_share(self, context, share, share_server\u003dNone):"},{"line_number":211,"context_line":"        \"\"\"Delete a share from ACCESS\"\"\""},{"line_number":212,"context_line":""},{"line_number":213,"context_line":"        sharename \u003d share[\u0027name\u0027]"},{"line_number":214,"context_line":"        isa_sharename \u003d self._get_isa_share_name(sharename)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_a7839f04","line":211,"range":{"start_line":211,"start_character":35,"end_line":211,"end_character":38},"updated":"2017-06-08 11:39:20.000000000","message":"period","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":215,"context_line":"        LOG.debug(\"VeritasNFSDriver delete_share %s called location %s \","},{"line_number":216,"context_line":"                  sharename, share[\u0027export_location\u0027])"},{"line_number":217,"context_line":"        if share[\u0027snapshot_id\u0027]:"},{"line_number":218,"context_line":"            LOG.debug(\"VeritasNFSDriver delete_share early return\")"},{"line_number":219,"context_line":"            return"},{"line_number":220,"context_line":"        path \u003d self._fs_delete_str"},{"line_number":221,"context_line":"        provider \u003d \u0027%s:%s\u0027 % (self.host, self._port)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_c7e1f3d2","line":218,"range":{"start_line":218,"start_character":40,"end_line":218,"end_character":63},"updated":"2017-06-08 11:39:20.000000000","message":"add an id here so it will make more sense as to which share this relates to. Add a period as well","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        provider \u003d \u0027%s:%s\u0027 % (self.host, self._port)"},{"line_number":222,"context_line":"        data \u003d dict()"},{"line_number":223,"context_line":"        data[\"fs_name\"] \u003d isa_sharename"},{"line_number":224,"context_line":"        result \u003d self._access_api(self.session, provider, path, json.dumps(data), \u0027POST\u0027)"},{"line_number":225,"context_line":"        if not result:"},{"line_number":226,"context_line":"            message \u003d ("},{"line_number":227,"context_line":"                _(\u0027VeritasNFSDriver delete share failed %s\u0027),sharename)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_27778f3d","line":224,"range":{"start_line":224,"start_character":74,"end_line":224,"end_character":89},"updated":"2017-06-08 11:39:20.000000000","message":"don\u0027t go beyond 79 chars","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":229,"context_line":"            raise exception.ShareBackendException(message\u003dmessage)"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"    def allow_access(self, context, share, access, share_server\u003dNone):"},{"line_number":232,"context_line":"        \"\"\"Give access of a share to an IP\"\"\""},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        access_type \u003d access[\u0027access_type\u0027]"},{"line_number":235,"context_line":"        server \u003d access[\u0027access_to\u0027]"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_87ebfbae","line":232,"range":{"start_line":232,"start_character":41,"end_line":232,"end_character":44},"updated":"2017-06-08 11:39:20.000000000","message":"period","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":248,"context_line":"        provider \u003d \u0027%s:%s\u0027 % (self.host, self._port)"},{"line_number":249,"context_line":"        data \u003d dict()"},{"line_number":250,"context_line":"        data[\"path\"] \u003d isa_sharepath"},{"line_number":251,"context_line":"        data[\"share_details\"] \u003d [{\"export_options\":access_level,\"client\":server}]"},{"line_number":252,"context_line":"        result \u003d self._access_api(self.session, provider, path, json.dumps(data), \u0027POST\u0027)"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"        if not result:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_87041b7d","line":251,"range":{"start_line":251,"start_character":74,"end_line":251,"end_character":81},"updated":"2017-06-08 11:39:20.000000000","message":"don\u0027t go beyond 79 chars","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":249,"context_line":"        data \u003d dict()"},{"line_number":250,"context_line":"        data[\"path\"] \u003d isa_sharepath"},{"line_number":251,"context_line":"        data[\"share_details\"] \u003d [{\"export_options\":access_level,\"client\":server}]"},{"line_number":252,"context_line":"        result \u003d self._access_api(self.session, provider, path, json.dumps(data), \u0027POST\u0027)"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"        if not result:"},{"line_number":255,"context_line":"            message \u003d ("}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_47f60392","line":252,"range":{"start_line":252,"start_character":72,"end_line":252,"end_character":89},"updated":"2017-06-08 11:39:20.000000000","message":"same as above","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        LOG.debug(\"VeritasNFSDriver allow_access sharepath %s server %s\","},{"line_number":263,"context_line":"                  isa_sharepath, server)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"    def deny_access(self, context, share, access, share_server\u003dNone):"},{"line_number":267,"context_line":"        \"\"\"Deny access to the share.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_27f30fa1","line":264,"updated":"2017-06-08 11:39:20.000000000","message":"remove this extra line","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        data \u003d dict()"},{"line_number":279,"context_line":"        data[\"path\"] \u003d isa_sharepath"},{"line_number":280,"context_line":"        data[\"share_details\"] \u003d [{\"client\":server}]"},{"line_number":281,"context_line":"        result \u003d self._access_api(self.session, provider, path, json.dumps(data), \u0027POST\u0027)"},{"line_number":282,"context_line":"        if not result:"},{"line_number":283,"context_line":"            message \u003d ("},{"line_number":284,"context_line":"                _(\u0027VeritasNFSDriver deny failed sharepath %s server %s\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_8739bb42","line":281,"range":{"start_line":281,"start_character":75,"end_line":281,"end_character":89},"updated":"2017-06-08 11:39:20.000000000","message":"don\u0027t go beyond 79 chars","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":294,"context_line":"    def create_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":295,"context_line":"        \"\"\"create snapshot of a share\"\"\""},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        LOG.debug(\"VeritasNFSDriver create_snapshot called\")"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        LOG.debug(snapshot)"},{"line_number":300,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_c718d3d4","line":297,"range":{"start_line":297,"start_character":57,"end_line":297,"end_character":60},"updated":"2017-06-08 11:39:20.000000000","message":"add a period and an id","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":296,"context_line":""},{"line_number":297,"context_line":"        LOG.debug(\"VeritasNFSDriver create_snapshot called\")"},{"line_number":298,"context_line":""},{"line_number":299,"context_line":"        LOG.debug(snapshot)"},{"line_number":300,"context_line":""},{"line_number":301,"context_line":"        sharename \u003d snapshot[\u0027share_name\u0027]"},{"line_number":302,"context_line":"        isa_sharename \u003d self._get_isa_share_name(sharename)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_8a82e24e","line":299,"range":{"start_line":299,"start_character":8,"end_line":299,"end_character":27},"updated":"2017-06-08 11:39:20.000000000","message":"remove this by adding the id above","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":302,"context_line":"        isa_sharename \u003d self._get_isa_share_name(sharename)"},{"line_number":303,"context_line":"        snapname \u003d snapshot[\u0027name\u0027]"},{"line_number":304,"context_line":"        isa_snapname \u003d self._get_isa_snap_name(snapname)"},{"line_number":305,"context_line":"        "},{"line_number":306,"context_line":"        path \u003d self._snap_create_str"},{"line_number":307,"context_line":"        provider \u003d \u0027%s:%s\u0027 % (self.host, self._port)"},{"line_number":308,"context_line":"        data \u003d dict()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_0745abb3","line":305,"range":{"start_line":305,"start_character":2,"end_line":305,"end_character":6},"updated":"2017-06-08 11:39:20.000000000","message":"remove these trailing spaces","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":309,"context_line":"        data[\"snapShotname\"] \u003d isa_snapname"},{"line_number":310,"context_line":"        data[\"fileSystem\"] \u003d isa_sharename"},{"line_number":311,"context_line":"        data[\"removable\"] \u003d \u0027yes\u0027"},{"line_number":312,"context_line":"        result \u003d self._access_api(self.session, provider, path, json.dumps(data), \u0027PUT\u0027)"},{"line_number":313,"context_line":"        if not result:"},{"line_number":314,"context_line":"            message \u003d ("},{"line_number":315,"context_line":"                _(\u0027VeritasNFSDriver create snapshot failed snapname %s\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_07736b17","line":312,"range":{"start_line":312,"start_character":68,"end_line":312,"end_character":88},"updated":"2017-06-08 11:39:20.000000000","message":"don\u0027t go beyond 79 chars","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":329,"context_line":""},{"line_number":330,"context_line":"        path \u003d self._snap_delete_str"},{"line_number":331,"context_line":"        provider \u003d \u0027%s:%s\u0027 % (self.host, self._port)"},{"line_number":332,"context_line":"        "},{"line_number":333,"context_line":"        data \u003d dict()"},{"line_number":334,"context_line":"        data[\"name\"] \u003d isa_snapname"},{"line_number":335,"context_line":"        data[\"fsName\"] \u003d isa_sharename"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_074c8bc5","line":332,"range":{"start_line":332,"start_character":2,"end_line":332,"end_character":6},"updated":"2017-06-08 11:39:20.000000000","message":"remove these trailing spaces","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":330,"context_line":"        path \u003d self._snap_delete_str"},{"line_number":331,"context_line":"        provider \u003d \u0027%s:%s\u0027 % (self.host, self._port)"},{"line_number":332,"context_line":"        "},{"line_number":333,"context_line":"        data \u003d dict()"},{"line_number":334,"context_line":"        data[\"name\"] \u003d isa_snapname"},{"line_number":335,"context_line":"        data[\"fsName\"] \u003d isa_sharename"},{"line_number":336,"context_line":"        data_to_send \u003d {\"snapShotDetails\":{\"snapshot\":[data]}}"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_0ab5b231","line":333,"range":{"start_line":333,"start_character":15,"end_line":333,"end_character":21},"updated":"2017-06-08 11:39:20.000000000","message":"use {}","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":344,"context_line":"            LOG.error(message)"},{"line_number":345,"context_line":"            raise exception.ShareBackendException(message\u003dmessage)"},{"line_number":346,"context_line":""},{"line_number":347,"context_line":"#"},{"line_number":348,"context_line":"#    def get_network_allocations_number(self):"},{"line_number":349,"context_line":"#        return 0"},{"line_number":350,"context_line":"#"},{"line_number":351,"context_line":"#    def create_share_from_snapshot(self, ctx, share, snapshot,"},{"line_number":352,"context_line":"#                                   share_server\u003dNone):"},{"line_number":353,"context_line":"#        \"\"\"create share from a snapshot.\"\"\""},{"line_number":354,"context_line":"#        sharename \u003d snapshot[\u0027share_name\u0027]"},{"line_number":355,"context_line":"#        isa_sharename \u003d self._get_isa_share_name(sharename)"},{"line_number":356,"context_line":"#        snapname \u003d snapshot[\u0027name\u0027]"},{"line_number":357,"context_line":"#        isa_snapname \u003d self._get_isa_snap_name(snapname)"},{"line_number":358,"context_line":"#        isa_sharepath \u003d self._get_isa_share_path(isa_sharename)"},{"line_number":359,"context_line":"#        LOG.debug("},{"line_number":360,"context_line":"#            _(\u0027VeritasNFSDriver create_share_from_snapshot snapname %s\u0027"},{"line_number":361,"context_line":"#              \u0027 sharename %s\u0027),"},{"line_number":362,"context_line":"#            isa_snapname,"},{"line_number":363,"context_line":"#            isa_sharename)"},{"line_number":364,"context_line":"#        vip \u003d self._get_vip()"},{"line_number":365,"context_line":"#        location \u003d vip + \u0027:\u0027 + isa_sharepath + \u0027:\u0027 + isa_snapname"},{"line_number":366,"context_line":"#        LOG.debug(\"VeritasNFSDriver create_share location %s\", location)"},{"line_number":367,"context_line":"#        return location"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    def _get_api(self, provider, tail):"},{"line_number":370,"context_line":"        api_root \u003d \u0027https://%s/api\u0027 % (provider,)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_47d723c1","line":367,"range":{"start_line":347,"start_character":0,"end_line":367,"end_character":24},"updated":"2017-06-08 11:39:20.000000000","message":"remove this if not needed","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":371,"context_line":"        return api_root + tail"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"    def _access_api(self, session, provider, path, input_data, method):"},{"line_number":374,"context_line":"        \"\"\"Returns False if failure occures\"\"\""},{"line_number":375,"context_line":"        kwargs \u003d { \u0027data\u0027: input_data }"},{"line_number":376,"context_line":"        if not isinstance(input_data, dict):"},{"line_number":377,"context_line":"            kwargs[\u0027headers\u0027] \u003d {\u0027Content-Type\u0027: \u0027application/json\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_6788e7c5","line":374,"range":{"start_line":374,"start_character":36,"end_line":374,"end_character":41},"updated":"2017-06-08 11:39:20.000000000","message":"occurs","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":371,"context_line":"        return api_root + tail"},{"line_number":372,"context_line":""},{"line_number":373,"context_line":"    def _access_api(self, session, provider, path, input_data, method):"},{"line_number":374,"context_line":"        \"\"\"Returns False if failure occures\"\"\""},{"line_number":375,"context_line":"        kwargs \u003d { \u0027data\u0027: input_data }"},{"line_number":376,"context_line":"        if not isinstance(input_data, dict):"},{"line_number":377,"context_line":"            kwargs[\u0027headers\u0027] \u003d {\u0027Content-Type\u0027: \u0027application/json\u0027}"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_67034744","line":374,"range":{"start_line":374,"start_character":42,"end_line":374,"end_character":45},"updated":"2017-06-08 11:39:20.000000000","message":"period","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":387,"context_line":""},{"line_number":388,"context_line":"        path \u003d self._ip_addr_show_str"},{"line_number":389,"context_line":"        provider \u003d \u0027%s:%s\u0027 % (host, self._port)"},{"line_number":390,"context_line":"        data \u003d dict()"},{"line_number":391,"context_line":"        ip_list \u003d self._access_api(session, provider, path, json.dumps(data), \u0027GET\u0027)"},{"line_number":392,"context_line":"        return ip_list"},{"line_number":393,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_47ae032f","line":390,"range":{"start_line":390,"start_character":15,"end_line":390,"end_character":21},"updated":"2017-06-08 11:39:20.000000000","message":"use {}, also you could be use it like json.dumps({}) below","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":388,"context_line":"        path \u003d self._ip_addr_show_str"},{"line_number":389,"context_line":"        provider \u003d \u0027%s:%s\u0027 % (host, self._port)"},{"line_number":390,"context_line":"        data \u003d dict()"},{"line_number":391,"context_line":"        ip_list \u003d self._access_api(session, provider, path, json.dumps(data), \u0027GET\u0027)"},{"line_number":392,"context_line":"        return ip_list"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def _authenticate_access(self, address, username, password):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_87bc1b6a","line":391,"range":{"start_line":391,"start_character":64,"end_line":391,"end_character":84},"updated":"2017-06-08 11:39:20.000000000","message":"don\u0027t go beyond 79 chars","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        session.verify \u003d False"},{"line_number":397,"context_line":"        session.auth \u003d NoAuth()"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"        response \u003d session.post(\u0027https://%s:%s/api/rest/authenticate\u0027 % (address, self._port),"},{"line_number":400,"context_line":"                                data\u003d{\u0027username\u0027: username, \u0027password\u0027: password})"},{"line_number":401,"context_line":"        if response.status_code !\u003d http_client.OK:"},{"line_number":402,"context_line":"            LOG.debug(\u0027failed to authenticate to remote cluster at %s as %s\u0027 %"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_e762b716","line":399,"range":{"start_line":399,"start_character":69,"end_line":399,"end_character":94},"updated":"2017-06-08 11:39:20.000000000","message":"don\u0027t go beyond 79 chars","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":397,"context_line":"        session.auth \u003d NoAuth()"},{"line_number":398,"context_line":""},{"line_number":399,"context_line":"        response \u003d session.post(\u0027https://%s:%s/api/rest/authenticate\u0027 % (address, self._port),"},{"line_number":400,"context_line":"                                data\u003d{\u0027username\u0027: username, \u0027password\u0027: password})"},{"line_number":401,"context_line":"        if response.status_code !\u003d http_client.OK:"},{"line_number":402,"context_line":"            LOG.debug(\u0027failed to authenticate to remote cluster at %s as %s\u0027 %"},{"line_number":403,"context_line":"                              (address, username))"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_c767b325","line":400,"range":{"start_line":400,"start_character":67,"end_line":400,"end_character":82},"updated":"2017-06-08 11:39:20.000000000","message":"don\u0027t go beyond 79 chars","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":403,"context_line":"                              (address, username))"},{"line_number":404,"context_line":"            raise exception.NotAuthorized(\u0027Authentication Failes\u0027)"},{"line_number":405,"context_line":"        result \u003d response.json()"},{"line_number":406,"context_line":"        session.headers.update({\u0027Authorization\u0027: \u0027Bearer {}\u0027.format(result[\u0027token\u0027])})"},{"line_number":407,"context_line":"        session.headers.update({\u0027Content-Type\u0027: \u0027application/json\u0027})"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        return session"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_a76cbf08","line":406,"range":{"start_line":406,"start_character":65,"end_line":406,"end_character":86},"updated":"2017-06-08 11:39:20.000000000","message":"don\u0027t go beyond 79 chars","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":409,"context_line":"        return session"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"    def _get_access_pool_details(self):"},{"line_number":412,"context_line":"        \"\"\"get access pool details\"\"\""},{"line_number":413,"context_line":"        path \u003d self._pool_free_str"},{"line_number":414,"context_line":"        provider \u003d \u0027%s:%s\u0027 % (self.host, self._port)"},{"line_number":415,"context_line":"        data \u003d dict()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_ca9fbab2","line":412,"range":{"start_line":412,"start_character":11,"end_line":412,"end_character":12},"updated":"2017-06-08 11:39:20.000000000","message":"G","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":412,"context_line":"        \"\"\"get access pool details\"\"\""},{"line_number":413,"context_line":"        path \u003d self._pool_free_str"},{"line_number":414,"context_line":"        provider \u003d \u0027%s:%s\u0027 % (self.host, self._port)"},{"line_number":415,"context_line":"        data \u003d dict()"},{"line_number":416,"context_line":"        pool_details \u003d self._access_api(self.session, provider, path, json.dumps(data), \u0027GET\u0027)"},{"line_number":417,"context_line":"        LOG.debug(pool_details)"},{"line_number":418,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_077dabb0","line":415,"range":{"start_line":415,"start_character":15,"end_line":415,"end_character":21},"updated":"2017-06-08 11:39:20.000000000","message":"use {}, also you could be use it like json.dumps({}) below","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":413,"context_line":"        path \u003d self._pool_free_str"},{"line_number":414,"context_line":"        provider \u003d \u0027%s:%s\u0027 % (self.host, self._port)"},{"line_number":415,"context_line":"        data \u003d dict()"},{"line_number":416,"context_line":"        pool_details \u003d self._access_api(self.session, provider, path, json.dumps(data), \u0027GET\u0027)"},{"line_number":417,"context_line":"        LOG.debug(pool_details)"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"        for pool in pool_details:"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_8771bbe3","line":416,"range":{"start_line":416,"start_character":70,"end_line":416,"end_character":94},"updated":"2017-06-08 11:39:20.000000000","message":"don\u0027t go beyond 79 chars","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":414,"context_line":"        provider \u003d \u0027%s:%s\u0027 % (self.host, self._port)"},{"line_number":415,"context_line":"        data \u003d dict()"},{"line_number":416,"context_line":"        pool_details \u003d self._access_api(self.session, provider, path, json.dumps(data), \u0027GET\u0027)"},{"line_number":417,"context_line":"        LOG.debug(pool_details)"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"        for pool in pool_details:"},{"line_number":420,"context_line":"            if pool[\u0027device_group_name\u0027] \u003d\u003d str(self._pool):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_8af782f6","line":417,"range":{"start_line":417,"start_character":8,"end_line":417,"end_character":31},"updated":"2017-06-08 11:39:20.000000000","message":"include a message here instead of only the value","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":417,"context_line":"        LOG.debug(pool_details)"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"        for pool in pool_details:"},{"line_number":420,"context_line":"            if pool[\u0027device_group_name\u0027] \u003d\u003d str(self._pool):"},{"line_number":421,"context_line":"                total_capacity \u003d (int(pool[\u0027capacity\u0027]) / 1073741824)"},{"line_number":422,"context_line":"                used_size \u003d (int(pool[\u0027used_size\u0027]) / 1073741824)"},{"line_number":423,"context_line":"                return (total_capacity,(total_capacity - used_size))"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_072b6b94","line":420,"range":{"start_line":420,"start_character":44,"end_line":420,"end_character":47},"updated":"2017-06-08 11:39:20.000000000","message":"use six.text_type instead of str so it is python 3.5 compatible","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":418,"context_line":""},{"line_number":419,"context_line":"        for pool in pool_details:"},{"line_number":420,"context_line":"            if pool[\u0027device_group_name\u0027] \u003d\u003d str(self._pool):"},{"line_number":421,"context_line":"                total_capacity \u003d (int(pool[\u0027capacity\u0027]) / 1073741824)"},{"line_number":422,"context_line":"                used_size \u003d (int(pool[\u0027used_size\u0027]) / 1073741824)"},{"line_number":423,"context_line":"                return (total_capacity,(total_capacity - used_size))"},{"line_number":424,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_ea75de99","line":421,"range":{"start_line":421,"start_character":58,"end_line":421,"end_character":68},"updated":"2017-06-08 11:39:20.000000000","message":"I believe you could use Units.GB here (or Units.MB, depending on the unit that comes from your backend)","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":419,"context_line":"        for pool in pool_details:"},{"line_number":420,"context_line":"            if pool[\u0027device_group_name\u0027] \u003d\u003d str(self._pool):"},{"line_number":421,"context_line":"                total_capacity \u003d (int(pool[\u0027capacity\u0027]) / 1073741824)"},{"line_number":422,"context_line":"                used_size \u003d (int(pool[\u0027used_size\u0027]) / 1073741824)"},{"line_number":423,"context_line":"                return (total_capacity,(total_capacity - used_size))"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"        raise Exception(\u0027Fetching pool details operation failed\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_6a69cebc","line":422,"range":{"start_line":422,"start_character":55,"end_line":422,"end_character":64},"updated":"2017-06-08 11:39:20.000000000","message":"same as above","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":422,"context_line":"                used_size \u003d (int(pool[\u0027used_size\u0027]) / 1073741824)"},{"line_number":423,"context_line":"                return (total_capacity,(total_capacity - used_size))"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"        raise Exception(\u0027Fetching pool details operation failed\u0027)"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    def _update_share_stats(self):"},{"line_number":428,"context_line":"        \"\"\"Retrieve status info from share volume group.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_470a8326","line":425,"range":{"start_line":425,"start_character":14,"end_line":425,"end_character":23},"updated":"2017-06-08 11:39:20.000000000","message":"ShareBackendException","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":422,"context_line":"                used_size \u003d (int(pool[\u0027used_size\u0027]) / 1073741824)"},{"line_number":423,"context_line":"                return (total_capacity,(total_capacity - used_size))"},{"line_number":424,"context_line":""},{"line_number":425,"context_line":"        raise Exception(\u0027Fetching pool details operation failed\u0027)"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    def _update_share_stats(self):"},{"line_number":428,"context_line":"        \"\"\"Retrieve status info from share volume group.\"\"\""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_e7199788","line":425,"range":{"start_line":425,"start_character":62,"end_line":425,"end_character":65},"updated":"2017-06-08 11:39:20.000000000","message":"period","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":427,"context_line":"    def _update_share_stats(self):"},{"line_number":428,"context_line":"        \"\"\"Retrieve status info from share volume group.\"\"\""},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"        LOG.debug(\"VRTSISA Updating share status\")"},{"line_number":431,"context_line":"        self.host \u003d str(self._isa_ip) "},{"line_number":432,"context_line":" "},{"line_number":433,"context_line":"        self.session \u003d self._authenticate_access(self._isa_ip, self._user, self._pwd)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_8a0d4239","line":430,"range":{"start_line":430,"start_character":47,"end_line":430,"end_character":50},"updated":"2017-06-08 11:39:20.000000000","message":"period","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":428,"context_line":"        \"\"\"Retrieve status info from share volume group.\"\"\""},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"        LOG.debug(\"VRTSISA Updating share status\")"},{"line_number":431,"context_line":"        self.host \u003d str(self._isa_ip) "},{"line_number":432,"context_line":" "},{"line_number":433,"context_line":"        self.session \u003d self._authenticate_access(self._isa_ip, self._user, self._pwd)"},{"line_number":434,"context_line":"        total_capacity,free_capacity \u003d self._get_access_pool_details()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_07048b16","line":431,"range":{"start_line":431,"start_character":37,"end_line":431,"end_character":38},"updated":"2017-06-08 11:39:20.000000000","message":"trailing space","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":429,"context_line":""},{"line_number":430,"context_line":"        LOG.debug(\"VRTSISA Updating share status\")"},{"line_number":431,"context_line":"        self.host \u003d str(self._isa_ip) "},{"line_number":432,"context_line":" "},{"line_number":433,"context_line":"        self.session \u003d self._authenticate_access(self._isa_ip, self._user, self._pwd)"},{"line_number":434,"context_line":"        total_capacity,free_capacity \u003d self._get_access_pool_details()"},{"line_number":435,"context_line":"        data \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_aa080628","line":432,"range":{"start_line":432,"start_character":0,"end_line":432,"end_character":1},"updated":"2017-06-08 11:39:20.000000000","message":"trailing space","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"ebf6e633dd43887ddfef519f43c1378d548e6691","unresolved":false,"context_lines":[{"line_number":432,"context_line":" "},{"line_number":433,"context_line":"        self.session \u003d self._authenticate_access(self._isa_ip, self._user, self._pwd)"},{"line_number":434,"context_line":"        total_capacity,free_capacity \u003d self._get_access_pool_details()"},{"line_number":435,"context_line":"        data \u003d {}"},{"line_number":436,"context_line":"        data[\"share_backend_name\"] \u003d self.backend_name"},{"line_number":437,"context_line":"        data[\"vendor_name\"] \u003d \u0027Veritas\u0027"},{"line_number":438,"context_line":"        data[\"driver_version\"] \u003d \u00271.0\u0027"},{"line_number":439,"context_line":"        data[\"storage_protocol\"] \u003d \u0027NFS\u0027"},{"line_number":440,"context_line":"        data[\u0027total_capacity_gb\u0027] \u003d total_capacity"},{"line_number":441,"context_line":"        data[\u0027free_capacity_gb\u0027] \u003d free_capacity"},{"line_number":442,"context_line":"        data[\u0027reserved_percentage\u0027] \u003d 0"},{"line_number":443,"context_line":"        data[\u0027QoS_support\u0027] \u003d False"},{"line_number":444,"context_line":"        data[\u0027snapshot_support\u0027] \u003d True"},{"line_number":445,"context_line":"        super(ACCESSShareDriver, self)._update_share_stats(data)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf091321_2abf56fc","line":444,"range":{"start_line":435,"start_character":8,"end_line":444,"end_character":39},"updated":"2017-06-08 11:39:20.000000000","message":"you could do\n\ndata \u003d {\n   \u0027share_backend_name\u0027: self.backend_name,\n   ...\n}","commit_id":"52c8b5457c9c22d92b29f0d4b458155d7755807d"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"fb6cc66a26f9d6c9f3aac6f540bf500de1ec2aa4","unresolved":false,"context_lines":[{"line_number":29,"context_line":"from six.moves import http_client"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"from manila.common import constants as const"},{"line_number":32,"context_line":"from manila.share import driver"},{"line_number":33,"context_line":"from manila import exception"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"from oslo_config import cfg"},{"line_number":36,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":5,"id":"7f231b9d_e0ee44eb","line":33,"range":{"start_line":32,"start_character":0,"end_line":33,"end_character":28},"updated":"2017-06-19 10:23:14.000000000","message":"re-order","commit_id":"7c41ccc377a13da9675ed74763f10adababfaecb"}],"manila/tests/share/drivers/veritas/test_veritas_isa.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b3984eb637a66a9f358a606187c1e887b8180883","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self._create_fake_config()"},{"line_number":65,"context_line":"        lcfg \u003d self.configuration"},{"line_number":66,"context_line":"        self._context \u003d context.get_admin_context()"},{"line_number":67,"context_line":"        self._driver \u003d veritas_isa.ACCESSShareDriver(False, configuration\u003dlcfg)"},{"line_number":68,"context_line":"        self._driver.do_setup(self._context)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def _create_fake_config(self):"}],"source_content_type":"text/x-python","patch_set":17,"id":"1f1a1f67_47adb92f","line":67,"range":{"start_line":67,"start_character":52,"end_line":67,"end_character":59},"updated":"2017-07-13 21:47:14.000000000","message":"Where is this being used?","commit_id":"49bd7e98fe756e3230a471bce9830d0681355eb6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b3984eb637a66a9f358a606187c1e887b8180883","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self._create_fake_config()"},{"line_number":65,"context_line":"        lcfg \u003d self.configuration"},{"line_number":66,"context_line":"        self._context \u003d context.get_admin_context()"},{"line_number":67,"context_line":"        self._driver \u003d veritas_isa.ACCESSShareDriver(False, configuration\u003dlcfg)"},{"line_number":68,"context_line":"        self._driver.do_setup(self._context)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def _create_fake_config(self):"}],"source_content_type":"text/x-python","patch_set":17,"id":"1f1a1f67_8744f11c","line":67,"range":{"start_line":67,"start_character":60,"end_line":67,"end_character":78},"updated":"2017-07-13 21:47:14.000000000","message":"where is this being consumed?","commit_id":"49bd7e98fe756e3230a471bce9830d0681355eb6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b3984eb637a66a9f358a606187c1e887b8180883","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        def _safe_get(opt):"},{"line_number":72,"context_line":"            return getattr(self.configuration, opt)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        self.configuration \u003d mock.Mock(spec\u003dconf.Configuration)"},{"line_number":75,"context_line":"        self.configuration.va_server_ip \u003d \u00271.1.1.1\u0027"},{"line_number":76,"context_line":"        self.configuration.va_pool \u003d \u0027pool1\u0027"},{"line_number":77,"context_line":"        self.configuration.va_user \u003d \u0027user\u0027"}],"source_content_type":"text/x-python","patch_set":17,"id":"1f1a1f67_477259e5","line":74,"range":{"start_line":74,"start_character":8,"end_line":74,"end_character":63},"updated":"2017-07-13 21:47:14.000000000","message":"sure. you still need to override the safe_get() from the Configuration class to point to your custom method above;\n\n self.configuration.safe_get \u003d mock.Mock(side_effect\u003d_safe_get)","commit_id":"49bd7e98fe756e3230a471bce9830d0681355eb6"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"901a28ff02b759427f125b9130a7a7e6bee55085","unresolved":false,"context_lines":[{"line_number":14,"context_line":"\"\"\""},{"line_number":15,"context_line":"Unit tests for Veritas Manila driver."},{"line_number":16,"context_line":"\"\"\""},{"line_number":17,"context_line":"import mock"},{"line_number":18,"context_line":"from oslo_config import cfg"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from manila import context"},{"line_number":21,"context_line":"from manila.share import configuration as conf"},{"line_number":22,"context_line":"from manila.share.drivers.veritas import veritas_isa"},{"line_number":23,"context_line":"from manila import test"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"import six"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":21,"id":"1f1a1f67_33805fbf","line":25,"range":{"start_line":17,"start_character":0,"end_line":25,"end_character":10},"updated":"2017-07-18 01:54:35.000000000","message":"These should be changed to the following code, please see the link: https://docs.openstack.org/hacking/latest/user/hacking.html#imports\n\nimport mock\nfrom oslo_config import cfg\nimport six\n\nfrom manila import context\nfrom manila.share import configuration as conf\nfrom manila.share.drivers.veritas import veritas_isa\nfrom manila import test","commit_id":"4ba5c054a1cbb9569f879d312fb05663fc1e19e2"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"6124be40f3b724027981489e58c55d0f4c751eb4","unresolved":false,"context_lines":[{"line_number":14,"context_line":"\"\"\""},{"line_number":15,"context_line":"Unit tests for Veritas Manila driver."},{"line_number":16,"context_line":"\"\"\""},{"line_number":17,"context_line":"import mock"},{"line_number":18,"context_line":"from oslo_config import cfg"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from manila import context"},{"line_number":21,"context_line":"from manila.share import configuration as conf"},{"line_number":22,"context_line":"from manila.share.drivers.veritas import veritas_isa"},{"line_number":23,"context_line":"from manila import test"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"import six"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":21,"id":"1f1a1f67_ce0615cf","line":25,"range":{"start_line":17,"start_character":0,"end_line":25,"end_character":10},"in_reply_to":"1f1a1f67_33805fbf","updated":"2017-07-18 10:33:27.000000000","message":"Done","commit_id":"4ba5c054a1cbb9569f879d312fb05663fc1e19e2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b811834dc4e3197975c56535fe0e5367169bd07d","unresolved":false,"context_lines":[{"line_number":14,"context_line":"\"\"\""},{"line_number":15,"context_line":"Unit tests for Veritas Manila driver."},{"line_number":16,"context_line":"\"\"\""},{"line_number":17,"context_line":"import hashlib"},{"line_number":18,"context_line":"import json"},{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":"import requests"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_7b96e895","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":11},"updated":"2017-08-27 05:41:50.000000000","message":"Separate stdlib imports from third party lib imports with a blank line","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"951c131b76258254e403f4afe9708765c073a2bb","unresolved":false,"context_lines":[{"line_number":14,"context_line":"\"\"\""},{"line_number":15,"context_line":"Unit tests for Veritas Manila driver."},{"line_number":16,"context_line":"\"\"\""},{"line_number":17,"context_line":"import hashlib"},{"line_number":18,"context_line":"import json"},{"line_number":19,"context_line":"import mock"},{"line_number":20,"context_line":"from oslo_config import cfg"},{"line_number":21,"context_line":"import requests"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_fefa54ba","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":11},"in_reply_to":"7f287b81_7b96e895","updated":"2017-08-31 14:48:46.000000000","message":"Done","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b811834dc4e3197975c56535fe0e5367169bd07d","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                          self._context, self.share)"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def test_delete_share_if_share_created_from_snap(self):"},{"line_number":201,"context_line":"        self._driver.delete_share(self._context, self.share3)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def test_create_snapshot(self):"},{"line_number":204,"context_line":"        self.mock_object(self._driver, \u0027_access_api\u0027)"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_5b8fac74","line":201,"range":{"start_line":201,"start_character":8,"end_line":201,"end_character":61},"updated":"2017-08-27 05:41:50.000000000","message":"assert that API calls were not made?","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"951c131b76258254e403f4afe9708765c073a2bb","unresolved":false,"context_lines":[{"line_number":198,"context_line":"                          self._context, self.share)"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def test_delete_share_if_share_created_from_snap(self):"},{"line_number":201,"context_line":"        self._driver.delete_share(self._context, self.share3)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def test_create_snapshot(self):"},{"line_number":204,"context_line":"        self.mock_object(self._driver, \u0027_access_api\u0027)"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_be196c22","line":201,"range":{"start_line":201,"start_character":8,"end_line":201,"end_character":61},"in_reply_to":"7f287b81_5b8fac74","updated":"2017-08-31 14:48:46.000000000","message":"Done","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b811834dc4e3197975c56535fe0e5367169bd07d","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        self._driver.delete_share(self._context, self.share3)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def test_create_snapshot(self):"},{"line_number":204,"context_line":"        self.mock_object(self._driver, \u0027_access_api\u0027)"},{"line_number":205,"context_line":"        self._driver.create_snapshot(self._context, self.snapshot)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def test_create_snapshot_negative(self):"},{"line_number":208,"context_line":"        self.mock_object(self._driver, \u0027_access_api\u0027)"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_1beb6413","line":205,"range":{"start_line":204,"start_character":0,"end_line":205,"end_character":66},"updated":"2017-08-27 05:41:50.000000000","message":"asserts?","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"951c131b76258254e403f4afe9708765c073a2bb","unresolved":false,"context_lines":[{"line_number":201,"context_line":"        self._driver.delete_share(self._context, self.share3)"},{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    def test_create_snapshot(self):"},{"line_number":204,"context_line":"        self.mock_object(self._driver, \u0027_access_api\u0027)"},{"line_number":205,"context_line":"        self._driver.create_snapshot(self._context, self.snapshot)"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"    def test_create_snapshot_negative(self):"},{"line_number":208,"context_line":"        self.mock_object(self._driver, \u0027_access_api\u0027)"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_3ea9fc8e","line":205,"range":{"start_line":204,"start_character":0,"end_line":205,"end_character":66},"in_reply_to":"7f287b81_1beb6413","updated":"2017-08-31 14:48:46.000000000","message":"Done","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b811834dc4e3197975c56535fe0e5367169bd07d","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                          self.snapshot)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    def test_delete_snapshot(self):"},{"line_number":218,"context_line":"        self.mock_object(self._driver, \u0027_access_api\u0027)"},{"line_number":219,"context_line":"        self._driver.delete_snapshot(self._context, self.snapshot)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def test_delete_snapshot_negative(self):"},{"line_number":222,"context_line":"        self.mock_object(self._driver, \u0027_access_api\u0027)"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_fbef781b","line":219,"range":{"start_line":218,"start_character":8,"end_line":219,"end_character":66},"updated":"2017-08-27 05:41:50.000000000","message":"asserts?","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"951c131b76258254e403f4afe9708765c073a2bb","unresolved":false,"context_lines":[{"line_number":215,"context_line":"                          self.snapshot)"},{"line_number":216,"context_line":""},{"line_number":217,"context_line":"    def test_delete_snapshot(self):"},{"line_number":218,"context_line":"        self.mock_object(self._driver, \u0027_access_api\u0027)"},{"line_number":219,"context_line":"        self._driver.delete_snapshot(self._context, self.snapshot)"},{"line_number":220,"context_line":""},{"line_number":221,"context_line":"    def test_delete_snapshot_negative(self):"},{"line_number":222,"context_line":"        self.mock_object(self._driver, \u0027_access_api\u0027)"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_be9ccc69","line":219,"range":{"start_line":218,"start_character":8,"end_line":219,"end_character":66},"in_reply_to":"7f287b81_fbef781b","updated":"2017-08-31 14:48:46.000000000","message":"Done","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b811834dc4e3197975c56535fe0e5367169bd07d","unresolved":false,"context_lines":[{"line_number":228,"context_line":"                          self._context, self.snapshot)"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    def test_allow_access(self):"},{"line_number":231,"context_line":"        self.mock_object(self._driver, \u0027_access_api\u0027)"},{"line_number":232,"context_line":"        self._driver.allow_access(self._context, self.share, self.access)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    def test_allow_access_negative(self):"},{"line_number":235,"context_line":"        self.mock_object(self._driver, \u0027_access_api\u0027)"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_dbf03c00","line":232,"range":{"start_line":231,"start_character":0,"end_line":232,"end_character":73},"updated":"2017-08-27 05:41:50.000000000","message":"asserts?","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"951c131b76258254e403f4afe9708765c073a2bb","unresolved":false,"context_lines":[{"line_number":228,"context_line":"                          self._context, self.snapshot)"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"    def test_allow_access(self):"},{"line_number":231,"context_line":"        self.mock_object(self._driver, \u0027_access_api\u0027)"},{"line_number":232,"context_line":"        self._driver.allow_access(self._context, self.share, self.access)"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"    def test_allow_access_negative(self):"},{"line_number":235,"context_line":"        self.mock_object(self._driver, \u0027_access_api\u0027)"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_de7af821","line":232,"range":{"start_line":231,"start_character":0,"end_line":232,"end_character":73},"in_reply_to":"7f287b81_dbf03c00","updated":"2017-08-31 14:48:46.000000000","message":"Done","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b811834dc4e3197975c56535fe0e5367169bd07d","unresolved":false,"context_lines":[{"line_number":249,"context_line":"                          self._context,"},{"line_number":250,"context_line":"                          self.share, self.access3)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    def test_deny_access(self):"},{"line_number":253,"context_line":"        self.mock_object(self._driver, \u0027_access_api\u0027)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        self._driver.deny_access(self._context, self.share, self.access)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    def test_deny_access_negative(self):"},{"line_number":258,"context_line":"        self.mock_object(self._driver, \u0027_access_api\u0027)"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_bbf570ef","line":255,"range":{"start_line":252,"start_character":0,"end_line":255,"end_character":72},"updated":"2017-08-27 05:41:50.000000000","message":"asserts?","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"951c131b76258254e403f4afe9708765c073a2bb","unresolved":false,"context_lines":[{"line_number":249,"context_line":"                          self._context,"},{"line_number":250,"context_line":"                          self.share, self.access3)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    def test_deny_access(self):"},{"line_number":253,"context_line":"        self.mock_object(self._driver, \u0027_access_api\u0027)"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        self._driver.deny_access(self._context, self.share, self.access)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    def test_deny_access_negative(self):"},{"line_number":258,"context_line":"        self.mock_object(self._driver, \u0027_access_api\u0027)"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_fea494a7","line":255,"range":{"start_line":252,"start_character":0,"end_line":255,"end_character":72},"in_reply_to":"7f287b81_bbf570ef","updated":"2017-08-31 14:48:46.000000000","message":"Done","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b811834dc4e3197975c56535fe0e5367169bd07d","unresolved":false,"context_lines":[{"line_number":262,"context_line":"                          self._context,"},{"line_number":263,"context_line":"                          self.share, self.access)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    def test_extend_share(self):"},{"line_number":266,"context_line":"        self.mock_object(self._driver, \u0027_access_api\u0027)"},{"line_number":267,"context_line":"        new_size \u003d 3"},{"line_number":268,"context_line":"        self._driver.extend_share(self.share, new_size)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    def test_extend_share_negative(self):"},{"line_number":271,"context_line":"        self.mock_object(self._driver, \u0027_access_api\u0027)"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_9bde346b","line":268,"range":{"start_line":265,"start_character":0,"end_line":268,"end_character":55},"updated":"2017-08-27 05:41:50.000000000","message":"asserts?","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"951c131b76258254e403f4afe9708765c073a2bb","unresolved":false,"context_lines":[{"line_number":262,"context_line":"                          self._context,"},{"line_number":263,"context_line":"                          self.share, self.access)"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":"    def test_extend_share(self):"},{"line_number":266,"context_line":"        self.mock_object(self._driver, \u0027_access_api\u0027)"},{"line_number":267,"context_line":"        new_size \u003d 3"},{"line_number":268,"context_line":"        self._driver.extend_share(self.share, new_size)"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"    def test_extend_share_negative(self):"},{"line_number":271,"context_line":"        self.mock_object(self._driver, \u0027_access_api\u0027)"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_beaa8c6d","line":268,"range":{"start_line":265,"start_character":0,"end_line":268,"end_character":55},"in_reply_to":"7f287b81_9bde346b","updated":"2017-08-31 14:48:46.000000000","message":"Done","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b811834dc4e3197975c56535fe0e5367169bd07d","unresolved":false,"context_lines":[{"line_number":276,"context_line":"                          self._driver.extend_share,"},{"line_number":277,"context_line":"                          self.share, new_size)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def test_shrink_share(self):"},{"line_number":280,"context_line":"        self.mock_object(self._driver, \u0027_access_api\u0027)"},{"line_number":281,"context_line":"        new_size \u003d 3"},{"line_number":282,"context_line":"        self._driver.shrink_share(self.share2, new_size)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    def test_shrink_share_negative(self):"},{"line_number":285,"context_line":"        self.mock_object(self._driver, \u0027_access_api\u0027)"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_7bdb887b","line":282,"range":{"start_line":279,"start_character":0,"end_line":282,"end_character":56},"updated":"2017-08-27 05:41:50.000000000","message":"asserts?","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"951c131b76258254e403f4afe9708765c073a2bb","unresolved":false,"context_lines":[{"line_number":276,"context_line":"                          self._driver.extend_share,"},{"line_number":277,"context_line":"                          self.share, new_size)"},{"line_number":278,"context_line":""},{"line_number":279,"context_line":"    def test_shrink_share(self):"},{"line_number":280,"context_line":"        self.mock_object(self._driver, \u0027_access_api\u0027)"},{"line_number":281,"context_line":"        new_size \u003d 3"},{"line_number":282,"context_line":"        self._driver.shrink_share(self.share2, new_size)"},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    def test_shrink_share_negative(self):"},{"line_number":285,"context_line":"        self.mock_object(self._driver, \u0027_access_api\u0027)"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_9ebeb0ab","line":282,"range":{"start_line":279,"start_character":0,"end_line":282,"end_character":56},"in_reply_to":"7f287b81_7bdb887b","updated":"2017-08-31 14:48:46.000000000","message":"Done","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b811834dc4e3197975c56535fe0e5367169bd07d","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        pool_details_dict[\u0027device_group_name\u0027] \u003d self.configuration.va_pool"},{"line_number":299,"context_line":"        pool_details_dict[\u0027capacity\u0027] \u003d 10737418240"},{"line_number":300,"context_line":"        pool_details_dict[\u0027used_size\u0027] \u003d 9663676416"},{"line_number":301,"context_line":"        pool_details.append(pool_details_dict)"},{"line_number":302,"context_line":"        self._driver._access_api.return_value \u003d pool_details"},{"line_number":303,"context_line":"        self._driver._get_access_pool_details()"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    def test__get_access_pool_details_negative(self):"},{"line_number":306,"context_line":"        self.mock_object(self._driver, \u0027_access_api\u0027)"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_5be44c3c","line":303,"range":{"start_line":301,"start_character":0,"end_line":303,"end_character":47},"updated":"2017-08-27 05:41:50.000000000","message":"asserts?","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"951c131b76258254e403f4afe9708765c073a2bb","unresolved":false,"context_lines":[{"line_number":298,"context_line":"        pool_details_dict[\u0027device_group_name\u0027] \u003d self.configuration.va_pool"},{"line_number":299,"context_line":"        pool_details_dict[\u0027capacity\u0027] \u003d 10737418240"},{"line_number":300,"context_line":"        pool_details_dict[\u0027used_size\u0027] \u003d 9663676416"},{"line_number":301,"context_line":"        pool_details.append(pool_details_dict)"},{"line_number":302,"context_line":"        self._driver._access_api.return_value \u003d pool_details"},{"line_number":303,"context_line":"        self._driver._get_access_pool_details()"},{"line_number":304,"context_line":""},{"line_number":305,"context_line":"    def test__get_access_pool_details_negative(self):"},{"line_number":306,"context_line":"        self.mock_object(self._driver, \u0027_access_api\u0027)"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_decd585d","line":303,"range":{"start_line":301,"start_character":0,"end_line":303,"end_character":47},"in_reply_to":"7f287b81_5be44c3c","updated":"2017-08-31 14:48:46.000000000","message":"Done","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b811834dc4e3197975c56535fe0e5367169bd07d","unresolved":false,"context_lines":[{"line_number":313,"context_line":"    def test__update_share_stats(self):"},{"line_number":314,"context_line":"        self.mock_object(self._driver, \u0027_authenticate_access\u0027)"},{"line_number":315,"context_line":"        self.mock_object(self._driver, \u0027_get_access_pool_details\u0027)"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        self._driver._get_access_pool_details.return_value \u003d (10, 9)"},{"line_number":318,"context_line":"        self._driver._update_share_stats()"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    def test__get_vip(self):"},{"line_number":321,"context_line":"        self.mock_object(self._driver, \u0027_get_access_ips\u0027)"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_3be1802b","line":318,"range":{"start_line":316,"start_character":0,"end_line":318,"end_character":42},"updated":"2017-08-27 05:41:50.000000000","message":"asserts?","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"951c131b76258254e403f4afe9708765c073a2bb","unresolved":false,"context_lines":[{"line_number":313,"context_line":"    def test__update_share_stats(self):"},{"line_number":314,"context_line":"        self.mock_object(self._driver, \u0027_authenticate_access\u0027)"},{"line_number":315,"context_line":"        self.mock_object(self._driver, \u0027_get_access_pool_details\u0027)"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"        self._driver._get_access_pool_details.return_value \u003d (10, 9)"},{"line_number":318,"context_line":"        self._driver._update_share_stats()"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"    def test__get_vip(self):"},{"line_number":321,"context_line":"        self.mock_object(self._driver, \u0027_get_access_ips\u0027)"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_def6788f","line":318,"range":{"start_line":316,"start_character":0,"end_line":318,"end_character":42},"in_reply_to":"7f287b81_3be1802b","updated":"2017-08-31 14:48:46.000000000","message":"Done","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b811834dc4e3197975c56535fe0e5367169bd07d","unresolved":false,"context_lines":[{"line_number":335,"context_line":"        pool_list \u003d [ip1, ip2, ip3, ip4, ip5]"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        self._driver._get_access_ips.return_value \u003d pool_list"},{"line_number":338,"context_line":"        self._driver._get_vip()"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"    def test__get_access_ips(self):"},{"line_number":341,"context_line":"        self.mock_object(self._driver, \u0027_access_api\u0027)"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_1bd48447","line":338,"range":{"start_line":338,"start_character":0,"end_line":338,"end_character":31},"updated":"2017-08-27 05:41:50.000000000","message":"assert?","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"951c131b76258254e403f4afe9708765c073a2bb","unresolved":false,"context_lines":[{"line_number":335,"context_line":"        pool_list \u003d [ip1, ip2, ip3, ip4, ip5]"},{"line_number":336,"context_line":""},{"line_number":337,"context_line":"        self._driver._get_access_ips.return_value \u003d pool_list"},{"line_number":338,"context_line":"        self._driver._get_vip()"},{"line_number":339,"context_line":""},{"line_number":340,"context_line":"    def test__get_access_ips(self):"},{"line_number":341,"context_line":"        self.mock_object(self._driver, \u0027_access_api\u0027)"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_5e304856","line":338,"range":{"start_line":338,"start_character":0,"end_line":338,"end_character":31},"in_reply_to":"7f287b81_1bd48447","updated":"2017-08-31 14:48:46.000000000","message":"Done","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b811834dc4e3197975c56535fe0e5367169bd07d","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        self.mock_object(self._driver, \u0027_access_api\u0027)"},{"line_number":342,"context_line":"        ip_list \u003d [\u00271.1.1.2\u0027, \u00271.1.2.3\u0027, \u00271.1.1.4\u0027]"},{"line_number":343,"context_line":"        self._driver._access_api.return_value \u003d ip_list"},{"line_number":344,"context_line":"        self._driver._get_access_ips(self._driver.session, self._driver.host)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    def test__access_api(self):"},{"line_number":347,"context_line":"        self.mock_object(requests, \u0027session\u0027)"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_fbd8987b","line":344,"range":{"start_line":344,"start_character":0,"end_line":344,"end_character":77},"updated":"2017-08-27 05:41:50.000000000","message":"assertEqual?","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"951c131b76258254e403f4afe9708765c073a2bb","unresolved":false,"context_lines":[{"line_number":341,"context_line":"        self.mock_object(self._driver, \u0027_access_api\u0027)"},{"line_number":342,"context_line":"        ip_list \u003d [\u00271.1.1.2\u0027, \u00271.1.2.3\u0027, \u00271.1.1.4\u0027]"},{"line_number":343,"context_line":"        self._driver._access_api.return_value \u003d ip_list"},{"line_number":344,"context_line":"        self._driver._get_access_ips(self._driver.session, self._driver.host)"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    def test__access_api(self):"},{"line_number":347,"context_line":"        self.mock_object(requests, \u0027session\u0027)"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_de3b1835","line":344,"range":{"start_line":344,"start_character":0,"end_line":344,"end_character":77},"in_reply_to":"7f287b81_fbd8987b","updated":"2017-08-31 14:48:46.000000000","message":"Done","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b811834dc4e3197975c56535fe0e5367169bd07d","unresolved":false,"context_lines":[{"line_number":352,"context_line":"        mock_response \u003d MockResponse()"},{"line_number":353,"context_line":"        session \u003d requests.session"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        session.request.return_value \u003d mock_response"},{"line_number":356,"context_line":"        self._driver._access_api(session, provider, path,"},{"line_number":357,"context_line":"                                 json.dumps(input_data), \u0027GET\u0027)"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    def test__access_api_ret_for_update_object(self):"},{"line_number":360,"context_line":"        self.mock_object(requests, \u0027session\u0027)"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_9bc75497","line":357,"range":{"start_line":355,"start_character":0,"end_line":357,"end_character":63},"updated":"2017-08-27 05:41:50.000000000","message":"asserts?","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"951c131b76258254e403f4afe9708765c073a2bb","unresolved":false,"context_lines":[{"line_number":352,"context_line":"        mock_response \u003d MockResponse()"},{"line_number":353,"context_line":"        session \u003d requests.session"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"        session.request.return_value \u003d mock_response"},{"line_number":356,"context_line":"        self._driver._access_api(session, provider, path,"},{"line_number":357,"context_line":"                                 json.dumps(input_data), \u0027GET\u0027)"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    def test__access_api_ret_for_update_object(self):"},{"line_number":360,"context_line":"        self.mock_object(requests, \u0027session\u0027)"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_1e0f6088","line":357,"range":{"start_line":355,"start_character":0,"end_line":357,"end_character":63},"in_reply_to":"7f287b81_9bc75497","updated":"2017-08-31 14:48:46.000000000","message":"Done","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b811834dc4e3197975c56535fe0e5367169bd07d","unresolved":false,"context_lines":[{"line_number":372,"context_line":"        self.assertTrue(ret)"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    def test__access_api_negative(self):"},{"line_number":375,"context_line":"        session \u003d self._driver.session"},{"line_number":376,"context_line":"        provider \u003d \u0027%s:%s\u0027 % (self._driver.host, self._driver._port)"},{"line_number":377,"context_line":"        path \u003d \u0027/fake/path\u0027"},{"line_number":378,"context_line":"        input_data \u003d {}"},{"line_number":379,"context_line":"        self._driver._access_api(session, provider, path,"},{"line_number":380,"context_line":"                                 json.dumps(input_data), \u0027GET\u0027)"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"    def test__get_api(self):"},{"line_number":383,"context_line":"        provider \u003d \u0027%s:%s\u0027 % (self._driver.host, self._driver._port)"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_bbce90b1","line":380,"range":{"start_line":375,"start_character":0,"end_line":380,"end_character":63},"updated":"2017-08-27 05:41:50.000000000","message":"asserts?","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"951c131b76258254e403f4afe9708765c073a2bb","unresolved":false,"context_lines":[{"line_number":372,"context_line":"        self.assertTrue(ret)"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    def test__access_api_negative(self):"},{"line_number":375,"context_line":"        session \u003d self._driver.session"},{"line_number":376,"context_line":"        provider \u003d \u0027%s:%s\u0027 % (self._driver.host, self._driver._port)"},{"line_number":377,"context_line":"        path \u003d \u0027/fake/path\u0027"},{"line_number":378,"context_line":"        input_data \u003d {}"},{"line_number":379,"context_line":"        self._driver._access_api(session, provider, path,"},{"line_number":380,"context_line":"                                 json.dumps(input_data), \u0027GET\u0027)"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"    def test__get_api(self):"},{"line_number":383,"context_line":"        provider \u003d \u0027%s:%s\u0027 % (self._driver.host, self._driver._port)"}],"source_content_type":"text/x-python","patch_set":28,"id":"7f287b81_3e81fcc3","line":380,"range":{"start_line":375,"start_character":0,"end_line":380,"end_character":63},"in_reply_to":"7f287b81_bbce90b1","updated":"2017-08-31 14:48:46.000000000","message":"Done","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"5ee69b2c9a9ed2166609addd0bb01b692baaca22","unresolved":false,"context_lines":[{"line_number":473,"context_line":"        self._driver._access_api.return_value \u003d ip_list"},{"line_number":474,"context_line":"        ret_value \u003d self._driver._get_access_ips(self._driver.session,"},{"line_number":475,"context_line":"                                                 self._driver.host)"},{"line_number":476,"context_line":"        self.assertEqual(ret_value, ip_list)"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"    def test__access_api(self):"},{"line_number":479,"context_line":"        self.mock_object(requests, \u0027session\u0027)"}],"source_content_type":"text/x-python","patch_set":33,"id":"5f2577a7_46ab7d88","line":476,"range":{"start_line":476,"start_character":8,"end_line":476,"end_character":44},"updated":"2017-09-13 09:19:23.000000000","message":"same","commit_id":"dd615b71e182b03505caffe7fffd33d22e2e9057"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"1b381f816ce7f8e6423610fd47f0563e5d9db2df","unresolved":false,"context_lines":[{"line_number":473,"context_line":"        self._driver._access_api.return_value \u003d ip_list"},{"line_number":474,"context_line":"        ret_value \u003d self._driver._get_access_ips(self._driver.session,"},{"line_number":475,"context_line":"                                                 self._driver.host)"},{"line_number":476,"context_line":"        self.assertEqual(ret_value, ip_list)"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"    def test__access_api(self):"},{"line_number":479,"context_line":"        self.mock_object(requests, \u0027session\u0027)"}],"source_content_type":"text/x-python","patch_set":33,"id":"5f2577a7_e17133e0","line":476,"range":{"start_line":476,"start_character":8,"end_line":476,"end_character":44},"in_reply_to":"5f2577a7_46ab7d88","updated":"2017-09-13 14:13:25.000000000","message":"In a way same, but we are just insuring that \u0027_get_access_ips\u0027 returns returns value got from \u0027_access_api\u0027.\nI know it seems weird :-) but nothing more can be done to cover this portion of code.","commit_id":"dd615b71e182b03505caffe7fffd33d22e2e9057"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"5ee69b2c9a9ed2166609addd0bb01b692baaca22","unresolved":false,"context_lines":[{"line_number":491,"context_line":"        ret_value \u003d self._driver._access_api(session, provider, path,"},{"line_number":492,"context_line":"                                             json.dumps(input_data), \u0027GET\u0027)"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"        self.assertEqual(ret_value, json_data)"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"    def test__access_api_ret_for_update_object(self):"},{"line_number":497,"context_line":"        self.mock_object(requests, \u0027session\u0027)"}],"source_content_type":"text/x-python","patch_set":33,"id":"5f2577a7_66a439ba","line":494,"range":{"start_line":494,"start_character":8,"end_line":494,"end_character":46},"updated":"2017-09-13 09:19:23.000000000","message":"s/ self.assertEqual(ret_value, json_data) /self.assertEqual(json_data, ret_value)\n\nself.assertEqual(espected, result)","commit_id":"dd615b71e182b03505caffe7fffd33d22e2e9057"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"1b381f816ce7f8e6423610fd47f0563e5d9db2df","unresolved":false,"context_lines":[{"line_number":491,"context_line":"        ret_value \u003d self._driver._access_api(session, provider, path,"},{"line_number":492,"context_line":"                                             json.dumps(input_data), \u0027GET\u0027)"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"        self.assertEqual(ret_value, json_data)"},{"line_number":495,"context_line":""},{"line_number":496,"context_line":"    def test__access_api_ret_for_update_object(self):"},{"line_number":497,"context_line":"        self.mock_object(requests, \u0027session\u0027)"}],"source_content_type":"text/x-python","patch_set":33,"id":"5f2577a7_1d237faa","line":494,"range":{"start_line":494,"start_character":8,"end_line":494,"end_character":46},"in_reply_to":"5f2577a7_66a439ba","updated":"2017-09-13 14:13:25.000000000","message":"Done","commit_id":"dd615b71e182b03505caffe7fffd33d22e2e9057"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"5ee69b2c9a9ed2166609addd0bb01b692baaca22","unresolved":false,"context_lines":[{"line_number":515,"context_line":"        input_data \u003d {}"},{"line_number":516,"context_line":"        ret_value \u003d self._driver._access_api(session, provider, path,"},{"line_number":517,"context_line":"                                             json.dumps(input_data), \u0027GET\u0027)"},{"line_number":518,"context_line":"        self.assertEqual(ret_value, False)"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"    def test__get_api(self):"},{"line_number":521,"context_line":"        provider \u003d \u0027%s:%s\u0027 % (self._driver.host, self._driver._port)"}],"source_content_type":"text/x-python","patch_set":33,"id":"5f2577a7_86d3a538","line":518,"range":{"start_line":518,"start_character":8,"end_line":518,"end_character":42},"updated":"2017-09-13 09:19:23.000000000","message":"s/ self.assertEqual(ret_value, False) /self.assertEqual(False, ret_value)\n  or just use self.assertFalse","commit_id":"dd615b71e182b03505caffe7fffd33d22e2e9057"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"1b381f816ce7f8e6423610fd47f0563e5d9db2df","unresolved":false,"context_lines":[{"line_number":515,"context_line":"        input_data \u003d {}"},{"line_number":516,"context_line":"        ret_value \u003d self._driver._access_api(session, provider, path,"},{"line_number":517,"context_line":"                                             json.dumps(input_data), \u0027GET\u0027)"},{"line_number":518,"context_line":"        self.assertEqual(ret_value, False)"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"    def test__get_api(self):"},{"line_number":521,"context_line":"        provider \u003d \u0027%s:%s\u0027 % (self._driver.host, self._driver._port)"}],"source_content_type":"text/x-python","patch_set":33,"id":"5f2577a7_9d1d2f68","line":518,"range":{"start_line":518,"start_character":8,"end_line":518,"end_character":42},"in_reply_to":"5f2577a7_86d3a538","updated":"2017-09-13 14:13:25.000000000","message":"Done","commit_id":"dd615b71e182b03505caffe7fffd33d22e2e9057"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"5ee69b2c9a9ed2166609addd0bb01b692baaca22","unresolved":false,"context_lines":[{"line_number":534,"context_line":"        self._driver._access_api.return_value \u003d fake_item_list"},{"line_number":535,"context_line":"        ret_value \u003d self._driver._does_item_exist_at_va_backend(item_name,"},{"line_number":536,"context_line":"                                                                path)"},{"line_number":537,"context_line":"        self.assertEqual(ret_value, True)"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"    def test__does_item_exist_at_va_backend_negative(self):"},{"line_number":540,"context_line":"        self.mock_object(self._driver, \u0027_access_api\u0027)"}],"source_content_type":"text/x-python","patch_set":33,"id":"5f2577a7_26e071fa","line":537,"range":{"start_line":537,"start_character":8,"end_line":537,"end_character":41},"updated":"2017-09-13 09:19:23.000000000","message":"self.assertTrue","commit_id":"dd615b71e182b03505caffe7fffd33d22e2e9057"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"1b381f816ce7f8e6423610fd47f0563e5d9db2df","unresolved":false,"context_lines":[{"line_number":534,"context_line":"        self._driver._access_api.return_value \u003d fake_item_list"},{"line_number":535,"context_line":"        ret_value \u003d self._driver._does_item_exist_at_va_backend(item_name,"},{"line_number":536,"context_line":"                                                                path)"},{"line_number":537,"context_line":"        self.assertEqual(ret_value, True)"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"    def test__does_item_exist_at_va_backend_negative(self):"},{"line_number":540,"context_line":"        self.mock_object(self._driver, \u0027_access_api\u0027)"}],"source_content_type":"text/x-python","patch_set":33,"id":"5f2577a7_7d184374","line":537,"range":{"start_line":537,"start_character":8,"end_line":537,"end_character":41},"in_reply_to":"5f2577a7_26e071fa","updated":"2017-09-13 14:13:25.000000000","message":"Done","commit_id":"dd615b71e182b03505caffe7fffd33d22e2e9057"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"5ee69b2c9a9ed2166609addd0bb01b692baaca22","unresolved":false,"context_lines":[{"line_number":544,"context_line":"        self._driver._access_api.return_value \u003d fake_item_list"},{"line_number":545,"context_line":"        ret_value \u003d self._driver._does_item_exist_at_va_backend(item_name,"},{"line_number":546,"context_line":"                                                                path)"},{"line_number":547,"context_line":"        self.assertEqual(ret_value, False)"},{"line_number":548,"context_line":""},{"line_number":549,"context_line":"    def test__fetch_existing_rule(self):"},{"line_number":550,"context_line":"        self.mock_object(self._driver, \u0027_access_api\u0027)"}],"source_content_type":"text/x-python","patch_set":33,"id":"5f2577a7_66d6792a","line":547,"range":{"start_line":547,"start_character":8,"end_line":547,"end_character":42},"updated":"2017-09-13 09:19:23.000000000","message":"s/ self.assertEqual(ret_value, False) /self.assertEqual(False, ret_value)\n  or just use self.assertFalse","commit_id":"dd615b71e182b03505caffe7fffd33d22e2e9057"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"1b381f816ce7f8e6423610fd47f0563e5d9db2df","unresolved":false,"context_lines":[{"line_number":544,"context_line":"        self._driver._access_api.return_value \u003d fake_item_list"},{"line_number":545,"context_line":"        ret_value \u003d self._driver._does_item_exist_at_va_backend(item_name,"},{"line_number":546,"context_line":"                                                                path)"},{"line_number":547,"context_line":"        self.assertEqual(ret_value, False)"},{"line_number":548,"context_line":""},{"line_number":549,"context_line":"    def test__fetch_existing_rule(self):"},{"line_number":550,"context_line":"        self.mock_object(self._driver, \u0027_access_api\u0027)"}],"source_content_type":"text/x-python","patch_set":33,"id":"5f2577a7_bd37cbe3","line":547,"range":{"start_line":547,"start_character":8,"end_line":547,"end_character":42},"in_reply_to":"5f2577a7_66d6792a","updated":"2017-09-13 14:13:25.000000000","message":"Done","commit_id":"dd615b71e182b03505caffe7fffd33d22e2e9057"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"5ee69b2c9a9ed2166609addd0bb01b692baaca22","unresolved":false,"context_lines":[{"line_number":607,"context_line":""},{"line_number":608,"context_line":"        self._driver._access_api.return_value \u003d fake_access_list"},{"line_number":609,"context_line":"        ret_value \u003d self._driver._fetch_existing_rule(fake_share)"},{"line_number":610,"context_line":"        self.assertEqual(ret_value, ret_access_list)"}],"source_content_type":"text/x-python","patch_set":33,"id":"5f2577a7_06d0d51e","line":610,"range":{"start_line":610,"start_character":8,"end_line":610,"end_character":52},"updated":"2017-09-13 09:19:23.000000000","message":"s / self.assertEqual(ret_value, ret_access_list)  self.assertEqual(ret_access_list, ret_value)","commit_id":"dd615b71e182b03505caffe7fffd33d22e2e9057"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"1b381f816ce7f8e6423610fd47f0563e5d9db2df","unresolved":false,"context_lines":[{"line_number":607,"context_line":""},{"line_number":608,"context_line":"        self._driver._access_api.return_value \u003d fake_access_list"},{"line_number":609,"context_line":"        ret_value \u003d self._driver._fetch_existing_rule(fake_share)"},{"line_number":610,"context_line":"        self.assertEqual(ret_value, ret_access_list)"}],"source_content_type":"text/x-python","patch_set":33,"id":"5f2577a7_5d4ea76f","line":610,"range":{"start_line":610,"start_character":8,"end_line":610,"end_character":52},"in_reply_to":"5f2577a7_06d0d51e","updated":"2017-09-13 14:13:25.000000000","message":"Done","commit_id":"dd615b71e182b03505caffe7fffd33d22e2e9057"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"a54dcb89de36b2527b7f1a1356dfee1df6c571db","unresolved":false,"context_lines":[{"line_number":473,"context_line":"        self._driver._access_api.return_value \u003d ip_list"},{"line_number":474,"context_line":"        ret_value \u003d self._driver._get_access_ips(self._driver.session,"},{"line_number":475,"context_line":"                                                 self._driver.host)"},{"line_number":476,"context_line":"        self.assertEqual(ret_value, ip_list)"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"    def test__access_api(self):"},{"line_number":479,"context_line":"        self.mock_object(requests, \u0027session\u0027)"}],"source_content_type":"text/x-python","patch_set":34,"id":"5f2577a7_2c5039d4","line":476,"range":{"start_line":476,"start_character":8,"end_line":476,"end_character":44},"updated":"2017-09-14 01:36:00.000000000","message":"self.assertEqual(ip_list, ret_value)","commit_id":"6824207a0e807891f120ab6a31b713512fb335f6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ea8ad166c33068bfdcc81d75276d323d7d12cdaf","unresolved":false,"context_lines":[{"line_number":473,"context_line":"        self._driver._access_api.return_value \u003d ip_list"},{"line_number":474,"context_line":"        ret_value \u003d self._driver._get_access_ips(self._driver.session,"},{"line_number":475,"context_line":"                                                 self._driver.host)"},{"line_number":476,"context_line":"        self.assertEqual(ret_value, ip_list)"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":"    def test__access_api(self):"},{"line_number":479,"context_line":"        self.mock_object(requests, \u0027session\u0027)"}],"source_content_type":"text/x-python","patch_set":34,"id":"5f2577a7_83049b4b","line":476,"range":{"start_line":476,"start_character":8,"end_line":476,"end_character":44},"in_reply_to":"5f2577a7_2c5039d4","updated":"2017-09-14 04:09:42.000000000","message":"Good find. Please fix this in a follow up patch","commit_id":"6824207a0e807891f120ab6a31b713512fb335f6"}],"releasenotes/notes/veritas-access-manila-driver-d75558c01ce6d428.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b811834dc4e3197975c56535fe0e5367169bd07d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added Manila driver for Veritas Access."}],"source_content_type":"text/x-yaml","patch_set":28,"id":"7f287b81_3bbaa009","line":3,"range":{"start_line":3,"start_character":42,"end_line":3,"end_character":43},"updated":"2017-08-27 05:41:50.000000000","message":"what can this driver do?\n\n supports NFS protocol and snapshots, does not handle share servers \n (operates in driver_handles_share_servers\u003dFalse mode).","commit_id":"fe6a60d584e967756a5e971089725b2b956d024e"}]}
