)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"dfa1e76a03210671ce0a4e0e664150d596cd82ca","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dustin Schoenbrun \u003cdschoenb@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-06-12 22:12:42 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Changed default value in docs for CephFS snapshots"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The documentation for the CephFS Native Manila driver would,"},{"line_number":10,"context_line":"by default, show the configuration stanza with the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f231b9d_5eb22296","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":15},"updated":"2017-06-13 07:33:06.000000000","message":"I think the usage of \u0027default\u0027 is confusing. A doc change can\u0027t modify the default value, only a code change can. I\u0027m not opposed to changing an example as you prefer, snaphsot-support to no-snapshot-support. So let\u0027s just say that, example value.","commit_id":"2b4ac839b44d3dc9bec4450104a2f7ce7fa17221"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"8f34df6c003350c3657fef123bdd2ea087aaaf74","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dustin Schoenbrun \u003cdschoenb@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-06-12 22:12:42 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Changed default value in docs for CephFS snapshots"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The documentation for the CephFS Native Manila driver would,"},{"line_number":10,"context_line":"by default, show the configuration stanza with the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f231b9d_6faf66e3","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":15},"in_reply_to":"7f231b9d_5eb22296","updated":"2017-06-13 08:25:23.000000000","message":"\" A doc change can\u0027t modify the default value, only a code change can.\" Please ignore this sentence from the earlier comment. It\u0027s distracting, non sequitur, etc...","commit_id":"2b4ac839b44d3dc9bec4450104a2f7ce7fa17221"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"9c73b942037c51504b8fcc143b60f8e32729f6d6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dustin Schoenbrun \u003cdschoenb@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-06-12 22:12:42 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Changed default value in docs for CephFS snapshots"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The documentation for the CephFS Native Manila driver would,"},{"line_number":10,"context_line":"by default, show the configuration stanza with the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f231b9d_4cd4aabd","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":15},"in_reply_to":"7f231b9d_5eb22296","updated":"2017-06-13 14:42:39.000000000","message":"Done","commit_id":"2b4ac839b44d3dc9bec4450104a2f7ce7fa17221"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"9c73b942037c51504b8fcc143b60f8e32729f6d6","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dustin Schoenbrun \u003cdschoenb@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-06-12 22:12:42 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Changed default value in docs for CephFS snapshots"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The documentation for the CephFS Native Manila driver would,"},{"line_number":10,"context_line":"by default, show the configuration stanza with the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f231b9d_2cdbaeed","line":7,"range":{"start_line":7,"start_character":8,"end_line":7,"end_character":15},"in_reply_to":"7f231b9d_6faf66e3","updated":"2017-06-13 14:42:39.000000000","message":"Done","commit_id":"2b4ac839b44d3dc9bec4450104a2f7ce7fa17221"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"dfa1e76a03210671ce0a4e0e664150d596cd82ca","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Changed default value in docs for CephFS snapshots"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The documentation for the CephFS Native Manila driver would,"},{"line_number":10,"context_line":"by default, show the configuration stanza with the"},{"line_number":11,"context_line":"\"cephfs_snapshot_support\" option set to \"true\". The snapshot"},{"line_number":12,"context_line":"support in CephFS is experimental and comes with a list of"},{"line_number":13,"context_line":"caveats, so this patch changes the value shown in the example"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f231b9d_fea68e53","line":10,"range":{"start_line":10,"start_character":2,"end_line":10,"end_character":10},"updated":"2017-06-13 07:33:06.000000000","message":"prefer removing this","commit_id":"2b4ac839b44d3dc9bec4450104a2f7ce7fa17221"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"9c73b942037c51504b8fcc143b60f8e32729f6d6","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Changed default value in docs for CephFS snapshots"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The documentation for the CephFS Native Manila driver would,"},{"line_number":10,"context_line":"by default, show the configuration stanza with the"},{"line_number":11,"context_line":"\"cephfs_snapshot_support\" option set to \"true\". The snapshot"},{"line_number":12,"context_line":"support in CephFS is experimental and comes with a list of"},{"line_number":13,"context_line":"caveats, so this patch changes the value shown in the example"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7f231b9d_ece496ae","line":10,"range":{"start_line":10,"start_character":2,"end_line":10,"end_character":10},"in_reply_to":"7f231b9d_fea68e53","updated":"2017-06-13 14:42:39.000000000","message":"Done","commit_id":"2b4ac839b44d3dc9bec4450104a2f7ce7fa17221"}],"doc/source/devref/cephfs_driver.rst":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"82a7793bdd380ca9c14556defe0c7b3147375df0","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    [cephfs1]"},{"line_number":147,"context_line":"    driver_handles_share_servers \u003d False"},{"line_number":148,"context_line":"    share_backend_name \u003d cephfs1"},{"line_number":149,"context_line":"    share_driver \u003d manila.share.drivers.cephfs.driver.CephFSDriver"},{"line_number":150,"context_line":"    cephfs_conf_path \u003d /etc/ceph/ceph.conf"},{"line_number":151,"context_line":"    cephfs_auth_id \u003d manila"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f231b9d_6fb53c31","line":148,"range":{"start_line":148,"start_character":25,"end_line":148,"end_character":32},"updated":"2017-06-12 16:58:46.000000000","message":"any reason to change this? I think using a upper-case value helps avoid the confusion that some people think this value needs to be the same as the config group name \"[cephfs1]\"","commit_id":"54c7e518b20813aa6849a6726f9de3953d9e67d8"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"be9af84fc5d15274a274bb20f63d4b74f9c98110","unresolved":false,"context_lines":[{"line_number":145,"context_line":""},{"line_number":146,"context_line":"    [cephfs1]"},{"line_number":147,"context_line":"    driver_handles_share_servers \u003d False"},{"line_number":148,"context_line":"    share_backend_name \u003d cephfs1"},{"line_number":149,"context_line":"    share_driver \u003d manila.share.drivers.cephfs.driver.CephFSDriver"},{"line_number":150,"context_line":"    cephfs_conf_path \u003d /etc/ceph/ceph.conf"},{"line_number":151,"context_line":"    cephfs_auth_id \u003d manila"}],"source_content_type":"text/x-rst","patch_set":1,"id":"7f231b9d_3e2891e0","line":148,"range":{"start_line":148,"start_character":25,"end_line":148,"end_character":32},"in_reply_to":"7f231b9d_6fb53c31","updated":"2017-06-12 21:42:32.000000000","message":"I honestly thought they did have to be the same. I can understand the confusion, though!","commit_id":"54c7e518b20813aa6849a6726f9de3953d9e67d8"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"dfa1e76a03210671ce0a4e0e664150d596cd82ca","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    of manila."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"- Extend/shrink share"},{"line_number":51,"context_line":"- Create/delete snapshot (experimental)"},{"line_number":52,"context_line":"- Create/delete consistency group (CG)"},{"line_number":53,"context_line":"- Create/delete CG snapshot"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f231b9d_7e703edd","line":51,"updated":"2017-06-13 07:33:06.000000000","message":"Can you state explicitly what\u0027s experimental, the manila API or the underlying backend support for the API?","commit_id":"2b4ac839b44d3dc9bec4450104a2f7ce7fa17221"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"9c73b942037c51504b8fcc143b60f8e32729f6d6","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    of manila."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"- Extend/shrink share"},{"line_number":51,"context_line":"- Create/delete snapshot (experimental)"},{"line_number":52,"context_line":"- Create/delete consistency group (CG)"},{"line_number":53,"context_line":"- Create/delete CG snapshot"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f231b9d_ac069e85","line":51,"in_reply_to":"7f231b9d_7e703edd","updated":"2017-06-13 14:42:39.000000000","message":"Done, I removed the experimental from here (as it seems to imply that the snapshot support is experimental in Manila itself not in the driver) and added a warning underneath explaining the experimental nature of snapshots in CephFS.","commit_id":"2b4ac839b44d3dc9bec4450104a2f7ce7fa17221"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"dfa1e76a03210671ce0a4e0e664150d596cd82ca","unresolved":false,"context_lines":[{"line_number":50,"context_line":"- Extend/shrink share"},{"line_number":51,"context_line":"- Create/delete snapshot (experimental)"},{"line_number":52,"context_line":"- Create/delete consistency group (CG)"},{"line_number":53,"context_line":"- Create/delete CG snapshot"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Prerequisites"},{"line_number":56,"context_line":"-------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f231b9d_de4cf29f","line":53,"updated":"2017-06-13 07:33:06.000000000","message":"CephFS backend support for this feature is also experimental as snapshotting is an experimental feature in CephFS.","commit_id":"2b4ac839b44d3dc9bec4450104a2f7ce7fa17221"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"9c73b942037c51504b8fcc143b60f8e32729f6d6","unresolved":false,"context_lines":[{"line_number":50,"context_line":"- Extend/shrink share"},{"line_number":51,"context_line":"- Create/delete snapshot (experimental)"},{"line_number":52,"context_line":"- Create/delete consistency group (CG)"},{"line_number":53,"context_line":"- Create/delete CG snapshot"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Prerequisites"},{"line_number":56,"context_line":"-------------"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f231b9d_2cfa8e74","line":53,"in_reply_to":"7f231b9d_de4cf29f","updated":"2017-06-13 14:42:39.000000000","message":"Done","commit_id":"2b4ac839b44d3dc9bec4450104a2f7ce7fa17221"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"dfa1e76a03210671ce0a4e0e664150d596cd82ca","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    ceph mds set allow_new_snaps true --yes-i-really-mean-it"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Note that the snapshot support for the CephFS Native driver is experimental"},{"line_number":107,"context_line":"and is known to have several caveats for use. Only enable this and the"},{"line_number":108,"context_line":"equivalent ``manila.conf`` option if you understand these risks. See"},{"line_number":109,"context_line":"(http://docs.ceph.com/docs/master/cephfs/experimental-features/#snapshots)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f231b9d_d963ecb0","line":106,"updated":"2017-06-13 07:33:06.000000000","message":"Add the note special section as done in line 164 of this doc\n\nYou can see this too,\nhttps://docs.openstack.org/contributor-guide/rst-conv/specific-info.html","commit_id":"2b4ac839b44d3dc9bec4450104a2f7ce7fa17221"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"9c73b942037c51504b8fcc143b60f8e32729f6d6","unresolved":false,"context_lines":[{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    ceph mds set allow_new_snaps true --yes-i-really-mean-it"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"Note that the snapshot support for the CephFS Native driver is experimental"},{"line_number":107,"context_line":"and is known to have several caveats for use. Only enable this and the"},{"line_number":108,"context_line":"equivalent ``manila.conf`` option if you understand these risks. See"},{"line_number":109,"context_line":"(http://docs.ceph.com/docs/master/cephfs/experimental-features/#snapshots)"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f231b9d_0cf59283","line":106,"in_reply_to":"7f231b9d_d963ecb0","updated":"2017-06-13 14:42:39.000000000","message":"Done, I made this note a warning block.","commit_id":"2b4ac839b44d3dc9bec4450104a2f7ce7fa17221"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"dfa1e76a03210671ce0a4e0e664150d596cd82ca","unresolved":false,"context_lines":[{"line_number":285,"context_line":""},{"line_number":286,"context_line":"- The snapshot support of the driver is disabled by default. The"},{"line_number":287,"context_line":"  ``cephfs_enable_snapshots`` configuration option needs to be set to ``True``"},{"line_number":288,"context_line":"  to allow snapshot operations as well as having the snapshot support enabled"},{"line_number":289,"context_line":"  on the backend storage."},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"- Snapshots are read-only.  A user can read a snapshot\u0027s contents from the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f231b9d_191724f0","line":288,"updated":"2017-06-13 07:33:06.000000000","message":"s/having/have/ ?\n\nParallelism.","commit_id":"2b4ac839b44d3dc9bec4450104a2f7ce7fa17221"},{"author":{"_account_id":17780,"name":"Dustin Schoenbrun","email":"dschoenb@redhat.com","username":"dschoenb"},"change_message_id":"9c73b942037c51504b8fcc143b60f8e32729f6d6","unresolved":false,"context_lines":[{"line_number":285,"context_line":""},{"line_number":286,"context_line":"- The snapshot support of the driver is disabled by default. The"},{"line_number":287,"context_line":"  ``cephfs_enable_snapshots`` configuration option needs to be set to ``True``"},{"line_number":288,"context_line":"  to allow snapshot operations as well as having the snapshot support enabled"},{"line_number":289,"context_line":"  on the backend storage."},{"line_number":290,"context_line":""},{"line_number":291,"context_line":"- Snapshots are read-only.  A user can read a snapshot\u0027s contents from the"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7f231b9d_6c352646","line":288,"in_reply_to":"7f231b9d_191724f0","updated":"2017-06-13 14:42:39.000000000","message":"Yeah, rereading that does sound kinda awkward. I reworded it into two separate sentences.","commit_id":"2b4ac839b44d3dc9bec4450104a2f7ce7fa17221"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"3d50c15d8adf43a4d0ca631854437f8207fdbb71","unresolved":false,"context_lines":[{"line_number":52,"context_line":"- Create/delete consistency group (CG)"},{"line_number":53,"context_line":"- Create/delete CG snapshot"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":".. warning::"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"    CephFS currently supports snapshots as an experimental feature, therefore"},{"line_number":58,"context_line":"    the snapshot support with the CephFS Native driver is also experimental"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7f231b9d_a74d9773","line":55,"updated":"2017-06-13 14:48:56.000000000","message":"Nice!","commit_id":"9c4261557ac3581805d19fe4c82c4a27566b8008"}]}
