)]}'
{"manila/api/views/share_group_snapshots.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c97a4e6e2fb40b301b84d7197d716c9ddbac783d","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                \u0027project_id\u0027: member.get(\u0027project_id\u0027),"},{"line_number":41,"context_line":"                \u0027share_group_snapshot_id\u0027: member.get("},{"line_number":42,"context_line":"                    \u0027share_group_snapshot_id\u0027),"},{"line_number":43,"context_line":"                \u0027share_id\u0027: member.get(\u0027share_instance\u0027, {}).get(\u0027share_id\u0027),"},{"line_number":44,"context_line":"                # TODO(vponomaryov): add \u0027provider_location\u0027 key in Pike."},{"line_number":45,"context_line":"            }"},{"line_number":46,"context_line":"            members_list.append(member_dict)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f231b9d_1f98a172","line":43,"range":{"start_line":43,"start_character":57,"end_line":43,"end_character":59},"updated":"2017-06-16 17:50:31.000000000","message":"Under what circumstances would a snapshot member not be tied to a share_instance?","commit_id":"160a9a113e93a2464976375a82f484684a236ac9"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"a2c1a3be7e7939705047e67b36c2672a8fd2b135","unresolved":false,"context_lines":[{"line_number":40,"context_line":"                \u0027project_id\u0027: member.get(\u0027project_id\u0027),"},{"line_number":41,"context_line":"                \u0027share_group_snapshot_id\u0027: member.get("},{"line_number":42,"context_line":"                    \u0027share_group_snapshot_id\u0027),"},{"line_number":43,"context_line":"                \u0027share_id\u0027: member.get(\u0027share_instance\u0027, {}).get(\u0027share_id\u0027),"},{"line_number":44,"context_line":"                # TODO(vponomaryov): add \u0027provider_location\u0027 key in Pike."},{"line_number":45,"context_line":"            }"},{"line_number":46,"context_line":"            members_list.append(member_dict)"}],"source_content_type":"text/x-python","patch_set":9,"id":"7f231b9d_3fc47d3f","line":43,"range":{"start_line":43,"start_character":57,"end_line":43,"end_character":59},"in_reply_to":"7f231b9d_1f98a172","updated":"2017-06-19 07:08:17.000000000","message":"Any \"bug\" circumstances that could lead to unexpected behavior. Current approach is just safe programming, where our error will be smaller and most likely not critical, because probability that someone uses this attr is too small.","commit_id":"160a9a113e93a2464976375a82f484684a236ac9"}],"manila/share/api.py":[{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"c350fb8481339c05a31f02f5fb90a1a940ed0be5","unresolved":false,"context_lines":[{"line_number":500,"context_line":"        snapshot_instance \u003d {"},{"line_number":501,"context_line":"            \u0027status\u0027: constants.STATUS_CREATING,"},{"line_number":502,"context_line":"            \u0027progress\u0027: \u00270%\u0027,"},{"line_number":503,"context_line":"            \u0027share_id\u0027: share[\u0027id\u0027],"},{"line_number":504,"context_line":"            \u0027share_instance_id\u0027: share_replica[\u0027id\u0027],"},{"line_number":505,"context_line":"        }"},{"line_number":506,"context_line":"        for snapshot in existing_snapshots:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_d7939aa2","line":503,"range":{"start_line":503,"start_character":24,"end_line":503,"end_character":35},"updated":"2017-06-13 20:23:21.000000000","message":"This should be share_instance_id to be backward compatible.  Previously \"share_id\" property in ShareSnapshotInstance is set to \"share_instance_id\".  Now you changed this to share_id.  This change still breaks the drivers.\n\nIn VNX/VMAX, for example, when a share is created, it uses the share[\u0027id\u0027] passed to the driver in create_share to name the filesystem.  That share[\u0027id\u0027] is the share instance id, not the Share id.  When creating a snapshot, it relies on the \"share_id\" in snapshot passed in create_snapshot to find the filesystem.  Since it becomes the id of the Share not the id of the ShareInstance, it can\u0027t find it any more.","commit_id":"52c09118b57c1a0dc97c5f219d11e2300132e69b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"2e40648faa59bfc891340c9b9af24db124865131","unresolved":false,"context_lines":[{"line_number":500,"context_line":"        snapshot_instance \u003d {"},{"line_number":501,"context_line":"            \u0027status\u0027: constants.STATUS_CREATING,"},{"line_number":502,"context_line":"            \u0027progress\u0027: \u00270%\u0027,"},{"line_number":503,"context_line":"            \u0027share_id\u0027: share[\u0027id\u0027],"},{"line_number":504,"context_line":"            \u0027share_instance_id\u0027: share_replica[\u0027id\u0027],"},{"line_number":505,"context_line":"        }"},{"line_number":506,"context_line":"        for snapshot in existing_snapshots:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_b313885c","line":503,"range":{"start_line":503,"start_character":24,"end_line":503,"end_character":35},"in_reply_to":"7f231b9d_cc3f8c23","updated":"2017-06-14 03:41:07.000000000","message":"We need to discuss with Ben again as this still changed what was there before.  With this change, drivers are still broken and backward compatibility is still not supported.\n\nThe share_id property code removed in the following patch should be added back to maintain backward compatibility.\n\nhttps://review.openstack.org/#/c/433854/12/manila/db/sqlalchemy/models.py","commit_id":"52c09118b57c1a0dc97c5f219d11e2300132e69b"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"10c5ce89db1ac56f6ca496a5fcf290d5b1f4089b","unresolved":false,"context_lines":[{"line_number":500,"context_line":"        snapshot_instance \u003d {"},{"line_number":501,"context_line":"            \u0027status\u0027: constants.STATUS_CREATING,"},{"line_number":502,"context_line":"            \u0027progress\u0027: \u00270%\u0027,"},{"line_number":503,"context_line":"            \u0027share_id\u0027: share[\u0027id\u0027],"},{"line_number":504,"context_line":"            \u0027share_instance_id\u0027: share_replica[\u0027id\u0027],"},{"line_number":505,"context_line":"        }"},{"line_number":506,"context_line":"        for snapshot in existing_snapshots:"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f231b9d_cc3f8c23","line":503,"range":{"start_line":503,"start_character":24,"end_line":503,"end_character":35},"in_reply_to":"7f231b9d_d7939aa2","updated":"2017-06-13 21:48:32.000000000","message":"Xing, it is intended. \"Share ID\" became really \"share ID\".\nThe approach you described I consider as improper one based on confused naming in driver interface that calls \"share instance\" as \"share\".","commit_id":"52c09118b57c1a0dc97c5f219d11e2300132e69b"}]}
