)]}'
{"doc/source/conf.py":[{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9de52424797c20febc1f70d47a0a5d753f39f19c","unresolved":false,"context_lines":[{"line_number":108,"context_line":"git_cmd \u003d \"/usr/bin/git log | head -n1 | cut -f2 -d\u0027 \u0027\""},{"line_number":109,"context_line":"try:"},{"line_number":110,"context_line":"    gitsha \u003d os.popen(git_cmd).read().strip(\u0027\\n\u0027)"},{"line_number":111,"context_line":"except Exception:"},{"line_number":112,"context_line":"    warnings.warn(\u0027Cannot get gitsha repository.\u0027)"},{"line_number":113,"context_line":"    gitsha \u003d \u0027unknown\u0027"},{"line_number":114,"context_line":"bug_tag \u003d u\u0027docs\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_02e68417","line":111,"range":{"start_line":111,"start_character":7,"end_line":111,"end_character":17},"updated":"2017-07-11 10:18:21.000000000","message":"too broad catch.","commit_id":"d1027dbc41bcd5de4a78acd6d123ce90e6d83432"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"6f38f9d5e79fb61ad225811314c1b78bf9e3af57","unresolved":false,"context_lines":[{"line_number":108,"context_line":"git_cmd \u003d \"/usr/bin/git log | head -n1 | cut -f2 -d\u0027 \u0027\""},{"line_number":109,"context_line":"try:"},{"line_number":110,"context_line":"    gitsha \u003d os.popen(git_cmd).read().strip(\u0027\\n\u0027)"},{"line_number":111,"context_line":"except Exception:"},{"line_number":112,"context_line":"    warnings.warn(\u0027Cannot get gitsha repository.\u0027)"},{"line_number":113,"context_line":"    gitsha \u003d \u0027unknown\u0027"},{"line_number":114,"context_line":"bug_tag \u003d u\u0027docs\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_6391ba46","line":111,"range":{"start_line":111,"start_character":7,"end_line":111,"end_character":17},"in_reply_to":"3f1d235d_02e68417","updated":"2017-07-11 11:54:37.000000000","message":"we do already the same in line 222","commit_id":"d1027dbc41bcd5de4a78acd6d123ce90e6d83432"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"222c2c40175b48419e13b989753090ba531d7a61","unresolved":false,"context_lines":[{"line_number":108,"context_line":"git_cmd \u003d \"/usr/bin/git log | head -n1 | cut -f2 -d\u0027 \u0027\""},{"line_number":109,"context_line":"try:"},{"line_number":110,"context_line":"    gitsha \u003d os.popen(git_cmd).read().strip(\u0027\\n\u0027)"},{"line_number":111,"context_line":"except Exception:"},{"line_number":112,"context_line":"    warnings.warn(\u0027Cannot get gitsha repository.\u0027)"},{"line_number":113,"context_line":"    gitsha \u003d \u0027unknown\u0027"},{"line_number":114,"context_line":"bug_tag \u003d u\u0027docs\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_a34232aa","line":111,"range":{"start_line":111,"start_character":7,"end_line":111,"end_character":17},"in_reply_to":"3f1d235d_6391ba46","updated":"2017-07-11 11:58:12.000000000","message":"I consider it a bug. Even if we use \"Exception\" here, then better to provide exception message to be sure it is one of expected ones.","commit_id":"d1027dbc41bcd5de4a78acd6d123ce90e6d83432"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"5230c20043e5757c002e3976a8ca1b8e07ccf1da","unresolved":false,"context_lines":[{"line_number":108,"context_line":"git_cmd \u003d \"/usr/bin/git log | head -n1 | cut -f2 -d\u0027 \u0027\""},{"line_number":109,"context_line":"try:"},{"line_number":110,"context_line":"    gitsha \u003d os.popen(git_cmd).read().strip(\u0027\\n\u0027)"},{"line_number":111,"context_line":"except Exception:"},{"line_number":112,"context_line":"    warnings.warn(\u0027Cannot get gitsha repository.\u0027)"},{"line_number":113,"context_line":"    gitsha \u003d \u0027unknown\u0027"},{"line_number":114,"context_line":"bug_tag \u003d u\u0027docs\u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_43e91e7e","line":111,"range":{"start_line":111,"start_character":7,"end_line":111,"end_character":17},"in_reply_to":"3f1d235d_a34232aa","updated":"2017-07-11 12:02:32.000000000","message":"It doesn\u0027t matter what exception it is. If it fails, gitsha is not available. that\u0027s it. I don\u0027t care why it fails...","commit_id":"d1027dbc41bcd5de4a78acd6d123ce90e6d83432"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"9de52424797c20febc1f70d47a0a5d753f39f19c","unresolved":false,"context_lines":[{"line_number":109,"context_line":"try:"},{"line_number":110,"context_line":"    gitsha \u003d os.popen(git_cmd).read().strip(\u0027\\n\u0027)"},{"line_number":111,"context_line":"except Exception:"},{"line_number":112,"context_line":"    warnings.warn(\u0027Cannot get gitsha repository.\u0027)"},{"line_number":113,"context_line":"    gitsha \u003d \u0027unknown\u0027"},{"line_number":114,"context_line":"bug_tag \u003d u\u0027docs\u0027"},{"line_number":115,"context_line":"# source tree"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_82bbb4e3","line":112,"range":{"start_line":112,"start_character":4,"end_line":112,"end_character":50},"updated":"2017-07-11 10:18:21.000000000","message":"It can be incorrect message, because you catch ALL possible exceptions.","commit_id":"d1027dbc41bcd5de4a78acd6d123ce90e6d83432"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"07cd072ad917ae88d867dff25e05239fb96a4dfe","unresolved":false,"context_lines":[{"line_number":109,"context_line":"try:"},{"line_number":110,"context_line":"    gitsha \u003d os.popen(git_cmd).read().strip(\u0027\\n\u0027)"},{"line_number":111,"context_line":"except Exception:"},{"line_number":112,"context_line":"    warnings.warn(\u0027Cannot get gitsha repository.\u0027)"},{"line_number":113,"context_line":"    gitsha \u003d \u0027unknown\u0027"},{"line_number":114,"context_line":"bug_tag \u003d u\u0027docs\u0027"},{"line_number":115,"context_line":"# source tree"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f1d235d_c3c40e43","line":112,"range":{"start_line":112,"start_character":4,"end_line":112,"end_character":50},"in_reply_to":"3f1d235d_82bbb4e3","updated":"2017-07-11 11:55:34.000000000","message":"Done","commit_id":"d1027dbc41bcd5de4a78acd6d123ce90e6d83432"}]}
