)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a35673ff220c03864688bd3b095d7590d372dc2b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dave Hill \u003cdhill@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-07-14 08:52:30 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Define preferred to false instead of none"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Define preferred to false instead of none as setting it to none"},{"line_number":10,"context_line":"will trigger a traceback later on because the database doesn\u0027t"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"1f1a1f67_0b3b1f9c","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":41},"updated":"2017-07-15 04:46:24.000000000","message":"NetApp: Define \u0027preferred\u0027 to False instead of none","commit_id":"b6500264a935fcf36893a97a1814efe5b312cd7f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a35673ff220c03864688bd3b095d7590d372dc2b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Define preferred to false instead of none"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Define preferred to false instead of none as setting it to none"},{"line_number":10,"context_line":"will trigger a traceback later on because the database doesn\u0027t"},{"line_number":11,"context_line":"allow null values to be inserted.  preferred must be set to"},{"line_number":12,"context_line":"true or false."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"1f1a1f67_eb41030d","line":9,"range":{"start_line":9,"start_character":7,"end_line":9,"end_character":16},"updated":"2017-07-15 04:46:24.000000000","message":"\"preferred\" export location metadata","commit_id":"b6500264a935fcf36893a97a1814efe5b312cd7f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a35673ff220c03864688bd3b095d7590d372dc2b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Define preferred to false instead of none"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Define preferred to false instead of none as setting it to none"},{"line_number":10,"context_line":"will trigger a traceback later on because the database doesn\u0027t"},{"line_number":11,"context_line":"allow null values to be inserted.  preferred must be set to"},{"line_number":12,"context_line":"true or false."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"1f1a1f67_ab4b0b29","line":9,"range":{"start_line":9,"start_character":25,"end_line":9,"end_character":26},"updated":"2017-07-15 04:46:24.000000000","message":"in the NetApp driver","commit_id":"b6500264a935fcf36893a97a1814efe5b312cd7f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a35673ff220c03864688bd3b095d7590d372dc2b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"will trigger a traceback later on because the database doesn\u0027t"},{"line_number":11,"context_line":"allow null values to be inserted.  preferred must be set to"},{"line_number":12,"context_line":"true or false."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ie7420c9286cc42eaa1361eeffe607b9b5b6b3fbd"},{"line_number":15,"context_line":"Closes-Bug: 1703660"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"1f1a1f67_8b460f21","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":0},"updated":"2017-07-15 04:46:24.000000000","message":"nit: mention that you\u0027re also increasing the logging by warning that the driver sent invalid values to update the export location metadata","commit_id":"b6500264a935fcf36893a97a1814efe5b312cd7f"}],"manila/db/sqlalchemy/api.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"c7fc78ce7bc531442d17213e744113e158117d05","unresolved":false,"context_lines":[{"line_number":2903,"context_line":"        # in that case, single record - first one added with this call."},{"line_number":2904,"context_line":"        session \u003d get_session()"},{"line_number":2905,"context_line":""},{"line_number":2906,"context_line":"        if not meta_value:"},{"line_number":2907,"context_line":"            LOG.warning(\"%s should be defined properly in the driver\", meta_key)"},{"line_number":2908,"context_line":""},{"line_number":2909,"context_line":"        item \u003d {\"value\": meta_value, \"updated_at\": timeutils.utcnow()}"},{"line_number":2910,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"1f1a1f67_329fb004","line":2907,"range":{"start_line":2906,"start_character":8,"end_line":2907,"end_character":80},"updated":"2017-07-13 11:56:14.000000000","message":"I think it\u0027s OK to let the DB code raise the exception here (as you are doing) rather than raising a specific manila exception.  Probably this should be LOG.error though?\n\npep8 is failing because this line exceeds 79 characters: wrap it before \u0027meta_key\u0027.\n\nnit: add a period to the end of your log message.\n\n@gouthamr: what do you think w.r.t. this message?","commit_id":"fce8195a11d6eccb410374adf66ae31147bc86e2"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"a35673ff220c03864688bd3b095d7590d372dc2b","unresolved":false,"context_lines":[{"line_number":2903,"context_line":"        # in that case, single record - first one added with this call."},{"line_number":2904,"context_line":"        session \u003d get_session()"},{"line_number":2905,"context_line":""},{"line_number":2906,"context_line":"        if not meta_value:"},{"line_number":2907,"context_line":"            LOG.warning(\"%s should be properly defined in the driver.\","},{"line_number":2908,"context_line":"                        meta_key)"},{"line_number":2909,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"1f1a1f67_6bc0537c","line":2906,"range":{"start_line":2906,"start_character":8,"end_line":2906,"end_character":25},"updated":"2017-07-15 04:46:24.000000000","message":"You only need this \"if meta_value is None\"\n\nSetting meta_value to False also triggers this warning..","commit_id":"b6500264a935fcf36893a97a1814efe5b312cd7f"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f37a8d19e578b5d0e3abdb1decb087706de4a271","unresolved":false,"context_lines":[{"line_number":2903,"context_line":"        # in that case, single record - first one added with this call."},{"line_number":2904,"context_line":"        session \u003d get_session()"},{"line_number":2905,"context_line":""},{"line_number":2906,"context_line":"        if not meta_value:"},{"line_number":2907,"context_line":"            LOG.warning(\"%s should be properly defined in the driver.\","},{"line_number":2908,"context_line":"                        meta_key)"},{"line_number":2909,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"1f1a1f67_7b8fe574","line":2906,"range":{"start_line":2906,"start_character":8,"end_line":2906,"end_character":25},"in_reply_to":"1f1a1f67_6bc0537c","updated":"2017-07-17 12:21:29.000000000","message":"This seems like a good point, as False might be a deliberate setting for some keys.","commit_id":"b6500264a935fcf36893a97a1814efe5b312cd7f"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_base.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"e02bcd25c905837940475f99b7595f8d928763ae","unresolved":false,"context_lines":[{"line_number":742,"context_line":"            if home_node:"},{"line_number":743,"context_line":"                preferred \u003d interface.get(\u0027home-node\u0027) \u003d\u003d home_node"},{"line_number":744,"context_line":"            else:"},{"line_number":745,"context_line":"                preferred \u003d \u0027False\u0027"},{"line_number":746,"context_line":""},{"line_number":747,"context_line":"            addresses[address] \u003d {"},{"line_number":748,"context_line":"                \u0027is_admin_only\u0027: is_admin_only,"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f1a1f67_65f7c8f7","line":745,"range":{"start_line":745,"start_character":28,"end_line":745,"end_character":35},"updated":"2017-07-12 15:08:34.000000000","message":"False","commit_id":"94c9115b9fc79607d8474392623253971a0d0810"}],"releasenotes/notes/bug-1703660-fix-netapp-driver-preferred-state-0ce1a62961cded35.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"19f1306362a1988ac940db6cfd518c6b5e58d62a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Changes preferred value from None to False as setting it to None will"},{"line_number":5,"context_line":"    later on backtrace when inserting the empty value in the metadata"},{"line_number":6,"context_line":"    table where the value field is set to \"not null\"."}],"source_content_type":"text/x-yaml","patch_set":13,"id":"1f1a1f67_a1547022","line":6,"range":{"start_line":4,"start_character":4,"end_line":6,"end_character":53},"updated":"2017-07-14 05:07:18.000000000","message":"what \"preferred\" value does this refer to? Also, renos are written in past tense\n\n - Fixed the NetApp driver to report the correct value of the \"preferred\"\n    export location metadata where it cannot determine if there are any\n    \"preferred\" export locations.","commit_id":"17767ff7b6840176c9325bdc8bd103688f99cef4"}]}