)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"0b34957a0f37da942267615dc990104dad1de0f1","unresolved":false,"context_lines":[{"line_number":10,"context_line":"which resulted in unreliable behavior. This change makes"},{"line_number":11,"context_line":"the reverts synchronous."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also, the drivew now unexports and unmounts both the share and"},{"line_number":14,"context_line":"the snapshot during the revert (required to make the operation"},{"line_number":15,"context_line":"synchronous) which requires changing the driver interface to"},{"line_number":16,"context_line":"include the snapshot access rules in addition to the share access"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"df3967d1_56779803","line":13,"range":{"start_line":13,"start_character":10,"end_line":13,"end_character":16},"updated":"2017-08-02 11:22:43.000000000","message":"driver","commit_id":"a3f67f5b9e39fdaacd842e2d640b1f51bc2dcf12"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"71f9af2cca401e662f17d8398ff67a985ebb7eff","unresolved":false,"context_lines":[{"line_number":10,"context_line":"which resulted in unreliable behavior. This change makes"},{"line_number":11,"context_line":"the reverts synchronous."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Also, the drivew now unexports and unmounts both the share and"},{"line_number":14,"context_line":"the snapshot during the revert (required to make the operation"},{"line_number":15,"context_line":"synchronous) which requires changing the driver interface to"},{"line_number":16,"context_line":"include the snapshot access rules in addition to the share access"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"df3967d1_01465b50","line":13,"range":{"start_line":13,"start_character":10,"end_line":13,"end_character":16},"in_reply_to":"df3967d1_56779803","updated":"2017-08-02 17:48:07.000000000","message":"Done","commit_id":"a3f67f5b9e39fdaacd842e2d640b1f51bc2dcf12"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"0b34957a0f37da942267615dc990104dad1de0f1","unresolved":false,"context_lines":[{"line_number":16,"context_line":"include the snapshot access rules in addition to the share access"},{"line_number":17,"context_line":"rules."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Fixes-bug: 1707943"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ifea1799e1d2e3963fec7e90ce3f9cb47b9f02f4f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"df3967d1_16635044","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":18},"updated":"2017-08-02 11:22:43.000000000","message":"Closes-bug: #1707943","commit_id":"a3f67f5b9e39fdaacd842e2d640b1f51bc2dcf12"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"71f9af2cca401e662f17d8398ff67a985ebb7eff","unresolved":false,"context_lines":[{"line_number":16,"context_line":"include the snapshot access rules in addition to the share access"},{"line_number":17,"context_line":"rules."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Fixes-bug: 1707943"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: Ifea1799e1d2e3963fec7e90ce3f9cb47b9f02f4f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"df3967d1_e176b7a4","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":18},"in_reply_to":"df3967d1_16635044","updated":"2017-08-02 17:48:07.000000000","message":"Done","commit_id":"a3f67f5b9e39fdaacd842e2d640b1f51bc2dcf12"}],"etc/manila/rootwrap.d/share.filters":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f4431ffebbd6a92b335378ab06d8d15b35f5205c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"df3967d1_b0111607","updated":"2017-08-02 20:23:08.000000000","message":"please call this out in the release note","commit_id":"fb0fa2865f31779cb3e1387b3a33d0d8afc0ffff"}],"manila/share/drivers/hitachi/hnas/driver.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f4431ffebbd6a92b335378ab06d8d15b35f5205c","unresolved":false,"context_lines":[{"line_number":808,"context_line":"                  \u0027shr_size\u0027: six.text_type(new_size)})"},{"line_number":809,"context_line":""},{"line_number":810,"context_line":"    def revert_to_snapshot(self, context, snapshot, share_access_rules,"},{"line_number":811,"context_line":"                           snapshot_access_rule, share_server\u003dNone):"},{"line_number":812,"context_line":"        \"\"\"Reverts a share to a given snapshot."},{"line_number":813,"context_line":""},{"line_number":814,"context_line":"        :param context: The `context.RequestContext` object for the request"}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_301646f3","line":811,"range":{"start_line":811,"start_character":27,"end_line":811,"end_character":47},"updated":"2017-08-02 20:23:08.000000000","message":"confusing to change this here, \n\nsnapshot_access_rules","commit_id":"fb0fa2865f31779cb3e1387b3a33d0d8afc0ffff"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f4431ffebbd6a92b335378ab06d8d15b35f5205c","unresolved":false,"context_lines":[{"line_number":815,"context_line":"        :param snapshot: The snapshot to which the share is to be reverted to."},{"line_number":816,"context_line":"        :param share_access_rules: List of all access rules for the affected"},{"line_number":817,"context_line":"            share. Not used by this driver."},{"line_number":818,"context_line":"        :param snapshot_access_rule: List of all access rules for the affected"},{"line_number":819,"context_line":"            snapshot. Not used by this driver."},{"line_number":820,"context_line":"        :param share_server: Data structure with share server information."},{"line_number":821,"context_line":"            Not used by this driver."}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_f0d9de56","line":818,"range":{"start_line":818,"start_character":15,"end_line":818,"end_character":35},"updated":"2017-08-02 20:23:08.000000000","message":"same","commit_id":"fb0fa2865f31779cb3e1387b3a33d0d8afc0ffff"}],"manila/share/drivers/lvm.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"0b34957a0f37da942267615dc990104dad1de0f1","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        self._deallocate_container(share[\u0027name\u0027])"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def _unmount_device(self, share_or_snapshot):"},{"line_number":268,"context_line":"        \"\"\"Removes an access rules for a share.\"\"\""},{"line_number":269,"context_line":"        mount_path \u003d self._get_mount_path(share_or_snapshot)"},{"line_number":270,"context_line":"        if os.path.exists(mount_path):"},{"line_number":271,"context_line":"            # umount, may be busy"}],"source_content_type":"text/x-python","patch_set":4,"id":"df3967d1_36e09496","line":268,"range":{"start_line":268,"start_character":8,"end_line":268,"end_character":50},"updated":"2017-08-02 11:22:43.000000000","message":"Wrong docstring for this method.","commit_id":"a3f67f5b9e39fdaacd842e2d640b1f51bc2dcf12"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"71f9af2cca401e662f17d8398ff67a985ebb7eff","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        self._deallocate_container(share[\u0027name\u0027])"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def _unmount_device(self, share_or_snapshot):"},{"line_number":268,"context_line":"        \"\"\"Removes an access rules for a share.\"\"\""},{"line_number":269,"context_line":"        mount_path \u003d self._get_mount_path(share_or_snapshot)"},{"line_number":270,"context_line":"        if os.path.exists(mount_path):"},{"line_number":271,"context_line":"            # umount, may be busy"}],"source_content_type":"text/x-python","patch_set":4,"id":"df3967d1_81812b4d","line":268,"range":{"start_line":268,"start_character":8,"end_line":268,"end_character":50},"in_reply_to":"df3967d1_36e09496","updated":"2017-08-02 17:48:07.000000000","message":"Done","commit_id":"a3f67f5b9e39fdaacd842e2d640b1f51bc2dcf12"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"0b34957a0f37da942267615dc990104dad1de0f1","unresolved":false,"context_lines":[{"line_number":336,"context_line":"            raise exception.InvalidShare(reason\u003d\u0027Wrong share protocol\u0027)"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    def _mount_device(self, share_or_snapshot, device_name):"},{"line_number":339,"context_line":"        \"\"\"Mount LVM share and ignore if already mounted.\"\"\""},{"line_number":340,"context_line":"        mount_path \u003d self._get_mount_path(share_or_snapshot)"},{"line_number":341,"context_line":"        self._execute(\u0027mkdir\u0027, \u0027-p\u0027, mount_path)"},{"line_number":342,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"df3967d1_f698cc1b","line":339,"range":{"start_line":339,"start_character":8,"end_line":339,"end_character":60},"updated":"2017-08-02 11:22:43.000000000","message":"Update doc string.","commit_id":"a3f67f5b9e39fdaacd842e2d640b1f51bc2dcf12"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"71f9af2cca401e662f17d8398ff67a985ebb7eff","unresolved":false,"context_lines":[{"line_number":336,"context_line":"            raise exception.InvalidShare(reason\u003d\u0027Wrong share protocol\u0027)"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    def _mount_device(self, share_or_snapshot, device_name):"},{"line_number":339,"context_line":"        \"\"\"Mount LVM share and ignore if already mounted.\"\"\""},{"line_number":340,"context_line":"        mount_path \u003d self._get_mount_path(share_or_snapshot)"},{"line_number":341,"context_line":"        self._execute(\u0027mkdir\u0027, \u0027-p\u0027, mount_path)"},{"line_number":342,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":4,"id":"df3967d1_018d3b7a","line":339,"range":{"start_line":339,"start_character":8,"end_line":339,"end_character":60},"in_reply_to":"df3967d1_f698cc1b","updated":"2017-08-02 17:48:07.000000000","message":"Done","commit_id":"a3f67f5b9e39fdaacd842e2d640b1f51bc2dcf12"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"0b34957a0f37da942267615dc990104dad1de0f1","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        return mount_path"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"    def _get_mount_path(self, share_or_snapshot):"},{"line_number":356,"context_line":"        \"\"\"Returns path where share is mounted.\"\"\""},{"line_number":357,"context_line":"        return os.path.join(self.configuration.share_mount_path,"},{"line_number":358,"context_line":"                            share_or_snapshot[\u0027name\u0027])"},{"line_number":359,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"df3967d1_16bfd061","line":356,"range":{"start_line":356,"start_character":7,"end_line":356,"end_character":50},"updated":"2017-08-02 11:22:43.000000000","message":"Update doc string.","commit_id":"a3f67f5b9e39fdaacd842e2d640b1f51bc2dcf12"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"71f9af2cca401e662f17d8398ff67a985ebb7eff","unresolved":false,"context_lines":[{"line_number":353,"context_line":"        return mount_path"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"    def _get_mount_path(self, share_or_snapshot):"},{"line_number":356,"context_line":"        \"\"\"Returns path where share is mounted.\"\"\""},{"line_number":357,"context_line":"        return os.path.join(self.configuration.share_mount_path,"},{"line_number":358,"context_line":"                            share_or_snapshot[\u0027name\u0027])"},{"line_number":359,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"df3967d1_e1e9171a","line":356,"range":{"start_line":356,"start_character":7,"end_line":356,"end_character":50},"in_reply_to":"df3967d1_16bfd061","updated":"2017-08-02 17:48:07.000000000","message":"Done","commit_id":"a3f67f5b9e39fdaacd842e2d640b1f51bc2dcf12"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"085216331fbfaae22d71d7a5737a747353f23dc2","unresolved":false,"context_lines":[{"line_number":265,"context_line":"        self._deallocate_container(share[\u0027name\u0027])"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"    def _unmount_device(self, share_or_snapshot):"},{"line_number":268,"context_line":"        \"\"\"Unmount the filesystem of a share or snapshot LV\"\"\""},{"line_number":269,"context_line":"        mount_path \u003d self._get_mount_path(share_or_snapshot)"},{"line_number":270,"context_line":"        if os.path.exists(mount_path):"},{"line_number":271,"context_line":"            # umount, may be busy"}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_0465481e","line":268,"range":{"start_line":268,"start_character":57,"end_line":268,"end_character":60},"updated":"2017-08-02 19:15:17.000000000","message":"nit: LV.","commit_id":"fb0fa2865f31779cb3e1387b3a33d0d8afc0ffff"}],"manila/share/drivers/netapp/dataontap/cluster_mode/drv_multi_svm.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f4431ffebbd6a92b335378ab06d8d15b35f5205c","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        return self.library.create_snapshot(context, snapshot, **kwargs)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def revert_to_snapshot(self, context, snapshot, share_access_rules,"},{"line_number":59,"context_line":"                           snapshot_access_rule, **kwargs):"},{"line_number":60,"context_line":"        return self.library.revert_to_snapshot(context, snapshot, **kwargs)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def delete_share(self, context, share, **kwargs):"}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_b0dfd638","line":59,"range":{"start_line":59,"start_character":27,"end_line":59,"end_character":47},"updated":"2017-08-02 20:23:08.000000000","message":"same comment, \n\nsnapshot_access_rules","commit_id":"fb0fa2865f31779cb3e1387b3a33d0d8afc0ffff"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f4431ffebbd6a92b335378ab06d8d15b35f5205c","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    def revert_to_replicated_snapshot(self, context, active_replica,"},{"line_number":173,"context_line":"                                      replica_list, active_replica_snapshot,"},{"line_number":174,"context_line":"                                      replica_snapshots, share_access_rules,"},{"line_number":175,"context_line":"                                      snapshot_access_rule,"},{"line_number":176,"context_line":"                                      share_server\u003dNone):"},{"line_number":177,"context_line":"        raise NotImplementedError()"},{"line_number":178,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_70e5ee08","line":175,"range":{"start_line":175,"start_character":38,"end_line":175,"end_character":58},"updated":"2017-08-02 20:23:08.000000000","message":"same","commit_id":"fb0fa2865f31779cb3e1387b3a33d0d8afc0ffff"}],"manila/share/drivers/netapp/dataontap/cluster_mode/drv_single_svm.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f4431ffebbd6a92b335378ab06d8d15b35f5205c","unresolved":false,"context_lines":[{"line_number":56,"context_line":"        return self.library.create_snapshot(context, snapshot, **kwargs)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    def revert_to_snapshot(self, context, snapshot, share_access_rules,"},{"line_number":59,"context_line":"                           snapshot_access_rule, **kwargs):"},{"line_number":60,"context_line":"        return self.library.revert_to_snapshot(context, snapshot, **kwargs)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def delete_share(self, context, share, **kwargs):"}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_30ebe6dc","line":59,"range":{"start_line":59,"start_character":27,"end_line":59,"end_character":47},"updated":"2017-08-02 20:23:08.000000000","message":"snapshot_access_rules","commit_id":"fb0fa2865f31779cb3e1387b3a33d0d8afc0ffff"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f4431ffebbd6a92b335378ab06d8d15b35f5205c","unresolved":false,"context_lines":[{"line_number":187,"context_line":"    def revert_to_replicated_snapshot(self, context, active_replica,"},{"line_number":188,"context_line":"                                      replica_list, active_replica_snapshot,"},{"line_number":189,"context_line":"                                      replica_snapshots, share_access_rules,"},{"line_number":190,"context_line":"                                      snapshot_access_rule,"},{"line_number":191,"context_line":"                                      **kwargs):"},{"line_number":192,"context_line":"        return self.library.revert_to_replicated_snapshot("},{"line_number":193,"context_line":"            context, active_replica, replica_list, active_replica_snapshot,"}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_f0c2fe58","line":190,"range":{"start_line":190,"start_character":38,"end_line":190,"end_character":58},"updated":"2017-08-02 20:23:08.000000000","message":"same","commit_id":"fb0fa2865f31779cb3e1387b3a33d0d8afc0ffff"}],"manila/share/manager.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"0b34957a0f37da942267615dc990104dad1de0f1","unresolved":false,"context_lines":[{"line_number":2597,"context_line":"        share \u003d snapshot[\u0027share\u0027]"},{"line_number":2598,"context_line":"        share_id \u003d share[\u0027id\u0027]"},{"line_number":2599,"context_line":"        share_instance_id \u003d snapshot.instance.share_instance_id"},{"line_number":2600,"context_line":"        share_access_rules \u003d \\"},{"line_number":2601,"context_line":"            self.access_helper.get_share_instance_access_rules("},{"line_number":2602,"context_line":"                context, filters\u003d{\u0027state\u0027: constants.STATUS_ACTIVE},"},{"line_number":2603,"context_line":"                share_instance_id\u003dshare_instance_id)"},{"line_number":2604,"context_line":"        snapshot_access_rules \u003d \\"},{"line_number":2605,"context_line":"            self.snapshot_access_helper.get_snapshot_instance_access_rules("},{"line_number":2606,"context_line":"                context, snapshot.instance[\u0027id\u0027])"},{"line_number":2607,"context_line":""},{"line_number":2608,"context_line":"        if share.get(\u0027has_replicas\u0027):"},{"line_number":2609,"context_line":"            self._revert_to_replicated_snapshot("}],"source_content_type":"text/x-python","patch_set":4,"id":"df3967d1_b63ec4d7","line":2606,"range":{"start_line":2600,"start_character":0,"end_line":2606,"end_character":49},"updated":"2017-08-02 11:22:43.000000000","message":"Use parens rather than \\ for line continuation.","commit_id":"a3f67f5b9e39fdaacd842e2d640b1f51bc2dcf12"}],"manila/tests/share/drivers/test_lvm.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"085216331fbfaae22d71d7a5737a747353f23dc2","unresolved":false,"context_lines":[{"line_number":352,"context_line":"            self._helper_nfs.create_exports.assert_called_once_with("},{"line_number":353,"context_line":"                self.server, self.share[\u0027name\u0027], recreate\u003dTrue)"},{"line_number":354,"context_line":""},{"line_number":355,"context_line":"    def test_delete_share(self):"},{"line_number":356,"context_line":"        mount_path \u003d self._get_mount_path(self.share)"},{"line_number":357,"context_line":"        self._helper_nfs.remove_export(mount_path, self.share[\u0027name\u0027])"},{"line_number":358,"context_line":"        self._driver._delete_share(self._context, self.share)"},{"line_number":359,"context_line":""},{"line_number":360,"context_line":"    def test_delete_snapshot(self):"},{"line_number":361,"context_line":"        mount_path \u003d self._get_mount_path(self.snapshot)"}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_87a49aa7","line":358,"range":{"start_line":355,"start_character":0,"end_line":358,"end_character":61},"updated":"2017-08-02 19:15:17.000000000","message":"This unit test makes no assertions and coverage tool shows it uncovered.  Pre-existing issue though.","commit_id":"fb0fa2865f31779cb3e1387b3a33d0d8afc0ffff"}],"releasenotes/notes/bug-1707943-make-lvm-revert-synchronous-0ef5baee3367fd27.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f4431ffebbd6a92b335378ab06d8d15b35f5205c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"df3967d1_509c2a69","updated":"2017-08-02 20:23:08.000000000","message":"upgrade:\n\n  - Changes to rootwrap.conf are necessary","commit_id":"fb0fa2865f31779cb3e1387b3a33d0d8afc0ffff"}]}
