)]}'
{"manila/share/access.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"91d6000af28a3141f291b9761a4dcb7612786abc","unresolved":false,"context_lines":[{"line_number":373,"context_line":"                                           rules_to_be_removed_from_db,"},{"line_number":374,"context_line":"                                           share_server):"},{"line_number":375,"context_line":"        driver_rule_updates \u003d {}"},{"line_number":376,"context_line":"        share \u003d self.db.share_get(context, share_instance[\u0027share_id\u0027])"},{"line_number":377,"context_line":"        si_proto \u003d share[\u0027share_proto\u0027].lower()"},{"line_number":378,"context_line":"        if not self.driver.ipv6_implemented:"},{"line_number":379,"context_line":"            add_rules \u003d self._filter_ipv6_rules(add_rules, si_proto)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_4ea999dd","line":376,"range":{"start_line":376,"start_character":0,"end_line":376,"end_character":70},"updated":"2017-07-30 01:13:36.000000000","message":"you don\u0027t need the share here, share_instance has \"share_proto\" attribute:\n\n\nhttps://github.com/openstack/manila/blob/2b40e56/manila/share/access.py#L246\nhttps://github.com/openstack/manila/blob/2b40e5/manila/db/sqlalchemy/models.py#L348","commit_id":"11d92cb842c693c148bb0a9ea6c0e572d70db41c"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"6d556fc0601c25425c1adc92602054e3e3852b98","unresolved":false,"context_lines":[{"line_number":373,"context_line":"                                           rules_to_be_removed_from_db,"},{"line_number":374,"context_line":"                                           share_server):"},{"line_number":375,"context_line":"        driver_rule_updates \u003d {}"},{"line_number":376,"context_line":"        share \u003d self.db.share_get(context, share_instance[\u0027share_id\u0027])"},{"line_number":377,"context_line":"        si_proto \u003d share[\u0027share_proto\u0027].lower()"},{"line_number":378,"context_line":"        if not self.driver.ipv6_implemented:"},{"line_number":379,"context_line":"            add_rules \u003d self._filter_ipv6_rules(add_rules, si_proto)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_fe2a3a8e","line":376,"range":{"start_line":376,"start_character":0,"end_line":376,"end_character":70},"in_reply_to":"df3967d1_4ea999dd","updated":"2017-07-31 03:10:31.000000000","message":"Done","commit_id":"11d92cb842c693c148bb0a9ea6c0e572d70db41c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"91d6000af28a3141f291b9761a4dcb7612786abc","unresolved":false,"context_lines":[{"line_number":374,"context_line":"                                           share_server):"},{"line_number":375,"context_line":"        driver_rule_updates \u003d {}"},{"line_number":376,"context_line":"        share \u003d self.db.share_get(context, share_instance[\u0027share_id\u0027])"},{"line_number":377,"context_line":"        si_proto \u003d share[\u0027share_proto\u0027].lower()"},{"line_number":378,"context_line":"        if not self.driver.ipv6_implemented:"},{"line_number":379,"context_line":"            add_rules \u003d self._filter_ipv6_rules(add_rules, si_proto)"},{"line_number":380,"context_line":"            delete_rules \u003d self._filter_ipv6_rules(delete_rules, si_proto)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_0eab91d6","line":377,"range":{"start_line":377,"start_character":8,"end_line":377,"end_character":16},"updated":"2017-07-30 01:13:36.000000000","message":"share_protocol","commit_id":"11d92cb842c693c148bb0a9ea6c0e572d70db41c"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"6d556fc0601c25425c1adc92602054e3e3852b98","unresolved":false,"context_lines":[{"line_number":374,"context_line":"                                           share_server):"},{"line_number":375,"context_line":"        driver_rule_updates \u003d {}"},{"line_number":376,"context_line":"        share \u003d self.db.share_get(context, share_instance[\u0027share_id\u0027])"},{"line_number":377,"context_line":"        si_proto \u003d share[\u0027share_proto\u0027].lower()"},{"line_number":378,"context_line":"        if not self.driver.ipv6_implemented:"},{"line_number":379,"context_line":"            add_rules \u003d self._filter_ipv6_rules(add_rules, si_proto)"},{"line_number":380,"context_line":"            delete_rules \u003d self._filter_ipv6_rules(delete_rules, si_proto)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_de19b688","line":377,"range":{"start_line":377,"start_character":8,"end_line":377,"end_character":16},"in_reply_to":"df3967d1_0eab91d6","updated":"2017-07-31 03:10:31.000000000","message":"Done","commit_id":"11d92cb842c693c148bb0a9ea6c0e572d70db41c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"91d6000af28a3141f291b9761a4dcb7612786abc","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        driver_rule_updates \u003d {}"},{"line_number":376,"context_line":"        share \u003d self.db.share_get(context, share_instance[\u0027share_id\u0027])"},{"line_number":377,"context_line":"        si_proto \u003d share[\u0027share_proto\u0027].lower()"},{"line_number":378,"context_line":"        if not self.driver.ipv6_implemented:"},{"line_number":379,"context_line":"            add_rules \u003d self._filter_ipv6_rules(add_rules, si_proto)"},{"line_number":380,"context_line":"            delete_rules \u003d self._filter_ipv6_rules(delete_rules, si_proto)"},{"line_number":381,"context_line":"            access_rules_to_be_on_share \u003d self._filter_ipv6_rules("}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_eeb72d3a","line":378,"range":{"start_line":378,"start_character":43,"end_line":378,"end_character":44},"updated":"2017-07-30 01:13:36.000000000","message":"and share_protocol \u003d\u003d \u0027nfs\u0027","commit_id":"11d92cb842c693c148bb0a9ea6c0e572d70db41c"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"6d556fc0601c25425c1adc92602054e3e3852b98","unresolved":false,"context_lines":[{"line_number":375,"context_line":"        driver_rule_updates \u003d {}"},{"line_number":376,"context_line":"        share \u003d self.db.share_get(context, share_instance[\u0027share_id\u0027])"},{"line_number":377,"context_line":"        si_proto \u003d share[\u0027share_proto\u0027].lower()"},{"line_number":378,"context_line":"        if not self.driver.ipv6_implemented:"},{"line_number":379,"context_line":"            add_rules \u003d self._filter_ipv6_rules(add_rules, si_proto)"},{"line_number":380,"context_line":"            delete_rules \u003d self._filter_ipv6_rules(delete_rules, si_proto)"},{"line_number":381,"context_line":"            access_rules_to_be_on_share \u003d self._filter_ipv6_rules("}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_9e132e67","line":378,"range":{"start_line":378,"start_character":43,"end_line":378,"end_character":44},"in_reply_to":"df3967d1_eeb72d3a","updated":"2017-07-31 03:10:31.000000000","message":"Done","commit_id":"11d92cb842c693c148bb0a9ea6c0e572d70db41c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"91d6000af28a3141f291b9761a4dcb7612786abc","unresolved":false,"context_lines":[{"line_number":376,"context_line":"        share \u003d self.db.share_get(context, share_instance[\u0027share_id\u0027])"},{"line_number":377,"context_line":"        si_proto \u003d share[\u0027share_proto\u0027].lower()"},{"line_number":378,"context_line":"        if not self.driver.ipv6_implemented:"},{"line_number":379,"context_line":"            add_rules \u003d self._filter_ipv6_rules(add_rules, si_proto)"},{"line_number":380,"context_line":"            delete_rules \u003d self._filter_ipv6_rules(delete_rules, si_proto)"},{"line_number":381,"context_line":"            access_rules_to_be_on_share \u003d self._filter_ipv6_rules("},{"line_number":382,"context_line":"                access_rules_to_be_on_share, si_proto)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_ae836556","line":379,"range":{"start_line":379,"start_character":57,"end_line":379,"end_character":67},"updated":"2017-07-30 01:13:36.000000000","message":"remove","commit_id":"11d92cb842c693c148bb0a9ea6c0e572d70db41c"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"6d556fc0601c25425c1adc92602054e3e3852b98","unresolved":false,"context_lines":[{"line_number":376,"context_line":"        share \u003d self.db.share_get(context, share_instance[\u0027share_id\u0027])"},{"line_number":377,"context_line":"        si_proto \u003d share[\u0027share_proto\u0027].lower()"},{"line_number":378,"context_line":"        if not self.driver.ipv6_implemented:"},{"line_number":379,"context_line":"            add_rules \u003d self._filter_ipv6_rules(add_rules, si_proto)"},{"line_number":380,"context_line":"            delete_rules \u003d self._filter_ipv6_rules(delete_rules, si_proto)"},{"line_number":381,"context_line":"            access_rules_to_be_on_share \u003d self._filter_ipv6_rules("},{"line_number":382,"context_line":"                access_rules_to_be_on_share, si_proto)"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_7e188a80","line":379,"range":{"start_line":379,"start_character":57,"end_line":379,"end_character":67},"in_reply_to":"df3967d1_ae836556","updated":"2017-07-31 03:10:31.000000000","message":"Done","commit_id":"11d92cb842c693c148bb0a9ea6c0e572d70db41c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"91d6000af28a3141f291b9761a4dcb7612786abc","unresolved":false,"context_lines":[{"line_number":377,"context_line":"        si_proto \u003d share[\u0027share_proto\u0027].lower()"},{"line_number":378,"context_line":"        if not self.driver.ipv6_implemented:"},{"line_number":379,"context_line":"            add_rules \u003d self._filter_ipv6_rules(add_rules, si_proto)"},{"line_number":380,"context_line":"            delete_rules \u003d self._filter_ipv6_rules(delete_rules, si_proto)"},{"line_number":381,"context_line":"            access_rules_to_be_on_share \u003d self._filter_ipv6_rules("},{"line_number":382,"context_line":"                access_rules_to_be_on_share, si_proto)"},{"line_number":383,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_8e88a171","line":380,"range":{"start_line":380,"start_character":63,"end_line":380,"end_character":73},"updated":"2017-07-30 01:13:36.000000000","message":"remove","commit_id":"11d92cb842c693c148bb0a9ea6c0e572d70db41c"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"6d556fc0601c25425c1adc92602054e3e3852b98","unresolved":false,"context_lines":[{"line_number":377,"context_line":"        si_proto \u003d share[\u0027share_proto\u0027].lower()"},{"line_number":378,"context_line":"        if not self.driver.ipv6_implemented:"},{"line_number":379,"context_line":"            add_rules \u003d self._filter_ipv6_rules(add_rules, si_proto)"},{"line_number":380,"context_line":"            delete_rules \u003d self._filter_ipv6_rules(delete_rules, si_proto)"},{"line_number":381,"context_line":"            access_rules_to_be_on_share \u003d self._filter_ipv6_rules("},{"line_number":382,"context_line":"                access_rules_to_be_on_share, si_proto)"},{"line_number":383,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_5e0dc63c","line":380,"range":{"start_line":380,"start_character":63,"end_line":380,"end_character":73},"in_reply_to":"df3967d1_8e88a171","updated":"2017-07-31 03:10:31.000000000","message":"Done","commit_id":"11d92cb842c693c148bb0a9ea6c0e572d70db41c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"91d6000af28a3141f291b9761a4dcb7612786abc","unresolved":false,"context_lines":[{"line_number":379,"context_line":"            add_rules \u003d self._filter_ipv6_rules(add_rules, si_proto)"},{"line_number":380,"context_line":"            delete_rules \u003d self._filter_ipv6_rules(delete_rules, si_proto)"},{"line_number":381,"context_line":"            access_rules_to_be_on_share \u003d self._filter_ipv6_rules("},{"line_number":382,"context_line":"                access_rules_to_be_on_share, si_proto)"},{"line_number":383,"context_line":"        try:"},{"line_number":384,"context_line":"            driver_rule_updates \u003d self.driver.update_access("},{"line_number":385,"context_line":"                context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_6e7d7d6d","line":382,"range":{"start_line":382,"start_character":43,"end_line":382,"end_character":53},"updated":"2017-07-30 01:13:36.000000000","message":"remove","commit_id":"11d92cb842c693c148bb0a9ea6c0e572d70db41c"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"6d556fc0601c25425c1adc92602054e3e3852b98","unresolved":false,"context_lines":[{"line_number":379,"context_line":"            add_rules \u003d self._filter_ipv6_rules(add_rules, si_proto)"},{"line_number":380,"context_line":"            delete_rules \u003d self._filter_ipv6_rules(delete_rules, si_proto)"},{"line_number":381,"context_line":"            access_rules_to_be_on_share \u003d self._filter_ipv6_rules("},{"line_number":382,"context_line":"                access_rules_to_be_on_share, si_proto)"},{"line_number":383,"context_line":"        try:"},{"line_number":384,"context_line":"            driver_rule_updates \u003d self.driver.update_access("},{"line_number":385,"context_line":"                context,"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_3e0a0226","line":382,"range":{"start_line":382,"start_character":43,"end_line":382,"end_character":53},"in_reply_to":"df3967d1_6e7d7d6d","updated":"2017-07-31 03:10:31.000000000","message":"Done","commit_id":"11d92cb842c693c148bb0a9ea6c0e572d70db41c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"91d6000af28a3141f291b9761a4dcb7612786abc","unresolved":false,"context_lines":[{"line_number":470,"context_line":"        return access_rules_to_be_on_share"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"    @staticmethod"},{"line_number":473,"context_line":"    def _filter_ipv6_rules(rules, share_instance_proto):"},{"line_number":474,"context_line":"        filtered \u003d []"},{"line_number":475,"context_line":"        for rule in rules:"},{"line_number":476,"context_line":"            if rule[\u0027access_type\u0027] \u003d\u003d \u0027ip\u0027 and share_instance_proto \u003d\u003d \u0027nfs\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_2e977593","line":473,"range":{"start_line":473,"start_character":32,"end_line":473,"end_character":54},"updated":"2017-07-30 01:13:36.000000000","message":"not necessary","commit_id":"11d92cb842c693c148bb0a9ea6c0e572d70db41c"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"6d556fc0601c25425c1adc92602054e3e3852b98","unresolved":false,"context_lines":[{"line_number":470,"context_line":"        return access_rules_to_be_on_share"},{"line_number":471,"context_line":""},{"line_number":472,"context_line":"    @staticmethod"},{"line_number":473,"context_line":"    def _filter_ipv6_rules(rules, share_instance_proto):"},{"line_number":474,"context_line":"        filtered \u003d []"},{"line_number":475,"context_line":"        for rule in rules:"},{"line_number":476,"context_line":"            if rule[\u0027access_type\u0027] \u003d\u003d \u0027ip\u0027 and share_instance_proto \u003d\u003d \u0027nfs\u0027:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_81606f34","line":473,"range":{"start_line":473,"start_character":32,"end_line":473,"end_character":54},"in_reply_to":"df3967d1_2e977593","updated":"2017-07-31 03:10:31.000000000","message":"Done","commit_id":"11d92cb842c693c148bb0a9ea6c0e572d70db41c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"91d6000af28a3141f291b9761a4dcb7612786abc","unresolved":false,"context_lines":[{"line_number":473,"context_line":"    def _filter_ipv6_rules(rules, share_instance_proto):"},{"line_number":474,"context_line":"        filtered \u003d []"},{"line_number":475,"context_line":"        for rule in rules:"},{"line_number":476,"context_line":"            if rule[\u0027access_type\u0027] \u003d\u003d \u0027ip\u0027 and share_instance_proto \u003d\u003d \u0027nfs\u0027:"},{"line_number":477,"context_line":"                ip_version \u003d ipaddress.ip_network("},{"line_number":478,"context_line":"                    six.text_type(rule[\u0027access_to\u0027])).version"},{"line_number":479,"context_line":"                if 6 \u003d\u003d ip_version:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_0e94b18a","line":476,"range":{"start_line":476,"start_character":42,"end_line":476,"end_character":76},"updated":"2017-07-30 01:13:36.000000000","message":"remove","commit_id":"11d92cb842c693c148bb0a9ea6c0e572d70db41c"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"6d556fc0601c25425c1adc92602054e3e3852b98","unresolved":false,"context_lines":[{"line_number":473,"context_line":"    def _filter_ipv6_rules(rules, share_instance_proto):"},{"line_number":474,"context_line":"        filtered \u003d []"},{"line_number":475,"context_line":"        for rule in rules:"},{"line_number":476,"context_line":"            if rule[\u0027access_type\u0027] \u003d\u003d \u0027ip\u0027 and share_instance_proto \u003d\u003d \u0027nfs\u0027:"},{"line_number":477,"context_line":"                ip_version \u003d ipaddress.ip_network("},{"line_number":478,"context_line":"                    six.text_type(rule[\u0027access_to\u0027])).version"},{"line_number":479,"context_line":"                if 6 \u003d\u003d ip_version:"}],"source_content_type":"text/x-python","patch_set":1,"id":"df3967d1_61558b50","line":476,"range":{"start_line":476,"start_character":42,"end_line":476,"end_character":76},"in_reply_to":"df3967d1_0e94b18a","updated":"2017-07-31 03:10:31.000000000","message":"Done","commit_id":"11d92cb842c693c148bb0a9ea6c0e572d70db41c"}],"manila/tests/share/test_access.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6efa6aefe57800e7ff5ff2e4c35e9b365bdad387","unresolved":false,"context_lines":[{"line_number":761,"context_line":"        driver_update_rules \u003d ("},{"line_number":762,"context_line":"            self.access_helper._update_rules_through_share_driver("},{"line_number":763,"context_line":"                self.context, share_instance\u003dshare_instance,"},{"line_number":764,"context_line":"                access_rules_to_be_on_share\u003dtest_rules,"},{"line_number":765,"context_line":"                add_rules\u003dtest_rules,"},{"line_number":766,"context_line":"                delete_rules\u003dtest_rules,"},{"line_number":767,"context_line":"                rules_to_be_removed_from_db\u003dtest_rules,"},{"line_number":768,"context_line":"                share_server\u003dNone))"},{"line_number":769,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_49f04a91","line":766,"range":{"start_line":764,"start_character":16,"end_line":766,"end_character":40},"updated":"2017-08-01 03:27:26.000000000","message":"test_rules to all three?","commit_id":"079763af54324f19f17ecdc867b4c10659565307"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c0e615be7ca460fd3421cda8a09e08e566347f4d","unresolved":false,"context_lines":[{"line_number":761,"context_line":"        driver_update_rules \u003d ("},{"line_number":762,"context_line":"            self.access_helper._update_rules_through_share_driver("},{"line_number":763,"context_line":"                self.context, share_instance\u003dshare_instance,"},{"line_number":764,"context_line":"                access_rules_to_be_on_share\u003dtest_rules,"},{"line_number":765,"context_line":"                add_rules\u003dtest_rules,"},{"line_number":766,"context_line":"                delete_rules\u003dtest_rules,"},{"line_number":767,"context_line":"                rules_to_be_removed_from_db\u003dtest_rules,"},{"line_number":768,"context_line":"                share_server\u003dNone))"},{"line_number":769,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_43f6cffb","line":766,"range":{"start_line":764,"start_character":16,"end_line":766,"end_character":40},"in_reply_to":"df3967d1_490cc93a","updated":"2017-08-01 18:16:01.000000000","message":"But the test data must make sense to the unit/method... please use a different set of rules for delete..","commit_id":"079763af54324f19f17ecdc867b4c10659565307"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"bbf1a58ac66e8f6675f93eaec4482a911754cc0a","unresolved":false,"context_lines":[{"line_number":761,"context_line":"        driver_update_rules \u003d ("},{"line_number":762,"context_line":"            self.access_helper._update_rules_through_share_driver("},{"line_number":763,"context_line":"                self.context, share_instance\u003dshare_instance,"},{"line_number":764,"context_line":"                access_rules_to_be_on_share\u003dtest_rules,"},{"line_number":765,"context_line":"                add_rules\u003dtest_rules,"},{"line_number":766,"context_line":"                delete_rules\u003dtest_rules,"},{"line_number":767,"context_line":"                rules_to_be_removed_from_db\u003dtest_rules,"},{"line_number":768,"context_line":"                share_server\u003dNone))"},{"line_number":769,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"df3967d1_490cc93a","line":766,"range":{"start_line":764,"start_character":16,"end_line":766,"end_character":40},"in_reply_to":"df3967d1_49f04a91","updated":"2017-08-01 06:04:15.000000000","message":"yes, use test_rules to test ignore ipv6 access rules. so I am not build different rules to distinguish add_rules, delete_rules and  access_rules_to_be_on_share.","commit_id":"079763af54324f19f17ecdc867b4c10659565307"}],"releasenotes/notes/bug-1707066-deny-ipv6-access-in-error-bce379ee310060f6.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6efa6aefe57800e7ff5ff2e4c35e9b365bdad387","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Fixed cannot deny ipv6 access rule."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"df3967d1_a96c5636","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":39},"updated":"2017-08-01 03:27:26.000000000","message":"Can you add a more descriptive message here, only because it is a very confusing feature/bug:\n\n - The access-allow API accepts ipv6 rules and ignores them if the   \n    configured backend does not support ipv6 access rules. \n    However, when the access-deny API is invoked to remove such\n    rules, they used to be stuck in \"denying\" state. This bug has been\n    fixed and ipv6 access rules can be denied successfully.","commit_id":"079763af54324f19f17ecdc867b4c10659565307"},{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"da1a93aa11c5e7c3889c6a7e3591d9f37d62a425","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - The access-allow API accepts ipv6 rules and ignores them if the"},{"line_number":4,"context_line":"    configured backend does not support ipv6 access rules."},{"line_number":5,"context_line":"    However, when the access-deny API is invoked to remove such"},{"line_number":6,"context_line":"    rules, they used to be stuck in \"denying\" state. This bug has been"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df3967d1_13e123d1","line":3,"range":{"start_line":3,"start_character":3,"end_line":3,"end_character":4},"updated":"2017-08-02 09:45:05.000000000","message":"add | for multiple lines","commit_id":"9cf89f118ea922ae24818338502a67fa51901e00"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"bb8e3da8e37d99e4c9fa3fd0cd29388208da93e2","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - The access-allow API accepts ipv6 rules and ignores them if the"},{"line_number":4,"context_line":"    configured backend does not support ipv6 access rules."},{"line_number":5,"context_line":"    However, when the access-deny API is invoked to remove such"},{"line_number":6,"context_line":"    rules, they used to be stuck in \"denying\" state. This bug has been"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df3967d1_66953d40","line":3,"range":{"start_line":3,"start_character":3,"end_line":3,"end_character":4},"in_reply_to":"df3967d1_13e123d1","updated":"2017-08-02 18:23:03.000000000","message":"I think we only need to use \u0027|\u0027 if we want to escape the following text to reatin the newlines but we really don\u0027t care how the text in this paragraph gets wrapped by sphinx when it renders the doc so we don\u0027t need it.\n\nhttps://docs.openstack.org/reno/latest/user/usage.html#creating-new-release-notes","commit_id":"9cf89f118ea922ae24818338502a67fa51901e00"}]}
