)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"599b49cd294129c4b4954d5f1511f702d26074d4","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ben Swartzlander \u003cben@swartzlander.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-08-01 13:14:42 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix NFSHelper 0-length netmask bug"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add special case handling of 0-length netmasks in NFS helper."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"df3967d1_f1cc5fbd","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":34},"updated":"2017-08-02 08:38:25.000000000","message":"Could add some description about what happening if we got 0-length netmask.","commit_id":"9b4d620c84a0e34350a4bf7385dd858654c42d10"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"42aa7b4945fdf4dda0f4ba82e41d1b5f69d07e64","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Ben Swartzlander \u003cben@swartzlander.org\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-08-01 13:14:42 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix NFSHelper 0-length netmask bug"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add special case handling of 0-length netmasks in NFS helper."},{"line_number":10,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"df3967d1_4bf482cf","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":34},"in_reply_to":"df3967d1_f1cc5fbd","updated":"2017-08-02 17:22:32.000000000","message":"I linked the correct bug and added some more details below.","commit_id":"9b4d620c84a0e34350a4bf7385dd858654c42d10"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"599b49cd294129c4b4954d5f1511f702d26074d4","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Also split out utility function for wrapping IPv6 addresses with"},{"line_number":12,"context_line":"square brackets."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes bug: 1707943"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Id907478837099b250a6c88b6b5ff50c214bcdbb2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"df3967d1_ae89d2ca","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":19},"updated":"2017-08-02 08:38:25.000000000","message":"Closes-bug: 1707943","commit_id":"9b4d620c84a0e34350a4bf7385dd858654c42d10"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"599b49cd294129c4b4954d5f1511f702d26074d4","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Also split out utility function for wrapping IPv6 addresses with"},{"line_number":12,"context_line":"square brackets."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes bug: 1707943"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Id907478837099b250a6c88b6b5ff50c214bcdbb2"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"df3967d1_0e357ef7","line":14,"range":{"start_line":14,"start_character":11,"end_line":14,"end_character":19},"updated":"2017-08-02 08:38:25.000000000","message":"https://bugs.launchpad.net/manila/+bug/1707943\nI am not sure what is relationship between \u0027LVM revert is not synchronous\u0027 and \u0027Fix NFSHelper 0-length netmask bug\u0027?","commit_id":"9b4d620c84a0e34350a4bf7385dd858654c42d10"}],"manila/share/drivers/helpers.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"599b49cd294129c4b4954d5f1511f702d26074d4","unresolved":false,"context_lines":[{"line_number":321,"context_line":"                reason\u003d_(\"Invalid address or cidr supplied %s.\") % access_to)"},{"line_number":322,"context_line":"        mask_length \u003d network.prefixlen"},{"line_number":323,"context_line":"        address \u003d access_to.split(\u0027/\u0027)[0]"},{"line_number":324,"context_line":"        if mask_length \u003d\u003d 0:"},{"line_number":325,"context_line":"            # Special case because Linux exports don\u0027t support /0 netmasks"},{"line_number":326,"context_line":"            return \u0027*\u0027"},{"line_number":327,"context_line":"        if network.version \u003d\u003d 4:"},{"line_number":328,"context_line":"            if mask_length \u003d\u003d 32:"},{"line_number":329,"context_line":"                return address"}],"source_content_type":"text/x-python","patch_set":4,"id":"df3967d1_07e1e1d0","line":326,"range":{"start_line":324,"start_character":5,"end_line":326,"end_character":22},"updated":"2017-08-02 08:38:25.000000000","message":"How about 0.0.0.0, should we change 0.0.0.0 to *? We have the same problem with 0.0.0.0.","commit_id":"9b4d620c84a0e34350a4bf7385dd858654c42d10"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"f172d28b1cce0570a01133c5ddbfa317c3e81e4f","unresolved":false,"context_lines":[{"line_number":321,"context_line":"                reason\u003d_(\"Invalid address or cidr supplied %s.\") % access_to)"},{"line_number":322,"context_line":"        mask_length \u003d network.prefixlen"},{"line_number":323,"context_line":"        address \u003d access_to.split(\u0027/\u0027)[0]"},{"line_number":324,"context_line":"        if mask_length \u003d\u003d 0:"},{"line_number":325,"context_line":"            # Special case because Linux exports don\u0027t support /0 netmasks"},{"line_number":326,"context_line":"            return \u0027*\u0027"},{"line_number":327,"context_line":"        if network.version \u003d\u003d 4:"},{"line_number":328,"context_line":"            if mask_length \u003d\u003d 32:"},{"line_number":329,"context_line":"                return address"}],"source_content_type":"text/x-python","patch_set":4,"id":"df3967d1_93d07221","line":326,"range":{"start_line":324,"start_character":5,"end_line":326,"end_character":22},"in_reply_to":"df3967d1_07e1e1d0","updated":"2017-08-02 10:11:28.000000000","message":"0.0.0.0 is network address. so it looks good to cover case of CIDR - 0.0.0.0/0","commit_id":"9b4d620c84a0e34350a4bf7385dd858654c42d10"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"42aa7b4945fdf4dda0f4ba82e41d1b5f69d07e64","unresolved":false,"context_lines":[{"line_number":321,"context_line":"                reason\u003d_(\"Invalid address or cidr supplied %s.\") % access_to)"},{"line_number":322,"context_line":"        mask_length \u003d network.prefixlen"},{"line_number":323,"context_line":"        address \u003d access_to.split(\u0027/\u0027)[0]"},{"line_number":324,"context_line":"        if mask_length \u003d\u003d 0:"},{"line_number":325,"context_line":"            # Special case because Linux exports don\u0027t support /0 netmasks"},{"line_number":326,"context_line":"            return \u0027*\u0027"},{"line_number":327,"context_line":"        if network.version \u003d\u003d 4:"},{"line_number":328,"context_line":"            if mask_length \u003d\u003d 32:"},{"line_number":329,"context_line":"                return address"}],"source_content_type":"text/x-python","patch_set":4,"id":"df3967d1_4bcc8260","line":326,"range":{"start_line":324,"start_character":5,"end_line":326,"end_character":22},"in_reply_to":"df3967d1_93d07221","updated":"2017-08-02 17:22:32.000000000","message":"The problem with that approach is that 0.0.0.0/24 is a valid network, but it\u0027s NOT the same as 0.0.0.0/0. The relevant thing to check is the netmask length.","commit_id":"9b4d620c84a0e34350a4bf7385dd858654c42d10"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"599b49cd294129c4b4954d5f1511f702d26074d4","unresolved":false,"context_lines":[{"line_number":327,"context_line":"        if network.version \u003d\u003d 4:"},{"line_number":328,"context_line":"            if mask_length \u003d\u003d 32:"},{"line_number":329,"context_line":"                return address"},{"line_number":330,"context_line":"            return \u0027%s/%s\u0027 % (network.network, mask_length)"},{"line_number":331,"context_line":"        if mask_length \u003d\u003d 128:"},{"line_number":332,"context_line":"            return \"[%s]\" % address"},{"line_number":333,"context_line":"        return \"[%s]/%s\" % (network.network, mask_length)"}],"source_content_type":"text/x-python","patch_set":4,"id":"df3967d1_a44b3329","line":330,"range":{"start_line":330,"start_character":30,"end_line":330,"end_character":45},"updated":"2017-08-02 08:38:25.000000000","message":"We added ip access rule check in api. such as: if we input\n\u00271.1.1.0/8\u0027, it will get error \"ValueError: 1.1.1.0/8 has host bits set\". It looks like the \"address\" is equal to network.network.\nhttps://github.com/openstack/manila/blob/master/manila/api/common.py#L375","commit_id":"9b4d620c84a0e34350a4bf7385dd858654c42d10"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"42aa7b4945fdf4dda0f4ba82e41d1b5f69d07e64","unresolved":false,"context_lines":[{"line_number":327,"context_line":"        if network.version \u003d\u003d 4:"},{"line_number":328,"context_line":"            if mask_length \u003d\u003d 32:"},{"line_number":329,"context_line":"                return address"},{"line_number":330,"context_line":"            return \u0027%s/%s\u0027 % (network.network, mask_length)"},{"line_number":331,"context_line":"        if mask_length \u003d\u003d 128:"},{"line_number":332,"context_line":"            return \"[%s]\" % address"},{"line_number":333,"context_line":"        return \"[%s]/%s\" % (network.network, mask_length)"}],"source_content_type":"text/x-python","patch_set":4,"id":"df3967d1_cbbbd2c1","line":330,"range":{"start_line":330,"start_character":30,"end_line":330,"end_character":45},"in_reply_to":"df3967d1_27c5fc5b","updated":"2017-08-02 17:22:32.000000000","message":"Yes this was unclear until we discussed it at the bug squash. I didn\u0027t realize validation happened at a higher level. I will update the validation code here.","commit_id":"9b4d620c84a0e34350a4bf7385dd858654c42d10"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"50df5315a491ae504d88d74ad4bd66a9bdf8737e","unresolved":false,"context_lines":[{"line_number":327,"context_line":"        if network.version \u003d\u003d 4:"},{"line_number":328,"context_line":"            if mask_length \u003d\u003d 32:"},{"line_number":329,"context_line":"                return address"},{"line_number":330,"context_line":"            return \u0027%s/%s\u0027 % (network.network, mask_length)"},{"line_number":331,"context_line":"        if mask_length \u003d\u003d 128:"},{"line_number":332,"context_line":"            return \"[%s]\" % address"},{"line_number":333,"context_line":"        return \"[%s]/%s\" % (network.network, mask_length)"}],"source_content_type":"text/x-python","patch_set":4,"id":"df3967d1_27c5fc5b","line":330,"range":{"start_line":330,"start_character":30,"end_line":330,"end_character":45},"in_reply_to":"df3967d1_a44b3329","updated":"2017-08-02 12:33:20.000000000","message":"It would be better to use \u0027address\u0027 itself. If the \u0027network.network\u0027 is different with \u0027address\u0027, it could raise error, because the \u0027address\u0027 is not exactly correct.","commit_id":"9b4d620c84a0e34350a4bf7385dd858654c42d10"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8458757823a40c626c9864ddd2048ac464dad45a","unresolved":false,"context_lines":[{"line_number":205,"context_line":"    def _escaped_address(address):"},{"line_number":206,"context_line":"        addr \u003d ipaddress.ip_address(six.text_type(address))"},{"line_number":207,"context_line":"        if addr.version \u003d\u003d 4:"},{"line_number":208,"context_line":"            return str(addr)"},{"line_number":209,"context_line":"        else:"},{"line_number":210,"context_line":"            return \u0027[%s]\u0027 % str(addr)"},{"line_number":211,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_fb29ace5","line":208,"range":{"start_line":208,"start_character":19,"end_line":208,"end_character":22},"updated":"2017-08-03 10:24:51.000000000","message":"Py 2/3 incompatible approach. Should be \"six.text_type\".","commit_id":"318cebedf220bfa59489633406747903dd8e0c7b"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"54bb82ef93ee4747f208492d532e5406f063004f","unresolved":false,"context_lines":[{"line_number":205,"context_line":"    def _escaped_address(address):"},{"line_number":206,"context_line":"        addr \u003d ipaddress.ip_address(six.text_type(address))"},{"line_number":207,"context_line":"        if addr.version \u003d\u003d 4:"},{"line_number":208,"context_line":"            return str(addr)"},{"line_number":209,"context_line":"        else:"},{"line_number":210,"context_line":"            return \u0027[%s]\u0027 % str(addr)"},{"line_number":211,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_62df490d","line":208,"range":{"start_line":208,"start_character":19,"end_line":208,"end_character":22},"in_reply_to":"df3967d1_fb29ace5","updated":"2017-08-03 13:07:02.000000000","message":"good catch: +1","commit_id":"318cebedf220bfa59489633406747903dd8e0c7b"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"8458757823a40c626c9864ddd2048ac464dad45a","unresolved":false,"context_lines":[{"line_number":313,"context_line":"    def _get_parsed_address_or_cidr(access_to):"},{"line_number":314,"context_line":"        network \u003d ipaddress.ip_network(six.text_type(access_to))"},{"line_number":315,"context_line":"        mask_length \u003d network.prefixlen"},{"line_number":316,"context_line":"        address \u003d str(network.network_address)"},{"line_number":317,"context_line":"        if mask_length \u003d\u003d 0:"},{"line_number":318,"context_line":"            # Special case because Linux exports don\u0027t support /0 netmasks"},{"line_number":319,"context_line":"            return \u0027*\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_db26e815","line":316,"range":{"start_line":316,"start_character":18,"end_line":316,"end_character":21},"updated":"2017-08-03 10:24:51.000000000","message":"Py 2/3 incompatible approach. Should be \"six.text_type\".","commit_id":"318cebedf220bfa59489633406747903dd8e0c7b"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"54bb82ef93ee4747f208492d532e5406f063004f","unresolved":false,"context_lines":[{"line_number":313,"context_line":"    def _get_parsed_address_or_cidr(access_to):"},{"line_number":314,"context_line":"        network \u003d ipaddress.ip_network(six.text_type(access_to))"},{"line_number":315,"context_line":"        mask_length \u003d network.prefixlen"},{"line_number":316,"context_line":"        address \u003d str(network.network_address)"},{"line_number":317,"context_line":"        if mask_length \u003d\u003d 0:"},{"line_number":318,"context_line":"            # Special case because Linux exports don\u0027t support /0 netmasks"},{"line_number":319,"context_line":"            return \u0027*\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"df3967d1_42e445e1","line":316,"range":{"start_line":316,"start_character":18,"end_line":316,"end_character":21},"in_reply_to":"df3967d1_db26e815","updated":"2017-08-03 13:07:02.000000000","message":"+1","commit_id":"318cebedf220bfa59489633406747903dd8e0c7b"}],"manila/tests/share/drivers/test_helpers.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"f172d28b1cce0570a01133c5ddbfa317c3e81e4f","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            mock.call(self.server, [\u0027sudo\u0027, \u0027exportfs\u0027, \u0027-u\u0027,"},{"line_number":165,"context_line":"                                    \u0027:\u0027.join([\u00273.3.3.3\u0027, local_path])]),"},{"line_number":166,"context_line":"            mock.call(self.server, [\u0027sudo\u0027, \u0027exportfs\u0027, \u0027-u\u0027,"},{"line_number":167,"context_line":"                                    \u0027:\u0027.join([\u0027*\u0027,"},{"line_number":168,"context_line":"                                              local_path])]),"},{"line_number":169,"context_line":"            mock.call(self.server, [\u0027sudo\u0027, \u0027exportfs\u0027, \u0027-o\u0027,"},{"line_number":170,"context_line":"                                    expected_mount_options % access_level,"}],"source_content_type":"text/x-python","patch_set":4,"id":"df3967d1_1d2c9297","line":167,"range":{"start_line":167,"start_character":46,"end_line":167,"end_character":50},"updated":"2017-08-02 10:11:28.000000000","message":"Could you add test about the ip access rule 0.0.0.0/0 change to *?","commit_id":"9b4d620c84a0e34350a4bf7385dd858654c42d10"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"42aa7b4945fdf4dda0f4ba82e41d1b5f69d07e64","unresolved":false,"context_lines":[{"line_number":164,"context_line":"            mock.call(self.server, [\u0027sudo\u0027, \u0027exportfs\u0027, \u0027-u\u0027,"},{"line_number":165,"context_line":"                                    \u0027:\u0027.join([\u00273.3.3.3\u0027, local_path])]),"},{"line_number":166,"context_line":"            mock.call(self.server, [\u0027sudo\u0027, \u0027exportfs\u0027, \u0027-u\u0027,"},{"line_number":167,"context_line":"                                    \u0027:\u0027.join([\u0027*\u0027,"},{"line_number":168,"context_line":"                                              local_path])]),"},{"line_number":169,"context_line":"            mock.call(self.server, [\u0027sudo\u0027, \u0027exportfs\u0027, \u0027-o\u0027,"},{"line_number":170,"context_line":"                                    expected_mount_options % access_level,"}],"source_content_type":"text/x-python","patch_set":4,"id":"df3967d1_cb099295","line":167,"range":{"start_line":167,"start_character":46,"end_line":167,"end_character":50},"in_reply_to":"df3967d1_1d2c9297","updated":"2017-08-02 17:22:32.000000000","message":"Updated test","commit_id":"9b4d620c84a0e34350a4bf7385dd858654c42d10"}]}
