)]}'
{"manila_tempest_tests/tests/api/admin/test_share_servers.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"48ee8a935eda32248de97087ef9c58ff8422fc8c","unresolved":false,"context_lines":[{"line_number":196,"context_line":"    @tc.attr(base.TAG_POSITIVE, base.TAG_API_WITH_BACKEND)"},{"line_number":197,"context_line":"    @ddt.data(True, False)"},{"line_number":198,"context_line":"    @testtools.skipIf(CONF.share.share_network_id !\u003d \"\","},{"line_number":199,"context_line":"                      \"Skip the test for pre-existing share_network.\")"},{"line_number":200,"context_line":"    def test_delete_share_server(self, delete_share_network):"},{"line_number":201,"context_line":"        # Get network and subnet from existing share_network and reuse it"},{"line_number":202,"context_line":"        # to be able to delete share_server after test ends."}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_f0aa6c17","line":199,"range":{"start_line":199,"start_character":23,"end_line":199,"end_character":40},"updated":"2017-08-08 16:12:20.000000000","message":"This test is not suitable for","commit_id":"b8ede57c2a8dab8584df7c0306ee145e8249e3af"}],"manila_tempest_tests/tests/api/base.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"48ee8a935eda32248de97087ef9c58ff8422fc8c","unresolved":false,"context_lines":[{"line_number":907,"context_line":"                    elif res[\"type\"] is \"snapshot\":"},{"line_number":908,"context_line":"                        client.delete_snapshot(res_id)"},{"line_number":909,"context_line":"                        client.wait_for_resource_deletion(snapshot_id\u003dres_id)"},{"line_number":910,"context_line":"                    elif (res[\"type\"] is \"share_network\" and res_id !\u003d"},{"line_number":911,"context_line":"                          CONF.share.share_network_id):"},{"line_number":912,"context_line":"                            client.delete_share_network(res_id)"},{"line_number":913,"context_line":"                            client.wait_for_resource_deletion(sn_id\u003dres_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_105cd049","line":910,"range":{"start_line":910,"start_character":60,"end_line":910,"end_character":61},"updated":"2017-08-08 16:12:20.000000000","message":"move \"and res_id !\u003d\" to the next line:\n\nhttps://www.python.org/dev/peps/pep-0008/#should-a-line-break-before-or-after-a-binary-operator","commit_id":"b8ede57c2a8dab8584df7c0306ee145e8249e3af"},{"author":{"_account_id":8851,"name":"Valeriy Ponomaryov","email":"kiparis.kh@gmail.com","username":"vponomaryov"},"change_message_id":"fcf301b18d3da9c110d08f000b280c388cae552c","unresolved":false,"context_lines":[{"line_number":421,"context_line":"                      share_network_id\u003dNone, share_type_id\u003dNone,"},{"line_number":422,"context_line":"                      share_group_id\u003dNone, client\u003dNone,"},{"line_number":423,"context_line":"                      cleanup_in_class\u003dTrue, is_public\u003dFalse, **kwargs):"},{"line_number":424,"context_line":"        client \u003d client or cls.shares_v2_client"},{"line_number":425,"context_line":"        description \u003d description or \"Tempest\u0027s share\""},{"line_number":426,"context_line":"        share_network_id \u003d (share_network_id or"},{"line_number":427,"context_line":"                            CONF.share.share_network_id or"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_edbde068","line":424,"updated":"2017-08-09 08:48:12.000000000","message":"Changes to this file is implementation of bug.\n\nBecause we have 3 different config options for getting share network ID - https://github.com/openstack/manila/blob/256b5c84/manila_tempest_tests/config.py#L120-L132\n\nSo, you should, at first, check argument, then client attr then set None. \"config\" should not be used directly here.","commit_id":"29a52269aa0d70006e2f0537780e68369da619d0"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"28eed4e7e8a1704a46622dfdd9274affbf207160","unresolved":false,"context_lines":[{"line_number":907,"context_line":"                    elif res[\"type\"] is \"snapshot\":"},{"line_number":908,"context_line":"                        client.delete_snapshot(res_id)"},{"line_number":909,"context_line":"                        client.wait_for_resource_deletion(snapshot_id\u003dres_id)"},{"line_number":910,"context_line":"                    elif (res[\"type\"] is \"share_network\" and"},{"line_number":911,"context_line":"                            res_id !\u003d CONF.share.share_network_id):"},{"line_number":912,"context_line":"                            client.delete_share_network(res_id)"},{"line_number":913,"context_line":"                            client.wait_for_resource_deletion(sn_id\u003dres_id)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_8b73e980","line":910,"range":{"start_line":910,"start_character":56,"end_line":910,"end_character":60},"updated":"2017-08-08 23:24:56.000000000","message":"put this in the next line if you make another patch","commit_id":"29a52269aa0d70006e2f0537780e68369da619d0"}],"manila_tempest_tests/tests/api/test_share_networks_negative.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"48ee8a935eda32248de97087ef9c58ff8422fc8c","unresolved":false,"context_lines":[{"line_number":112,"context_line":"                      \u0027Can run only with drivers that do handle share servers \u0027"},{"line_number":113,"context_line":"                      \u0027creation. Skipping.\u0027)"},{"line_number":114,"context_line":"    @testtools.skipIf(CONF.share.share_network_id !\u003d \"\","},{"line_number":115,"context_line":"                      \"Skip the test for pre-existing share_network.\")"},{"line_number":116,"context_line":"    def test_try_delete_share_network_with_existing_shares(self):"},{"line_number":117,"context_line":"        # Get valid network data for successful share creation"},{"line_number":118,"context_line":"        share_network \u003d self.shares_client.get_share_network("}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_b062a415","line":115,"range":{"start_line":115,"start_character":23,"end_line":115,"end_character":36},"updated":"2017-08-08 16:12:20.000000000","message":"This test is not suitable","commit_id":"b8ede57c2a8dab8584df7c0306ee145e8249e3af"}]}
