)]}'
{"manila/share/drivers/helpers.py":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"73bf789dd2e782da00d28143057f53344fa56188","unresolved":false,"context_lines":[{"line_number":604,"context_line":"    Class provides functionality to operate with CIFS shares."},{"line_number":605,"context_line":"    Samba server is automatically configured to join a AD domain."},{"line_number":606,"context_line":"    Manila service image must contain following packages:"},{"line_number":607,"context_line":"    libnss-winbind, krb5-user, libpam-winbind, krb5-config, krb5-locales,"},{"line_number":608,"context_line":"    winbind, ntp, ntpdate."},{"line_number":609,"context_line":""},{"line_number":610,"context_line":"    To use this helper NTP should be available on the AD controller."}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_ab805fc0","line":607,"updated":"2017-09-28 12:42:57.000000000","message":"Are theses ubuntu package names? Is that something that should go into the documentation?","commit_id":"c447b33f08a1350a7d60d1d8527c9e42831541ab"},{"author":{"_account_id":26768,"name":"Jan Vondra","email":"jan.vondra@ultimum.io","username":"JanVondra"},"change_message_id":"3c228c4095e0083c022d0ac0a7ed066c6d9dec5c","unresolved":false,"context_lines":[{"line_number":604,"context_line":"    Class provides functionality to operate with CIFS shares."},{"line_number":605,"context_line":"    Samba server is automatically configured to join a AD domain."},{"line_number":606,"context_line":"    Manila service image must contain following packages:"},{"line_number":607,"context_line":"    libnss-winbind, krb5-user, libpam-winbind, krb5-config, krb5-locales,"},{"line_number":608,"context_line":"    winbind, ntp, ntpdate."},{"line_number":609,"context_line":""},{"line_number":610,"context_line":"    To use this helper NTP should be available on the AD controller."}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_09e50638","line":607,"in_reply_to":"7f515b1d_ab805fc0","updated":"2017-10-02 10:32:15.000000000","message":"Yes, will add them to the documentation","commit_id":"c447b33f08a1350a7d60d1d8527c9e42831541ab"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"73bf789dd2e782da00d28143057f53344fa56188","unresolved":false,"context_lines":[{"line_number":633,"context_line":"        realm \u003d {domain_uppercase}"},{"line_number":634,"context_line":"        kerberos method \u003d secrets and keytab"},{"line_number":635,"context_line":"        security \u003d ads"},{"line_number":636,"context_line":"        server string \u003d %h server (Samba, Ubuntu)"},{"line_number":637,"context_line":"        netbios name \u003d {server_name}"},{"line_number":638,"context_line":"        encrypt passwords \u003d yes"},{"line_number":639,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_cb683b1e","line":636,"updated":"2017-09-28 12:42:57.000000000","message":"Remove ubuntu","commit_id":"c447b33f08a1350a7d60d1d8527c9e42831541ab"},{"author":{"_account_id":26768,"name":"Jan Vondra","email":"jan.vondra@ultimum.io","username":"JanVondra"},"change_message_id":"3c228c4095e0083c022d0ac0a7ed066c6d9dec5c","unresolved":false,"context_lines":[{"line_number":633,"context_line":"        realm \u003d {domain_uppercase}"},{"line_number":634,"context_line":"        kerberos method \u003d secrets and keytab"},{"line_number":635,"context_line":"        security \u003d ads"},{"line_number":636,"context_line":"        server string \u003d %h server (Samba, Ubuntu)"},{"line_number":637,"context_line":"        netbios name \u003d {server_name}"},{"line_number":638,"context_line":"        encrypt passwords \u003d yes"},{"line_number":639,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_c9392ea4","line":636,"in_reply_to":"7f515b1d_cb683b1e","updated":"2017-10-02 10:32:15.000000000","message":"Ok, will do that.","commit_id":"c447b33f08a1350a7d60d1d8527c9e42831541ab"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"73bf789dd2e782da00d28143057f53344fa56188","unresolved":false,"context_lines":[{"line_number":743,"context_line":""},{"line_number":744,"context_line":"        self._ssh_exec(server, [\"echo\", resolv_conf, \"|\","},{"line_number":745,"context_line":"                                \"sudo\", \"tee\", \"/etc/resolv.conf\"])"},{"line_number":746,"context_line":"        self._ssh_exec(server, [\"sudo\", \"chattr\", \"+i\", \"/etc/resolv.conf\"])"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"    def _setup_ntp(self, server, servers):"},{"line_number":749,"context_line":"        \"\"\"Sync time with AD domain\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_6bdca7e3","line":746,"updated":"2017-09-28 12:42:57.000000000","message":"Why is that needed?","commit_id":"c447b33f08a1350a7d60d1d8527c9e42831541ab"},{"author":{"_account_id":26768,"name":"Jan Vondra","email":"jan.vondra@ultimum.io","username":"JanVondra"},"change_message_id":"3c228c4095e0083c022d0ac0a7ed066c6d9dec5c","unresolved":false,"context_lines":[{"line_number":743,"context_line":""},{"line_number":744,"context_line":"        self._ssh_exec(server, [\"echo\", resolv_conf, \"|\","},{"line_number":745,"context_line":"                                \"sudo\", \"tee\", \"/etc/resolv.conf\"])"},{"line_number":746,"context_line":"        self._ssh_exec(server, [\"sudo\", \"chattr\", \"+i\", \"/etc/resolv.conf\"])"},{"line_number":747,"context_line":""},{"line_number":748,"context_line":"    def _setup_ntp(self, server, servers):"},{"line_number":749,"context_line":"        \"\"\"Sync time with AD domain\"\"\""}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_494d3e3c","line":746,"in_reply_to":"7f515b1d_6bdca7e3","updated":"2017-10-02 10:32:15.000000000","message":"This is needed to prevent cloud init or dhcp to change resolv.conf. Changing DNS resolvers breaks kerberos and winbind.","commit_id":"c447b33f08a1350a7d60d1d8527c9e42831541ab"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"73bf789dd2e782da00d28143057f53344fa56188","unresolved":false,"context_lines":[{"line_number":747,"context_line":""},{"line_number":748,"context_line":"    def _setup_ntp(self, server, servers):"},{"line_number":749,"context_line":"        \"\"\"Sync time with AD domain\"\"\""},{"line_number":750,"context_line":"        ntp_server \u003d servers[0]"},{"line_number":751,"context_line":"        self._ssh_exec(server, [\"echo\", \"\u0027\", \"server %s\" % ntp_server, \"\u0027\","},{"line_number":752,"context_line":"                                \"|\", \"sudo\", \"tee\", \"/etc/ntp.conf\"])"},{"line_number":753,"context_line":"        self._ssh_exec(server, [\"sudo\", \u0027service\u0027, \u0027ntp\u0027, \u0027stop\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_ab9cdf0d","line":750,"updated":"2017-09-28 12:42:57.000000000","message":"Isn\u0027t the ntp setup something that can be done during image build?","commit_id":"c447b33f08a1350a7d60d1d8527c9e42831541ab"},{"author":{"_account_id":26768,"name":"Jan Vondra","email":"jan.vondra@ultimum.io","username":"JanVondra"},"change_message_id":"3c228c4095e0083c022d0ac0a7ed066c6d9dec5c","unresolved":false,"context_lines":[{"line_number":747,"context_line":""},{"line_number":748,"context_line":"    def _setup_ntp(self, server, servers):"},{"line_number":749,"context_line":"        \"\"\"Sync time with AD domain\"\"\""},{"line_number":750,"context_line":"        ntp_server \u003d servers[0]"},{"line_number":751,"context_line":"        self._ssh_exec(server, [\"echo\", \"\u0027\", \"server %s\" % ntp_server, \"\u0027\","},{"line_number":752,"context_line":"                                \"|\", \"sudo\", \"tee\", \"/etc/ntp.conf\"])"},{"line_number":753,"context_line":"        self._ssh_exec(server, [\"sudo\", \u0027service\u0027, \u0027ntp\u0027, \u0027stop\u0027])"}],"source_content_type":"text/x-python","patch_set":3,"id":"7f515b1d_e9662abb","line":750,"in_reply_to":"7f515b1d_ab9cdf0d","updated":"2017-10-02 10:32:15.000000000","message":"The idea behind ntp setup here is using AD server as a NTP source.","commit_id":"c447b33f08a1350a7d60d1d8527c9e42831541ab"}],"manila/share/drivers/service_instance.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"2b1d855fd1fc5b4667f85a3c6d205026ba536775","unresolved":false,"context_lines":[{"line_number":421,"context_line":"        instance_details[\"security_service\"] \u003d security_service"},{"line_number":422,"context_line":"        return instance_details"},{"line_number":423,"context_line":""},{"line_number":424,"context_line":"    def _get_valid_security_service(self, security_services):"},{"line_number":425,"context_line":"        \"\"\"Validate security services and return AD config.\"\"\""},{"line_number":426,"context_line":"        if not security_services:"},{"line_number":427,"context_line":"            return None"},{"line_number":428,"context_line":"        for ss in security_services:"},{"line_number":429,"context_line":"            if ss[\u0027type\u0027] \u003d\u003d \u0027active_directory\u0027:"},{"line_number":430,"context_line":"                return ss"},{"line_number":431,"context_line":"            else:"},{"line_number":432,"context_line":"                err_msg \u003d \"Unsupported security service: %s\" % ss[\"type\"]"},{"line_number":433,"context_line":"                LOG.error(err_msg)"},{"line_number":434,"context_line":"                raise exception.InvalidInput(reason\u003derr_msg)"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    def _get_new_instance_details(self, server):"},{"line_number":437,"context_line":"        instance_details \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_dbaaae17","line":434,"range":{"start_line":424,"start_character":4,"end_line":434,"end_character":60},"updated":"2017-09-05 14:14:45.000000000","message":"you could add unit test code that actually goes through here","commit_id":"b6b8d436bd76726a35cc24b2a375687dbb9e0102"}]}