)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"8344909754473a84795a81b23bcdf515b13e986d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Generic driver - Limiting SSH access from tenant network"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adedd new config option limit_ssh_access. If set to true the"},{"line_number":10,"context_line":"iptables are set up to block port 22 from other subnets"},{"line_number":11,"context_line":"than service network in service instance."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7f287b81_3c531ae5","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":5},"updated":"2017-09-02 15:53:22.000000000","message":"nit: Added","commit_id":"12139d14af2875b2ad99160553e5b5a363eec71f"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"8344909754473a84795a81b23bcdf515b13e986d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"than service network in service instance."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3c247ac2c55e5c74dbb0c8e31144bb865fd48710"},{"line_number":14,"context_line":"Closes-bug: #1714288"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7f287b81_1c505ed4","line":14,"range":{"start_line":14,"start_character":13,"end_line":14,"end_character":20},"updated":"2017-09-02 15:53:22.000000000","message":"Is this the right bug number?  The link in the gerrit page here is not working correctly.","commit_id":"12139d14af2875b2ad99160553e5b5a363eec71f"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"23477eb14c69752abdd4234667bee21ddf3f58f9","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Generic driver - Limiting SSH access from tenant network"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adedd new config option limit_ssh_access. If set to true the"},{"line_number":10,"context_line":"iptables are set up to block port 22 from other subnets"},{"line_number":11,"context_line":"than service network in service instance."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"7f287b81_e3deedd8","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":5},"updated":"2017-09-05 02:56:06.000000000","message":"Added","commit_id":"577ba457ad3244fb84ceb5cd6ed86fc02c790a40"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"8efd4d9599bd169fc05a5de5741363c4a7f9236b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Generic driver - Limiting SSH access from tenant network"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adedd new config option limit_ssh_access. If set to true the"},{"line_number":10,"context_line":"iptables are set up to block port 22 from other subnets"},{"line_number":11,"context_line":"than service network in service instance."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I3c247ac2c55e5c74dbb0c8e31144bb865fd48710"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3f4b6375_7f0eda3b","line":10,"range":{"start_line":9,"start_character":57,"end_line":10,"end_character":19},"updated":"2017-10-23 15:40:52.000000000","message":"\"neutron security groups are set up\"  -- whether iptables are used to implement these is plugin dependent.","commit_id":"577ba457ad3244fb84ceb5cd6ed86fc02c790a40"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"c2a28bc6297d0682b88857272e249fa9d6c84298","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Generic driver - Limiting SSH access from tenant network"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adedd new config option limit_ssh_access. If set to true the"},{"line_number":10,"context_line":"iptables are set up to block port 22 from other subnets"},{"line_number":11,"context_line":"than service network in service instance."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"5f2577a7_d2c942ac","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":6},"updated":"2017-10-18 10:16:22.000000000","message":"nit: Added","commit_id":"4c7f9ba5b98356fa30e47737d891dba549cd4ce9"}],"manila/share/drivers/generic.py":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6ff13148a56cb607ce317610c4f5251e9a22fc1a","unresolved":false,"context_lines":[{"line_number":78,"context_line":"               help\u003d\u0027Name or id of cinder volume type which will be used \u0027"},{"line_number":79,"context_line":"                    \u0027for all volumes created by driver.\u0027),"},{"line_number":80,"context_line":"    cfg.StrOpt(\"limit_ssh_access\","},{"line_number":81,"context_line":"               default\u003dTrue,"},{"line_number":82,"context_line":"               help\u003d\u0027Block SSH connection from other networks\u0027"},{"line_number":83,"context_line":"                    \u0027than service network.\u0027),"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_313a34cd","line":81,"range":{"start_line":81,"start_character":23,"end_line":81,"end_character":27},"updated":"2017-09-01 13:03:21.000000000","message":"Perhaps the default should be False. Why do you think it is best to be set to True?","commit_id":"69eae2e7f0ddb010cca5259915ecade8ae1062a1"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6ff13148a56cb607ce317610c4f5251e9a22fc1a","unresolved":false,"context_lines":[{"line_number":915,"context_line":"                self._ssh_exec(server_details, [\u0027echo\u0027, \"\u0027%s\u0027\" % limit, \u0027|\u0027,"},{"line_number":916,"context_line":"                                                \u0027sudo\u0027, \u0027tee\u0027, \u0027-a\u0027,"},{"line_number":917,"context_line":"                                                \u0027/etc/rc.local\u0027])"},{"line_number":918,"context_line":"            else:"},{"line_number":919,"context_line":"                LOG.error(\"Unable to limit ssh access to instance id: \u0027%s\u0027!\","},{"line_number":920,"context_line":"                          server_details[\u0027instance_id\u0027])"},{"line_number":921,"context_line":""},{"line_number":922,"context_line":"    def _get_instance_netmask(self, server_details):"},{"line_number":923,"context_line":"        import re"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_d1177045","line":920,"range":{"start_line":918,"start_character":11,"end_line":920,"end_character":56},"updated":"2017-09-01 13:03:21.000000000","message":"perhaps wouldn\u0027t you want to fail the creation of the share server if it is set to limit ssh access but unable to do so? Ignoring the error could be a security vulnerability.","commit_id":"69eae2e7f0ddb010cca5259915ecade8ae1062a1"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6ff13148a56cb607ce317610c4f5251e9a22fc1a","unresolved":false,"context_lines":[{"line_number":928,"context_line":"            mask \u003d re.search(reg_exp, output).group(\u0027mask\u0027)"},{"line_number":929,"context_line":"            return mask"},{"line_number":930,"context_line":"        except Exception:"},{"line_number":931,"context_line":"            LOG.error(\"Unable to get netmask for instance \u0027%s\u0027\","},{"line_number":932,"context_line":"                      server_details[\u0027instance_id\u0027])"},{"line_number":933,"context_line":"            return False"},{"line_number":934,"context_line":""},{"line_number":935,"context_line":"    def _teardown_server(self, server_details, security_services\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_b1fd040a","line":932,"range":{"start_line":931,"start_character":12,"end_line":932,"end_character":52},"updated":"2017-09-01 13:03:21.000000000","message":"you could include the exception error here.","commit_id":"69eae2e7f0ddb010cca5259915ecade8ae1062a1"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"1ac64bab28eb4990985926354ff7b7ff61a0b638","unresolved":false,"context_lines":[{"line_number":902,"context_line":"            header \u003d \"#!/bin/bash\""},{"line_number":903,"context_line":"            self._ssh_exec(server_details, [\u0027echo\u0027, \"\u0027%s\u0027\" % header, \u0027|\u0027,"},{"line_number":904,"context_line":"                                            \u0027sudo\u0027, \u0027tee\u0027,"},{"line_number":905,"context_line":"                                            \u0027/etc/rc.local\u0027])"},{"line_number":906,"context_line":"            set_e \u003d \"set -e\""},{"line_number":907,"context_line":"            self._ssh_exec(server_details, [\u0027echo\u0027, \"\u0027%s\u0027\" % set_e, \u0027|\u0027,"},{"line_number":908,"context_line":"                                            \u0027sudo\u0027, \u0027tee\u0027, \u0027-a\u0027,"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f287b81_61555550","line":905,"updated":"2017-09-05 05:30:11.000000000","message":"This might not work on all distros because /etc/rc.local is not everywhere available (eg not on openSUSE)","commit_id":"577ba457ad3244fb84ceb5cd6ed86fc02c790a40"}],"manila/share/drivers/service_instance.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"3c24c3bbbc8e44b8cd63536af295cae23d34db85","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    cfg.StrOpt("},{"line_number":150,"context_line":"        \"limit_ssh_access\","},{"line_number":151,"context_line":"        default\u003dFalse,"},{"line_number":152,"context_line":"        help\u003d\"Block SSH connection from other networks\""},{"line_number":153,"context_line":"             \"than service network.\"),"},{"line_number":154,"context_line":"]"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":10,"id":"3f4b6375_91438d6c","line":153,"range":{"start_line":152,"start_character":46,"end_line":153,"end_character":18},"updated":"2017-10-25 12:23:19.000000000","message":"Please add a space between the two words.","commit_id":"c84fbb8d736de3b7bc3208eea6d4c32c2062fc33"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"99afb6ee4a65a8627c3ebaa4782b43ed2db0cad8","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        \"max_time_to_build_instance\","},{"line_number":147,"context_line":"        default\u003d300,"},{"line_number":148,"context_line":"        help\u003d\"Maximum time in seconds to wait for creating service instance.\"),"},{"line_number":149,"context_line":"    cfg.StrOpt("},{"line_number":150,"context_line":"        \"limit_ssh_access\","},{"line_number":151,"context_line":"        default\u003dFalse,"},{"line_number":152,"context_line":"        help\u003d\"Block SSH connection from other networks \""}],"source_content_type":"text/x-python","patch_set":11,"id":"1f485f77_861735a4","line":149,"range":{"start_line":149,"start_character":7,"end_line":149,"end_character":14},"updated":"2017-11-14 10:30:17.000000000","message":"Why don\u0027t we just use BoolOpt?","commit_id":"a63d35ad562d9c33e65344c4e1fd86d86f04bf58"},{"author":{"_account_id":26768,"name":"Jan Vondra","email":"jan.vondra@ultimum.io","username":"JanVondra"},"change_message_id":"87c0742f3a240d1098f3f6124c97c693c8139ec4","unresolved":false,"context_lines":[{"line_number":146,"context_line":"        \"max_time_to_build_instance\","},{"line_number":147,"context_line":"        default\u003d300,"},{"line_number":148,"context_line":"        help\u003d\"Maximum time in seconds to wait for creating service instance.\"),"},{"line_number":149,"context_line":"    cfg.StrOpt("},{"line_number":150,"context_line":"        \"limit_ssh_access\","},{"line_number":151,"context_line":"        default\u003dFalse,"},{"line_number":152,"context_line":"        help\u003d\"Block SSH connection from other networks \""}],"source_content_type":"text/x-python","patch_set":11,"id":"5f7c97a3_d17af186","line":149,"range":{"start_line":149,"start_character":7,"end_line":149,"end_character":14},"in_reply_to":"1f485f77_861735a4","updated":"2018-05-04 12:38:46.000000000","message":"Done","commit_id":"a63d35ad562d9c33e65344c4e1fd86d86f04bf58"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4a229c4be432b5cb4cfde006181f58a58ea5078f","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    cfg.StrOpt("},{"line_number":150,"context_line":"        \"limit_ssh_access\","},{"line_number":151,"context_line":"        default\u003dFalse,"},{"line_number":152,"context_line":"        help\u003d\"Block SSH connection from other networks \""},{"line_number":153,"context_line":"             \"than service network.\"),"},{"line_number":154,"context_line":"]"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1f485f77_4b25ddaa","line":152,"range":{"start_line":152,"start_character":34,"end_line":152,"end_character":35},"updated":"2017-11-13 14:54:38.000000000","message":"to the service_instance","commit_id":"a63d35ad562d9c33e65344c4e1fd86d86f04bf58"},{"author":{"_account_id":26768,"name":"Jan Vondra","email":"jan.vondra@ultimum.io","username":"JanVondra"},"change_message_id":"87c0742f3a240d1098f3f6124c97c693c8139ec4","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    cfg.StrOpt("},{"line_number":150,"context_line":"        \"limit_ssh_access\","},{"line_number":151,"context_line":"        default\u003dFalse,"},{"line_number":152,"context_line":"        help\u003d\"Block SSH connection from other networks \""},{"line_number":153,"context_line":"             \"than service network.\"),"},{"line_number":154,"context_line":"]"},{"line_number":155,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"5f7c97a3_716f5dc5","line":152,"range":{"start_line":152,"start_character":34,"end_line":152,"end_character":35},"in_reply_to":"1f485f77_4b25ddaa","updated":"2018-05-04 12:38:46.000000000","message":"Done","commit_id":"a63d35ad562d9c33e65344c4e1fd86d86f04bf58"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4a229c4be432b5cb4cfde006181f58a58ea5078f","unresolved":false,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        sgs.append(self._get_or_create_security_group(name, description,"},{"line_number":342,"context_line":"                                                      sec_group_data))"},{"line_number":343,"context_line":"        if allow_ssh_subnet:"},{"line_number":344,"context_line":"            if \"cidr\" not in allow_ssh_subnet or \u0027id\u0027 not in allow_ssh_subnet:"},{"line_number":345,"context_line":"                raise exception.ManilaException("},{"line_number":346,"context_line":"                    \"SSH limitation could not be set up\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f485f77_eb07e91b","line":343,"range":{"start_line":343,"start_character":0,"end_line":343,"end_character":28},"updated":"2017-11-13 14:54:38.000000000","message":"What\u0027s the reason to create a second security group? Why not add the SSH ports of the allowed CIDR to the same group as a new rule, as was done before?","commit_id":"a63d35ad562d9c33e65344c4e1fd86d86f04bf58"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"99afb6ee4a65a8627c3ebaa4782b43ed2db0cad8","unresolved":false,"context_lines":[{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        sgs.append(self._get_or_create_security_group(name, description,"},{"line_number":342,"context_line":"                                                      sec_group_data))"},{"line_number":343,"context_line":"        if allow_ssh_subnet:"},{"line_number":344,"context_line":"            if \"cidr\" not in allow_ssh_subnet or \u0027id\u0027 not in allow_ssh_subnet:"},{"line_number":345,"context_line":"                raise exception.ManilaException("},{"line_number":346,"context_line":"                    \"SSH limitation could not be set up\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f485f77_fccb1647","line":343,"range":{"start_line":343,"start_character":0,"end_line":343,"end_character":28},"in_reply_to":"1f485f77_eb07e91b","updated":"2017-11-14 10:30:17.000000000","message":"The same question +1","commit_id":"a63d35ad562d9c33e65344c4e1fd86d86f04bf58"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4a229c4be432b5cb4cfde006181f58a58ea5078f","unresolved":false,"context_lines":[{"line_number":343,"context_line":"        if allow_ssh_subnet:"},{"line_number":344,"context_line":"            if \"cidr\" not in allow_ssh_subnet or \u0027id\u0027 not in allow_ssh_subnet:"},{"line_number":345,"context_line":"                raise exception.ManilaException("},{"line_number":346,"context_line":"                    \"SSH limitation could not be set up\")"},{"line_number":347,"context_line":"            ssh_sg_name \u003d \"manila-service-subnet-{}\".format("},{"line_number":348,"context_line":"                allow_ssh_subnet[\"id\"])"},{"line_number":349,"context_line":"            sgs.append(self._get_or_create_security_group("}],"source_content_type":"text/x-python","patch_set":11,"id":"1f485f77_eb6369db","line":346,"range":{"start_line":346,"start_character":21,"end_line":346,"end_character":55},"updated":"2017-11-13 14:54:38.000000000","message":"_(\"Cannot limit SSH access\")","commit_id":"a63d35ad562d9c33e65344c4e1fd86d86f04bf58"},{"author":{"_account_id":26768,"name":"Jan Vondra","email":"jan.vondra@ultimum.io","username":"JanVondra"},"change_message_id":"87c0742f3a240d1098f3f6124c97c693c8139ec4","unresolved":false,"context_lines":[{"line_number":343,"context_line":"        if allow_ssh_subnet:"},{"line_number":344,"context_line":"            if \"cidr\" not in allow_ssh_subnet or \u0027id\u0027 not in allow_ssh_subnet:"},{"line_number":345,"context_line":"                raise exception.ManilaException("},{"line_number":346,"context_line":"                    \"SSH limitation could not be set up\")"},{"line_number":347,"context_line":"            ssh_sg_name \u003d \"manila-service-subnet-{}\".format("},{"line_number":348,"context_line":"                allow_ssh_subnet[\"id\"])"},{"line_number":349,"context_line":"            sgs.append(self._get_or_create_security_group("}],"source_content_type":"text/x-python","patch_set":11,"id":"5f7c97a3_116069ce","line":346,"range":{"start_line":346,"start_character":21,"end_line":346,"end_character":55},"in_reply_to":"1f485f77_eb6369db","updated":"2018-05-04 12:38:46.000000000","message":"Done","commit_id":"a63d35ad562d9c33e65344c4e1fd86d86f04bf58"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"99afb6ee4a65a8627c3ebaa4782b43ed2db0cad8","unresolved":false,"context_lines":[{"line_number":344,"context_line":"            if \"cidr\" not in allow_ssh_subnet or \u0027id\u0027 not in allow_ssh_subnet:"},{"line_number":345,"context_line":"                raise exception.ManilaException("},{"line_number":346,"context_line":"                    \"SSH limitation could not be set up\")"},{"line_number":347,"context_line":"            ssh_sg_name \u003d \"manila-service-subnet-{}\".format("},{"line_number":348,"context_line":"                allow_ssh_subnet[\"id\"])"},{"line_number":349,"context_line":"            sgs.append(self._get_or_create_security_group("},{"line_number":350,"context_line":"                ssh_sg_name, description,"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f485f77_3cbbee72","line":347,"range":{"start_line":347,"start_character":26,"end_line":347,"end_character":52},"updated":"2017-11-14 10:30:17.000000000","message":"Since the service_instance_security_group can be configured, do we have to let it to be configured if we have to create a second security group?","commit_id":"a63d35ad562d9c33e65344c4e1fd86d86f04bf58"},{"author":{"_account_id":26768,"name":"Jan Vondra","email":"jan.vondra@ultimum.io","username":"JanVondra"},"change_message_id":"87c0742f3a240d1098f3f6124c97c693c8139ec4","unresolved":false,"context_lines":[{"line_number":344,"context_line":"            if \"cidr\" not in allow_ssh_subnet or \u0027id\u0027 not in allow_ssh_subnet:"},{"line_number":345,"context_line":"                raise exception.ManilaException("},{"line_number":346,"context_line":"                    \"SSH limitation could not be set up\")"},{"line_number":347,"context_line":"            ssh_sg_name \u003d \"manila-service-subnet-{}\".format("},{"line_number":348,"context_line":"                allow_ssh_subnet[\"id\"])"},{"line_number":349,"context_line":"            sgs.append(self._get_or_create_security_group("},{"line_number":350,"context_line":"                ssh_sg_name, description,"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f7c97a3_91f799f6","line":347,"range":{"start_line":347,"start_character":26,"end_line":347,"end_character":52},"in_reply_to":"1f485f77_3cbbee72","updated":"2018-05-04 12:38:46.000000000","message":"The service_instance_security_group intention is rather different than this one (or set of these to be more precise). Service_instance_security_group is used for allowing ports for share servers while purpose of this is to limit ssh access from any other network than its service network.","commit_id":"a63d35ad562d9c33e65344c4e1fd86d86f04bf58"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"99afb6ee4a65a8627c3ebaa4782b43ed2db0cad8","unresolved":false,"context_lines":[{"line_number":571,"context_line":"                service_instance[\u0027id\u0027],"},{"line_number":572,"context_line":"                self.max_time_to_build_instance)"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"            if self.get_config_option(\"limit_ssh_access\"):"},{"line_number":575,"context_line":"                try:"},{"line_number":576,"context_line":"                    service_subnet \u003d network_data[\u0027service_subnet\u0027]"},{"line_number":577,"context_line":"                except KeyError:"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f485f77_e6e4a9ae","line":574,"range":{"start_line":574,"start_character":12,"end_line":574,"end_character":58},"updated":"2017-11-14 10:30:17.000000000","message":"If the \"limit_ssh_access\" type is cfg.StrOpt, it could be set to any value and the value is work, not just \"True\" is work.","commit_id":"a63d35ad562d9c33e65344c4e1fd86d86f04bf58"},{"author":{"_account_id":26768,"name":"Jan Vondra","email":"jan.vondra@ultimum.io","username":"JanVondra"},"change_message_id":"87c0742f3a240d1098f3f6124c97c693c8139ec4","unresolved":false,"context_lines":[{"line_number":571,"context_line":"                service_instance[\u0027id\u0027],"},{"line_number":572,"context_line":"                self.max_time_to_build_instance)"},{"line_number":573,"context_line":""},{"line_number":574,"context_line":"            if self.get_config_option(\"limit_ssh_access\"):"},{"line_number":575,"context_line":"                try:"},{"line_number":576,"context_line":"                    service_subnet \u003d network_data[\u0027service_subnet\u0027]"},{"line_number":577,"context_line":"                except KeyError:"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f7c97a3_31dc8573","line":574,"range":{"start_line":574,"start_character":12,"end_line":574,"end_character":58},"in_reply_to":"1f485f77_e6e4a9ae","updated":"2018-05-04 12:38:46.000000000","message":"Done","commit_id":"a63d35ad562d9c33e65344c4e1fd86d86f04bf58"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"4a229c4be432b5cb4cfde006181f58a58ea5078f","unresolved":false,"context_lines":[{"line_number":579,"context_line":"                        \"Unable to limit ssh access to instance id: \u0027%s\u0027!\","},{"line_number":580,"context_line":"                        fail_safe_data[\u0027instance_id\u0027])"},{"line_number":581,"context_line":"                    raise exception.ManilaException("},{"line_number":582,"context_line":"                        \"SSH limitation could not be set up - \""},{"line_number":583,"context_line":"                        \"invalid service subnet details provided\")"},{"line_number":584,"context_line":"            else:"},{"line_number":585,"context_line":"                service_subnet \u003d False"}],"source_content_type":"text/x-python","patch_set":11,"id":"1f485f77_ebb8092b","line":582,"range":{"start_line":582,"start_character":25,"end_line":582,"end_character":59},"updated":"2017-11-13 14:54:38.000000000","message":"_(\"Unable to limit SSH access to the service instance...\"","commit_id":"a63d35ad562d9c33e65344c4e1fd86d86f04bf58"},{"author":{"_account_id":26768,"name":"Jan Vondra","email":"jan.vondra@ultimum.io","username":"JanVondra"},"change_message_id":"87c0742f3a240d1098f3f6124c97c693c8139ec4","unresolved":false,"context_lines":[{"line_number":579,"context_line":"                        \"Unable to limit ssh access to instance id: \u0027%s\u0027!\","},{"line_number":580,"context_line":"                        fail_safe_data[\u0027instance_id\u0027])"},{"line_number":581,"context_line":"                    raise exception.ManilaException("},{"line_number":582,"context_line":"                        \"SSH limitation could not be set up - \""},{"line_number":583,"context_line":"                        \"invalid service subnet details provided\")"},{"line_number":584,"context_line":"            else:"},{"line_number":585,"context_line":"                service_subnet \u003d False"}],"source_content_type":"text/x-python","patch_set":11,"id":"5f7c97a3_51d90181","line":582,"range":{"start_line":582,"start_character":25,"end_line":582,"end_character":59},"in_reply_to":"1f485f77_ebb8092b","updated":"2018-05-04 12:38:46.000000000","message":"Done","commit_id":"a63d35ad562d9c33e65344c4e1fd86d86f04bf58"}],"releasenotes/notes/limiting-ssh-access-from-tenant-network-6519efd6d6895076.yaml":[{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"dd902f8fee170c6474c683f4e52388b84fc4fd5c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"security:"},{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    added blocking port 22 in service images from other subnets than"},{"line_number":4,"context_line":"    manila service network"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7f287b81_c6a451bc","line":4,"range":{"start_line":3,"start_character":3,"end_line":4,"end_character":26},"updated":"2017-09-01 14:20:19.000000000","message":"you should mention that this is related to the generic driver, as all release notes pertaining to patches of all driver vendors will not be separated.","commit_id":"7020f7de45a6e559d8779ff3c71cb17dc1ae0ddb"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"c2a28bc6297d0682b88857272e249fa9d6c84298","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"security:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Generic driver - added blocking port 22 in service images from other subnets than"},{"line_number":5,"context_line":"    manila service network"}],"source_content_type":"text/x-yaml","patch_set":7,"id":"5f2577a7_f2d9de56","line":4,"range":{"start_line":4,"start_character":21,"end_line":4,"end_character":35},"updated":"2017-10-18 10:16:22.000000000","message":"Suggest: Service Instance Module - Added option to block port 22 to service VMs from ...","commit_id":"4c7f9ba5b98356fa30e47737d891dba549cd4ce9"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"8efd4d9599bd169fc05a5de5741363c4a7f9236b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"security:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Service Instance Module - Added option to block port 22 in service images from other subnets "},{"line_number":5,"context_line":"    than manila service network."}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3f4b6375_4236a5e8","line":4,"range":{"start_line":4,"start_character":71,"end_line":4,"end_character":77},"updated":"2017-10-23 15:40:52.000000000","message":"\"in Service VMs\" -- you aren\u0027t manipulating the boot image for the Service VMs anymore.","commit_id":"933cf8bedccce1d010af41b68b635175aaf08da3"}]}
