)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"806554e37492c08724a56c7989c5d306842b3be7","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Pengju Jiao \u003cjiaopengju@cmss.chinamobile.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-09-14 09:27:43 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \u0027try catch\u0027 of writting file in ganesha driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, in ganesha driver, we use two \u0027ssh\u0027 operations"},{"line_number":10,"context_line":"to generate a valid export configuration file. But some"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f2577a7_74338b15","line":7,"updated":"2017-09-15 05:48:40.000000000","message":"s/writting/writing/\n\nThe commit message isn\u0027t very clear to me.\nMaybe say, ganesha: cleanup of tmp config files","commit_id":"93b897794f536304ae48aa77237e064062ff980c"},{"author":{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},"change_message_id":"a7a69db0311642b57bd545684d496cf2c76bb4ba","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Pengju Jiao \u003cjiaopengju@cmss.chinamobile.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-09-14 09:27:43 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \u0027try catch\u0027 of writting file in ganesha driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, in ganesha driver, we use two \u0027ssh\u0027 operations"},{"line_number":10,"context_line":"to generate a valid export configuration file. But some"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f2577a7_d4bc6907","line":7,"in_reply_to":"5f2577a7_74338b15","updated":"2017-09-16 15:06:24.000000000","message":"Done","commit_id":"93b897794f536304ae48aa77237e064062ff980c"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"806554e37492c08724a56c7989c5d306842b3be7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \u0027try catch\u0027 of writting file in ganesha driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, in ganesha driver, we use two \u0027ssh\u0027 operations"},{"line_number":10,"context_line":"to generate a valid export configuration file. But some"},{"line_number":11,"context_line":"times the second \u0027ssh\u0027 operation may execute failed. In"},{"line_number":12,"context_line":"this case, ganesha driver will generate invalid files (the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f2577a7_3720659b","line":9,"updated":"2017-09-15 05:48:40.000000000","message":"Generation of export config file doesn\u0027t always require ssh operations. They\u0027re not used if ganesha server is local to manila-share service node. Maybe you can just say that while writing ganesha config files some times the tmp config files don\u0027t cleaned up?","commit_id":"93b897794f536304ae48aa77237e064062ff980c"},{"author":{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},"change_message_id":"a7a69db0311642b57bd545684d496cf2c76bb4ba","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add \u0027try catch\u0027 of writting file in ganesha driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently, in ganesha driver, we use two \u0027ssh\u0027 operations"},{"line_number":10,"context_line":"to generate a valid export configuration file. But some"},{"line_number":11,"context_line":"times the second \u0027ssh\u0027 operation may execute failed. In"},{"line_number":12,"context_line":"this case, ganesha driver will generate invalid files (the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f2577a7_b4b9dd15","line":9,"in_reply_to":"5f2577a7_3720659b","updated":"2017-09-16 15:06:24.000000000","message":"Done","commit_id":"93b897794f536304ae48aa77237e064062ff980c"},{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"806554e37492c08724a56c7989c5d306842b3be7","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently, in ganesha driver, we use two \u0027ssh\u0027 operations"},{"line_number":10,"context_line":"to generate a valid export configuration file. But some"},{"line_number":11,"context_line":"times the second \u0027ssh\u0027 operation may execute failed. In"},{"line_number":12,"context_line":"this case, ganesha driver will generate invalid files (the"},{"line_number":13,"context_line":"tmpf file) and these files will never be removed."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch add try catch block on second \u0027ssh\u0027 operation"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f2577a7_575411ff","line":12,"updated":"2017-09-15 05:48:40.000000000","message":"I find the use of invalid confusing. You can just say that you\u0027re cleaning up tmp config files if something goes wrong while moving the config file from tmp location to the correct ganesha config location.","commit_id":"93b897794f536304ae48aa77237e064062ff980c"},{"author":{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},"change_message_id":"a7a69db0311642b57bd545684d496cf2c76bb4ba","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently, in ganesha driver, we use two \u0027ssh\u0027 operations"},{"line_number":10,"context_line":"to generate a valid export configuration file. But some"},{"line_number":11,"context_line":"times the second \u0027ssh\u0027 operation may execute failed. In"},{"line_number":12,"context_line":"this case, ganesha driver will generate invalid files (the"},{"line_number":13,"context_line":"tmpf file) and these files will never be removed."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch add try catch block on second \u0027ssh\u0027 operation"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f2577a7_943821a0","line":12,"in_reply_to":"5f2577a7_575411ff","updated":"2017-09-16 15:06:24.000000000","message":"Done","commit_id":"93b897794f536304ae48aa77237e064062ff980c"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"c8002cd0f1927e2cd3ce9074875ba25bed3b6b88","unresolved":false,"context_lines":[{"line_number":12,"context_line":"tmp location to the correct ganesha config location"},{"line_number":13,"context_line":"sometimes goes wrong."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch add operation of cleaning up the tmp config"},{"line_number":16,"context_line":"files."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Id93a5062c48e99afc26594f05cbf29cffce1499e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f2577a7_7e2d7da6","line":15,"range":{"start_line":15,"start_character":11,"end_line":15,"end_character":14},"updated":"2017-09-18 13:24:57.000000000","message":"nit: adds","commit_id":"3b2a02a4e5fe3ba2b2e9b7b1672652a75015c7f5"}],"manila/share/drivers/ganesha/manager.py":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@canonical.com","username":"toabctl"},"change_message_id":"373e9c3cafc14922dad52ad2e413fe7f95b7ce80","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            \u0027echo %s \u003e %s\u0027 % (pipes.quote(data), pipes.quote(tmpf)),"},{"line_number":261,"context_line":"            message\u003d\u0027writing \u0027 + tmpf)"},{"line_number":262,"context_line":"        try:"},{"line_number":263,"context_line":"            self.execute(\u0027mv\u0027, tmpf, path)"},{"line_number":264,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":265,"context_line":"            LOG.error(\u0027mv temp file ({0}) to {1} failed.\u0027.format(tmpf, path))"},{"line_number":266,"context_line":"            self.execute(\u0027rm\u0027, tmpf)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f2577a7_5be09326","line":263,"updated":"2017-09-18 12:28:50.000000000","message":"This whole function should be rewritten and should use python methods todo file manipulations instead of forking extra processes for mktemp, mv and rm. But looks good anyway...","commit_id":"3b2a02a4e5fe3ba2b2e9b7b1672652a75015c7f5"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"c8002cd0f1927e2cd3ce9074875ba25bed3b6b88","unresolved":false,"context_lines":[{"line_number":260,"context_line":"            \u0027echo %s \u003e %s\u0027 % (pipes.quote(data), pipes.quote(tmpf)),"},{"line_number":261,"context_line":"            message\u003d\u0027writing \u0027 + tmpf)"},{"line_number":262,"context_line":"        try:"},{"line_number":263,"context_line":"            self.execute(\u0027mv\u0027, tmpf, path)"},{"line_number":264,"context_line":"        except exception.ProcessExecutionError:"},{"line_number":265,"context_line":"            LOG.error(\u0027mv temp file ({0}) to {1} failed.\u0027.format(tmpf, path))"},{"line_number":266,"context_line":"            self.execute(\u0027rm\u0027, tmpf)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f2577a7_3e3495fb","line":263,"in_reply_to":"5f2577a7_5be09326","updated":"2017-09-18 13:24:57.000000000","message":"+1","commit_id":"3b2a02a4e5fe3ba2b2e9b7b1672652a75015c7f5"}],"releasenotes/notes/bug-1717135-ganesha-cleanup-of-tmp-config-files-66082b2384ace0a5.yaml":[{"author":{"_account_id":8056,"name":"Ramana Raja","email":"rraja@redhat.com","username":"Ram_Raja"},"change_message_id":"156546aeb72f1f798b33e7717bd4f96cb34a2239","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Add operation of cleaning up the temp config files when moving the config"},{"line_number":4,"context_line":"    file from temp location to the correct ganesha config location goes wrong."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f2577a7_9801613b","line":3,"updated":"2017-09-18 12:02:11.000000000","message":"nit: s/Add/Added/","commit_id":"47f11ee1ff818fd8d9a8acdbcd2d69c3b8038044"},{"author":{"_account_id":21224,"name":"jiaopengju","email":"jiaopengju_yewu@cmss.chinamobile.com","username":"jiaopengju"},"change_message_id":"2bc640a1fb33cb1dae640e161d286c549b6bc5e5","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - Add operation of cleaning up the temp config files when moving the config"},{"line_number":4,"context_line":"    file from temp location to the correct ganesha config location goes wrong."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f2577a7_f8b6258a","line":3,"in_reply_to":"5f2577a7_9801613b","updated":"2017-09-18 12:05:39.000000000","message":"Done","commit_id":"47f11ee1ff818fd8d9a8acdbcd2d69c3b8038044"}]}