)]}'
{"manila/share/drivers/netapp/dataontap/client/api.py":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"1d41027cf2772cdc8662947641d996333a7f9e3c","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                 transport_type\u003dTRANSPORT_TYPE_HTTP,"},{"line_number":73,"context_line":"                 style\u003dSTYLE_LOGIN_PASSWORD, username\u003dNone,"},{"line_number":74,"context_line":"                 password\u003dNone, port\u003dNone, trace\u003dFalse,"},{"line_number":75,"context_line":"                 api_trace_pattern\u003dutils.TRACE_API_PATTERN):"},{"line_number":76,"context_line":"        self._host \u003d host"},{"line_number":77,"context_line":"        self.set_server_type(server_type)"},{"line_number":78,"context_line":"        self.set_transport_type(transport_type)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf57530f_b473c54d","line":75,"updated":"2017-09-20 10:45:07.000000000","message":"nit: naming it \"trace_api_pattern\" would fit the \"trace\" var and also utils.TRACE_API_PATTERN","commit_id":"ffc2903b05bed58bc07b92a0775c083b63845e24"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"446ffaa4cbc5a07cd4ad791682f3ba98870083e6","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                 transport_type\u003dTRANSPORT_TYPE_HTTP,"},{"line_number":73,"context_line":"                 style\u003dSTYLE_LOGIN_PASSWORD, username\u003dNone,"},{"line_number":74,"context_line":"                 password\u003dNone, port\u003dNone, trace\u003dFalse,"},{"line_number":75,"context_line":"                 api_trace_pattern\u003dutils.TRACE_API_PATTERN):"},{"line_number":76,"context_line":"        self._host \u003d host"},{"line_number":77,"context_line":"        self.set_server_type(server_type)"},{"line_number":78,"context_line":"        self.set_transport_type(transport_type)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf57530f_0abedb64","line":75,"in_reply_to":"bf57530f_03f376a0","updated":"2017-09-20 18:24:25.000000000","message":"agree with Rodrigo.. the \"TRACE_API_PATTERN\" naming occurred because of the naming style of the constants in this file: https://review.openstack.org/#/c/505437/1/manila/share/drivers/netapp/utils.py@37","commit_id":"ffc2903b05bed58bc07b92a0775c083b63845e24"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"406840f4d385894a08e8dc9657a5a6d46735d1a4","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                 transport_type\u003dTRANSPORT_TYPE_HTTP,"},{"line_number":73,"context_line":"                 style\u003dSTYLE_LOGIN_PASSWORD, username\u003dNone,"},{"line_number":74,"context_line":"                 password\u003dNone, port\u003dNone, trace\u003dFalse,"},{"line_number":75,"context_line":"                 api_trace_pattern\u003dutils.TRACE_API_PATTERN):"},{"line_number":76,"context_line":"        self._host \u003d host"},{"line_number":77,"context_line":"        self.set_server_type(server_type)"},{"line_number":78,"context_line":"        self.set_transport_type(transport_type)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf57530f_3356b62b","line":75,"in_reply_to":"bf57530f_0abedb64","updated":"2017-09-20 20:02:28.000000000","message":"Done","commit_id":"ffc2903b05bed58bc07b92a0775c083b63845e24"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"1b17d278b02f1ce0cc8862f73d3a4501c5a161e5","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                 transport_type\u003dTRANSPORT_TYPE_HTTP,"},{"line_number":73,"context_line":"                 style\u003dSTYLE_LOGIN_PASSWORD, username\u003dNone,"},{"line_number":74,"context_line":"                 password\u003dNone, port\u003dNone, trace\u003dFalse,"},{"line_number":75,"context_line":"                 api_trace_pattern\u003dutils.TRACE_API_PATTERN):"},{"line_number":76,"context_line":"        self._host \u003d host"},{"line_number":77,"context_line":"        self.set_server_type(server_type)"},{"line_number":78,"context_line":"        self.set_transport_type(transport_type)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf57530f_03f376a0","line":75,"in_reply_to":"bf57530f_b473c54d","updated":"2017-09-20 13:23:55.000000000","message":"in fact I think utils.API_TRACE_PATTERN is more readable.... but just a nit.","commit_id":"ffc2903b05bed58bc07b92a0775c083b63845e24"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"1d41027cf2772cdc8662947641d996333a7f9e3c","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        self._username \u003d username"},{"line_number":83,"context_line":"        self._password \u003d password"},{"line_number":84,"context_line":"        self._trace \u003d trace"},{"line_number":85,"context_line":"        self._api_trace_pattern \u003d api_trace_pattern"},{"line_number":86,"context_line":"        self._refresh_conn \u003d True"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        LOG.debug(\u0027Using NetApp controller: %s\u0027, self._host)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf57530f_54980969","line":85,"updated":"2017-09-20 10:45:07.000000000","message":"same here: imo self._trace_api_pattern would be better","commit_id":"ffc2903b05bed58bc07b92a0775c083b63845e24"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"406840f4d385894a08e8dc9657a5a6d46735d1a4","unresolved":false,"context_lines":[{"line_number":82,"context_line":"        self._username \u003d username"},{"line_number":83,"context_line":"        self._password \u003d password"},{"line_number":84,"context_line":"        self._trace \u003d trace"},{"line_number":85,"context_line":"        self._api_trace_pattern \u003d api_trace_pattern"},{"line_number":86,"context_line":"        self._refresh_conn \u003d True"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        LOG.debug(\u0027Using NetApp controller: %s\u0027, self._host)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf57530f_1331720c","line":85,"in_reply_to":"bf57530f_54980969","updated":"2017-09-20 20:02:28.000000000","message":"Done differently","commit_id":"ffc2903b05bed58bc07b92a0775c083b63845e24"}],"manila/share/drivers/netapp/options.py":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"1d41027cf2772cdc8662947641d996333a7f9e3c","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                     \u0027include method and api. API logging can further be \u0027"},{"line_number":119,"context_line":"                     \u0027filtered with the \u0027"},{"line_number":120,"context_line":"                     \u0027``netapp_api_trace_pattern option``.\u0027)),"},{"line_number":121,"context_line":"    cfg.StrOpt(\u0027netapp_api_trace_pattern\u0027,"},{"line_number":122,"context_line":"               default\u003d\u0027(.*)\u0027,"},{"line_number":123,"context_line":"               help\u003d(\u0027A regular expression to limit the API tracing. This \u0027"},{"line_number":124,"context_line":"                     \u0027option is honored only if enabling ``api`` tracing \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf57530f_34b6b5db","line":121,"updated":"2017-09-20 10:45:07.000000000","message":"netapp_trace_api_pattern","commit_id":"ffc2903b05bed58bc07b92a0775c083b63845e24"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"1b17d278b02f1ce0cc8862f73d3a4501c5a161e5","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                     \u0027include method and api. API logging can further be \u0027"},{"line_number":119,"context_line":"                     \u0027filtered with the \u0027"},{"line_number":120,"context_line":"                     \u0027``netapp_api_trace_pattern option``.\u0027)),"},{"line_number":121,"context_line":"    cfg.StrOpt(\u0027netapp_api_trace_pattern\u0027,"},{"line_number":122,"context_line":"               default\u003d\u0027(.*)\u0027,"},{"line_number":123,"context_line":"               help\u003d(\u0027A regular expression to limit the API tracing. This \u0027"},{"line_number":124,"context_line":"                     \u0027option is honored only if enabling ``api`` tracing \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf57530f_c3dc3e1a","line":121,"in_reply_to":"bf57530f_34b6b5db","updated":"2017-09-20 13:23:55.000000000","message":"I personally think \"api_trace_pattern\" is more readable.","commit_id":"ffc2903b05bed58bc07b92a0775c083b63845e24"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"446ffaa4cbc5a07cd4ad791682f3ba98870083e6","unresolved":false,"context_lines":[{"line_number":118,"context_line":"                     \u0027include method and api. API logging can further be \u0027"},{"line_number":119,"context_line":"                     \u0027filtered with the \u0027"},{"line_number":120,"context_line":"                     \u0027``netapp_api_trace_pattern option``.\u0027)),"},{"line_number":121,"context_line":"    cfg.StrOpt(\u0027netapp_api_trace_pattern\u0027,"},{"line_number":122,"context_line":"               default\u003d\u0027(.*)\u0027,"},{"line_number":123,"context_line":"               help\u003d(\u0027A regular expression to limit the API tracing. This \u0027"},{"line_number":124,"context_line":"                     \u0027option is honored only if enabling ``api`` tracing \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"bf57530f_8a888bc6","line":121,"in_reply_to":"bf57530f_c3dc3e1a","updated":"2017-09-20 18:24:25.000000000","message":"Tom: since the configuration option is human-facing, it feels nice to make it semantically readable. So I\u0027ll change the occurrences in code to align with this option rather.\n\n\"trace_api_pattern\" seems to suggest there are \"trace APIs\"... while the intent here is to limit the APIs we \"trace\"","commit_id":"ffc2903b05bed58bc07b92a0775c083b63845e24"}]}