)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5c373390706853d26f084217780880967a029498","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When an IPv6 literal is specified in manila.conf for the"},{"line_number":10,"context_line":"netapp_hostname option, automatically URL-escape it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id55e870066b6a669da83aa6a96f74ea76d6103bd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f4b6375_3c37fe01","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":0},"updated":"2017-10-25 23:34:10.000000000","message":"Please reference Blueprint: https://blueprints.launchpad.net/manila/+spec/netapp-ontap-ipv6-support and add a release note","commit_id":"aa745bf0acd2ba425066703321aaa47d5b6e2813"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"4558d41ea5b360c1239a1e017a8851731e41250d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"When an IPv6 literal is specified in manila.conf for the"},{"line_number":10,"context_line":"netapp_hostname option, automatically URL-escape it."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Id55e870066b6a669da83aa6a96f74ea76d6103bd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f4b6375_2900c9aa","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":0},"in_reply_to":"3f4b6375_3c37fe01","updated":"2017-11-07 01:30:36.000000000","message":"This change is more properly viewed as a bugfix than implementing a new feature. I filed a bug and referenced it here.","commit_id":"aa745bf0acd2ba425066703321aaa47d5b6e2813"}],"manila/share/drivers/netapp/dataontap/client/api.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"c7af11d0971ef1bfbf24e8611304717305cfd86b","unresolved":false,"context_lines":[{"line_number":325,"context_line":""},{"line_number":326,"context_line":"    def _get_url(self):"},{"line_number":327,"context_line":"        host \u003d self._host"},{"line_number":328,"context_line":"        if \u0027:\u0027 in host:"},{"line_number":329,"context_line":"            host \u003d \u0027[%s]\u0027 % host"},{"line_number":330,"context_line":"        return \u0027%s://%s:%s/%s\u0027 % (self._protocol, host, self._port, self._url)"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    def _build_opener(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_623948d5","line":329,"range":{"start_line":328,"start_character":8,"end_line":329,"end_character":32},"updated":"2017-10-26 07:24:01.000000000","message":"The host is the hostname (or IP address) for the storage system. How about if the hostname (It\u0027s not the IP address) include the \u0027:\u0027, then the hostname will wrapped by \u0027[]\u0027.\nWhy don\u0027t just use ipaddress.ip_address(six.text_type(address)).version or netaddr to check the host is ipv6 address format.","commit_id":"aa745bf0acd2ba425066703321aaa47d5b6e2813"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"63b41c8dad8527770c380059fd6f56c607703af3","unresolved":false,"context_lines":[{"line_number":325,"context_line":""},{"line_number":326,"context_line":"    def _get_url(self):"},{"line_number":327,"context_line":"        host \u003d self._host"},{"line_number":328,"context_line":"        if \u0027:\u0027 in host:"},{"line_number":329,"context_line":"            host \u003d \u0027[%s]\u0027 % host"},{"line_number":330,"context_line":"        return \u0027%s://%s:%s/%s\u0027 % (self._protocol, host, self._port, self._url)"},{"line_number":331,"context_line":""},{"line_number":332,"context_line":"    def _build_opener(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_7f8556ac","line":329,"range":{"start_line":328,"start_character":8,"end_line":329,"end_character":32},"in_reply_to":"3f4b6375_623948d5","updated":"2017-11-06 21:43:03.000000000","message":"There are many different ways to fix this bug. I\u0027m confident that this one will address the way this library is used in the NetApp driver. The hostname is expected to be one of:\n1) Literal IPv4 address\n2) Liberal IPv6 address\n3) DNS-resolvable hostname to be handled at a lower level\n\n1 and 3 already work fine. 2 is the bug. This change doesn\u0027t affect 1 or 3, but it fixes 2.","commit_id":"aa745bf0acd2ba425066703321aaa47d5b6e2813"}]}
