)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"6ccc2502ad56a5f751f192e548232b4715dc2c4a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Escape IPv6 exports correctly and setup the default export"},{"line_number":10,"context_line":"policy to allow both IPv4 and IPv6."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I84437b140e2a9561cc4092683209800101f45815"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f4b6375_bc5d2e48","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":0},"updated":"2017-10-25 23:33:39.000000000","message":"Please reference Blueprint: https://blueprints.launchpad.net/manila/+spec/netapp-ontap-ipv6-support and add a release note","commit_id":"8bc3efea4d705a690db952b4551c1cbc2f1526a7"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"6e886b67a90526944af089e85b9f2b0ffc5a21b6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Escape IPv6 exports correctly and setup the default export"},{"line_number":10,"context_line":"policy to allow both IPv4 and IPv6."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I84437b140e2a9561cc4092683209800101f45815"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f4b6375_296b2985","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":0},"in_reply_to":"3f4b6375_bc5d2e48","updated":"2017-11-07 01:28:51.000000000","message":"Done","commit_id":"8bc3efea4d705a690db952b4551c1cbc2f1526a7"}],"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"57957aa67f7c4c2afae665af2054ccd38b8adc05","unresolved":false,"context_lines":[{"line_number":3659,"context_line":"    def get_net_options(self):"},{"line_number":3660,"context_line":"        result \u003d self.send_request(\u0027net-options-get\u0027, None, False)"},{"line_number":3661,"context_line":"        options \u003d result.get_child_by_name(\u0027net-options\u0027)"},{"line_number":3662,"context_line":"        ipv6_enabled \u003d False"},{"line_number":3663,"context_line":"        ipv6_info \u003d options.get_child_by_name(\u0027ipv6-options-info\u0027)"},{"line_number":3664,"context_line":"        if ipv6_info:"},{"line_number":3665,"context_line":"            ipv6_enabled \u003d ipv6_info.get_child_content(\u0027enabled\u0027) \u003d\u003d \u0027true\u0027"},{"line_number":3666,"context_line":"        return {"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_0da1ae46","line":3663,"range":{"start_line":3662,"start_character":8,"end_line":3663,"end_character":66},"updated":"2017-10-26 06:58:00.000000000","message":"Do we need to get ipv4 options and check whether the ipv4 is enabled?","commit_id":"8bc3efea4d705a690db952b4551c1cbc2f1526a7"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"1896be612ea82dce7d31ea96837b5171d12dde1d","unresolved":false,"context_lines":[{"line_number":3659,"context_line":"    def get_net_options(self):"},{"line_number":3660,"context_line":"        result \u003d self.send_request(\u0027net-options-get\u0027, None, False)"},{"line_number":3661,"context_line":"        options \u003d result.get_child_by_name(\u0027net-options\u0027)"},{"line_number":3662,"context_line":"        ipv6_enabled \u003d False"},{"line_number":3663,"context_line":"        ipv6_info \u003d options.get_child_by_name(\u0027ipv6-options-info\u0027)"},{"line_number":3664,"context_line":"        if ipv6_info:"},{"line_number":3665,"context_line":"            ipv6_enabled \u003d ipv6_info.get_child_content(\u0027enabled\u0027) \u003d\u003d \u0027true\u0027"},{"line_number":3666,"context_line":"        return {"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_a97b9978","line":3663,"range":{"start_line":3662,"start_character":8,"end_line":3663,"end_character":66},"in_reply_to":"3f4b6375_0da1ae46","updated":"2017-11-07 01:25:29.000000000","message":"On NetApp devices, IPv4 cannot be disabled.","commit_id":"8bc3efea4d705a690db952b4551c1cbc2f1526a7"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_single_svm.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"57957aa67f7c4c2afae665af2054ccd38b8adc05","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        interfaces \u003d vserver_client.get_network_interfaces()"},{"line_number":156,"context_line":"        for interface in interfaces:"},{"line_number":157,"context_line":"            address \u003d interface[\u0027address\u0027]"},{"line_number":158,"context_line":"            if \u0027:\u0027 in address:"},{"line_number":159,"context_line":"                ipv6 \u003d True"},{"line_number":160,"context_line":"            else:"},{"line_number":161,"context_line":"                ipv4 \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_28dc5844","line":158,"range":{"start_line":158,"start_character":12,"end_line":158,"end_character":30},"updated":"2017-10-26 06:58:00.000000000","message":"Why don\u0027t you use the following method, then we don\u0027t need to define temporary variable and can also check the address format.\n\"versions.append(ipaddress.ip_address(six.text_type(address)).version)\"","commit_id":"8bc3efea4d705a690db952b4551c1cbc2f1526a7"},{"author":{"_account_id":2417,"name":"Ben Swartzlander","email":"ben@swartzlander.org","username":"bswartz"},"change_message_id":"1896be612ea82dce7d31ea96837b5171d12dde1d","unresolved":false,"context_lines":[{"line_number":155,"context_line":"        interfaces \u003d vserver_client.get_network_interfaces()"},{"line_number":156,"context_line":"        for interface in interfaces:"},{"line_number":157,"context_line":"            address \u003d interface[\u0027address\u0027]"},{"line_number":158,"context_line":"            if \u0027:\u0027 in address:"},{"line_number":159,"context_line":"                ipv6 \u003d True"},{"line_number":160,"context_line":"            else:"},{"line_number":161,"context_line":"                ipv4 \u003d True"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_c9d6d54f","line":158,"range":{"start_line":158,"start_character":12,"end_line":158,"end_character":30},"in_reply_to":"3f4b6375_28dc5844","updated":"2017-11-07 01:25:29.000000000","message":"Your solution has a bug -- if there are multiple v4 or v6 addresses, the returned list will have duplicates in it.\n\nI agree the code is probably more verbose than it needs to be, but I think it\u0027s more readable this way. I\u0027ll choose readability over compactness every time.","commit_id":"8bc3efea4d705a690db952b4551c1cbc2f1526a7"}]}
