)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"6bfb970f1603b096d9f83354f92f3832b400df72","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Things like following is in api-ref, need to be correct."},{"line_number":10,"context_line":"  1. share_id is in path not in body"},{"line_number":11,"context_line":"  2. export_location_id is in path not in body"},{"line_number":12,"context_line":"  3. security_service_id is mandatory not optional"},{"line_number":13,"context_line":"This patch is to fix these."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1f485f77_c4260516","line":11,"range":{"start_line":11,"start_character":2,"end_line":11,"end_character":46},"updated":"2017-11-16 06:58:18.000000000","message":"nit: I didn\u0027t see any change about this. It just be deleted?","commit_id":"e192d828f704a1352c63e2b86281e367a49e4958"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":18529,"name":"Dongdong Pei","email":"peidongdong121@163.com","username":"dongdongpei"},"change_message_id":"c95e635f7d4d720fef5dfe791987cea882f251ee","unresolved":false,"context_lines":[{"line_number":2709,"context_line":"  in: body"},{"line_number":2710,"context_line":"  required: true"},{"line_number":2711,"context_line":"  type: string"},{"line_number":2712,"context_line":"share_id_4:"},{"line_number":2713,"context_line":"  description: |"},{"line_number":2714,"context_line":"    The UUID of the share from which to create a"},{"line_number":2715,"context_line":"    snapshot."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f485f77_9e50df34","side":"PARENT","line":2712,"range":{"start_line":2712,"start_character":0,"end_line":2712,"end_character":9},"updated":"2017-11-10 06:44:50.000000000","message":"Need to remove unused variable.","commit_id":"8946ea0088c93b8591526095bfef95370efb6028"},{"author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"change_message_id":"2fcac21efffc609f381b722de24871e91146c2a9","unresolved":false,"context_lines":[{"line_number":2709,"context_line":"  in: body"},{"line_number":2710,"context_line":"  required: true"},{"line_number":2711,"context_line":"  type: string"},{"line_number":2712,"context_line":"share_id_4:"},{"line_number":2713,"context_line":"  description: |"},{"line_number":2714,"context_line":"    The UUID of the share from which to create a"},{"line_number":2715,"context_line":"    snapshot."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"1f485f77_a1213ba2","side":"PARENT","line":2712,"range":{"start_line":2712,"start_character":0,"end_line":2712,"end_character":9},"in_reply_to":"1f485f77_9e50df34","updated":"2017-11-10 12:53:03.000000000","message":"Done","commit_id":"8946ea0088c93b8591526095bfef95370efb6028"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"4e1481a3641b3ef600458856c9d5edf42bcb71a3","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  type: string"},{"line_number":9,"context_line":"  description: \u003e"},{"line_number":10,"context_line":"    The API version as returned in the links from the ``GET /`` call."},{"line_number":11,"context_line":"export_location_id_path:"},{"line_number":12,"context_line":"  description: |"},{"line_number":13,"context_line":"    The UUID of the export location."},{"line_number":14,"context_line":"  in: path"},{"line_number":15,"context_line":"  required: true"},{"line_number":16,"context_line":"  type: string"},{"line_number":17,"context_line":"group_snapshot_id_path:"},{"line_number":18,"context_line":"  description: |"},{"line_number":19,"context_line":"    The group snapshot ID."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f485f77_72be3466","line":16,"range":{"start_line":11,"start_character":0,"end_line":16,"end_character":14},"updated":"2017-11-14 08:33:41.000000000","message":"It looks like we didn\u0027t use this parameter.","commit_id":"98d2e378c9ba9eb0a6a3925a7b4495eb043517dc"},{"author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"change_message_id":"ac7f8574879bd4817bc83b80d4ec7f9352732b87","unresolved":false,"context_lines":[{"line_number":8,"context_line":"  type: string"},{"line_number":9,"context_line":"  description: \u003e"},{"line_number":10,"context_line":"    The API version as returned in the links from the ``GET /`` call."},{"line_number":11,"context_line":"export_location_id_path:"},{"line_number":12,"context_line":"  description: |"},{"line_number":13,"context_line":"    The UUID of the export location."},{"line_number":14,"context_line":"  in: path"},{"line_number":15,"context_line":"  required: true"},{"line_number":16,"context_line":"  type: string"},{"line_number":17,"context_line":"group_snapshot_id_path:"},{"line_number":18,"context_line":"  description: |"},{"line_number":19,"context_line":"    The group snapshot ID."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f485f77_46a25d4d","line":16,"range":{"start_line":11,"start_character":0,"end_line":16,"end_character":14},"in_reply_to":"1f485f77_72be3466","updated":"2017-11-14 09:02:28.000000000","message":"Yeah, I double check this, export_location_path is used, this one is not used. So will remove this.","commit_id":"98d2e378c9ba9eb0a6a3925a7b4495eb043517dc"}],"api-ref/source/share-export-locations.inc":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0cf1af22f5697c8f883ec13ca27959947274ec6a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"Show single export location"},{"line_number":51,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":".. rest_method::  GET /v2/{tenant_id}/shares/{share_id}/export_locations/​{export_location_id_path}​"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Show details of an export location belonging to a share."},{"line_number":56,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"1f485f77_a8685c1c","line":53,"range":{"start_line":53,"start_character":75,"end_line":53,"end_character":98},"updated":"2017-11-17 03:12:29.000000000","message":"export_location_id\n\nIn the URL, you want to use names that probably make sense.. we use the variable export_location_id_path as a way to distinguish the resource in parameters.yaml, but that\u0027s not shown in the output as \"export_location_id_path\"","commit_id":"2fac96960760d865c4531b881c6037aaa24a5941"},{"author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"change_message_id":"ac2c68817e77976b9ab77c702cb0303b13e81d0f","unresolved":false,"context_lines":[{"line_number":50,"context_line":"Show single export location"},{"line_number":51,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":".. rest_method::  GET /v2/{tenant_id}/shares/{share_id}/export_locations/​{export_location_id_path}​"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Show details of an export location belonging to a share."},{"line_number":56,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"1f485f77_c6ea690d","line":53,"range":{"start_line":53,"start_character":75,"end_line":53,"end_character":98},"in_reply_to":"1f485f77_a8685c1c","updated":"2017-11-17 04:44:58.000000000","message":"The param export_location_id in the URL must be required. So I changed the export_location_id_path with the propertity required: true, because nowhere reference export_location_id_path, so change this one and use it.\nThe param export_location_id in output is in body, So I think we should still use export_location_id.","commit_id":"2fac96960760d865c4531b881c6037aaa24a5941"},{"author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"change_message_id":"7a6cd4ea5c5cb749a4d4ea61c068962d7e9f03ee","unresolved":false,"context_lines":[{"line_number":50,"context_line":"Show single export location"},{"line_number":51,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":".. rest_method::  GET /v2/{tenant_id}/shares/{share_id}/export_locations/​{export_location_id_path}​"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Show details of an export location belonging to a share."},{"line_number":56,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"1f485f77_26237dbf","line":53,"range":{"start_line":53,"start_character":75,"end_line":53,"end_character":98},"in_reply_to":"1f485f77_c6638941","updated":"2017-11-17 05:32:36.000000000","message":"Done","commit_id":"2fac96960760d865c4531b881c6037aaa24a5941"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dd7936bf89f51afc153bedd59509efd3f1283a05","unresolved":false,"context_lines":[{"line_number":50,"context_line":"Show single export location"},{"line_number":51,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":".. rest_method::  GET /v2/{tenant_id}/shares/{share_id}/export_locations/​{export_location_id_path}​"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"Show details of an export location belonging to a share."},{"line_number":56,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":6,"id":"1f485f77_c6638941","line":53,"range":{"start_line":53,"start_character":75,"end_line":53,"end_character":98},"in_reply_to":"1f485f77_c6ea690d","updated":"2017-11-17 05:15:56.000000000","message":"Your change parameters.yaml is correct. I\u0027m asking you to revert the naming in the URI above\n\n GET /v2/{tenant_id}/shares/{share_id}/export_locations/​{export_location_id}\n\nis more readable, and consistent with the other URIs. Check the output here: http://logs.openstack.org/41/507441/6/check/build-openstack-api-ref/8a75327/html/#show-single-export-location\n\n GET /v2/{tenant_id}/shares/{share_id}/export_locations/​{export_location_id_path}\n\nis not as readable, because there is another manila property called \"export_location_path\" which makes things confusing, so leave it as export_location_id in the URI.","commit_id":"2fac96960760d865c4531b881c6037aaa24a5941"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0cf1af22f5697c8f883ec13ca27959947274ec6a","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"   - share_id: share_id"},{"line_number":67,"context_line":"   - tenant_id: tenant_id_path"},{"line_number":68,"context_line":"   - export_location_id_path: export_location_id_path"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Response parameters"},{"line_number":71,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"1f485f77_8859208f","line":68,"range":{"start_line":68,"start_character":5,"end_line":68,"end_character":28},"updated":"2017-11-17 03:12:29.000000000","message":"export_location_id","commit_id":"2fac96960760d865c4531b881c6037aaa24a5941"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"dd7936bf89f51afc153bedd59509efd3f1283a05","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"   - share_id: share_id"},{"line_number":67,"context_line":"   - tenant_id: tenant_id_path"},{"line_number":68,"context_line":"   - export_location_id_path: export_location_id_path"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Response parameters"},{"line_number":71,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"1f485f77_a6688d1c","line":68,"range":{"start_line":68,"start_character":5,"end_line":68,"end_character":53},"updated":"2017-11-17 05:15:56.000000000","message":"this mapping should be:\n\n   - export_location_id: export_location_id_path\n\nLike tenant_id above..","commit_id":"2fac96960760d865c4531b881c6037aaa24a5941"},{"author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"change_message_id":"7a6cd4ea5c5cb749a4d4ea61c068962d7e9f03ee","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"   - share_id: share_id"},{"line_number":67,"context_line":"   - tenant_id: tenant_id_path"},{"line_number":68,"context_line":"   - export_location_id_path: export_location_id_path"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"Response parameters"},{"line_number":71,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"1f485f77_062c01aa","line":68,"range":{"start_line":68,"start_character":5,"end_line":68,"end_character":53},"in_reply_to":"1f485f77_a6688d1c","updated":"2017-11-17 05:32:36.000000000","message":"Done","commit_id":"2fac96960760d865c4531b881c6037aaa24a5941"}],"api-ref/source/share-instance-export-locations.inc":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"556210673fb4da5193c855de58e71baadb4d003d","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"   - tenant_id: tenant_id_path"},{"line_number":68,"context_line":"   - share_instance_id: share_instance_id"},{"line_number":69,"context_line":"   - export_location_id: export_location_id"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Response parameters"},{"line_number":72,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"1f485f77_844a4da9","line":69,"range":{"start_line":69,"start_character":25,"end_line":69,"end_character":43},"updated":"2017-11-16 07:00:27.000000000","message":"It is still in body? \nexport_location_id:\n  description: |\n    The share export location UUID.\n  in: body\n  required: true\n  type: string","commit_id":"e192d828f704a1352c63e2b86281e367a49e4958"},{"author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"change_message_id":"f41176e493d0469cfae847490e04419324ff7120","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"   - tenant_id: tenant_id_path"},{"line_number":68,"context_line":"   - share_instance_id: share_instance_id"},{"line_number":69,"context_line":"   - export_location_id: export_location_id"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Response parameters"},{"line_number":72,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"1f485f77_68594433","line":69,"range":{"start_line":69,"start_character":25,"end_line":69,"end_character":43},"in_reply_to":"1f485f77_6fd27302","updated":"2017-11-17 02:34:47.000000000","message":"Thanks Goutham and Zhongjun, I have updated this.","commit_id":"e192d828f704a1352c63e2b86281e367a49e4958"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ca4057c8a9a69b8765e0ddb1041c9ad5dc4289b6","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"   - tenant_id: tenant_id_path"},{"line_number":68,"context_line":"   - share_instance_id: share_instance_id"},{"line_number":69,"context_line":"   - export_location_id: export_location_id"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Response parameters"},{"line_number":72,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":5,"id":"1f485f77_6fd27302","line":69,"range":{"start_line":69,"start_character":25,"end_line":69,"end_character":43},"in_reply_to":"1f485f77_844a4da9","updated":"2017-11-16 20:28:17.000000000","message":"Good catch. This is the right pace for export_location_id_path","commit_id":"e192d828f704a1352c63e2b86281e367a49e4958"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0cf1af22f5697c8f883ec13ca27959947274ec6a","unresolved":false,"context_lines":[{"line_number":52,"context_line":"Show single export location"},{"line_number":53,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":".. rest_method::  GET /v2/{tenant_id}/share_instances/{share_instance_id}/export_locations/{export_location_id_path}"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"Normal response codes: 200"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"1f485f77_888000c1","line":55,"range":{"start_line":55,"start_character":92,"end_line":55,"end_character":110},"updated":"2017-11-17 03:12:29.000000000","message":"This should be export_location_id","commit_id":"2fac96960760d865c4531b881c6037aaa24a5941"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"0cf1af22f5697c8f883ec13ca27959947274ec6a","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"   - tenant_id: tenant_id_path"},{"line_number":68,"context_line":"   - share_instance_id: share_instance_id"},{"line_number":69,"context_line":"   - export_location_id_path: export_location_id_path"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"Response parameters"},{"line_number":72,"context_line":"-------------------"}],"source_content_type":"text/x-c++src","patch_set":6,"id":"1f485f77_087410fd","line":69,"range":{"start_line":69,"start_character":5,"end_line":69,"end_character":28},"updated":"2017-11-17 03:12:29.000000000","message":"this should be export_location_id","commit_id":"2fac96960760d865c4531b881c6037aaa24a5941"}]}
