)]}'
{"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8ead9808e2f3608eaebc97d468d24aaf44c0b8d8","unresolved":false,"context_lines":[{"line_number":1327,"context_line":"        # \u0027cifs-server\u0027 is CIFS Server NetBIOS Name, max length is 15."},{"line_number":1328,"context_line":"        # Should be unique within each domain (data[\u0027domain\u0027])"},{"line_number":1329,"context_line":"        # and a valid DNS hostname."},{"line_number":1330,"context_line":"        cifs_server \u003d vserver_name[-36:-23].upper()"},{"line_number":1331,"context_line":"        api_args \u003d {"},{"line_number":1332,"context_line":"            \u0027admin-username\u0027: security_service[\u0027user\u0027],"},{"line_number":1333,"context_line":"            \u0027admin-password\u0027: security_service[\u0027password\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_70445674","line":1330,"range":{"start_line":1330,"start_character":32,"end_line":1330,"end_character":33},"updated":"2018-06-25 16:22:41.000000000","message":"vserver_name.split(\u0027_\u0027)[-1]","commit_id":"7dee3fc61d6f02957a750eb6f980e1080f30a70a"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"3da43bd6274229a0edb8e13bda6796da3b396751","unresolved":false,"context_lines":[{"line_number":1324,"context_line":"        \"\"\"Configures AD on Vserver.\"\"\""},{"line_number":1325,"context_line":"        self.configure_dns(security_service)"},{"line_number":1326,"context_line":""},{"line_number":1327,"context_line":"        # \u0027cifs-server\u0027 is CIFS Server NetBIOS Name, max length is 15."},{"line_number":1328,"context_line":"        # Should be unique within each domain (data[\u0027domain\u0027])"},{"line_number":1329,"context_line":"        # and a valid DNS hostname."},{"line_number":1330,"context_line":"        cifs_server \u003d vserver_name[-36:-23].upper()"},{"line_number":1331,"context_line":"        api_args \u003d {"},{"line_number":1332,"context_line":"            \u0027admin-username\u0027: security_service[\u0027user\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_e17f7614","line":1329,"range":{"start_line":1327,"start_character":0,"end_line":1329,"end_character":35},"updated":"2018-06-25 12:32:08.000000000","message":"Does this comment need an update?","commit_id":"39e5da85dd58a15d6223112bf39c0f55dfac1a58"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8ead9808e2f3608eaebc97d468d24aaf44c0b8d8","unresolved":false,"context_lines":[{"line_number":1327,"context_line":"        # \u0027cifs-server\u0027 is CIFS Server NetBIOS Name, max length is 15."},{"line_number":1328,"context_line":"        # Should be unique within each domain (data[\u0027domain\u0027])"},{"line_number":1329,"context_line":"        # and a valid DNS hostname."},{"line_number":1330,"context_line":"        cifs_server \u003d vserver_name[-36:-23].upper()"},{"line_number":1331,"context_line":"        api_args \u003d {"},{"line_number":1332,"context_line":"            \u0027admin-username\u0027: security_service[\u0027user\u0027],"},{"line_number":1333,"context_line":"            \u0027admin-password\u0027: security_service[\u0027password\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_4fd52c42","line":1330,"range":{"start_line":1330,"start_character":22,"end_line":1330,"end_character":43},"updated":"2018-06-25 16:22:41.000000000","message":"This is fine, but it doesn\u0027t get you a valid hostname if someone decides to put invalid characters at the end of `netapp_vserver_name_template`. You could probably change the help text for that configuration option to make things clearer.","commit_id":"39e5da85dd58a15d6223112bf39c0f55dfac1a58"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"90545b297f34a6a82695c5d631377db49d7c6ad3","unresolved":false,"context_lines":[{"line_number":1382,"context_line":"        # \u0027cifs-server\u0027 is CIFS Server NetBIOS Name, max length is 15."},{"line_number":1383,"context_line":"        # Should be unique within each domain (data[\u0027domain\u0027])"},{"line_number":1384,"context_line":"        # and a valid DNS hostname."},{"line_number":1385,"context_line":"        cifs_server \u003d vserver_name[-36:-23].upper()"},{"line_number":1386,"context_line":"        api_args \u003d {"},{"line_number":1387,"context_line":"            \u0027admin-username\u0027: security_service[\u0027user\u0027],"},{"line_number":1388,"context_line":"            \u0027admin-password\u0027: security_service[\u0027password\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_31ea1075","line":1385,"range":{"start_line":1385,"start_character":8,"end_line":1385,"end_character":51},"updated":"2018-08-08 14:21:54.000000000","message":"That approach uses only 13 characters.\n\nyou could do  x[-36:-28] + x[-7:] and maximize to 15 if you are dropping the \"..\" from the previous approach.","commit_id":"573a83a2d896403dd0fc1e9c90fece4af6cc47e7"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"fd960a58e56f0cdfeed4f764cf0de8915c6cb7bb","unresolved":false,"context_lines":[{"line_number":1382,"context_line":"        # \u0027cifs-server\u0027 is CIFS Server NetBIOS Name, max length is 15."},{"line_number":1383,"context_line":"        # Should be unique within each domain (data[\u0027domain\u0027])"},{"line_number":1384,"context_line":"        # and a valid DNS hostname."},{"line_number":1385,"context_line":"        cifs_server \u003d vserver_name[-36:-23].upper()"},{"line_number":1386,"context_line":"        api_args \u003d {"},{"line_number":1387,"context_line":"            \u0027admin-username\u0027: security_service[\u0027user\u0027],"},{"line_number":1388,"context_line":"            \u0027admin-password\u0027: security_service[\u0027password\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"3f79a3b5_753e2ddb","line":1385,"range":{"start_line":1385,"start_character":8,"end_line":1385,"end_character":51},"in_reply_to":"3f79a3b5_31ea1075","updated":"2018-08-08 19:58:21.000000000","message":"I would suggest to replace the original \u0027..\u0027 with \u0027-\u0027 and keep the beginning and end of the vserver name. Following Ganso\u0027s idea, I would say: x[-36:-28] + \u0027-\u0027 + x[-6:].\n\nI think this solves your problem and avoids a mess for the operator.","commit_id":"573a83a2d896403dd0fc1e9c90fece4af6cc47e7"}]}