)]}'
{"etc/manila/policy.json":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b1090b30c5d3e9d5b60f1bb14c1bfc733abeb903","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    \"share_snapshot_instance_export_location:index\": \"rule:admin_api\","},{"line_number":68,"context_line":"    \"share_snapshot_instance_export_location:show\": \"rule:admin_api\","},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    \"share_type:index\": \"rule:default\","},{"line_number":71,"context_line":"    \"share_type:show\": \"rule:default\","},{"line_number":72,"context_line":"    \"share_type:default\": \"rule:default\","},{"line_number":73,"context_line":"    \"share_type:create\": \"rule:admin_api\","}],"source_content_type":"application/json","patch_set":8,"id":"ff82abbf_09118652","side":"PARENT","line":70,"range":{"start_line":70,"start_character":25,"end_line":70,"end_character":37},"updated":"2017-11-27 16:48:53.000000000","message":"Where is this specified? What rule does this evaluate to?","commit_id":"db8b63c139c97f9ee0e67f61e6e38be4821df5e5"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"0920f6a5d2f7605261c8d49f66aaed41b19bbdff","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    \"share_snapshot_instance_export_location:index\": \"rule:admin_api\","},{"line_number":68,"context_line":"    \"share_snapshot_instance_export_location:show\": \"rule:admin_api\","},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    \"share_type:index\": \"rule:default\","},{"line_number":71,"context_line":"    \"share_type:show\": \"rule:default\","},{"line_number":72,"context_line":"    \"share_type:default\": \"rule:default\","},{"line_number":73,"context_line":"    \"share_type:create\": \"rule:admin_api\","}],"source_content_type":"application/json","patch_set":8,"id":"ff82abbf_638143fb","side":"PARENT","line":70,"range":{"start_line":70,"start_character":25,"end_line":70,"end_character":37},"in_reply_to":"ff82abbf_09118652","updated":"2017-11-28 03:35:58.000000000","message":"Done","commit_id":"db8b63c139c97f9ee0e67f61e6e38be4821df5e5"}],"manila/policies/share_type.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"3885ed780648501c2a87dc289d3542f51822b156","unresolved":false,"context_lines":[{"line_number":21,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":22,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027create\u0027,"},{"line_number":23,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":24,"context_line":"        description\u003d\"\"\"Create share type.\"\"\","},{"line_number":25,"context_line":"        operations\u003d["},{"line_number":26,"context_line":"            {"},{"line_number":27,"context_line":"                \u0027method\u0027: \u0027POST\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_c8b45938","line":24,"range":{"start_line":24,"start_character":19,"end_line":24,"end_character":23},"updated":"2017-10-10 15:07:29.000000000","message":"Is there a specific reason to use \"\"\" instead of \u0027?","commit_id":"a43254578430234790ca883c6919750d83b79300"},{"author":{"_account_id":19741,"name":"Hieu LE","email":"hieulq2@viettel.com.vn","username":"hieulq"},"change_message_id":"d051ab49dfb855404060761c14e2ca649d2486a7","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        operations\u003d["},{"line_number":26,"context_line":"            {"},{"line_number":27,"context_line":"                \u0027method\u0027: \u0027POST\u0027,"},{"line_number":28,"context_line":"                \u0027path\u0027: \u0027/types\u0027,"},{"line_number":29,"context_line":"            }"},{"line_number":30,"context_line":"        ]),"},{"line_number":31,"context_line":"    policy.DocumentedRuleDefault("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_97bc2b6a","line":28,"range":{"start_line":28,"start_character":17,"end_line":28,"end_character":21},"updated":"2017-10-11 06:17:36.000000000","message":"I think all path here should indicate {tenant_id} for consistency with manila api-ref doc","commit_id":"a43254578430234790ca883c6919750d83b79300"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7ce9ef718ea624f29a0ef04f3273969dff010513","unresolved":false,"context_lines":[{"line_number":25,"context_line":"        operations\u003d["},{"line_number":26,"context_line":"            {"},{"line_number":27,"context_line":"                \u0027method\u0027: \u0027POST\u0027,"},{"line_number":28,"context_line":"                \u0027path\u0027: \u0027/types\u0027,"},{"line_number":29,"context_line":"            }"},{"line_number":30,"context_line":"        ]),"},{"line_number":31,"context_line":"    policy.DocumentedRuleDefault("}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_3d9af513","line":28,"range":{"start_line":28,"start_character":17,"end_line":28,"end_character":21},"in_reply_to":"5f4e5783_97bc2b6a","updated":"2017-10-20 02:23:24.000000000","message":"It is a hint for user in new policy conf file. I think it is clear for user now, we don\u0027t need to add {tenant_id} in all places. such as other project does:\nhttps://github.com/openstack/nova/blob/master/nova/policies/config_drive.py#L32\nhttps://github.com/openstack/cinder/blob/master/cinder/policies/snapshots.py#L38","commit_id":"a43254578430234790ca883c6919750d83b79300"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7df5dfd47b0b017962f84f555607e07003d9fbea","unresolved":false,"context_lines":[{"line_number":20,"context_line":"share_type_policies \u003d ["},{"line_number":21,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":22,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027create\u0027,"},{"line_number":23,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":24,"context_line":"        description\u003d\u0027Create share type.\u0027,"},{"line_number":25,"context_line":"        operations\u003d["},{"line_number":26,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_5760e5ce","line":23,"range":{"start_line":23,"start_character":18,"end_line":23,"end_character":43},"updated":"2017-10-19 21:41:01.000000000","message":"Some of these looked like they changed from the definitions in policy.json. I\u0027m working on some functionality in oslo.policy to make changing these easier [0].\n\nFor now it might be easiest to just use the same check strings as policy.json.\n\n[0] https://review.openstack.org/#/c/509909/","commit_id":"a9b096b15b0749ab24a175ff625e6498429031c2"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7ce9ef718ea624f29a0ef04f3273969dff010513","unresolved":false,"context_lines":[{"line_number":20,"context_line":"share_type_policies \u003d ["},{"line_number":21,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":22,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027create\u0027,"},{"line_number":23,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":24,"context_line":"        description\u003d\u0027Create share type.\u0027,"},{"line_number":25,"context_line":"        operations\u003d["},{"line_number":26,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_0b3c8891","line":23,"range":{"start_line":23,"start_character":18,"end_line":23,"end_character":43},"in_reply_to":"3f4b6375_5760e5ce","updated":"2017-10-20 02:23:24.000000000","message":"Done","commit_id":"a9b096b15b0749ab24a175ff625e6498429031c2"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"7df5dfd47b0b017962f84f555607e07003d9fbea","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":86,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027add_project_access\u0027,"},{"line_number":87,"context_line":"        check_str\u003dbase.RULE_ADMIN_API,"},{"line_number":88,"context_line":"        description\u003d\"\"\"Add share type to project.\"\"\","},{"line_number":89,"context_line":"        operations\u003d["},{"line_number":90,"context_line":"            {"},{"line_number":91,"context_line":"                \u0027method\u0027: \u0027POST\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_5747c54c","line":88,"range":{"start_line":88,"start_character":19,"end_line":88,"end_character":23},"updated":"2017-10-19 21:41:01.000000000","message":"nit: use \u0027 to be consistent with the other usage in this module","commit_id":"a9b096b15b0749ab24a175ff625e6498429031c2"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7ce9ef718ea624f29a0ef04f3273969dff010513","unresolved":false,"context_lines":[{"line_number":85,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":86,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027add_project_access\u0027,"},{"line_number":87,"context_line":"        check_str\u003dbase.RULE_ADMIN_API,"},{"line_number":88,"context_line":"        description\u003d\"\"\"Add share type to project.\"\"\","},{"line_number":89,"context_line":"        operations\u003d["},{"line_number":90,"context_line":"            {"},{"line_number":91,"context_line":"                \u0027method\u0027: \u0027POST\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f4b6375_cb455019","line":88,"range":{"start_line":88,"start_character":19,"end_line":88,"end_character":23},"in_reply_to":"3f4b6375_5747c54c","updated":"2017-10-20 02:23:24.000000000","message":"Done","commit_id":"a9b096b15b0749ab24a175ff625e6498429031c2"},{"author":{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},"change_message_id":"b7f666ae9243b0e1344a6707f7296980eaaab883","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        operations\u003d["},{"line_number":90,"context_line":"            {"},{"line_number":91,"context_line":"                \u0027method\u0027: \u0027POST\u0027,"},{"line_number":92,"context_line":"                \u0027path\u0027: \u0027/types/{share_type_id}\u0027,"},{"line_number":93,"context_line":"            }"},{"line_number":94,"context_line":"        ]),"},{"line_number":95,"context_line":"    policy.DocumentedRuleDefault("}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_c8af0428","line":92,"range":{"start_line":92,"start_character":25,"end_line":92,"end_character":47},"updated":"2017-10-26 03:45:09.000000000","message":"I should be /types/{share_type_id}/action?","commit_id":"18284b3548a425f8b2c7d2737c6ec096e6f41314"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d2f167de319ad58d3bedfaea05167a0242edc053","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        operations\u003d["},{"line_number":90,"context_line":"            {"},{"line_number":91,"context_line":"                \u0027method\u0027: \u0027POST\u0027,"},{"line_number":92,"context_line":"                \u0027path\u0027: \u0027/types/{share_type_id}\u0027,"},{"line_number":93,"context_line":"            }"},{"line_number":94,"context_line":"        ]),"},{"line_number":95,"context_line":"    policy.DocumentedRuleDefault("}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_3d581154","line":92,"range":{"start_line":92,"start_character":25,"end_line":92,"end_character":47},"in_reply_to":"3f4b6375_c8af0428","updated":"2017-10-26 08:33:48.000000000","message":"Done","commit_id":"18284b3548a425f8b2c7d2737c6ec096e6f41314"},{"author":{"_account_id":19930,"name":"Dai Dang Van","email":"daidv@omzcloud.vn","username":"daidv"},"change_message_id":"b7f666ae9243b0e1344a6707f7296980eaaab883","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        operations\u003d["},{"line_number":100,"context_line":"            {"},{"line_number":101,"context_line":"                \u0027method\u0027: \u0027POST\u0027,"},{"line_number":102,"context_line":"                \u0027path\u0027: \u0027/types/{share_type_id}\u0027,"},{"line_number":103,"context_line":"            }"},{"line_number":104,"context_line":"        ]),"},{"line_number":105,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_88a58c49","line":102,"range":{"start_line":102,"start_character":25,"end_line":102,"end_character":46},"updated":"2017-10-26 03:45:09.000000000","message":"ditto","commit_id":"18284b3548a425f8b2c7d2737c6ec096e6f41314"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d2f167de319ad58d3bedfaea05167a0242edc053","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        operations\u003d["},{"line_number":100,"context_line":"            {"},{"line_number":101,"context_line":"                \u0027method\u0027: \u0027POST\u0027,"},{"line_number":102,"context_line":"                \u0027path\u0027: \u0027/types/{share_type_id}\u0027,"},{"line_number":103,"context_line":"            }"},{"line_number":104,"context_line":"        ]),"},{"line_number":105,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f4b6375_1d53153b","line":102,"range":{"start_line":102,"start_character":25,"end_line":102,"end_character":46},"in_reply_to":"3f4b6375_88a58c49","updated":"2017-10-26 08:33:48.000000000","message":"Done","commit_id":"18284b3548a425f8b2c7d2737c6ec096e6f41314"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b1090b30c5d3e9d5b60f1bb14c1bfc733abeb903","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        ]),"},{"line_number":34,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":35,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027show\u0027,"},{"line_number":36,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":37,"context_line":"        description\u003d\u0027Get share type.\u0027,"},{"line_number":38,"context_line":"        operations\u003d["},{"line_number":39,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff82abbf_694e1270","line":36,"range":{"start_line":36,"start_character":23,"end_line":36,"end_character":42},"updated":"2017-11-27 16:48:53.000000000","message":"Looks like the old default for this in policy.json was rule:default.\n\nhttps://github.com/openstack/manila/blob/master/manila/policies/base.py#L26","commit_id":"81a1dd997d95069304f23e4f0cc2c491fdca9ddf"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"0920f6a5d2f7605261c8d49f66aaed41b19bbdff","unresolved":false,"context_lines":[{"line_number":33,"context_line":"        ]),"},{"line_number":34,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":35,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027show\u0027,"},{"line_number":36,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":37,"context_line":"        description\u003d\u0027Get share type.\u0027,"},{"line_number":38,"context_line":"        operations\u003d["},{"line_number":39,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff82abbf_a3bd0bd9","line":36,"range":{"start_line":36,"start_character":23,"end_line":36,"end_character":42},"in_reply_to":"ff82abbf_694e1270","updated":"2017-11-28 03:35:58.000000000","message":"Done","commit_id":"81a1dd997d95069304f23e4f0cc2c491fdca9ddf"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"b1090b30c5d3e9d5b60f1bb14c1bfc733abeb903","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        ]),"},{"line_number":44,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":45,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027index\u0027,"},{"line_number":46,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":47,"context_line":"        description\u003d\u0027List share types.\u0027,"},{"line_number":48,"context_line":"        operations\u003d["},{"line_number":49,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff82abbf_e96a22b1","line":46,"range":{"start_line":46,"start_character":23,"end_line":46,"end_character":42},"updated":"2017-11-27 16:48:53.000000000","message":"Same comment here. We register rule:default as a policy in base.py but we don\u0027t reuse it anywhere.\n\nhttps://github.com/openstack/manila/blob/master/manila/policies/base.py#L26\n\nWe can reference it here\n\n  check_str\u003dbase.DEFAULT,\n\nAnd then define it in one place in base.py to be used everywhere. This should keep things consistent with the old default, at least until we can propose changes or remove default with a new version of oslo.policy [0].\n\n[0] https://github.com/openstack/oslo.policy/commit/d3ea093c18a2c9e83ae9dcb3a3f5f3deae213bf8","commit_id":"81a1dd997d95069304f23e4f0cc2c491fdca9ddf"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"0920f6a5d2f7605261c8d49f66aaed41b19bbdff","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        ]),"},{"line_number":44,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":45,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027index\u0027,"},{"line_number":46,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":47,"context_line":"        description\u003d\u0027List share types.\u0027,"},{"line_number":48,"context_line":"        operations\u003d["},{"line_number":49,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":8,"id":"ff82abbf_c3c28f59","line":46,"range":{"start_line":46,"start_character":23,"end_line":46,"end_character":42},"in_reply_to":"ff82abbf_e96a22b1","updated":"2017-11-28 03:35:58.000000000","message":"Done","commit_id":"81a1dd997d95069304f23e4f0cc2c491fdca9ddf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"646cf576aaabf3c6603dd4c4d77968c68ae2d2c2","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        operations\u003d["},{"line_number":63,"context_line":"            {"},{"line_number":64,"context_line":"                \u0027method\u0027: \u0027GET\u0027,"},{"line_number":65,"context_line":"                \u0027path\u0027: \u0027/types/defaults\u0027,"},{"line_number":66,"context_line":"            }"},{"line_number":67,"context_line":"        ]),"},{"line_number":68,"context_line":"    policy.DocumentedRuleDefault("}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_a8587687","line":65,"range":{"start_line":65,"start_character":32,"end_line":65,"end_character":40},"updated":"2017-12-10 22:08:23.000000000","message":"default","commit_id":"7a49a34b6194c3554261f856ed5a2fb0a03011c8"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"3a053bb7004f83f632883bb4cfb7d372ddfa35cd","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        operations\u003d["},{"line_number":63,"context_line":"            {"},{"line_number":64,"context_line":"                \u0027method\u0027: \u0027GET\u0027,"},{"line_number":65,"context_line":"                \u0027path\u0027: \u0027/types/defaults\u0027,"},{"line_number":66,"context_line":"            }"},{"line_number":67,"context_line":"        ]),"},{"line_number":68,"context_line":"    policy.DocumentedRuleDefault("}],"source_content_type":"text/x-python","patch_set":9,"id":"df87a7cf_4bf68465","line":65,"range":{"start_line":65,"start_character":32,"end_line":65,"end_character":40},"in_reply_to":"df87a7cf_a8587687","updated":"2017-12-11 01:10:33.000000000","message":"Done","commit_id":"7a49a34b6194c3554261f856ed5a2fb0a03011c8"}],"manila/policy.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"3885ed780648501c2a87dc289d3542f51822b156","unresolved":false,"context_lines":[{"line_number":209,"context_line":"    }"},{"line_number":210,"context_line":"    target.update(target_obj or {})"},{"line_number":211,"context_line":"    _action \u003d \u0027%s:%s\u0027 % (resource, action)"},{"line_number":212,"context_line":"    # The else branch will be deleted after all policy in code patches"},{"line_number":213,"context_line":"    # be merged."},{"line_number":214,"context_line":"    if resource in (\u0027share_instance_export_location\u0027, \u0027share_type\u0027, ):"},{"line_number":215,"context_line":"        authorize(context, _action, target)"},{"line_number":216,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_48f749f7","line":213,"range":{"start_line":212,"start_character":4,"end_line":213,"end_character":16},"updated":"2017-10-10 15:07:29.000000000","message":"Just for my knowledge, how come we have two different policy enforcement paths for file-based policies and in-code policies? Shouldn\u0027t enforcement accept policy rules regardless of them coming from code or a file?\n\nIdeally, a policy file will only contain overrides (if applicable), so we could have deployments out there with some overrides. How would that work in this case, since we can\u0027t know or guarantee which policies are being overridden (and that can change per deployment).","commit_id":"a43254578430234790ca883c6919750d83b79300"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7ce9ef718ea624f29a0ef04f3273969dff010513","unresolved":false,"context_lines":[{"line_number":209,"context_line":"    }"},{"line_number":210,"context_line":"    target.update(target_obj or {})"},{"line_number":211,"context_line":"    _action \u003d \u0027%s:%s\u0027 % (resource, action)"},{"line_number":212,"context_line":"    # The else branch will be deleted after all policy in code patches"},{"line_number":213,"context_line":"    # be merged."},{"line_number":214,"context_line":"    if resource in (\u0027share_instance_export_location\u0027, \u0027share_type\u0027, ):"},{"line_number":215,"context_line":"        authorize(context, _action, target)"},{"line_number":216,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f4e5783_0a5a2929","line":213,"range":{"start_line":212,"start_character":4,"end_line":213,"end_character":16},"in_reply_to":"5f4e5783_48f749f7","updated":"2017-10-20 02:23:24.000000000","message":"The new authorize will check whether the policy has been registered in the code, if we write the policy in code, it will raise PolicyNotRegistered error, so it only can be removed until all of the policies as been upgraded.","commit_id":"a43254578430234790ca883c6919750d83b79300"}]}