)]}'
{"devstack/settings":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3686f80c875e08711b5a87cb001d6540170226de","unresolved":false,"context_lines":[{"line_number":192,"context_line":"# Data Service copy validation"},{"line_number":193,"context_line":"MANILA_DATA_COPY_CHECK_HASH\u003d${MANILA_DATA_COPY_CHECK_HASH:\u003dTrue}"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"MANILA_TEMPEST_PLUGIN_PATH\u003d$DEST/manila-tempest-plugin"},{"line_number":196,"context_line":"if [[ $TEMPEST_PLUGINS !\u003d 0 ]] ; then"},{"line_number":197,"context_line":"    TEMPEST_PLUGINS\u003d\"$MANILA_TEMPEST_PLUGIN_PATH $TEMPEST_PLUGINS\""},{"line_number":198,"context_line":"else"}],"source_content_type":"application/octet-stream","patch_set":19,"id":"df87a7cf_ff3d11dd","line":195,"range":{"start_line":195,"start_character":27,"end_line":195,"end_character":33},"updated":"2017-12-07 15:01:46.000000000","message":"thought all new installations occur within $DEST/new in the gate..","commit_id":"4c9cfb9b334f764069096d397d5c425cb7ca43a7"}],"playbooks/legacy/manila-tempest-dsvm-container-scenario-custom-image/run.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"513b0c0a63787f245a3e0f604436c30456be1d82","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"          # Keep localrc to be able to set some vars in pre_test_hook"},{"line_number":56,"context_line":"          export KEEP_LOCALRC\u003d1"},{"line_number":57,"context_line":"          export PROJECTS\u003d\"openstack/manila-tempest-plugin $PROJECTS\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"          function pre_test_hook {"},{"line_number":60,"context_line":"              # Build custom image if needed"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1f485f77_84ef20af","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":69},"updated":"2017-11-14 19:13:30.000000000","message":"I think this should be added to contrib/ci/pre_test_hook, which most third party CIs will be using.","commit_id":"80039dd5c6aa13729ab87a78c04cf83c45b1381d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"3a17cd8891976206d498457e3d63b69c18b4d360","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"          # Keep localrc to be able to set some vars in pre_test_hook"},{"line_number":56,"context_line":"          export KEEP_LOCALRC\u003d1"},{"line_number":57,"context_line":"          export PROJECTS\u003d\"openstack/manila-tempest-plugin $PROJECTS\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"          function pre_test_hook {"},{"line_number":60,"context_line":"              # Build custom image if needed"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1f485f77_127b4df5","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":69},"in_reply_to":"1f485f77_428fbc74","updated":"2017-11-15 18:30:35.000000000","message":"ouch. yeah, makes sense.. pre_test_hook is invoked as part of DevStack\u0027s own pre_test_hook... I guess we need to send out an email to all the driver maintainers..","commit_id":"80039dd5c6aa13729ab87a78c04cf83c45b1381d"},{"author":{"_account_id":21698,"name":"Raissa Sarmento","email":"raissaa@gmail.com","username":"raissa"},"change_message_id":"d34a861f7aa2a34c0c45574c0bd35d21d765db0a","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"          # Keep localrc to be able to set some vars in pre_test_hook"},{"line_number":56,"context_line":"          export KEEP_LOCALRC\u003d1"},{"line_number":57,"context_line":"          export PROJECTS\u003d\"openstack/manila-tempest-plugin $PROJECTS\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"          function pre_test_hook {"},{"line_number":60,"context_line":"              # Build custom image if needed"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1f485f77_428fbc74","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":69},"in_reply_to":"1f485f77_514443b7","updated":"2017-11-15 15:30:29.000000000","message":"Ok, so I tried changing that in patchset #12 and it didn\u0027t work. After investigating, I found out that it\u0027s because devstack-gate/devstack-vm-gate-wrap.sh gets the projects from the PROJECTS variable before running the pre_test_hook script. I\u0027m not sure if there\u0027s a less disruptive way apart from 3rd parties adjusting their CIs - I guess this can/should be discussed in our meeting tomorrow","commit_id":"80039dd5c6aa13729ab87a78c04cf83c45b1381d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bb7c1c1f836ea7b3558de17c13bc75010ae08e26","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"          # Keep localrc to be able to set some vars in pre_test_hook"},{"line_number":56,"context_line":"          export KEEP_LOCALRC\u003d1"},{"line_number":57,"context_line":"          export PROJECTS\u003d\"openstack/manila-tempest-plugin $PROJECTS\""},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"          function pre_test_hook {"},{"line_number":60,"context_line":"              # Build custom image if needed"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"1f485f77_514443b7","line":57,"range":{"start_line":57,"start_character":0,"end_line":57,"end_character":69},"in_reply_to":"1f485f77_84ef20af","updated":"2017-11-14 21:29:35.000000000","message":"In most third party CI\u0027s we source the in-tree CI hooks to act as helpers to build out the localrc/tempest configuration, so adding this variable in pre_test_hook will mitigate any changes to third party CIs. Ofcourse there will still be some who don\u0027t use this approach. Perhaps we should bring it up in the weekly meeting and post a note to the OpenStack-dev mailing list.","commit_id":"80039dd5c6aa13729ab87a78c04cf83c45b1381d"}],"playbooks/legacy/manila-tempest-minimal-py35-dsvm-cephfs-native-centos-7/run.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"5c1e175bd52466622e33e82b7d7074c0b4407c1e","unresolved":false,"context_lines":[{"line_number":39,"context_line":"          disable_service s-proxy"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"          enable_plugin manila git://git.openstack.org/openstack/manila"},{"line_number":42,"context_line":"          TEMPEST_PLUGINS\u003d\u0027/opt/stack/new/manila-tempest-plugin\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"          enable_plugin devstack-plugin-ceph git://git.openstack.org/openstack/devstack-plugin-ceph"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"3f4b6375_5cc96ca9","line":42,"range":{"start_line":42,"start_character":10,"end_line":42,"end_character":64},"updated":"2017-11-07 23:36:47.000000000","message":"This should be set in our DevStack plugin so that third party CIs do not have to change their current configuration. You can see that all of them are broken on this change..","commit_id":"3336707849ba5d2887eec9fdbaaa3cdb01c4b249"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"349b18d2f85c4ae28012ed0e318fc135d92a1b02","unresolved":false,"context_lines":[{"line_number":39,"context_line":"          disable_service s-proxy"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"          enable_plugin manila git://git.openstack.org/openstack/manila"},{"line_number":42,"context_line":"          TEMPEST_PLUGINS\u003d\u0027/opt/stack/new/manila-tempest-plugin\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"          enable_plugin devstack-plugin-ceph git://git.openstack.org/openstack/devstack-plugin-ceph"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1f485f77_87ae2b2c","line":42,"range":{"start_line":42,"start_character":10,"end_line":42,"end_character":64},"in_reply_to":"1f485f77_b2475ebd","updated":"2017-11-13 14:10:45.000000000","message":"Yes please, that was always the behavior. You can add this variable there so that people may override this option if necessary, or you may check for \u0027tempest\u0027 in ENABLED_SERVICES env variable...","commit_id":"3336707849ba5d2887eec9fdbaaa3cdb01c4b249"},{"author":{"_account_id":21698,"name":"Raissa Sarmento","email":"raissaa@gmail.com","username":"raissa"},"change_message_id":"bb2e0fd00ac0bf9c2277e9ecd0bba6208f82f0bc","unresolved":false,"context_lines":[{"line_number":39,"context_line":"          disable_service s-proxy"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"          enable_plugin manila git://git.openstack.org/openstack/manila"},{"line_number":42,"context_line":"          TEMPEST_PLUGINS\u003d\u0027/opt/stack/new/manila-tempest-plugin\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"          enable_plugin devstack-plugin-ceph git://git.openstack.org/openstack/devstack-plugin-ceph"},{"line_number":45,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1f485f77_b2475ebd","line":42,"range":{"start_line":42,"start_character":10,"end_line":42,"end_character":64},"in_reply_to":"3f4b6375_5cc96ca9","updated":"2017-11-09 11:47:07.000000000","message":"But then is it ok to install the manila tempest plugin by default with devstack?","commit_id":"3336707849ba5d2887eec9fdbaaa3cdb01c4b249"}]}