)]}'
{"manila_tempest_tests/tests/api/base.py":[{"author":{"_account_id":26535,"name":"Nir Gilboa","email":"gilboa.nir@gmail.com","username":"nirgilbo"},"change_message_id":"97cae019e6ee8af687272a15571ca96284841398","unresolved":false,"context_lines":[{"line_number":436,"context_line":"                LOG.info(\u0027NO SHARE TYPE AND CONF ON\u0027)"},{"line_number":437,"context_line":"                LOG.info(\u0027CONF\u003d\u0027 + CONF.share.default_share_type_name)"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":"                # Call type-list and search"},{"line_number":440,"context_line":"                list_output \u003d client.list_share_types()[\u0027volume_types\u0027]"},{"line_number":441,"context_line":"                found_id \u003d False"},{"line_number":442,"context_line":"                for current_type in list_output:"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_87d92458","line":439,"updated":"2017-10-24 20:58:51.000000000","message":"Suggestion for improved readability of searching code:\n\nshare_types_list \u003d client.list_share_types()[\u0027volume_types\u0027]\nshare_types_dict \u003d {share_type[\u0027name\u0027]: share_type[\u0027id\u0027] for share_type in share_types_list}\nif CONF.share.default_share_type_name in share_types_dict:\n    found_type_id \u003d share_types_dict[CONF.share.default_share_type_name]\n    LOG.info(\u0027FOUND TYPE {name} [{id}]\u0027.format(name\u003dCONF.share.default_share_type_name,\n                                               id\u003dfound_type_id))","commit_id":"88f8ab3992bcb7385a373a8b02b7959ef26b0cd9"},{"author":{"_account_id":26535,"name":"Nir Gilboa","email":"gilboa.nir@gmail.com","username":"nirgilbo"},"change_message_id":"97cae019e6ee8af687272a15571ca96284841398","unresolved":false,"context_lines":[{"line_number":957,"context_line":"                        client.delete_security_service(res_id)"},{"line_number":958,"context_line":"                        client.wait_for_resource_deletion(ss_id\u003dres_id)"},{"line_number":959,"context_line":"                    elif res[\"type\"] is \"share_type\":"},{"line_number":960,"context_line":"                        LOG.info(\u0027DELETE TYPE \u0027 + str(res_id))"},{"line_number":961,"context_line":"                        admin_client \u003d cls.get_client_with_isolated_creds()"},{"line_number":962,"context_line":"                        admin_client.delete_share_type(res_id)"},{"line_number":963,"context_line":"                        admin_client.wait_for_resource_deletion(st_id\u003dres_id)"}],"source_content_type":"text/x-python","patch_set":8,"id":"3f4b6375_4c6fd3fb","line":960,"updated":"2017-10-24 20:58:51.000000000","message":"Suggest to use string formatting, for example:\nLOG.info(\u0027DELETE TYPE {res_id}\u0027.format(res_id\u003dres_id))\n\n1. Easier to read/modify in the future\n2. No need to perform str() on variables to ensure you\u0027ve forgotten a type conversion.","commit_id":"88f8ab3992bcb7385a373a8b02b7959ef26b0cd9"}]}
