)]}'
{"manila/policies/shares.py":[{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"bb638da0e5b5ee1cfd37629bd6934ee364e8a7d5","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        ]),"},{"line_number":32,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":33,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027get\u0027,"},{"line_number":34,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":35,"context_line":"        description\u003d\"Get share.\","},{"line_number":36,"context_line":"        operations\u003d["},{"line_number":37,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_09dbc67b","line":34,"range":{"start_line":34,"start_character":23,"end_line":34,"end_character":42},"updated":"2017-11-27 17:02:16.000000000","message":"This appears to be inconsistent with the old value in policy.json.","commit_id":"2299b46f3b9da1d177d442b664a93c83bcab4547"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"40ddcc987f088a535fa141648b73cd89fe365f3b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"        ]),"},{"line_number":32,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":33,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027get\u0027,"},{"line_number":34,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":35,"context_line":"        description\u003d\"Get share.\","},{"line_number":36,"context_line":"        operations\u003d["},{"line_number":37,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_d9f04294","line":34,"range":{"start_line":34,"start_character":23,"end_line":34,"end_character":42},"in_reply_to":"ff82abbf_09dbc67b","updated":"2017-11-28 03:37:48.000000000","message":"Done","commit_id":"2299b46f3b9da1d177d442b664a93c83bcab4547"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"bb638da0e5b5ee1cfd37629bd6934ee364e8a7d5","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        ]),"},{"line_number":42,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":43,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027get_all\u0027,"},{"line_number":44,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":45,"context_line":"        description\u003d\"Show shares.\","},{"line_number":46,"context_line":"        operations\u003d["},{"line_number":47,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_c9e07e29","line":44,"range":{"start_line":44,"start_character":23,"end_line":44,"end_character":42},"updated":"2017-11-27 17:02:16.000000000","message":"Same comment here.","commit_id":"2299b46f3b9da1d177d442b664a93c83bcab4547"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"40ddcc987f088a535fa141648b73cd89fe365f3b","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        ]),"},{"line_number":42,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":43,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027get_all\u0027,"},{"line_number":44,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":45,"context_line":"        description\u003d\"Show shares.\","},{"line_number":46,"context_line":"        operations\u003d["},{"line_number":47,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_b97f7ede","line":44,"range":{"start_line":44,"start_character":23,"end_line":44,"end_character":42},"in_reply_to":"ff82abbf_c9e07e29","updated":"2017-11-28 03:37:48.000000000","message":"Done","commit_id":"2299b46f3b9da1d177d442b664a93c83bcab4547"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"bb638da0e5b5ee1cfd37629bd6934ee364e8a7d5","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        ]),"},{"line_number":56,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":57,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027update\u0027,"},{"line_number":58,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":59,"context_line":"        description\u003d\"Update share.\","},{"line_number":60,"context_line":"        operations\u003d["},{"line_number":61,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_e9c6a29a","line":58,"range":{"start_line":58,"start_character":23,"end_line":58,"end_character":42},"updated":"2017-11-27 17:02:16.000000000","message":"This should be:\n\n  check_str\u003d\u0027rule:default\u0027\n\nright?","commit_id":"2299b46f3b9da1d177d442b664a93c83bcab4547"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"40ddcc987f088a535fa141648b73cd89fe365f3b","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        ]),"},{"line_number":56,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":57,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027update\u0027,"},{"line_number":58,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":59,"context_line":"        description\u003d\"Update share.\","},{"line_number":60,"context_line":"        operations\u003d["},{"line_number":61,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_997abaee","line":58,"range":{"start_line":58,"start_character":23,"end_line":58,"end_character":42},"in_reply_to":"ff82abbf_e9c6a29a","updated":"2017-11-28 03:37:48.000000000","message":"Done","commit_id":"2299b46f3b9da1d177d442b664a93c83bcab4547"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"bb638da0e5b5ee1cfd37629bd6934ee364e8a7d5","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        ]),"},{"line_number":66,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":67,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027delete\u0027,"},{"line_number":68,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":69,"context_line":"        description\u003d\"Delete share.\","},{"line_number":70,"context_line":"        operations\u003d["},{"line_number":71,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_293eca8a","line":68,"range":{"start_line":68,"start_character":23,"end_line":68,"end_character":42},"updated":"2017-11-27 17:02:16.000000000","message":"This should be `rule:default`, right?","commit_id":"2299b46f3b9da1d177d442b664a93c83bcab4547"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"40ddcc987f088a535fa141648b73cd89fe365f3b","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        ]),"},{"line_number":66,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":67,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027delete\u0027,"},{"line_number":68,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":69,"context_line":"        description\u003d\"Delete share.\","},{"line_number":70,"context_line":"        operations\u003d["},{"line_number":71,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_992cfa02","line":68,"range":{"start_line":68,"start_character":23,"end_line":68,"end_character":42},"in_reply_to":"ff82abbf_293eca8a","updated":"2017-11-28 03:37:48.000000000","message":"Done","commit_id":"2299b46f3b9da1d177d442b664a93c83bcab4547"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"bb638da0e5b5ee1cfd37629bd6934ee364e8a7d5","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        ]),"},{"line_number":106,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":107,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027create_snapshot\u0027,"},{"line_number":108,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":109,"context_line":"        description\u003d\"Create share snapshot.\","},{"line_number":110,"context_line":"        operations\u003d["},{"line_number":111,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_8966f6c0","line":108,"range":{"start_line":108,"start_character":23,"end_line":108,"end_character":42},"updated":"2017-11-27 17:02:16.000000000","message":"This should be `rule:default`, right?","commit_id":"2299b46f3b9da1d177d442b664a93c83bcab4547"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"40ddcc987f088a535fa141648b73cd89fe365f3b","unresolved":false,"context_lines":[{"line_number":105,"context_line":"        ]),"},{"line_number":106,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":107,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027create_snapshot\u0027,"},{"line_number":108,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":109,"context_line":"        description\u003d\"Create share snapshot.\","},{"line_number":110,"context_line":"        operations\u003d["},{"line_number":111,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_f9ed06b7","line":108,"range":{"start_line":108,"start_character":23,"end_line":108,"end_character":42},"in_reply_to":"ff82abbf_8966f6c0","updated":"2017-11-28 03:37:48.000000000","message":"Done","commit_id":"2299b46f3b9da1d177d442b664a93c83bcab4547"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"bb638da0e5b5ee1cfd37629bd6934ee364e8a7d5","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        ]),"},{"line_number":144,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":145,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027access_get\u0027,"},{"line_number":146,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":147,"context_line":"        description\u003d\"Get share access rule, it under deny access operation.\","},{"line_number":148,"context_line":"        operations\u003d["},{"line_number":149,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_890b56d4","line":146,"range":{"start_line":146,"start_character":23,"end_line":146,"end_character":42},"updated":"2017-11-27 17:02:16.000000000","message":"This should be `rule:default`?","commit_id":"2299b46f3b9da1d177d442b664a93c83bcab4547"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"40ddcc987f088a535fa141648b73cd89fe365f3b","unresolved":false,"context_lines":[{"line_number":143,"context_line":"        ]),"},{"line_number":144,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":145,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027access_get\u0027,"},{"line_number":146,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":147,"context_line":"        description\u003d\"Get share access rule, it under deny access operation.\","},{"line_number":148,"context_line":"        operations\u003d["},{"line_number":149,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_f91bc6c6","line":146,"range":{"start_line":146,"start_character":23,"end_line":146,"end_character":42},"in_reply_to":"ff82abbf_890b56d4","updated":"2017-11-28 03:37:48.000000000","message":"Done","commit_id":"2299b46f3b9da1d177d442b664a93c83bcab4547"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"bb638da0e5b5ee1cfd37629bd6934ee364e8a7d5","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        ]),"},{"line_number":154,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":155,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027access_get_all\u0027,"},{"line_number":156,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":157,"context_line":"        description\u003d\"List share access rules.\","},{"line_number":158,"context_line":"        operations\u003d["},{"line_number":159,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_29256a5c","line":156,"range":{"start_line":156,"start_character":23,"end_line":156,"end_character":42},"updated":"2017-11-27 17:02:16.000000000","message":"This should be `rule:default`?","commit_id":"2299b46f3b9da1d177d442b664a93c83bcab4547"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"40ddcc987f088a535fa141648b73cd89fe365f3b","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        ]),"},{"line_number":154,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":155,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027access_get_all\u0027,"},{"line_number":156,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":157,"context_line":"        description\u003d\"List share access rules.\","},{"line_number":158,"context_line":"        operations\u003d["},{"line_number":159,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_d91e02ba","line":156,"range":{"start_line":156,"start_character":23,"end_line":156,"end_character":42},"in_reply_to":"ff82abbf_29256a5c","updated":"2017-11-28 03:37:48.000000000","message":"Done","commit_id":"2299b46f3b9da1d177d442b664a93c83bcab4547"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"bb638da0e5b5ee1cfd37629bd6934ee364e8a7d5","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        ]),"},{"line_number":164,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":165,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027extend\u0027,"},{"line_number":166,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":167,"context_line":"        description\u003d\"Extend share.\","},{"line_number":168,"context_line":"        operations\u003d["},{"line_number":169,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_c915dee6","line":166,"range":{"start_line":166,"start_character":23,"end_line":166,"end_character":42},"updated":"2017-11-27 17:02:16.000000000","message":"This should be `rule:default`?","commit_id":"2299b46f3b9da1d177d442b664a93c83bcab4547"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"40ddcc987f088a535fa141648b73cd89fe365f3b","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        ]),"},{"line_number":164,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":165,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027extend\u0027,"},{"line_number":166,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":167,"context_line":"        description\u003d\"Extend share.\","},{"line_number":168,"context_line":"        operations\u003d["},{"line_number":169,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_39260e17","line":166,"range":{"start_line":166,"start_character":23,"end_line":166,"end_character":42},"in_reply_to":"ff82abbf_c915dee6","updated":"2017-11-28 03:37:48.000000000","message":"Done","commit_id":"2299b46f3b9da1d177d442b664a93c83bcab4547"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"bb638da0e5b5ee1cfd37629bd6934ee364e8a7d5","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        ]),"},{"line_number":174,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":175,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027shrink\u0027,"},{"line_number":176,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":177,"context_line":"        description\u003d\"Shrink share.\","},{"line_number":178,"context_line":"        operations\u003d["},{"line_number":179,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_c9eabed6","line":176,"range":{"start_line":176,"start_character":23,"end_line":176,"end_character":42},"updated":"2017-11-27 17:02:16.000000000","message":"This should be `rule:default`?","commit_id":"2299b46f3b9da1d177d442b664a93c83bcab4547"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"40ddcc987f088a535fa141648b73cd89fe365f3b","unresolved":false,"context_lines":[{"line_number":173,"context_line":"        ]),"},{"line_number":174,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":175,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027shrink\u0027,"},{"line_number":176,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":177,"context_line":"        description\u003d\"Shrink share.\","},{"line_number":178,"context_line":"        operations\u003d["},{"line_number":179,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_590bd27b","line":176,"range":{"start_line":176,"start_character":23,"end_line":176,"end_character":42},"in_reply_to":"ff82abbf_c9eabed6","updated":"2017-11-28 03:37:48.000000000","message":"Done","commit_id":"2299b46f3b9da1d177d442b664a93c83bcab4547"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"bb638da0e5b5ee1cfd37629bd6934ee364e8a7d5","unresolved":false,"context_lines":[{"line_number":244,"context_line":"        ]),"},{"line_number":245,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":246,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027revert_to_snapshot\u0027,"},{"line_number":247,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":248,"context_line":"        description\u003d(\"Revert a share to a snapshot.\"),"},{"line_number":249,"context_line":"        operations\u003d["},{"line_number":250,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_49ad4e99","line":247,"range":{"start_line":247,"start_character":23,"end_line":247,"end_character":42},"updated":"2017-11-27 17:02:16.000000000","message":"This should be `rule:default`?","commit_id":"2299b46f3b9da1d177d442b664a93c83bcab4547"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"40ddcc987f088a535fa141648b73cd89fe365f3b","unresolved":false,"context_lines":[{"line_number":244,"context_line":"        ]),"},{"line_number":245,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":246,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027revert_to_snapshot\u0027,"},{"line_number":247,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":248,"context_line":"        description\u003d(\"Revert a share to a snapshot.\"),"},{"line_number":249,"context_line":"        operations\u003d["},{"line_number":250,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_b91a1ec9","line":247,"range":{"start_line":247,"start_character":23,"end_line":247,"end_character":42},"in_reply_to":"ff82abbf_49ad4e99","updated":"2017-11-28 03:37:48.000000000","message":"Done","commit_id":"2299b46f3b9da1d177d442b664a93c83bcab4547"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"bb638da0e5b5ee1cfd37629bd6934ee364e8a7d5","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        ]),"},{"line_number":255,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":256,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027allow_access\u0027,"},{"line_number":257,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":258,"context_line":"        description\u003d(\"Add share access rule.\"),"},{"line_number":259,"context_line":"        operations\u003d["},{"line_number":260,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_a99bba70","line":257,"range":{"start_line":257,"start_character":23,"end_line":257,"end_character":42},"updated":"2017-11-27 17:02:16.000000000","message":"This should be `rule:default`?","commit_id":"2299b46f3b9da1d177d442b664a93c83bcab4547"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"40ddcc987f088a535fa141648b73cd89fe365f3b","unresolved":false,"context_lines":[{"line_number":254,"context_line":"        ]),"},{"line_number":255,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":256,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027allow_access\u0027,"},{"line_number":257,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":258,"context_line":"        description\u003d(\"Add share access rule.\"),"},{"line_number":259,"context_line":"        operations\u003d["},{"line_number":260,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_9915da9e","line":257,"range":{"start_line":257,"start_character":23,"end_line":257,"end_character":42},"in_reply_to":"ff82abbf_a99bba70","updated":"2017-11-28 03:37:48.000000000","message":"Done","commit_id":"2299b46f3b9da1d177d442b664a93c83bcab4547"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"bb638da0e5b5ee1cfd37629bd6934ee364e8a7d5","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        ]),"},{"line_number":265,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":266,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027deny_access\u0027,"},{"line_number":267,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":268,"context_line":"        description\u003d(\"Remove share access rule.\"),"},{"line_number":269,"context_line":"        operations\u003d["},{"line_number":270,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_698b721e","line":267,"range":{"start_line":267,"start_character":23,"end_line":267,"end_character":42},"updated":"2017-11-27 17:02:16.000000000","message":"This should be `rule:default`?","commit_id":"2299b46f3b9da1d177d442b664a93c83bcab4547"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"40ddcc987f088a535fa141648b73cd89fe365f3b","unresolved":false,"context_lines":[{"line_number":264,"context_line":"        ]),"},{"line_number":265,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":266,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027deny_access\u0027,"},{"line_number":267,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":268,"context_line":"        description\u003d(\"Remove share access rule.\"),"},{"line_number":269,"context_line":"        operations\u003d["},{"line_number":270,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_f942e6aa","line":267,"range":{"start_line":267,"start_character":23,"end_line":267,"end_character":42},"in_reply_to":"ff82abbf_698b721e","updated":"2017-11-28 03:37:48.000000000","message":"Done","commit_id":"2299b46f3b9da1d177d442b664a93c83bcab4547"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"bb638da0e5b5ee1cfd37629bd6934ee364e8a7d5","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        ]),"},{"line_number":275,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":276,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027delete_snapshot\u0027,"},{"line_number":277,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":278,"context_line":"        description\u003d(\"Delete share snapshot.\"),"},{"line_number":279,"context_line":"        operations\u003d["},{"line_number":280,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_e97ea217","line":277,"range":{"start_line":277,"start_character":23,"end_line":277,"end_character":42},"updated":"2017-11-27 17:02:16.000000000","message":"This should be `rule:default`?","commit_id":"2299b46f3b9da1d177d442b664a93c83bcab4547"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"40ddcc987f088a535fa141648b73cd89fe365f3b","unresolved":false,"context_lines":[{"line_number":274,"context_line":"        ]),"},{"line_number":275,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":276,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027delete_snapshot\u0027,"},{"line_number":277,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":278,"context_line":"        description\u003d(\"Delete share snapshot.\"),"},{"line_number":279,"context_line":"        operations\u003d["},{"line_number":280,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_d945a2b5","line":277,"range":{"start_line":277,"start_character":23,"end_line":277,"end_character":42},"in_reply_to":"ff82abbf_e97ea217","updated":"2017-11-28 03:37:48.000000000","message":"Done","commit_id":"2299b46f3b9da1d177d442b664a93c83bcab4547"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"bb638da0e5b5ee1cfd37629bd6934ee364e8a7d5","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        ]),"},{"line_number":285,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":286,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027snapshot_update\u0027,"},{"line_number":287,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":288,"context_line":"        description\u003d(\"Update share snapshot.\"),"},{"line_number":289,"context_line":"        operations\u003d["},{"line_number":290,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_a9741a37","line":287,"range":{"start_line":287,"start_character":23,"end_line":287,"end_character":42},"updated":"2017-11-27 17:02:16.000000000","message":"This should be `rule:default`?","commit_id":"2299b46f3b9da1d177d442b664a93c83bcab4547"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"40ddcc987f088a535fa141648b73cd89fe365f3b","unresolved":false,"context_lines":[{"line_number":284,"context_line":"        ]),"},{"line_number":285,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":286,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027snapshot_update\u0027,"},{"line_number":287,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":288,"context_line":"        description\u003d(\"Update share snapshot.\"),"},{"line_number":289,"context_line":"        operations\u003d["},{"line_number":290,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_393dae2a","line":287,"range":{"start_line":287,"start_character":23,"end_line":287,"end_character":42},"in_reply_to":"ff82abbf_a9741a37","updated":"2017-11-28 03:37:48.000000000","message":"Done","commit_id":"2299b46f3b9da1d177d442b664a93c83bcab4547"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"bb638da0e5b5ee1cfd37629bd6934ee364e8a7d5","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        ]),"},{"line_number":295,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":296,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027update_share_metadata\u0027,"},{"line_number":297,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":298,"context_line":"        description\u003d(\"Update share metadata.\"),"},{"line_number":299,"context_line":"        operations\u003d["},{"line_number":300,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_69905244","line":297,"range":{"start_line":297,"start_character":23,"end_line":297,"end_character":42},"updated":"2017-11-27 17:02:16.000000000","message":"This should be `rule:default`?","commit_id":"2299b46f3b9da1d177d442b664a93c83bcab4547"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"40ddcc987f088a535fa141648b73cd89fe365f3b","unresolved":false,"context_lines":[{"line_number":294,"context_line":"        ]),"},{"line_number":295,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":296,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027update_share_metadata\u0027,"},{"line_number":297,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":298,"context_line":"        description\u003d(\"Update share metadata.\"),"},{"line_number":299,"context_line":"        operations\u003d["},{"line_number":300,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_7937b64e","line":297,"range":{"start_line":297,"start_character":23,"end_line":297,"end_character":42},"in_reply_to":"ff82abbf_69905244","updated":"2017-11-28 03:37:48.000000000","message":"Done","commit_id":"2299b46f3b9da1d177d442b664a93c83bcab4547"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"bb638da0e5b5ee1cfd37629bd6934ee364e8a7d5","unresolved":false,"context_lines":[{"line_number":304,"context_line":"        ]),"},{"line_number":305,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":306,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027delete_share_metadata\u0027,"},{"line_number":307,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":308,"context_line":"        description\u003d(\"Delete share metadata.\"),"},{"line_number":309,"context_line":"        operations\u003d["},{"line_number":310,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_89959635","line":307,"range":{"start_line":307,"start_character":23,"end_line":307,"end_character":42},"updated":"2017-11-27 17:02:16.000000000","message":"This should be `rule:default`?","commit_id":"2299b46f3b9da1d177d442b664a93c83bcab4547"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"40ddcc987f088a535fa141648b73cd89fe365f3b","unresolved":false,"context_lines":[{"line_number":304,"context_line":"        ]),"},{"line_number":305,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":306,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027delete_share_metadata\u0027,"},{"line_number":307,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":308,"context_line":"        description\u003d(\"Delete share metadata.\"),"},{"line_number":309,"context_line":"        operations\u003d["},{"line_number":310,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_5932f25f","line":307,"range":{"start_line":307,"start_character":23,"end_line":307,"end_character":42},"in_reply_to":"ff82abbf_89959635","updated":"2017-11-28 03:37:48.000000000","message":"Done","commit_id":"2299b46f3b9da1d177d442b664a93c83bcab4547"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"bb638da0e5b5ee1cfd37629bd6934ee364e8a7d5","unresolved":false,"context_lines":[{"line_number":314,"context_line":"        ]),"},{"line_number":315,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":316,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027get_share_metadata\u0027,"},{"line_number":317,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":318,"context_line":"        description\u003d(\"Get share metadata.\"),"},{"line_number":319,"context_line":"        operations\u003d["},{"line_number":320,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_2996ca3f","line":317,"range":{"start_line":317,"start_character":23,"end_line":317,"end_character":42},"updated":"2017-11-27 17:02:16.000000000","message":"This should be `rule:default`?","commit_id":"2299b46f3b9da1d177d442b664a93c83bcab4547"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"40ddcc987f088a535fa141648b73cd89fe365f3b","unresolved":false,"context_lines":[{"line_number":314,"context_line":"        ]),"},{"line_number":315,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":316,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027get_share_metadata\u0027,"},{"line_number":317,"context_line":"        check_str\u003dbase.RULE_ADMIN_OR_OWNER,"},{"line_number":318,"context_line":"        description\u003d(\"Get share metadata.\"),"},{"line_number":319,"context_line":"        operations\u003d["},{"line_number":320,"context_line":"            {"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff82abbf_b931be5c","line":317,"range":{"start_line":317,"start_character":23,"end_line":317,"end_character":42},"in_reply_to":"ff82abbf_2996ca3f","updated":"2017-11-28 03:37:48.000000000","message":"Done","commit_id":"2299b46f3b9da1d177d442b664a93c83bcab4547"}],"manila/policy.py":[{"author":{"_account_id":23630,"name":"Tovin Seven","email":"tovin07@gmail.com","username":"tovin07"},"change_message_id":"b8ca503bb8767756a8668bc0c9a1501baa1b74d2","unresolved":false,"context_lines":[{"line_number":208,"context_line":"    _action \u003d \u0027%s:%s\u0027 % (resource, action)"},{"line_number":209,"context_line":"    # The else branch will be deleted after all policy in code patches"},{"line_number":210,"context_line":"    # be merged."},{"line_number":211,"context_line":"    if resource in (\u0027share_instance_export_location\u0027, \u0027share_type\u0027,"},{"line_number":212,"context_line":"                    \u0027share\u0027, ):"},{"line_number":213,"context_line":"        authorize(context, _action, target)"},{"line_number":214,"context_line":"    else:"},{"line_number":215,"context_line":"        enforce(context, _action, target)"}],"source_content_type":"text/x-python","patch_set":8,"id":"df87a7cf_d7331613","line":212,"range":{"start_line":211,"start_character":0,"end_line":212,"end_character":31},"updated":"2017-12-11 08:15:27.000000000","message":"just put it in oneline","commit_id":"6184063a4ca2f908a9186f292b3f2c59e9e59e0d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"1de1260a2fe32426ede0515e8b86cda74c8f9929","unresolved":false,"context_lines":[{"line_number":208,"context_line":"    _action \u003d \u0027%s:%s\u0027 % (resource, action)"},{"line_number":209,"context_line":"    # The else branch will be deleted after all policy in code patches"},{"line_number":210,"context_line":"    # be merged."},{"line_number":211,"context_line":"    if resource in (\u0027share_instance_export_location\u0027, \u0027share_type\u0027,"},{"line_number":212,"context_line":"                    \u0027share\u0027, ):"},{"line_number":213,"context_line":"        authorize(context, _action, target)"},{"line_number":214,"context_line":"    else:"},{"line_number":215,"context_line":"        enforce(context, _action, target)"}],"source_content_type":"text/x-python","patch_set":8,"id":"df87a7cf_ba58b730","line":212,"range":{"start_line":211,"start_character":0,"end_line":212,"end_character":31},"in_reply_to":"df87a7cf_1a3443dd","updated":"2017-12-11 08:26:17.000000000","message":"79 characters","commit_id":"6184063a4ca2f908a9186f292b3f2c59e9e59e0d"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"4e118fa4962cbc6ff7d107b894ad03abd7e56c6e","unresolved":false,"context_lines":[{"line_number":208,"context_line":"    _action \u003d \u0027%s:%s\u0027 % (resource, action)"},{"line_number":209,"context_line":"    # The else branch will be deleted after all policy in code patches"},{"line_number":210,"context_line":"    # be merged."},{"line_number":211,"context_line":"    if resource in (\u0027share_instance_export_location\u0027, \u0027share_type\u0027,"},{"line_number":212,"context_line":"                    \u0027share\u0027, ):"},{"line_number":213,"context_line":"        authorize(context, _action, target)"},{"line_number":214,"context_line":"    else:"},{"line_number":215,"context_line":"        enforce(context, _action, target)"}],"source_content_type":"text/x-python","patch_set":8,"id":"df87a7cf_cbc7c295","line":212,"range":{"start_line":211,"start_character":0,"end_line":212,"end_character":31},"in_reply_to":"df87a7cf_1a3443dd","updated":"2017-12-12 17:19:28.000000000","message":"I count 75 characters but this is not an issue to hold up the merge over.  Tovin: you\u0027re welcome to submit a followup patch :-)","commit_id":"6184063a4ca2f908a9186f292b3f2c59e9e59e0d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"67ea031ebfef46022d1f113bc338dfd4c23388e6","unresolved":false,"context_lines":[{"line_number":208,"context_line":"    _action \u003d \u0027%s:%s\u0027 % (resource, action)"},{"line_number":209,"context_line":"    # The else branch will be deleted after all policy in code patches"},{"line_number":210,"context_line":"    # be merged."},{"line_number":211,"context_line":"    if resource in (\u0027share_instance_export_location\u0027, \u0027share_type\u0027,"},{"line_number":212,"context_line":"                    \u0027share\u0027, ):"},{"line_number":213,"context_line":"        authorize(context, _action, target)"},{"line_number":214,"context_line":"    else:"},{"line_number":215,"context_line":"        enforce(context, _action, target)"}],"source_content_type":"text/x-python","patch_set":8,"id":"df87a7cf_e28f5b72","line":212,"range":{"start_line":211,"start_character":0,"end_line":212,"end_character":31},"in_reply_to":"df87a7cf_ba58b730","updated":"2017-12-12 02:57:12.000000000","message":"By one line you mean one line per resource?","commit_id":"6184063a4ca2f908a9186f292b3f2c59e9e59e0d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"418880ba239a97e9f26f2771fb94536802cf9ec9","unresolved":false,"context_lines":[{"line_number":208,"context_line":"    _action \u003d \u0027%s:%s\u0027 % (resource, action)"},{"line_number":209,"context_line":"    # The else branch will be deleted after all policy in code patches"},{"line_number":210,"context_line":"    # be merged."},{"line_number":211,"context_line":"    if resource in (\u0027share_instance_export_location\u0027, \u0027share_type\u0027,"},{"line_number":212,"context_line":"                    \u0027share\u0027, ):"},{"line_number":213,"context_line":"        authorize(context, _action, target)"},{"line_number":214,"context_line":"    else:"},{"line_number":215,"context_line":"        enforce(context, _action, target)"}],"source_content_type":"text/x-python","patch_set":8,"id":"df87a7cf_1a3443dd","line":212,"range":{"start_line":211,"start_character":0,"end_line":212,"end_character":31},"in_reply_to":"df87a7cf_d7331613","updated":"2017-12-11 08:24:48.000000000","message":"If I put it in one line, there are more than 79 in one line.","commit_id":"6184063a4ca2f908a9186f292b3f2c59e9e59e0d"}]}