)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"310bb89eae92e4c764e214687b3d8baef822299b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Instead of always using the first IP from the INFINIDAT InfiniBox"},{"line_number":10,"context_line":"network space, randomly choose one of the IPs for better"},{"line_number":11,"context_line":"load-balancing."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I2319d574cb95f8cc688e608a7e455743e4e63f93"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5f93b717_266838b7","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":0},"updated":"2018-01-31 07:31:01.000000000","message":"Could you add a tag for this patch\nhttps://github.com/openstack/manila/blob/master/doc/source/contributor/commit_message_tags.rst","commit_id":"fb4908da801718f24e1d08e3a7e056accd30a2aa"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"d43e7bdbd1adadd1c5e26cdc23c0411f6d045244","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Instead of always using the first IP from the INFINIDAT InfiniBox"},{"line_number":10,"context_line":"network space, utilize the export_locations attribute of the share"},{"line_number":11,"context_line":"and return the IPs of all enabled network space IPs."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I2319d574cb95f8cc688e608a7e455743e4e63f93"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f93b717_4f4f426a","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":0},"updated":"2018-02-03 02:38:09.000000000","message":"It looks like a big change for user. Cloud you open a bug and add a release notes for this patch? Thanks.\nsuch as: https://review.openstack.org/#/c/525527/6/releasenotes/notes/bug-1736370-qnap-fix-access-rule-override-1b79b70ae48ad9e6.yaml","commit_id":"2a29409a540d90f8fa0cfa0e1fd8dd6679ad1d2b"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"17f66b48dfdf720d12420e09fc7bc1e188771e7a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Instead of always using the first IP from the INFINIDAT InfiniBox"},{"line_number":10,"context_line":"network space, utilize the export_locations attribute of the share"},{"line_number":11,"context_line":"and return the IPs of all enabled network space IPs."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Change-Id: I2319d574cb95f8cc688e608a7e455743e4e63f93"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"3fa0c359_57ab44d5","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":0},"in_reply_to":"5f93b717_4f4f426a","updated":"2018-02-05 14:19:37.000000000","message":"Added the required release note. \nHowever, this is not a bug, but a new supported feature; the driver works fine when selecting only one IP, despite having no fallback. Therefore, I prefer not to open a bug report in this case.","commit_id":"2a29409a540d90f8fa0cfa0e1fd8dd6679ad1d2b"}],"manila/share/drivers/infinidat/infinibox.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"310bb89eae92e4c764e214687b3d8baef822299b","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        return random.choice(self._get_infinidat_nas_network_space_ips())"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    def _get_full_nfs_export_path(self, export_path):"},{"line_number":239,"context_line":"        network_space_ip \u003d self._get_random_infinidat_nas_network_space_ip()"},{"line_number":240,"context_line":"        return \u0027{network_space_ip}:{export_path}\u0027.format("},{"line_number":241,"context_line":"            network_space_ip\u003dnetwork_space_ip,"},{"line_number":242,"context_line":"            export_path\u003dexport_path)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    @infinisdk_to_manila_exceptions"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f93b717_06141c43","line":241,"range":{"start_line":239,"start_character":8,"end_line":241,"end_character":46},"updated":"2018-01-31 07:31:01.000000000","message":"Just a question: It looks like all IPs (belong to the \nspecial \"network_space\")  are available for  nfs export \npath, such as: The following of the full nfs export path \nare all available.\n{network_space_ip_1}:{export_path}\n{network_space_ip_2}:{export_path}\n{network_space_ip_N}:{export_path} \n....\n \nWe already support one share has multiple export locations.\n so why you don\u0027t just add all IPs to export_path, and not \njust return one of them.","commit_id":"fb4908da801718f24e1d08e3a7e056accd30a2aa"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"d4e673a83a9ab20d66f2e922ddb3b31de4b14690","unresolved":false,"context_lines":[{"line_number":236,"context_line":"        return random.choice(self._get_infinidat_nas_network_space_ips())"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    def _get_full_nfs_export_path(self, export_path):"},{"line_number":239,"context_line":"        network_space_ip \u003d self._get_random_infinidat_nas_network_space_ip()"},{"line_number":240,"context_line":"        return \u0027{network_space_ip}:{export_path}\u0027.format("},{"line_number":241,"context_line":"            network_space_ip\u003dnetwork_space_ip,"},{"line_number":242,"context_line":"            export_path\u003dexport_path)"},{"line_number":243,"context_line":""},{"line_number":244,"context_line":"    @infinisdk_to_manila_exceptions"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f93b717_62ce2283","line":241,"range":{"start_line":239,"start_character":8,"end_line":241,"end_character":46},"in_reply_to":"5f93b717_06141c43","updated":"2018-01-31 13:53:09.000000000","message":"You are correct, I changed that, and the commit message accordingly.","commit_id":"fb4908da801718f24e1d08e3a7e056accd30a2aa"}],"releasenotes/notes/infinidat-balance-network-spaces-ips-25a9f1e587b87156.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"df3417e7bc3fb615e4647b2d179c70ec7b080357","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - The INFINIDAT share driver now load balances shares between the IPs"},{"line_number":4,"context_line":"    of the chosen network space."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"1f9dbf25_572b26ea","line":3,"range":{"start_line":3,"start_character":31,"end_line":3,"end_character":55},"updated":"2018-03-01 17:33:40.000000000","message":"This statement seems ambiguous, it suggests that the driver performs this load balancing with some intelligence. \n\nThe change lets the driver return a list of export locations instead of returning one export location, where possible. I suppose users can decide to load balance off these different paths as they deem necessary.","commit_id":"6a85a6f5e320ccb087f6ba0fc51e4ad5f10ef2d0"}]}
