)]}'
{"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"f7050683fc30f7edfcc10c5ef2cca427d12af86c","unresolved":false,"context_lines":[{"line_number":1726,"context_line":""},{"line_number":1727,"context_line":"        # Below order is important:"},{"line_number":1728,"context_line":"        # cDOT compression requires that deduplication is enabled first."},{"line_number":1729,"context_line":"        if efficiency_status[\u0027dedupe\u0027] !\u003d dedup_enabled:"},{"line_number":1730,"context_line":"            if dedup_enabled:"},{"line_number":1731,"context_line":"                self.enable_dedup(volume_name)"},{"line_number":1732,"context_line":"            else:"},{"line_number":1733,"context_line":"                self.disable_dedup(volume_name)"},{"line_number":1734,"context_line":""},{"line_number":1735,"context_line":"        if efficiency_status[\u0027compression\u0027] !\u003d compression_enabled:"},{"line_number":1736,"context_line":"            if compression_enabled:"},{"line_number":1737,"context_line":"                self.enable_compression(volume_name)"},{"line_number":1738,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_06098d29","line":1735,"range":{"start_line":1729,"start_character":8,"end_line":1735,"end_character":67},"updated":"2018-06-22 03:05:47.000000000","message":"How about the dedup_enabled value is equal to \"False\"(default value) and the compression_enabled is equal to \"True\"?  The enabling compression also does not work on the netapp driver, because the deduplication is also disabled. So the issue also doesn\u0027t fix.  Am I missing something?","commit_id":"68b9903a7fcff6c238c2523c1d6cdc33d3dc88db"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"ded26d07666525296bb7fddf6d59b61fc20523bb","unresolved":false,"context_lines":[{"line_number":1726,"context_line":""},{"line_number":1727,"context_line":"        # Below order is important:"},{"line_number":1728,"context_line":"        # cDOT compression requires that deduplication is enabled first."},{"line_number":1729,"context_line":"        if efficiency_status[\u0027dedupe\u0027] !\u003d dedup_enabled:"},{"line_number":1730,"context_line":"            if dedup_enabled:"},{"line_number":1731,"context_line":"                self.enable_dedup(volume_name)"},{"line_number":1732,"context_line":"            else:"},{"line_number":1733,"context_line":"                self.disable_dedup(volume_name)"},{"line_number":1734,"context_line":""},{"line_number":1735,"context_line":"        if efficiency_status[\u0027compression\u0027] !\u003d compression_enabled:"},{"line_number":1736,"context_line":"            if compression_enabled:"},{"line_number":1737,"context_line":"                self.enable_compression(volume_name)"},{"line_number":1738,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_218ef326","line":1735,"range":{"start_line":1729,"start_character":8,"end_line":1735,"end_character":67},"in_reply_to":"5f7c97a3_06098d29","updated":"2018-06-22 05:26:46.000000000","message":"I understand that as misconfiguration by the user. I wouldn\u0027t implicitly enable deduplication if the user configures compression only, seems non-transparent.\n\nMaybe a better error should be raised, but personally I\u0027m fine with the one coming from the NetApp backend. Who knows... this configuration may even work in the future.","commit_id":"68b9903a7fcff6c238c2523c1d6cdc33d3dc88db"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"20780c772570fa99cdfc64472722dc5b5b2e78b4","unresolved":false,"context_lines":[{"line_number":1726,"context_line":""},{"line_number":1727,"context_line":"        # Below order is important:"},{"line_number":1728,"context_line":"        # cDOT compression requires that deduplication is enabled first."},{"line_number":1729,"context_line":"        if efficiency_status[\u0027dedupe\u0027] !\u003d dedup_enabled:"},{"line_number":1730,"context_line":"            if dedup_enabled:"},{"line_number":1731,"context_line":"                self.enable_dedup(volume_name)"},{"line_number":1732,"context_line":"            else:"},{"line_number":1733,"context_line":"                self.disable_dedup(volume_name)"},{"line_number":1734,"context_line":""},{"line_number":1735,"context_line":"        if efficiency_status[\u0027compression\u0027] !\u003d compression_enabled:"},{"line_number":1736,"context_line":"            if compression_enabled:"},{"line_number":1737,"context_line":"                self.enable_compression(volume_name)"},{"line_number":1738,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_a98bc966","line":1735,"range":{"start_line":1729,"start_character":8,"end_line":1735,"end_character":67},"in_reply_to":"5f7c97a3_218ef326","updated":"2018-06-22 06:18:31.000000000","message":"Sorry, I have to correct myself: for create_volume the behaviour was already, that dedup was implicitly set if compression was enabled.\nI will restore that behaviour in this method here.\n\nmodify_volume will behave the same then.","commit_id":"68b9903a7fcff6c238c2523c1d6cdc33d3dc88db"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"16bb714a62d557961b2e4efc653cd17393b640f4","unresolved":false,"context_lines":[{"line_number":1761,"context_line":"        \"\"\"Update dedupe \u0026 compression attributes to match desired values.\"\"\""},{"line_number":1762,"context_line":"        efficiency_status \u003d self.get_volume_efficiency_status(volume_name)"},{"line_number":1763,"context_line":""},{"line_number":1764,"context_line":"        # dedup with compression_enabled will be handled later"},{"line_number":1765,"context_line":"        if (efficiency_status[\u0027dedupe\u0027] !\u003d dedup_enabled and"},{"line_number":1766,"context_line":"                not compression_enabled):"},{"line_number":1767,"context_line":"            if dedup_enabled:"},{"line_number":1768,"context_line":"                self.enable_dedup(volume_name)"},{"line_number":1769,"context_line":"            else:"},{"line_number":1770,"context_line":"                self.disable_dedup(volume_name)"},{"line_number":1771,"context_line":""},{"line_number":1772,"context_line":"        if efficiency_status[\u0027compression\u0027] !\u003d compression_enabled:"},{"line_number":1773,"context_line":"            if compression_enabled:"},{"line_number":1774,"context_line":"                # cDOT compression requires that dedup is enabled first."},{"line_number":1775,"context_line":"                if not efficiency_status[\u0027dedupe\u0027]:"},{"line_number":1776,"context_line":"                    self.enable_dedup(volume_name)"},{"line_number":1777,"context_line":"                self.enable_compression(volume_name)"},{"line_number":1778,"context_line":"            else:"},{"line_number":1779,"context_line":"                self.disable_compression(volume_name)"},{"line_number":1780,"context_line":""},{"line_number":1781,"context_line":"    @na_utils.trace"},{"line_number":1782,"context_line":"    def volume_exists(self, volume_name):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_c3fad075","line":1779,"range":{"start_line":1764,"start_character":0,"end_line":1779,"end_character":53},"updated":"2018-07-26 17:16:22.000000000","message":"Sorry, I know this was on the verge of getting merged, but this is really confusing. Can we rewrite to something like this:\n\n# check if we need to update dedup or compression\nif efficiency_status[\u0027dedupe\u0027] !\u003d dedup_enabled or efficiency_status[\u0027compression\u0027] !\u003d compression_enabled:\n    # cDOT compression requires dedup to be enabled\n    dedup_enabled \u003d dedup_enabled or compression_enabled\n    \n    if dedup_enabled:\n        self.enable_dedup(volume_name)\n    else:\n        self.disable_dedup(volume_name)\n\n    if compression_enabled:\n        self.enable_compression(volume_name)\n    else:\n        self.disable_compression(volume_name)","commit_id":"7119dc78e37558b310366e866633b45c7224200f"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"127d6163bb0487cc7f1c0659486d0fbf238f42e2","unresolved":false,"context_lines":[{"line_number":1761,"context_line":"        \"\"\"Update dedupe \u0026 compression attributes to match desired values.\"\"\""},{"line_number":1762,"context_line":"        efficiency_status \u003d self.get_volume_efficiency_status(volume_name)"},{"line_number":1763,"context_line":""},{"line_number":1764,"context_line":"        if (efficiency_status[\u0027dedupe\u0027] !\u003d dedup_enabled or"},{"line_number":1765,"context_line":"                efficiency_status[\u0027compression\u0027] !\u003d compression_enabled):"},{"line_number":1766,"context_line":""},{"line_number":1767,"context_line":"            # cDOT compression requires dedup to be enabled"},{"line_number":1768,"context_line":"            dedup_enabled \u003d dedup_enabled or compression_enabled"}],"source_content_type":"text/x-python","patch_set":6,"id":"3f79a3b5_f12498c8","line":1765,"range":{"start_line":1764,"start_character":6,"end_line":1765,"end_character":73},"updated":"2018-08-08 14:26:07.000000000","message":"I believe this condition could be removed, and you are double checking it again below","commit_id":"6deb2f3f3edf8872c7024099a27e3d48d63c5eda"}]}
