)]}'
{".zuul.yaml":[{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"c25ea48ac3a79f693855e7527ac1ba718d0bf594","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        q-meta: true"},{"line_number":334,"context_line":"      devstack_plugins:"},{"line_number":335,"context_line":"        manila: git://git.openstack.org/openstack/manila"},{"line_number":336,"context_line":"        manila_tempest_plugin: git://git.openstack.org/openstack/manila-tempest-plugin"},{"line_number":337,"context_line":"        devstack_ceph_plugin: git://git.openstack.org/openstack/devstack-plugin-ceph"},{"line_number":338,"context_line":"      devstack_localrc:"},{"line_number":339,"context_line":"        SKIP_EPEL_INSTALL: True"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa0c359_5b2b2381","line":336,"range":{"start_line":336,"start_character":8,"end_line":336,"end_character":86},"updated":"2018-02-19 14:08:10.000000000","message":"This is not a devstack plugin, so it shouldn\u0027t be here","commit_id":"9abc3135ebadd13c7d82bb64db41918524e3c5af"},{"author":{"_account_id":27697,"name":"Rishabh Dave","email":"ridave@redhat.com","username":"rishabh-d-dave"},"change_message_id":"3b7db8d178113feeeeaf47325cdb8512ddf79ca6","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        q-meta: true"},{"line_number":334,"context_line":"      devstack_plugins:"},{"line_number":335,"context_line":"        manila: git://git.openstack.org/openstack/manila"},{"line_number":336,"context_line":"        manila_tempest_plugin: git://git.openstack.org/openstack/manila-tempest-plugin"},{"line_number":337,"context_line":"        devstack_ceph_plugin: git://git.openstack.org/openstack/devstack-plugin-ceph"},{"line_number":338,"context_line":"      devstack_localrc:"},{"line_number":339,"context_line":"        SKIP_EPEL_INSTALL: True"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"bf659307_1cc82e20","line":336,"range":{"start_line":336,"start_character":8,"end_line":336,"end_character":86},"in_reply_to":"3fa0c359_04f68ffa","updated":"2018-03-28 07:16:08.000000000","message":"Done","commit_id":"9abc3135ebadd13c7d82bb64db41918524e3c5af"},{"author":{"_account_id":27697,"name":"Rishabh Dave","email":"ridave@redhat.com","username":"rishabh-d-dave"},"change_message_id":"e4549b68fa8e848ab18b7fb2f3ce9fa483ca6a84","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        q-meta: true"},{"line_number":334,"context_line":"      devstack_plugins:"},{"line_number":335,"context_line":"        manila: git://git.openstack.org/openstack/manila"},{"line_number":336,"context_line":"        manila_tempest_plugin: git://git.openstack.org/openstack/manila-tempest-plugin"},{"line_number":337,"context_line":"        devstack_ceph_plugin: git://git.openstack.org/openstack/devstack-plugin-ceph"},{"line_number":338,"context_line":"      devstack_localrc:"},{"line_number":339,"context_line":"        SKIP_EPEL_INSTALL: True"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa0c359_7e1b6d1a","line":336,"range":{"start_line":336,"start_character":8,"end_line":336,"end_character":86},"in_reply_to":"3fa0c359_5b2b2381","updated":"2018-02-19 15:06:23.000000000","message":"The last time I ran stack.sh, I wasn\u0027t able to get devstack instance without this line in in my local.conf. And the patch that will make manila_tempest_plugin fetch and install by default hasn\u0027t merged (look at - https://review.openstack.org/#/c/539186/).","commit_id":"9abc3135ebadd13c7d82bb64db41918524e3c5af"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"7e187bc518b3298573e6c23e65c1fd01c53f5827","unresolved":false,"context_lines":[{"line_number":333,"context_line":"        q-meta: true"},{"line_number":334,"context_line":"      devstack_plugins:"},{"line_number":335,"context_line":"        manila: git://git.openstack.org/openstack/manila"},{"line_number":336,"context_line":"        manila_tempest_plugin: git://git.openstack.org/openstack/manila-tempest-plugin"},{"line_number":337,"context_line":"        devstack_ceph_plugin: git://git.openstack.org/openstack/devstack-plugin-ceph"},{"line_number":338,"context_line":"      devstack_localrc:"},{"line_number":339,"context_line":"        SKIP_EPEL_INSTALL: True"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa0c359_04f68ffa","line":336,"range":{"start_line":336,"start_character":8,"end_line":336,"end_character":86},"in_reply_to":"3fa0c359_7e1b6d1a","updated":"2018-03-05 16:50:15.000000000","message":"We need the manila_tempest_plugin system wide install merge first. As mentioned by Andrea, manila_tempest_plugin is not a devstack plugin so this line over here is not right.","commit_id":"9abc3135ebadd13c7d82bb64db41918524e3c5af"},{"author":{"_account_id":1921,"name":"Andrea Frittoli","email":"andrea.frittoli@gmail.com","username":"andrea-frittoli"},"change_message_id":"c25ea48ac3a79f693855e7527ac1ba718d0bf594","unresolved":false,"context_lines":[{"line_number":314,"context_line":"      - openstack/manila-tempest-plugin"},{"line_number":315,"context_line":"      - openstack/python-manilaclient"},{"line_number":316,"context_line":"      - openstack/tempest"},{"line_number":317,"context_line":"    vars:"},{"line_number":318,"context_line":"      tempest_test_regex: manila_tempest_tests.tests.scenario"},{"line_number":319,"context_line":"      devstack_services:"},{"line_number":320,"context_line":"        tempest: true"},{"line_number":321,"context_line":"        horizon: false"},{"line_number":322,"context_line":"        heat: false"},{"line_number":323,"context_line":"        h-eng: false"},{"line_number":324,"context_line":"        h-api: false"},{"line_number":325,"context_line":"        h-api-cfn: false"},{"line_number":326,"context_line":"        h-api-cw: false"},{"line_number":327,"context_line":"        n-net: false"},{"line_number":328,"context_line":"        neutron: true"},{"line_number":329,"context_line":"        q-svc: true"},{"line_number":330,"context_line":"        q-agt: true"},{"line_number":331,"context_line":"        q-dhcp: true"},{"line_number":332,"context_line":"        q-l3: true"},{"line_number":333,"context_line":"        q-meta: true"},{"line_number":334,"context_line":"      devstack_plugins:"},{"line_number":335,"context_line":"        manila: git://git.openstack.org/openstack/manila"},{"line_number":336,"context_line":"        manila_tempest_plugin: git://git.openstack.org/openstack/manila-tempest-plugin"},{"line_number":337,"context_line":"        devstack_ceph_plugin: git://git.openstack.org/openstack/devstack-plugin-ceph"},{"line_number":338,"context_line":"      devstack_localrc:"},{"line_number":339,"context_line":"        SKIP_EPEL_INSTALL: True"},{"line_number":340,"context_line":"        ENABLE_CEPH_MANILA: True"},{"line_number":341,"context_line":"        ENABLE_CEPH_NOVA: False"},{"line_number":342,"context_line":"        ENABLE_CEPH_GLANCE: False"},{"line_number":343,"context_line":"        ENABLE_CEPH_CINDER: False"},{"line_number":344,"context_line":"        ENABLE_CEPH_C_BAK: False"},{"line_number":345,"context_line":"        MANILA_CEPH_DRIVER: \u0027cephfsnfs\u0027"},{"line_number":346,"context_line":"      osc_environment:"},{"line_number":347,"context_line":"        PYTHONUNBUFFERED: \u0027true\u0027"},{"line_number":348,"context_line":"        DEVSTACK_GATE_NEUTRON: \u00271\u0027"},{"line_number":349,"context_line":"        KEEP_LOCALRC: \u00271\u0027"},{"line_number":350,"context_line":"        DEVSTACK_PROJECT_FROM_GIT: \u0027python-manilaclient\u0027"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"- job:"},{"line_number":353,"context_line":"    name: manila-tempest-minimal-dsvm-dummy"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa0c359_fb08ef28","line":350,"range":{"start_line":317,"start_character":0,"end_line":350,"end_character":56},"updated":"2018-02-19 14:08:10.000000000","message":"This job, as well as all jobs defined above, are based on a parent job called legacy-dsvm-base - these variables are used by the ansible roles defined in zuulv3 native jobs so I don\u0027t see how this could work at all.\n\nThe tempest base job devstack-tempest has already tempest and neutron enabled by default as well as heat  and horizon disabled.","commit_id":"9abc3135ebadd13c7d82bb64db41918524e3c5af"},{"author":{"_account_id":27697,"name":"Rishabh Dave","email":"ridave@redhat.com","username":"rishabh-d-dave"},"change_message_id":"e4549b68fa8e848ab18b7fb2f3ce9fa483ca6a84","unresolved":false,"context_lines":[{"line_number":314,"context_line":"      - openstack/manila-tempest-plugin"},{"line_number":315,"context_line":"      - openstack/python-manilaclient"},{"line_number":316,"context_line":"      - openstack/tempest"},{"line_number":317,"context_line":"    vars:"},{"line_number":318,"context_line":"      tempest_test_regex: manila_tempest_tests.tests.scenario"},{"line_number":319,"context_line":"      devstack_services:"},{"line_number":320,"context_line":"        tempest: true"},{"line_number":321,"context_line":"        horizon: false"},{"line_number":322,"context_line":"        heat: false"},{"line_number":323,"context_line":"        h-eng: false"},{"line_number":324,"context_line":"        h-api: false"},{"line_number":325,"context_line":"        h-api-cfn: false"},{"line_number":326,"context_line":"        h-api-cw: false"},{"line_number":327,"context_line":"        n-net: false"},{"line_number":328,"context_line":"        neutron: true"},{"line_number":329,"context_line":"        q-svc: true"},{"line_number":330,"context_line":"        q-agt: true"},{"line_number":331,"context_line":"        q-dhcp: true"},{"line_number":332,"context_line":"        q-l3: true"},{"line_number":333,"context_line":"        q-meta: true"},{"line_number":334,"context_line":"      devstack_plugins:"},{"line_number":335,"context_line":"        manila: git://git.openstack.org/openstack/manila"},{"line_number":336,"context_line":"        manila_tempest_plugin: git://git.openstack.org/openstack/manila-tempest-plugin"},{"line_number":337,"context_line":"        devstack_ceph_plugin: git://git.openstack.org/openstack/devstack-plugin-ceph"},{"line_number":338,"context_line":"      devstack_localrc:"},{"line_number":339,"context_line":"        SKIP_EPEL_INSTALL: True"},{"line_number":340,"context_line":"        ENABLE_CEPH_MANILA: True"},{"line_number":341,"context_line":"        ENABLE_CEPH_NOVA: False"},{"line_number":342,"context_line":"        ENABLE_CEPH_GLANCE: False"},{"line_number":343,"context_line":"        ENABLE_CEPH_CINDER: False"},{"line_number":344,"context_line":"        ENABLE_CEPH_C_BAK: False"},{"line_number":345,"context_line":"        MANILA_CEPH_DRIVER: \u0027cephfsnfs\u0027"},{"line_number":346,"context_line":"      osc_environment:"},{"line_number":347,"context_line":"        PYTHONUNBUFFERED: \u0027true\u0027"},{"line_number":348,"context_line":"        DEVSTACK_GATE_NEUTRON: \u00271\u0027"},{"line_number":349,"context_line":"        KEEP_LOCALRC: \u00271\u0027"},{"line_number":350,"context_line":"        DEVSTACK_PROJECT_FROM_GIT: \u0027python-manilaclient\u0027"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"- job:"},{"line_number":353,"context_line":"    name: manila-tempest-minimal-dsvm-dummy"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa0c359_5ebb11c3","line":350,"range":{"start_line":317,"start_character":0,"end_line":350,"end_character":56},"in_reply_to":"3fa0c359_fb08ef28","updated":"2018-02-19 15:06:23.000000000","message":"\u003e This job, as well as all jobs defined above, are based on a parent\n \u003e job called legacy-dsvm-base - these variables are used by the\n \u003e ansible roles defined in zuulv3 native jobs so I don\u0027t see how this\n \u003e could work at all.\n\nIf this is about variable at line 347, I picked up the idea from here (http://git.openstack.org/cgit/openstack/python-openstackclient/tree/.zuul.yaml#n107). Should I get rid of them too?","commit_id":"9abc3135ebadd13c7d82bb64db41918524e3c5af"},{"author":{"_account_id":27697,"name":"Rishabh Dave","email":"ridave@redhat.com","username":"rishabh-d-dave"},"change_message_id":"e4549b68fa8e848ab18b7fb2f3ce9fa483ca6a84","unresolved":false,"context_lines":[{"line_number":314,"context_line":"      - openstack/manila-tempest-plugin"},{"line_number":315,"context_line":"      - openstack/python-manilaclient"},{"line_number":316,"context_line":"      - openstack/tempest"},{"line_number":317,"context_line":"    vars:"},{"line_number":318,"context_line":"      tempest_test_regex: manila_tempest_tests.tests.scenario"},{"line_number":319,"context_line":"      devstack_services:"},{"line_number":320,"context_line":"        tempest: true"},{"line_number":321,"context_line":"        horizon: false"},{"line_number":322,"context_line":"        heat: false"},{"line_number":323,"context_line":"        h-eng: false"},{"line_number":324,"context_line":"        h-api: false"},{"line_number":325,"context_line":"        h-api-cfn: false"},{"line_number":326,"context_line":"        h-api-cw: false"},{"line_number":327,"context_line":"        n-net: false"},{"line_number":328,"context_line":"        neutron: true"},{"line_number":329,"context_line":"        q-svc: true"},{"line_number":330,"context_line":"        q-agt: true"},{"line_number":331,"context_line":"        q-dhcp: true"},{"line_number":332,"context_line":"        q-l3: true"},{"line_number":333,"context_line":"        q-meta: true"},{"line_number":334,"context_line":"      devstack_plugins:"},{"line_number":335,"context_line":"        manila: git://git.openstack.org/openstack/manila"},{"line_number":336,"context_line":"        manila_tempest_plugin: git://git.openstack.org/openstack/manila-tempest-plugin"},{"line_number":337,"context_line":"        devstack_ceph_plugin: git://git.openstack.org/openstack/devstack-plugin-ceph"},{"line_number":338,"context_line":"      devstack_localrc:"},{"line_number":339,"context_line":"        SKIP_EPEL_INSTALL: True"},{"line_number":340,"context_line":"        ENABLE_CEPH_MANILA: True"},{"line_number":341,"context_line":"        ENABLE_CEPH_NOVA: False"},{"line_number":342,"context_line":"        ENABLE_CEPH_GLANCE: False"},{"line_number":343,"context_line":"        ENABLE_CEPH_CINDER: False"},{"line_number":344,"context_line":"        ENABLE_CEPH_C_BAK: False"},{"line_number":345,"context_line":"        MANILA_CEPH_DRIVER: \u0027cephfsnfs\u0027"},{"line_number":346,"context_line":"      osc_environment:"},{"line_number":347,"context_line":"        PYTHONUNBUFFERED: \u0027true\u0027"},{"line_number":348,"context_line":"        DEVSTACK_GATE_NEUTRON: \u00271\u0027"},{"line_number":349,"context_line":"        KEEP_LOCALRC: \u00271\u0027"},{"line_number":350,"context_line":"        DEVSTACK_PROJECT_FROM_GIT: \u0027python-manilaclient\u0027"},{"line_number":351,"context_line":""},{"line_number":352,"context_line":"- job:"},{"line_number":353,"context_line":"    name: manila-tempest-minimal-dsvm-dummy"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa0c359_fe59bdfd","line":350,"range":{"start_line":317,"start_character":0,"end_line":350,"end_character":56},"in_reply_to":"3fa0c359_fb08ef28","updated":"2018-02-19 15:06:23.000000000","message":"I do see tempest enabled (in devstack-tempest) and horizon disabled (in devstack) but I don\u0027t see anything about neutron and heat in job definitions.\n\nAnyways, I will incorporate your these into next patch set.","commit_id":"9abc3135ebadd13c7d82bb64db41918524e3c5af"}],"playbooks/manila-tempest-minimal-dsvm-cephfs-nfs-scenario-centos-7/run.yaml":[{"author":{"_account_id":27697,"name":"Rishabh Dave","email":"ridave@redhat.com","username":"rishabh-d-dave"},"change_message_id":"dc6e1f1181b9919584827367a699e8ac78af4cbc","unresolved":false,"context_lines":[{"line_number":51,"context_line":"              # CephFSNFS driver backend."},{"line_number":52,"context_line":"              # Refer to job-template post_test_hook for more details on the"},{"line_number":53,"context_line":"              # arguments."},{"line_number":54,"context_line":"              source $BASE/new/devstack-plugin-ceph/manila/post_test_hook.sh \\"},{"line_number":55,"context_line":"                  singlebackend cephfsnfs scenario"},{"line_number":56,"context_line":"          }"},{"line_number":57,"context_line":"          export -f post_test_hook"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"3fa0c359_7ee60d47","line":54,"updated":"2018-02-19 14:56:46.000000000","message":"The reason why I was/am reluctant to get rid of playbooks is that I don\u0027t think that the (or any) parent job(s) would call post_test_hook.sh in devstack-ceph-plugin (that script invokes tempest to run scenario tests). This (along with line #44 that has similar significance) is specifically why I did not delete the playbooks.","commit_id":"9abc3135ebadd13c7d82bb64db41918524e3c5af"}]}
