)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"f017db6b32a014a4934330a65146ef3fcc722a5e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Simon Dodsley \u003csimon@purestorage.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-04-12 18:05:02 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add basic driver for Pure Storage FlashBlade array."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I9c9c6ea6d996d7c90e966661c314cd86dfa9f8e7"},{"line_number":10,"context_line":"Implements: blueprint purestorage-flashblade-manila-driver"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"9f6a8fd7_e002d83e","line":7,"range":{"start_line":7,"start_character":50,"end_line":7,"end_character":51},"updated":"2018-04-15 09:53:56.000000000","message":"delete","commit_id":"2461e513f774d0ccf13042ce995f5826eb732684"}],"doc/source/configuration/shared-file-systems/drivers/purestorage-flashblade-driver.rst":[{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"f017db6b32a014a4934330a65146ef3fcc722a5e","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Supported operations"},{"line_number":11,"context_line":"~~~~~~~~~~~~~~~~~~~~"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- Create and delete CIFS/NFS shares."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- Extend/Shrink a share."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"9f6a8fd7_80675c26","line":13,"range":{"start_line":13,"start_character":20,"end_line":13,"end_character":24},"updated":"2018-04-15 09:53:56.000000000","message":"So is CIFS already supported? (not sure according to the TODO comment in _update_access)","commit_id":"2461e513f774d0ccf13042ce995f5826eb732684"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"8c729f84f7b8bc3b0cf90a201c525d7aec5cfb1c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"Supported operations"},{"line_number":11,"context_line":"~~~~~~~~~~~~~~~~~~~~"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"- Create and delete CIFS/NFS shares."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- Extend/Shrink a share."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"9f6a8fd7_6b36a9b7","line":13,"range":{"start_line":13,"start_character":20,"end_line":13,"end_character":24},"in_reply_to":"9f6a8fd7_80675c26","updated":"2018-04-15 12:34:22.000000000","message":"CIFS is supported. Currently all CIFS shares are open access. What is TODO is to add ACLs based on AD integration. This requires a new REST call in the array. When this becomes available we will patch the driver.","commit_id":"2461e513f774d0ccf13042ce995f5826eb732684"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9968f722423c3b993c38cbfc5a53d519d9b93c02","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- Extend/Shrink a share."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- Create and delete filesystem snapshots."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- Set access rights to shares."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"9f6a8fd7_0c7aa323","line":17,"range":{"start_line":17,"start_character":30,"end_line":17,"end_character":40},"updated":"2018-04-16 02:58:23.000000000","message":"How to use the snapshot after you create. Do you need to support one of the feature about snapshot: create share from snapshot | revert to snapshot | mountable snapshot?","commit_id":"2461e513f774d0ccf13042ce995f5826eb732684"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"ff9cf3af6a0796930bc70107b482cc584fbb89ef","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- Extend/Shrink a share."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"- Create and delete filesystem snapshots."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- Set access rights to shares."},{"line_number":20,"context_line":""}],"source_content_type":"text/x-rst","patch_set":10,"id":"9f6a8fd7_4ccc1189","line":17,"range":{"start_line":17,"start_character":30,"end_line":17,"end_character":40},"in_reply_to":"9f6a8fd7_0c7aa323","updated":"2018-06-07 13:32:39.000000000","message":"Revert to snaphot and mountable snapshots are not yet available. Thet will be added in the future.","commit_id":"2461e513f774d0ccf13042ce995f5826eb732684"}],"manila/share/drivers/purestorage/flashblade.py":[{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"f017db6b32a014a4934330a65146ef3fcc722a5e","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        self.configuration.append_config_values(flashblade_connection_opts)"},{"line_number":92,"context_line":"        self.configuration.append_config_values(flashblade_auth_opts)"},{"line_number":93,"context_line":"        self.configuration.append_config_values(flashblade_extra_opts)"},{"line_number":94,"context_line":"        self._user_agent \u003d \u0027%(base)s %(class)s/%(version)s (%(platform)s)\u0027 % {"},{"line_number":95,"context_line":"            \u0027base\u0027: self.USER_AGENT_BASE,"},{"line_number":96,"context_line":"            \u0027class\u0027: self.__class__.__name__,"},{"line_number":97,"context_line":"            \u0027version\u0027: self.VERSION,"}],"source_content_type":"text/x-python","patch_set":10,"id":"bf659307_15a5ea9e","line":94,"range":{"start_line":94,"start_character":8,"end_line":94,"end_character":24},"updated":"2018-04-15 09:53:56.000000000","message":"Where is that actually set as the User-Agent for the REST API? As I see it\u0027s only set as an instance member and not used anywhere else...","commit_id":"2461e513f774d0ccf13042ce995f5826eb732684"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"8c729f84f7b8bc3b0cf90a201c525d7aec5cfb1c","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        self.configuration.append_config_values(flashblade_connection_opts)"},{"line_number":92,"context_line":"        self.configuration.append_config_values(flashblade_auth_opts)"},{"line_number":93,"context_line":"        self.configuration.append_config_values(flashblade_extra_opts)"},{"line_number":94,"context_line":"        self._user_agent \u003d \u0027%(base)s %(class)s/%(version)s (%(platform)s)\u0027 % {"},{"line_number":95,"context_line":"            \u0027base\u0027: self.USER_AGENT_BASE,"},{"line_number":96,"context_line":"            \u0027class\u0027: self.__class__.__name__,"},{"line_number":97,"context_line":"            \u0027version\u0027: self.VERSION,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_eb495932","line":94,"range":{"start_line":94,"start_character":8,"end_line":94,"end_character":24},"in_reply_to":"bf659307_15a5ea9e","updated":"2018-04-15 12:34:22.000000000","message":"user agent is there ready for the next Rest API release for the array. I\u0027ll remove it and add it in when available.","commit_id":"2461e513f774d0ccf13042ce995f5826eb732684"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"f017db6b32a014a4934330a65146ef3fcc722a5e","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def do_setup(self, context):"},{"line_number":102,"context_line":"        \"\"\"Driver initialization\"\"\""},{"line_number":103,"context_line":"        if HAS_PURITY_FB is None:"},{"line_number":104,"context_line":"            msg \u003d _(\"Missing \u0027purity_fb\u0027 python module, ensure the library\""},{"line_number":105,"context_line":"                    \" is installed and available.\")"},{"line_number":106,"context_line":"            raise exception.ManilaException(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"bf659307_b3669350","line":103,"range":{"start_line":103,"start_character":8,"end_line":103,"end_character":32},"updated":"2018-04-15 09:53:56.000000000","message":"You can also do:\nif not HAS_PURITY_FB","commit_id":"2461e513f774d0ccf13042ce995f5826eb732684"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"8c729f84f7b8bc3b0cf90a201c525d7aec5cfb1c","unresolved":false,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"    def do_setup(self, context):"},{"line_number":102,"context_line":"        \"\"\"Driver initialization\"\"\""},{"line_number":103,"context_line":"        if HAS_PURITY_FB is None:"},{"line_number":104,"context_line":"            msg \u003d _(\"Missing \u0027purity_fb\u0027 python module, ensure the library\""},{"line_number":105,"context_line":"                    \" is installed and available.\")"},{"line_number":106,"context_line":"            raise exception.ManilaException(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_0b47ed1f","line":103,"range":{"start_line":103,"start_character":8,"end_line":103,"end_character":32},"in_reply_to":"bf659307_b3669350","updated":"2018-04-15 12:34:22.000000000","message":"Done","commit_id":"2461e513f774d0ccf13042ce995f5826eb732684"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9968f722423c3b993c38cbfc5a53d519d9b93c02","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            free_capacity_gb\u003dfloat(free_capacity_bytes) / units.Gi,"},{"line_number":143,"context_line":"            provisioned_capacity_gb\u003dfloat(provisioned_cap_bytes) / units.Gi,"},{"line_number":144,"context_line":"            snapshot_support\u003dTrue,"},{"line_number":145,"context_line":"            create_share_from_snapshot_support\u003dFalse,"},{"line_number":146,"context_line":"            mount_snapshot_support\u003dFalse,"},{"line_number":147,"context_line":"            revert_to_snapshot_support\u003dFalse)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        super(FlashBladeShareDriver, self)._update_share_stats(data)"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_2cb1a7e2","line":147,"range":{"start_line":145,"start_character":12,"end_line":147,"end_character":44},"updated":"2018-04-16 02:58:23.000000000","message":"How to use the snapshot after you create. Do you need to support one of the feature about snapshot: create share from snapshot | revert to snapshot | mountable snapshot?","commit_id":"2461e513f774d0ccf13042ce995f5826eb732684"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"ff9cf3af6a0796930bc70107b482cc584fbb89ef","unresolved":false,"context_lines":[{"line_number":142,"context_line":"            free_capacity_gb\u003dfloat(free_capacity_bytes) / units.Gi,"},{"line_number":143,"context_line":"            provisioned_capacity_gb\u003dfloat(provisioned_cap_bytes) / units.Gi,"},{"line_number":144,"context_line":"            snapshot_support\u003dTrue,"},{"line_number":145,"context_line":"            create_share_from_snapshot_support\u003dFalse,"},{"line_number":146,"context_line":"            mount_snapshot_support\u003dFalse,"},{"line_number":147,"context_line":"            revert_to_snapshot_support\u003dFalse)"},{"line_number":148,"context_line":""},{"line_number":149,"context_line":"        super(FlashBladeShareDriver, self)._update_share_stats(data)"},{"line_number":150,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_2ce67d18","line":147,"range":{"start_line":145,"start_character":12,"end_line":147,"end_character":44},"in_reply_to":"9f6a8fd7_2cb1a7e2","updated":"2018-06-07 13:32:39.000000000","message":"Revert to snapshot and mountable snapshots are not yet available. These will be added in the future","commit_id":"2461e513f774d0ccf13042ce995f5826eb732684"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"f017db6b32a014a4934330a65146ef3fcc722a5e","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def _get_available_capacity(self):"},{"line_number":152,"context_line":"        space \u003d self._sys.arrays.list_arrays_space()"},{"line_number":153,"context_line":"        data_reduction \u003d space.items[0].space.data_reduction"},{"line_number":154,"context_line":"        physical_capacity_bytes \u003d space.items[0].capacity"},{"line_number":155,"context_line":"        used_capacity_bytes \u003d space.items[0].space.total_physical"},{"line_number":156,"context_line":"        free_capacity_bytes \u003d physical_capacity_bytes - used_capacity_bytes"},{"line_number":157,"context_line":"        provisioned_capacity_bytes \u003d space.items[0].space.unique"},{"line_number":158,"context_line":"        return (free_capacity_bytes, physical_capacity_bytes,"},{"line_number":159,"context_line":"                provisioned_capacity_bytes, data_reduction)"},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"bf659307_95e7bae3","line":157,"range":{"start_line":153,"start_character":8,"end_line":157,"end_character":64},"updated":"2018-04-15 09:53:56.000000000","message":"As you\u0027re using space.items[0] several times here, I suggest moving it into another variable and referencing it instead of repeating space.items[0] each time.","commit_id":"2461e513f774d0ccf13042ce995f5826eb732684"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"8c729f84f7b8bc3b0cf90a201c525d7aec5cfb1c","unresolved":false,"context_lines":[{"line_number":150,"context_line":""},{"line_number":151,"context_line":"    def _get_available_capacity(self):"},{"line_number":152,"context_line":"        space \u003d self._sys.arrays.list_arrays_space()"},{"line_number":153,"context_line":"        data_reduction \u003d space.items[0].space.data_reduction"},{"line_number":154,"context_line":"        physical_capacity_bytes \u003d space.items[0].capacity"},{"line_number":155,"context_line":"        used_capacity_bytes \u003d space.items[0].space.total_physical"},{"line_number":156,"context_line":"        free_capacity_bytes \u003d physical_capacity_bytes - used_capacity_bytes"},{"line_number":157,"context_line":"        provisioned_capacity_bytes \u003d space.items[0].space.unique"},{"line_number":158,"context_line":"        return (free_capacity_bytes, physical_capacity_bytes,"},{"line_number":159,"context_line":"                provisioned_capacity_bytes, data_reduction)"},{"line_number":160,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_6b5f89e5","line":157,"range":{"start_line":153,"start_character":8,"end_line":157,"end_character":64},"in_reply_to":"bf659307_95e7bae3","updated":"2018-04-15 12:34:22.000000000","message":"Done","commit_id":"2461e513f774d0ccf13042ce995f5826eb732684"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"f017db6b32a014a4934330a65146ef3fcc722a5e","unresolved":false,"context_lines":[{"line_number":248,"context_line":"            LOG.warning(message, {\"dataset_name\": dataset_name})"},{"line_number":249,"context_line":"            return"},{"line_number":250,"context_line":"        attr \u003d {}"},{"line_number":251,"context_line":"        attr[\u0027provisioned\u0027] \u003d new_size * 1073741824"},{"line_number":252,"context_line":"        n_attr \u003d purity_fb.FileSystem(**attr)"},{"line_number":253,"context_line":"        self._sys.file_systems.update_file_systems("},{"line_number":254,"context_line":"            name\u003ddataset_name, attributes\u003dn_attr)"}],"source_content_type":"text/x-python","patch_set":10,"id":"bf659307_b3cbf31b","line":251,"range":{"start_line":251,"start_character":41,"end_line":251,"end_character":51},"updated":"2018-04-15 09:53:56.000000000","message":"Magic number, please set as a private constant in the file header.","commit_id":"2461e513f774d0ccf13042ce995f5826eb732684"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"ff9cf3af6a0796930bc70107b482cc584fbb89ef","unresolved":false,"context_lines":[{"line_number":248,"context_line":"            LOG.warning(message, {\"dataset_name\": dataset_name})"},{"line_number":249,"context_line":"            return"},{"line_number":250,"context_line":"        attr \u003d {}"},{"line_number":251,"context_line":"        attr[\u0027provisioned\u0027] \u003d new_size * 1073741824"},{"line_number":252,"context_line":"        n_attr \u003d purity_fb.FileSystem(**attr)"},{"line_number":253,"context_line":"        self._sys.file_systems.update_file_systems("},{"line_number":254,"context_line":"            name\u003ddataset_name, attributes\u003dn_attr)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_4ce3b106","line":251,"range":{"start_line":251,"start_character":41,"end_line":251,"end_character":51},"in_reply_to":"9f6a8fd7_2cff6768","updated":"2018-06-07 13:32:39.000000000","message":"My bad","commit_id":"2461e513f774d0ccf13042ce995f5826eb732684"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9968f722423c3b993c38cbfc5a53d519d9b93c02","unresolved":false,"context_lines":[{"line_number":248,"context_line":"            LOG.warning(message, {\"dataset_name\": dataset_name})"},{"line_number":249,"context_line":"            return"},{"line_number":250,"context_line":"        attr \u003d {}"},{"line_number":251,"context_line":"        attr[\u0027provisioned\u0027] \u003d new_size * 1073741824"},{"line_number":252,"context_line":"        n_attr \u003d purity_fb.FileSystem(**attr)"},{"line_number":253,"context_line":"        self._sys.file_systems.update_file_systems("},{"line_number":254,"context_line":"            name\u003ddataset_name, attributes\u003dn_attr)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_2cff6768","line":251,"range":{"start_line":251,"start_character":41,"end_line":251,"end_character":51},"in_reply_to":"9f6a8fd7_cbfed5ad","updated":"2018-04-16 02:58:23.000000000","message":"? Where is patch 11? Cloud you update patch first then response the comments?","commit_id":"2461e513f774d0ccf13042ce995f5826eb732684"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"8c729f84f7b8bc3b0cf90a201c525d7aec5cfb1c","unresolved":false,"context_lines":[{"line_number":248,"context_line":"            LOG.warning(message, {\"dataset_name\": dataset_name})"},{"line_number":249,"context_line":"            return"},{"line_number":250,"context_line":"        attr \u003d {}"},{"line_number":251,"context_line":"        attr[\u0027provisioned\u0027] \u003d new_size * 1073741824"},{"line_number":252,"context_line":"        n_attr \u003d purity_fb.FileSystem(**attr)"},{"line_number":253,"context_line":"        self._sys.file_systems.update_file_systems("},{"line_number":254,"context_line":"            name\u003ddataset_name, attributes\u003dn_attr)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_cbfed5ad","line":251,"range":{"start_line":251,"start_character":41,"end_line":251,"end_character":51},"in_reply_to":"bf659307_b3cbf31b","updated":"2018-04-15 12:34:22.000000000","message":"Done","commit_id":"2461e513f774d0ccf13042ce995f5826eb732684"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"f017db6b32a014a4934330a65146ef3fcc722a5e","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        for access in access_rules:"},{"line_number":268,"context_line":"            if access[\u0027access_type\u0027] \u003d\u003d \u0027ip\u0027:"},{"line_number":269,"context_line":"                line \u003d (access[\u0027access_to\u0027] +"},{"line_number":270,"context_line":"                        \u0027(\u0027 + self._get_flashblade_access_level(access) +"},{"line_number":271,"context_line":"                        \u0027,no_root_squash) \u0027)"},{"line_number":272,"context_line":"                nfs_rules +\u003d line"},{"line_number":273,"context_line":"        message \u003d (\"rules are %(nfs_rules)s, info \""},{"line_number":274,"context_line":"                   \"update nfs access\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"bf659307_33d7e3c1","line":271,"range":{"start_line":270,"start_character":24,"end_line":271,"end_character":43},"updated":"2018-04-15 09:53:56.000000000","message":"I think it\u0027ll be clearer to write this using string formatting:\nline \u003d \u0027%(access_to)s(%(access_level)s,no_root_squash) \u0027\nor something of the sort.","commit_id":"2461e513f774d0ccf13042ce995f5826eb732684"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"8c729f84f7b8bc3b0cf90a201c525d7aec5cfb1c","unresolved":false,"context_lines":[{"line_number":267,"context_line":"        for access in access_rules:"},{"line_number":268,"context_line":"            if access[\u0027access_type\u0027] \u003d\u003d \u0027ip\u0027:"},{"line_number":269,"context_line":"                line \u003d (access[\u0027access_to\u0027] +"},{"line_number":270,"context_line":"                        \u0027(\u0027 + self._get_flashblade_access_level(access) +"},{"line_number":271,"context_line":"                        \u0027,no_root_squash) \u0027)"},{"line_number":272,"context_line":"                nfs_rules +\u003d line"},{"line_number":273,"context_line":"        message \u003d (\"rules are %(nfs_rules)s, info \""},{"line_number":274,"context_line":"                   \"update nfs access\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_2b5991fd","line":271,"range":{"start_line":270,"start_character":24,"end_line":271,"end_character":43},"in_reply_to":"bf659307_33d7e3c1","updated":"2018-04-15 12:34:22.000000000","message":"Done","commit_id":"2461e513f774d0ccf13042ce995f5826eb732684"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"f017db6b32a014a4934330a65146ef3fcc722a5e","unresolved":false,"context_lines":[{"line_number":282,"context_line":"    @purity_fb_to_manila_exceptions"},{"line_number":283,"context_line":"    def create_share(self, context, share, share_server\u003dNone):"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        size \u003d share[\u0027size\u0027] * 1073741824"},{"line_number":286,"context_line":"        share_name \u003d self._make_share_name(share)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        if share[\u0027share_proto\u0027] \u003d\u003d \u0027NFS\u0027:"}],"source_content_type":"text/x-python","patch_set":10,"id":"bf659307_b3f4535c","line":285,"range":{"start_line":285,"start_character":31,"end_line":285,"end_character":41},"updated":"2018-04-15 09:53:56.000000000","message":"Magic number.","commit_id":"2461e513f774d0ccf13042ce995f5826eb732684"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"c881a71ff9ac01ddcb4151ea84175a6e2d9a0863","unresolved":false,"context_lines":[{"line_number":282,"context_line":"    @purity_fb_to_manila_exceptions"},{"line_number":283,"context_line":"    def create_share(self, context, share, share_server\u003dNone):"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        size \u003d share[\u0027size\u0027] * 1073741824"},{"line_number":286,"context_line":"        share_name \u003d self._make_share_name(share)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        if share[\u0027share_proto\u0027] \u003d\u003d \u0027NFS\u0027:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_6bd22937","line":285,"range":{"start_line":285,"start_character":31,"end_line":285,"end_character":41},"in_reply_to":"9f6a8fd7_6b2d4945","updated":"2018-04-15 12:45:19.000000000","message":"Wanted to write it in the first comment round but forgot:\nSince that\u0027s simply 1 GiB, maybe just use units.Gi? (from oslo_units import units)","commit_id":"2461e513f774d0ccf13042ce995f5826eb732684"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"ff9cf3af6a0796930bc70107b482cc584fbb89ef","unresolved":false,"context_lines":[{"line_number":282,"context_line":"    @purity_fb_to_manila_exceptions"},{"line_number":283,"context_line":"    def create_share(self, context, share, share_server\u003dNone):"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        size \u003d share[\u0027size\u0027] * 1073741824"},{"line_number":286,"context_line":"        share_name \u003d self._make_share_name(share)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        if share[\u0027share_proto\u0027] \u003d\u003d \u0027NFS\u0027:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_cb73354d","line":285,"range":{"start_line":285,"start_character":31,"end_line":285,"end_character":41},"in_reply_to":"9f6a8fd7_6bd22937","updated":"2018-06-07 13:32:39.000000000","message":"Done","commit_id":"2461e513f774d0ccf13042ce995f5826eb732684"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"8c729f84f7b8bc3b0cf90a201c525d7aec5cfb1c","unresolved":false,"context_lines":[{"line_number":282,"context_line":"    @purity_fb_to_manila_exceptions"},{"line_number":283,"context_line":"    def create_share(self, context, share, share_server\u003dNone):"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        size \u003d share[\u0027size\u0027] * 1073741824"},{"line_number":286,"context_line":"        share_name \u003d self._make_share_name(share)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        if share[\u0027share_proto\u0027] \u003d\u003d \u0027NFS\u0027:"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_6b2d4945","line":285,"range":{"start_line":285,"start_character":31,"end_line":285,"end_character":41},"in_reply_to":"bf659307_b3f4535c","updated":"2018-04-15 12:34:22.000000000","message":"Done","commit_id":"2461e513f774d0ccf13042ce995f5826eb732684"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"9968f722423c3b993c38cbfc5a53d519d9b93c02","unresolved":false,"context_lines":[{"line_number":322,"context_line":"                sources\u003dsource,"},{"line_number":323,"context_line":"                suffix\u003dpurity_fb.SnapshotSuffix(snapshot[\u0027id\u0027]))"},{"line_number":324,"context_line":"        except exception.ShareResourceNotFound:"},{"line_number":325,"context_line":"            message \u003d (\"share %(dataset_name)s not found on FlashBlade, skip \""},{"line_number":326,"context_line":"                       \"delete\")"},{"line_number":327,"context_line":"            LOG.warning(message, {\"dataset_name\": flashblade_filesystem})"},{"line_number":328,"context_line":"            raise exception.InvalidShare(reason\u003dmessage)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    @purity_fb_to_manila_exceptions"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_0ccdc35c","line":327,"range":{"start_line":325,"start_character":11,"end_line":327,"end_character":73},"updated":"2018-04-16 02:58:23.000000000","message":"The function is create snapshot, not delete a snapshot. It should raise error log.","commit_id":"2461e513f774d0ccf13042ce995f5826eb732684"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"ff9cf3af6a0796930bc70107b482cc584fbb89ef","unresolved":false,"context_lines":[{"line_number":322,"context_line":"                sources\u003dsource,"},{"line_number":323,"context_line":"                suffix\u003dpurity_fb.SnapshotSuffix(snapshot[\u0027id\u0027]))"},{"line_number":324,"context_line":"        except exception.ShareResourceNotFound:"},{"line_number":325,"context_line":"            message \u003d (\"share %(dataset_name)s not found on FlashBlade, skip \""},{"line_number":326,"context_line":"                       \"delete\")"},{"line_number":327,"context_line":"            LOG.warning(message, {\"dataset_name\": flashblade_filesystem})"},{"line_number":328,"context_line":"            raise exception.InvalidShare(reason\u003dmessage)"},{"line_number":329,"context_line":""},{"line_number":330,"context_line":"    @purity_fb_to_manila_exceptions"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_0cedb9ee","line":327,"range":{"start_line":325,"start_character":11,"end_line":327,"end_character":73},"in_reply_to":"9f6a8fd7_0ccdc35c","updated":"2018-06-07 13:32:39.000000000","message":"Done","commit_id":"2461e513f774d0ccf13042ce995f5826eb732684"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"f017db6b32a014a4934330a65146ef3fcc722a5e","unresolved":false,"context_lines":[{"line_number":351,"context_line":"    def delete_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":352,"context_line":"        \"\"\"Caled to delete a snapshot\"\"\""},{"line_number":353,"context_line":"        dataset_name \u003d self._make_source_name(snapshot)"},{"line_number":354,"context_line":"        filt \u003d (\u0027source\u003d\\\u0027\u0027 +"},{"line_number":355,"context_line":"                dataset_name +"},{"line_number":356,"context_line":"                \u0027\\\u0027 and suffix\u003d\\\u0027\u0027 +"},{"line_number":357,"context_line":"                snapshot[\u0027id\u0027] +"},{"line_number":358,"context_line":"                \u0027\\\u0027\u0027)"},{"line_number":359,"context_line":"        name \u003d (dataset_name +"},{"line_number":360,"context_line":"                \".\" +"},{"line_number":361,"context_line":"                snapshot[\u0027id\u0027])"},{"line_number":362,"context_line":"        try:"},{"line_number":363,"context_line":"            flashblade_snapshot \u003d ("},{"line_number":364,"context_line":"                self._get_flashblade_snapshot_by_name(filt))"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_c050f4d7","line":361,"range":{"start_line":354,"start_character":8,"end_line":361,"end_character":31},"updated":"2018-04-15 09:53:56.000000000","message":"Maybe using string formatting here as well will make this more clear.","commit_id":"2461e513f774d0ccf13042ce995f5826eb732684"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"8c729f84f7b8bc3b0cf90a201c525d7aec5cfb1c","unresolved":false,"context_lines":[{"line_number":351,"context_line":"    def delete_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":352,"context_line":"        \"\"\"Caled to delete a snapshot\"\"\""},{"line_number":353,"context_line":"        dataset_name \u003d self._make_source_name(snapshot)"},{"line_number":354,"context_line":"        filt \u003d (\u0027source\u003d\\\u0027\u0027 +"},{"line_number":355,"context_line":"                dataset_name +"},{"line_number":356,"context_line":"                \u0027\\\u0027 and suffix\u003d\\\u0027\u0027 +"},{"line_number":357,"context_line":"                snapshot[\u0027id\u0027] +"},{"line_number":358,"context_line":"                \u0027\\\u0027\u0027)"},{"line_number":359,"context_line":"        name \u003d (dataset_name +"},{"line_number":360,"context_line":"                \".\" +"},{"line_number":361,"context_line":"                snapshot[\u0027id\u0027])"},{"line_number":362,"context_line":"        try:"},{"line_number":363,"context_line":"            flashblade_snapshot \u003d ("},{"line_number":364,"context_line":"                self._get_flashblade_snapshot_by_name(filt))"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_8b09bdde","line":361,"range":{"start_line":354,"start_character":8,"end_line":361,"end_character":31},"in_reply_to":"9f6a8fd7_c050f4d7","updated":"2018-04-15 12:34:22.000000000","message":"Done","commit_id":"2461e513f774d0ccf13042ce995f5826eb732684"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"f017db6b32a014a4934330a65146ef3fcc722a5e","unresolved":false,"context_lines":[{"line_number":350,"context_line":"    @purity_fb_to_manila_exceptions"},{"line_number":351,"context_line":"    def delete_snapshot(self, context, snapshot, share_server\u003dNone):"},{"line_number":352,"context_line":"        \"\"\"Caled to delete a snapshot\"\"\""},{"line_number":353,"context_line":"        dataset_name \u003d self._make_source_name(snapshot)"},{"line_number":354,"context_line":"        filt \u003d (\u0027source\u003d\\\u0027\u0027 +"},{"line_number":355,"context_line":"                dataset_name +"},{"line_number":356,"context_line":"                \u0027\\\u0027 and suffix\u003d\\\u0027\u0027 +"},{"line_number":357,"context_line":"                snapshot[\u0027id\u0027] +"},{"line_number":358,"context_line":"                \u0027\\\u0027\u0027)"},{"line_number":359,"context_line":"        name \u003d (dataset_name +"},{"line_number":360,"context_line":"                \".\" +"},{"line_number":361,"context_line":"                snapshot[\u0027id\u0027])"},{"line_number":362,"context_line":"        try:"},{"line_number":363,"context_line":"            flashblade_snapshot \u003d ("},{"line_number":364,"context_line":"                self._get_flashblade_snapshot_by_name(filt))"},{"line_number":365,"context_line":"        except exception.ShareResourceNotFound:"},{"line_number":366,"context_line":"            message \u003d (\"snapshot %(snapshot)s not found on FlashBlade, skip \""},{"line_number":367,"context_line":"                       \"delete\")"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_2059b0fd","line":364,"range":{"start_line":353,"start_character":8,"end_line":364,"end_character":60},"updated":"2018-04-15 09:53:56.000000000","message":"maybe make _get_flashblade_snapshot_by_name get a snapshot object and move the construction of the filter into this function instead. since it\u0027s based entirely on the snapshot object?","commit_id":"2461e513f774d0ccf13042ce995f5826eb732684"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"f017db6b32a014a4934330a65146ef3fcc722a5e","unresolved":false,"context_lines":[{"line_number":374,"context_line":"            self._sys.file_system_snapshots.delete_file_system_snapshots("},{"line_number":375,"context_line":"                name\u003dname)"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"    def ensure_share(self, context, share, share_server\u003dNone):"},{"line_number":378,"context_line":"        \"\"\"Dummy - called to ensure share is exported\"\"\""},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    def update_access(self, context, share, access_rules, add_rules,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_200e90e5","line":377,"range":{"start_line":377,"start_character":4,"end_line":377,"end_character":62},"updated":"2018-04-15 09:53:56.000000000","message":"is there nothing that should be done in front of your API to ensure that the share is exported?","commit_id":"2461e513f774d0ccf13042ce995f5826eb732684"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@everpuredata.com","username":"sdodsley"},"change_message_id":"8c729f84f7b8bc3b0cf90a201c525d7aec5cfb1c","unresolved":false,"context_lines":[{"line_number":374,"context_line":"            self._sys.file_system_snapshots.delete_file_system_snapshots("},{"line_number":375,"context_line":"                name\u003dname)"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"    def ensure_share(self, context, share, share_server\u003dNone):"},{"line_number":378,"context_line":"        \"\"\"Dummy - called to ensure share is exported\"\"\""},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"    def update_access(self, context, share, access_rules, add_rules,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_8b321da7","line":377,"range":{"start_line":377,"start_character":4,"end_line":377,"end_character":62},"in_reply_to":"9f6a8fd7_200e90e5","updated":"2018-04-15 12:34:22.000000000","message":"No. The share is guaranteed to be exported just by the act of creating it.","commit_id":"2461e513f774d0ccf13042ce995f5826eb732684"}],"manila/tests/share/drivers/purestorage/test_flashblade.py":[{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"f017db6b32a014a4934330a65146ef3fcc722a5e","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                  \u0027time_remaining\u0027: None}"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"def _create_mock__getitem__(mock):"},{"line_number":50,"context_line":"    def mock__getitem__(self, key, default\u003dNone):"},{"line_number":51,"context_line":"        return getattr(mock, key, default)"},{"line_number":52,"context_line":"    return mock__getitem__"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"test_share \u003d mock.Mock(id\u003d_MOCK_SHARE_ID, size\u003d_MOCK_SHARE_SIZE,"},{"line_number":55,"context_line":"                       share_proto\u003d\u0027NFS\u0027)"},{"line_number":56,"context_line":"test_share.__getitem__ \u003d _create_mock__getitem__(test_share)"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"test_snapshot \u003d mock.Mock(id\u003d_MOCK_SNAPSHOT_ID)"},{"line_number":59,"context_line":"test_snapshot.__getitem__ \u003d _create_mock__getitem__(test_snapshot)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"class FakePurityFBException(Exception):"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf659307_9314dda1","line":59,"range":{"start_line":49,"start_character":0,"end_line":59,"end_character":66},"updated":"2018-04-15 09:53:56.000000000","message":"really flattered that you used our tests code, but this code is unused, so you can remove it. :)","commit_id":"97ddc13d9d7b95561cb3fe83fc690fdb191b22b9"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"f017db6b32a014a4934330a65146ef3fcc722a5e","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        self._mock_filesystem \u003d mock.Mock()"},{"line_number":102,"context_line":"        self._mock_filesystem.size \u003d _MOCK_SHARE_SIZE"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"#        result.file_systems.create_share.return_value \u003d self._mock_filesystem"},{"line_number":105,"context_line":"#        result.file_systems.extend_share.return_value \u003d self._mock_filesystem"},{"line_number":106,"context_line":"        return result"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    def _raise_purity_fb(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":7,"id":"bf659307_3325d109","line":105,"range":{"start_line":104,"start_character":0,"end_line":105,"end_character":78},"updated":"2018-04-15 09:53:56.000000000","message":"remove commented out code","commit_id":"97ddc13d9d7b95561cb3fe83fc690fdb191b22b9"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"f017db6b32a014a4934330a65146ef3fcc722a5e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"import mock"},{"line_number":18,"context_line":"import sys"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"sys.modules[\u0027purity_fb\u0027] \u003d mock.Mock()"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from manila.common import constants"},{"line_number":23,"context_line":"from manila import exception"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_20d0d0c9","line":20,"updated":"2018-04-15 09:53:56.000000000","message":"Are you sure that this is needed?","commit_id":"2461e513f774d0ccf13042ce995f5826eb732684"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"f017db6b32a014a4934330a65146ef3fcc722a5e","unresolved":false,"context_lines":[{"line_number":93,"context_line":"        return result"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"class FlashBladeDriverTestCase(FlashBladeDriverTestCaseBase):"},{"line_number":97,"context_line":"    def test_no_auth_parameters(self):"},{"line_number":98,"context_line":"        self.configuration.flashblade_api \u003d None"},{"line_number":99,"context_line":"        self.assertRaises(exception.BadConfigurationException,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_00aeec2d","line":96,"updated":"2018-04-15 09:53:56.000000000","message":"I suggest adding some tests for:\n1. Other corner-cases (you can see the tests that we used): deleting a share which doesn\u0027t exist, deleting a share with snapshots, API fails, etc.\n2. Some private methods (_resize_share, _update_nfs_access, etc.).\n\nAlso, in your tests, please see where you can assert that the correct mocked API method in purity_fb has been called, or called with the correct argument values (see uses of assert_called_once and assert_called_once_with in our test code). If you extend your mocking (mock setitem for test_share and test_snapshot) you can also assert for changed values on the mocked share and snapshot, but I\u0027m not sure if that won\u0027t be a bit of an overkill.","commit_id":"2461e513f774d0ccf13042ce995f5826eb732684"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"f017db6b32a014a4934330a65146ef3fcc722a5e","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        # should not raise an exception"},{"line_number":132,"context_line":""},{"line_number":133,"context_line":"    def test_extend_share(self):"},{"line_number":134,"context_line":"        self.driver.extend_share(test_share, _MOCK_SHARE_SIZE * 2)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def test_shrink_share(self):"},{"line_number":137,"context_line":"        self.driver.shrink_share(test_share, _MOCK_SHARE_SIZE / 2)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_c0f9d44d","line":134,"updated":"2018-04-15 09:53:56.000000000","message":"Assert that the required action has been taken (required mocked API method has been called, share size has changed, etc.).","commit_id":"2461e513f774d0ccf13042ce995f5826eb732684"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"f017db6b32a014a4934330a65146ef3fcc722a5e","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        self.driver.extend_share(test_share, _MOCK_SHARE_SIZE * 2)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def test_shrink_share(self):"},{"line_number":137,"context_line":"        self.driver.shrink_share(test_share, _MOCK_SHARE_SIZE / 2)"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"    def test_create_snapshot(self):"},{"line_number":140,"context_line":"        self.driver.create_snapshot(None, test_snapshot)"}],"source_content_type":"text/x-python","patch_set":10,"id":"9f6a8fd7_609488e9","line":137,"updated":"2018-04-15 09:53:56.000000000","message":"Same comment as for test_extend_share.","commit_id":"2461e513f774d0ccf13042ce995f5826eb732684"}]}
