)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"e23ba40ed70aef498bddf946a78a62d0f53e488d","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"IPv6 support for Veritas Access Manila driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding IPv6 support and some modifications in Veritas Access"},{"line_number":10,"context_line":"API call for allow_access and deny_access."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I288a63d9c1e4a217aaf06c9a1ace3c0a49231dd6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_eb35f1f7","line":10,"range":{"start_line":9,"start_character":1,"end_line":10,"end_character":42},"updated":"2018-06-01 06:49:25.000000000","message":"Cloud you separate those to two patches? Do they have any related?","commit_id":"491249fab173ee0d081609e636099609570281b6"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"a2909799b4dc776c1905f71799adf595c148e006","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"IPv6 support for Veritas Access Manila driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Adding IPv6 support and some modifications in Veritas Access"},{"line_number":10,"context_line":"API call for allow_access and deny_access."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I288a63d9c1e4a217aaf06c9a1ace3c0a49231dd6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_30dd4a41","line":10,"range":{"start_line":9,"start_character":1,"end_line":10,"end_character":42},"in_reply_to":"5f7c97a3_eb35f1f7","updated":"2018-10-08 05:16:34.000000000","message":"They are not related.\nBut is it necessary, to open two separate patch.","commit_id":"491249fab173ee0d081609e636099609570281b6"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"5f07a6a4990bddf1e1136bb693472b0ef5c3da38","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Adding IPv6 support and some modifications in Veritas Access"},{"line_number":10,"context_line":"API call for allow_access and deny_access."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I288a63d9c1e4a217aaf06c9a1ace3c0a49231dd6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5f7c97a3_0b7e2dae","line":12,"range":{"start_line":12,"start_character":52,"end_line":12,"end_character":52},"updated":"2018-06-01 06:46:39.000000000","message":"This is a new feature, it would be better to add the bp for this.","commit_id":"491249fab173ee0d081609e636099609570281b6"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"a2909799b4dc776c1905f71799adf595c148e006","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Adding IPv6 support and some modifications in Veritas Access"},{"line_number":10,"context_line":"API call for allow_access and deny_access."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I288a63d9c1e4a217aaf06c9a1ace3c0a49231dd6"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3f79a3b5_3028ea31","line":12,"range":{"start_line":12,"start_character":52,"end_line":12,"end_character":52},"in_reply_to":"5f7c97a3_0b7e2dae","updated":"2018-10-08 05:16:34.000000000","message":"Done","commit_id":"491249fab173ee0d081609e636099609570281b6"}],"manila/share/drivers/veritas/veritas_isa.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"5f07a6a4990bddf1e1136bb693472b0ef5c3da38","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        self._update_object \u003d \u0027/objecttags\u0027"},{"line_number":124,"context_line":"        self.session \u003d None"},{"line_number":125,"context_line":"        self.host \u003d None"},{"line_number":126,"context_line":"        LOG.debug(\"ACCESSShareDriver called\")"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def do_setup(self, context):"},{"line_number":129,"context_line":"        \"\"\"Any initialization the share driver does while starting.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_ab6db903","line":126,"range":{"start_line":126,"start_character":45,"end_line":126,"end_character":45},"updated":"2018-06-01 06:46:39.000000000","message":"It should add \"self.ipv6_implemented \u003d True\" to let your driver support ipv6.\nexample: https://github.com/openstack/manila/blob/master/manila/share/drivers/lvm.py#L173","commit_id":"491249fab173ee0d081609e636099609570281b6"},{"author":{"_account_id":25838,"name":"Mayur Indalkar","email":"mayur.indalkar@veritas.com","username":"mayurindalkar"},"change_message_id":"a2909799b4dc776c1905f71799adf595c148e006","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        self._update_object \u003d \u0027/objecttags\u0027"},{"line_number":124,"context_line":"        self.session \u003d None"},{"line_number":125,"context_line":"        self.host \u003d None"},{"line_number":126,"context_line":"        LOG.debug(\"ACCESSShareDriver called\")"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"    def do_setup(self, context):"},{"line_number":129,"context_line":"        \"\"\"Any initialization the share driver does while starting.\"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_b0139a01","line":126,"range":{"start_line":126,"start_character":45,"end_line":126,"end_character":45},"in_reply_to":"5f7c97a3_ab6db903","updated":"2018-10-08 05:16:34.000000000","message":"Done","commit_id":"491249fab173ee0d081609e636099609570281b6"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3ce8e511754ff20ec80179c634fdf197be9c25f9","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        self._update_object \u003d \u0027/objecttags\u0027"},{"line_number":124,"context_line":"        self.session \u003d None"},{"line_number":125,"context_line":"        self.host \u003d None"},{"line_number":126,"context_line":"        self.ipv6_implemented \u003d True"},{"line_number":127,"context_line":"        LOG.debug(\"ACCESSShareDriver called\")"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"    def do_setup(self, context):"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_7247b81c","line":126,"range":{"start_line":126,"start_character":2,"end_line":126,"end_character":36},"updated":"2018-11-08 12:06:32.000000000","message":"you need to implement get_configured_ip_versions(). Your backend may have IPv4+IPv6, only IPv4 or only IPv6 configured, you should implement this function to obtain which protocol version your backend has configured.","commit_id":"5a6848704f4c03f85d9dcd69b56948838a401f43"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3ce8e511754ff20ec80179c634fdf197be9c25f9","unresolved":false,"context_lines":[{"line_number":343,"context_line":"    def _allow_access(self, context, share, access, share_server\u003dNone):"},{"line_number":344,"context_line":"        \"\"\"Give access of a share to an IP.\"\"\""},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"        sharename \u003d share[\u0027name\u0027]"},{"line_number":347,"context_line":"        va_sharename \u003d self._get_va_share_name(sharename)"},{"line_number":348,"context_line":"        va_sharepath \u003d self._get_va_share_path(va_sharename)"},{"line_number":349,"context_line":"        access_type \u003d access[\u0027access_type\u0027]"},{"line_number":350,"context_line":"        server \u003d access[\u0027access_to\u0027]"},{"line_number":351,"context_line":"        if access_type !\u003d \u0027ip\u0027:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_b260f0d1","line":348,"range":{"start_line":346,"start_character":1,"end_line":348,"end_character":60},"updated":"2018-11-08 12:06:32.000000000","message":"same as below","commit_id":"5a6848704f4c03f85d9dcd69b56948838a401f43"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3ce8e511754ff20ec80179c634fdf197be9c25f9","unresolved":false,"context_lines":[{"line_number":366,"context_line":"        nfs_client_info \u003d {}"},{"line_number":367,"context_line":"        nfs_client_info[\"client\"] \u003d server"},{"line_number":368,"context_line":"        nfs_client_info[\"exportOptions\"] \u003d access_level"},{"line_number":369,"context_line":"        nfs_share_details \u003d {}"},{"line_number":370,"context_line":"        nfs_share_details[\"fileSystemPath\"] \u003d va_sharepath"},{"line_number":371,"context_line":"        nfs_share_details[\"shareType\"] \u003d \"NFS\""},{"line_number":372,"context_line":"        nfs_share_details[\"shareDetails\"] \u003d [nfs_client_info]"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"        va_share_info \u003d {}"},{"line_number":375,"context_line":"        va_share_info[\"share\"] \u003d []"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_12e5243e","line":372,"range":{"start_line":369,"start_character":0,"end_line":372,"end_character":61},"updated":"2018-11-08 12:06:32.000000000","message":"you could do:\n\nnfs_share_details \u003d {\n   \u0027fileSystemPath\u0027: va_sharepath,\n   \u0027shareType\u0027: \u0027NFS\u0027,\n   ...\n}","commit_id":"5a6848704f4c03f85d9dcd69b56948838a401f43"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3ce8e511754ff20ec80179c634fdf197be9c25f9","unresolved":false,"context_lines":[{"line_number":363,"context_line":"        provider \u003d \u0027%s:%s\u0027 % (self.host, self._port)"},{"line_number":364,"context_line":"        data \u003d {}"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"        nfs_client_info \u003d {}"},{"line_number":367,"context_line":"        nfs_client_info[\"client\"] \u003d server"},{"line_number":368,"context_line":"        nfs_client_info[\"exportOptions\"] \u003d access_level"},{"line_number":369,"context_line":"        nfs_share_details \u003d {}"},{"line_number":370,"context_line":"        nfs_share_details[\"fileSystemPath\"] \u003d va_sharepath"},{"line_number":371,"context_line":"        nfs_share_details[\"shareType\"] \u003d \"NFS\""},{"line_number":372,"context_line":"        nfs_share_details[\"shareDetails\"] \u003d [nfs_client_info]"},{"line_number":373,"context_line":""},{"line_number":374,"context_line":"        va_share_info \u003d {}"},{"line_number":375,"context_line":"        va_share_info[\"share\"] \u003d []"},{"line_number":376,"context_line":"        va_share_info[\"client\"] \u003d server"},{"line_number":377,"context_line":""},{"line_number":378,"context_line":"        data[\"shareDetails\"] \u003d {\"share\": [nfs_share_details]}"},{"line_number":379,"context_line":""},{"line_number":380,"context_line":"        result \u003d self._access_api(self.session, provider, path,"},{"line_number":381,"context_line":"                                  json.dumps(data), \u0027POST\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_9265b4e4","line":378,"range":{"start_line":366,"start_character":0,"end_line":378,"end_character":61},"updated":"2018-11-08 12:06:32.000000000","message":"you could move this and the below code from _deny_access to another function to avoid code duplication","commit_id":"5a6848704f4c03f85d9dcd69b56948838a401f43"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3ce8e511754ff20ec80179c634fdf197be9c25f9","unresolved":false,"context_lines":[{"line_number":401,"context_line":"    def _deny_access(self, context, share, access, share_server\u003dNone):"},{"line_number":402,"context_line":"        \"\"\"Deny access to the share.\"\"\""},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"        sharename \u003d share[\u0027name\u0027]"},{"line_number":405,"context_line":"        va_sharename \u003d self._get_va_share_name(sharename)"},{"line_number":406,"context_line":"        va_sharepath \u003d self._get_va_share_path(va_sharename)"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"        server \u003d access[\u0027access_to\u0027]"},{"line_number":409,"context_line":"        access_type \u003d access[\u0027access_type\u0027]"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_525b9c21","line":406,"range":{"start_line":404,"start_character":0,"end_line":406,"end_character":60},"updated":"2018-11-08 12:06:32.000000000","message":"see above comment","commit_id":"5a6848704f4c03f85d9dcd69b56948838a401f43"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"3ce8e511754ff20ec80179c634fdf197be9c25f9","unresolved":false,"context_lines":[{"line_number":416,"context_line":"        provider \u003d \u0027%s:%s\u0027 % (self.host, self._port)"},{"line_number":417,"context_line":"        data \u003d {}"},{"line_number":418,"context_line":""},{"line_number":419,"context_line":"        nfs_client_info \u003d {}"},{"line_number":420,"context_line":"        nfs_client_info[\"client\"] \u003d server"},{"line_number":421,"context_line":"        nfs_share_details \u003d {}"},{"line_number":422,"context_line":"        nfs_share_details[\"fileSystemPath\"] \u003d va_sharepath"},{"line_number":423,"context_line":"        nfs_share_details[\"shareType\"] \u003d \"NFS\""},{"line_number":424,"context_line":"        nfs_share_details[\"shareDetails\"] \u003d [nfs_client_info]"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"        va_share_info \u003d {}"},{"line_number":427,"context_line":"        va_share_info[\"share\"] \u003d []"},{"line_number":428,"context_line":"        va_share_info[\"client\"] \u003d server"},{"line_number":429,"context_line":""},{"line_number":430,"context_line":"        data[\"shareDetails\"] \u003d {\"share\": [nfs_share_details]}"},{"line_number":431,"context_line":""},{"line_number":432,"context_line":"        result \u003d self._access_api(self.session, provider, path,"},{"line_number":433,"context_line":"                                  json.dumps(data), \u0027DELETE\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3f79a3b5_329aa0c3","line":430,"range":{"start_line":419,"start_character":0,"end_line":430,"end_character":61},"updated":"2018-11-08 12:06:32.000000000","message":"see above comment","commit_id":"5a6848704f4c03f85d9dcd69b56948838a401f43"}]}