)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"b0cdf6a1022ac00112274a7cdd8942284d6cd41f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     junboli \u003cjunbo85.li@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-06-07 16:13:35 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Retrive is_default value to fix empty dispty in CLI"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This bug is from path[1], when we use manila client to create"},{"line_number":10,"context_line":"a share type or share group type, the is_default value is always"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_998b001d","line":7,"range":{"start_line":7,"start_character":38,"end_line":7,"end_character":44},"updated":"2018-06-07 10:23:18.000000000","message":"?","commit_id":"92fb486559dfa6c0bf92914e5df2f2674c168209"},{"author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"change_message_id":"5ba67dcf14a09085e2931d8f6f7d2e4639ff0e52","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     junboli \u003cjunbo85.li@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-06-07 16:13:35 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Retrive is_default value to fix empty dispty in CLI"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This bug is from path[1], when we use manila client to create"},{"line_number":10,"context_line":"a share type or share group type, the is_default value is always"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_01b536ee","line":7,"range":{"start_line":7,"start_character":38,"end_line":7,"end_character":44},"in_reply_to":"5f7c97a3_998b001d","updated":"2018-06-07 10:54:37.000000000","message":"My mistake, should be display.","commit_id":"92fb486559dfa6c0bf92914e5df2f2674c168209"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"98cbb4676b05c743978294666950f65040bc98aa","unresolved":false,"context_lines":[{"line_number":12,"context_line":"or share group type."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"[1] Ib264d8422fe57701f990cbbf7ea5d1e90b8b0008"},{"line_number":15,"context_line":"Closes-bug: #1743941"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: Ia8bcb632591fc0b5438847b22ec59c2039ecf5f1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5f7c97a3_4d9cb8be","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":20},"updated":"2018-06-20 04:07:08.000000000","message":"Move this below, above Change-Id, I\u0027ve added manila to the bug.","commit_id":"09887947f377d7e618bb92efeb7b4da843a0524f"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1af7cba8fc9eafaa025a5752cef7758e8282c4de","unresolved":false,"context_lines":[{"line_number":1612,"context_line":"  required: true"},{"line_number":1613,"context_line":"  type: boolean"},{"line_number":1614,"context_line":"  min_version: 2.45"},{"line_number":1615,"context_line":"is_group_default:"},{"line_number":1616,"context_line":"  description: |"},{"line_number":1617,"context_line":"    Defines the share group type created is default or not. If the"},{"line_number":1618,"context_line":"    returning value is true, then it is the default share group type,"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f7c97a3_b5f34e9f","line":1615,"range":{"start_line":1615,"start_character":8,"end_line":1615,"end_character":9},"updated":"2018-06-07 23:21:41.000000000","message":"_type_","commit_id":"868c4b80b87f96eb1e747a3327f4482967b4f92a"}],"api-ref/source/samples/share-group-types-default-list-response.json":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1af7cba8fc9eafaa025a5752cef7758e8282c4de","unresolved":false,"context_lines":[{"line_number":5,"context_line":"        \"share_types\": [\"ecd11f4c-d811-4471-b656-c755c77e02ba\"],"},{"line_number":6,"context_line":"        \"id\": \"89861c2a-10bf-4013-bdd4-3d020466aee4\","},{"line_number":7,"context_line":"        \"name\": \"test_group_type\","},{"line_number":8,"context_line":"        \"is_default\": false"},{"line_number":9,"context_line":"    }"},{"line_number":10,"context_line":"}"}],"source_content_type":"application/json","patch_set":5,"id":"5f7c97a3_d5336a61","line":8,"range":{"start_line":8,"start_character":22,"end_line":8,"end_character":27},"updated":"2018-06-07 23:21:41.000000000","message":"this has got to be \"true\"","commit_id":"868c4b80b87f96eb1e747a3327f4482967b4f92a"}],"api-ref/source/samples/share-type-show-response.json":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1af7cba8fc9eafaa025a5752cef7758e8282c4de","unresolved":false,"context_lines":[{"line_number":10,"context_line":"        \"id\": \"2780fc88-526b-464a-a72c-ecb83f0e3929\","},{"line_number":11,"context_line":"        \"name\": \"default-share-type\","},{"line_number":12,"context_line":"        \"description\": \"manila share type\","},{"line_number":13,"context_line":"        \"is_default\": false"},{"line_number":14,"context_line":"    },"},{"line_number":15,"context_line":"    \"volume_type\": {"},{"line_number":16,"context_line":"        \"required_extra_specs\": {"}],"source_content_type":"application/json","patch_set":5,"id":"5f7c97a3_f50f8685","line":13,"range":{"start_line":13,"start_character":22,"end_line":13,"end_character":27},"updated":"2018-06-07 23:21:41.000000000","message":"lets set this to \"true\", because line#11 has this share type name as \"default-share-type\".","commit_id":"868c4b80b87f96eb1e747a3327f4482967b4f92a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1af7cba8fc9eafaa025a5752cef7758e8282c4de","unresolved":false,"context_lines":[{"line_number":23,"context_line":"        \"id\": \"2780fc88-526b-464a-a72c-ecb83f0e3929\","},{"line_number":24,"context_line":"        \"name\": \"default-share-type\","},{"line_number":25,"context_line":"        \"description\": \"manila share type\","},{"line_number":26,"context_line":"        \"is_default\": false"},{"line_number":27,"context_line":"    }"},{"line_number":28,"context_line":"}"}],"source_content_type":"application/json","patch_set":5,"id":"5f7c97a3_95265216","line":26,"range":{"start_line":26,"start_character":22,"end_line":26,"end_character":27},"updated":"2018-06-07 23:21:41.000000000","message":"same","commit_id":"868c4b80b87f96eb1e747a3327f4482967b4f92a"}],"api-ref/source/samples/share-types-default-list-response.json":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1af7cba8fc9eafaa025a5752cef7758e8282c4de","unresolved":false,"context_lines":[{"line_number":9,"context_line":"        },"},{"line_number":10,"context_line":"        \"id\": \"420e6a31-3f3d-4ed7-9d11-59450372182a\","},{"line_number":11,"context_line":"        \"name\": \"default\","},{"line_number":12,"context_line":"        \"is_default\": false,"},{"line_number":13,"context_line":"        \"description\": \"share type description\""},{"line_number":14,"context_line":"    },"},{"line_number":15,"context_line":"    \"volume_type\": {"}],"source_content_type":"application/json","patch_set":5,"id":"5f7c97a3_b5210eff","line":12,"range":{"start_line":12,"start_character":22,"end_line":12,"end_character":27},"updated":"2018-06-07 23:21:41.000000000","message":"this has to be \"true\"","commit_id":"868c4b80b87f96eb1e747a3327f4482967b4f92a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1af7cba8fc9eafaa025a5752cef7758e8282c4de","unresolved":false,"context_lines":[{"line_number":22,"context_line":"        },"},{"line_number":23,"context_line":"        \"id\": \"420e6a31-3f3d-4ed7-9d11-59450372182a\","},{"line_number":24,"context_line":"        \"name\": \"default\","},{"line_number":25,"context_line":"        \"is_default\": false,"},{"line_number":26,"context_line":"        \"description\": \"share type description\""},{"line_number":27,"context_line":"    }"},{"line_number":28,"context_line":"}"}],"source_content_type":"application/json","patch_set":5,"id":"5f7c97a3_751b76c9","line":25,"range":{"start_line":25,"start_character":22,"end_line":25,"end_character":27},"updated":"2018-06-07 23:21:41.000000000","message":"same","commit_id":"868c4b80b87f96eb1e747a3327f4482967b4f92a"}],"api-ref/source/samples/share-types-list-response.json":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1af7cba8fc9eafaa025a5752cef7758e8282c4de","unresolved":false,"context_lines":[{"line_number":10,"context_line":"            },"},{"line_number":11,"context_line":"            \"id\": \"420e6a31-3f3d-4ed7-9d11-59450372182a\","},{"line_number":12,"context_line":"            \"name\": \"default\","},{"line_number":13,"context_line":"            \"is_default\": false,"},{"line_number":14,"context_line":"            \"description\": \"share type description\""},{"line_number":15,"context_line":"        },"},{"line_number":16,"context_line":"        {"}],"source_content_type":"application/json","patch_set":5,"id":"5f7c97a3_d5812ac5","line":13,"range":{"start_line":13,"start_character":26,"end_line":13,"end_character":31},"updated":"2018-06-07 23:21:41.000000000","message":"\"true\"","commit_id":"868c4b80b87f96eb1e747a3327f4482967b4f92a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1af7cba8fc9eafaa025a5752cef7758e8282c4de","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            },"},{"line_number":44,"context_line":"            \"id\": \"420e6a31-3f3d-4ed7-9d11-59450372182a\","},{"line_number":45,"context_line":"            \"name\": \"default\","},{"line_number":46,"context_line":"            \"is_default\": false,"},{"line_number":47,"context_line":"            \"description\": \"share type description\""},{"line_number":48,"context_line":"        },"},{"line_number":49,"context_line":"        {"}],"source_content_type":"application/json","patch_set":5,"id":"5f7c97a3_f58466d5","line":46,"range":{"start_line":46,"start_character":26,"end_line":46,"end_character":31},"updated":"2018-06-07 23:21:41.000000000","message":"\"true\"","commit_id":"868c4b80b87f96eb1e747a3327f4482967b4f92a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b2c3605eeab527f5608ff5cd471b2425aa7ab801","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            },"},{"line_number":44,"context_line":"            \"id\": \"420e6a31-3f3d-4ed7-9d11-59450372182a\","},{"line_number":45,"context_line":"            \"name\": \"default\","},{"line_number":46,"context_line":"            \"is_default\": false,"},{"line_number":47,"context_line":"            \"description\": \"share type description\""},{"line_number":48,"context_line":"        },"},{"line_number":49,"context_line":"        {"}],"source_content_type":"application/json","patch_set":17,"id":"5f7c97a3_116e2964","line":46,"range":{"start_line":46,"start_character":26,"end_line":46,"end_character":31},"updated":"2018-07-23 21:00:05.000000000","message":"true","commit_id":"cd99566f87c97a2d2ba5b4743072a3cdd73c126d"}],"manila/api/openstack/api_version_request.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1af7cba8fc9eafaa025a5752cef7758e8282c4de","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    * 2.43 - Added filter search by extra spec for share type list."},{"line_number":117,"context_line":"    * 2.44 - Added \u0027ou\u0027 field to \u0027security_service\u0027 object."},{"line_number":118,"context_line":"    * 2.45 - Added \u0027is_default\u0027 field to \u0027share_type\u0027 and \u0027share_group_type\u0027"},{"line_number":119,"context_line":"             object."},{"line_number":120,"context_line":"\"\"\""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_1561e239","line":119,"range":{"start_line":119,"start_character":19,"end_line":119,"end_character":20},"updated":"2018-06-07 23:21:41.000000000","message":"objects","commit_id":"868c4b80b87f96eb1e747a3327f4482967b4f92a"}],"manila/api/openstack/rest_api_version_history.rst":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1af7cba8fc9eafaa025a5752cef7758e8282c4de","unresolved":false,"context_lines":[{"line_number":246,"context_line":"2.45"},{"line_number":247,"context_line":"----"},{"line_number":248,"context_line":"  Added \u0027is_default\u0027 field to \u0027share_type\u0027 and \u0027share_group_type\u0027"},{"line_number":249,"context_line":"  object."}],"source_content_type":"text/x-rst","patch_set":5,"id":"5f7c97a3_d55a8a81","line":249,"range":{"start_line":249,"start_character":8,"end_line":249,"end_character":9},"updated":"2018-06-07 23:21:41.000000000","message":"objects","commit_id":"868c4b80b87f96eb1e747a3327f4482967b4f92a"}],"manila/api/views/share_group_types.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b2c3605eeab527f5608ff5cd471b2425aa7ab801","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        default_name \u003d CONF.default_share_group_type"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        if default_name is not None:"},{"line_number":57,"context_line":"            is_default \u003d True if default_name \u003d\u003d type_name else False"},{"line_number":58,"context_line":"        share_group_type_dict[\u0027is_default\u0027] \u003d is_default"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_71075d72","line":57,"range":{"start_line":57,"start_character":25,"end_line":57,"end_character":69},"updated":"2018-07-23 21:00:05.000000000","message":"default_name \u003d\u003d type_name","commit_id":"cd99566f87c97a2d2ba5b4743072a3cdd73c126d"}],"manila/api/views/types.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"f08c1eef4a7b0d07c3df4eb8591031c5c0638ff3","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            \u0027id\u0027: share_type.get(\u0027id\u0027),"},{"line_number":59,"context_line":"            \u0027name\u0027: share_type.get(\u0027name\u0027),"},{"line_number":60,"context_line":"            \u0027extra_specs\u0027: extra_specs,"},{"line_number":61,"context_line":"            \u0027is_default_type\u0027: is_default_type,"},{"line_number":62,"context_line":"            \u0027required_extra_specs\u0027: required_extra_specs,"},{"line_number":63,"context_line":"        }"},{"line_number":64,"context_line":"        self.update_versioned_resource_dict(request, trimmed, share_type)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_65fbb178","line":61,"range":{"start_line":61,"start_character":12,"end_line":61,"end_character":47},"updated":"2018-03-29 03:05:57.000000000","message":"This could broke the tests or other software that use the previous API, because we don\u0027t have \u0027is_default_type\u0027 response in previous API version.","commit_id":"1663715ae11f671b30691c65d39b169accbd1dc1"},{"author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"change_message_id":"ec7f03b550e619fb46a4288cd2ab66129cda87ca","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            \u0027id\u0027: share_type.get(\u0027id\u0027),"},{"line_number":59,"context_line":"            \u0027name\u0027: share_type.get(\u0027name\u0027),"},{"line_number":60,"context_line":"            \u0027extra_specs\u0027: extra_specs,"},{"line_number":61,"context_line":"            \u0027is_default_type\u0027: is_default_type,"},{"line_number":62,"context_line":"            \u0027required_extra_specs\u0027: required_extra_specs,"},{"line_number":63,"context_line":"        }"},{"line_number":64,"context_line":"        self.update_versioned_resource_dict(request, trimmed, share_type)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_0a3b0beb","line":61,"range":{"start_line":61,"start_character":12,"end_line":61,"end_character":47},"in_reply_to":"5f7c97a3_ab49cf60","updated":"2018-05-23 00:29:11.000000000","message":"Thanks Goutham Pacha Ravi, I will add microversion for this change later on, but it looks like this issue also exists in do_share_group_type_create. Let me check all and finish up in one review.","commit_id":"1663715ae11f671b30691c65d39b169accbd1dc1"},{"author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"change_message_id":"3d5b5a93764e82d99869875d45f91623796334a4","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            \u0027id\u0027: share_type.get(\u0027id\u0027),"},{"line_number":59,"context_line":"            \u0027name\u0027: share_type.get(\u0027name\u0027),"},{"line_number":60,"context_line":"            \u0027extra_specs\u0027: extra_specs,"},{"line_number":61,"context_line":"            \u0027is_default_type\u0027: is_default_type,"},{"line_number":62,"context_line":"            \u0027required_extra_specs\u0027: required_extra_specs,"},{"line_number":63,"context_line":"        }"},{"line_number":64,"context_line":"        self.update_versioned_resource_dict(request, trimmed, share_type)"}],"source_content_type":"text/x-python","patch_set":2,"id":"bf659307_fe8bce1b","line":61,"range":{"start_line":61,"start_character":12,"end_line":61,"end_character":47},"in_reply_to":"bf659307_65fbb178","updated":"2018-03-29 05:50:43.000000000","message":"This is adding response field, so should be compatible with previous API version.","commit_id":"1663715ae11f671b30691c65d39b169accbd1dc1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"16102590c64883c2f353e0475391053de064f61b","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            \u0027id\u0027: share_type.get(\u0027id\u0027),"},{"line_number":59,"context_line":"            \u0027name\u0027: share_type.get(\u0027name\u0027),"},{"line_number":60,"context_line":"            \u0027extra_specs\u0027: extra_specs,"},{"line_number":61,"context_line":"            \u0027is_default_type\u0027: is_default_type,"},{"line_number":62,"context_line":"            \u0027required_extra_specs\u0027: required_extra_specs,"},{"line_number":63,"context_line":"        }"},{"line_number":64,"context_line":"        self.update_versioned_resource_dict(request, trimmed, share_type)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_ab49cf60","line":61,"range":{"start_line":61,"start_character":12,"end_line":61,"end_character":47},"in_reply_to":"bf659307_fe8bce1b","updated":"2018-05-21 17:56:30.000000000","message":"Junbo: This change is reasonable, but it requires a microversion bump.","commit_id":"1663715ae11f671b30691c65d39b169accbd1dc1"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1af7cba8fc9eafaa025a5752cef7758e8282c4de","unresolved":false,"context_lines":[{"line_number":30,"context_line":"        \"add_is_public_attr_core_api_like\","},{"line_number":31,"context_line":"        \"add_is_public_attr_extension_like\","},{"line_number":32,"context_line":"        \"add_inferred_optional_extra_specs\","},{"line_number":33,"context_line":"        \"add_description_attr\","},{"line_number":34,"context_line":"    ]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    def show(self, request, share_type, brief\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_75de16db","line":33,"range":{"start_line":33,"start_character":0,"end_line":33,"end_character":31},"updated":"2018-06-07 23:21:41.000000000","message":"missing here: \"add_is_default_attr\"","commit_id":"868c4b80b87f96eb1e747a3327f4482967b4f92a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b2c3605eeab527f5608ff5cd471b2425aa7ab801","unresolved":false,"context_lines":[{"line_number":116,"context_line":"        default_name \u003d CONF.default_share_type"},{"line_number":117,"context_line":""},{"line_number":118,"context_line":"        if default_name is not None:"},{"line_number":119,"context_line":"            is_default \u003d True if default_name \u003d\u003d type_name else False"},{"line_number":120,"context_line":"        share_type_dict[\u0027is_default\u0027] \u003d is_default"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_910c7994","line":119,"range":{"start_line":119,"start_character":25,"end_line":119,"end_character":69},"updated":"2018-07-23 21:00:05.000000000","message":"default_name \u003d\u003d type_name","commit_id":"cd99566f87c97a2d2ba5b4743072a3cdd73c126d"}],"manila/tests/api/v2/test_share_group_types.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"98cbb4676b05c743978294666950f65040bc98aa","unresolved":false,"context_lines":[{"line_number":433,"context_line":"            webob.exc.HTTPNotFound,"},{"line_number":434,"context_line":"            self.controller._create, req, fake_body)"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    @ddt.data((\u00272.45\u0027, True), (\u00272.45\u0027, False))"},{"line_number":437,"context_line":"    @ddt.unpack"},{"line_number":438,"context_line":"    def test_share_group_types_is_default_false(self, version, admin):"},{"line_number":439,"context_line":"        # create share group type"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_0d856007","line":436,"range":{"start_line":436,"start_character":5,"end_line":436,"end_character":46},"updated":"2018-06-20 04:07:08.000000000","message":"test the prior microversion, i.e, 2.44 to verify that the key is not present","commit_id":"09887947f377d7e618bb92efeb7b4da843a0524f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c947984978ce61ccc27ce0c197ea9235623e1ad1","unresolved":false,"context_lines":[{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    @ddt.data((\u00272.45\u0027, True), (\u00272.45\u0027, False))"},{"line_number":437,"context_line":"    @ddt.unpack"},{"line_number":438,"context_line":"    def test_share_group_types_is_default_false(self, version, admin):"},{"line_number":439,"context_line":"        # create share group type"},{"line_number":440,"context_line":"        fake_type \u003d copy.deepcopy(GROUP_TYPE_1)"},{"line_number":441,"context_line":"        fake_type[\u0027share_types\u0027] \u003d [{\u0027share_type_id\u0027: SHARE_TYPE_ID}]"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_8d2730c8","line":438,"range":{"start_line":438,"start_character":0,"end_line":438,"end_character":70},"updated":"2018-06-20 04:08:04.000000000","message":"You can combine test_share_group_types_is_default_false and test_share_group_types_is_default_true and mock the value of the configuration based on a ddt value.. and do the same thing to test all of the API methods..","commit_id":"09887947f377d7e618bb92efeb7b4da843a0524f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"98cbb4676b05c743978294666950f65040bc98aa","unresolved":false,"context_lines":[{"line_number":451,"context_line":"            \u0027share_types\u0027: [SHARE_TYPE_ID],"},{"line_number":452,"context_line":"        }}"},{"line_number":453,"context_line":"        res_dict \u003d self.controller._create(req, fake_body)"},{"line_number":454,"context_line":"        self.assertFalse(res_dict[\u0027share_group_type\u0027][\u0027is_default\u0027])"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        # list share group type"},{"line_number":457,"context_line":"        fake_types \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_edafc47a","line":454,"range":{"start_line":454,"start_character":13,"end_line":454,"end_character":24},"updated":"2018-06-20 04:07:08.000000000","message":"replace with assertEqual(False, value)","commit_id":"09887947f377d7e618bb92efeb7b4da843a0524f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"98cbb4676b05c743978294666950f65040bc98aa","unresolved":false,"context_lines":[{"line_number":453,"context_line":"        res_dict \u003d self.controller._create(req, fake_body)"},{"line_number":454,"context_line":"        self.assertFalse(res_dict[\u0027share_group_type\u0027][\u0027is_default\u0027])"},{"line_number":455,"context_line":""},{"line_number":456,"context_line":"        # list share group type"},{"line_number":457,"context_line":"        fake_types \u003d {"},{"line_number":458,"context_line":"            GROUP_TYPE_1[\u0027name\u0027]: GROUP_TYPE_1,"},{"line_number":459,"context_line":"            GROUP_TYPE_2[\u0027name\u0027]: GROUP_TYPE_2,"},{"line_number":460,"context_line":"        }"},{"line_number":461,"context_line":"        self.mock_object("},{"line_number":462,"context_line":"            share_group_types, \u0027get_all\u0027,"},{"line_number":463,"context_line":"            mock.Mock(return_value\u003dfake_types))"},{"line_number":464,"context_line":"        req \u003d fake_request("},{"line_number":465,"context_line":"            \u0027/v2/fake/share-group-types?is_public\u003dall\u0027,"},{"line_number":466,"context_line":"            version\u003dversion,"},{"line_number":467,"context_line":"            admin\u003dadmin)"},{"line_number":468,"context_line":"        res_dict \u003d self.controller.index(req)"},{"line_number":469,"context_line":"        for res in res_dict[\u0027share_group_types\u0027]:"},{"line_number":470,"context_line":"            self.assertFalse(res[\u0027is_default\u0027])"},{"line_number":471,"context_line":"        self.assertEqual(2, len(res_dict[\u0027share_group_types\u0027]))"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"        # show share group type"},{"line_number":474,"context_line":"        self.mock_object("}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_2db61cde","line":471,"range":{"start_line":456,"start_character":8,"end_line":471,"end_character":63},"updated":"2018-06-20 04:07:08.000000000","message":"Please separate this out into its own unit test\n\n    test_share_group_types_create_with_is_default_key()","commit_id":"09887947f377d7e618bb92efeb7b4da843a0524f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"98cbb4676b05c743978294666950f65040bc98aa","unresolved":false,"context_lines":[{"line_number":470,"context_line":"            self.assertFalse(res[\u0027is_default\u0027])"},{"line_number":471,"context_line":"        self.assertEqual(2, len(res_dict[\u0027share_group_types\u0027]))"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"        # show share group type"},{"line_number":474,"context_line":"        self.mock_object("},{"line_number":475,"context_line":"            share_group_types, \u0027get\u0027,"},{"line_number":476,"context_line":"            mock.Mock(return_value\u003dGROUP_TYPE_2))"},{"line_number":477,"context_line":"        req \u003d fake_request(\u0027/v2/fake/group-types/%s\u0027 % GROUP_TYPE_2[\u0027id\u0027],"},{"line_number":478,"context_line":"                           version\u003dversion,"},{"line_number":479,"context_line":"                           admin\u003dadmin)"},{"line_number":480,"context_line":"        res_dict \u003d self.controller.show(req, GROUP_TYPE_2[\u0027id\u0027])"},{"line_number":481,"context_line":"        self.assertFalse(res_dict[\u0027share_group_type\u0027][\u0027is_default\u0027])"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"    @ddt.data((\u00272.45\u0027, True), (\u00272.45\u0027, False))"},{"line_number":484,"context_line":"    @ddt.unpack"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_8dbe50ac","line":481,"range":{"start_line":473,"start_character":0,"end_line":481,"end_character":68},"updated":"2018-06-20 04:07:08.000000000","message":"Please separate this out into its own unit test\n\n   test_share_group_types_show_with_is_default_key","commit_id":"09887947f377d7e618bb92efeb7b4da843a0524f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"98cbb4676b05c743978294666950f65040bc98aa","unresolved":false,"context_lines":[{"line_number":480,"context_line":"        res_dict \u003d self.controller.show(req, GROUP_TYPE_2[\u0027id\u0027])"},{"line_number":481,"context_line":"        self.assertFalse(res_dict[\u0027share_group_type\u0027][\u0027is_default\u0027])"},{"line_number":482,"context_line":""},{"line_number":483,"context_line":"    @ddt.data((\u00272.45\u0027, True), (\u00272.45\u0027, False))"},{"line_number":484,"context_line":"    @ddt.unpack"},{"line_number":485,"context_line":"    def test_share_group_types_is_default_true(self, version, admin):"},{"line_number":486,"context_line":"        # create share group type"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_0de800b1","line":483,"range":{"start_line":483,"start_character":0,"end_line":483,"end_character":46},"updated":"2018-06-20 04:07:08.000000000","message":"test the prior microversion, i.e, 2.44 to verify that the key is not present","commit_id":"09887947f377d7e618bb92efeb7b4da843a0524f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"98cbb4676b05c743978294666950f65040bc98aa","unresolved":false,"context_lines":[{"line_number":482,"context_line":""},{"line_number":483,"context_line":"    @ddt.data((\u00272.45\u0027, True), (\u00272.45\u0027, False))"},{"line_number":484,"context_line":"    @ddt.unpack"},{"line_number":485,"context_line":"    def test_share_group_types_is_default_true(self, version, admin):"},{"line_number":486,"context_line":"        # create share group type"},{"line_number":487,"context_line":"        fake_type \u003d copy.deepcopy(GROUP_TYPE_1)"},{"line_number":488,"context_line":"        default_type_name \u003d fake_type[\u0027name\u0027]"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_8dd3b001","line":485,"range":{"start_line":485,"start_character":8,"end_line":485,"end_character":46},"updated":"2018-06-20 04:07:08.000000000","message":"test_share_group_types_index_with_is_default_key","commit_id":"09887947f377d7e618bb92efeb7b4da843a0524f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"98cbb4676b05c743978294666950f65040bc98aa","unresolved":false,"context_lines":[{"line_number":500,"context_line":"            \u0027share_types\u0027: [SHARE_TYPE_ID],"},{"line_number":501,"context_line":"        }}"},{"line_number":502,"context_line":"        res_dict \u003d self.controller._create(req, fake_body)"},{"line_number":503,"context_line":"        self.assertTrue(res_dict[\u0027share_group_type\u0027][\u0027is_default\u0027])"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"        # list share group type"},{"line_number":506,"context_line":"        fake_types \u003d {"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_cdc9a851","line":503,"range":{"start_line":503,"start_character":13,"end_line":503,"end_character":23},"updated":"2018-06-20 04:07:08.000000000","message":"see comment above, same here, replace assertTrue with assertEqual(True, value)","commit_id":"09887947f377d7e618bb92efeb7b4da843a0524f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"98cbb4676b05c743978294666950f65040bc98aa","unresolved":false,"context_lines":[{"line_number":502,"context_line":"        res_dict \u003d self.controller._create(req, fake_body)"},{"line_number":503,"context_line":"        self.assertTrue(res_dict[\u0027share_group_type\u0027][\u0027is_default\u0027])"},{"line_number":504,"context_line":""},{"line_number":505,"context_line":"        # list share group type"},{"line_number":506,"context_line":"        fake_types \u003d {"},{"line_number":507,"context_line":"            GROUP_TYPE_1[\u0027name\u0027]: GROUP_TYPE_1,"},{"line_number":508,"context_line":"            GROUP_TYPE_2[\u0027name\u0027]: GROUP_TYPE_2,"},{"line_number":509,"context_line":"        }"},{"line_number":510,"context_line":"        self.mock_object("},{"line_number":511,"context_line":"            share_group_types, \u0027get_all\u0027,"},{"line_number":512,"context_line":"            mock.Mock(return_value\u003dfake_types))"},{"line_number":513,"context_line":"        req \u003d fake_request("},{"line_number":514,"context_line":"            \u0027/v2/fake/share-group-types?is_public\u003dall\u0027,"},{"line_number":515,"context_line":"            version\u003dversion,"},{"line_number":516,"context_line":"            admin\u003dadmin)"},{"line_number":517,"context_line":"        res_dict \u003d self.controller.index(req)"},{"line_number":518,"context_line":"        self.assertEqual(2, len(res_dict[\u0027share_group_types\u0027]))"},{"line_number":519,"context_line":"        for res in res_dict[\u0027share_group_types\u0027]:"},{"line_number":520,"context_line":"            if res[\u0027name\u0027] \u003d\u003d default_type_name:"},{"line_number":521,"context_line":"                self.assertTrue(res[\u0027is_default\u0027])"},{"line_number":522,"context_line":"            else:"},{"line_number":523,"context_line":"                self.assertFalse(res[\u0027is_default\u0027])"},{"line_number":524,"context_line":"        self.assertEqual(2, len(res_dict[\u0027share_group_types\u0027]))"},{"line_number":525,"context_line":""},{"line_number":526,"context_line":"        # show share group type"},{"line_number":527,"context_line":"        self.mock_object("}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_2d04dc7d","line":524,"range":{"start_line":505,"start_character":8,"end_line":524,"end_character":63},"updated":"2018-06-20 04:07:08.000000000","message":"Please separate this out into its own unit test\n\n   test_share_group_types_list_with_is_default_key","commit_id":"09887947f377d7e618bb92efeb7b4da843a0524f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"98cbb4676b05c743978294666950f65040bc98aa","unresolved":false,"context_lines":[{"line_number":523,"context_line":"                self.assertFalse(res[\u0027is_default\u0027])"},{"line_number":524,"context_line":"        self.assertEqual(2, len(res_dict[\u0027share_group_types\u0027]))"},{"line_number":525,"context_line":""},{"line_number":526,"context_line":"        # show share group type"},{"line_number":527,"context_line":"        self.mock_object("},{"line_number":528,"context_line":"            share_group_types, \u0027get\u0027,"},{"line_number":529,"context_line":"            mock.Mock(return_value\u003dGROUP_TYPE_1))"},{"line_number":530,"context_line":"        req \u003d fake_request(\u0027/v2/fake/group-types/%s\u0027 % GROUP_TYPE_2[\u0027id\u0027],"},{"line_number":531,"context_line":"                           version\u003dversion,"},{"line_number":532,"context_line":"                           admin\u003dadmin)"},{"line_number":533,"context_line":"        res_dict \u003d self.controller.show(req, GROUP_TYPE_2[\u0027id\u0027])"},{"line_number":534,"context_line":"        self.assertTrue(res_dict[\u0027share_group_type\u0027][\u0027is_default\u0027])"},{"line_number":535,"context_line":""},{"line_number":536,"context_line":""},{"line_number":537,"context_line":"class ShareGroupTypeAccessTest(test.TestCase):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_edfd846e","line":534,"range":{"start_line":526,"start_character":0,"end_line":534,"end_character":67},"updated":"2018-06-20 04:07:08.000000000","message":"Please separate this out into its own unit test\n\n    test_share_group_types_show_with_is_default_key","commit_id":"09887947f377d7e618bb92efeb7b4da843a0524f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b174c80c20a98e6fa6fa0e6463eb3a4c0449762d","unresolved":false,"context_lines":[{"line_number":434,"context_line":"            self.controller._create, req, fake_body)"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":"    @ddt.data((\u00272.44\u0027, True), (\u00272.44\u0027, False))"},{"line_number":437,"context_line":"    @ddt.data((\u00272.45\u0027, True), (\u00272.45\u0027, False))"},{"line_number":438,"context_line":"    @ddt.unpack"},{"line_number":439,"context_line":"    def test_share_group_types_create_with_is_default_key(self,"},{"line_number":440,"context_line":"                                                          version,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5f7c97a3_848dd47d","line":437,"range":{"start_line":437,"start_character":4,"end_line":437,"end_character":46},"updated":"2018-07-17 20:29:04.000000000","message":"This annotation is ignored\n\nSee: http://logs.openstack.org/06/557206/10/check/openstack-tox-py27/741c065/job-output.txt.gz\n\nyou should combine it into one:\n\n @ddt.data((\u00272.44\u0027, True), (\u00272.44\u0027, False), \n           (\u00272.45\u0027, True), (\u00272.45\u0027, False))","commit_id":"c9616303aeb3dd3d293f227091201c78d195c6c8"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"248548ff858389936da3838e34c2ccc68f7b737a","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        res_dict \u003d self.controller._create(req, fake_body)"},{"line_number":456,"context_line":"        if version \u003e\u003d \u00272.45\u0027:"},{"line_number":457,"context_line":"            self.assertIn(\u0027is_default\u0027, res_dict[\u0027share_group_type\u0027])"},{"line_number":458,"context_line":"            self.assertIs(res_dict[\u0027share_group_type\u0027][\u0027is_default\u0027], False)"},{"line_number":459,"context_line":"        else:"},{"line_number":460,"context_line":"            self.assertNotIn(\u0027is_default\u0027, res_dict[\u0027share_group_type\u0027])"},{"line_number":461,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_3d3e13e3","line":458,"range":{"start_line":458,"start_character":26,"end_line":458,"end_character":68},"updated":"2018-07-18 04:08:48.000000000","message":"Is there a test for res_dict[\u0027share_group_type\u0027][\u0027is_default\u0027] is equal to True?","commit_id":"e379e23242a57e2caa04a7688860117909626125"},{"author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"change_message_id":"1b8db964efa4b66399eb9c64d0641b57d466c09b","unresolved":false,"context_lines":[{"line_number":455,"context_line":"        res_dict \u003d self.controller._create(req, fake_body)"},{"line_number":456,"context_line":"        if version \u003e\u003d \u00272.45\u0027:"},{"line_number":457,"context_line":"            self.assertIn(\u0027is_default\u0027, res_dict[\u0027share_group_type\u0027])"},{"line_number":458,"context_line":"            self.assertIs(res_dict[\u0027share_group_type\u0027][\u0027is_default\u0027], False)"},{"line_number":459,"context_line":"        else:"},{"line_number":460,"context_line":"            self.assertNotIn(\u0027is_default\u0027, res_dict[\u0027share_group_type\u0027])"},{"line_number":461,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"5f7c97a3_18fd653a","line":458,"range":{"start_line":458,"start_character":26,"end_line":458,"end_character":68},"in_reply_to":"5f7c97a3_3d3e13e3","updated":"2018-07-18 05:13:26.000000000","message":"Done","commit_id":"e379e23242a57e2caa04a7688860117909626125"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f905ecdefeb11bfb9491fcae65d90cdef7c9bc73","unresolved":false,"context_lines":[{"line_number":468,"context_line":"        res_dict \u003d self.controller._create(req, fake_body)"},{"line_number":469,"context_line":"        if version \u003e\u003d \u00272.45\u0027:"},{"line_number":470,"context_line":"            self.assertIn(\u0027is_default\u0027, res_dict[\u0027share_group_type\u0027])"},{"line_number":471,"context_line":"            self.assertIs(res_dict[\u0027share_group_type\u0027][\u0027is_default\u0027], False)"},{"line_number":472,"context_line":"        else:"},{"line_number":473,"context_line":"            self.assertNotIn(\u0027is_default\u0027, res_dict[\u0027share_group_type\u0027])"},{"line_number":474,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5f7c97a3_6e5d7846","line":471,"range":{"start_line":471,"start_character":12,"end_line":471,"end_character":76},"updated":"2018-07-20 00:44:20.000000000","message":"self.assertIs(False, res_dict[\u0027share_group_type\u0027][\u0027is_default\u0027])","commit_id":"c5cea9510a62e908ca53b44d3f7d7d83c23139d5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f905ecdefeb11bfb9491fcae65d90cdef7c9bc73","unresolved":false,"context_lines":[{"line_number":492,"context_line":"        res_dict \u003d self.controller._create(req, fake_body)"},{"line_number":493,"context_line":"        if version \u003e\u003d \u00272.45\u0027:"},{"line_number":494,"context_line":"            self.assertIn(\u0027is_default\u0027, res_dict[\u0027share_group_type\u0027])"},{"line_number":495,"context_line":"            self.assertIs(res_dict[\u0027share_group_type\u0027][\u0027is_default\u0027], True)"},{"line_number":496,"context_line":"        else:"},{"line_number":497,"context_line":"            self.assertNotIn(\u0027is_default\u0027, res_dict[\u0027share_group_type\u0027])"},{"line_number":498,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5f7c97a3_8e581457","line":495,"range":{"start_line":495,"start_character":12,"end_line":495,"end_character":75},"updated":"2018-07-20 00:44:20.000000000","message":"self.assertIs(True, res_dict[\u0027share_group_type\u0027][\u0027is_default\u0027])","commit_id":"c5cea9510a62e908ca53b44d3f7d7d83c23139d5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f905ecdefeb11bfb9491fcae65d90cdef7c9bc73","unresolved":false,"context_lines":[{"line_number":515,"context_line":"        for res in res_dict[\u0027share_group_types\u0027]:"},{"line_number":516,"context_line":"            if version \u003e\u003d \u00272.45\u0027:"},{"line_number":517,"context_line":"                self.assertIn(\u0027is_default\u0027, res)"},{"line_number":518,"context_line":"                self.assertIs(res[\u0027is_default\u0027], False)"},{"line_number":519,"context_line":"            else:"},{"line_number":520,"context_line":"                self.assertNotIn(\u0027is_default\u0027, res)"},{"line_number":521,"context_line":"        self.assertEqual(2, len(res_dict[\u0027share_group_types\u0027]))"}],"source_content_type":"text/x-python","patch_set":13,"id":"5f7c97a3_2e53003c","line":518,"range":{"start_line":518,"start_character":16,"end_line":518,"end_character":55},"updated":"2018-07-20 00:44:20.000000000","message":"self.assertIs(False, res[\u0027is_default\u0027])","commit_id":"c5cea9510a62e908ca53b44d3f7d7d83c23139d5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f905ecdefeb11bfb9491fcae65d90cdef7c9bc73","unresolved":false,"context_lines":[{"line_number":533,"context_line":"        res_dict \u003d self.controller.show(req, GROUP_TYPE_2[\u0027id\u0027])"},{"line_number":534,"context_line":"        if version \u003e\u003d \u00272.45\u0027:"},{"line_number":535,"context_line":"            self.assertIn(\u0027is_default\u0027, res_dict[\u0027share_group_type\u0027])"},{"line_number":536,"context_line":"            self.assertIs(res_dict[\u0027share_group_type\u0027][\u0027is_default\u0027], False)"},{"line_number":537,"context_line":"        else:"},{"line_number":538,"context_line":"            self.assertNotIn(\u0027is_default\u0027, res_dict[\u0027share_group_type\u0027])"},{"line_number":539,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5f7c97a3_4e4e7c90","line":536,"range":{"start_line":536,"start_character":12,"end_line":536,"end_character":76},"updated":"2018-07-20 00:44:20.000000000","message":"self.assertIs(False, res_dict[\u0027share_group_type\u0027][\u0027is_default\u0027])","commit_id":"c5cea9510a62e908ca53b44d3f7d7d83c23139d5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b2c3605eeab527f5608ff5cd471b2425aa7ab801","unresolved":false,"context_lines":[{"line_number":466,"context_line":"            \u0027share_types\u0027: [SHARE_TYPE_ID],"},{"line_number":467,"context_line":"        }}"},{"line_number":468,"context_line":"        res_dict \u003d self.controller._create(req, fake_body)"},{"line_number":469,"context_line":"        if version \u003e\u003d \u00272.46\u0027:"},{"line_number":470,"context_line":"            self.assertIn(\u0027is_default\u0027, res_dict[\u0027share_group_type\u0027])"},{"line_number":471,"context_line":"            self.assertIs(False, res_dict[\u0027share_group_type\u0027][\u0027is_default\u0027])"},{"line_number":472,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_d1775107","line":469,"range":{"start_line":469,"start_character":8,"end_line":469,"end_character":28},"updated":"2018-07-23 21:00:05.000000000","message":"if self.is_microversion_ge(version, \u00272.46\u0027)","commit_id":"cd99566f87c97a2d2ba5b4743072a3cdd73c126d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b2c3605eeab527f5608ff5cd471b2425aa7ab801","unresolved":false,"context_lines":[{"line_number":490,"context_line":"            \u0027share_types\u0027: [SHARE_TYPE_ID],"},{"line_number":491,"context_line":"        }}"},{"line_number":492,"context_line":"        res_dict \u003d self.controller._create(req, fake_body)"},{"line_number":493,"context_line":"        if version \u003e\u003d \u00272.46\u0027:"},{"line_number":494,"context_line":"            self.assertIn(\u0027is_default\u0027, res_dict[\u0027share_group_type\u0027])"},{"line_number":495,"context_line":"            self.assertIs(True, res_dict[\u0027share_group_type\u0027][\u0027is_default\u0027])"},{"line_number":496,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_116dc92e","line":493,"range":{"start_line":493,"start_character":8,"end_line":493,"end_character":29},"updated":"2018-07-23 21:00:05.000000000","message":"self.is_microversion_ge(version, \u00272.46\u0027)","commit_id":"cd99566f87c97a2d2ba5b4743072a3cdd73c126d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b2c3605eeab527f5608ff5cd471b2425aa7ab801","unresolved":false,"context_lines":[{"line_number":513,"context_line":"            admin\u003dadmin)"},{"line_number":514,"context_line":"        res_dict \u003d self.controller.index(req)"},{"line_number":515,"context_line":"        for res in res_dict[\u0027share_group_types\u0027]:"},{"line_number":516,"context_line":"            if version \u003e\u003d \u00272.46\u0027:"},{"line_number":517,"context_line":"                self.assertIn(\u0027is_default\u0027, res)"},{"line_number":518,"context_line":"                self.assertIs(False, res[\u0027is_default\u0027])"},{"line_number":519,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_514ca1c8","line":516,"range":{"start_line":516,"start_character":12,"end_line":516,"end_character":33},"updated":"2018-07-23 21:00:05.000000000","message":"self.is_microversion_ge(version, \u00272.46\u0027)","commit_id":"cd99566f87c97a2d2ba5b4743072a3cdd73c126d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b2c3605eeab527f5608ff5cd471b2425aa7ab801","unresolved":false,"context_lines":[{"line_number":531,"context_line":"                           version\u003dversion,"},{"line_number":532,"context_line":"                           admin\u003dadmin)"},{"line_number":533,"context_line":"        res_dict \u003d self.controller.show(req, GROUP_TYPE_2[\u0027id\u0027])"},{"line_number":534,"context_line":"        if version \u003e\u003d \u00272.46\u0027:"},{"line_number":535,"context_line":"            self.assertIn(\u0027is_default\u0027, res_dict[\u0027share_group_type\u0027])"},{"line_number":536,"context_line":"            self.assertIs(False, res_dict[\u0027share_group_type\u0027][\u0027is_default\u0027])"},{"line_number":537,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_b1c095fb","line":534,"range":{"start_line":534,"start_character":8,"end_line":534,"end_character":29},"updated":"2018-07-23 21:00:05.000000000","message":"self.is_microversion_ge(version, \u00272.46\u0027)","commit_id":"cd99566f87c97a2d2ba5b4743072a3cdd73c126d"}],"manila/tests/api/v2/test_share_types.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1af7cba8fc9eafaa025a5752cef7758e8282c4de","unresolved":false,"context_lines":[{"line_number":490,"context_line":"        observed \u003d sorted(observed, key\u003dlambda item: item[\u0027id\u0027])"},{"line_number":491,"context_line":"        for d1, d2 in zip(expected, observed):"},{"line_number":492,"context_line":"            self.assertEqual(d1[\u0027id\u0027], d2[\u0027id\u0027])"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"    @ddt.data((\u00272.45\u0027, True), (\u00272.45\u0027, False))"},{"line_number":495,"context_line":"    @ddt.unpack"},{"line_number":496,"context_line":"    def test_share_types_is_default(self, version, admin):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_d5b60a8b","line":493,"range":{"start_line":493,"start_character":0,"end_line":493,"end_character":0},"updated":"2018-06-07 23:21:41.000000000","message":"Your changes affect all share type APIs, can you please add tests for the remaining APIs: show, list and create share types","commit_id":"868c4b80b87f96eb1e747a3327f4482967b4f92a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1af7cba8fc9eafaa025a5752cef7758e8282c4de","unresolved":false,"context_lines":[{"line_number":501,"context_line":"                                      version\u003dversion,"},{"line_number":502,"context_line":"                                      use_admin_context\u003dadmin)"},{"line_number":503,"context_line":""},{"line_number":504,"context_line":"        res_dict \u003d self.controller.default(req)"},{"line_number":505,"context_line":"        if self.is_microversion_ge(version, \u00272.45\u0027):"},{"line_number":506,"context_line":"            res_dict[\u0027share_type\u0027][\u0027is_default\u0027] \u003d False"},{"line_number":507,"context_line":"            res_dict[\u0027volume_type\u0027][\u0027is_default\u0027] \u003d False"},{"line_number":508,"context_line":"        self.assertEqual(False, res_dict[\u0027share_type\u0027][\u0027is_default\u0027])"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_9502d23d","line":507,"range":{"start_line":504,"start_character":47,"end_line":507,"end_character":57},"updated":"2018-06-07 23:21:41.000000000","message":"?\n\nYou\u0027re assigning the \"is_default\", you should be testing whether the controller gives you the value of it..\n\nI guess what you meant to mock was the \"default_share_type\" of the CONF object.","commit_id":"868c4b80b87f96eb1e747a3327f4482967b4f92a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"98cbb4676b05c743978294666950f65040bc98aa","unresolved":false,"context_lines":[{"line_number":521,"context_line":"        observed \u003d sorted(observed, key\u003dlambda item: item[\u0027id\u0027])"},{"line_number":522,"context_line":"        for d1, d2 in zip(expected, observed):"},{"line_number":523,"context_line":"            self.assertEqual(d1[\u0027id\u0027], d2[\u0027id\u0027])"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"    @ddt.data((\u00272.45\u0027, True), (\u00272.45\u0027, False))"},{"line_number":526,"context_line":"    @ddt.unpack"},{"line_number":527,"context_line":"    def test_share_types_is_default_false(self, version, admin):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_2d885c20","line":524,"range":{"start_line":524,"start_character":0,"end_line":524,"end_character":0},"updated":"2018-06-20 04:07:08.000000000","message":"Please avoid the use of assertTrue and assertFalse to verify the values of \"True\" and \"False\", see https://jamescooke.info/python-unittest-asserttrue-is-truthy-assertfalse-is-falsy.html","commit_id":"09887947f377d7e618bb92efeb7b4da843a0524f"},{"author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"change_message_id":"cbc8c3e4e228882588f7c8600b3526ef58f097fc","unresolved":false,"context_lines":[{"line_number":521,"context_line":"        observed \u003d sorted(observed, key\u003dlambda item: item[\u0027id\u0027])"},{"line_number":522,"context_line":"        for d1, d2 in zip(expected, observed):"},{"line_number":523,"context_line":"            self.assertEqual(d1[\u0027id\u0027], d2[\u0027id\u0027])"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"    @ddt.data((\u00272.45\u0027, True), (\u00272.45\u0027, False))"},{"line_number":526,"context_line":"    @ddt.unpack"},{"line_number":527,"context_line":"    def test_share_types_is_default_false(self, version, admin):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_6604571a","line":524,"range":{"start_line":524,"start_character":0,"end_line":524,"end_character":0},"in_reply_to":"5f7c97a3_2d885c20","updated":"2018-07-13 10:18:26.000000000","message":"This is against with M313:\nM313  Unit tests should use assertTrue(value) instead of using assertEqual(True, value)\nSo, I keep assertTrue(variables) in this change, I am waiting for you suggestion. Should we get rid of M313 in hacking rule?","commit_id":"09887947f377d7e618bb92efeb7b4da843a0524f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"60852eef44392018c2ceacfcbab46d25f33273ee","unresolved":false,"context_lines":[{"line_number":521,"context_line":"        observed \u003d sorted(observed, key\u003dlambda item: item[\u0027id\u0027])"},{"line_number":522,"context_line":"        for d1, d2 in zip(expected, observed):"},{"line_number":523,"context_line":"            self.assertEqual(d1[\u0027id\u0027], d2[\u0027id\u0027])"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"    @ddt.data((\u00272.45\u0027, True), (\u00272.45\u0027, False))"},{"line_number":526,"context_line":"    @ddt.unpack"},{"line_number":527,"context_line":"    def test_share_types_is_default_false(self, version, admin):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_b18dc2d5","line":524,"range":{"start_line":524,"start_character":0,"end_line":524,"end_character":0},"in_reply_to":"5f7c97a3_6604571a","updated":"2018-07-13 18:26:46.000000000","message":"oh, assertIs then..","commit_id":"09887947f377d7e618bb92efeb7b4da843a0524f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"98cbb4676b05c743978294666950f65040bc98aa","unresolved":false,"context_lines":[{"line_number":522,"context_line":"        for d1, d2 in zip(expected, observed):"},{"line_number":523,"context_line":"            self.assertEqual(d1[\u0027id\u0027], d2[\u0027id\u0027])"},{"line_number":524,"context_line":""},{"line_number":525,"context_line":"    @ddt.data((\u00272.45\u0027, True), (\u00272.45\u0027, False))"},{"line_number":526,"context_line":"    @ddt.unpack"},{"line_number":527,"context_line":"    def test_share_types_is_default_false(self, version, admin):"},{"line_number":528,"context_line":"        # list share type"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_0d29e035","line":525,"range":{"start_line":525,"start_character":15,"end_line":525,"end_character":21},"updated":"2018-06-20 04:07:08.000000000","message":"test the prior microversion, i.e, 2.44 to verify that the key is not present","commit_id":"09887947f377d7e618bb92efeb7b4da843a0524f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"98cbb4676b05c743978294666950f65040bc98aa","unresolved":false,"context_lines":[{"line_number":524,"context_line":""},{"line_number":525,"context_line":"    @ddt.data((\u00272.45\u0027, True), (\u00272.45\u0027, False))"},{"line_number":526,"context_line":"    @ddt.unpack"},{"line_number":527,"context_line":"    def test_share_types_is_default_false(self, version, admin):"},{"line_number":528,"context_line":"        # list share type"},{"line_number":529,"context_line":"        self.mock_object(share_types, \u0027get_all_types\u0027,"},{"line_number":530,"context_line":"                         return_share_types_get_all_types)"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_2d2cdc48","line":527,"range":{"start_line":527,"start_character":25,"end_line":527,"end_character":41},"updated":"2018-06-20 04:07:08.000000000","message":"?\n\n def test_share_types_index_with_is_default_key","commit_id":"09887947f377d7e618bb92efeb7b4da843a0524f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"98cbb4676b05c743978294666950f65040bc98aa","unresolved":false,"context_lines":[{"line_number":536,"context_line":"        res_dict \u003d self.controller.index(req)"},{"line_number":537,"context_line":"        self.assertEqual(3, len(res_dict[\u0027share_types\u0027]))"},{"line_number":538,"context_line":"        for res in res_dict[\u0027share_types\u0027]:"},{"line_number":539,"context_line":"            self.assertFalse(res[\u0027is_default\u0027])"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"        # create share type"},{"line_number":542,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/fake/types\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_0d5b20f6","line":539,"range":{"start_line":539,"start_character":12,"end_line":539,"end_character":47},"updated":"2018-06-20 04:07:08.000000000","message":"replace with:\n\n   self.assertIn(\u0027is_default\u0027, res)\n   self.assertEqual(False, res[\u0027is_default\u0027])","commit_id":"09887947f377d7e618bb92efeb7b4da843a0524f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"98cbb4676b05c743978294666950f65040bc98aa","unresolved":false,"context_lines":[{"line_number":537,"context_line":"        self.assertEqual(3, len(res_dict[\u0027share_types\u0027]))"},{"line_number":538,"context_line":"        for res in res_dict[\u0027share_types\u0027]:"},{"line_number":539,"context_line":"            self.assertFalse(res[\u0027is_default\u0027])"},{"line_number":540,"context_line":""},{"line_number":541,"context_line":"        # create share type"},{"line_number":542,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/fake/types\u0027,"},{"line_number":543,"context_line":"                                      version\u003dversion,"},{"line_number":544,"context_line":"                                      use_admin_context\u003dadmin)"},{"line_number":545,"context_line":""},{"line_number":546,"context_line":"        body \u003d make_create_body()"},{"line_number":547,"context_line":"        res_dict \u003d self.controller.create(req, body)"},{"line_number":548,"context_line":"        self.assertEqual(False, res_dict[\u0027share_type\u0027][\u0027is_default\u0027])"},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"    @ddt.data((\u00272.45\u0027, True), (\u00272.45\u0027, False))"},{"line_number":551,"context_line":"    @ddt.unpack"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_2d35bca8","line":548,"range":{"start_line":540,"start_character":0,"end_line":548,"end_character":69},"updated":"2018-06-20 04:07:08.000000000","message":"please separate this test, a unit test must only test one unit at a time..\n\n  def test_share_types_create_with_is_default_key","commit_id":"09887947f377d7e618bb92efeb7b4da843a0524f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"98cbb4676b05c743978294666950f65040bc98aa","unresolved":false,"context_lines":[{"line_number":563,"context_line":"        res_dict \u003d self.controller.index(req)"},{"line_number":564,"context_line":"        self.assertEqual(3, len(res_dict[\u0027share_types\u0027]))"},{"line_number":565,"context_line":"        for res in res_dict[\u0027share_types\u0027]:"},{"line_number":566,"context_line":"            if res[\u0027name\u0027] \u003d\u003d default_type_name:"},{"line_number":567,"context_line":"                self.assertTrue(res[\u0027is_default\u0027])"},{"line_number":568,"context_line":"            else:"},{"line_number":569,"context_line":"                self.assertFalse(res[\u0027is_default\u0027])"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"        # default share type"},{"line_number":572,"context_line":"        self.mock_object(share_types, \u0027get_default_share_type\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_2d9ffc65","line":569,"range":{"start_line":566,"start_character":12,"end_line":569,"end_character":51},"updated":"2018-06-20 04:07:08.000000000","message":"if version \u003e\u003d \u00272.45\u0027:\n      self.assertIn(\u0027is_default\u0027, res)\n      self.assertEqual(res[\u0027name\u0027] \u003d\u003d default_type_name, res[\u0027is_default\u0027])\n  else:\n      self.assertNotIn(\u0027is_default\u0027, res)","commit_id":"09887947f377d7e618bb92efeb7b4da843a0524f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"98cbb4676b05c743978294666950f65040bc98aa","unresolved":false,"context_lines":[{"line_number":568,"context_line":"            else:"},{"line_number":569,"context_line":"                self.assertFalse(res[\u0027is_default\u0027])"},{"line_number":570,"context_line":""},{"line_number":571,"context_line":"        # default share type"},{"line_number":572,"context_line":"        self.mock_object(share_types, \u0027get_default_share_type\u0027,"},{"line_number":573,"context_line":"                         return_default_share_type)"},{"line_number":574,"context_line":""},{"line_number":575,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/fake/types/default_share_type\u0027,"},{"line_number":576,"context_line":"                                      version\u003dversion,"},{"line_number":577,"context_line":"                                      use_admin_context\u003dadmin)"},{"line_number":578,"context_line":""},{"line_number":579,"context_line":"        res_dict \u003d self.controller.default(req)"},{"line_number":580,"context_line":"        self.assertTrue(res_dict[\u0027share_type\u0027][\u0027is_default\u0027])"},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"        # create share type"},{"line_number":583,"context_line":"        self.mock_object("}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_ad922c57","line":580,"range":{"start_line":571,"start_character":7,"end_line":580,"end_character":61},"updated":"2018-06-20 04:07:08.000000000","message":"Please separate this into its own unit test\n\n\n  def test_share_types_default_with_is_default_key","commit_id":"09887947f377d7e618bb92efeb7b4da843a0524f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"98cbb4676b05c743978294666950f65040bc98aa","unresolved":false,"context_lines":[{"line_number":577,"context_line":"                                      use_admin_context\u003dadmin)"},{"line_number":578,"context_line":""},{"line_number":579,"context_line":"        res_dict \u003d self.controller.default(req)"},{"line_number":580,"context_line":"        self.assertTrue(res_dict[\u0027share_type\u0027][\u0027is_default\u0027])"},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"        # create share type"},{"line_number":583,"context_line":"        self.mock_object("}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_6d6bb484","line":580,"range":{"start_line":580,"start_character":8,"end_line":580,"end_character":61},"updated":"2018-06-20 04:07:08.000000000","message":"self.assertEqual(True, res_dict[\u0027share_type\u0027][\u0027is_default\u0027])","commit_id":"09887947f377d7e618bb92efeb7b4da843a0524f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"98cbb4676b05c743978294666950f65040bc98aa","unresolved":false,"context_lines":[{"line_number":579,"context_line":"        res_dict \u003d self.controller.default(req)"},{"line_number":580,"context_line":"        self.assertTrue(res_dict[\u0027share_type\u0027][\u0027is_default\u0027])"},{"line_number":581,"context_line":""},{"line_number":582,"context_line":"        # create share type"},{"line_number":583,"context_line":"        self.mock_object("},{"line_number":584,"context_line":"            share_types, \u0027create\u0027,"},{"line_number":585,"context_line":"            mock.Mock(side_effect\u003dreturn_share_types_create))"},{"line_number":586,"context_line":"        self.mock_object("},{"line_number":587,"context_line":"            share_types, \u0027get_share_type_by_name\u0027,"},{"line_number":588,"context_line":"            mock.Mock(side_effect\u003dreturn_default_share_type))"},{"line_number":589,"context_line":""},{"line_number":590,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/fake/types\u0027,"},{"line_number":591,"context_line":"                                      version\u003dversion,"},{"line_number":592,"context_line":"                                      use_admin_context\u003dadmin)"},{"line_number":593,"context_line":""},{"line_number":594,"context_line":"        body \u003d make_create_body()"},{"line_number":595,"context_line":"        res_dict \u003d self.controller.create(req, body)"},{"line_number":596,"context_line":"        self.assertTrue(res_dict[\u0027share_type\u0027][\u0027is_default\u0027])"},{"line_number":597,"context_line":""},{"line_number":598,"context_line":""},{"line_number":599,"context_line":"def generate_type(type_id, is_public):"}],"source_content_type":"text/x-python","patch_set":8,"id":"5f7c97a3_cd43e810","line":596,"range":{"start_line":582,"start_character":0,"end_line":596,"end_character":61},"updated":"2018-06-20 04:07:08.000000000","message":"You may remove this if you separate the create test above.","commit_id":"09887947f377d7e618bb92efeb7b4da843a0524f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f905ecdefeb11bfb9491fcae65d90cdef7c9bc73","unresolved":false,"context_lines":[{"line_number":534,"context_line":"        res_dict \u003d self.controller.create(req, body)"},{"line_number":535,"context_line":"        if version \u003e\u003d \u00272.45\u0027:"},{"line_number":536,"context_line":"            self.assertIn(\u0027is_default\u0027, res_dict[\u0027share_type\u0027])"},{"line_number":537,"context_line":"            self.assertIs(res_dict[\u0027share_type\u0027][\u0027is_default\u0027], False)"},{"line_number":538,"context_line":"        else:"},{"line_number":539,"context_line":"            self.assertNotIn(\u0027is_default\u0027, res_dict[\u0027share_type\u0027])"},{"line_number":540,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5f7c97a3_ce692cf7","line":537,"range":{"start_line":537,"start_character":12,"end_line":537,"end_character":70},"updated":"2018-07-20 00:44:20.000000000","message":"self.assertIs(False, res_dict[\u0027share_type\u0027][\u0027is_default\u0027])","commit_id":"c5cea9510a62e908ca53b44d3f7d7d83c23139d5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f905ecdefeb11bfb9491fcae65d90cdef7c9bc73","unresolved":false,"context_lines":[{"line_number":577,"context_line":"        res_dict \u003d self.controller.default(req)"},{"line_number":578,"context_line":"        if version \u003e\u003d \u00272.45\u0027:"},{"line_number":579,"context_line":"            self.assertIn(\u0027is_default\u0027, res_dict[\u0027share_type\u0027])"},{"line_number":580,"context_line":"            self.assertIs(res_dict[\u0027share_type\u0027][\u0027is_default\u0027], True)"},{"line_number":581,"context_line":"        else:"},{"line_number":582,"context_line":"            self.assertNotIn(\u0027is_default\u0027, res_dict[\u0027share_type\u0027])"},{"line_number":583,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5f7c97a3_2e7a20ba","line":580,"range":{"start_line":580,"start_character":12,"end_line":580,"end_character":69},"updated":"2018-07-20 00:44:20.000000000","message":"self.assertIs(True, res_dict[\u0027share_type\u0027][\u0027is_default\u0027])","commit_id":"c5cea9510a62e908ca53b44d3f7d7d83c23139d5"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b2c3605eeab527f5608ff5cd471b2425aa7ab801","unresolved":false,"context_lines":[{"line_number":532,"context_line":""},{"line_number":533,"context_line":"        body \u003d make_create_body()"},{"line_number":534,"context_line":"        res_dict \u003d self.controller.create(req, body)"},{"line_number":535,"context_line":"        if version \u003e\u003d \u00272.46\u0027:"},{"line_number":536,"context_line":"            self.assertIn(\u0027is_default\u0027, res_dict[\u0027share_type\u0027])"},{"line_number":537,"context_line":"            self.assertIs(False, res_dict[\u0027share_type\u0027][\u0027is_default\u0027])"},{"line_number":538,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_71cafd19","line":535,"range":{"start_line":535,"start_character":7,"end_line":535,"end_character":29},"updated":"2018-07-23 21:00:05.000000000","message":"self.is_microversion_ge(version, \u00272.46\u0027)","commit_id":"cd99566f87c97a2d2ba5b4743072a3cdd73c126d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b2c3605eeab527f5608ff5cd471b2425aa7ab801","unresolved":false,"context_lines":[{"line_number":554,"context_line":"        res_dict \u003d self.controller.index(req)"},{"line_number":555,"context_line":"        self.assertEqual(3, len(res_dict[\u0027share_types\u0027]))"},{"line_number":556,"context_line":"        for res in res_dict[\u0027share_types\u0027]:"},{"line_number":557,"context_line":"            if version \u003e\u003d \u00272.46\u0027:"},{"line_number":558,"context_line":"                self.assertIn(\u0027is_default\u0027, res)"},{"line_number":559,"context_line":"                expected \u003d res[\u0027name\u0027] \u003d\u003d default_type_name"},{"line_number":560,"context_line":"                self.assertIs(res[\u0027is_default\u0027], expected)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_f1ddadde","line":557,"range":{"start_line":557,"start_character":12,"end_line":557,"end_character":33},"updated":"2018-07-23 21:00:05.000000000","message":"self.is_microversion_ge(version, \u00272.46\u0027)","commit_id":"cd99566f87c97a2d2ba5b4743072a3cdd73c126d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b2c3605eeab527f5608ff5cd471b2425aa7ab801","unresolved":false,"context_lines":[{"line_number":575,"context_line":"                                      use_admin_context\u003dadmin)"},{"line_number":576,"context_line":""},{"line_number":577,"context_line":"        res_dict \u003d self.controller.default(req)"},{"line_number":578,"context_line":"        if version \u003e\u003d \u00272.46\u0027:"},{"line_number":579,"context_line":"            self.assertIn(\u0027is_default\u0027, res_dict[\u0027share_type\u0027])"},{"line_number":580,"context_line":"            self.assertIs(True, res_dict[\u0027share_type\u0027][\u0027is_default\u0027])"},{"line_number":581,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_31d485bc","line":578,"range":{"start_line":578,"start_character":8,"end_line":578,"end_character":29},"updated":"2018-07-23 21:00:05.000000000","message":"self.is_microversion_ge(version, \u00272.46\u0027)","commit_id":"cd99566f87c97a2d2ba5b4743072a3cdd73c126d"}],"releasenotes/notes/add-is-default-e49727d276dd9bc3.yaml":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"ddc81a09c0091d86e0bd66c3cda6c21acccc24b0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"  - The share type and share group type APIs in API version 2.45 return"},{"line_number":5,"context_line":"    field \"is_default\" which is set to \u0027true\u0027 if the share type or the"},{"line_number":6,"context_line":"    share group type is the default as configured by the administrator."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"5f7c97a3_58d621fb","line":4,"range":{"start_line":4,"start_character":59,"end_line":4,"end_character":64},"updated":"2018-07-22 10:39:22.000000000","message":"2.46","commit_id":"652ed49c2732ea6bae1dcfaf16b0d86ad14d4b67"},{"author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"change_message_id":"230faebcad5f9832450e7f3f52fe7f13e43dad67","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"  - The share type and share group type APIs in API version 2.45 return"},{"line_number":5,"context_line":"    field \"is_default\" which is set to \u0027true\u0027 if the share type or the"},{"line_number":6,"context_line":"    share group type is the default as configured by the administrator."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"5f7c97a3_9b8a7363","line":4,"range":{"start_line":4,"start_character":59,"end_line":4,"end_character":64},"in_reply_to":"5f7c97a3_58d621fb","updated":"2018-07-22 12:59:23.000000000","message":"Yes, right, missing this one.","commit_id":"652ed49c2732ea6bae1dcfaf16b0d86ad14d4b67"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b2c3605eeab527f5608ff5cd471b2425aa7ab801","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"  - The share type and share group type APIs in API version 2.46 return"},{"line_number":5,"context_line":"    field \"is_default\" which is set to \u0027true\u0027 if the share type or the"},{"line_number":6,"context_line":"    share group type is the default as configured by the administrator."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5f7c97a3_91e8f97b","line":5,"range":{"start_line":5,"start_character":39,"end_line":5,"end_character":45},"updated":"2018-07-23 21:00:05.000000000","message":"True","commit_id":"cd99566f87c97a2d2ba5b4743072a3cdd73c126d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"49c281a846ca4448390d3474902ae1228bef544a","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"  - The share type and share group type APIs in API version 2.46 return"},{"line_number":5,"context_line":"    field \"is_default\" which is set to \u0027true\u0027 if the share type or the"},{"line_number":6,"context_line":"    share group type is the default as configured by the administrator."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5f7c97a3_919d590b","line":5,"range":{"start_line":5,"start_character":39,"end_line":5,"end_character":45},"in_reply_to":"5f7c97a3_91e8f97b","updated":"2018-07-23 21:00:44.000000000","message":"ignore this comment","commit_id":"cd99566f87c97a2d2ba5b4743072a3cdd73c126d"}],"releasenotes/notes/add_is_default-e49727d276dd9bc3.yaml":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"b0cdf6a1022ac00112274a7cdd8942284d6cd41f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"  - Retrive the ``is_default`` value when creating share type or"},{"line_number":5,"context_line":"    share group type in order to fix the empty value of ``is_default``"},{"line_number":6,"context_line":"    in command line message."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f7c97a3_f9923458","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":11},"updated":"2018-06-07 10:23:18.000000000","message":"Retrieve","commit_id":"92fb486559dfa6c0bf92914e5df2f2674c168209"},{"author":{"_account_id":25456,"name":"junboli","email":"junbo85.li@gmail.com","username":"junboli"},"change_message_id":"5ba67dcf14a09085e2931d8f6f7d2e4639ff0e52","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"  - Retrive the ``is_default`` value when creating share type or"},{"line_number":5,"context_line":"    share group type in order to fix the empty value of ``is_default``"},{"line_number":6,"context_line":"    in command line message."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f7c97a3_81c86674","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":11},"in_reply_to":"5f7c97a3_f9923458","updated":"2018-06-07 10:54:37.000000000","message":"Done","commit_id":"92fb486559dfa6c0bf92914e5df2f2674c168209"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1af7cba8fc9eafaa025a5752cef7758e8282c4de","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"  - Retrieve the ``is_default`` value when creating share type or"},{"line_number":5,"context_line":"    share group type in order to fix the empty value of ``is_default``"},{"line_number":6,"context_line":"    in command line message."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"5f7c97a3_d56b6aee","line":6,"range":{"start_line":4,"start_character":4,"end_line":6,"end_character":28},"updated":"2018-06-07 23:21:41.000000000","message":"suggestion:\n\n - The share type and share group type APIs now return a new field, \"is_default\" which is set to \u0027true\u0027 if the share type or the share group type is the default as configured by the administrator.","commit_id":"868c4b80b87f96eb1e747a3327f4482967b4f92a"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"98cbb4676b05c743978294666950f65040bc98aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"5f7c97a3_4d859858","updated":"2018-06-20 04:07:08.000000000","message":"Please use hyphens (\"-\") instead of underscores (\"_\") while naming the Renos, for consistency... \n\n add-is-default-e49727d276dd9bc3.yaml","commit_id":"09887947f377d7e618bb92efeb7b4da843a0524f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"98cbb4676b05c743978294666950f65040bc98aa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"  - The share type and share group type APIs now return a new field,"},{"line_number":5,"context_line":"    \"is_default\" which is set to \u0027true\u0027 if the share type or the share"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f7c97a3_adac6cee","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":5},"updated":"2018-06-20 04:07:08.000000000","message":"please change this to features","commit_id":"09887947f377d7e618bb92efeb7b4da843a0524f"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"98cbb4676b05c743978294666950f65040bc98aa","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"  - The share type and share group type APIs now return a new field,"},{"line_number":5,"context_line":"    \"is_default\" which is set to \u0027true\u0027 if the share type or the share"},{"line_number":6,"context_line":"    group type is the default as configured by the administrator."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5f7c97a3_ed7b4478","line":4,"range":{"start_line":4,"start_character":45,"end_line":4,"end_character":68},"updated":"2018-06-20 04:07:08.000000000","message":"in API version 2.4x..","commit_id":"09887947f377d7e618bb92efeb7b4da843a0524f"}]}
