)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"537d340b26de9a7e5eeb732068d3f590b6c7dd1b","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now only share have metadata property."},{"line_number":10,"context_line":"We should support it for access rule as well."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2f2b3325a09e5af7f7c4e4fa3443259fb69f9771"},{"line_number":13,"context_line":"bp: metadata-for-access-rule"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"5f7c97a3_e8aa9782","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":0},"updated":"2018-07-12 06:03:00.000000000","message":"Please add a DocImpact flag, or include the required user, admin,api-ref documentation in this patch \n\nI would strongly recommend including the API Ref changes in this patch","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2450b68e9648b36b1280649928709b2661b6f62e","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Now only share have metadata property."},{"line_number":10,"context_line":"We should support it for access rule as well."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2f2b3325a09e5af7f7c4e4fa3443259fb69f9771"},{"line_number":13,"context_line":"bp: metadata-for-access-rule"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"5f7c97a3_0ed83b22","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":0},"in_reply_to":"5f7c97a3_e8aa9782","updated":"2018-07-12 08:06:06.000000000","message":"Done  The API doc will add in separate patch ASAP.","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"537d340b26de9a7e5eeb732068d3f590b6c7dd1b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Now only share have metadata property."},{"line_number":10,"context_line":"We should support it for access rule as well."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2f2b3325a09e5af7f7c4e4fa3443259fb69f9771"},{"line_number":13,"context_line":"bp: metadata-for-access-rule"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"5f7c97a3_e2b5d8ee","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":52},"updated":"2018-07-12 06:03:00.000000000","message":"please add Needed-By for the manila-tempest-tests patch and the python-manilaclient patch so they\u0027re easier to keep track of","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2450b68e9648b36b1280649928709b2661b6f62e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Now only share have metadata property."},{"line_number":10,"context_line":"We should support it for access rule as well."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2f2b3325a09e5af7f7c4e4fa3443259fb69f9771"},{"line_number":13,"context_line":"bp: metadata-for-access-rule"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"5f7c97a3_2e14179f","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":52},"in_reply_to":"5f7c97a3_e2b5d8ee","updated":"2018-07-12 08:06:06.000000000","message":"Done","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"537d340b26de9a7e5eeb732068d3f590b6c7dd1b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"We should support it for access rule as well."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: I2f2b3325a09e5af7f7c4e4fa3443259fb69f9771"},{"line_number":13,"context_line":"bp: metadata-for-access-rule"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":17,"id":"5f7c97a3_42eb6cdc","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":2},"updated":"2018-07-12 06:03:00.000000000","message":"Implements: bp metadata-for-access-rule","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"603a08670987620253c8877e894537f8bde832df","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"DocImpact"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Needed-By: The manila-tempest-tests patch[1] and"},{"line_number":15,"context_line":"the python-manilaclient patch [2]."},{"line_number":16,"context_line":"[1] https://review.openstack.org/#/c/579534"},{"line_number":17,"context_line":"[2] https://review.openstack.org/#/c/571366"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I2f2b3325a09e5af7f7c4e4fa3443259fb69f9771"},{"line_number":20,"context_line":"Implements: bp metadata-for-access-rule"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":20,"id":"5f7c97a3_f020cb4d","line":17,"range":{"start_line":14,"start_character":0,"end_line":17,"end_character":43},"updated":"2018-07-17 22:26:07.000000000","message":"don\u0027t matter here, but in the future patches:\n\nNeeded-By: https://review.openstack.org/#/c/579534\nNeeded-By: https://review.openstack.org/#/c/571366","commit_id":"892b88a832e8a0941ee75c1aee61627f3b76df66"}],"manila/api/openstack/api_version_request.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aa8044c5efb443e2fb032476842d0f4f0b7abada","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    * 2.42 - Added ``with_count`` in share list API to get total count info."},{"line_number":117,"context_line":"    * 2.43 - Added filter search by extra spec for share type list."},{"line_number":118,"context_line":"    * 2.44 - Added \u0027ou\u0027 field to \u0027security_service\u0027 object."},{"line_number":119,"context_line":"    * 2.45 - Added access metadata for share access."},{"line_number":120,"context_line":"\"\"\""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":20,"id":"5f7c97a3_61d38b03","line":119,"range":{"start_line":119,"start_character":51,"end_line":119,"end_character":52},"updated":"2018-07-17 23:32:37.000000000","message":"and also introduced the GET /share-access-rules API","commit_id":"892b88a832e8a0941ee75c1aee61627f3b76df66"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2a1920777c122fe5d55f0a89822727d48055cec8","unresolved":false,"context_lines":[{"line_number":116,"context_line":"    * 2.42 - Added ``with_count`` in share list API to get total count info."},{"line_number":117,"context_line":"    * 2.43 - Added filter search by extra spec for share type list."},{"line_number":118,"context_line":"    * 2.44 - Added \u0027ou\u0027 field to \u0027security_service\u0027 object."},{"line_number":119,"context_line":"    * 2.45 - Added access metadata for share access."},{"line_number":120,"context_line":"\"\"\""},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":20,"id":"5f7c97a3_8c005b02","line":119,"range":{"start_line":119,"start_character":51,"end_line":119,"end_character":52},"in_reply_to":"5f7c97a3_61d38b03","updated":"2018-07-18 00:29:57.000000000","message":"Done","commit_id":"892b88a832e8a0941ee75c1aee61627f3b76df66"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e1f556c2c11065341528b43078a8f3314809171","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    * 2.43 - Added filter search by extra spec for share type list."},{"line_number":118,"context_line":"    * 2.44 - Added \u0027ou\u0027 field to \u0027security_service\u0027 object."},{"line_number":119,"context_line":"    * 2.45 - Added access metadata for share access and also introduced"},{"line_number":120,"context_line":"             the GET /share-access-rules API."},{"line_number":121,"context_line":"\"\"\""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_03596327","line":120,"range":{"start_line":120,"start_character":44,"end_line":120,"end_character":45},"updated":"2018-07-18 23:17:35.000000000","message":"Please add:\n The prior API to retrieve access rules will not work with API version \u003e\u003d2.45.","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"11976fc9d82a431c63035a1e286bf5d6bc119459","unresolved":false,"context_lines":[{"line_number":117,"context_line":"    * 2.43 - Added filter search by extra spec for share type list."},{"line_number":118,"context_line":"    * 2.44 - Added \u0027ou\u0027 field to \u0027security_service\u0027 object."},{"line_number":119,"context_line":"    * 2.45 - Added access metadata for share access and also introduced"},{"line_number":120,"context_line":"             the GET /share-access-rules API."},{"line_number":121,"context_line":"\"\"\""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_2ce79e48","line":120,"range":{"start_line":120,"start_character":44,"end_line":120,"end_character":45},"in_reply_to":"5f7c97a3_03596327","updated":"2018-07-19 12:53:47.000000000","message":"Done","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"}],"manila/api/openstack/rest_api_version_history.rst":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aa8044c5efb443e2fb032476842d0f4f0b7abada","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"2.45"},{"line_number":247,"context_line":"----"},{"line_number":248,"context_line":"  Added access metadata for share access."}],"source_content_type":"text/x-rst","patch_set":20,"id":"5f7c97a3_61ecebbb","line":248,"range":{"start_line":248,"start_character":2,"end_line":248,"end_character":41},"updated":"2018-07-17 23:32:37.000000000","message":"same","commit_id":"892b88a832e8a0941ee75c1aee61627f3b76df66"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2a1920777c122fe5d55f0a89822727d48055cec8","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"2.45"},{"line_number":247,"context_line":"----"},{"line_number":248,"context_line":"  Added access metadata for share access."}],"source_content_type":"text/x-rst","patch_set":20,"id":"5f7c97a3_4c06c31d","line":248,"range":{"start_line":248,"start_character":2,"end_line":248,"end_character":41},"in_reply_to":"5f7c97a3_61ecebbb","updated":"2018-07-18 00:29:57.000000000","message":"Done","commit_id":"892b88a832e8a0941ee75c1aee61627f3b76df66"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e1f556c2c11065341528b43078a8f3314809171","unresolved":false,"context_lines":[{"line_number":246,"context_line":"2.45"},{"line_number":247,"context_line":"----"},{"line_number":248,"context_line":"  Added access metadata for share access and also introduced the"},{"line_number":249,"context_line":"  GET /share-access-rules API."}],"source_content_type":"text/x-rst","patch_set":27,"id":"5f7c97a3_c39ccbc0","line":249,"range":{"start_line":249,"start_character":29,"end_line":249,"end_character":30},"updated":"2018-07-18 23:17:35.000000000","message":"Please add:\n The prior API to retrieve access rules will not work with API version \u003e\u003d2.45.","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"11976fc9d82a431c63035a1e286bf5d6bc119459","unresolved":false,"context_lines":[{"line_number":246,"context_line":"2.45"},{"line_number":247,"context_line":"----"},{"line_number":248,"context_line":"  Added access metadata for share access and also introduced the"},{"line_number":249,"context_line":"  GET /share-access-rules API."}],"source_content_type":"text/x-rst","patch_set":27,"id":"5f7c97a3_4cea1a0e","line":249,"range":{"start_line":249,"start_character":29,"end_line":249,"end_character":30},"in_reply_to":"5f7c97a3_c39ccbc0","updated":"2018-07-19 12:53:47.000000000","message":"Done","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"}],"manila/api/v1/shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"537d340b26de9a7e5eeb732068d3f590b6c7dd1b","unresolved":false,"context_lines":[{"line_number":397,"context_line":"        \"\"\"Add share access rule.\"\"\""},{"line_number":398,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":399,"context_line":"        access_data \u003d body.get(\u0027allow_access\u0027, body.get(\u0027os-allow_access\u0027))"},{"line_number":400,"context_line":"        if not enable_metadata and \u0027metadata\u0027 in access_data:"},{"line_number":401,"context_line":"            msg \u003d _(\"The share access metadata only support \""},{"line_number":402,"context_line":"                    \"microversion \u003e\u003d 2.45.\")"},{"line_number":403,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":404,"context_line":"        share \u003d self.share_api.get(context, id)"},{"line_number":405,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_828f442e","line":402,"range":{"start_line":400,"start_character":0,"end_line":402,"end_character":44},"updated":"2018-07-12 06:03:00.000000000","message":"Added a discussion item to the meeting tomorrow (July 12th 2018) to discuss what is the best way we need to handle this. I do not believe we should special case API schema validation like this; I like the approach you proposed to the priority for access rules patch where you check for valid keys and return HTTP400 in case of all invalid fields. This is teh same semantics being proposed in the JSON schema validation spec that we have committed to deliver in this cycle.","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aa8044c5efb443e2fb032476842d0f4f0b7abada","unresolved":false,"context_lines":[{"line_number":400,"context_line":"        if not enable_metadata and \u0027metadata\u0027 in access_data:"},{"line_number":401,"context_line":"            msg \u003d _(\"The share access metadata only support \""},{"line_number":402,"context_line":"                    \"microversion \u003e\u003d 2.45.\")"},{"line_number":403,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":404,"context_line":"        share \u003d self.share_api.get(context, id)"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"        if (not allow_on_error_status and"}],"source_content_type":"text/x-python","patch_set":20,"id":"5f7c97a3_41c9af22","line":403,"range":{"start_line":403,"start_character":0,"end_line":403,"end_character":59},"updated":"2018-07-17 23:32:37.000000000","message":"So, I suggest changing this to:\n\nif not enable_metadata:\n    access_data.pop(\u0027metadata\u0027, None)","commit_id":"892b88a832e8a0941ee75c1aee61627f3b76df66"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aa8044c5efb443e2fb032476842d0f4f0b7abada","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":399,"context_line":"        access_data \u003d body.get(\u0027allow_access\u0027, body.get(\u0027os-allow_access\u0027))"},{"line_number":400,"context_line":"        if not enable_metadata and \u0027metadata\u0027 in access_data:"},{"line_number":401,"context_line":"            msg \u003d _(\"The share access metadata only support \""},{"line_number":402,"context_line":"                    \"microversion \u003e\u003d 2.45.\")"},{"line_number":403,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":404,"context_line":"        share \u003d self.share_api.get(context, id)"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"        if (not allow_on_error_status and"}],"source_content_type":"text/x-python","patch_set":20,"id":"5f7c97a3_8145879d","line":403,"range":{"start_line":401,"start_character":12,"end_line":403,"end_character":59},"updated":"2018-07-17 23:32:37.000000000","message":"Zhongjun: We have had multiple discussions around this; please do not follow the bad precedent we set with share type quota APIs because:\n\n1) We have ignored unknown keys in the past, and we don\u0027t need to introduce any breaking special case behavior now just because a key is introduced. For example see:\nhttps://github.com/openstack/manila/blob/c460f9d/manila/api/v1/share_snapshots.py#L76\nhttps://github.com/openstack/manila/blob/e4acaa/manila/api/v1/shares.py#L105\nhttps://github.com/openstack/manila/blob/e4acaa/manila/api/v2/shares.py#L188\nhttps://github.com/openstack/manila/blob/c460f9/manila/api/v2/share_snapshots.py#L299\n\n \n\n2) We have ongoing work to validate our API schemas with the help of jsonschema. We can cover this with that work if we decide to \"fix\" released APIs in a backwards incompatible way. \n\nIf you have questions, I am happy to discuss.","commit_id":"892b88a832e8a0941ee75c1aee61627f3b76df66"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2a1920777c122fe5d55f0a89822727d48055cec8","unresolved":false,"context_lines":[{"line_number":400,"context_line":"        if not enable_metadata and \u0027metadata\u0027 in access_data:"},{"line_number":401,"context_line":"            msg \u003d _(\"The share access metadata only support \""},{"line_number":402,"context_line":"                    \"microversion \u003e\u003d 2.45.\")"},{"line_number":403,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":404,"context_line":"        share \u003d self.share_api.get(context, id)"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"        if (not allow_on_error_status and"}],"source_content_type":"text/x-python","patch_set":20,"id":"5f7c97a3_6916115b","line":403,"range":{"start_line":403,"start_character":0,"end_line":403,"end_character":59},"in_reply_to":"5f7c97a3_41c9af22","updated":"2018-07-18 00:29:57.000000000","message":"Done","commit_id":"892b88a832e8a0941ee75c1aee61627f3b76df66"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2a1920777c122fe5d55f0a89822727d48055cec8","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":399,"context_line":"        access_data \u003d body.get(\u0027allow_access\u0027, body.get(\u0027os-allow_access\u0027))"},{"line_number":400,"context_line":"        if not enable_metadata and \u0027metadata\u0027 in access_data:"},{"line_number":401,"context_line":"            msg \u003d _(\"The share access metadata only support \""},{"line_number":402,"context_line":"                    \"microversion \u003e\u003d 2.45.\")"},{"line_number":403,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":404,"context_line":"        share \u003d self.share_api.get(context, id)"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"        if (not allow_on_error_status and"}],"source_content_type":"text/x-python","patch_set":20,"id":"5f7c97a3_a92669cb","line":403,"range":{"start_line":401,"start_character":12,"end_line":403,"end_character":59},"in_reply_to":"5f7c97a3_8145879d","updated":"2018-07-18 00:29:57.000000000","message":"Done","commit_id":"892b88a832e8a0941ee75c1aee61627f3b76df66"}],"manila/api/v2/share_access_metadata.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"537d340b26de9a7e5eeb732068d3f590b6c7dd1b","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        metadata \u003d body[\u0027metadata\u0027]"},{"line_number":48,"context_line":"        new_metadata \u003d self._update_share_access_metadata("},{"line_number":49,"context_line":"            context, access_id, metadata)"},{"line_number":50,"context_line":"        return {\u0027metadata\u0027: new_metadata}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @wsgi.Controller.api_version(\u00272.45\u0027)"},{"line_number":53,"context_line":"    @wsgi.Controller.authorize"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_cdb24d97","line":50,"range":{"start_line":50,"start_character":15,"end_line":50,"end_character":41},"updated":"2018-07-12 06:03:00.000000000","message":"format this through the view builder","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2450b68e9648b36b1280649928709b2661b6f62e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        metadata \u003d body[\u0027metadata\u0027]"},{"line_number":48,"context_line":"        new_metadata \u003d self._update_share_access_metadata("},{"line_number":49,"context_line":"            context, access_id, metadata)"},{"line_number":50,"context_line":"        return {\u0027metadata\u0027: new_metadata}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    @wsgi.Controller.api_version(\u00272.45\u0027)"},{"line_number":53,"context_line":"    @wsgi.Controller.authorize"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_b3f094dc","line":50,"range":{"start_line":50,"start_character":15,"end_line":50,"end_character":41},"in_reply_to":"5f7c97a3_cdb24d97","updated":"2018-07-12 08:06:06.000000000","message":"Done","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"537d340b26de9a7e5eeb732068d3f590b6c7dd1b","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            db.share_access_metadata_delete(context, access_id, key)"},{"line_number":60,"context_line":"        except exception.ShareAccessMetadataNotFound as error:"},{"line_number":61,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003derror.msg)"},{"line_number":62,"context_line":"        return webob.Response(status_int\u003dhttp_client.OK)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _update_share_access_metadata(self, context, access_id, metadata):"},{"line_number":65,"context_line":"        self._assert_access_exists(context, access_id)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_2d4c219c","line":62,"range":{"start_line":62,"start_character":8,"end_line":62,"end_character":56},"updated":"2018-07-12 06:03:00.000000000","message":"you can do this via a decorator:\n\n  @wsgi.response(200)","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2450b68e9648b36b1280649928709b2661b6f62e","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            db.share_access_metadata_delete(context, access_id, key)"},{"line_number":60,"context_line":"        except exception.ShareAccessMetadataNotFound as error:"},{"line_number":61,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003derror.msg)"},{"line_number":62,"context_line":"        return webob.Response(status_int\u003dhttp_client.OK)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _update_share_access_metadata(self, context, access_id, metadata):"},{"line_number":65,"context_line":"        self._assert_access_exists(context, access_id)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_3337a4b2","line":62,"range":{"start_line":62,"start_character":8,"end_line":62,"end_character":56},"in_reply_to":"5f7c97a3_2d4c219c","updated":"2018-07-12 08:06:06.000000000","message":"Done","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"603a08670987620253c8877e894537f8bde832df","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        metadata \u003d body[\u0027metadata\u0027]"},{"line_number":48,"context_line":"        self._update_share_access_metadata(context, access_id, metadata)"},{"line_number":49,"context_line":"        return body"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @wsgi.Controller.api_version(\u00272.45\u0027)"},{"line_number":52,"context_line":"    @wsgi.Controller.authorize"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_b5fb8146","line":49,"range":{"start_line":49,"start_character":15,"end_line":49,"end_character":19},"updated":"2018-07-17 22:26:07.000000000","message":"? \n\nWhy return the body that was sent to the API?\n\nI see the updated metadata is being returned in case of share metadata APIs. do the same and please funnel this through the view builder for consistency; in case modifications to the response are necessary later.","commit_id":"db8c3ea38dbdfa08718c5082f080986234b4c65c"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2a1920777c122fe5d55f0a89822727d48055cec8","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        metadata \u003d body[\u0027metadata\u0027]"},{"line_number":48,"context_line":"        self._update_share_access_metadata(context, access_id, metadata)"},{"line_number":49,"context_line":"        return body"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @wsgi.Controller.api_version(\u00272.45\u0027)"},{"line_number":52,"context_line":"    @wsgi.Controller.authorize"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_09f3dda0","line":49,"range":{"start_line":49,"start_character":15,"end_line":49,"end_character":19},"in_reply_to":"5f7c97a3_b5fb8146","updated":"2018-07-18 00:29:57.000000000","message":"Done","commit_id":"db8c3ea38dbdfa08718c5082f080986234b4c65c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"603a08670987620253c8877e894537f8bde832df","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            db.share_access_metadata_delete(context, access_id, key)"},{"line_number":60,"context_line":"        except exception.ShareAccessMetadataNotFound as error:"},{"line_number":61,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003derror.msg)"},{"line_number":62,"context_line":"        return webob.Response(status_int\u003dhttp_client.OK)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _update_share_access_metadata(self, context, access_id, metadata):"},{"line_number":65,"context_line":"        self._assert_access_exists(context, access_id)"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_55f8ed48","line":62,"range":{"start_line":62,"start_character":0,"end_line":62,"end_character":56},"updated":"2018-07-17 22:26:07.000000000","message":"you don\u0027t need this line","commit_id":"db8c3ea38dbdfa08718c5082f080986234b4c65c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aa8044c5efb443e2fb032476842d0f4f0b7abada","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from manila import share"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class ShareAccessMetadataController(wsgi.Controller, wsgi.AdminActionsMixin):"},{"line_number":31,"context_line":"    \"\"\"The Share access rule metadata API V2 controller.\"\"\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    resource_name \u003d \u0027share_access_metadata\u0027"}],"source_content_type":"text/x-python","patch_set":20,"id":"5f7c97a3_a18523b0","line":30,"range":{"start_line":30,"start_character":53,"end_line":30,"end_character":75},"updated":"2018-07-17 23:32:37.000000000","message":"Why do you need this?","commit_id":"892b88a832e8a0941ee75c1aee61627f3b76df66"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2a1920777c122fe5d55f0a89822727d48055cec8","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from manila import share"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class ShareAccessMetadataController(wsgi.Controller, wsgi.AdminActionsMixin):"},{"line_number":31,"context_line":"    \"\"\"The Share access rule metadata API V2 controller.\"\"\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    resource_name \u003d \u0027share_access_metadata\u0027"}],"source_content_type":"text/x-python","patch_set":20,"id":"5f7c97a3_0c0c4b37","line":30,"range":{"start_line":30,"start_character":53,"end_line":30,"end_character":75},"in_reply_to":"5f7c97a3_a18523b0","updated":"2018-07-18 00:29:57.000000000","message":"Done","commit_id":"892b88a832e8a0941ee75c1aee61627f3b76df66"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"603a08670987620253c8877e894537f8bde832df","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        metadata \u003d body[\u0027metadata\u0027]"},{"line_number":48,"context_line":"        self._update_share_access_metadata(context, access_id, metadata)"},{"line_number":49,"context_line":"        return body"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @wsgi.Controller.api_version(\u00272.45\u0027)"},{"line_number":52,"context_line":"    @wsgi.Controller.authorize"}],"source_content_type":"text/x-python","patch_set":20,"id":"5f7c97a3_d0c90f79","line":49,"range":{"start_line":49,"start_character":15,"end_line":49,"end_character":19},"updated":"2018-07-17 22:26:07.000000000","message":"? Does this API even need a response? If it does, any json object must be sent through the view builder for consistency","commit_id":"892b88a832e8a0941ee75c1aee61627f3b76df66"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2a1920777c122fe5d55f0a89822727d48055cec8","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"        metadata \u003d body[\u0027metadata\u0027]"},{"line_number":48,"context_line":"        self._update_share_access_metadata(context, access_id, metadata)"},{"line_number":49,"context_line":"        return body"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    @wsgi.Controller.api_version(\u00272.45\u0027)"},{"line_number":52,"context_line":"    @wsgi.Controller.authorize"}],"source_content_type":"text/x-python","patch_set":20,"id":"5f7c97a3_09c51d3d","line":49,"range":{"start_line":49,"start_character":15,"end_line":49,"end_character":19},"in_reply_to":"5f7c97a3_d0c90f79","updated":"2018-07-18 00:29:57.000000000","message":"Done","commit_id":"892b88a832e8a0941ee75c1aee61627f3b76df66"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"603a08670987620253c8877e894537f8bde832df","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            db.share_access_metadata_delete(context, access_id, key)"},{"line_number":60,"context_line":"        except exception.ShareAccessMetadataNotFound as error:"},{"line_number":61,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003derror.msg)"},{"line_number":62,"context_line":"        return webob.Response(status_int\u003dhttp_client.OK)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _update_share_access_metadata(self, context, access_id, metadata):"},{"line_number":65,"context_line":"        self._assert_access_exists(context, access_id)"}],"source_content_type":"text/x-python","patch_set":20,"id":"5f7c97a3_309e4369","line":62,"range":{"start_line":62,"start_character":8,"end_line":62,"end_character":56},"updated":"2018-07-17 22:26:07.000000000","message":"This is not necessary, line 53 will take care of the return value","commit_id":"892b88a832e8a0941ee75c1aee61627f3b76df66"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2a1920777c122fe5d55f0a89822727d48055cec8","unresolved":false,"context_lines":[{"line_number":59,"context_line":"            db.share_access_metadata_delete(context, access_id, key)"},{"line_number":60,"context_line":"        except exception.ShareAccessMetadataNotFound as error:"},{"line_number":61,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003derror.msg)"},{"line_number":62,"context_line":"        return webob.Response(status_int\u003dhttp_client.OK)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _update_share_access_metadata(self, context, access_id, metadata):"},{"line_number":65,"context_line":"        self._assert_access_exists(context, access_id)"}],"source_content_type":"text/x-python","patch_set":20,"id":"5f7c97a3_29dfb90b","line":62,"range":{"start_line":62,"start_character":8,"end_line":62,"end_character":56},"in_reply_to":"5f7c97a3_309e4369","updated":"2018-07-18 00:29:57.000000000","message":"Done","commit_id":"892b88a832e8a0941ee75c1aee61627f3b76df66"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e1f556c2c11065341528b43078a8f3314809171","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\"\"\"The share access rule metadata api.\"\"\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import webob"},{"line_number":19,"context_line":"from webob import exc"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from manila.api.openstack import wsgi"},{"line_number":22,"context_line":"from manila.api.views import share_access_metadata as access_metadata_views"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_169f6351","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":21},"updated":"2018-07-18 23:17:35.000000000","message":"you don\u0027t need this?","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"11976fc9d82a431c63035a1e286bf5d6bc119459","unresolved":false,"context_lines":[{"line_number":16,"context_line":"\"\"\"The share access rule metadata api.\"\"\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import webob"},{"line_number":19,"context_line":"from webob import exc"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"from manila.api.openstack import wsgi"},{"line_number":22,"context_line":"from manila.api.views import share_access_metadata as access_metadata_views"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_acc3ae89","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":21},"in_reply_to":"5f7c97a3_169f6351","updated":"2018-07-19 12:53:47.000000000","message":"Done","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e1f556c2c11065341528b43078a8f3314809171","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    @wsgi.Controller.authorize"},{"line_number":41,"context_line":"    def update(self, req, access_id, body\u003dNone):"},{"line_number":42,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":43,"context_line":"        if not self.is_valid_body(body, \u0027metadata\u0027):"},{"line_number":44,"context_line":"            raise webob.exc.HTTPBadRequest()"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        metadata \u003d body[\u0027metadata\u0027]"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_54df130a","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":52},"updated":"2018-07-18 23:17:35.000000000","message":"not covered by unit tests","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"11976fc9d82a431c63035a1e286bf5d6bc119459","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    @wsgi.Controller.authorize"},{"line_number":41,"context_line":"    def update(self, req, access_id, body\u003dNone):"},{"line_number":42,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":43,"context_line":"        if not self.is_valid_body(body, \u0027metadata\u0027):"},{"line_number":44,"context_line":"            raise webob.exc.HTTPBadRequest()"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"        metadata \u003d body[\u0027metadata\u0027]"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_ef667828","line":43,"range":{"start_line":43,"start_character":0,"end_line":43,"end_character":52},"in_reply_to":"5f7c97a3_54df130a","updated":"2018-07-19 12:53:47.000000000","message":"Done","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e1f556c2c11065341528b43078a8f3314809171","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        except exception.ShareAccessMetadataNotFound as error:"},{"line_number":60,"context_line":"            raise webob.exc.HTTPNotFound(explanation\u003derror.msg)"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    def _update_share_access_metadata(self, context, access_id, metadata):"},{"line_number":63,"context_line":"        self._assert_access_exists(context, access_id)"},{"line_number":64,"context_line":"        try:"},{"line_number":65,"context_line":"            return self.share_api.update_share_access_metadata("},{"line_number":66,"context_line":"                context, access_id, metadata)"},{"line_number":67,"context_line":"        except (ValueError, AttributeError):"},{"line_number":68,"context_line":"            msg \u003d _(\"Malformed request body\")"},{"line_number":69,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        except exception.InvalidMetadata as error:"},{"line_number":72,"context_line":"            raise exc.HTTPBadRequest(explanation\u003derror.msg)"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        except exception.InvalidMetadataSize as error:"},{"line_number":75,"context_line":"            raise exc.HTTPBadRequest(explanation\u003derror.msg)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def _assert_access_exists(self, context, access_id):"},{"line_number":78,"context_line":"        try:"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_b4dea70d","line":75,"range":{"start_line":62,"start_character":0,"end_line":75,"end_character":59},"updated":"2018-07-18 23:17:35.000000000","message":"not covered by unit tests","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"}],"manila/api/v2/share_accesses.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"537d340b26de9a7e5eeb732068d3f590b6c7dd1b","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    @wsgi.Controller.api_version(\u00272.45\u0027)"},{"line_number":40,"context_line":"    @wsgi.Controller.authorize(\u0027get\u0027)"},{"line_number":41,"context_line":"    def show(self, req, id):"},{"line_number":42,"context_line":"        \"\"\"Return data about the given share access.\"\"\""},{"line_number":43,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":44,"context_line":"        share_access \u003d self._get_share_access(context, id)"},{"line_number":45,"context_line":"        return self._view_builder.view(req, share_access)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_c81c7b68","line":42,"range":{"start_line":42,"start_character":51,"end_line":42,"end_character":52},"updated":"2018-07-12 06:03:00.000000000","message":"rule","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2450b68e9648b36b1280649928709b2661b6f62e","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    @wsgi.Controller.api_version(\u00272.45\u0027)"},{"line_number":40,"context_line":"    @wsgi.Controller.authorize(\u0027get\u0027)"},{"line_number":41,"context_line":"    def show(self, req, id):"},{"line_number":42,"context_line":"        \"\"\"Return data about the given share access.\"\"\""},{"line_number":43,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":44,"context_line":"        share_access \u003d self._get_share_access(context, id)"},{"line_number":45,"context_line":"        return self._view_builder.view(req, share_access)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_8883e3aa","line":42,"range":{"start_line":42,"start_character":51,"end_line":42,"end_character":52},"in_reply_to":"5f7c97a3_c81c7b68","updated":"2018-07-12 08:06:06.000000000","message":"Done","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"537d340b26de9a7e5eeb732068d3f590b6c7dd1b","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        try:"},{"line_number":49,"context_line":"            return self.share_api.access_get(context, share_access_id)"},{"line_number":50,"context_line":"        except exception.NotFound:"},{"line_number":51,"context_line":"            msg \u003d _(\"Share access %s not found.\") % share_access_id"},{"line_number":52,"context_line":"            raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @wsgi.Controller.api_version(\u00272.45\u0027)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_883683e8","line":51,"range":{"start_line":51,"start_character":27,"end_line":51,"end_character":33},"updated":"2018-07-12 06:03:00.000000000","message":"access rule","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2450b68e9648b36b1280649928709b2661b6f62e","unresolved":false,"context_lines":[{"line_number":48,"context_line":"        try:"},{"line_number":49,"context_line":"            return self.share_api.access_get(context, share_access_id)"},{"line_number":50,"context_line":"        except exception.NotFound:"},{"line_number":51,"context_line":"            msg \u003d _(\"Share access %s not found.\") % share_access_id"},{"line_number":52,"context_line":"            raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    @wsgi.Controller.api_version(\u00272.45\u0027)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_488dcbd2","line":51,"range":{"start_line":51,"start_character":27,"end_line":51,"end_character":33},"in_reply_to":"5f7c97a3_883683e8","updated":"2018-07-12 08:06:06.000000000","message":"Done","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"537d340b26de9a7e5eeb732068d3f590b6c7dd1b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    @wsgi.Controller.api_version(\u00272.45\u0027)"},{"line_number":55,"context_line":"    @wsgi.Controller.authorize"},{"line_number":56,"context_line":"    def index(self, req):"},{"line_number":57,"context_line":"        \"\"\"Returns the list of access for a given share.\"\"\""},{"line_number":58,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":59,"context_line":"        search_opts \u003d {}"},{"line_number":60,"context_line":"        search_opts.update(req.GET)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_a8333ff7","line":57,"range":{"start_line":57,"start_character":31,"end_line":57,"end_character":37},"updated":"2018-07-12 06:03:00.000000000","message":"access rules","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2450b68e9648b36b1280649928709b2661b6f62e","unresolved":false,"context_lines":[{"line_number":54,"context_line":"    @wsgi.Controller.api_version(\u00272.45\u0027)"},{"line_number":55,"context_line":"    @wsgi.Controller.authorize"},{"line_number":56,"context_line":"    def index(self, req):"},{"line_number":57,"context_line":"        \"\"\"Returns the list of access for a given share.\"\"\""},{"line_number":58,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":59,"context_line":"        search_opts \u003d {}"},{"line_number":60,"context_line":"        search_opts.update(req.GET)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_c8b23b97","line":57,"range":{"start_line":57,"start_character":31,"end_line":57,"end_character":37},"in_reply_to":"5f7c97a3_a8333ff7","updated":"2018-07-12 08:06:06.000000000","message":"Done","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"537d340b26de9a7e5eeb732068d3f590b6c7dd1b","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":59,"context_line":"        search_opts \u003d {}"},{"line_number":60,"context_line":"        search_opts.update(req.GET)"},{"line_number":61,"context_line":"        share_id \u003d search_opts.pop(\u0027share_id\u0027, None)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        if \u0027metadata\u0027 in search_opts:"},{"line_number":64,"context_line":"            search_opts[\u0027metadata\u0027] \u003d ast.literal_eval("}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_682d278e","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":52},"updated":"2018-07-12 06:03:00.000000000","message":"check here for share_id.. should be a mandatory query key..","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2450b68e9648b36b1280649928709b2661b6f62e","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":59,"context_line":"        search_opts \u003d {}"},{"line_number":60,"context_line":"        search_opts.update(req.GET)"},{"line_number":61,"context_line":"        share_id \u003d search_opts.pop(\u0027share_id\u0027, None)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        if \u0027metadata\u0027 in search_opts:"},{"line_number":64,"context_line":"            search_opts[\u0027metadata\u0027] \u003d ast.literal_eval("}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_135dc87b","line":61,"range":{"start_line":61,"start_character":0,"end_line":61,"end_character":52},"in_reply_to":"5f7c97a3_682d278e","updated":"2018-07-12 08:06:06.000000000","message":"Done","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"603a08670987620253c8877e894537f8bde832df","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        search_opts \u003d {}"},{"line_number":60,"context_line":"        search_opts.update(req.GET)"},{"line_number":61,"context_line":"        if \u0027share_id\u0027 not in search_opts:"},{"line_number":62,"context_line":"            msg \u003d _(\"The field \u0027share_id\u0027not be set.\")"},{"line_number":63,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":64,"context_line":"        share_id \u003d search_opts.pop(\u0027share_id\u0027, None)"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_d5995d1e","line":62,"range":{"start_line":62,"start_character":21,"end_line":62,"end_character":51},"updated":"2018-07-17 22:26:07.000000000","message":"\u0027share_id\u0027 has not been specified.","commit_id":"db8c3ea38dbdfa08718c5082f080986234b4c65c"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"603a08670987620253c8877e894537f8bde832df","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        search_opts \u003d {}"},{"line_number":60,"context_line":"        search_opts.update(req.GET)"},{"line_number":61,"context_line":"        if \u0027share_id\u0027 not in search_opts:"},{"line_number":62,"context_line":"            msg \u003d _(\"The field \u0027share_id\u0027not be set.\")"},{"line_number":63,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":64,"context_line":"        share_id \u003d search_opts.pop(\u0027share_id\u0027, None)"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"5f7c97a3_c1637fdc","line":62,"range":{"start_line":62,"start_character":20,"end_line":62,"end_character":53},"updated":"2018-07-17 22:26:07.000000000","message":"The field \u0027share_id\u0027 has to be specified.","commit_id":"892b88a832e8a0941ee75c1aee61627f3b76df66"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2a1920777c122fe5d55f0a89822727d48055cec8","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        search_opts \u003d {}"},{"line_number":60,"context_line":"        search_opts.update(req.GET)"},{"line_number":61,"context_line":"        if \u0027share_id\u0027 not in search_opts:"},{"line_number":62,"context_line":"            msg \u003d _(\"The field \u0027share_id\u0027not be set.\")"},{"line_number":63,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":64,"context_line":"        share_id \u003d search_opts.pop(\u0027share_id\u0027, None)"},{"line_number":65,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"5f7c97a3_8915ad9d","line":62,"range":{"start_line":62,"start_character":20,"end_line":62,"end_character":53},"in_reply_to":"5f7c97a3_c1637fdc","updated":"2018-07-18 00:29:57.000000000","message":"Done","commit_id":"892b88a832e8a0941ee75c1aee61627f3b76df66"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"603a08670987620253c8877e894537f8bde832df","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        access_rules \u003d self.share_api.access_get_all("},{"line_number":75,"context_line":"            context, share, search_opts)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        return self._view_builder.list_view_with_new_API(req, access_rules)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"def create_resource():"}],"source_content_type":"text/x-python","patch_set":20,"id":"5f7c97a3_61b14b45","line":77,"range":{"start_line":77,"start_character":34,"end_line":77,"end_character":56},"updated":"2018-07-17 22:26:07.000000000","message":"Can you use the api version in the request to distinguish this within the view builder?","commit_id":"892b88a832e8a0941ee75c1aee61627f3b76df66"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2a1920777c122fe5d55f0a89822727d48055cec8","unresolved":false,"context_lines":[{"line_number":74,"context_line":"        access_rules \u003d self.share_api.access_get_all("},{"line_number":75,"context_line":"            context, share, search_opts)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"        return self._view_builder.list_view_with_new_API(req, access_rules)"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"def create_resource():"}],"source_content_type":"text/x-python","patch_set":20,"id":"5f7c97a3_490b157b","line":77,"range":{"start_line":77,"start_character":34,"end_line":77,"end_character":56},"in_reply_to":"5f7c97a3_61b14b45","updated":"2018-07-18 00:29:57.000000000","message":"Done","commit_id":"892b88a832e8a0941ee75c1aee61627f3b76df66"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e1f556c2c11065341528b43078a8f3314809171","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import ast"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from webob import exc"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from manila.api.openstack import wsgi"},{"line_number":23,"context_line":"from manila.api.views import share_accesses as share_access_views"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_76e497df","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":21},"updated":"2018-07-18 23:17:35.000000000","message":"import webob, and not exc directly\n\n https://docs.openstack.org/hacking/latest/user/hacking.html#imports","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"11976fc9d82a431c63035a1e286bf5d6bc119459","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"import ast"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from webob import exc"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from manila.api.openstack import wsgi"},{"line_number":23,"context_line":"from manila.api.views import share_accesses as share_access_views"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_cf6cdc9e","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":21},"in_reply_to":"5f7c97a3_76e497df","updated":"2018-07-19 12:53:47.000000000","message":"Done","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e1f556c2c11065341528b43078a8f3314809171","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":59,"context_line":"        search_opts \u003d {}"},{"line_number":60,"context_line":"        search_opts.update(req.GET)"},{"line_number":61,"context_line":"        if \u0027share_id\u0027 not in search_opts:"},{"line_number":62,"context_line":"            msg \u003d _(\"The field \u0027share_id\u0027 has to be specified.\")"},{"line_number":63,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":64,"context_line":"        share_id \u003d search_opts.pop(\u0027share_id\u0027, None)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        if \u0027metadata\u0027 in search_opts:"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_8a97c09c","line":63,"range":{"start_line":61,"start_character":0,"end_line":63,"end_character":53},"updated":"2018-07-18 23:17:35.000000000","message":"please add a unit test, it\u0027s rather important","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"11976fc9d82a431c63035a1e286bf5d6bc119459","unresolved":false,"context_lines":[{"line_number":58,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":59,"context_line":"        search_opts \u003d {}"},{"line_number":60,"context_line":"        search_opts.update(req.GET)"},{"line_number":61,"context_line":"        if \u0027share_id\u0027 not in search_opts:"},{"line_number":62,"context_line":"            msg \u003d _(\"The field \u0027share_id\u0027 has to be specified.\")"},{"line_number":63,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":64,"context_line":"        share_id \u003d search_opts.pop(\u0027share_id\u0027, None)"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        if \u0027metadata\u0027 in search_opts:"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_6f282897","line":63,"range":{"start_line":61,"start_character":0,"end_line":63,"end_character":53},"in_reply_to":"5f7c97a3_8a97c09c","updated":"2018-07-19 12:53:47.000000000","message":"Done","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"}],"manila/api/v2/shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"603a08670987620253c8877e894537f8bde832df","unresolved":false,"context_lines":[{"line_number":368,"context_line":"        \"\"\"List share access rules.\"\"\""},{"line_number":369,"context_line":"        return self._access_list(req, id, body)"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    @wsgi.Controller.api_version(\u00272.7\u0027)"},{"line_number":372,"context_line":"    @wsgi.action(\u0027access_list\u0027)"},{"line_number":373,"context_line":"    def access_list(self, req, id, body):"},{"line_number":374,"context_line":"        \"\"\"List share access rules.\"\"\""},{"line_number":375,"context_line":"        return self._access_list(req, id, body)"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"    @wsgi.Controller.api_version(\u00272.0\u0027, \u00272.6\u0027)"},{"line_number":378,"context_line":"    @wsgi.action(\u0027os-extend\u0027)"}],"source_content_type":"text/x-python","patch_set":20,"id":"5f7c97a3_816d8768","line":375,"range":{"start_line":371,"start_character":0,"end_line":375,"end_character":47},"updated":"2018-07-17 22:26:07.000000000","message":"As per your comment on PS 17 [1] - you meant to deprecate this API, but you haven\u0027t\n\n\n[1] https://review.openstack.org/#/c/570708/17/manila/api/views/share_accesses.py@29","commit_id":"892b88a832e8a0941ee75c1aee61627f3b76df66"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2a1920777c122fe5d55f0a89822727d48055cec8","unresolved":false,"context_lines":[{"line_number":368,"context_line":"        \"\"\"List share access rules.\"\"\""},{"line_number":369,"context_line":"        return self._access_list(req, id, body)"},{"line_number":370,"context_line":""},{"line_number":371,"context_line":"    @wsgi.Controller.api_version(\u00272.7\u0027)"},{"line_number":372,"context_line":"    @wsgi.action(\u0027access_list\u0027)"},{"line_number":373,"context_line":"    def access_list(self, req, id, body):"},{"line_number":374,"context_line":"        \"\"\"List share access rules.\"\"\""},{"line_number":375,"context_line":"        return self._access_list(req, id, body)"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"    @wsgi.Controller.api_version(\u00272.0\u0027, \u00272.6\u0027)"},{"line_number":378,"context_line":"    @wsgi.action(\u0027os-extend\u0027)"}],"source_content_type":"text/x-python","patch_set":20,"id":"5f7c97a3_49ceb52c","line":375,"range":{"start_line":371,"start_character":0,"end_line":375,"end_character":47},"in_reply_to":"5f7c97a3_816d8768","updated":"2018-07-18 00:29:57.000000000","message":"Done","commit_id":"892b88a832e8a0941ee75c1aee61627f3b76df66"}],"manila/api/views/share_access_metadata.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ab8c44aaa874c431e4e11918b1b876413b8d5a32","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"5f7c97a3_a372efae","updated":"2018-07-18 19:12:03.000000000","message":"this method can be added to the share access view builder class..","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"11976fc9d82a431c63035a1e286bf5d6bc119459","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":27,"id":"5f7c97a3_af0ba028","in_reply_to":"5f7c97a3_a372efae","updated":"2018-07-19 12:53:47.000000000","message":"Done","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"}],"manila/api/views/share_accesses.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"537d340b26de9a7e5eeb732068d3f590b6c7dd1b","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        \"add_access_key\","},{"line_number":27,"context_line":"        \"translate_transitional_statuses\","},{"line_number":28,"context_line":"        \"add_created_at_and_updated_at\","},{"line_number":29,"context_line":"        \"add_access_rule_metadata_field\","},{"line_number":30,"context_line":"    ]"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def list_view(self, request, accesses):"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_e86ff7c1","line":29,"range":{"start_line":29,"start_character":8,"end_line":29,"end_character":40},"updated":"2018-07-12 06:03:00.000000000","message":"This should only be added to the new API - the old API (POST /shares/{share-id}/action with body {\u0027action\u0027: \u0027access_list\u0027} \n\nshould be unmodified..","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2450b68e9648b36b1280649928709b2661b6f62e","unresolved":false,"context_lines":[{"line_number":26,"context_line":"        \"add_access_key\","},{"line_number":27,"context_line":"        \"translate_transitional_statuses\","},{"line_number":28,"context_line":"        \"add_created_at_and_updated_at\","},{"line_number":29,"context_line":"        \"add_access_rule_metadata_field\","},{"line_number":30,"context_line":"    ]"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"    def list_view(self, request, accesses):"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_f3cb6ca1","line":29,"range":{"start_line":29,"start_character":8,"end_line":29,"end_character":40},"in_reply_to":"5f7c97a3_e86ff7c1","updated":"2018-07-12 08:06:06.000000000","message":"The old API (POST /shares/{share-id}/action ) with boday{\u0027action\u0027: \u0027access_list\u0027} will be deprecated at version 2.45. The \"add_access_rule_metadata_field\" will work from version 2.45. So this is only be added to the new API, the old API cannot see the new \"add_access_rule_metadata_field\" response parameters.","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"603a08670987620253c8877e894537f8bde832df","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        return {\u0027access_list\u0027: [self.summary_view(request, access)[\u0027access\u0027]"},{"line_number":35,"context_line":"                                for access in accesses]}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def list_view_with_new_API(self, request, accesses):"},{"line_number":38,"context_line":"        \"\"\"View of a list of share accesses.\"\"\""},{"line_number":39,"context_line":"        return {\u0027accesses\u0027: [self.summary_view(request, access)[\u0027access\u0027]"},{"line_number":40,"context_line":"                             for access in accesses]}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def summary_view(self, request, access):"},{"line_number":43,"context_line":"        \"\"\"Summarized view of a single share access.\"\"\""}],"source_content_type":"text/x-python","patch_set":20,"id":"5f7c97a3_418c4f34","line":40,"range":{"start_line":37,"start_character":3,"end_line":40,"end_character":53},"updated":"2018-07-17 22:26:07.000000000","message":"How is this different from the above method?","commit_id":"892b88a832e8a0941ee75c1aee61627f3b76df66"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7b833ffe1d6563cdb0291aa0fa0a0016bd6a6648","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        return {\u0027access_list\u0027: [self.summary_view(request, access)[\u0027access\u0027]"},{"line_number":35,"context_line":"                                for access in accesses]}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def list_view_with_new_API(self, request, accesses):"},{"line_number":38,"context_line":"        \"\"\"View of a list of share accesses.\"\"\""},{"line_number":39,"context_line":"        return {\u0027accesses\u0027: [self.summary_view(request, access)[\u0027access\u0027]"},{"line_number":40,"context_line":"                             for access in accesses]}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def summary_view(self, request, access):"},{"line_number":43,"context_line":"        \"\"\"Summarized view of a single share access.\"\"\""}],"source_content_type":"text/x-python","patch_set":20,"id":"5f7c97a3_495795ca","line":40,"range":{"start_line":37,"start_character":3,"end_line":40,"end_character":53},"in_reply_to":"5f7c97a3_418c4f34","updated":"2018-07-17 23:13:05.000000000","message":"The function list_view body node name is \"access_list\", the new function is \"access\".","commit_id":"892b88a832e8a0941ee75c1aee61627f3b76df66"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"aa8044c5efb443e2fb032476842d0f4f0b7abada","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        return {\u0027access_list\u0027: [self.summary_view(request, access)[\u0027access\u0027]"},{"line_number":35,"context_line":"                                for access in accesses]}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def list_view_with_new_API(self, request, accesses):"},{"line_number":38,"context_line":"        \"\"\"View of a list of share accesses.\"\"\""},{"line_number":39,"context_line":"        return {\u0027accesses\u0027: [self.summary_view(request, access)[\u0027access\u0027]"},{"line_number":40,"context_line":"                             for access in accesses]}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def summary_view(self, request, access):"},{"line_number":43,"context_line":"        \"\"\"Summarized view of a single share access.\"\"\""}],"source_content_type":"text/x-python","patch_set":20,"id":"5f7c97a3_c91645a2","line":40,"range":{"start_line":37,"start_character":3,"end_line":40,"end_character":53},"in_reply_to":"5f7c97a3_495795ca","updated":"2018-07-17 23:32:37.000000000","message":"Lets retain it as \"access_list\", seems like unnecessary churn to change that. Please update the API-ref you\u0027re writing accordingly","commit_id":"892b88a832e8a0941ee75c1aee61627f3b76df66"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2a1920777c122fe5d55f0a89822727d48055cec8","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        return {\u0027access_list\u0027: [self.summary_view(request, access)[\u0027access\u0027]"},{"line_number":35,"context_line":"                                for access in accesses]}"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def list_view_with_new_API(self, request, accesses):"},{"line_number":38,"context_line":"        \"\"\"View of a list of share accesses.\"\"\""},{"line_number":39,"context_line":"        return {\u0027accesses\u0027: [self.summary_view(request, access)[\u0027access\u0027]"},{"line_number":40,"context_line":"                             for access in accesses]}"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"    def summary_view(self, request, access):"},{"line_number":43,"context_line":"        \"\"\"Summarized view of a single share access.\"\"\""}],"source_content_type":"text/x-python","patch_set":20,"id":"5f7c97a3_a9dc29e2","line":40,"range":{"start_line":37,"start_character":3,"end_line":40,"end_character":53},"in_reply_to":"5f7c97a3_c91645a2","updated":"2018-07-18 00:29:57.000000000","message":"Done","commit_id":"892b88a832e8a0941ee75c1aee61627f3b76df66"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ab8c44aaa874c431e4e11918b1b876413b8d5a32","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @common.ViewBuilder.versioned_method(\"2.45\")"},{"line_number":74,"context_line":"    def add_access_rule_metadata_field(self, context, access_dict, access):"},{"line_number":75,"context_line":"        metadata \u003d access.get(\u0027share_access_rules_metadata\u0027)"},{"line_number":76,"context_line":"        if metadata:"},{"line_number":77,"context_line":"            metadata \u003d {item[\u0027key\u0027]: item[\u0027value\u0027] for item in metadata}"},{"line_number":78,"context_line":"        else:"},{"line_number":79,"context_line":"            metadata \u003d {}"},{"line_number":80,"context_line":"        access_dict[\u0027metadata\u0027] \u003d metadata"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @common.ViewBuilder.versioned_method(\"1.0\", \"2.27\")"},{"line_number":83,"context_line":"    def translate_transitional_statuses(self, context, access_dict, access):"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_60c92d22","line":80,"range":{"start_line":75,"start_character":8,"end_line":80,"end_character":42},"updated":"2018-07-18 19:12:03.000000000","message":"metadata \u003d access.get(\u0027share_access_rules_metadata\u0027) or {}\n metadata \u003d {item[\u0027key\u0027]: item[\u0027value\u0027] for item in metadata}\n access_dict[\u0027metadata\u0027] \u003d metadata","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"11976fc9d82a431c63035a1e286bf5d6bc119459","unresolved":false,"context_lines":[{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @common.ViewBuilder.versioned_method(\"2.45\")"},{"line_number":74,"context_line":"    def add_access_rule_metadata_field(self, context, access_dict, access):"},{"line_number":75,"context_line":"        metadata \u003d access.get(\u0027share_access_rules_metadata\u0027)"},{"line_number":76,"context_line":"        if metadata:"},{"line_number":77,"context_line":"            metadata \u003d {item[\u0027key\u0027]: item[\u0027value\u0027] for item in metadata}"},{"line_number":78,"context_line":"        else:"},{"line_number":79,"context_line":"            metadata \u003d {}"},{"line_number":80,"context_line":"        access_dict[\u0027metadata\u0027] \u003d metadata"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @common.ViewBuilder.versioned_method(\"1.0\", \"2.27\")"},{"line_number":83,"context_line":"    def translate_transitional_statuses(self, context, access_dict, access):"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_afcde086","line":80,"range":{"start_line":75,"start_character":8,"end_line":80,"end_character":42},"in_reply_to":"5f7c97a3_60c92d22","updated":"2018-07-19 12:53:47.000000000","message":"Done","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"}],"manila/db/api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"537d340b26de9a7e5eeb732068d3f590b6c7dd1b","unresolved":false,"context_lines":[{"line_number":490,"context_line":"    return IMPL.share_instance_access_delete(context, mapping_id)"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"def share_access_metadata_update(context, access_id, metadata, session\u003dNone):"},{"line_number":494,"context_line":"    \"\"\"Update metadata of share access rule.\"\"\""},{"line_number":495,"context_line":"    return IMPL.share_access_metadata_update("},{"line_number":496,"context_line":"        context, access_id, metadata, session)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_88a9a3df","line":493,"range":{"start_line":493,"start_character":63,"end_line":493,"end_character":75},"updated":"2018-07-12 06:03:00.000000000","message":"We only create sessions inside the lower sqlalchemy API layer..","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2450b68e9648b36b1280649928709b2661b6f62e","unresolved":false,"context_lines":[{"line_number":490,"context_line":"    return IMPL.share_instance_access_delete(context, mapping_id)"},{"line_number":491,"context_line":""},{"line_number":492,"context_line":""},{"line_number":493,"context_line":"def share_access_metadata_update(context, access_id, metadata, session\u003dNone):"},{"line_number":494,"context_line":"    \"\"\"Update metadata of share access rule.\"\"\""},{"line_number":495,"context_line":"    return IMPL.share_access_metadata_update("},{"line_number":496,"context_line":"        context, access_id, metadata, session)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_53eee0b5","line":493,"range":{"start_line":493,"start_character":63,"end_line":493,"end_character":75},"in_reply_to":"5f7c97a3_88a9a3df","updated":"2018-07-12 08:06:06.000000000","message":"Done","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e1f556c2c11065341528b43078a8f3314809171","unresolved":false,"context_lines":[{"line_number":431,"context_line":""},{"line_number":432,"context_line":"def share_access_get_all_for_share(context, share_id, filters\u003dNone):"},{"line_number":433,"context_line":"    \"\"\"Get all access rules for given share.\"\"\""},{"line_number":434,"context_line":"    return IMPL.share_access_get_all_for_share(context, share_id, filters)"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"def share_access_get_all_for_instance(context, instance_id, filters\u003dNone,"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_5968acba","line":434,"range":{"start_line":434,"start_character":66,"end_line":434,"end_character":73},"updated":"2018-07-18 23:17:35.000000000","message":"pass kwargs as kwargs","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"11976fc9d82a431c63035a1e286bf5d6bc119459","unresolved":false,"context_lines":[{"line_number":431,"context_line":""},{"line_number":432,"context_line":"def share_access_get_all_for_share(context, share_id, filters\u003dNone):"},{"line_number":433,"context_line":"    \"\"\"Get all access rules for given share.\"\"\""},{"line_number":434,"context_line":"    return IMPL.share_access_get_all_for_share(context, share_id, filters)"},{"line_number":435,"context_line":""},{"line_number":436,"context_line":""},{"line_number":437,"context_line":"def share_access_get_all_for_instance(context, instance_id, filters\u003dNone,"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_0f8174fa","line":434,"range":{"start_line":434,"start_character":66,"end_line":434,"end_character":73},"in_reply_to":"5f7c97a3_5968acba","updated":"2018-07-19 12:53:47.000000000","message":"Done","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"}],"manila/db/migrations/alembic/versions/11ee96se625f3_add_metadata_for_access.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"537d340b26de9a7e5eeb732068d3f590b6c7dd1b","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Revision ID: 11ee96se625f3"},{"line_number":19,"context_line":"Revises: 0274d20c560f"},{"line_number":20,"context_line":"Create Date: 2015-01-16 03:07:15.548947"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"\"\"\""},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_68b0c741","line":20,"range":{"start_line":20,"start_character":13,"end_line":20,"end_character":23},"updated":"2018-07-12 06:03:00.000000000","message":"that\u0027s really old :P","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2450b68e9648b36b1280649928709b2661b6f62e","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Revision ID: 11ee96se625f3"},{"line_number":19,"context_line":"Revises: 0274d20c560f"},{"line_number":20,"context_line":"Create Date: 2015-01-16 03:07:15.548947"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"\"\"\""},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_13486860","line":20,"range":{"start_line":20,"start_character":13,"end_line":20,"end_character":23},"in_reply_to":"5f7c97a3_68b0c741","updated":"2018-07-12 08:06:06.000000000","message":"Done","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"537d340b26de9a7e5eeb732068d3f590b6c7dd1b","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    try:"},{"line_number":39,"context_line":"        op.create_table("},{"line_number":40,"context_line":"            access_metadata_table_name,"},{"line_number":41,"context_line":"            sql.Column(\u0027created_at\u0027, sql.DateTime),"},{"line_number":42,"context_line":"            sql.Column(\u0027updated_at\u0027, sql.DateTime),"},{"line_number":43,"context_line":"            sql.Column(\u0027deleted_at\u0027, sql.DateTime),"},{"line_number":44,"context_line":"            sql.Column(\u0027deleted\u0027, sql.String(36), default\u003d\u0027False\u0027),"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_e87db76d","line":41,"range":{"start_line":41,"start_character":41,"end_line":41,"end_character":49},"updated":"2018-07-12 06:03:00.000000000","message":"DateTime(timezone\u003dFalse)\n\nsame below","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2450b68e9648b36b1280649928709b2661b6f62e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    try:"},{"line_number":39,"context_line":"        op.create_table("},{"line_number":40,"context_line":"            access_metadata_table_name,"},{"line_number":41,"context_line":"            sql.Column(\u0027created_at\u0027, sql.DateTime),"},{"line_number":42,"context_line":"            sql.Column(\u0027updated_at\u0027, sql.DateTime),"},{"line_number":43,"context_line":"            sql.Column(\u0027deleted_at\u0027, sql.DateTime),"},{"line_number":44,"context_line":"            sql.Column(\u0027deleted\u0027, sql.String(36), default\u003d\u0027False\u0027),"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_f3560c06","line":41,"range":{"start_line":41,"start_character":41,"end_line":41,"end_character":49},"in_reply_to":"5f7c97a3_e87db76d","updated":"2018-07-12 08:06:06.000000000","message":"Done","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"537d340b26de9a7e5eeb732068d3f590b6c7dd1b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                       sql.ForeignKey(\u0027share_access_map.id\u0027), nullable\u003dFalse),"},{"line_number":47,"context_line":"            sql.Column(\u0027key\u0027, sql.String(255), nullable\u003dFalse),"},{"line_number":48,"context_line":"            sql.Column(\u0027value\u0027, sql.String(1023), nullable\u003dFalse),"},{"line_number":49,"context_line":"            sql.Column(\u0027id\u0027, sql.Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":50,"context_line":"            mysql_engine\u003d\u0027InnoDB\u0027,"},{"line_number":51,"context_line":"        )"},{"line_number":52,"context_line":"    except Exception:"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_6889a76d","line":49,"range":{"start_line":49,"start_character":29,"end_line":49,"end_character":40},"updated":"2018-07-12 06:03:00.000000000","message":"why Integer and not UUID?","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"f985b45fef31a58f393c43b45656505acc788733","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                       sql.ForeignKey(\u0027share_access_map.id\u0027), nullable\u003dFalse),"},{"line_number":47,"context_line":"            sql.Column(\u0027key\u0027, sql.String(255), nullable\u003dFalse),"},{"line_number":48,"context_line":"            sql.Column(\u0027value\u0027, sql.String(1023), nullable\u003dFalse),"},{"line_number":49,"context_line":"            sql.Column(\u0027id\u0027, sql.Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":50,"context_line":"            mysql_engine\u003d\u0027InnoDB\u0027,"},{"line_number":51,"context_line":"        )"},{"line_number":52,"context_line":"    except Exception:"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_d5cb9d1a","line":49,"range":{"start_line":49,"start_character":29,"end_line":49,"end_character":40},"in_reply_to":"5f7c97a3_139628a2","updated":"2018-07-13 00:11:06.000000000","message":"it can be integer, as with export_location_metadata","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2450b68e9648b36b1280649928709b2661b6f62e","unresolved":false,"context_lines":[{"line_number":46,"context_line":"                       sql.ForeignKey(\u0027share_access_map.id\u0027), nullable\u003dFalse),"},{"line_number":47,"context_line":"            sql.Column(\u0027key\u0027, sql.String(255), nullable\u003dFalse),"},{"line_number":48,"context_line":"            sql.Column(\u0027value\u0027, sql.String(1023), nullable\u003dFalse),"},{"line_number":49,"context_line":"            sql.Column(\u0027id\u0027, sql.Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":50,"context_line":"            mysql_engine\u003d\u0027InnoDB\u0027,"},{"line_number":51,"context_line":"        )"},{"line_number":52,"context_line":"    except Exception:"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_139628a2","line":49,"range":{"start_line":49,"start_character":29,"end_line":49,"end_character":40},"in_reply_to":"5f7c97a3_6889a76d","updated":"2018-07-12 08:06:06.000000000","message":"It consistent with share metadata Integer ID, and we could use some common function, Do we have to set id to UUID for metadata resouce?","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"537d340b26de9a7e5eeb732068d3f590b6c7dd1b","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            sql.Column(\u0027key\u0027, sql.String(255), nullable\u003dFalse),"},{"line_number":48,"context_line":"            sql.Column(\u0027value\u0027, sql.String(1023), nullable\u003dFalse),"},{"line_number":49,"context_line":"            sql.Column(\u0027id\u0027, sql.Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":50,"context_line":"            mysql_engine\u003d\u0027InnoDB\u0027,"},{"line_number":51,"context_line":"        )"},{"line_number":52,"context_line":"    except Exception:"},{"line_number":53,"context_line":"        LOG.error(\"Table |%s| not created!\","}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_a88fbf74","line":50,"range":{"start_line":50,"start_character":32,"end_line":50,"end_character":34},"updated":"2018-07-12 06:03:00.000000000","message":"mysql_charset\u003d\u0027utf8\u0027","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2450b68e9648b36b1280649928709b2661b6f62e","unresolved":false,"context_lines":[{"line_number":47,"context_line":"            sql.Column(\u0027key\u0027, sql.String(255), nullable\u003dFalse),"},{"line_number":48,"context_line":"            sql.Column(\u0027value\u0027, sql.String(1023), nullable\u003dFalse),"},{"line_number":49,"context_line":"            sql.Column(\u0027id\u0027, sql.Integer, primary_key\u003dTrue, nullable\u003dFalse),"},{"line_number":50,"context_line":"            mysql_engine\u003d\u0027InnoDB\u0027,"},{"line_number":51,"context_line":"        )"},{"line_number":52,"context_line":"    except Exception:"},{"line_number":53,"context_line":"        LOG.error(\"Table |%s| not created!\","}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_933b18c8","line":50,"range":{"start_line":50,"start_character":32,"end_line":50,"end_character":34},"in_reply_to":"5f7c97a3_a88fbf74","updated":"2018-07-12 08:06:06.000000000","message":"Done","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"}],"manila/db/sqlalchemy/api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"537d340b26de9a7e5eeb732068d3f590b6c7dd1b","unresolved":false,"context_lines":[{"line_number":2262,"context_line":""},{"line_number":2263,"context_line":"        # NOTE(u_glide): Remove access rule if all mappings were removed."},{"line_number":2264,"context_line":"        if len(other_mappings) \u003d\u003d 0:"},{"line_number":2265,"context_line":"            (session.query(models.ShareAccessMapping).filter_by("},{"line_number":2266,"context_line":"             id\u003dmapping[\u0027access_id\u0027]).soft_delete())"},{"line_number":2267,"context_line":""},{"line_number":2268,"context_line":"            access_metadata \u003d (_share_access_metadata_get_query("},{"line_number":2269,"context_line":"                context, mapping[\u0027access_id\u0027], session\u003dsession).first())"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_a86b3f84","line":2266,"range":{"start_line":2265,"start_character":12,"end_line":2266,"end_character":52},"updated":"2018-07-12 06:03:00.000000000","message":"The dependent rows in the metadata table must be deleted before deleting the access rule","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2450b68e9648b36b1280649928709b2661b6f62e","unresolved":false,"context_lines":[{"line_number":2262,"context_line":""},{"line_number":2263,"context_line":"        # NOTE(u_glide): Remove access rule if all mappings were removed."},{"line_number":2264,"context_line":"        if len(other_mappings) \u003d\u003d 0:"},{"line_number":2265,"context_line":"            (session.query(models.ShareAccessMapping).filter_by("},{"line_number":2266,"context_line":"             id\u003dmapping[\u0027access_id\u0027]).soft_delete())"},{"line_number":2267,"context_line":""},{"line_number":2268,"context_line":"            access_metadata \u003d (_share_access_metadata_get_query("},{"line_number":2269,"context_line":"                context, mapping[\u0027access_id\u0027], session\u003dsession).first())"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_881f6370","line":2266,"range":{"start_line":2265,"start_character":12,"end_line":2266,"end_character":52},"in_reply_to":"5f7c97a3_a86b3f84","updated":"2018-07-12 08:06:06.000000000","message":"Done","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"537d340b26de9a7e5eeb732068d3f590b6c7dd1b","unresolved":false,"context_lines":[{"line_number":2266,"context_line":"             id\u003dmapping[\u0027access_id\u0027]).soft_delete())"},{"line_number":2267,"context_line":""},{"line_number":2268,"context_line":"            access_metadata \u003d (_share_access_metadata_get_query("},{"line_number":2269,"context_line":"                context, mapping[\u0027access_id\u0027], session\u003dsession).first())"},{"line_number":2270,"context_line":"            if access_metadata:"},{"line_number":2271,"context_line":"                access_metadata.soft_delete(session)"},{"line_number":2272,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_686527af","line":2269,"range":{"start_line":2269,"start_character":64,"end_line":2269,"end_character":71},"updated":"2018-07-12 06:03:00.000000000","message":"just one? you need all of them","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2450b68e9648b36b1280649928709b2661b6f62e","unresolved":false,"context_lines":[{"line_number":2266,"context_line":"             id\u003dmapping[\u0027access_id\u0027]).soft_delete())"},{"line_number":2267,"context_line":""},{"line_number":2268,"context_line":"            access_metadata \u003d (_share_access_metadata_get_query("},{"line_number":2269,"context_line":"                context, mapping[\u0027access_id\u0027], session\u003dsession).first())"},{"line_number":2270,"context_line":"            if access_metadata:"},{"line_number":2271,"context_line":"                access_metadata.soft_delete(session)"},{"line_number":2272,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_b333b4f7","line":2269,"range":{"start_line":2269,"start_character":64,"end_line":2269,"end_character":71},"in_reply_to":"5f7c97a3_686527af","updated":"2018-07-12 08:06:06.000000000","message":"Done","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e1f556c2c11065341528b43078a8f3314809171","unresolved":false,"context_lines":[{"line_number":1965,"context_line":"    if not result:"},{"line_number":1966,"context_line":"        raise exception.ShareAccessMetadataNotFound("},{"line_number":1967,"context_line":"            metadata_key\u003dkey, access_id\u003daccess_id)"},{"line_number":1968,"context_line":""},{"line_number":1969,"context_line":"    return result"},{"line_number":1970,"context_line":""},{"line_number":1971,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_1994748b","line":1968,"range":{"start_line":1968,"start_character":0,"end_line":1968,"end_character":0},"updated":"2018-07-18 23:17:35.000000000","message":"nit: blank line unnecessary","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"11976fc9d82a431c63035a1e286bf5d6bc119459","unresolved":false,"context_lines":[{"line_number":1965,"context_line":"    if not result:"},{"line_number":1966,"context_line":"        raise exception.ShareAccessMetadataNotFound("},{"line_number":1967,"context_line":"            metadata_key\u003dkey, access_id\u003daccess_id)"},{"line_number":1968,"context_line":""},{"line_number":1969,"context_line":"    return result"},{"line_number":1970,"context_line":""},{"line_number":1971,"context_line":""}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_6f710845","line":1968,"range":{"start_line":1968,"start_character":0,"end_line":1968,"end_character":0},"in_reply_to":"5f7c97a3_1994748b","updated":"2018-07-19 12:53:47.000000000","message":"Done","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"}],"manila/db/sqlalchemy/models.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"537d340b26de9a7e5eeb732068d3f590b6c7dd1b","unresolved":false,"context_lines":[{"line_number":579,"context_line":"                       nullable\u003dFalse)"},{"line_number":580,"context_line":"    access \u003d orm.relationship("},{"line_number":581,"context_line":"        ShareAccessMapping, backref\u003d\"share_access_rules_metadata\","},{"line_number":582,"context_line":"        foreign_keys\u003daccess_id,"},{"line_number":583,"context_line":"        primaryjoin\u003d\u0027and_(\u0027"},{"line_number":584,"context_line":"        \u0027ShareAccessRulesMetadata.access_id \u003d\u003d ShareAccessMapping.id,\u0027"},{"line_number":585,"context_line":"        \u0027ShareAccessRulesMetadata.deleted \u003d\u003d \"False\")\u0027)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_28bc0fda","line":582,"range":{"start_line":582,"start_character":30,"end_line":582,"end_character":31},"updated":"2018-07-12 06:03:00.000000000","message":"lazy\u003dimmediate","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2450b68e9648b36b1280649928709b2661b6f62e","unresolved":false,"context_lines":[{"line_number":579,"context_line":"                       nullable\u003dFalse)"},{"line_number":580,"context_line":"    access \u003d orm.relationship("},{"line_number":581,"context_line":"        ShareAccessMapping, backref\u003d\"share_access_rules_metadata\","},{"line_number":582,"context_line":"        foreign_keys\u003daccess_id,"},{"line_number":583,"context_line":"        primaryjoin\u003d\u0027and_(\u0027"},{"line_number":584,"context_line":"        \u0027ShareAccessRulesMetadata.access_id \u003d\u003d ShareAccessMapping.id,\u0027"},{"line_number":585,"context_line":"        \u0027ShareAccessRulesMetadata.deleted \u003d\u003d \"False\")\u0027)"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_885a034f","line":582,"range":{"start_line":582,"start_character":30,"end_line":582,"end_character":31},"in_reply_to":"5f7c97a3_28bc0fda","updated":"2018-07-12 08:06:06.000000000","message":"Done","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"}],"manila/exception.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e1f556c2c11065341528b43078a8f3314809171","unresolved":false,"context_lines":[{"line_number":473,"context_line":""},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"class ShareAccessMetadataNotFound(NotFound):"},{"line_number":476,"context_line":"    message \u003d _(\"Share access rule metadata item is not found.\")"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"class ShareSnapshotAccessExists(InvalidInput):"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_1991d453","line":476,"range":{"start_line":476,"start_character":44,"end_line":476,"end_character":61},"updated":"2018-07-18 23:17:35.000000000","message":"grammatically incorrect - \n\n\"does not exist\" makes better sense","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"11976fc9d82a431c63035a1e286bf5d6bc119459","unresolved":false,"context_lines":[{"line_number":473,"context_line":""},{"line_number":474,"context_line":""},{"line_number":475,"context_line":"class ShareAccessMetadataNotFound(NotFound):"},{"line_number":476,"context_line":"    message \u003d _(\"Share access rule metadata item is not found.\")"},{"line_number":477,"context_line":""},{"line_number":478,"context_line":""},{"line_number":479,"context_line":"class ShareSnapshotAccessExists(InvalidInput):"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_4f90cc42","line":476,"range":{"start_line":476,"start_character":44,"end_line":476,"end_character":61},"in_reply_to":"5f7c97a3_1991d453","updated":"2018-07-19 12:53:47.000000000","message":"Done","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"}],"manila/policies/share_access.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"537d340b26de9a7e5eeb732068d3f590b6c7dd1b","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":36,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027index\u0027,"},{"line_number":37,"context_line":"        check_str\u003dbase.RULE_DEFAULT,"},{"line_number":38,"context_line":"        description\u003d\"List accesses of a share access rule.\","},{"line_number":39,"context_line":"        operations\u003d["},{"line_number":40,"context_line":"            {"},{"line_number":41,"context_line":"                \u0027method\u0027: \u0027GET\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_0db7e5fa","line":38,"range":{"start_line":38,"start_character":26,"end_line":38,"end_character":57},"updated":"2018-07-12 06:03:00.000000000","message":"access rules of a given share","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2450b68e9648b36b1280649928709b2661b6f62e","unresolved":false,"context_lines":[{"line_number":35,"context_line":"    policy.DocumentedRuleDefault("},{"line_number":36,"context_line":"        name\u003dBASE_POLICY_NAME % \u0027index\u0027,"},{"line_number":37,"context_line":"        check_str\u003dbase.RULE_DEFAULT,"},{"line_number":38,"context_line":"        description\u003d\"List accesses of a share access rule.\","},{"line_number":39,"context_line":"        operations\u003d["},{"line_number":40,"context_line":"            {"},{"line_number":41,"context_line":"                \u0027method\u0027: \u0027GET\u0027,"}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_c840fb62","line":38,"range":{"start_line":38,"start_character":26,"end_line":38,"end_character":57},"in_reply_to":"5f7c97a3_0db7e5fa","updated":"2018-07-12 08:06:06.000000000","message":"Done","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"}],"manila/share/api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e1f556c2c11065341528b43078a8f3314809171","unresolved":false,"context_lines":[{"line_number":1678,"context_line":"        \"\"\"Returns all access rules for share.\"\"\""},{"line_number":1679,"context_line":"        policy.check_policy(context, \u0027share\u0027, \u0027access_get_all\u0027)"},{"line_number":1680,"context_line":"        rules \u003d self.db.share_access_get_all_for_share("},{"line_number":1681,"context_line":"            context, share[\u0027id\u0027], filters)"},{"line_number":1682,"context_line":"        return rules"},{"line_number":1683,"context_line":""},{"line_number":1684,"context_line":"    def access_get(self, context, access_id):"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_197a3424","line":1681,"range":{"start_line":1681,"start_character":34,"end_line":1681,"end_character":41},"updated":"2018-07-18 23:17:35.000000000","message":"pass kwargs as kwargs","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"11976fc9d82a431c63035a1e286bf5d6bc119459","unresolved":false,"context_lines":[{"line_number":1678,"context_line":"        \"\"\"Returns all access rules for share.\"\"\""},{"line_number":1679,"context_line":"        policy.check_policy(context, \u0027share\u0027, \u0027access_get_all\u0027)"},{"line_number":1680,"context_line":"        rules \u003d self.db.share_access_get_all_for_share("},{"line_number":1681,"context_line":"            context, share[\u0027id\u0027], filters)"},{"line_number":1682,"context_line":"        return rules"},{"line_number":1683,"context_line":""},{"line_number":1684,"context_line":"    def access_get(self, context, access_id):"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_2fb6b0dd","line":1681,"range":{"start_line":1681,"start_character":34,"end_line":1681,"end_character":41},"in_reply_to":"5f7c97a3_197a3424","updated":"2018-07-19 12:53:47.000000000","message":"Done","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e1f556c2c11065341528b43078a8f3314809171","unresolved":false,"context_lines":[{"line_number":1735,"context_line":"    def update_share_access_metadata(self, context, access_id, metadata):"},{"line_number":1736,"context_line":"        \"\"\"Updates share access metadata.\"\"\""},{"line_number":1737,"context_line":"        self._check_metadata_properties(metadata)"},{"line_number":1738,"context_line":"        return self.db.share_access_metadata_update(context, access_id,"},{"line_number":1739,"context_line":"                                                    metadata)"},{"line_number":1740,"context_line":""},{"line_number":1741,"context_line":"    @policy.wrap_check_policy(\u0027share\u0027)"},{"line_number":1742,"context_line":"    def update_share_metadata(self, context, share, metadata, delete\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_d96fdc5e","line":1739,"range":{"start_line":1738,"start_character":52,"end_line":1739,"end_character":61},"updated":"2018-07-18 23:17:35.000000000","message":"nit: wrap to next line, or one param per line","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"11976fc9d82a431c63035a1e286bf5d6bc119459","unresolved":false,"context_lines":[{"line_number":1735,"context_line":"    def update_share_access_metadata(self, context, access_id, metadata):"},{"line_number":1736,"context_line":"        \"\"\"Updates share access metadata.\"\"\""},{"line_number":1737,"context_line":"        self._check_metadata_properties(metadata)"},{"line_number":1738,"context_line":"        return self.db.share_access_metadata_update(context, access_id,"},{"line_number":1739,"context_line":"                                                    metadata)"},{"line_number":1740,"context_line":""},{"line_number":1741,"context_line":"    @policy.wrap_check_policy(\u0027share\u0027)"},{"line_number":1742,"context_line":"    def update_share_metadata(self, context, share, metadata, delete\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_cfc4dc43","line":1739,"range":{"start_line":1738,"start_character":52,"end_line":1739,"end_character":61},"in_reply_to":"5f7c97a3_d96fdc5e","updated":"2018-07-19 12:53:47.000000000","message":"Done","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"}],"manila/tests/api/v2/test_share_access_metadata.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e1f556c2c11065341528b43078a8f3314809171","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        return req"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def setUp(self):"},{"line_number":41,"context_line":"        super(self.__class__, self).setUp()"},{"line_number":42,"context_line":"        self.controller \u003d ("},{"line_number":43,"context_line":"            share_access_metadata.ShareAccessMetadataController())"},{"line_number":44,"context_line":"        self.access_controller \u003d ("}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_59aaec6c","line":41,"range":{"start_line":41,"start_character":14,"end_line":41,"end_character":28},"updated":"2018-07-18 23:17:35.000000000","message":"ShareAccessesMetadataAPITest","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"11976fc9d82a431c63035a1e286bf5d6bc119459","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        return req"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def setUp(self):"},{"line_number":41,"context_line":"        super(self.__class__, self).setUp()"},{"line_number":42,"context_line":"        self.controller \u003d ("},{"line_number":43,"context_line":"            share_access_metadata.ShareAccessMetadataController())"},{"line_number":44,"context_line":"        self.access_controller \u003d ("}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_8fba64b7","line":41,"range":{"start_line":41,"start_character":14,"end_line":41,"end_character":28},"in_reply_to":"5f7c97a3_59aaec6c","updated":"2018-07-19 12:53:47.000000000","message":"Done","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e1f556c2c11065341528b43078a8f3314809171","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        self.assertIn(self.access[\u0027id\u0027], show_result[\u0027access\u0027][\u0027id\u0027])"},{"line_number":82,"context_line":"        self.assertNotIn(\u0027test_key3\u0027, show_result[\u0027access\u0027][\u0027metadata\u0027])"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def test_update_access_metadata_not_found(self):"},{"line_number":85,"context_line":"        self.assertRaises("},{"line_number":86,"context_line":"            exc.HTTPNotFound,"},{"line_number":87,"context_line":"            self.controller.update,"},{"line_number":88,"context_line":"            self._get_request(), \u0027not_exist_access_id\u0027,"},{"line_number":89,"context_line":"            {\u0027metadata\u0027: {\u0027key1\u0027: \u0027v1\u0027}}"},{"line_number":90,"context_line":"        )"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def test_delete_access_metadata_not_found(self):"},{"line_number":93,"context_line":"        self.assertRaises("},{"line_number":94,"context_line":"            exc.HTTPNotFound,"},{"line_number":95,"context_line":"            self.controller.delete,"},{"line_number":96,"context_line":"            self._get_request(), self.access[\u0027id\u0027], \u0027key1\u0027"},{"line_number":97,"context_line":"        )"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    @ddt.data(\u00271.0\u0027, \u00272.0\u0027, \u00272.8\u0027)"},{"line_number":100,"context_line":"    def test_update_metadata_unsupported_version(self, version):"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_9927241f","line":97,"range":{"start_line":84,"start_character":4,"end_line":97,"end_character":9},"updated":"2018-07-18 23:17:35.000000000","message":"can you add some metadata, and then query for an unavailable key?","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"11976fc9d82a431c63035a1e286bf5d6bc119459","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        self.assertIn(self.access[\u0027id\u0027], show_result[\u0027access\u0027][\u0027id\u0027])"},{"line_number":82,"context_line":"        self.assertNotIn(\u0027test_key3\u0027, show_result[\u0027access\u0027][\u0027metadata\u0027])"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def test_update_access_metadata_not_found(self):"},{"line_number":85,"context_line":"        self.assertRaises("},{"line_number":86,"context_line":"            exc.HTTPNotFound,"},{"line_number":87,"context_line":"            self.controller.update,"},{"line_number":88,"context_line":"            self._get_request(), \u0027not_exist_access_id\u0027,"},{"line_number":89,"context_line":"            {\u0027metadata\u0027: {\u0027key1\u0027: \u0027v1\u0027}}"},{"line_number":90,"context_line":"        )"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def test_delete_access_metadata_not_found(self):"},{"line_number":93,"context_line":"        self.assertRaises("},{"line_number":94,"context_line":"            exc.HTTPNotFound,"},{"line_number":95,"context_line":"            self.controller.delete,"},{"line_number":96,"context_line":"            self._get_request(), self.access[\u0027id\u0027], \u0027key1\u0027"},{"line_number":97,"context_line":"        )"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    @ddt.data(\u00271.0\u0027, \u00272.0\u0027, \u00272.8\u0027)"},{"line_number":100,"context_line":"    def test_update_metadata_unsupported_version(self, version):"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_6ad4961f","line":97,"range":{"start_line":84,"start_character":4,"end_line":97,"end_character":9},"in_reply_to":"5f7c97a3_9927241f","updated":"2018-07-19 12:53:47.000000000","message":"Done","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e1f556c2c11065341528b43078a8f3314809171","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            self._get_request(), self.access[\u0027id\u0027], \u0027key1\u0027"},{"line_number":97,"context_line":"        )"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    @ddt.data(\u00271.0\u0027, \u00272.0\u0027, \u00272.8\u0027)"},{"line_number":100,"context_line":"    def test_update_metadata_unsupported_version(self, version):"},{"line_number":101,"context_line":"        self.assertRaises("},{"line_number":102,"context_line":"            exception.VersionNotFoundForAPIMethod,"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_592d0cfa","line":99,"range":{"start_line":99,"start_character":28,"end_line":99,"end_character":33},"updated":"2018-07-18 23:17:35.000000000","message":"border please \u00272.44\u0027","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"11976fc9d82a431c63035a1e286bf5d6bc119459","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            self._get_request(), self.access[\u0027id\u0027], \u0027key1\u0027"},{"line_number":97,"context_line":"        )"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    @ddt.data(\u00271.0\u0027, \u00272.0\u0027, \u00272.8\u0027)"},{"line_number":100,"context_line":"    def test_update_metadata_unsupported_version(self, version):"},{"line_number":101,"context_line":"        self.assertRaises("},{"line_number":102,"context_line":"            exception.VersionNotFoundForAPIMethod,"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_6fd4a8ea","line":99,"range":{"start_line":99,"start_character":28,"end_line":99,"end_character":33},"in_reply_to":"5f7c97a3_592d0cfa","updated":"2018-07-19 12:53:47.000000000","message":"Done","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e1f556c2c11065341528b43078a8f3314809171","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            self.controller.update,"},{"line_number":104,"context_line":"            self._get_request(version\u003dversion), self.access[\u0027id\u0027],"},{"line_number":105,"context_line":"            {\u0027metadata\u0027: {\u0027key1\u0027: \u0027v1\u0027}}"},{"line_number":106,"context_line":"        )"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    @ddt.data(\u00271.0\u0027, \u00272.0\u0027, \u00272.43\u0027)"},{"line_number":109,"context_line":"    def test_delete_metadata_with_unsupported_version(self, version):"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_7932485f","line":106,"range":{"start_line":106,"start_character":8,"end_line":106,"end_character":9},"updated":"2018-07-18 23:17:35.000000000","message":"pull to previous line","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"11976fc9d82a431c63035a1e286bf5d6bc119459","unresolved":false,"context_lines":[{"line_number":103,"context_line":"            self.controller.update,"},{"line_number":104,"context_line":"            self._get_request(version\u003dversion), self.access[\u0027id\u0027],"},{"line_number":105,"context_line":"            {\u0027metadata\u0027: {\u0027key1\u0027: \u0027v1\u0027}}"},{"line_number":106,"context_line":"        )"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    @ddt.data(\u00271.0\u0027, \u00272.0\u0027, \u00272.43\u0027)"},{"line_number":109,"context_line":"    def test_delete_metadata_with_unsupported_version(self, version):"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_4f076c82","line":106,"range":{"start_line":106,"start_character":8,"end_line":106,"end_character":9},"in_reply_to":"5f7c97a3_7932485f","updated":"2018-07-19 12:53:47.000000000","message":"Done","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"}],"manila/tests/api/v2/test_share_accesses.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e1f556c2c11065341528b43078a8f3314809171","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        return req"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def setUp(self):"},{"line_number":50,"context_line":"        super(self.__class__, self).setUp()"},{"line_number":51,"context_line":"        self.controller \u003d ("},{"line_number":52,"context_line":"            share_accesses.ShareAccessesController())"},{"line_number":53,"context_line":"        self.resource_name \u003d self.controller.resource_name"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_ca893870","line":50,"range":{"start_line":50,"start_character":14,"end_line":50,"end_character":28},"updated":"2018-07-18 23:17:35.000000000","message":"ShareAccessesAPITest\n\nhttps://docs.quantifiedcode.com/python-anti-patterns/correctness/bad_first_argument_given_to_super.html","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"11976fc9d82a431c63035a1e286bf5d6bc119459","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        return req"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def setUp(self):"},{"line_number":50,"context_line":"        super(self.__class__, self).setUp()"},{"line_number":51,"context_line":"        self.controller \u003d ("},{"line_number":52,"context_line":"            share_accesses.ShareAccessesController())"},{"line_number":53,"context_line":"        self.resource_name \u003d self.controller.resource_name"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_4f7a0cf0","line":50,"range":{"start_line":50,"start_character":14,"end_line":50,"end_character":28},"in_reply_to":"5f7c97a3_ca893870","updated":"2018-07-19 12:53:47.000000000","message":"Done","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e1f556c2c11065341528b43078a8f3314809171","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        self.controller \u003d ("},{"line_number":52,"context_line":"            share_accesses.ShareAccessesController())"},{"line_number":53,"context_line":"        self.resource_name \u003d self.controller.resource_name"},{"line_number":54,"context_line":"        self.ctxt \u003d {"},{"line_number":55,"context_line":"            \u0027admin\u0027: context.RequestContext(\u0027admin\u0027, \u0027fake\u0027, True),"},{"line_number":56,"context_line":"            \u0027user\u0027: context.RequestContext(\u0027fake\u0027, \u0027fake\u0027),"},{"line_number":57,"context_line":"        }"},{"line_number":58,"context_line":"        self.mock_policy_check \u003d self.mock_object("},{"line_number":59,"context_line":"            policy, \u0027check_policy\u0027, mock.Mock(return_value\u003dTrue))"},{"line_number":60,"context_line":"        self.share \u003d db_utils.create_share()"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_6a3ee48a","line":57,"range":{"start_line":54,"start_character":8,"end_line":57,"end_character":9},"updated":"2018-07-18 23:17:35.000000000","message":"not used","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"11976fc9d82a431c63035a1e286bf5d6bc119459","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        self.controller \u003d ("},{"line_number":52,"context_line":"            share_accesses.ShareAccessesController())"},{"line_number":53,"context_line":"        self.resource_name \u003d self.controller.resource_name"},{"line_number":54,"context_line":"        self.ctxt \u003d {"},{"line_number":55,"context_line":"            \u0027admin\u0027: context.RequestContext(\u0027admin\u0027, \u0027fake\u0027, True),"},{"line_number":56,"context_line":"            \u0027user\u0027: context.RequestContext(\u0027fake\u0027, \u0027fake\u0027),"},{"line_number":57,"context_line":"        }"},{"line_number":58,"context_line":"        self.mock_policy_check \u003d self.mock_object("},{"line_number":59,"context_line":"            policy, \u0027check_policy\u0027, mock.Mock(return_value\u003dTrue))"},{"line_number":60,"context_line":"        self.share \u003d db_utils.create_share()"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_ef7c38eb","line":57,"range":{"start_line":54,"start_character":8,"end_line":57,"end_character":9},"in_reply_to":"5f7c97a3_6a3ee48a","updated":"2018-07-19 12:53:47.000000000","message":"Done","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e1f556c2c11065341528b43078a8f3314809171","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        self.assertIn(\u0027access_list\u0027, index_result)"},{"line_number":89,"context_line":"        self.assertEqual(1, len(index_result))"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        access_count \u003d 2"},{"line_number":92,"context_line":"        if filters:"},{"line_number":93,"context_line":"            access_count \u003d 1"},{"line_number":94,"context_line":"        self.assertEqual(access_count, len(index_result[\u0027access_list\u0027]))"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        for index_access in index_result[\u0027access_list\u0027]:"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_0a709072","line":93,"range":{"start_line":91,"start_character":8,"end_line":93,"end_character":28},"updated":"2018-07-18 23:17:35.000000000","message":"access_count \u003d 1 if filters else 2","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"11976fc9d82a431c63035a1e286bf5d6bc119459","unresolved":false,"context_lines":[{"line_number":88,"context_line":"        self.assertIn(\u0027access_list\u0027, index_result)"},{"line_number":89,"context_line":"        self.assertEqual(1, len(index_result))"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"        access_count \u003d 2"},{"line_number":92,"context_line":"        if filters:"},{"line_number":93,"context_line":"            access_count \u003d 1"},{"line_number":94,"context_line":"        self.assertEqual(access_count, len(index_result[\u0027access_list\u0027]))"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        for index_access in index_result[\u0027access_list\u0027]:"}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_cf65bc4a","line":93,"range":{"start_line":91,"start_character":8,"end_line":93,"end_character":28},"in_reply_to":"5f7c97a3_0a709072","updated":"2018-07-19 12:53:47.000000000","message":"Done","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"}],"manila/tests/db/sqlalchemy/test_api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8e1f556c2c11065341528b43078a8f3314809171","unresolved":false,"context_lines":[{"line_number":195,"context_line":"            for key in share_access_keys:"},{"line_number":196,"context_line":"                self.assertIn(key, rule)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def test_share_instance_access_delete(self):"},{"line_number":199,"context_line":"        share \u003d db_utils.create_share()"},{"line_number":200,"context_line":"        access \u003d db_utils.create_access(share_id\u003dshare[\u0027id\u0027],"},{"line_number":201,"context_line":"                                        metadata\u003d{\u0027key1\u0027: \u0027v1\u0027})"},{"line_number":202,"context_line":"        instance_access_mapping \u003d db_api.share_instance_access_get("},{"line_number":203,"context_line":"            self.ctxt, access[\u0027id\u0027], share.instance[\u0027id\u0027])"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        db_api.share_instance_access_delete("},{"line_number":206,"context_line":"            self.ctxt, instance_access_mapping[\u0027id\u0027])"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        rules \u003d db_api.share_access_get_all_for_instance("},{"line_number":209,"context_line":"            self.ctxt, share.instance[\u0027id\u0027])"},{"line_number":210,"context_line":"        self.assertEqual([], rules)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        self.assertRaises(exception.NotFound, db_api.share_instance_access_get,"},{"line_number":213,"context_line":"                          self.ctxt, access[\u0027id\u0027], share[\u0027instance\u0027][\u0027id\u0027])"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    @ddt.data(True, False)"},{"line_number":216,"context_line":"    def test_share_instance_access_get_with_share_access_data("}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_4a91a844","line":213,"range":{"start_line":198,"start_character":0,"end_line":213,"end_character":75},"updated":"2018-07-18 23:17:35.000000000","message":"Can you add another test with this case:\n\n Setup:\n - A share \n - 2 share instances of the share\n - one access rule with share instance access mappings for each of the instances\n - one or more metadata items for the access rule\n\n Test:\n - delete the share instance, this should delete the corresponding \n   share instance access mapping\n - retrieve the access rule metadata, it should be intact, i.e, deleted \u003d \"False\"\n - delete the share, this should delete the remaining share instance, and \n    the access rule, access rule metadata\n - retrieve the access rule metadata, you should get an error.","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"11976fc9d82a431c63035a1e286bf5d6bc119459","unresolved":false,"context_lines":[{"line_number":195,"context_line":"            for key in share_access_keys:"},{"line_number":196,"context_line":"                self.assertIn(key, rule)"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"    def test_share_instance_access_delete(self):"},{"line_number":199,"context_line":"        share \u003d db_utils.create_share()"},{"line_number":200,"context_line":"        access \u003d db_utils.create_access(share_id\u003dshare[\u0027id\u0027],"},{"line_number":201,"context_line":"                                        metadata\u003d{\u0027key1\u0027: \u0027v1\u0027})"},{"line_number":202,"context_line":"        instance_access_mapping \u003d db_api.share_instance_access_get("},{"line_number":203,"context_line":"            self.ctxt, access[\u0027id\u0027], share.instance[\u0027id\u0027])"},{"line_number":204,"context_line":""},{"line_number":205,"context_line":"        db_api.share_instance_access_delete("},{"line_number":206,"context_line":"            self.ctxt, instance_access_mapping[\u0027id\u0027])"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        rules \u003d db_api.share_access_get_all_for_instance("},{"line_number":209,"context_line":"            self.ctxt, share.instance[\u0027id\u0027])"},{"line_number":210,"context_line":"        self.assertEqual([], rules)"},{"line_number":211,"context_line":""},{"line_number":212,"context_line":"        self.assertRaises(exception.NotFound, db_api.share_instance_access_get,"},{"line_number":213,"context_line":"                          self.ctxt, access[\u0027id\u0027], share[\u0027instance\u0027][\u0027id\u0027])"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"    @ddt.data(True, False)"},{"line_number":216,"context_line":"    def test_share_instance_access_get_with_share_access_data("}],"source_content_type":"text/x-python","patch_set":27,"id":"5f7c97a3_40fdfb05","line":213,"range":{"start_line":198,"start_character":0,"end_line":213,"end_character":75},"in_reply_to":"5f7c97a3_4a91a844","updated":"2018-07-19 12:53:47.000000000","message":"Done","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"685f2b9ebda5a8db0a4f8fa884704cce69723107","unresolved":false,"context_lines":[{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        get_access \u003d db_api.share_instance_access_get("},{"line_number":230,"context_line":"            self.ctxt, access[\u0027id\u0027], share[\u0027instance\u0027][\u0027id\u0027])"},{"line_number":231,"context_line":"        self.assertEqual(access[\u0027id\u0027], get_access[\u0027access_id\u0027])"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        db_api.share_instance_delete(self.ctxt, share[\u0027instance\u0027][\u0027id\u0027])"},{"line_number":234,"context_line":"        self.assertRaises(exception.NotFound,"}],"source_content_type":"text/x-python","patch_set":28,"id":"5f7c97a3_fa5dcaeb","line":231,"range":{"start_line":231,"start_character":8,"end_line":231,"end_character":63},"updated":"2018-07-19 20:53:02.000000000","message":"check for the metadata","commit_id":"0b43f72d6ecf9a7393768c36f36ccac9c2b040d1"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"94f0caaf21d5fce20cda3b8365f74aef089e0b52","unresolved":false,"context_lines":[{"line_number":228,"context_line":""},{"line_number":229,"context_line":"        get_access \u003d db_api.share_instance_access_get("},{"line_number":230,"context_line":"            self.ctxt, access[\u0027id\u0027], share[\u0027instance\u0027][\u0027id\u0027])"},{"line_number":231,"context_line":"        self.assertEqual(access[\u0027id\u0027], get_access[\u0027access_id\u0027])"},{"line_number":232,"context_line":""},{"line_number":233,"context_line":"        db_api.share_instance_delete(self.ctxt, share[\u0027instance\u0027][\u0027id\u0027])"},{"line_number":234,"context_line":"        self.assertRaises(exception.NotFound,"}],"source_content_type":"text/x-python","patch_set":28,"id":"5f7c97a3_11a0a835","line":231,"range":{"start_line":231,"start_character":8,"end_line":231,"end_character":63},"in_reply_to":"5f7c97a3_fa5dcaeb","updated":"2018-07-20 12:25:47.000000000","message":"Done","commit_id":"0b43f72d6ecf9a7393768c36f36ccac9c2b040d1"}],"releasenotes/notes/add-share-access-metadata-4fda2c06e750e83c.yaml":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"537d340b26de9a7e5eeb732068d3f590b6c7dd1b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added metadata for share access rule resource."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5f7c97a3_e2dcf846","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":50},"updated":"2018-07-12 06:03:00.000000000","message":"Metadata can be added to share access rules as key value pairs with API version 2.45.","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"2450b68e9648b36b1280649928709b2661b6f62e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Added metadata for share access rule resource."}],"source_content_type":"text/x-yaml","patch_set":17,"id":"5f7c97a3_531ca0c1","line":3,"range":{"start_line":3,"start_character":4,"end_line":3,"end_character":50},"in_reply_to":"5f7c97a3_e2dcf846","updated":"2018-07-12 08:06:06.000000000","message":"Done","commit_id":"9e12635de1efbe04b56593616269166b70ed53bf"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ab8c44aaa874c431e4e11918b1b876413b8d5a32","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Metadata can be added to share access rules as key value pairs, and also"},{"line_number":4,"context_line":"    introduced the GET /share-access-rules API with API version 2.45."}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5f7c97a3_e078ddc2","line":3,"range":{"start_line":3,"start_character":51,"end_line":3,"end_character":60},"updated":"2018-07-18 19:12:03.000000000","message":"key\u003dvalue","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"11976fc9d82a431c63035a1e286bf5d6bc119459","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Metadata can be added to share access rules as key value pairs, and also"},{"line_number":4,"context_line":"    introduced the GET /share-access-rules API with API version 2.45."}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5f7c97a3_6ff7c85b","line":3,"range":{"start_line":3,"start_character":51,"end_line":3,"end_character":60},"in_reply_to":"5f7c97a3_e078ddc2","updated":"2018-07-19 12:53:47.000000000","message":"Done","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ab8c44aaa874c431e4e11918b1b876413b8d5a32","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Metadata can be added to share access rules as key value pairs, and also"},{"line_number":4,"context_line":"    introduced the GET /share-access-rules API with API version 2.45."}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5f7c97a3_631a976b","line":4,"range":{"start_line":4,"start_character":68,"end_line":4,"end_character":69},"updated":"2018-07-18 19:12:03.000000000","message":"Also add upgrade:\n\n\n upgrade:\n     - The API GET /share-access-rules?share_id\u003d{share-id} replaces \n        POST /shares/{share-id}/action with body {\u0027access_list\u0027: null} in API version\n        2.45. The new API supports access rule metadata and is expected\n        to support sorting, filtering and pagination features along with newer\n        fields to interact with access rules in future versions. The API request\n        header \u0027X-OpenStack-Manila-API-Version\u0027 can be set to 2.44 to\n        continue using the prior API to retrieve access rules, but no new features\n        will be added to that API.","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"ab8c44aaa874c431e4e11918b1b876413b8d5a32","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Metadata can be added to share access rules as key value pairs, and also"},{"line_number":4,"context_line":"    introduced the GET /share-access-rules API with API version 2.45."}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5f7c97a3_207335ea","line":4,"range":{"start_line":4,"start_character":68,"end_line":4,"end_character":69},"updated":"2018-07-18 19:12:03.000000000","message":"The prior API to retrieve access rules of a given share, POST /shares/{share-id}/action {\u0027access-list: null} has been removed in API version 2.45.","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"11976fc9d82a431c63035a1e286bf5d6bc119459","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Metadata can be added to share access rules as key value pairs, and also"},{"line_number":4,"context_line":"    introduced the GET /share-access-rules API with API version 2.45."}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5f7c97a3_cf813ca2","line":4,"range":{"start_line":4,"start_character":68,"end_line":4,"end_character":69},"in_reply_to":"5f7c97a3_207335ea","updated":"2018-07-19 12:53:47.000000000","message":"Done","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"11976fc9d82a431c63035a1e286bf5d6bc119459","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Metadata can be added to share access rules as key value pairs, and also"},{"line_number":4,"context_line":"    introduced the GET /share-access-rules API with API version 2.45."}],"source_content_type":"text/x-yaml","patch_set":27,"id":"5f7c97a3_6f8ca8d7","line":4,"range":{"start_line":4,"start_character":68,"end_line":4,"end_character":69},"in_reply_to":"5f7c97a3_631a976b","updated":"2018-07-19 12:53:47.000000000","message":"Done","commit_id":"6583d7cf5d0026b5e0002d5c82b829adf352dee7"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"685f2b9ebda5a8db0a4f8fa884704cce69723107","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"5f7c97a3_1a0686ce","updated":"2018-07-19 20:53:02.000000000","message":"So the release notes job\u0027s failing because of the \u0027:\u0027 in the API, you should reformat these notes like this:\n\n ---\n features:\n  - |\n    Metadata can be added to share access rules as key\u003dvalue pairs, and also\n    introduced the GET /share-access-rules API with API version 2.45.\n    The prior API to retrieve access rules of a given share,\n    POST /shares/{share-id}/action {\u0027access-list: null} has been\n    removed in API version 2.45.\n upgrade:\n  - |\n    The API GET /share-access-rules?share_id\u003d{share-id} replaces\n    POST /shares/{share-id}/action with body {\u0027access_list\u0027: null} in\n    API version 2.45. The new API supports access rule metadata and is expected\n    to support sorting, filtering and pagination features along with newer\n    fields to interact with access rules in future versions. The API request\n    header \u0027X-OpenStack-Manila-API-Version\u0027 can be set to 2.44 to\n    continue using the prior API to retrieve access rules, but no new features\n    will be added to that API.","commit_id":"0b43f72d6ecf9a7393768c36f36ccac9c2b040d1"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"94f0caaf21d5fce20cda3b8365f74aef089e0b52","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":28,"id":"5f7c97a3_a5e3aad6","in_reply_to":"5f7c97a3_1a0686ce","updated":"2018-07-20 12:25:47.000000000","message":"Done","commit_id":"0b43f72d6ecf9a7393768c36f36ccac9c2b040d1"}]}
