)]}'
{"manila/share/drivers/qnap/qnap.py":[{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"88d955882bd06ad2068289fb853f2285098e7513","unresolved":false,"context_lines":[{"line_number":839,"context_line":""},{"line_number":840,"context_line":"        vol_no \u003d existing_share.find(\u0027vol_no\u0027).text"},{"line_number":841,"context_line":"        vol \u003d self.api_executor.get_specific_volinfo(vol_no)"},{"line_number":842,"context_line":"        vol_size_gb \u003d int(vol.find(\u0027size\u0027).text) / units.Gi"},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"        share_dict \u003d {"},{"line_number":845,"context_line":"            \u0027sharename\u0027: share_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_b90b008c","line":842,"range":{"start_line":842,"start_character":8,"end_line":842,"end_character":59},"updated":"2018-05-30 08:15:49.000000000","message":"In your case, the actually share size is equal to 100.55 GB in NAS, but the vol_size_gb will be set to 100 GB after run \"int(vol.find(\u0027size\u0027).text) / units.Gi\". Do you really want it?  If the share size value is 0.99GB in NAS, you will return 0GB for share after manage share. \n\nDo you like to use math.ceil(float(vol.find(\u0027size\u0027).text) / units.Gi) to get the higher value for vol_size_gb?","commit_id":"c9278ad010f3188cec82604f1f875f029bd6e72e"},{"author":{"_account_id":26134,"name":"Chris Yang","email":"chrisyang@qnap.com","username":"chrisyang"},"change_message_id":"ef9e492d67a636634527e89f1c348d1eafb6c043","unresolved":false,"context_lines":[{"line_number":839,"context_line":""},{"line_number":840,"context_line":"        vol_no \u003d existing_share.find(\u0027vol_no\u0027).text"},{"line_number":841,"context_line":"        vol \u003d self.api_executor.get_specific_volinfo(vol_no)"},{"line_number":842,"context_line":"        vol_size_gb \u003d int(vol.find(\u0027size\u0027).text) / units.Gi"},{"line_number":843,"context_line":""},{"line_number":844,"context_line":"        share_dict \u003d {"},{"line_number":845,"context_line":"            \u0027sharename\u0027: share_name,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_9b0b857b","line":842,"range":{"start_line":842,"start_character":8,"end_line":842,"end_character":59},"in_reply_to":"5f7c97a3_b90b008c","updated":"2018-05-31 06:05:29.000000000","message":"Thanks, it is better!","commit_id":"c9278ad010f3188cec82604f1f875f029bd6e72e"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"abd3fba77c72e529c68f595eff63e6b67b82cd37","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        1.0.3 - Add supports for Thin Provisioning, SSD Cache, Deduplication"},{"line_number":72,"context_line":"                and Compression."},{"line_number":73,"context_line":"        1.0.4 - Add support for QES fw 2.0.0."},{"line_number":74,"context_line":"        1.0.5 - Fix bug, when user tries to manage share, the size of managed"},{"line_number":75,"context_line":"                share should not be changed."},{"line_number":76,"context_line":"    \"\"\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    DRIVER_VERSION \u003d \u00271.0.5\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_9e0686cd","line":75,"range":{"start_line":74,"start_character":7,"end_line":75,"end_character":44},"updated":"2018-06-07 09:41:39.000000000","message":"It\u0027s better to add bug ID here.","commit_id":"07a9453d16bb136ed9b368ac1c54d4a960e0defb"},{"author":{"_account_id":26134,"name":"Chris Yang","email":"chrisyang@qnap.com","username":"chrisyang"},"change_message_id":"4dab2e2a8bccb74e2b441b0e1fdec7d991b2217d","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        1.0.3 - Add supports for Thin Provisioning, SSD Cache, Deduplication"},{"line_number":72,"context_line":"                and Compression."},{"line_number":73,"context_line":"        1.0.4 - Add support for QES fw 2.0.0."},{"line_number":74,"context_line":"        1.0.5 - Fix bug, when user tries to manage share, the size of managed"},{"line_number":75,"context_line":"                share should not be changed."},{"line_number":76,"context_line":"    \"\"\""},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    DRIVER_VERSION \u003d \u00271.0.5\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_5db8c60f","line":75,"range":{"start_line":74,"start_character":7,"end_line":75,"end_character":44},"in_reply_to":"5f7c97a3_9e0686cd","updated":"2018-06-09 06:07:43.000000000","message":"Done","commit_id":"07a9453d16bb136ed9b368ac1c54d4a960e0defb"}],"releasenotes/notes/bug-1773761-qnap-fix-manage-share-size-override-a18acdf1a41909b0.yaml":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"a1eaf73a7b9c3aaea6d03f56b7c326a541b5e645","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed the QNAP driver that share size will be updated after"},{"line_number":5,"context_line":"    manage share by manila."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_a3e7c646","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":27},"updated":"2018-06-06 10:41:30.000000000","message":"Unfortunately this can be read as indicating that now the size on the back end *will* be updated.  I suggest:\n\n  Fixed the QNAP driver so that it does not modify the\n  share size on the back end when manila manages a share.","commit_id":"e16e0f423a9cfc2a6d581a74fb1176174e4095a3"},{"author":{"_account_id":26134,"name":"Chris Yang","email":"chrisyang@qnap.com","username":"chrisyang"},"change_message_id":"102a2603499327a60a6c1e3a35e3b922bc8c5f20","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed the QNAP driver that share size will be updated after"},{"line_number":5,"context_line":"    manage share by manila."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_25cac8a0","line":5,"range":{"start_line":4,"start_character":4,"end_line":5,"end_character":27},"in_reply_to":"5f7c97a3_a3e7c646","updated":"2018-06-07 01:35:54.000000000","message":"Thanks for your advice!","commit_id":"e16e0f423a9cfc2a6d581a74fb1176174e4095a3"},{"author":{"_account_id":23083,"name":"TommyLike","email":"tommylikehu@gmail.com","username":"TommyLike"},"change_message_id":"abd3fba77c72e529c68f595eff63e6b67b82cd37","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed the QNAP driver so that it dooes not modify the"},{"line_number":5,"context_line":"    share size on the back end when manila manage a share."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f7c97a3_7e2cca49","line":4,"range":{"start_line":4,"start_character":37,"end_line":4,"end_character":42},"updated":"2018-06-07 09:41:39.000000000","message":"does","commit_id":"07a9453d16bb136ed9b368ac1c54d4a960e0defb"},{"author":{"_account_id":26134,"name":"Chris Yang","email":"chrisyang@qnap.com","username":"chrisyang"},"change_message_id":"4dab2e2a8bccb74e2b441b0e1fdec7d991b2217d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed the QNAP driver so that it dooes not modify the"},{"line_number":5,"context_line":"    share size on the back end when manila manage a share."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f7c97a3_1d3c8e91","line":4,"range":{"start_line":4,"start_character":37,"end_line":4,"end_character":42},"in_reply_to":"5f7c97a3_7e2cca49","updated":"2018-06-09 06:07:43.000000000","message":"Done","commit_id":"07a9453d16bb136ed9b368ac1c54d4a960e0defb"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"3a7cbc241985aa12da0846cc71d838971c5f8943","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed the QNAP driver so that it dooes not modify the"},{"line_number":5,"context_line":"    share size on the back end when manila manage a share."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f7c97a3_d9b89812","line":5,"range":{"start_line":5,"start_character":43,"end_line":5,"end_character":49},"updated":"2018-06-07 10:15:58.000000000","message":"manages","commit_id":"07a9453d16bb136ed9b368ac1c54d4a960e0defb"},{"author":{"_account_id":26134,"name":"Chris Yang","email":"chrisyang@qnap.com","username":"chrisyang"},"change_message_id":"4dab2e2a8bccb74e2b441b0e1fdec7d991b2217d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Fixed the QNAP driver so that it dooes not modify the"},{"line_number":5,"context_line":"    share size on the back end when manila manage a share."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f7c97a3_fd3672b4","line":5,"range":{"start_line":5,"start_character":43,"end_line":5,"end_character":49},"in_reply_to":"5f7c97a3_d9b89812","updated":"2018-06-09 06:07:43.000000000","message":"Done","commit_id":"07a9453d16bb136ed9b368ac1c54d4a960e0defb"}]}
