)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"3ab3df30dd6c70ae2dcae24861300fe339decee4","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add priority for access rule"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add new priority attribute in allow/update access rule API."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"DocImpact"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":28,"id":"3f79a3b5_f3fa83bf","line":9,"updated":"2018-12-13 12:05:12.000000000","message":"Could you elaborate *why* we want this please?\nA commit msg is the perfect place for that.","commit_id":"16eab0ad63f5819e0411b43332d8308baaccc99d"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"d9e2e186f826a852419d3ae9e2557dc9314077a8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add priority for access rule"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Add new priority attribute in allow/update access rule API."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"DocImpact"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":28,"id":"3f79a3b5_53cd7759","line":9,"in_reply_to":"3f79a3b5_f3fa83bf","updated":"2018-12-13 12:20:27.000000000","message":"Done","commit_id":"16eab0ad63f5819e0411b43332d8308baaccc99d"}],"manila/api/common.py":[{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"44374b7250e92647cf7d3ecdcae6e87cb3d4841a","unresolved":false,"context_lines":[{"line_number":393,"context_line":""},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"def get_access_priority(enable_priority, priority):"},{"line_number":396,"context_line":"    access_priority \u003d 100"},{"line_number":397,"context_line":"    if priority and not enable_priority:"},{"line_number":398,"context_line":"        exc_str \u003d _(\"Access rule\u0027s priority only available with manila\""},{"line_number":399,"context_line":"                    \"API version \u003e\u003d 2.45\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_c2a8dc8d","line":396,"range":{"start_line":396,"start_character":22,"end_line":396,"end_character":25},"updated":"2018-06-05 09:50:37.000000000","message":"Set as a constant in the code (e.g. DEFAULT_ACCESS_PRIORITY) instead of using as a magic number which will be hard to trace in later revisions of the code.","commit_id":"6ffb38f3018225def57c52a76ac506383b05b951"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ce3874f0d161879c5aae35d21dd1d1f9298001d9","unresolved":false,"context_lines":[{"line_number":393,"context_line":""},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"def get_access_priority(enable_priority, priority):"},{"line_number":396,"context_line":"    access_priority \u003d 100"},{"line_number":397,"context_line":"    if priority and not enable_priority:"},{"line_number":398,"context_line":"        exc_str \u003d _(\"Access rule\u0027s priority only available with manila\""},{"line_number":399,"context_line":"                    \"API version \u003e\u003d 2.45\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_840cde42","line":396,"range":{"start_line":396,"start_character":22,"end_line":396,"end_character":25},"in_reply_to":"5f7c97a3_c2a8dc8d","updated":"2018-06-08 07:38:58.000000000","message":"Done","commit_id":"6ffb38f3018225def57c52a76ac506383b05b951"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"44374b7250e92647cf7d3ecdcae6e87cb3d4841a","unresolved":false,"context_lines":[{"line_number":400,"context_line":"        raise webob.exc.HTTPBadRequest(explanation\u003dexc_str)"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    if priority is not None and priority not in range(1, 201):"},{"line_number":403,"context_line":"        exc_str \u003d _(\"The priority value only support in range 1 ~ 200.\")"},{"line_number":404,"context_line":"        raise webob.exc.HTTPBadRequest(explanation\u003dexc_str)"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"    access_priority \u003d priority or access_priority"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_c281bcfd","line":403,"range":{"start_line":403,"start_character":21,"end_line":403,"end_character":70},"updated":"2018-06-05 09:50:37.000000000","message":"\"Priority values are only supported in the range 1 ~ 200.\"\nAlso, 1 and 200 should be constants and referred here by string formatting, for easier manipulation in the future.","commit_id":"6ffb38f3018225def57c52a76ac506383b05b951"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ce3874f0d161879c5aae35d21dd1d1f9298001d9","unresolved":false,"context_lines":[{"line_number":400,"context_line":"        raise webob.exc.HTTPBadRequest(explanation\u003dexc_str)"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    if priority is not None and priority not in range(1, 201):"},{"line_number":403,"context_line":"        exc_str \u003d _(\"The priority value only support in range 1 ~ 200.\")"},{"line_number":404,"context_line":"        raise webob.exc.HTTPBadRequest(explanation\u003dexc_str)"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"    access_priority \u003d priority or access_priority"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_a4079a1d","line":403,"range":{"start_line":403,"start_character":21,"end_line":403,"end_character":70},"in_reply_to":"5f7c97a3_c281bcfd","updated":"2018-06-08 07:38:58.000000000","message":"Done","commit_id":"6ffb38f3018225def57c52a76ac506383b05b951"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"961436106a9d25c43f53a81b5142bb322773ca53","unresolved":false,"context_lines":[{"line_number":395,"context_line":""},{"line_number":396,"context_line":"def validate_access_priority(access_data, enable_priority\u003dTrue):"},{"line_number":397,"context_line":"    if \u0027priority\u0027 in access_data:"},{"line_number":398,"context_line":"        if access_data.get(\u0027priority\u0027) not in range("},{"line_number":399,"context_line":"                constants.MIN_ACCESS_PRIORITY,"},{"line_number":400,"context_line":"                constants.MAX_ACCESS_PRIORITY + 1):"},{"line_number":401,"context_line":"            exc_str \u003d _(\"The priority value only support in range \""},{"line_number":402,"context_line":"                        \"%(min_priority)s ~ %(max_priority)s.\") % {"},{"line_number":403,"context_line":"                            \"min_priority\": constants.MIN_ACCESS_PRIORITY,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_04e7f710","line":400,"range":{"start_line":398,"start_character":11,"end_line":400,"end_character":50},"updated":"2018-06-27 00:20:28.000000000","message":"Hmm, don\u0027t you want to be setting the priority to the default when not provided?\n\n\n    access_data[\u0027priority\u0027] \u003d int(access_data[\u0027priority\u0027] or\n                                   constants.DEFAULT_ACCESS_PRIORITY)\n    access_priority \u003d access_data[\u0027priority\u0027]\n\n\n    if not (access_priority \u003e\u003d constants.MIN_ACCESS_PRIORITY and\n            access_priority \u003c\u003d constants.MAX_ACCESS_PRIORITY)","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"10e19ac862f34e8180c480473faa83af8e2d5200","unresolved":false,"context_lines":[{"line_number":395,"context_line":""},{"line_number":396,"context_line":"def validate_access_priority(access_data, enable_priority\u003dTrue):"},{"line_number":397,"context_line":"    if \u0027priority\u0027 in access_data:"},{"line_number":398,"context_line":"        if access_data.get(\u0027priority\u0027) not in range("},{"line_number":399,"context_line":"                constants.MIN_ACCESS_PRIORITY,"},{"line_number":400,"context_line":"                constants.MAX_ACCESS_PRIORITY + 1):"},{"line_number":401,"context_line":"            exc_str \u003d _(\"The priority value only support in range \""},{"line_number":402,"context_line":"                        \"%(min_priority)s ~ %(max_priority)s.\") % {"},{"line_number":403,"context_line":"                            \"min_priority\": constants.MIN_ACCESS_PRIORITY,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_326c909c","line":400,"range":{"start_line":398,"start_character":11,"end_line":400,"end_character":50},"in_reply_to":"5f7c97a3_04e7f710","updated":"2018-06-30 03:29:44.000000000","message":"This function only check weather the access priority value is\n validate.\n For update access API, they don\u0027t want to set the default \npriority value (constants.DEFAULT_ACCESS_PRIORITY).  The \ndefault value should be None if the request API doesn\u0027t have\n \u0027priority\u0027.\nthey just want to check weather the access priority value is \nright if the request API have the \u0027priority\u0027 value.","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"961436106a9d25c43f53a81b5142bb322773ca53","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        if access_data.get(\u0027priority\u0027) not in range("},{"line_number":399,"context_line":"                constants.MIN_ACCESS_PRIORITY,"},{"line_number":400,"context_line":"                constants.MAX_ACCESS_PRIORITY + 1):"},{"line_number":401,"context_line":"            exc_str \u003d _(\"The priority value only support in range \""},{"line_number":402,"context_line":"                        \"%(min_priority)s ~ %(max_priority)s.\") % {"},{"line_number":403,"context_line":"                            \"min_priority\": constants.MIN_ACCESS_PRIORITY,"},{"line_number":404,"context_line":"                            \"max_priority\": constants.MAX_ACCESS_PRIORITY}"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_84978739","line":401,"range":{"start_line":401,"start_character":25,"end_line":401,"end_character":65},"updated":"2018-06-27 00:20:28.000000000","message":"Access rule priority can only be in range:","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"10e19ac862f34e8180c480473faa83af8e2d5200","unresolved":false,"context_lines":[{"line_number":398,"context_line":"        if access_data.get(\u0027priority\u0027) not in range("},{"line_number":399,"context_line":"                constants.MIN_ACCESS_PRIORITY,"},{"line_number":400,"context_line":"                constants.MAX_ACCESS_PRIORITY + 1):"},{"line_number":401,"context_line":"            exc_str \u003d _(\"The priority value only support in range \""},{"line_number":402,"context_line":"                        \"%(min_priority)s ~ %(max_priority)s.\") % {"},{"line_number":403,"context_line":"                            \"min_priority\": constants.MIN_ACCESS_PRIORITY,"},{"line_number":404,"context_line":"                            \"max_priority\": constants.MAX_ACCESS_PRIORITY}"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_b231800d","line":401,"range":{"start_line":401,"start_character":25,"end_line":401,"end_character":65},"in_reply_to":"5f7c97a3_84978739","updated":"2018-06-30 03:29:44.000000000","message":"Done","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"961436106a9d25c43f53a81b5142bb322773ca53","unresolved":false,"context_lines":[{"line_number":403,"context_line":"                            \"min_priority\": constants.MIN_ACCESS_PRIORITY,"},{"line_number":404,"context_line":"                            \"max_priority\": constants.MAX_ACCESS_PRIORITY}"},{"line_number":405,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dexc_str)"},{"line_number":406,"context_line":"        if not enable_priority:"},{"line_number":407,"context_line":"            exc_str \u003d _(\"Access rule\u0027s priority only available with manila\""},{"line_number":408,"context_line":"                        \"API version \u003e\u003d 2.45\")"},{"line_number":409,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dexc_str)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_04bcd7b2","line":409,"range":{"start_line":406,"start_character":0,"end_line":409,"end_character":63},"updated":"2018-06-27 00:20:28.000000000","message":"This is not backwards compatible; you should probably just log a warning... With this change, you\u0027re introducing an error message to API versions \u003c 2.45.","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"961436106a9d25c43f53a81b5142bb322773ca53","unresolved":false,"context_lines":[{"line_number":406,"context_line":"        if not enable_priority:"},{"line_number":407,"context_line":"            exc_str \u003d _(\"Access rule\u0027s priority only available with manila\""},{"line_number":408,"context_line":"                        \"API version \u003e\u003d 2.45\")"},{"line_number":409,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dexc_str)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_243eb328","line":409,"range":{"start_line":409,"start_character":0,"end_line":409,"end_character":63},"updated":"2018-06-27 00:20:28.000000000","message":"When you\u0027re done validating, return the access_priority back to the calling method","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"10e19ac862f34e8180c480473faa83af8e2d5200","unresolved":false,"context_lines":[{"line_number":403,"context_line":"                            \"min_priority\": constants.MIN_ACCESS_PRIORITY,"},{"line_number":404,"context_line":"                            \"max_priority\": constants.MAX_ACCESS_PRIORITY}"},{"line_number":405,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dexc_str)"},{"line_number":406,"context_line":"        if not enable_priority:"},{"line_number":407,"context_line":"            exc_str \u003d _(\"Access rule\u0027s priority only available with manila\""},{"line_number":408,"context_line":"                        \"API version \u003e\u003d 2.45\")"},{"line_number":409,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dexc_str)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_dd43edaf","line":409,"range":{"start_line":406,"start_character":0,"end_line":409,"end_character":63},"in_reply_to":"5f7c97a3_04bcd7b2","updated":"2018-06-30 03:29:44.000000000","message":"If we don\u0027t raise error when the request have the \u0027priority\u0027 and the version \u003c 2.45, the user may thought the priority value is work, but the actually the priority value doesn\u0027t work. I remember we discussed this in variy\u0027s patch and IRC meeting, the conclusion is we should raise the error.\n\nhttps://review.openstack.org/#/c/473464/11/manila/api/v2/quota_sets.py@94","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"10e19ac862f34e8180c480473faa83af8e2d5200","unresolved":false,"context_lines":[{"line_number":406,"context_line":"        if not enable_priority:"},{"line_number":407,"context_line":"            exc_str \u003d _(\"Access rule\u0027s priority only available with manila\""},{"line_number":408,"context_line":"                        \"API version \u003e\u003d 2.45\")"},{"line_number":409,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dexc_str)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_5d791d80","line":409,"range":{"start_line":409,"start_character":0,"end_line":409,"end_character":63},"in_reply_to":"5f7c97a3_243eb328","updated":"2018-06-30 03:29:44.000000000","message":"This function only check weather the access priority value is\n validate. above","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"d248c45bb4735d70b262233ad4830782376d4b47","unresolved":false,"context_lines":[{"line_number":403,"context_line":"                            \"min_priority\": constants.MIN_ACCESS_PRIORITY,"},{"line_number":404,"context_line":"                            \"max_priority\": constants.MAX_ACCESS_PRIORITY}"},{"line_number":405,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dexc_str)"},{"line_number":406,"context_line":"        if not enable_priority:"},{"line_number":407,"context_line":"            exc_str \u003d _(\"Access rule\u0027s priority only available with manila\""},{"line_number":408,"context_line":"                        \"API version \u003e\u003d 2.45\")"},{"line_number":409,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dexc_str)"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_3b50e45f","line":409,"range":{"start_line":406,"start_character":0,"end_line":409,"end_character":63},"in_reply_to":"5f7c97a3_dd43edaf","updated":"2018-07-11 20:48:37.000000000","message":"The conclusion was not to raise an error arbitrarily per API field. This is supposed to be handled by strict JSON schema validation - which is a parallel effort; if the behavior of the older API is to ignore extra keys, that behavior should be preserved until we can fix the APIs. See the discussion here:\n\n\nhttp://eavesdrop.openstack.org/meetings/manila/2017/manila.2017-07-13-15.00.log.txt","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b7455c50ceb77a2c57dbc373fd32f5780db082f8","unresolved":false,"context_lines":[{"line_number":404,"context_line":"                            \"max_priority\": constants.MAX_ACCESS_PRIORITY}"},{"line_number":405,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dexc_str)"},{"line_number":406,"context_line":"        if not enable_priority:"},{"line_number":407,"context_line":"            exc_str \u003d _(\"Access rule\u0027s priority only available with manila\""},{"line_number":408,"context_line":"                        \"API version \u003e\u003d 2.45\")"},{"line_number":409,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dexc_str)"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_dbef7084","line":408,"range":{"start_line":407,"start_character":11,"end_line":408,"end_character":46},"updated":"2018-07-11 21:37:00.000000000","message":"double validation? https://review.openstack.org/#/c/572283/3..9/manila/api/v1/shares.py@404","commit_id":"519d75dda306333dac07f875aa7079537162f011"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"62d95ba6ece96ca883e10f61f8108db0c28d6296","unresolved":false,"context_lines":[{"line_number":404,"context_line":"                            \"max_priority\": constants.MAX_ACCESS_PRIORITY}"},{"line_number":405,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dexc_str)"},{"line_number":406,"context_line":"        if not enable_priority:"},{"line_number":407,"context_line":"            exc_str \u003d _(\"Access rule\u0027s priority only available with manila\""},{"line_number":408,"context_line":"                        \"API version \u003e\u003d 2.45\")"},{"line_number":409,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dexc_str)"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_1f2b8fea","line":408,"range":{"start_line":407,"start_character":11,"end_line":408,"end_character":46},"in_reply_to":"5f7c97a3_dbef7084","updated":"2018-07-12 05:16:09.000000000","message":"Done","commit_id":"519d75dda306333dac07f875aa7079537162f011"}],"manila/api/openstack/api_version_request.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"961436106a9d25c43f53a81b5142bb322773ca53","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    * 2.42 - Added ``with_count`` in share list API to get total count info."},{"line_number":116,"context_line":"    * 2.43 - Added filter search by extra spec for share type list."},{"line_number":117,"context_line":"    * 2.44 - Added \u0027ou\u0027 field to \u0027security_service\u0027 object."},{"line_number":118,"context_line":"    * 2.45 - Added \u0027priority\u0027 field to \u0027access\u0027 object."},{"line_number":119,"context_line":"\"\"\""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_849d470a","line":118,"range":{"start_line":118,"start_character":13,"end_line":118,"end_character":55},"updated":"2018-06-27 00:20:28.000000000","message":"This version also adds an API to update access rules, and an API to list access rules","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"10e19ac862f34e8180c480473faa83af8e2d5200","unresolved":false,"context_lines":[{"line_number":115,"context_line":"    * 2.42 - Added ``with_count`` in share list API to get total count info."},{"line_number":116,"context_line":"    * 2.43 - Added filter search by extra spec for share type list."},{"line_number":117,"context_line":"    * 2.44 - Added \u0027ou\u0027 field to \u0027security_service\u0027 object."},{"line_number":118,"context_line":"    * 2.45 - Added \u0027priority\u0027 field to \u0027access\u0027 object."},{"line_number":119,"context_line":"\"\"\""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"# The minimum and maximum versions of the API supported"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_3daa211a","line":118,"range":{"start_line":118,"start_character":13,"end_line":118,"end_character":55},"in_reply_to":"5f7c97a3_849d470a","updated":"2018-06-30 03:29:44.000000000","message":"Done","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8ac00c8df3b7882a3539a6c9e92754d5364bcf4f","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    * 2.45 - Added access metadata for share access and also introduced"},{"line_number":120,"context_line":"             the GET /share-access-rules API. The prior API to retrieve"},{"line_number":121,"context_line":"             access rules will not work with API version \u003e\u003d2.45."},{"line_number":122,"context_line":"    * 2.46 - Added \u0027priority\u0027 field to \u0027access\u0027 object, new API to update/list"},{"line_number":123,"context_line":"             access rules."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"\"\"\""},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"5f7c97a3_0a74c736","line":123,"range":{"start_line":122,"start_character":67,"end_line":123,"end_character":26},"updated":"2018-07-24 03:48:38.000000000","message":"update access rules, and added sorting, filtering and pagination support to the GET /share-access-rules API","commit_id":"650a54003a7d6545c94e7f6871b3edf1619b2482"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8ac00c8df3b7882a3539a6c9e92754d5364bcf4f","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    * 2.45 - Added access metadata for share access and also introduced"},{"line_number":120,"context_line":"             the GET /share-access-rules API. The prior API to retrieve"},{"line_number":121,"context_line":"             access rules will not work with API version \u003e\u003d2.45."},{"line_number":122,"context_line":"    * 2.46 - Added \u0027priority\u0027 field to \u0027access\u0027 object, new API to update/list"},{"line_number":123,"context_line":"             access rules."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"\"\"\""},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_08b83376","line":123,"range":{"start_line":122,"start_character":67,"end_line":123,"end_character":26},"updated":"2018-07-24 03:48:38.000000000","message":"update access rules, and added sorting, filtering and pagination support to the GET /share-access-rules API","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"357bdab92ed8d186b62a19cb3db8bdcddfc71b3c","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    * 2.45 - Added access metadata for share access and also introduced"},{"line_number":120,"context_line":"             the GET /share-access-rules API. The prior API to retrieve"},{"line_number":121,"context_line":"             access rules will not work with API version \u003e\u003d2.45."},{"line_number":122,"context_line":"    * 2.46 - Added \u0027priority\u0027 field to \u0027access\u0027 object, new API to update/list"},{"line_number":123,"context_line":"             access rules."},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"\"\"\""},{"line_number":126,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_866ad8e9","line":123,"range":{"start_line":122,"start_character":67,"end_line":123,"end_character":26},"in_reply_to":"5f7c97a3_08b83376","updated":"2018-07-26 08:52:53.000000000","message":"Done","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"}],"manila/api/openstack/rest_api_version_history.rst":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"961436106a9d25c43f53a81b5142bb322773ca53","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"2.45"},{"line_number":247,"context_line":"----"},{"line_number":248,"context_line":"  Added \u0027priority\u0027 field to \u0027access\u0027 object."}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f7c97a3_2488f3c3","line":248,"range":{"start_line":248,"start_character":0,"end_line":248,"end_character":44},"updated":"2018-06-27 00:20:28.000000000","message":"+ new API to update access rules and new API to list access rules","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"10e19ac862f34e8180c480473faa83af8e2d5200","unresolved":false,"context_lines":[{"line_number":245,"context_line":""},{"line_number":246,"context_line":"2.45"},{"line_number":247,"context_line":"----"},{"line_number":248,"context_line":"  Added \u0027priority\u0027 field to \u0027access\u0027 object."}],"source_content_type":"text/x-rst","patch_set":3,"id":"5f7c97a3_f8def768","line":248,"range":{"start_line":248,"start_character":0,"end_line":248,"end_character":44},"in_reply_to":"5f7c97a3_2488f3c3","updated":"2018-06-30 03:29:44.000000000","message":"Done","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8ac00c8df3b7882a3539a6c9e92754d5364bcf4f","unresolved":false,"context_lines":[{"line_number":251,"context_line":""},{"line_number":252,"context_line":"2.46"},{"line_number":253,"context_line":"----"},{"line_number":254,"context_line":"  Added \u0027priority\u0027 field to \u0027access\u0027 object, new API to update/list"},{"line_number":255,"context_line":"  access rules."},{"line_number":256,"context_line":""}],"source_content_type":"text/x-rst","patch_set":17,"id":"5f7c97a3_8a8d372b","line":255,"range":{"start_line":254,"start_character":56,"end_line":255,"end_character":15},"updated":"2018-07-24 03:48:38.000000000","message":"update access rules, and added sorting, filtering and pagination support to the GET /share-access-rules API","commit_id":"650a54003a7d6545c94e7f6871b3edf1619b2482"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8ac00c8df3b7882a3539a6c9e92754d5364bcf4f","unresolved":false,"context_lines":[{"line_number":251,"context_line":""},{"line_number":252,"context_line":"2.46"},{"line_number":253,"context_line":"----"},{"line_number":254,"context_line":"  Added \u0027priority\u0027 field to \u0027access\u0027 object, new API to update/list"},{"line_number":255,"context_line":"  access rules."},{"line_number":256,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"5f7c97a3_c8b1db93","line":255,"range":{"start_line":254,"start_character":56,"end_line":255,"end_character":15},"updated":"2018-07-24 03:48:38.000000000","message":"update access rules, and added sorting, filtering and pagination support to the GET /share-access-rules API","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"357bdab92ed8d186b62a19cb3db8bdcddfc71b3c","unresolved":false,"context_lines":[{"line_number":251,"context_line":""},{"line_number":252,"context_line":"2.46"},{"line_number":253,"context_line":"----"},{"line_number":254,"context_line":"  Added \u0027priority\u0027 field to \u0027access\u0027 object, new API to update/list"},{"line_number":255,"context_line":"  access rules."},{"line_number":256,"context_line":""}],"source_content_type":"text/x-rst","patch_set":19,"id":"5f7c97a3_267184e0","line":255,"range":{"start_line":254,"start_character":56,"end_line":255,"end_character":15},"in_reply_to":"5f7c97a3_c8b1db93","updated":"2018-07-26 08:52:53.000000000","message":"Done","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"}],"manila/api/v1/shares.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"961436106a9d25c43f53a81b5142bb322773ca53","unresolved":false,"context_lines":[{"line_number":400,"context_line":"        share \u003d self.share_api.get(context, id)"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"        common.validate_access_priority(access_data, enable_priority)"},{"line_number":403,"context_line":"        priority \u003d access_data.get(\u0027priority\u0027, 100)"},{"line_number":404,"context_line":"        if (not allow_on_error_status and"},{"line_number":405,"context_line":"                self._any_instance_has_errored_rules(share)):"},{"line_number":406,"context_line":"            msg \u003d _(\"Access rules cannot be added while the share or any of \""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_44cbaf48","line":403,"range":{"start_line":403,"start_character":0,"end_line":403,"end_character":51},"updated":"2018-06-27 00:20:28.000000000","message":"move logic to validate_access_priority method and use the constant defined.","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"10e19ac862f34e8180c480473faa83af8e2d5200","unresolved":false,"context_lines":[{"line_number":400,"context_line":"        share \u003d self.share_api.get(context, id)"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"        common.validate_access_priority(access_data, enable_priority)"},{"line_number":403,"context_line":"        priority \u003d access_data.get(\u0027priority\u0027, 100)"},{"line_number":404,"context_line":"        if (not allow_on_error_status and"},{"line_number":405,"context_line":"                self._any_instance_has_errored_rules(share)):"},{"line_number":406,"context_line":"            msg \u003d _(\"Access rules cannot be added while the share or any of \""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_d8721b4b","line":403,"range":{"start_line":403,"start_character":0,"end_line":403,"end_character":51},"in_reply_to":"5f7c97a3_44cbaf48","updated":"2018-06-30 03:29:44.000000000","message":"The different logic have different default value. The default value is 100 in create access API, The default value is None in update access API. It cloud also have the other logic in some thing else, so it cloud be more clear to not add this logic in validate_access_priority.","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6bb1d7aa0e2b0c0d3c1f5b895cbc4fc0840db11b","unresolved":false,"context_lines":[{"line_number":403,"context_line":"            access_data.pop(\u0027priority\u0027, None)"},{"line_number":404,"context_line":"        share \u003d self.share_api.get(context, id)"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"        common.validate_access_priority(access_data)"},{"line_number":407,"context_line":"        priority \u003d access_data.get("},{"line_number":408,"context_line":"            \u0027priority\u0027, constants.DEFAULT_ACCESS_PRIORITY)"},{"line_number":409,"context_line":"        if (not allow_on_error_status and"}],"source_content_type":"text/x-python","patch_set":22,"id":"3f79a3b5_d57b4b77","line":406,"range":{"start_line":406,"start_character":8,"end_line":406,"end_character":52},"updated":"2018-10-11 13:09:30.000000000","message":"no need to validate if you pop it, you could add this to an else clause above.","commit_id":"7b50d837d2d9820210d339408adc67266f4ce7a4"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"f183da3b53c7a9d5ffe5c8313892f092654cc79b","unresolved":false,"context_lines":[{"line_number":403,"context_line":"            access_data.pop(\u0027priority\u0027, None)"},{"line_number":404,"context_line":"        share \u003d self.share_api.get(context, id)"},{"line_number":405,"context_line":""},{"line_number":406,"context_line":"        common.validate_access_priority(access_data)"},{"line_number":407,"context_line":"        priority \u003d access_data.get("},{"line_number":408,"context_line":"            \u0027priority\u0027, constants.DEFAULT_ACCESS_PRIORITY)"},{"line_number":409,"context_line":"        if (not allow_on_error_status and"}],"source_content_type":"text/x-python","patch_set":22,"id":"3f79a3b5_833433fc","line":406,"range":{"start_line":406,"start_character":8,"end_line":406,"end_character":52},"in_reply_to":"3f79a3b5_d57b4b77","updated":"2018-10-18 03:09:27.000000000","message":"Done","commit_id":"7b50d837d2d9820210d339408adc67266f4ce7a4"}],"manila/api/v2/router.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"961436106a9d25c43f53a81b5142bb322773ca53","unresolved":false,"context_lines":[{"line_number":425,"context_line":"            controller\u003dself.resources[\"share-access-rules\"],"},{"line_number":426,"context_line":"            collection\u003d{\u0027detail\u0027: \u0027GET\u0027},"},{"line_number":427,"context_line":"            member\u003d{\u0027update\u0027: \u0027PATCH\u0027})"},{"line_number":428,"context_line":"        # mapper.connect("},{"line_number":429,"context_line":"        #     \"share-access-rules\","},{"line_number":430,"context_line":"        #     \"/{project_id}/share-access-rules/{access_id}\","},{"line_number":431,"context_line":"        #     controller\u003dself.resources[\"share-access-rules\"],"},{"line_number":432,"context_line":"        #     action\u003d\"update\","},{"line_number":433,"context_line":"        #     conditions\u003d{\"method\": [\"PATCH\"]})"},{"line_number":434,"context_line":"        # \u003d{\u0027update\u0027: \u0027PATCH\u0027}"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_e443dbae","line":434,"range":{"start_line":428,"start_character":0,"end_line":434,"end_character":30},"updated":"2018-06-27 00:20:28.000000000","message":"remove?","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"10e19ac862f34e8180c480473faa83af8e2d5200","unresolved":false,"context_lines":[{"line_number":425,"context_line":"            controller\u003dself.resources[\"share-access-rules\"],"},{"line_number":426,"context_line":"            collection\u003d{\u0027detail\u0027: \u0027GET\u0027},"},{"line_number":427,"context_line":"            member\u003d{\u0027update\u0027: \u0027PATCH\u0027})"},{"line_number":428,"context_line":"        # mapper.connect("},{"line_number":429,"context_line":"        #     \"share-access-rules\","},{"line_number":430,"context_line":"        #     \"/{project_id}/share-access-rules/{access_id}\","},{"line_number":431,"context_line":"        #     controller\u003dself.resources[\"share-access-rules\"],"},{"line_number":432,"context_line":"        #     action\u003d\"update\","},{"line_number":433,"context_line":"        #     conditions\u003d{\"method\": [\"PATCH\"]})"},{"line_number":434,"context_line":"        # \u003d{\u0027update\u0027: \u0027PATCH\u0027}"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_988a6311","line":434,"range":{"start_line":428,"start_character":0,"end_line":434,"end_character":30},"in_reply_to":"5f7c97a3_e443dbae","updated":"2018-06-30 03:29:44.000000000","message":"Done","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8ac00c8df3b7882a3539a6c9e92754d5364bcf4f","unresolved":false,"context_lines":[{"line_number":424,"context_line":"            \"share-access-rules\","},{"line_number":425,"context_line":"            controller\u003dself.resources[\"share-access-rules\"],"},{"line_number":426,"context_line":"            collection\u003d{\"detail\": \"GET\"},"},{"line_number":427,"context_line":"            member\u003d{\u0027update\u0027: \u0027PATCH\u0027})"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"        self.resources[\"access-metadata\"] \u003d ("},{"line_number":430,"context_line":"            share_access_metadata.create_resource())"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_48a5cb47","line":427,"range":{"start_line":427,"start_character":20,"end_line":427,"end_character":37},"updated":"2018-07-24 03:48:38.000000000","message":"nit: double quotes for consistency with above","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"357bdab92ed8d186b62a19cb3db8bdcddfc71b3c","unresolved":false,"context_lines":[{"line_number":424,"context_line":"            \"share-access-rules\","},{"line_number":425,"context_line":"            controller\u003dself.resources[\"share-access-rules\"],"},{"line_number":426,"context_line":"            collection\u003d{\"detail\": \"GET\"},"},{"line_number":427,"context_line":"            member\u003d{\u0027update\u0027: \u0027PATCH\u0027})"},{"line_number":428,"context_line":""},{"line_number":429,"context_line":"        self.resources[\"access-metadata\"] \u003d ("},{"line_number":430,"context_line":"            share_access_metadata.create_resource())"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_0676c8d6","line":427,"range":{"start_line":427,"start_character":20,"end_line":427,"end_character":37},"in_reply_to":"5f7c97a3_48a5cb47","updated":"2018-07-26 08:52:53.000000000","message":"Done","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"}],"manila/api/v2/share_accesses.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"961436106a9d25c43f53a81b5142bb322773ca53","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        self.share_api \u003d share.API()"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @wsgi.Controller.api_version(\u00272.45\u0027)"},{"line_number":40,"context_line":"    @wsgi.Controller.authorize"},{"line_number":41,"context_line":"    def update(self, req, id, body):"},{"line_number":42,"context_line":"        \"\"\"Return data about the given share access.\"\"\""},{"line_number":43,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_9f835256","line":41,"range":{"start_line":40,"start_character":0,"end_line":41,"end_character":36},"updated":"2018-06-27 00:20:28.000000000","message":"This needs a new policy under manila/policy","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"10e19ac862f34e8180c480473faa83af8e2d5200","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        self.share_api \u003d share.API()"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    @wsgi.Controller.api_version(\u00272.45\u0027)"},{"line_number":40,"context_line":"    @wsgi.Controller.authorize"},{"line_number":41,"context_line":"    def update(self, req, id, body):"},{"line_number":42,"context_line":"        \"\"\"Return data about the given share access.\"\"\""},{"line_number":43,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_4c72cce6","line":41,"range":{"start_line":40,"start_character":0,"end_line":41,"end_character":36},"in_reply_to":"5f7c97a3_9f835256","updated":"2018-06-30 03:29:44.000000000","message":"Done","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"961436106a9d25c43f53a81b5142bb322773ca53","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        priority \u003d access_data.get(\u0027priority\u0027)"},{"line_number":59,"context_line":"        if priority:"},{"line_number":60,"context_line":"            share_access \u003d db.share_access_update(context, share_access[\u0027id\u0027],"},{"line_number":61,"context_line":"                                                  {\u0027priority\u0027: priority})"},{"line_number":62,"context_line":"        return self._view_builder.view(req, share_access)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _get_share_access(self, context, share_access_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_9f3031a0","line":61,"range":{"start_line":60,"start_character":0,"end_line":61,"end_character":73},"updated":"2018-06-27 00:20:28.000000000","message":"You don\u0027t actually process the update on the share backend?","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"10e19ac862f34e8180c480473faa83af8e2d5200","unresolved":false,"context_lines":[{"line_number":57,"context_line":""},{"line_number":58,"context_line":"        priority \u003d access_data.get(\u0027priority\u0027)"},{"line_number":59,"context_line":"        if priority:"},{"line_number":60,"context_line":"            share_access \u003d db.share_access_update(context, share_access[\u0027id\u0027],"},{"line_number":61,"context_line":"                                                  {\u0027priority\u0027: priority})"},{"line_number":62,"context_line":"        return self._view_builder.view(req, share_access)"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _get_share_access(self, context, share_access_id):"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_1b7f1167","line":61,"range":{"start_line":60,"start_character":0,"end_line":61,"end_character":73},"in_reply_to":"5f7c97a3_9f3031a0","updated":"2018-06-30 03:29:44.000000000","message":"Done","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"961436106a9d25c43f53a81b5142bb322773ca53","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            msg \u003d _(\"Share access %s not found.\") % share_access_id"},{"line_number":69,"context_line":"            raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    @wsgi.Controller.api_version(\u00272.45\u0027)"},{"line_number":72,"context_line":"    @wsgi.Controller.authorize"},{"line_number":73,"context_line":"    def index(self, req):"},{"line_number":74,"context_line":"        \"\"\"Returns the list of access for a given share.\"\"\""},{"line_number":75,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":76,"context_line":"        search_opts \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_df8c6a81","line":73,"range":{"start_line":71,"start_character":0,"end_line":73,"end_character":25},"updated":"2018-06-27 00:20:28.000000000","message":"This needs a new default policy under manila/policy/ -\u003e It must use the same default as the older one: \"share:access_get_all\"","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"10e19ac862f34e8180c480473faa83af8e2d5200","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            msg \u003d _(\"Share access %s not found.\") % share_access_id"},{"line_number":69,"context_line":"            raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    @wsgi.Controller.api_version(\u00272.45\u0027)"},{"line_number":72,"context_line":"    @wsgi.Controller.authorize"},{"line_number":73,"context_line":"    def index(self, req):"},{"line_number":74,"context_line":"        \"\"\"Returns the list of access for a given share.\"\"\""},{"line_number":75,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":76,"context_line":"        search_opts \u003d {}"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_0c037412","line":73,"range":{"start_line":71,"start_character":0,"end_line":73,"end_character":25},"in_reply_to":"5f7c97a3_df8c6a81","updated":"2018-06-30 03:29:44.000000000","message":"Done","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"961436106a9d25c43f53a81b5142bb322773ca53","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        search_opts \u003d {}"},{"line_number":77,"context_line":"        search_opts.update(req.GET)"},{"line_number":78,"context_line":"        share_id \u003d search_opts.pop(\u0027share_id\u0027, None)"},{"line_number":79,"context_line":"        sort_key \u003d search_opts.pop(\u0027sort_key\u0027, \u0027priority\u0027)"},{"line_number":80,"context_line":"        sort_dir \u003d search_opts.pop(\u0027sort_dir\u0027, \u0027desc\u0027)"},{"line_number":81,"context_line":"        try:"},{"line_number":82,"context_line":"            share \u003d self.share_api.get(context, share_id)"},{"line_number":83,"context_line":"        except exception.NotFound:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_bf7baef1","line":80,"range":{"start_line":79,"start_character":0,"end_line":80,"end_character":54},"updated":"2018-06-27 00:20:28.000000000","message":"Pagination should be implemented as well, with `limit` and `offset`..","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"961436106a9d25c43f53a81b5142bb322773ca53","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        search_opts.update(req.GET)"},{"line_number":78,"context_line":"        share_id \u003d search_opts.pop(\u0027share_id\u0027, None)"},{"line_number":79,"context_line":"        sort_key \u003d search_opts.pop(\u0027sort_key\u0027, \u0027priority\u0027)"},{"line_number":80,"context_line":"        sort_dir \u003d search_opts.pop(\u0027sort_dir\u0027, \u0027desc\u0027)"},{"line_number":81,"context_line":"        try:"},{"line_number":82,"context_line":"            share \u003d self.share_api.get(context, share_id)"},{"line_number":83,"context_line":"        except exception.NotFound:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_7f6bd6ee","line":80,"range":{"start_line":80,"start_character":48,"end_line":80,"end_character":52},"updated":"2018-06-27 00:20:28.000000000","message":"The sort direction should be \"asc\"","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"10e19ac862f34e8180c480473faa83af8e2d5200","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        search_opts.update(req.GET)"},{"line_number":78,"context_line":"        share_id \u003d search_opts.pop(\u0027share_id\u0027, None)"},{"line_number":79,"context_line":"        sort_key \u003d search_opts.pop(\u0027sort_key\u0027, \u0027priority\u0027)"},{"line_number":80,"context_line":"        sort_dir \u003d search_opts.pop(\u0027sort_dir\u0027, \u0027desc\u0027)"},{"line_number":81,"context_line":"        try:"},{"line_number":82,"context_line":"            share \u003d self.share_api.get(context, share_id)"},{"line_number":83,"context_line":"        except exception.NotFound:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_8c41c466","line":80,"range":{"start_line":80,"start_character":48,"end_line":80,"end_character":52},"in_reply_to":"5f7c97a3_7f6bd6ee","updated":"2018-06-30 03:29:44.000000000","message":"Done","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"10e19ac862f34e8180c480473faa83af8e2d5200","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        search_opts \u003d {}"},{"line_number":77,"context_line":"        search_opts.update(req.GET)"},{"line_number":78,"context_line":"        share_id \u003d search_opts.pop(\u0027share_id\u0027, None)"},{"line_number":79,"context_line":"        sort_key \u003d search_opts.pop(\u0027sort_key\u0027, \u0027priority\u0027)"},{"line_number":80,"context_line":"        sort_dir \u003d search_opts.pop(\u0027sort_dir\u0027, \u0027desc\u0027)"},{"line_number":81,"context_line":"        try:"},{"line_number":82,"context_line":"            share \u003d self.share_api.get(context, share_id)"},{"line_number":83,"context_line":"        except exception.NotFound:"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_00033512","line":80,"range":{"start_line":79,"start_character":0,"end_line":80,"end_character":54},"in_reply_to":"5f7c97a3_bf7baef1","updated":"2018-06-30 03:29:44.000000000","message":"Done","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"961436106a9d25c43f53a81b5142bb322773ca53","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        sort_dir \u003d search_opts.pop(\u0027sort_dir\u0027, \u0027desc\u0027)"},{"line_number":81,"context_line":"        try:"},{"line_number":82,"context_line":"            share \u003d self.share_api.get(context, share_id)"},{"line_number":83,"context_line":"        except exception.NotFound:"},{"line_number":84,"context_line":"            msg \u003d _(\"Share %s not found.\") % share_id"},{"line_number":85,"context_line":"            raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":86,"context_line":"        access_rules \u003d self.share_api.access_get_all("}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_5fc7fa98","line":83,"range":{"start_line":83,"start_character":25,"end_line":83,"end_character":33},"updated":"2018-06-27 00:20:28.000000000","message":"Unless the resource ID is part of the endpoint, NotFound isn\u0027t an appropriate response. Replace with BadRequest","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"10e19ac862f34e8180c480473faa83af8e2d5200","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        sort_dir \u003d search_opts.pop(\u0027sort_dir\u0027, \u0027desc\u0027)"},{"line_number":81,"context_line":"        try:"},{"line_number":82,"context_line":"            share \u003d self.share_api.get(context, share_id)"},{"line_number":83,"context_line":"        except exception.NotFound:"},{"line_number":84,"context_line":"            msg \u003d _(\"Share %s not found.\") % share_id"},{"line_number":85,"context_line":"            raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":86,"context_line":"        access_rules \u003d self.share_api.access_get_all("}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_2f15023e","line":83,"range":{"start_line":83,"start_character":25,"end_line":83,"end_character":33},"in_reply_to":"5f7c97a3_5fc7fa98","updated":"2018-06-30 03:29:44.000000000","message":"Done","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"961436106a9d25c43f53a81b5142bb322773ca53","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        try:"},{"line_number":82,"context_line":"            share \u003d self.share_api.get(context, share_id)"},{"line_number":83,"context_line":"        except exception.NotFound:"},{"line_number":84,"context_line":"            msg \u003d _(\"Share %s not found.\") % share_id"},{"line_number":85,"context_line":"            raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":86,"context_line":"        access_rules \u003d self.share_api.access_get_all("},{"line_number":87,"context_line":"            context, share, search_opts, sort_key\u003dsort_key,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_ffb5a619","line":84,"range":{"start_line":84,"start_character":21,"end_line":84,"end_character":40},"updated":"2018-06-27 00:20:28.000000000","message":"What if share_id is not present in the query?","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"10e19ac862f34e8180c480473faa83af8e2d5200","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        try:"},{"line_number":82,"context_line":"            share \u003d self.share_api.get(context, share_id)"},{"line_number":83,"context_line":"        except exception.NotFound:"},{"line_number":84,"context_line":"            msg \u003d _(\"Share %s not found.\") % share_id"},{"line_number":85,"context_line":"            raise exc.HTTPNotFound(explanation\u003dmsg)"},{"line_number":86,"context_line":"        access_rules \u003d self.share_api.access_get_all("},{"line_number":87,"context_line":"            context, share, search_opts, sort_key\u003dsort_key,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_a09fe100","line":84,"range":{"start_line":84,"start_character":21,"end_line":84,"end_character":40},"in_reply_to":"5f7c97a3_ffb5a619","updated":"2018-06-30 03:29:44.000000000","message":"Done","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f6104e058d8a0536f3892f74996617a001cd8236","unresolved":false,"context_lines":[{"line_number":52,"context_line":"            msg \u003d _(\"The fields %s are invalid or not allowed to be updated.\")"},{"line_number":53,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg % invalid_fields)"},{"line_number":54,"context_line":"        if \u0027priority\u0027 not in access_data:"},{"line_number":55,"context_line":"            msg \u003d _(\"The fields \u0027priority\u0027 is not set.\")"},{"line_number":56,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":57,"context_line":"        common.validate_access_priority(access_data)"},{"line_number":58,"context_line":"        share_access \u003d self._get_share_access(context, id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_106d7ecb","line":55,"range":{"start_line":55,"start_character":21,"end_line":55,"end_character":56},"updated":"2018-07-18 22:13:58.000000000","message":"Suggest: \"The \u0027priority\u0027 field is not set.\"","commit_id":"246f491fd063cb0d01b3ef17a12b0a3cb35cc7d6"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f6104e058d8a0536f3892f74996617a001cd8236","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        sort_key \u003d search_opts.pop(\u0027sort_key\u0027, \u0027priority\u0027)"},{"line_number":78,"context_line":"        sort_dir \u003d search_opts.pop(\u0027sort_dir\u0027, \u0027asc\u0027)"},{"line_number":79,"context_line":"        if share_id is None:"},{"line_number":80,"context_line":"            exc_str \u003d _(\"The share id doesn\u0027t set.\")"},{"line_number":81,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dexc_str)"},{"line_number":82,"context_line":"        try:"},{"line_number":83,"context_line":"            share \u003d self.share_api.get(context, share_id)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_707632a6","line":80,"range":{"start_line":80,"start_character":24,"end_line":80,"end_character":51},"updated":"2018-07-18 22:13:58.000000000","message":"\"The \u0027share id\u0027 field is not set.\"","commit_id":"246f491fd063cb0d01b3ef17a12b0a3cb35cc7d6"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b7455c50ceb77a2c57dbc373fd32f5780db082f8","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @wsgi.Controller.api_version(\u00272.46\u0027)"},{"line_number":42,"context_line":"    @wsgi.Controller.authorize"},{"line_number":43,"context_line":"    def update(self, req, id, body):"},{"line_number":44,"context_line":"        \"\"\"Return data about the given share access.\"\"\""},{"line_number":45,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_d6d18758","line":43,"range":{"start_line":43,"start_character":8,"end_line":43,"end_character":14},"updated":"2018-07-11 21:37:00.000000000","message":"@wsgi.response(202)","commit_id":"519d75dda306333dac07f875aa7079537162f011"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"62d95ba6ece96ca883e10f61f8108db0c28d6296","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @wsgi.Controller.api_version(\u00272.46\u0027)"},{"line_number":42,"context_line":"    @wsgi.Controller.authorize"},{"line_number":43,"context_line":"    def update(self, req, id, body):"},{"line_number":44,"context_line":"        \"\"\"Return data about the given share access.\"\"\""},{"line_number":45,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_624c683f","line":43,"range":{"start_line":43,"start_character":8,"end_line":43,"end_character":14},"in_reply_to":"5f7c97a3_d6d18758","updated":"2018-07-12 05:16:09.000000000","message":"Done","commit_id":"519d75dda306333dac07f875aa7079537162f011"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b7455c50ceb77a2c57dbc373fd32f5780db082f8","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        access_data \u003d body[\u0027access\u0027]"},{"line_number":52,"context_line":"        common.validate_fields({\u0027priority\u0027, }, set(access_data.keys()))"},{"line_number":53,"context_line":"        if \u0027priority\u0027 not in access_data:"},{"line_number":54,"context_line":"            msg \u003d _(\"The fields \u0027priority\u0027 is not set.\")"},{"line_number":55,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":56,"context_line":"        common.validate_access_priority(access_data)"},{"line_number":57,"context_line":"        share_access \u003d self._get_share_access(context, id)"},{"line_number":58,"context_line":"        share_access \u003d self.share_api.update_access("}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_36d79b53","line":55,"range":{"start_line":53,"start_character":0,"end_line":55,"end_character":53},"updated":"2018-07-11 21:37:00.000000000","message":"The implementation in PS3 was correct, if no updates, just return 200 - what if we add different updatable fields? \u0027priority\u0027 wouldn\u0027t always need to be updated then\n\n\nif no fields are updated, you can return webob.Response(status_int\u003dhttp_client.OK)","commit_id":"519d75dda306333dac07f875aa7079537162f011"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"62d95ba6ece96ca883e10f61f8108db0c28d6296","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"        access_data \u003d body[\u0027access\u0027]"},{"line_number":52,"context_line":"        common.validate_fields({\u0027priority\u0027, }, set(access_data.keys()))"},{"line_number":53,"context_line":"        if \u0027priority\u0027 not in access_data:"},{"line_number":54,"context_line":"            msg \u003d _(\"The fields \u0027priority\u0027 is not set.\")"},{"line_number":55,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":56,"context_line":"        common.validate_access_priority(access_data)"},{"line_number":57,"context_line":"        share_access \u003d self._get_share_access(context, id)"},{"line_number":58,"context_line":"        share_access \u003d self.share_api.update_access("}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_ff46d37e","line":55,"range":{"start_line":53,"start_character":0,"end_line":55,"end_character":53},"in_reply_to":"5f7c97a3_36d79b53","updated":"2018-07-12 05:16:09.000000000","message":"Done","commit_id":"519d75dda306333dac07f875aa7079537162f011"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b7455c50ceb77a2c57dbc373fd32f5780db082f8","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        offset \u003d search_opts.pop(\u0027offset\u0027, None)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        if share_id is None:"},{"line_number":95,"context_line":"            exc_str \u003d _(\"The share id doesn\u0027t set.\")"},{"line_number":96,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dexc_str)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        if \u0027metadata\u0027 in search_opts:"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_769f53b3","line":95,"range":{"start_line":95,"start_character":35,"end_line":95,"end_character":50},"updated":"2018-07-11 21:37:00.000000000","message":"ID is required to retrieve access rules","commit_id":"519d75dda306333dac07f875aa7079537162f011"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"62d95ba6ece96ca883e10f61f8108db0c28d6296","unresolved":false,"context_lines":[{"line_number":92,"context_line":"        offset \u003d search_opts.pop(\u0027offset\u0027, None)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        if share_id is None:"},{"line_number":95,"context_line":"            exc_str \u003d _(\"The share id doesn\u0027t set.\")"},{"line_number":96,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dexc_str)"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"        if \u0027metadata\u0027 in search_opts:"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_3f544b22","line":95,"range":{"start_line":95,"start_character":35,"end_line":95,"end_character":50},"in_reply_to":"5f7c97a3_769f53b3","updated":"2018-07-12 05:16:09.000000000","message":"Done","commit_id":"519d75dda306333dac07f875aa7079537162f011"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bb89ed34c16de65175305e414dcfcc5970c823dd","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        super(ShareAccessesController, self).__init__()"},{"line_number":43,"context_line":"        self.share_api \u003d share.API()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @wsgi.Controller.api_version(\u00272.46\u0027)"},{"line_number":46,"context_line":"    @wsgi.Controller.authorize"},{"line_number":47,"context_line":"    @wsgi.response(202)"},{"line_number":48,"context_line":"    def update(self, req, id, body):"},{"line_number":49,"context_line":"        \"\"\"Return data about the given share access.\"\"\""},{"line_number":50,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_7318bccc","line":48,"range":{"start_line":45,"start_character":4,"end_line":48,"end_character":36},"updated":"2018-07-24 03:58:57.000000000","message":"This method is not unit-tested","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"357bdab92ed8d186b62a19cb3db8bdcddfc71b3c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"        super(ShareAccessesController, self).__init__()"},{"line_number":43,"context_line":"        self.share_api \u003d share.API()"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    @wsgi.Controller.api_version(\u00272.46\u0027)"},{"line_number":46,"context_line":"    @wsgi.Controller.authorize"},{"line_number":47,"context_line":"    @wsgi.response(202)"},{"line_number":48,"context_line":"    def update(self, req, id, body):"},{"line_number":49,"context_line":"        \"\"\"Return data about the given share access.\"\"\""},{"line_number":50,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":51,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_44c25c04","line":48,"range":{"start_line":45,"start_character":4,"end_line":48,"end_character":36},"in_reply_to":"5f7c97a3_7318bccc","updated":"2018-07-26 08:52:53.000000000","message":"Done","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8ac00c8df3b7882a3539a6c9e92754d5364bcf4f","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            msg \u003d _(\"\u0027access\u0027 is missing from the request body.\")"},{"line_number":54,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        access_data \u003d body[\u0027access\u0027]"},{"line_number":57,"context_line":"        if all(field not in access_data for field in access_data):"},{"line_number":58,"context_line":"            LOG.warning(\"The one of fields \u0027priority\u0027 is not set.\")"},{"line_number":59,"context_line":"            return webob.Response(status_int\u003dhttp_client.OK)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        common.validate_access_priority(access_data)"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_c83f9bdd","line":59,"range":{"start_line":56,"start_character":0,"end_line":59,"end_character":60},"updated":"2018-07-24 03:48:38.000000000","message":"what is this code meant to do?","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"357bdab92ed8d186b62a19cb3db8bdcddfc71b3c","unresolved":false,"context_lines":[{"line_number":53,"context_line":"            msg \u003d _(\"\u0027access\u0027 is missing from the request body.\")"},{"line_number":54,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        access_data \u003d body[\u0027access\u0027]"},{"line_number":57,"context_line":"        if all(field not in access_data for field in access_data):"},{"line_number":58,"context_line":"            LOG.warning(\"The one of fields \u0027priority\u0027 is not set.\")"},{"line_number":59,"context_line":"            return webob.Response(status_int\u003dhttp_client.OK)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        common.validate_access_priority(access_data)"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_614aea82","line":59,"range":{"start_line":56,"start_character":0,"end_line":59,"end_character":60},"in_reply_to":"5f7c97a3_c83f9bdd","updated":"2018-07-26 08:52:53.000000000","message":"This means we have to set one of the update parameter in request API. If we don\u0027t set any available update parameter, we will just return ok and don\u0027t need to go to next step.","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8ac00c8df3b7882a3539a6c9e92754d5364bcf4f","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            search_opts.pop(\u0027limit\u0027, None)"},{"line_number":97,"context_line":"            search_opts.pop(\u0027offset\u0027, None)"},{"line_number":98,"context_line":"        share_id \u003d search_opts.pop(\u0027share_id\u0027, None)"},{"line_number":99,"context_line":"        sort_key \u003d search_opts.pop(\u0027sort_key\u0027, \u0027share_id\u0027)"},{"line_number":100,"context_line":"        sort_dir \u003d search_opts.pop(\u0027sort_dir\u0027, \u0027asc\u0027)"},{"line_number":101,"context_line":"        limit \u003d search_opts.pop(\u0027limit\u0027, None)"},{"line_number":102,"context_line":"        offset \u003d search_opts.pop(\u0027offset\u0027, None)"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_6850c72d","line":99,"range":{"start_line":99,"start_character":47,"end_line":99,"end_character":58},"updated":"2018-07-24 03:48:38.000000000","message":"The default must be None, \"share_id\" is the same for all access rules of a given share, it makes no sense to default to this value.","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"357bdab92ed8d186b62a19cb3db8bdcddfc71b3c","unresolved":false,"context_lines":[{"line_number":96,"context_line":"            search_opts.pop(\u0027limit\u0027, None)"},{"line_number":97,"context_line":"            search_opts.pop(\u0027offset\u0027, None)"},{"line_number":98,"context_line":"        share_id \u003d search_opts.pop(\u0027share_id\u0027, None)"},{"line_number":99,"context_line":"        sort_key \u003d search_opts.pop(\u0027sort_key\u0027, \u0027share_id\u0027)"},{"line_number":100,"context_line":"        sort_dir \u003d search_opts.pop(\u0027sort_dir\u0027, \u0027asc\u0027)"},{"line_number":101,"context_line":"        limit \u003d search_opts.pop(\u0027limit\u0027, None)"},{"line_number":102,"context_line":"        offset \u003d search_opts.pop(\u0027offset\u0027, None)"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_f12fc886","line":99,"range":{"start_line":99,"start_character":47,"end_line":99,"end_character":58},"in_reply_to":"5f7c97a3_6850c72d","updated":"2018-07-26 08:52:53.000000000","message":"Done","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bb89ed34c16de65175305e414dcfcc5970c823dd","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        limit \u003d search_opts.pop(\u0027limit\u0027, None)"},{"line_number":102,"context_line":"        offset \u003d search_opts.pop(\u0027offset\u0027, None)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        if share_id is None:"},{"line_number":105,"context_line":"            exc_str \u003d _(\"The share ID is required to retrieve access rules.\")"},{"line_number":106,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dexc_str)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        if \u0027metadata\u0027 in search_opts:"},{"line_number":109,"context_line":"            search_opts[\u0027metadata\u0027] \u003d ast.literal_eval("}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_d37c30ec","line":106,"range":{"start_line":104,"start_character":0,"end_line":106,"end_character":63},"updated":"2018-07-24 03:58:57.000000000","message":"same as line 90?","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"357bdab92ed8d186b62a19cb3db8bdcddfc71b3c","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        limit \u003d search_opts.pop(\u0027limit\u0027, None)"},{"line_number":102,"context_line":"        offset \u003d search_opts.pop(\u0027offset\u0027, None)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"        if share_id is None:"},{"line_number":105,"context_line":"            exc_str \u003d _(\"The share ID is required to retrieve access rules.\")"},{"line_number":106,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dexc_str)"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"        if \u0027metadata\u0027 in search_opts:"},{"line_number":109,"context_line":"            search_opts[\u0027metadata\u0027] \u003d ast.literal_eval("}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_fc16b84a","line":106,"range":{"start_line":104,"start_character":0,"end_line":106,"end_character":63},"in_reply_to":"5f7c97a3_d37c30ec","updated":"2018-07-26 08:52:53.000000000","message":"Code line 90 only check if the \u0027share_id\u0027 exist in search_opts. But it the search_opts value could be {\u0027share_id\u0027: None}, so this check if the share_id value is None.","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6bb1d7aa0e2b0c0d3c1f5b895cbc4fc0840db11b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    @wsgi.Controller.authorize"},{"line_number":47,"context_line":"    @wsgi.response(202)"},{"line_number":48,"context_line":"    def update(self, req, id, body):"},{"line_number":49,"context_line":"        \"\"\"Return data about the given share access.\"\"\""},{"line_number":50,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if not self.is_valid_body(body, \u0027access\u0027):"}],"source_content_type":"text/x-python","patch_set":22,"id":"3f79a3b5_b5f80f7e","line":49,"range":{"start_line":49,"start_character":11,"end_line":49,"end_character":17},"updated":"2018-10-11 13:09:30.000000000","message":"Update","commit_id":"7b50d837d2d9820210d339408adc67266f4ce7a4"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"f183da3b53c7a9d5ffe5c8313892f092654cc79b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    @wsgi.Controller.authorize"},{"line_number":47,"context_line":"    @wsgi.response(202)"},{"line_number":48,"context_line":"    def update(self, req, id, body):"},{"line_number":49,"context_line":"        \"\"\"Return data about the given share access.\"\"\""},{"line_number":50,"context_line":"        context \u003d req.environ[\u0027manila.context\u0027]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"        if not self.is_valid_body(body, \u0027access\u0027):"}],"source_content_type":"text/x-python","patch_set":22,"id":"3f79a3b5_631b1784","line":49,"range":{"start_line":49,"start_character":11,"end_line":49,"end_character":17},"in_reply_to":"3f79a3b5_b5f80f7e","updated":"2018-10-18 03:09:27.000000000","message":"Done","commit_id":"7b50d837d2d9820210d339408adc67266f4ce7a4"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6bb1d7aa0e2b0c0d3c1f5b895cbc4fc0840db11b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        access_data \u003d body[\u0027access\u0027]"},{"line_number":57,"context_line":"        if all(field not in access_data for field in access_data):"},{"line_number":58,"context_line":"            LOG.warning(\"The one of fields \u0027priority\u0027 is not set.\")"},{"line_number":59,"context_line":"            return webob.Response(status_int\u003dhttp_client.OK)"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"3f79a3b5_f55e8777","line":57,"range":{"start_line":57,"start_character":15,"end_line":57,"end_character":64},"updated":"2018-10-11 13:09:30.000000000","message":"you are using \"access_data\", for the loop and for the check, is this correct?  I believe you should use a pre-defined list of fields that should exist","commit_id":"7b50d837d2d9820210d339408adc67266f4ce7a4"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"f183da3b53c7a9d5ffe5c8313892f092654cc79b","unresolved":false,"context_lines":[{"line_number":54,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"        access_data \u003d body[\u0027access\u0027]"},{"line_number":57,"context_line":"        if all(field not in access_data for field in access_data):"},{"line_number":58,"context_line":"            LOG.warning(\"The one of fields \u0027priority\u0027 is not set.\")"},{"line_number":59,"context_line":"            return webob.Response(status_int\u003dhttp_client.OK)"},{"line_number":60,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"3f79a3b5_23251fc0","line":57,"range":{"start_line":57,"start_character":15,"end_line":57,"end_character":64},"in_reply_to":"3f79a3b5_f55e8777","updated":"2018-10-18 03:09:27.000000000","message":"Yeah, this is weird","commit_id":"7b50d837d2d9820210d339408adc67266f4ce7a4"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6bb1d7aa0e2b0c0d3c1f5b895cbc4fc0840db11b","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        common.validate_access_priority(access_data)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        share_access \u003d self._get_share_access(context, id)"},{"line_number":64,"context_line":"        share_access \u003d self.share_api.update_access("},{"line_number":65,"context_line":"            context, access_data.get(\u0027priority\u0027), share_access)"},{"line_number":66,"context_line":"        return self._view_builder.view(req, share_access)"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"3f79a3b5_3043ad42","line":64,"range":{"start_line":64,"start_character":38,"end_line":64,"end_character":51},"updated":"2018-10-11 13:09:30.000000000","message":"this is where it starts getting semantically confusing. If you intend to only update the priority, this should be named update_access_priority. I see in share/api.py that you are only using \"{\u0027priority\u0027: priority}\" but now we also have all the mechanisms in place to update the access_value, access-type if we want to. I think we should discuss in a weekly meeting whether we intend to be this restrictive (only the priority) or allow other fields to be update, so we can properly name those methods.","commit_id":"7b50d837d2d9820210d339408adc67266f4ce7a4"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"f183da3b53c7a9d5ffe5c8313892f092654cc79b","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        common.validate_access_priority(access_data)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        share_access \u003d self._get_share_access(context, id)"},{"line_number":64,"context_line":"        share_access \u003d self.share_api.update_access("},{"line_number":65,"context_line":"            context, access_data.get(\u0027priority\u0027), share_access)"},{"line_number":66,"context_line":"        return self._view_builder.view(req, share_access)"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"3f79a3b5_86020108","line":64,"range":{"start_line":64,"start_character":38,"end_line":64,"end_character":51},"in_reply_to":"3f79a3b5_3043ad42","updated":"2018-10-18 03:09:27.000000000","message":"I\u0027d say according to the design scope, we should strict to only update priority first, and we can do other things latter if needed.","commit_id":"7b50d837d2d9820210d339408adc67266f4ce7a4"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"1e509baa446ccf27266c1a6ffb678c2a726b9fe3","unresolved":false,"context_lines":[{"line_number":61,"context_line":"        common.validate_access_priority(access_data)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        share_access \u003d self._get_share_access(context, id)"},{"line_number":64,"context_line":"        share_access \u003d self.share_api.update_access("},{"line_number":65,"context_line":"            context, access_data.get(\u0027priority\u0027), share_access)"},{"line_number":66,"context_line":"        return self._view_builder.view(req, share_access)"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-python","patch_set":22,"id":"3f79a3b5_ed262968","line":64,"range":{"start_line":64,"start_character":38,"end_line":64,"end_character":51},"in_reply_to":"3f79a3b5_86020108","updated":"2018-10-18 14:19:28.000000000","message":"Agreed, this was discussed in the weekly meeting. We will revisit this later for another spec. \n\nhttp://eavesdrop.openstack.org/meetings/manila/2018/manila.2018-10-11-15.01.log.html#l-111","commit_id":"7b50d837d2d9820210d339408adc67266f4ce7a4"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"1cc5f30abd6a9bcb8f2aa062c38623e311f8b8bf","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        access_data \u003d body[\u0027access\u0027]"},{"line_number":58,"context_line":"        if all(field not in constants.VALID_SHARE_ACCESS_UPDATE_FIELDS"},{"line_number":59,"context_line":"               for field in access_data):"},{"line_number":60,"context_line":"            LOG.warning(\"The one of fields \u0027priority\u0027 is not set.\")"},{"line_number":61,"context_line":"            return webob.Response(status_int\u003dhttp_client.OK)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"        common.validate_access_priority(access_data)"}],"source_content_type":"text/x-python","patch_set":23,"id":"3f79a3b5_5856c860","line":60,"range":{"start_line":60,"start_character":25,"end_line":60,"end_character":65},"updated":"2018-10-22 07:16:46.000000000","message":"Please rephrase this warning message. It should be something like:\n\"Field \u0027priority\u0027 has not been set in request data\"\nmaybe?","commit_id":"80c19d9390000b51442c58ce5796a752180dfe18"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"bce432ccf7b9de4f41e704e0577a956e16ffa1be","unresolved":false,"context_lines":[{"line_number":103,"context_line":"        limit \u003d search_opts.pop(\u0027limit\u0027, None)"},{"line_number":104,"context_line":"        offset \u003d search_opts.pop(\u0027offset\u0027, None)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        if share_id is None:"},{"line_number":107,"context_line":"            exc_str \u003d _(\"The share ID is required to retrieve access rules.\")"},{"line_number":108,"context_line":"            raise webob.exc.HTTPBadRequest(explanation\u003dexc_str)"},{"line_number":109,"context_line":""}],"source_content_type":"text/x-python","patch_set":29,"id":"3f79a3b5_8d3e8b25","line":106,"updated":"2018-12-13 15:37:31.000000000","message":"This is already checked in line 92","commit_id":"74ff39e077af5d2a8ee3b5be64cda15f9124bac5"}],"manila/api/views/share_access_metadata.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bb89ed34c16de65175305e414dcfcc5970c823dd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"5f7c97a3_736d1c2e","updated":"2018-07-24 03:58:57.000000000","message":"Re-introduced by accident?","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"357bdab92ed8d186b62a19cb3db8bdcddfc71b3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"5f7c97a3_5f731e50","in_reply_to":"5f7c97a3_736d1c2e","updated":"2018-07-26 08:52:53.000000000","message":"Done","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"}],"manila/api/views/share_accesses.py":[{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"44374b7250e92647cf7d3ecdcae6e87cb3d4841a","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        access_dict[\u0027created_at\u0027] \u003d access.get(\u0027created_at\u0027)"},{"line_number":71,"context_line":"        access_dict[\u0027updated_at\u0027] \u003d access.get(\u0027updated_at\u0027)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @common.ViewBuilder.versioned_method(\"2.44\")"},{"line_number":74,"context_line":"    def add_access_priority(self, context, access_dict, access):"},{"line_number":75,"context_line":"        access_dict[\u0027priority\u0027] \u003d access.get(\u0027priority\u0027)"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_02db3421","line":73,"range":{"start_line":73,"start_character":42,"end_line":73,"end_character":46},"updated":"2018-06-05 09:50:37.000000000","message":"Isn\u0027t that supposed to be 2.45? Not familiar with that too much, but I\u0027m basing that on your other changes related to micro-versions.","commit_id":"6ffb38f3018225def57c52a76ac506383b05b951"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ce3874f0d161879c5aae35d21dd1d1f9298001d9","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        access_dict[\u0027created_at\u0027] \u003d access.get(\u0027created_at\u0027)"},{"line_number":71,"context_line":"        access_dict[\u0027updated_at\u0027] \u003d access.get(\u0027updated_at\u0027)"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    @common.ViewBuilder.versioned_method(\"2.44\")"},{"line_number":74,"context_line":"    def add_access_priority(self, context, access_dict, access):"},{"line_number":75,"context_line":"        access_dict[\u0027priority\u0027] \u003d access.get(\u0027priority\u0027)"},{"line_number":76,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_18011205","line":73,"range":{"start_line":73,"start_character":42,"end_line":73,"end_character":46},"in_reply_to":"5f7c97a3_02db3421","updated":"2018-06-08 07:38:58.000000000","message":"Done","commit_id":"6ffb38f3018225def57c52a76ac506383b05b951"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8ac00c8df3b7882a3539a6c9e92754d5364bcf4f","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @common.ViewBuilder.versioned_method(\"2.46\")"},{"line_number":85,"context_line":"    def add_access_priority(self, context, access_dict, access):"},{"line_number":86,"context_line":"        access_dict[\u0027priority\u0027] \u003d access.get(\u0027priority\u0027)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    @common.ViewBuilder.versioned_method(\"1.0\", \"2.27\")"},{"line_number":89,"context_line":"    def translate_transitional_statuses(self, context, access_dict, access):"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_48014b07","line":86,"range":{"start_line":86,"start_character":34,"end_line":86,"end_character":56},"updated":"2018-07-24 03:48:38.000000000","message":"access[\u0027priority\u0027]","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"357bdab92ed8d186b62a19cb3db8bdcddfc71b3c","unresolved":false,"context_lines":[{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    @common.ViewBuilder.versioned_method(\"2.46\")"},{"line_number":85,"context_line":"    def add_access_priority(self, context, access_dict, access):"},{"line_number":86,"context_line":"        access_dict[\u0027priority\u0027] \u003d access.get(\u0027priority\u0027)"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    @common.ViewBuilder.versioned_method(\"1.0\", \"2.27\")"},{"line_number":89,"context_line":"    def translate_transitional_statuses(self, context, access_dict, access):"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_fc8b1866","line":86,"range":{"start_line":86,"start_character":34,"end_line":86,"end_character":56},"in_reply_to":"5f7c97a3_48014b07","updated":"2018-07-26 08:52:53.000000000","message":"Done","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"}],"manila/db/api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8ac00c8df3b7882a3539a6c9e92754d5364bcf4f","unresolved":false,"context_lines":[{"line_number":434,"context_line":"                                   offset\u003d0):"},{"line_number":435,"context_line":"    \"\"\"Get all access rules for given share.\"\"\""},{"line_number":436,"context_line":"    return IMPL.share_access_get_all_for_share("},{"line_number":437,"context_line":"        context, share_id, filters, sort_key, sort_dir, limit, offset)"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"def share_access_get_all_for_instance(context, instance_id, filters\u003dNone,"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_732c3c93","line":437,"range":{"start_line":437,"start_character":36,"end_line":437,"end_character":69},"updated":"2018-07-24 03:48:38.000000000","message":"pass kwargs as kwargs","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"357bdab92ed8d186b62a19cb3db8bdcddfc71b3c","unresolved":false,"context_lines":[{"line_number":434,"context_line":"                                   offset\u003d0):"},{"line_number":435,"context_line":"    \"\"\"Get all access rules for given share.\"\"\""},{"line_number":436,"context_line":"    return IMPL.share_access_get_all_for_share("},{"line_number":437,"context_line":"        context, share_id, filters, sort_key, sort_dir, limit, offset)"},{"line_number":438,"context_line":""},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"def share_access_get_all_for_instance(context, instance_id, filters\u003dNone,"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_1c87f45d","line":437,"range":{"start_line":437,"start_character":36,"end_line":437,"end_character":69},"in_reply_to":"5f7c97a3_732c3c93","updated":"2018-07-26 08:52:53.000000000","message":"Done","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"}],"manila/db/migrations/alembic/versions/26326cf8s2d_add_access_priority.py":[{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"44374b7250e92647cf7d3ecdcae6e87cb3d4841a","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def upgrade():"},{"line_number":35,"context_line":"    op.add_column("},{"line_number":36,"context_line":"        \u0027share_access_map\u0027, sa.Column(\u0027priority\u0027, sa.Integer, default\u003d100))"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    connection \u003d op.get_bind()"},{"line_number":39,"context_line":"    share_access_map_table \u003d utils.load_table(\u0027share_access_map\u0027, connection)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_e2e958b7","line":36,"range":{"start_line":36,"start_character":70,"end_line":36,"end_character":73},"updated":"2018-06-05 09:50:37.000000000","message":"If this file was not generated automatically (not sure): the same comment as in api/common.py - please use a constant for this value (the same one).","commit_id":"6ffb38f3018225def57c52a76ac506383b05b951"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ce3874f0d161879c5aae35d21dd1d1f9298001d9","unresolved":false,"context_lines":[{"line_number":33,"context_line":""},{"line_number":34,"context_line":"def upgrade():"},{"line_number":35,"context_line":"    op.add_column("},{"line_number":36,"context_line":"        \u0027share_access_map\u0027, sa.Column(\u0027priority\u0027, sa.Integer, default\u003d100))"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    connection \u003d op.get_bind()"},{"line_number":39,"context_line":"    share_access_map_table \u003d utils.load_table(\u0027share_access_map\u0027, connection)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_f82696ba","line":36,"range":{"start_line":36,"start_character":70,"end_line":36,"end_character":73},"in_reply_to":"5f7c97a3_e2e958b7","updated":"2018-06-08 07:38:58.000000000","message":"Done","commit_id":"6ffb38f3018225def57c52a76ac506383b05b951"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"44374b7250e92647cf7d3ecdcae6e87cb3d4841a","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    share_access_map_table \u003d utils.load_table(\u0027share_access_map\u0027, connection)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    # Set the value of ``priority`` in every existing share access to 100"},{"line_number":42,"context_line":"    op.execute(share_access_map_table.update().values({\u0027priority\u0027: 100, }))"},{"line_number":43,"context_line":"    op.alter_column(\u0027share_access_map\u0027,"},{"line_number":44,"context_line":"                    \u0027priority\u0027,"},{"line_number":45,"context_line":"                    existing_type\u003dsa.Integer,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_0204947d","line":42,"range":{"start_line":42,"start_character":67,"end_line":42,"end_character":70},"updated":"2018-06-05 09:50:37.000000000","message":"Same comment :)","commit_id":"6ffb38f3018225def57c52a76ac506383b05b951"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ce3874f0d161879c5aae35d21dd1d1f9298001d9","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    share_access_map_table \u003d utils.load_table(\u0027share_access_map\u0027, connection)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    # Set the value of ``priority`` in every existing share access to 100"},{"line_number":42,"context_line":"    op.execute(share_access_map_table.update().values({\u0027priority\u0027: 100, }))"},{"line_number":43,"context_line":"    op.alter_column(\u0027share_access_map\u0027,"},{"line_number":44,"context_line":"                    \u0027priority\u0027,"},{"line_number":45,"context_line":"                    existing_type\u003dsa.Integer,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_b8201e9d","line":42,"range":{"start_line":42,"start_character":67,"end_line":42,"end_character":70},"in_reply_to":"5f7c97a3_0204947d","updated":"2018-06-08 07:38:58.000000000","message":"Done","commit_id":"6ffb38f3018225def57c52a76ac506383b05b951"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"f6104e058d8a0536f3892f74996617a001cd8236","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Revision ID: 26326cf8s2d"},{"line_number":19,"context_line":"Revises: 0274d20c560f"},{"line_number":20,"context_line":"Create Date: 2014-12-19 05:34:06.790159"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"\"\"\""},{"line_number":23,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_305afaf1","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":39},"updated":"2018-07-18 22:13:58.000000000","message":"?","commit_id":"246f491fd063cb0d01b3ef17a12b0a3cb35cc7d6"}],"manila/db/sqlalchemy/api.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"961436106a9d25c43f53a81b5142bb322773ca53","unresolved":false,"context_lines":[{"line_number":2070,"context_line":"    filters \u003d filters or {}"},{"line_number":2071,"context_line":"    session \u003d session or get_session()"},{"line_number":2072,"context_line":"    sort_key \u003d sort_key or \u0027priority\u0027"},{"line_number":2073,"context_line":"    sort_dir \u003d sort_dir or \u0027desc\u0027"},{"line_number":2074,"context_line":""},{"line_number":2075,"context_line":"    filters.update({\u0027share_id\u0027: share_id})"},{"line_number":2076,"context_line":"    query \u003d (_share_access_get_query("}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_7f0435c6","line":2073,"range":{"start_line":2073,"start_character":28,"end_line":2073,"end_character":32},"updated":"2018-06-27 00:20:28.000000000","message":"\u0027asc\u0027","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"10e19ac862f34e8180c480473faa83af8e2d5200","unresolved":false,"context_lines":[{"line_number":2070,"context_line":"    filters \u003d filters or {}"},{"line_number":2071,"context_line":"    session \u003d session or get_session()"},{"line_number":2072,"context_line":"    sort_key \u003d sort_key or \u0027priority\u0027"},{"line_number":2073,"context_line":"    sort_dir \u003d sort_dir or \u0027desc\u0027"},{"line_number":2074,"context_line":""},{"line_number":2075,"context_line":"    filters.update({\u0027share_id\u0027: share_id})"},{"line_number":2076,"context_line":"    query \u003d (_share_access_get_query("}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_20df5167","line":2073,"range":{"start_line":2073,"start_character":28,"end_line":2073,"end_character":32},"in_reply_to":"5f7c97a3_7f0435c6","updated":"2018-06-30 03:29:44.000000000","message":"Done","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"961436106a9d25c43f53a81b5142bb322773ca53","unresolved":false,"context_lines":[{"line_number":2081,"context_line":"    try:"},{"line_number":2082,"context_line":"        attr \u003d getattr(models.ShareAccessMapping, sort_key)"},{"line_number":2083,"context_line":"    except AttributeError:"},{"line_number":2084,"context_line":"        msg \u003d _(\"Wrong sorting key provided - \u0027%s\u0027.\") % sort_key"},{"line_number":2085,"context_line":"        raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":2086,"context_line":"    if sort_dir.lower() \u003d\u003d \u0027desc\u0027:"},{"line_number":2087,"context_line":"        query \u003d query.order_by(attr.desc())"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_3f0a3dd0","line":2084,"range":{"start_line":2084,"start_character":17,"end_line":2084,"end_character":30},"updated":"2018-06-27 00:20:28.000000000","message":"Invalid sort","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"10e19ac862f34e8180c480473faa83af8e2d5200","unresolved":false,"context_lines":[{"line_number":2081,"context_line":"    try:"},{"line_number":2082,"context_line":"        attr \u003d getattr(models.ShareAccessMapping, sort_key)"},{"line_number":2083,"context_line":"    except AttributeError:"},{"line_number":2084,"context_line":"        msg \u003d _(\"Wrong sorting key provided - \u0027%s\u0027.\") % sort_key"},{"line_number":2085,"context_line":"        raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":2086,"context_line":"    if sort_dir.lower() \u003d\u003d \u0027desc\u0027:"},{"line_number":2087,"context_line":"        query \u003d query.order_by(attr.desc())"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_40c12d81","line":2084,"range":{"start_line":2084,"start_character":17,"end_line":2084,"end_character":30},"in_reply_to":"5f7c97a3_3f0a3dd0","updated":"2018-06-30 03:29:44.000000000","message":"Done","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b7455c50ceb77a2c57dbc373fd32f5780db082f8","unresolved":false,"context_lines":[{"line_number":2128,"context_line":"                                   offset\u003d0, session\u003dNone):"},{"line_number":2129,"context_line":"    filters \u003d filters or {}"},{"line_number":2130,"context_line":"    session \u003d session or get_session()"},{"line_number":2131,"context_line":"    sort_key \u003d sort_key or \u0027share_id\u0027"},{"line_number":2132,"context_line":"    sort_dir \u003d sort_dir or \u0027asc\u0027"},{"line_number":2133,"context_line":""},{"line_number":2134,"context_line":"    query \u003d (_share_access_get_query("}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_164cdf3d","line":2131,"range":{"start_line":2131,"start_character":28,"end_line":2131,"end_character":36},"updated":"2018-07-11 21:37:00.000000000","message":"? the share_id will always be the same, shouldn\u0027t we order on \u0027priority\u0027 by default","commit_id":"519d75dda306333dac07f875aa7079537162f011"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"62d95ba6ece96ca883e10f61f8108db0c28d6296","unresolved":false,"context_lines":[{"line_number":2128,"context_line":"                                   offset\u003d0, session\u003dNone):"},{"line_number":2129,"context_line":"    filters \u003d filters or {}"},{"line_number":2130,"context_line":"    session \u003d session or get_session()"},{"line_number":2131,"context_line":"    sort_key \u003d sort_key or \u0027share_id\u0027"},{"line_number":2132,"context_line":"    sort_dir \u003d sort_dir or \u0027asc\u0027"},{"line_number":2133,"context_line":""},{"line_number":2134,"context_line":"    query \u003d (_share_access_get_query("}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_42e12c2b","line":2131,"range":{"start_line":2131,"start_character":28,"end_line":2131,"end_character":36},"in_reply_to":"5f7c97a3_164cdf3d","updated":"2018-07-12 05:16:09.000000000","message":"Because the \u0027share_id\u0027 is the original key for order, the \u0027priority\u0027 is added at version 2.45. So we could just keep the original sort key in db api. We don\u0027t have microversion in db api, if we set default value to \u0027priority\u0027, the db test for prior db version will get error when the test use \"share_access_get_all_for_share\" function, because it doesn\u0027t have \u0027priority\u0027 in prior db version.","commit_id":"519d75dda306333dac07f875aa7079537162f011"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"1e4efe95b837b1ef06e8a4f8325b82cdb5b7c056","unresolved":false,"context_lines":[{"line_number":2128,"context_line":"                                   offset\u003d0, session\u003dNone):"},{"line_number":2129,"context_line":"    filters \u003d filters or {}"},{"line_number":2130,"context_line":"    session \u003d session or get_session()"},{"line_number":2131,"context_line":"    sort_key \u003d sort_key or \u0027share_id\u0027"},{"line_number":2132,"context_line":"    sort_dir \u003d sort_dir or \u0027asc\u0027"},{"line_number":2133,"context_line":""},{"line_number":2134,"context_line":"    query \u003d (_share_access_get_query("}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_ed138964","line":2131,"range":{"start_line":2131,"start_character":28,"end_line":2131,"end_character":36},"in_reply_to":"5f7c97a3_42e12c2b","updated":"2018-07-12 05:17:50.000000000","message":"Sure, but share_id will be the same for all access rules of a share, sorting on that key should do nothing deterministic..","commit_id":"519d75dda306333dac07f875aa7079537162f011"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"97eddbe9220c6aa113c1ea8271147b24b0332266","unresolved":false,"context_lines":[{"line_number":2128,"context_line":"                                   offset\u003d0, session\u003dNone):"},{"line_number":2129,"context_line":"    filters \u003d filters or {}"},{"line_number":2130,"context_line":"    session \u003d session or get_session()"},{"line_number":2131,"context_line":"    sort_key \u003d sort_key or \u0027share_id\u0027"},{"line_number":2132,"context_line":"    sort_dir \u003d sort_dir or \u0027asc\u0027"},{"line_number":2133,"context_line":""},{"line_number":2134,"context_line":"    query \u003d (_share_access_get_query("}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_e8837702","line":2131,"range":{"start_line":2131,"start_character":28,"end_line":2131,"end_character":36},"in_reply_to":"5f7c97a3_ed138964","updated":"2018-07-12 06:04:50.000000000","message":"The sort_key value is set to original value \"share_id\", because the default value just use to decide witch attr(attr \u003d getattr(models.ShareAccessMapping, sort_key)) to sort. \nSo even if the same for all access rules of share, I just set default sort_key to \"share_id\" in the beginning.\nIs it OK? Should I set default value in code line 2146 or is there a better way to solve it?\n\n```\nif sort_dir.lower() \u003d\u003d \u0027desc\u0027:\n        query \u003d query.order_by(attr.desc())\n    elif sort_dir.lower() \u003d\u003d \u0027asc\u0027:\n        query \u003d query.order_by(attr.asc())\n```","commit_id":"519d75dda306333dac07f875aa7079537162f011"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b7455c50ceb77a2c57dbc373fd32f5780db082f8","unresolved":false,"context_lines":[{"line_number":2145,"context_line":"    try:"},{"line_number":2146,"context_line":"        attr \u003d getattr(models.ShareAccessMapping, sort_key)"},{"line_number":2147,"context_line":"    except AttributeError:"},{"line_number":2148,"context_line":"        msg \u003d _(\"Wrong sorting key provided - \u0027%s\u0027.\") % sort_key"},{"line_number":2149,"context_line":"        raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":2150,"context_line":"    if sort_dir.lower() \u003d\u003d \u0027desc\u0027:"},{"line_number":2151,"context_line":"        query \u003d query.order_by(attr.desc())"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_765433c7","line":2148,"range":{"start_line":2148,"start_character":17,"end_line":2148,"end_character":30},"updated":"2018-07-11 21:37:00.000000000","message":"Invalid sort","commit_id":"519d75dda306333dac07f875aa7079537162f011"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"62d95ba6ece96ca883e10f61f8108db0c28d6296","unresolved":false,"context_lines":[{"line_number":2145,"context_line":"    try:"},{"line_number":2146,"context_line":"        attr \u003d getattr(models.ShareAccessMapping, sort_key)"},{"line_number":2147,"context_line":"    except AttributeError:"},{"line_number":2148,"context_line":"        msg \u003d _(\"Wrong sorting key provided - \u0027%s\u0027.\") % sort_key"},{"line_number":2149,"context_line":"        raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":2150,"context_line":"    if sort_dir.lower() \u003d\u003d \u0027desc\u0027:"},{"line_number":2151,"context_line":"        query \u003d query.order_by(attr.desc())"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_5f26e7cd","line":2148,"range":{"start_line":2148,"start_character":17,"end_line":2148,"end_character":30},"in_reply_to":"5f7c97a3_765433c7","updated":"2018-07-12 05:16:09.000000000","message":"Done","commit_id":"519d75dda306333dac07f875aa7079537162f011"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8ac00c8df3b7882a3539a6c9e92754d5364bcf4f","unresolved":false,"context_lines":[{"line_number":2125,"context_line":"                                   sort_key\u003dNone, sort_dir\u003dNone, limit\u003dNone,"},{"line_number":2126,"context_line":"                                   offset\u003d0, session\u003dNone):"},{"line_number":2127,"context_line":"    session \u003d session or get_session()"},{"line_number":2128,"context_line":"    sort_key \u003d sort_key or \u0027share_id\u0027"},{"line_number":2129,"context_line":"    sort_dir \u003d sort_dir or \u0027asc\u0027"},{"line_number":2130,"context_line":""},{"line_number":2131,"context_line":"    filters \u003d copy.deepcopy(filters) if filters else {}"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_b33734dc","line":2128,"range":{"start_line":2128,"start_character":15,"end_line":2128,"end_character":37},"updated":"2018-07-24 03:48:38.000000000","message":"not necessary","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"357bdab92ed8d186b62a19cb3db8bdcddfc71b3c","unresolved":false,"context_lines":[{"line_number":2125,"context_line":"                                   sort_key\u003dNone, sort_dir\u003dNone, limit\u003dNone,"},{"line_number":2126,"context_line":"                                   offset\u003d0, session\u003dNone):"},{"line_number":2127,"context_line":"    session \u003d session or get_session()"},{"line_number":2128,"context_line":"    sort_key \u003d sort_key or \u0027share_id\u0027"},{"line_number":2129,"context_line":"    sort_dir \u003d sort_dir or \u0027asc\u0027"},{"line_number":2130,"context_line":""},{"line_number":2131,"context_line":"    filters \u003d copy.deepcopy(filters) if filters else {}"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_ff71ca46","line":2128,"range":{"start_line":2128,"start_character":15,"end_line":2128,"end_character":37},"in_reply_to":"5f7c97a3_b33734dc","updated":"2018-07-26 08:52:53.000000000","message":"Done","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8ac00c8df3b7882a3539a6c9e92754d5364bcf4f","unresolved":false,"context_lines":[{"line_number":2144,"context_line":"                    share_access_rules_metadata.any(key\u003dk, value\u003dv)))"},{"line_number":2145,"context_line":""},{"line_number":2146,"context_line":"    # Apply sorting"},{"line_number":2147,"context_line":"    try:"},{"line_number":2148,"context_line":"        attr \u003d getattr(models.ShareAccessMapping, sort_key)"},{"line_number":2149,"context_line":"    except AttributeError:"},{"line_number":2150,"context_line":"        msg \u003d _(\"Invalid sort key provided - \u0027%s\u0027.\") % sort_key"},{"line_number":2151,"context_line":"        raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":2152,"context_line":"    if sort_dir.lower() \u003d\u003d \u0027desc\u0027:"},{"line_number":2153,"context_line":"        query \u003d query.order_by(attr.desc())"},{"line_number":2154,"context_line":"    elif sort_dir.lower() \u003d\u003d \u0027asc\u0027:"},{"line_number":2155,"context_line":"        query \u003d query.order_by(attr.asc())"},{"line_number":2156,"context_line":"    else:"},{"line_number":2157,"context_line":"        msg \u003d _(\"Invalid sort data provided: sort key is \u0027%(sort_key)s\u0027 \""},{"line_number":2158,"context_line":"                \"and sort direction is \u0027%(sort_dir)s\u0027.\") % {"},{"line_number":2159,"context_line":"                    \"sort_key\": sort_key, \"sort_dir\": sort_dir}"},{"line_number":2160,"context_line":"        raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":2161,"context_line":""},{"line_number":2162,"context_line":"    query \u003d query.limit(limit).offset(offset) if limit else query"},{"line_number":2163,"context_line":"    return query.all()"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_137068a7","line":2160,"range":{"start_line":2147,"start_character":0,"end_line":2160,"end_character":48},"updated":"2018-07-24 03:48:38.000000000","message":"if sort_key is not None:\n  ...","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bb89ed34c16de65175305e414dcfcc5970c823dd","unresolved":false,"context_lines":[{"line_number":2144,"context_line":"                    share_access_rules_metadata.any(key\u003dk, value\u003dv)))"},{"line_number":2145,"context_line":""},{"line_number":2146,"context_line":"    # Apply sorting"},{"line_number":2147,"context_line":"    try:"},{"line_number":2148,"context_line":"        attr \u003d getattr(models.ShareAccessMapping, sort_key)"},{"line_number":2149,"context_line":"    except AttributeError:"},{"line_number":2150,"context_line":"        msg \u003d _(\"Invalid sort key provided - \u0027%s\u0027.\") % sort_key"},{"line_number":2151,"context_line":"        raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":2152,"context_line":"    if sort_dir.lower() \u003d\u003d \u0027desc\u0027:"},{"line_number":2153,"context_line":"        query \u003d query.order_by(attr.desc())"},{"line_number":2154,"context_line":"    elif sort_dir.lower() \u003d\u003d \u0027asc\u0027:"},{"line_number":2155,"context_line":"        query \u003d query.order_by(attr.asc())"},{"line_number":2156,"context_line":"    else:"},{"line_number":2157,"context_line":"        msg \u003d _(\"Invalid sort data provided: sort key is \u0027%(sort_key)s\u0027 \""},{"line_number":2158,"context_line":"                \"and sort direction is \u0027%(sort_dir)s\u0027.\") % {"},{"line_number":2159,"context_line":"                    \"sort_key\": sort_key, \"sort_dir\": sort_dir}"},{"line_number":2160,"context_line":"        raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":2161,"context_line":""},{"line_number":2162,"context_line":"    query \u003d query.limit(limit).offset(offset) if limit else query"},{"line_number":2163,"context_line":"    return query.all()"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_f35a8c80","line":2160,"range":{"start_line":2147,"start_character":0,"end_line":2160,"end_character":48},"in_reply_to":"5f7c97a3_137068a7","updated":"2018-07-24 03:58:57.000000000","message":"Also: This section has not been unit-tested","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"357bdab92ed8d186b62a19cb3db8bdcddfc71b3c","unresolved":false,"context_lines":[{"line_number":2144,"context_line":"                    share_access_rules_metadata.any(key\u003dk, value\u003dv)))"},{"line_number":2145,"context_line":""},{"line_number":2146,"context_line":"    # Apply sorting"},{"line_number":2147,"context_line":"    try:"},{"line_number":2148,"context_line":"        attr \u003d getattr(models.ShareAccessMapping, sort_key)"},{"line_number":2149,"context_line":"    except AttributeError:"},{"line_number":2150,"context_line":"        msg \u003d _(\"Invalid sort key provided - \u0027%s\u0027.\") % sort_key"},{"line_number":2151,"context_line":"        raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":2152,"context_line":"    if sort_dir.lower() \u003d\u003d \u0027desc\u0027:"},{"line_number":2153,"context_line":"        query \u003d query.order_by(attr.desc())"},{"line_number":2154,"context_line":"    elif sort_dir.lower() \u003d\u003d \u0027asc\u0027:"},{"line_number":2155,"context_line":"        query \u003d query.order_by(attr.asc())"},{"line_number":2156,"context_line":"    else:"},{"line_number":2157,"context_line":"        msg \u003d _(\"Invalid sort data provided: sort key is \u0027%(sort_key)s\u0027 \""},{"line_number":2158,"context_line":"                \"and sort direction is \u0027%(sort_dir)s\u0027.\") % {"},{"line_number":2159,"context_line":"                    \"sort_key\": sort_key, \"sort_dir\": sort_dir}"},{"line_number":2160,"context_line":"        raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":2161,"context_line":""},{"line_number":2162,"context_line":"    query \u003d query.limit(limit).offset(offset) if limit else query"},{"line_number":2163,"context_line":"    return query.all()"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_1f6da666","line":2160,"range":{"start_line":2147,"start_character":0,"end_line":2160,"end_character":48},"in_reply_to":"5f7c97a3_137068a7","updated":"2018-07-26 08:52:53.000000000","message":"Done","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"357bdab92ed8d186b62a19cb3db8bdcddfc71b3c","unresolved":false,"context_lines":[{"line_number":2144,"context_line":"                    share_access_rules_metadata.any(key\u003dk, value\u003dv)))"},{"line_number":2145,"context_line":""},{"line_number":2146,"context_line":"    # Apply sorting"},{"line_number":2147,"context_line":"    try:"},{"line_number":2148,"context_line":"        attr \u003d getattr(models.ShareAccessMapping, sort_key)"},{"line_number":2149,"context_line":"    except AttributeError:"},{"line_number":2150,"context_line":"        msg \u003d _(\"Invalid sort key provided - \u0027%s\u0027.\") % sort_key"},{"line_number":2151,"context_line":"        raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":2152,"context_line":"    if sort_dir.lower() \u003d\u003d \u0027desc\u0027:"},{"line_number":2153,"context_line":"        query \u003d query.order_by(attr.desc())"},{"line_number":2154,"context_line":"    elif sort_dir.lower() \u003d\u003d \u0027asc\u0027:"},{"line_number":2155,"context_line":"        query \u003d query.order_by(attr.asc())"},{"line_number":2156,"context_line":"    else:"},{"line_number":2157,"context_line":"        msg \u003d _(\"Invalid sort data provided: sort key is \u0027%(sort_key)s\u0027 \""},{"line_number":2158,"context_line":"                \"and sort direction is \u0027%(sort_dir)s\u0027.\") % {"},{"line_number":2159,"context_line":"                    \"sort_key\": sort_key, \"sort_dir\": sort_dir}"},{"line_number":2160,"context_line":"        raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":2161,"context_line":""},{"line_number":2162,"context_line":"    query \u003d query.limit(limit).offset(offset) if limit else query"},{"line_number":2163,"context_line":"    return query.all()"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_1a71340e","line":2160,"range":{"start_line":2147,"start_character":0,"end_line":2160,"end_character":48},"in_reply_to":"5f7c97a3_f35a8c80","updated":"2018-07-26 08:52:53.000000000","message":"Done","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bb89ed34c16de65175305e414dcfcc5970c823dd","unresolved":false,"context_lines":[{"line_number":2317,"context_line":"        return access"},{"line_number":2318,"context_line":""},{"line_number":2319,"context_line":""},{"line_number":2320,"context_line":"@require_context"},{"line_number":2321,"context_line":"def share_access_update(context, access_id, updates):"},{"line_number":2322,"context_line":"    session \u003d get_session()"},{"line_number":2323,"context_line":""},{"line_number":2324,"context_line":"    with session.begin():"},{"line_number":2325,"context_line":"        share_access \u003d _share_access_get_query("},{"line_number":2326,"context_line":"            context, session, {\u0027id\u0027: access_id}).first()"},{"line_number":2327,"context_line":"        share_access.update(updates)"},{"line_number":2328,"context_line":"        share_access.save(session\u003dsession)"},{"line_number":2329,"context_line":""},{"line_number":2330,"context_line":"        return share_access"},{"line_number":2331,"context_line":""},{"line_number":2332,"context_line":""},{"line_number":2333,"context_line":"###################"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_f3cfec25","line":2330,"range":{"start_line":2320,"start_character":0,"end_line":2330,"end_character":27},"updated":"2018-07-24 03:58:57.000000000","message":"not unit-tested","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"357bdab92ed8d186b62a19cb3db8bdcddfc71b3c","unresolved":false,"context_lines":[{"line_number":2317,"context_line":"        return access"},{"line_number":2318,"context_line":""},{"line_number":2319,"context_line":""},{"line_number":2320,"context_line":"@require_context"},{"line_number":2321,"context_line":"def share_access_update(context, access_id, updates):"},{"line_number":2322,"context_line":"    session \u003d get_session()"},{"line_number":2323,"context_line":""},{"line_number":2324,"context_line":"    with session.begin():"},{"line_number":2325,"context_line":"        share_access \u003d _share_access_get_query("},{"line_number":2326,"context_line":"            context, session, {\u0027id\u0027: access_id}).first()"},{"line_number":2327,"context_line":"        share_access.update(updates)"},{"line_number":2328,"context_line":"        share_access.save(session\u003dsession)"},{"line_number":2329,"context_line":""},{"line_number":2330,"context_line":"        return share_access"},{"line_number":2331,"context_line":""},{"line_number":2332,"context_line":""},{"line_number":2333,"context_line":"###################"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_8129469d","line":2330,"range":{"start_line":2320,"start_character":0,"end_line":2330,"end_character":27},"in_reply_to":"5f7c97a3_f3cfec25","updated":"2018-07-26 08:52:53.000000000","message":"Done","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"ed06fd0a360bcd9e2a4f28c7888d79ff06fc9d53","unresolved":false,"context_lines":[{"line_number":2142,"context_line":"                or_(models.ShareAccessMapping."},{"line_number":2143,"context_line":"                    share_access_rules_metadata.any(key\u003dk, value\u003dv)))"},{"line_number":2144,"context_line":""},{"line_number":2145,"context_line":"    # Apply sorting"},{"line_number":2146,"context_line":"    if sort_key is not None:"},{"line_number":2147,"context_line":"        try:"},{"line_number":2148,"context_line":"            attr \u003d getattr(models.ShareAccessMapping, sort_key)"},{"line_number":2149,"context_line":"        except AttributeError:"}],"source_content_type":"text/x-python","patch_set":20,"id":"5f7c97a3_10557ec2","line":2146,"range":{"start_line":2145,"start_character":4,"end_line":2146,"end_character":28},"updated":"2018-07-26 07:07:49.000000000","message":"IMHO maybe it\u0027s better to handle the \"simpler\" case where sort_key IS None, and then return query.all(), otherwise (no else required) handle everything that\u0027s inside the if. I think it will be somewhat easier to read and maintain. What I mean:\nif sort_key is None:\n    query \u003d ...\n    return query.all()\n\ntry:\n    ....\n.\n.\n.\nquery \u003d ...\nreturn query.all()","commit_id":"c5949a350cddc800acfd615331461d5af40c4d43"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"357bdab92ed8d186b62a19cb3db8bdcddfc71b3c","unresolved":false,"context_lines":[{"line_number":2142,"context_line":"                or_(models.ShareAccessMapping."},{"line_number":2143,"context_line":"                    share_access_rules_metadata.any(key\u003dk, value\u003dv)))"},{"line_number":2144,"context_line":""},{"line_number":2145,"context_line":"    # Apply sorting"},{"line_number":2146,"context_line":"    if sort_key is not None:"},{"line_number":2147,"context_line":"        try:"},{"line_number":2148,"context_line":"            attr \u003d getattr(models.ShareAccessMapping, sort_key)"},{"line_number":2149,"context_line":"        except AttributeError:"}],"source_content_type":"text/x-python","patch_set":20,"id":"5f7c97a3_76294aef","line":2146,"range":{"start_line":2145,"start_character":4,"end_line":2146,"end_character":28},"in_reply_to":"5f7c97a3_10557ec2","updated":"2018-07-26 08:52:53.000000000","message":"Done","commit_id":"c5949a350cddc800acfd615331461d5af40c4d43"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6bb1d7aa0e2b0c0d3c1f5b895cbc4fc0840db11b","unresolved":false,"context_lines":[{"line_number":2130,"context_line":"    filters \u003d copy.deepcopy(filters) if filters else {}"},{"line_number":2131,"context_line":"    filters.update({\u0027share_id\u0027: share_id})"},{"line_number":2132,"context_line":""},{"line_number":2133,"context_line":"    legal_filter_keys \u003d (\u0027share_id\u0027, \u0027priority\u0027)"},{"line_number":2134,"context_line":"    legal_filters \u003d ("},{"line_number":2135,"context_line":"        {key: filters.get(key) for key in legal_filter_keys if key in filters})"},{"line_number":2136,"context_line":"    query \u003d (_share_access_get_query(context, session, legal_filters).filter("}],"source_content_type":"text/x-python","patch_set":22,"id":"3f79a3b5_7047e51f","line":2133,"range":{"start_line":2133,"start_character":37,"end_line":2133,"end_character":48},"updated":"2018-10-11 13:09:30.000000000","message":"why are we filtering only based on priority? I don\u0027t see much value on this","commit_id":"7b50d837d2d9820210d339408adc67266f4ce7a4"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"f183da3b53c7a9d5ffe5c8313892f092654cc79b","unresolved":false,"context_lines":[{"line_number":2130,"context_line":"    filters \u003d copy.deepcopy(filters) if filters else {}"},{"line_number":2131,"context_line":"    filters.update({\u0027share_id\u0027: share_id})"},{"line_number":2132,"context_line":""},{"line_number":2133,"context_line":"    legal_filter_keys \u003d (\u0027share_id\u0027, \u0027priority\u0027)"},{"line_number":2134,"context_line":"    legal_filters \u003d ("},{"line_number":2135,"context_line":"        {key: filters.get(key) for key in legal_filter_keys if key in filters})"},{"line_number":2136,"context_line":"    query \u003d (_share_access_get_query(context, session, legal_filters).filter("}],"source_content_type":"text/x-python","patch_set":22,"id":"3f79a3b5_c646b957","line":2133,"range":{"start_line":2133,"start_character":37,"end_line":2133,"end_character":48},"in_reply_to":"3f79a3b5_7047e51f","updated":"2018-10-18 03:09:27.000000000","message":"what do you mean by \"only based on priority\"? share_id will always be in the filters, see line 2131","commit_id":"7b50d837d2d9820210d339408adc67266f4ce7a4"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"1e509baa446ccf27266c1a6ffb678c2a726b9fe3","unresolved":false,"context_lines":[{"line_number":2130,"context_line":"    filters \u003d copy.deepcopy(filters) if filters else {}"},{"line_number":2131,"context_line":"    filters.update({\u0027share_id\u0027: share_id})"},{"line_number":2132,"context_line":""},{"line_number":2133,"context_line":"    legal_filter_keys \u003d (\u0027share_id\u0027, \u0027priority\u0027)"},{"line_number":2134,"context_line":"    legal_filters \u003d ("},{"line_number":2135,"context_line":"        {key: filters.get(key) for key in legal_filter_keys if key in filters})"},{"line_number":2136,"context_line":"    query \u003d (_share_access_get_query(context, session, legal_filters).filter("}],"source_content_type":"text/x-python","patch_set":22,"id":"3f79a3b5_eddb894b","line":2133,"range":{"start_line":2133,"start_character":37,"end_line":2133,"end_character":48},"in_reply_to":"3f79a3b5_c646b957","updated":"2018-10-18 14:19:28.000000000","message":"We could filter by other fields as well. We discussed this in a weekly meeting and the atendees think it is a good idea if it is not a lot of additional work. See http://eavesdrop.openstack.org/meetings/manila/2018/manila.2018-10-11-15.01.log.html#l-145\n\nA user could filter by access rule value, or by access_type, or by access level.","commit_id":"7b50d837d2d9820210d339408adc67266f4ce7a4"}],"manila/db/sqlalchemy/models.py":[{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"44374b7250e92647cf7d3ecdcae6e87cb3d4841a","unresolved":false,"context_lines":[{"line_number":552,"context_line":"    access_type \u003d Column(String(255))"},{"line_number":553,"context_line":"    access_to \u003d Column(String(255))"},{"line_number":554,"context_line":"    access_key \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":555,"context_line":"    priority \u003d Column(Integer, nullable\u003dFalse, default\u003d100)"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"    access_level \u003d Column(Enum(*constants.ACCESS_LEVELS),"},{"line_number":558,"context_line":"                          default\u003dconstants.ACCESS_LEVEL_RW)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_0229f4f0","line":555,"range":{"start_line":555,"start_character":55,"end_line":555,"end_character":58},"updated":"2018-06-05 09:50:37.000000000","message":"Same comment about the constant.","commit_id":"6ffb38f3018225def57c52a76ac506383b05b951"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ce3874f0d161879c5aae35d21dd1d1f9298001d9","unresolved":false,"context_lines":[{"line_number":552,"context_line":"    access_type \u003d Column(String(255))"},{"line_number":553,"context_line":"    access_to \u003d Column(String(255))"},{"line_number":554,"context_line":"    access_key \u003d Column(String(255), nullable\u003dTrue)"},{"line_number":555,"context_line":"    priority \u003d Column(Integer, nullable\u003dFalse, default\u003d100)"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"    access_level \u003d Column(Enum(*constants.ACCESS_LEVELS),"},{"line_number":558,"context_line":"                          default\u003dconstants.ACCESS_LEVEL_RW)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_d8239aa6","line":555,"range":{"start_line":555,"start_character":55,"end_line":555,"end_character":58},"in_reply_to":"5f7c97a3_0229f4f0","updated":"2018-06-08 07:38:58.000000000","message":"Done","commit_id":"6ffb38f3018225def57c52a76ac506383b05b951"}],"manila/share/access.py":[{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"44374b7250e92647cf7d3ecdcae6e87cb3d4841a","unresolved":false,"context_lines":[{"line_number":372,"context_line":"                                           share_server):"},{"line_number":373,"context_line":"        driver_rule_updates \u003d {}"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        access_rules_to_be_on_share \u003d sorted("},{"line_number":376,"context_line":"            access_rules_to_be_on_share, key\u003dlambda k: k[\u0027priority\u0027])"},{"line_number":377,"context_line":"        add_rules \u003d sorted(add_rules, key\u003dlambda k: k[\u0027priority\u0027])"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        share_protocol \u003d share_instance[\u0027share_proto\u0027].lower()"},{"line_number":380,"context_line":"        if (not self.driver.ipv6_implemented and"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_a2228000","line":377,"range":{"start_line":375,"start_character":8,"end_line":377,"end_character":66},"updated":"2018-06-05 09:50:37.000000000","message":"Try to avoid lambdas. operator.itemgetter is a neat solution for this case:\nhttps://docs.python.org/2/library/operator.html#operator.itemgetter\n\n(operator.itemgetter(\u0027priority\u0027) simply replaces the lambda expression).","commit_id":"6ffb38f3018225def57c52a76ac506383b05b951"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ce3874f0d161879c5aae35d21dd1d1f9298001d9","unresolved":false,"context_lines":[{"line_number":372,"context_line":"                                           share_server):"},{"line_number":373,"context_line":"        driver_rule_updates \u003d {}"},{"line_number":374,"context_line":""},{"line_number":375,"context_line":"        access_rules_to_be_on_share \u003d sorted("},{"line_number":376,"context_line":"            access_rules_to_be_on_share, key\u003dlambda k: k[\u0027priority\u0027])"},{"line_number":377,"context_line":"        add_rules \u003d sorted(add_rules, key\u003dlambda k: k[\u0027priority\u0027])"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        share_protocol \u003d share_instance[\u0027share_proto\u0027].lower()"},{"line_number":380,"context_line":"        if (not self.driver.ipv6_implemented and"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_98668255","line":377,"range":{"start_line":375,"start_character":8,"end_line":377,"end_character":66},"in_reply_to":"5f7c97a3_a2228000","updated":"2018-06-08 07:38:58.000000000","message":"Done","commit_id":"6ffb38f3018225def57c52a76ac506383b05b951"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8ac00c8df3b7882a3539a6c9e92754d5364bcf4f","unresolved":false,"context_lines":[{"line_number":259,"context_line":"            self.get_and_update_share_instance_access_rules("},{"line_number":260,"context_line":"                context, updates\u003dupdates, share_instance_id\u003dshare_instance_id)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        if update_all_rules:"},{"line_number":263,"context_line":"            updates \u003d {"},{"line_number":264,"context_line":"                \u0027state\u0027: constants.ACCESS_STATE_QUEUED_TO_APPLY,"},{"line_number":265,"context_line":"            }"},{"line_number":266,"context_line":"            self.get_and_update_share_instance_access_rules("},{"line_number":267,"context_line":"                context, updates\u003dupdates, share_instance_id\u003dshare_instance_id)"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        # Is there a sync in progress? If yes, ignore the incoming request."},{"line_number":270,"context_line":"        rule_filter \u003d {"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_7312fcff","line":267,"range":{"start_line":262,"start_character":0,"end_line":267,"end_character":78},"updated":"2018-07-24 03:48:38.000000000","message":"This isn\u0027t safe. You\u0027re forcing a state change without checking if there are any access rules being applied at the moment;\n\n  \n\nThis means, if there are access rule operations in-flight, you wouldn\u0027t care, you\u0027d cause the driver to pick up new rules too - this is the sort of thing we avoided by refactoring the access rules interface.\n\n \n\nRe-applying rules isn\u0027t the same as deleting all existing rules (which the code above forces) - you should leave the \"applying\" rules alone, and you shouldn\u0027t be setting \"denying\" rules to \"queued_to_apply\" - that will just cause the driver to reapply the rules!","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"357bdab92ed8d186b62a19cb3db8bdcddfc71b3c","unresolved":false,"context_lines":[{"line_number":259,"context_line":"            self.get_and_update_share_instance_access_rules("},{"line_number":260,"context_line":"                context, updates\u003dupdates, share_instance_id\u003dshare_instance_id)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        if update_all_rules:"},{"line_number":263,"context_line":"            updates \u003d {"},{"line_number":264,"context_line":"                \u0027state\u0027: constants.ACCESS_STATE_QUEUED_TO_APPLY,"},{"line_number":265,"context_line":"            }"},{"line_number":266,"context_line":"            self.get_and_update_share_instance_access_rules("},{"line_number":267,"context_line":"                context, updates\u003dupdates, share_instance_id\u003dshare_instance_id)"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        # Is there a sync in progress? If yes, ignore the incoming request."},{"line_number":270,"context_line":"        rule_filter \u003d {"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_bb4fcb8a","line":267,"range":{"start_line":262,"start_character":0,"end_line":267,"end_character":78},"in_reply_to":"5f7c97a3_53dee0db","updated":"2018-07-26 08:52:53.000000000","message":"Done","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bb89ed34c16de65175305e414dcfcc5970c823dd","unresolved":false,"context_lines":[{"line_number":259,"context_line":"            self.get_and_update_share_instance_access_rules("},{"line_number":260,"context_line":"                context, updates\u003dupdates, share_instance_id\u003dshare_instance_id)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        if update_all_rules:"},{"line_number":263,"context_line":"            updates \u003d {"},{"line_number":264,"context_line":"                \u0027state\u0027: constants.ACCESS_STATE_QUEUED_TO_APPLY,"},{"line_number":265,"context_line":"            }"},{"line_number":266,"context_line":"            self.get_and_update_share_instance_access_rules("},{"line_number":267,"context_line":"                context, updates\u003dupdates, share_instance_id\u003dshare_instance_id)"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        # Is there a sync in progress? If yes, ignore the incoming request."},{"line_number":270,"context_line":"        rule_filter \u003d {"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_53dee0db","line":267,"range":{"start_line":262,"start_character":0,"end_line":267,"end_character":78},"in_reply_to":"5f7c97a3_7312fcff","updated":"2018-07-24 03:58:57.000000000","message":"Also, this section was not unit-tested","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"357bdab92ed8d186b62a19cb3db8bdcddfc71b3c","unresolved":false,"context_lines":[{"line_number":259,"context_line":"            self.get_and_update_share_instance_access_rules("},{"line_number":260,"context_line":"                context, updates\u003dupdates, share_instance_id\u003dshare_instance_id)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"        if update_all_rules:"},{"line_number":263,"context_line":"            updates \u003d {"},{"line_number":264,"context_line":"                \u0027state\u0027: constants.ACCESS_STATE_QUEUED_TO_APPLY,"},{"line_number":265,"context_line":"            }"},{"line_number":266,"context_line":"            self.get_and_update_share_instance_access_rules("},{"line_number":267,"context_line":"                context, updates\u003dupdates, share_instance_id\u003dshare_instance_id)"},{"line_number":268,"context_line":""},{"line_number":269,"context_line":"        # Is there a sync in progress? If yes, ignore the incoming request."},{"line_number":270,"context_line":"        rule_filter \u003d {"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_9b544f24","line":267,"range":{"start_line":262,"start_character":0,"end_line":267,"end_character":78},"in_reply_to":"5f7c97a3_7312fcff","updated":"2018-07-26 08:52:53.000000000","message":"Done","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"6bb1d7aa0e2b0c0d3c1f5b895cbc4fc0840db11b","unresolved":false,"context_lines":[{"line_number":376,"context_line":"                                           share_server):"},{"line_number":377,"context_line":"        driver_rule_updates \u003d {}"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        access_rules_to_be_on_share \u003d sorted("},{"line_number":380,"context_line":"            access_rules_to_be_on_share, key\u003doperator.itemgetter(\u0027priority\u0027))"},{"line_number":381,"context_line":"        add_rules \u003d sorted(add_rules, key\u003doperator.itemgetter(\u0027priority\u0027))"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"        share_protocol \u003d share_instance[\u0027share_proto\u0027].lower()"},{"line_number":384,"context_line":"        if (not self.driver.ipv6_implemented and"}],"source_content_type":"text/x-python","patch_set":22,"id":"3f79a3b5_705cc54b","line":381,"range":{"start_line":379,"start_character":8,"end_line":381,"end_character":74},"updated":"2018-10-11 13:09:30.000000000","message":"I am confused by the fact that you are not handling a standard way to prioritize individual rules vs network rules when they both the same priority. If drivers are going to remove their sorting, this kind of sorting needs to happen here","commit_id":"7b50d837d2d9820210d339408adc67266f4ce7a4"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"4529583ed164406242e5e0bd447ccbb7395e7151","unresolved":false,"context_lines":[{"line_number":376,"context_line":"                                           share_server):"},{"line_number":377,"context_line":"        driver_rule_updates \u003d {}"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        access_rules_to_be_on_share \u003d sorted("},{"line_number":380,"context_line":"            access_rules_to_be_on_share, key\u003doperator.itemgetter(\u0027priority\u0027))"},{"line_number":381,"context_line":"        add_rules \u003d sorted(add_rules, key\u003doperator.itemgetter(\u0027priority\u0027))"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"        share_protocol \u003d share_instance[\u0027share_proto\u0027].lower()"},{"line_number":384,"context_line":"        if (not self.driver.ipv6_implemented and"}],"source_content_type":"text/x-python","patch_set":22,"id":"3f79a3b5_4e88706a","line":381,"range":{"start_line":379,"start_character":8,"end_line":381,"end_character":74},"in_reply_to":"3f79a3b5_4d715d45","updated":"2018-10-18 17:52:03.000000000","message":"According to the meeting discussion (http://eavesdrop.openstack.org/meetings/manila/2018/manila.2018-10-18-15.00.log.html#l-151) we don\u0027t want to prevent drivers to further reordering rules when it falls under the case of \"undefined\" behavior. So there is nothing to fix here. \u003d)","commit_id":"7b50d837d2d9820210d339408adc67266f4ce7a4"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"1e509baa446ccf27266c1a6ffb678c2a726b9fe3","unresolved":false,"context_lines":[{"line_number":376,"context_line":"                                           share_server):"},{"line_number":377,"context_line":"        driver_rule_updates \u003d {}"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        access_rules_to_be_on_share \u003d sorted("},{"line_number":380,"context_line":"            access_rules_to_be_on_share, key\u003doperator.itemgetter(\u0027priority\u0027))"},{"line_number":381,"context_line":"        add_rules \u003d sorted(add_rules, key\u003doperator.itemgetter(\u0027priority\u0027))"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"        share_protocol \u003d share_instance[\u0027share_proto\u0027].lower()"},{"line_number":384,"context_line":"        if (not self.driver.ipv6_implemented and"}],"source_content_type":"text/x-python","patch_set":22,"id":"3f79a3b5_4d715d45","line":381,"range":{"start_line":379,"start_character":8,"end_line":381,"end_character":74},"in_reply_to":"3f79a3b5_5c4cb8c8","updated":"2018-10-18 14:19:28.000000000","message":"I checked the spec, and it says in case conflicting rules have the same priority, the behavior will be undefined. I think this is ok, but I don\u0027t agree with the assumption that the behavior will be \"undefined, as it is today\" if we are proposing that drivers remove their ordering. Drivers that order rules today have deterministic behavior. If this ordering is removed, the behavior in that case will be different than it was and it could break deployments.\n\nI intend to discuss this at today\u0027s weekly meeting.","commit_id":"7b50d837d2d9820210d339408adc67266f4ce7a4"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"f183da3b53c7a9d5ffe5c8313892f092654cc79b","unresolved":false,"context_lines":[{"line_number":376,"context_line":"                                           share_server):"},{"line_number":377,"context_line":"        driver_rule_updates \u003d {}"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        access_rules_to_be_on_share \u003d sorted("},{"line_number":380,"context_line":"            access_rules_to_be_on_share, key\u003doperator.itemgetter(\u0027priority\u0027))"},{"line_number":381,"context_line":"        add_rules \u003d sorted(add_rules, key\u003doperator.itemgetter(\u0027priority\u0027))"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"        share_protocol \u003d share_instance[\u0027share_proto\u0027].lower()"},{"line_number":384,"context_line":"        if (not self.driver.ipv6_implemented and"}],"source_content_type":"text/x-python","patch_set":22,"id":"3f79a3b5_8669a1c1","line":381,"range":{"start_line":379,"start_character":8,"end_line":381,"end_character":74},"in_reply_to":"3f79a3b5_705cc54b","updated":"2018-10-18 03:09:27.000000000","message":"I will have to spend more time on understanding this","commit_id":"7b50d837d2d9820210d339408adc67266f4ce7a4"},{"author":{"_account_id":15888,"name":"Zhenyu Zheng","email":"zheng.zhenyu@outlook.com","username":"Kevin_Zheng"},"change_message_id":"5bc08918901df7f6378a009d7b325235a14b3dd4","unresolved":false,"context_lines":[{"line_number":376,"context_line":"                                           share_server):"},{"line_number":377,"context_line":"        driver_rule_updates \u003d {}"},{"line_number":378,"context_line":""},{"line_number":379,"context_line":"        access_rules_to_be_on_share \u003d sorted("},{"line_number":380,"context_line":"            access_rules_to_be_on_share, key\u003doperator.itemgetter(\u0027priority\u0027))"},{"line_number":381,"context_line":"        add_rules \u003d sorted(add_rules, key\u003doperator.itemgetter(\u0027priority\u0027))"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"        share_protocol \u003d share_instance[\u0027share_proto\u0027].lower()"},{"line_number":384,"context_line":"        if (not self.driver.ipv6_implemented and"}],"source_content_type":"text/x-python","patch_set":22,"id":"3f79a3b5_5c4cb8c8","line":381,"range":{"start_line":379,"start_character":8,"end_line":381,"end_character":74},"in_reply_to":"3f79a3b5_8669a1c1","updated":"2018-10-18 07:12:42.000000000","message":"...later... Asked Zhong Jun, she said that there was a discussion before and the result was to handle the same priority case latter, so I\u0027m going to leave this as is for now.","commit_id":"7b50d837d2d9820210d339408adc67266f4ce7a4"}],"manila/share/api.py":[{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"44374b7250e92647cf7d3ecdcae6e87cb3d4841a","unresolved":false,"context_lines":[{"line_number":1598,"context_line":"                INVALID_SHARE_INSTANCE_STATUSES_FOR_ACCESS_RULE_UPDATES)"},{"line_number":1599,"context_line":""},{"line_number":1600,"context_line":"    def allow_access(self, ctx, share, access_type, access_to,"},{"line_number":1601,"context_line":"                     access_level\u003dNone, priority\u003d100):"},{"line_number":1602,"context_line":"        \"\"\"Allow access to share.\"\"\""},{"line_number":1603,"context_line":""},{"line_number":1604,"context_line":"        # Access rule validation:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_0277b40a","line":1601,"range":{"start_line":1601,"start_character":49,"end_line":1601,"end_character":52},"updated":"2018-06-05 09:50:37.000000000","message":"Same comment :)","commit_id":"6ffb38f3018225def57c52a76ac506383b05b951"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"ce3874f0d161879c5aae35d21dd1d1f9298001d9","unresolved":false,"context_lines":[{"line_number":1598,"context_line":"                INVALID_SHARE_INSTANCE_STATUSES_FOR_ACCESS_RULE_UPDATES)"},{"line_number":1599,"context_line":""},{"line_number":1600,"context_line":"    def allow_access(self, ctx, share, access_type, access_to,"},{"line_number":1601,"context_line":"                     access_level\u003dNone, priority\u003d100):"},{"line_number":1602,"context_line":"        \"\"\"Allow access to share.\"\"\""},{"line_number":1603,"context_line":""},{"line_number":1604,"context_line":"        # Access rule validation:"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_983a02c2","line":1601,"range":{"start_line":1601,"start_character":49,"end_line":1601,"end_character":52},"in_reply_to":"5f7c97a3_0277b40a","updated":"2018-06-08 07:38:58.000000000","message":"Done","commit_id":"6ffb38f3018225def57c52a76ac506383b05b951"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b7455c50ceb77a2c57dbc373fd32f5780db082f8","unresolved":false,"context_lines":[{"line_number":1646,"context_line":"        # Share instance validation"},{"line_number":1647,"context_line":"        if any(instance for instance in share.instances"},{"line_number":1648,"context_line":"               if self._is_invalid_share_instance(instance)):"},{"line_number":1649,"context_line":"            msg \u003d _(\"New access rules cannot be applied while the share or \""},{"line_number":1650,"context_line":"                    \"any of its replicas or migration copies lacks a valid \""},{"line_number":1651,"context_line":"                    \"host or is in an invalid state.\")"},{"line_number":1652,"context_line":"            raise exception.InvalidShare(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_76d75324","line":1649,"range":{"start_line":1649,"start_character":21,"end_line":1649,"end_character":55},"updated":"2018-07-11 21:37:00.000000000","message":"Access rule updates cannot be performed","commit_id":"519d75dda306333dac07f875aa7079537162f011"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"62d95ba6ece96ca883e10f61f8108db0c28d6296","unresolved":false,"context_lines":[{"line_number":1646,"context_line":"        # Share instance validation"},{"line_number":1647,"context_line":"        if any(instance for instance in share.instances"},{"line_number":1648,"context_line":"               if self._is_invalid_share_instance(instance)):"},{"line_number":1649,"context_line":"            msg \u003d _(\"New access rules cannot be applied while the share or \""},{"line_number":1650,"context_line":"                    \"any of its replicas or migration copies lacks a valid \""},{"line_number":1651,"context_line":"                    \"host or is in an invalid state.\")"},{"line_number":1652,"context_line":"            raise exception.InvalidShare(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_3f020b0e","line":1649,"range":{"start_line":1649,"start_character":21,"end_line":1649,"end_character":55},"in_reply_to":"5f7c97a3_76d75324","updated":"2018-07-12 05:16:09.000000000","message":"Done","commit_id":"519d75dda306333dac07f875aa7079537162f011"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b7455c50ceb77a2c57dbc373fd32f5780db082f8","unresolved":false,"context_lines":[{"line_number":1655,"context_line":"            context, share_access[\u0027id\u0027], {\u0027priority\u0027: priority})"},{"line_number":1656,"context_line":""},{"line_number":1657,"context_line":"        for share_instance in share.instances:"},{"line_number":1658,"context_line":"            self.allow_access_to_instance(context, share_instance)"},{"line_number":1659,"context_line":""},{"line_number":1660,"context_line":"        return share_access"},{"line_number":1661,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_f6c36357","line":1658,"range":{"start_line":1658,"start_character":0,"end_line":1658,"end_character":66},"updated":"2018-07-11 21:37:00.000000000","message":"This will invoke update_access in the share manager, but there will be no rules to apply, because the rules could all have \"active\" or \"error\" statuses\n\nhttps://github.com/openstack/manila/blob/a1ba28c/manila/share/access.py#L274","commit_id":"519d75dda306333dac07f875aa7079537162f011"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"62d95ba6ece96ca883e10f61f8108db0c28d6296","unresolved":false,"context_lines":[{"line_number":1655,"context_line":"            context, share_access[\u0027id\u0027], {\u0027priority\u0027: priority})"},{"line_number":1656,"context_line":""},{"line_number":1657,"context_line":"        for share_instance in share.instances:"},{"line_number":1658,"context_line":"            self.allow_access_to_instance(context, share_instance)"},{"line_number":1659,"context_line":""},{"line_number":1660,"context_line":"        return share_access"},{"line_number":1661,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_ad1cb17b","line":1658,"range":{"start_line":1658,"start_character":0,"end_line":1658,"end_character":66},"in_reply_to":"5f7c97a3_f6c36357","updated":"2018-07-12 05:16:09.000000000","message":"Done","commit_id":"519d75dda306333dac07f875aa7079537162f011"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"bb89ed34c16de65175305e414dcfcc5970c823dd","unresolved":false,"context_lines":[{"line_number":1639,"context_line":""},{"line_number":1640,"context_line":"        return access"},{"line_number":1641,"context_line":""},{"line_number":1642,"context_line":"    def update_access(self, context, priority, share_access):"},{"line_number":1643,"context_line":"        if share_access[\u0027priority\u0027] \u003d\u003d priority or priority is None:"},{"line_number":1644,"context_line":"            return share_access"},{"line_number":1645,"context_line":"        share \u003d self.get(context, share_access[\u0027share_id\u0027])"},{"line_number":1646,"context_line":"        # Share instance validation"},{"line_number":1647,"context_line":"        if any(instance for instance in share.instances"},{"line_number":1648,"context_line":"               if self._is_invalid_share_instance(instance)):"},{"line_number":1649,"context_line":"            msg \u003d _(\"Access rule updates cannot be performed while the \""},{"line_number":1650,"context_line":"                    \"share or any of its replicas or migration copies \""},{"line_number":1651,"context_line":"                    \"lacks a valid host or is in an invalid state.\")"},{"line_number":1652,"context_line":"            raise exception.InvalidShare(message\u003dmsg)"},{"line_number":1653,"context_line":""},{"line_number":1654,"context_line":"        share_access \u003d self.db.share_access_update("},{"line_number":1655,"context_line":"            context, share_access[\u0027id\u0027], {\u0027priority\u0027: priority})"},{"line_number":1656,"context_line":""},{"line_number":1657,"context_line":"        for share_instance in share.instances:"},{"line_number":1658,"context_line":"            self._conditionally_transition_share_instance_access_rules_status("},{"line_number":1659,"context_line":"                context, share_instance)"},{"line_number":1660,"context_line":"            self.share_rpcapi.update_access(context, share_instance,"},{"line_number":1661,"context_line":"                                            update_all_rules\u003dTrue)"},{"line_number":1662,"context_line":"        return share_access"},{"line_number":1663,"context_line":""},{"line_number":1664,"context_line":"    def allow_access_to_instance(self, context, share_instance):"},{"line_number":1665,"context_line":"        self._conditionally_transition_share_instance_access_rules_status("}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_d3e3d09f","line":1662,"range":{"start_line":1642,"start_character":0,"end_line":1662,"end_character":27},"updated":"2018-07-24 03:58:57.000000000","message":"Not unit-tested","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"357bdab92ed8d186b62a19cb3db8bdcddfc71b3c","unresolved":false,"context_lines":[{"line_number":1639,"context_line":""},{"line_number":1640,"context_line":"        return access"},{"line_number":1641,"context_line":""},{"line_number":1642,"context_line":"    def update_access(self, context, priority, share_access):"},{"line_number":1643,"context_line":"        if share_access[\u0027priority\u0027] \u003d\u003d priority or priority is None:"},{"line_number":1644,"context_line":"            return share_access"},{"line_number":1645,"context_line":"        share \u003d self.get(context, share_access[\u0027share_id\u0027])"},{"line_number":1646,"context_line":"        # Share instance validation"},{"line_number":1647,"context_line":"        if any(instance for instance in share.instances"},{"line_number":1648,"context_line":"               if self._is_invalid_share_instance(instance)):"},{"line_number":1649,"context_line":"            msg \u003d _(\"Access rule updates cannot be performed while the \""},{"line_number":1650,"context_line":"                    \"share or any of its replicas or migration copies \""},{"line_number":1651,"context_line":"                    \"lacks a valid host or is in an invalid state.\")"},{"line_number":1652,"context_line":"            raise exception.InvalidShare(message\u003dmsg)"},{"line_number":1653,"context_line":""},{"line_number":1654,"context_line":"        share_access \u003d self.db.share_access_update("},{"line_number":1655,"context_line":"            context, share_access[\u0027id\u0027], {\u0027priority\u0027: priority})"},{"line_number":1656,"context_line":""},{"line_number":1657,"context_line":"        for share_instance in share.instances:"},{"line_number":1658,"context_line":"            self._conditionally_transition_share_instance_access_rules_status("},{"line_number":1659,"context_line":"                context, share_instance)"},{"line_number":1660,"context_line":"            self.share_rpcapi.update_access(context, share_instance,"},{"line_number":1661,"context_line":"                                            update_all_rules\u003dTrue)"},{"line_number":1662,"context_line":"        return share_access"},{"line_number":1663,"context_line":""},{"line_number":1664,"context_line":"    def allow_access_to_instance(self, context, share_instance):"},{"line_number":1665,"context_line":"        self._conditionally_transition_share_instance_access_rules_status("}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_4771feaa","line":1662,"range":{"start_line":1642,"start_character":0,"end_line":1662,"end_character":27},"in_reply_to":"5f7c97a3_d3e3d09f","updated":"2018-07-26 08:52:53.000000000","message":"Done","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8ac00c8df3b7882a3539a6c9e92754d5364bcf4f","unresolved":false,"context_lines":[{"line_number":1703,"context_line":"        \"\"\"Returns all access rules for share.\"\"\""},{"line_number":1704,"context_line":"        policy.check_policy(context, \u0027share\u0027, \u0027access_get_all\u0027)"},{"line_number":1705,"context_line":"        rules \u003d self.db.share_access_get_all_for_share("},{"line_number":1706,"context_line":"            context, share[\u0027id\u0027], filters, sort_key, sort_dir, limit, offset)"},{"line_number":1707,"context_line":"        return rules"},{"line_number":1708,"context_line":""},{"line_number":1709,"context_line":"    def access_get(self, context, access_id):"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_f397ec38","line":1706,"range":{"start_line":1706,"start_character":41,"end_line":1706,"end_character":76},"updated":"2018-07-24 03:48:38.000000000","message":"pass kwargs as kwargs","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"357bdab92ed8d186b62a19cb3db8bdcddfc71b3c","unresolved":false,"context_lines":[{"line_number":1703,"context_line":"        \"\"\"Returns all access rules for share.\"\"\""},{"line_number":1704,"context_line":"        policy.check_policy(context, \u0027share\u0027, \u0027access_get_all\u0027)"},{"line_number":1705,"context_line":"        rules \u003d self.db.share_access_get_all_for_share("},{"line_number":1706,"context_line":"            context, share[\u0027id\u0027], filters, sort_key, sort_dir, limit, offset)"},{"line_number":1707,"context_line":"        return rules"},{"line_number":1708,"context_line":""},{"line_number":1709,"context_line":"    def access_get(self, context, access_id):"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_dc5dfceb","line":1706,"range":{"start_line":1706,"start_character":41,"end_line":1706,"end_character":76},"in_reply_to":"5f7c97a3_f397ec38","updated":"2018-07-26 08:52:53.000000000","message":"Done","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8ac00c8df3b7882a3539a6c9e92754d5364bcf4f","unresolved":false,"context_lines":[{"line_number":1760,"context_line":"    def update_share_access_metadata(self, context, access_id, metadata):"},{"line_number":1761,"context_line":"        \"\"\"Updates share access metadata.\"\"\""},{"line_number":1762,"context_line":"        self._check_metadata_properties(metadata)"},{"line_number":1763,"context_line":"        return self.db.share_access_metadata_update(context, access_id,"},{"line_number":1764,"context_line":"                                                    metadata)"},{"line_number":1765,"context_line":""},{"line_number":1766,"context_line":"    @policy.wrap_check_policy(\u0027share\u0027)"},{"line_number":1767,"context_line":"    def update_share_metadata(self, context, share, metadata, delete\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_338ec426","line":1764,"range":{"start_line":1763,"start_character":15,"end_line":1764,"end_character":61},"updated":"2018-07-24 03:48:38.000000000","message":"revert this unrelated change","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"357bdab92ed8d186b62a19cb3db8bdcddfc71b3c","unresolved":false,"context_lines":[{"line_number":1760,"context_line":"    def update_share_access_metadata(self, context, access_id, metadata):"},{"line_number":1761,"context_line":"        \"\"\"Updates share access metadata.\"\"\""},{"line_number":1762,"context_line":"        self._check_metadata_properties(metadata)"},{"line_number":1763,"context_line":"        return self.db.share_access_metadata_update(context, access_id,"},{"line_number":1764,"context_line":"                                                    metadata)"},{"line_number":1765,"context_line":""},{"line_number":1766,"context_line":"    @policy.wrap_check_policy(\u0027share\u0027)"},{"line_number":1767,"context_line":"    def update_share_metadata(self, context, share, metadata, delete\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_bc5a80f2","line":1764,"range":{"start_line":1763,"start_character":15,"end_line":1764,"end_character":61},"in_reply_to":"5f7c97a3_338ec426","updated":"2018-07-26 08:52:53.000000000","message":"Done","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"}],"manila/tests/api/v2/test_share_accesses.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8ac00c8df3b7882a3539a6c9e92754d5364bcf4f","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            self.controller.index,"},{"line_number":108,"context_line":"            self._get_index_request(share_id\u003d\u0027inexistent_share_id\u0027))"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def test_list_accesses_share_req_share_id_not_exist(self):"},{"line_number":111,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/share-access-rules?\u0027,"},{"line_number":112,"context_line":"                                      version\u003d\"2.45\")"},{"line_number":113,"context_line":"        self.assertRaises(exc.HTTPBadRequest, self.controller.index, req)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def test_show_access_not_found(self):"},{"line_number":116,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_33dc8416","side":"PARENT","line":113,"range":{"start_line":110,"start_character":4,"end_line":113,"end_character":73},"updated":"2018-07-24 03:48:38.000000000","message":"why was this test removed?","commit_id":"2b389ce1e19402e34dfad135719b5d26e11ff8b8"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"357bdab92ed8d186b62a19cb3db8bdcddfc71b3c","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            self.controller.index,"},{"line_number":108,"context_line":"            self._get_index_request(share_id\u003d\u0027inexistent_share_id\u0027))"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def test_list_accesses_share_req_share_id_not_exist(self):"},{"line_number":111,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v2/share-access-rules?\u0027,"},{"line_number":112,"context_line":"                                      version\u003d\"2.45\")"},{"line_number":113,"context_line":"        self.assertRaises(exc.HTTPBadRequest, self.controller.index, req)"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def test_show_access_not_found(self):"},{"line_number":116,"context_line":"        self.assertRaises("}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_7c22a856","side":"PARENT","line":113,"range":{"start_line":110,"start_character":4,"end_line":113,"end_character":73},"in_reply_to":"5f7c97a3_33dc8416","updated":"2018-07-26 08:52:53.000000000","message":"Done","commit_id":"2b389ce1e19402e34dfad135719b5d26e11ff8b8"}],"manila/tests/db/migrations/alembic/migrations_data_checks.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"961436106a9d25c43f53a81b5142bb322773ca53","unresolved":false,"context_lines":[{"line_number":2600,"context_line":"            \u0027deleted\u0027: \u0027False\u0027"},{"line_number":2601,"context_line":"        }"},{"line_number":2602,"context_line":"        share_access_table \u003d utils.load_table(\u0027share_access_map\u0027, engine)"},{"line_number":2603,"context_line":"        engine.execute(share_access_table.insert(share_access_data))"},{"line_number":2604,"context_line":""},{"line_number":2605,"context_line":"        share_instance_access_data \u003d {"},{"line_number":2606,"context_line":"            \u0027id\u0027: uuidutils.generate_uuid(),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_9f9d91bc","line":2603,"range":{"start_line":2603,"start_character":49,"end_line":2603,"end_character":66},"updated":"2018-06-27 00:20:28.000000000","message":"Insert another rule with \u0027deleted\u0027 set to the rule_id","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"10e19ac862f34e8180c480473faa83af8e2d5200","unresolved":false,"context_lines":[{"line_number":2600,"context_line":"            \u0027deleted\u0027: \u0027False\u0027"},{"line_number":2601,"context_line":"        }"},{"line_number":2602,"context_line":"        share_access_table \u003d utils.load_table(\u0027share_access_map\u0027, engine)"},{"line_number":2603,"context_line":"        engine.execute(share_access_table.insert(share_access_data))"},{"line_number":2604,"context_line":""},{"line_number":2605,"context_line":"        share_instance_access_data \u003d {"},{"line_number":2606,"context_line":"            \u0027id\u0027: uuidutils.generate_uuid(),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_e02b99e7","line":2603,"range":{"start_line":2603,"start_character":49,"end_line":2603,"end_character":66},"in_reply_to":"5f7c97a3_9f9d91bc","updated":"2018-06-30 03:29:44.000000000","message":"Done","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"961436106a9d25c43f53a81b5142bb322773ca53","unresolved":false,"context_lines":[{"line_number":2617,"context_line":"        sam_table \u003d utils.load_table(\u0027share_access_map\u0027, engine)"},{"line_number":2618,"context_line":""},{"line_number":2619,"context_line":"        rule \u003d engine.execute(sam_table.select().where("},{"line_number":2620,"context_line":"            self.share_data[\u0027id\u0027] \u003d\u003d sam_table.c.share_id)).first()"},{"line_number":2621,"context_line":"        self.test_case.assertTrue(hasattr(rule, \u0027priority\u0027))"},{"line_number":2622,"context_line":"        self.test_case.assertEqual(100, rule[\u0027priority\u0027])"},{"line_number":2623,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_ff6845ba","line":2620,"range":{"start_line":2620,"start_character":59,"end_line":2620,"end_character":67},"updated":"2018-06-27 00:20:28.000000000","message":"you need all the rules","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"10e19ac862f34e8180c480473faa83af8e2d5200","unresolved":false,"context_lines":[{"line_number":2617,"context_line":"        sam_table \u003d utils.load_table(\u0027share_access_map\u0027, engine)"},{"line_number":2618,"context_line":""},{"line_number":2619,"context_line":"        rule \u003d engine.execute(sam_table.select().where("},{"line_number":2620,"context_line":"            self.share_data[\u0027id\u0027] \u003d\u003d sam_table.c.share_id)).first()"},{"line_number":2621,"context_line":"        self.test_case.assertTrue(hasattr(rule, \u0027priority\u0027))"},{"line_number":2622,"context_line":"        self.test_case.assertEqual(100, rule[\u0027priority\u0027])"},{"line_number":2623,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_6037894d","line":2620,"range":{"start_line":2620,"start_character":59,"end_line":2620,"end_character":67},"in_reply_to":"5f7c97a3_ff6845ba","updated":"2018-06-30 03:29:44.000000000","message":"Done","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"961436106a9d25c43f53a81b5142bb322773ca53","unresolved":false,"context_lines":[{"line_number":2618,"context_line":""},{"line_number":2619,"context_line":"        rule \u003d engine.execute(sam_table.select().where("},{"line_number":2620,"context_line":"            self.share_data[\u0027id\u0027] \u003d\u003d sam_table.c.share_id)).first()"},{"line_number":2621,"context_line":"        self.test_case.assertTrue(hasattr(rule, \u0027priority\u0027))"},{"line_number":2622,"context_line":"        self.test_case.assertEqual(100, rule[\u0027priority\u0027])"},{"line_number":2623,"context_line":""},{"line_number":2624,"context_line":"        share_access_data \u003d {"},{"line_number":2625,"context_line":"            \u0027id\u0027: uuidutils.generate_uuid(),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_ff3fe5b1","line":2622,"range":{"start_line":2621,"start_character":0,"end_line":2622,"end_character":57},"updated":"2018-06-27 00:20:28.000000000","message":"These asserts apply to all rules, not just ones that were inserted in this class, so don\u0027t filter by share_id here, filter by deleted not equals to \u0027False\u0027.","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"961436106a9d25c43f53a81b5142bb322773ca53","unresolved":false,"context_lines":[{"line_number":2619,"context_line":"        rule \u003d engine.execute(sam_table.select().where("},{"line_number":2620,"context_line":"            self.share_data[\u0027id\u0027] \u003d\u003d sam_table.c.share_id)).first()"},{"line_number":2621,"context_line":"        self.test_case.assertTrue(hasattr(rule, \u0027priority\u0027))"},{"line_number":2622,"context_line":"        self.test_case.assertEqual(100, rule[\u0027priority\u0027])"},{"line_number":2623,"context_line":""},{"line_number":2624,"context_line":"        share_access_data \u003d {"},{"line_number":2625,"context_line":"            \u0027id\u0027: uuidutils.generate_uuid(),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_fffda608","line":2622,"range":{"start_line":2622,"start_character":35,"end_line":2622,"end_character":38},"updated":"2018-06-27 00:20:28.000000000","message":"constants.ACCESS_LEVEL_DEFAULT","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"10e19ac862f34e8180c480473faa83af8e2d5200","unresolved":false,"context_lines":[{"line_number":2618,"context_line":""},{"line_number":2619,"context_line":"        rule \u003d engine.execute(sam_table.select().where("},{"line_number":2620,"context_line":"            self.share_data[\u0027id\u0027] \u003d\u003d sam_table.c.share_id)).first()"},{"line_number":2621,"context_line":"        self.test_case.assertTrue(hasattr(rule, \u0027priority\u0027))"},{"line_number":2622,"context_line":"        self.test_case.assertEqual(100, rule[\u0027priority\u0027])"},{"line_number":2623,"context_line":""},{"line_number":2624,"context_line":"        share_access_data \u003d {"},{"line_number":2625,"context_line":"            \u0027id\u0027: uuidutils.generate_uuid(),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_a099216e","line":2622,"range":{"start_line":2621,"start_character":0,"end_line":2622,"end_character":57},"in_reply_to":"5f7c97a3_ff3fe5b1","updated":"2018-06-30 03:29:44.000000000","message":"Done","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"10e19ac862f34e8180c480473faa83af8e2d5200","unresolved":false,"context_lines":[{"line_number":2619,"context_line":"        rule \u003d engine.execute(sam_table.select().where("},{"line_number":2620,"context_line":"            self.share_data[\u0027id\u0027] \u003d\u003d sam_table.c.share_id)).first()"},{"line_number":2621,"context_line":"        self.test_case.assertTrue(hasattr(rule, \u0027priority\u0027))"},{"line_number":2622,"context_line":"        self.test_case.assertEqual(100, rule[\u0027priority\u0027])"},{"line_number":2623,"context_line":""},{"line_number":2624,"context_line":"        share_access_data \u003d {"},{"line_number":2625,"context_line":"            \u0027id\u0027: uuidutils.generate_uuid(),"}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_a084c10c","line":2622,"range":{"start_line":2622,"start_character":35,"end_line":2622,"end_character":38},"in_reply_to":"5f7c97a3_fffda608","updated":"2018-06-30 03:29:44.000000000","message":"For the test, we should use the actually number(100)? Because the constants.ACCESS_LEVEL_DEFAULT value could be set to a wrong number.","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"961436106a9d25c43f53a81b5142bb322773ca53","unresolved":false,"context_lines":[{"line_number":2621,"context_line":"        self.test_case.assertTrue(hasattr(rule, \u0027priority\u0027))"},{"line_number":2622,"context_line":"        self.test_case.assertEqual(100, rule[\u0027priority\u0027])"},{"line_number":2623,"context_line":""},{"line_number":2624,"context_line":"        share_access_data \u003d {"},{"line_number":2625,"context_line":"            \u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":2626,"context_line":"            \u0027share_id\u0027: self.share_data[\u0027id\u0027],"},{"line_number":2627,"context_line":"            \u0027access_type\u0027: \u0027fake\u0027,"},{"line_number":2628,"context_line":"            \u0027access_to\u0027: \u0027alice\u0027,"},{"line_number":2629,"context_line":"            \u0027deleted\u0027: \u0027False\u0027,"},{"line_number":2630,"context_line":"            \u0027priority\u0027: 150,"},{"line_number":2631,"context_line":"        }"},{"line_number":2632,"context_line":"        engine.execute(sam_table.insert(share_access_data))"},{"line_number":2633,"context_line":"        share_instance_access_data \u003d {"},{"line_number":2634,"context_line":"            \u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":2635,"context_line":"            \u0027share_instance_id\u0027: self.share_instance_data[\u0027id\u0027],"},{"line_number":2636,"context_line":"            \u0027access_id\u0027: share_access_data[\u0027id\u0027],"},{"line_number":2637,"context_line":"            \u0027deleted\u0027: \u0027False\u0027"},{"line_number":2638,"context_line":"        }"},{"line_number":2639,"context_line":"        share_instance_access_table \u003d utils.load_table("},{"line_number":2640,"context_line":"            \u0027share_instance_access_map\u0027, engine)"},{"line_number":2641,"context_line":"        engine.execute(share_instance_access_table.insert("},{"line_number":2642,"context_line":"            share_instance_access_data))"},{"line_number":2643,"context_line":""},{"line_number":2644,"context_line":"        sam \u003d engine.execute(sam_table.select().where("},{"line_number":2645,"context_line":"            share_access_data[\u0027id\u0027] \u003d\u003d sam_table.c.id)).first()"},{"line_number":2646,"context_line":"        self.test_case.assertEqual("},{"line_number":2647,"context_line":"            share_access_data[\u0027priority\u0027], sam[\u0027priority\u0027])"},{"line_number":2648,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_5f6e19c8","line":2645,"range":{"start_line":2624,"start_character":0,"end_line":2645,"end_character":63},"updated":"2018-06-27 00:20:28.000000000","message":"this doesn\u0027t test the migration code","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"10e19ac862f34e8180c480473faa83af8e2d5200","unresolved":false,"context_lines":[{"line_number":2621,"context_line":"        self.test_case.assertTrue(hasattr(rule, \u0027priority\u0027))"},{"line_number":2622,"context_line":"        self.test_case.assertEqual(100, rule[\u0027priority\u0027])"},{"line_number":2623,"context_line":""},{"line_number":2624,"context_line":"        share_access_data \u003d {"},{"line_number":2625,"context_line":"            \u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":2626,"context_line":"            \u0027share_id\u0027: self.share_data[\u0027id\u0027],"},{"line_number":2627,"context_line":"            \u0027access_type\u0027: \u0027fake\u0027,"},{"line_number":2628,"context_line":"            \u0027access_to\u0027: \u0027alice\u0027,"},{"line_number":2629,"context_line":"            \u0027deleted\u0027: \u0027False\u0027,"},{"line_number":2630,"context_line":"            \u0027priority\u0027: 150,"},{"line_number":2631,"context_line":"        }"},{"line_number":2632,"context_line":"        engine.execute(sam_table.insert(share_access_data))"},{"line_number":2633,"context_line":"        share_instance_access_data \u003d {"},{"line_number":2634,"context_line":"            \u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":2635,"context_line":"            \u0027share_instance_id\u0027: self.share_instance_data[\u0027id\u0027],"},{"line_number":2636,"context_line":"            \u0027access_id\u0027: share_access_data[\u0027id\u0027],"},{"line_number":2637,"context_line":"            \u0027deleted\u0027: \u0027False\u0027"},{"line_number":2638,"context_line":"        }"},{"line_number":2639,"context_line":"        share_instance_access_table \u003d utils.load_table("},{"line_number":2640,"context_line":"            \u0027share_instance_access_map\u0027, engine)"},{"line_number":2641,"context_line":"        engine.execute(share_instance_access_table.insert("},{"line_number":2642,"context_line":"            share_instance_access_data))"},{"line_number":2643,"context_line":""},{"line_number":2644,"context_line":"        sam \u003d engine.execute(sam_table.select().where("},{"line_number":2645,"context_line":"            share_access_data[\u0027id\u0027] \u003d\u003d sam_table.c.id)).first()"},{"line_number":2646,"context_line":"        self.test_case.assertEqual("},{"line_number":2647,"context_line":"            share_access_data[\u0027priority\u0027], sam[\u0027priority\u0027])"},{"line_number":2648,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5f7c97a3_00fed5ae","line":2645,"range":{"start_line":2624,"start_character":0,"end_line":2645,"end_character":63},"in_reply_to":"5f7c97a3_5f6e19c8","updated":"2018-06-30 03:29:44.000000000","message":"This test weather the new db is fine after migration.","commit_id":"770e84fb29d3d1b777ec24e665384694d0563aea"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b7455c50ceb77a2c57dbc373fd32f5780db082f8","unresolved":false,"context_lines":[{"line_number":2774,"context_line":"            \u0027deleted\u0027: \u0027False\u0027"},{"line_number":2775,"context_line":"        }"},{"line_number":2776,"context_line":"        share_access_data2 \u003d {"},{"line_number":2777,"context_line":"            \u0027id\u0027: \u0027test_id\u0027,"},{"line_number":2778,"context_line":"            \u0027share_id\u0027: self.share_data[\u0027id\u0027],"},{"line_number":2779,"context_line":"            \u0027access_type\u0027: \u0027NFS\u0027,"},{"line_number":2780,"context_line":"            \u0027access_to\u0027: \u002710.0.0.1\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_d6b747d7","line":2777,"range":{"start_line":2777,"start_character":0,"end_line":2777,"end_character":28},"updated":"2018-07-11 21:37:00.000000000","message":"better create a uuid","commit_id":"519d75dda306333dac07f875aa7079537162f011"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"62d95ba6ece96ca883e10f61f8108db0c28d6296","unresolved":false,"context_lines":[{"line_number":2774,"context_line":"            \u0027deleted\u0027: \u0027False\u0027"},{"line_number":2775,"context_line":"        }"},{"line_number":2776,"context_line":"        share_access_data2 \u003d {"},{"line_number":2777,"context_line":"            \u0027id\u0027: \u0027test_id\u0027,"},{"line_number":2778,"context_line":"            \u0027share_id\u0027: self.share_data[\u0027id\u0027],"},{"line_number":2779,"context_line":"            \u0027access_type\u0027: \u0027NFS\u0027,"},{"line_number":2780,"context_line":"            \u0027access_to\u0027: \u002710.0.0.1\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_62146842","line":2777,"range":{"start_line":2777,"start_character":0,"end_line":2777,"end_character":28},"in_reply_to":"5f7c97a3_d6b747d7","updated":"2018-07-12 05:16:09.000000000","message":"Done","commit_id":"519d75dda306333dac07f875aa7079537162f011"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b7455c50ceb77a2c57dbc373fd32f5780db082f8","unresolved":false,"context_lines":[{"line_number":2778,"context_line":"            \u0027share_id\u0027: self.share_data[\u0027id\u0027],"},{"line_number":2779,"context_line":"            \u0027access_type\u0027: \u0027NFS\u0027,"},{"line_number":2780,"context_line":"            \u0027access_to\u0027: \u002710.0.0.1\u0027,"},{"line_number":2781,"context_line":"            \u0027deleted\u0027: \u0027test_id222\u0027,"},{"line_number":2782,"context_line":"        }"},{"line_number":2783,"context_line":"        share_access_table \u003d utils.load_table(\u0027share_access_map\u0027, engine)"},{"line_number":2784,"context_line":"        engine.execute(share_access_table.insert(share_access_data))"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_369d5b58","line":2781,"range":{"start_line":2781,"start_character":23,"end_line":2781,"end_character":35},"updated":"2018-07-11 21:37:00.000000000","message":"reuse uuid created above here","commit_id":"519d75dda306333dac07f875aa7079537162f011"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"62d95ba6ece96ca883e10f61f8108db0c28d6296","unresolved":false,"context_lines":[{"line_number":2778,"context_line":"            \u0027share_id\u0027: self.share_data[\u0027id\u0027],"},{"line_number":2779,"context_line":"            \u0027access_type\u0027: \u0027NFS\u0027,"},{"line_number":2780,"context_line":"            \u0027access_to\u0027: \u002710.0.0.1\u0027,"},{"line_number":2781,"context_line":"            \u0027deleted\u0027: \u0027test_id222\u0027,"},{"line_number":2782,"context_line":"        }"},{"line_number":2783,"context_line":"        share_access_table \u003d utils.load_table(\u0027share_access_map\u0027, engine)"},{"line_number":2784,"context_line":"        engine.execute(share_access_table.insert(share_access_data))"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_2228b083","line":2781,"range":{"start_line":2781,"start_character":23,"end_line":2781,"end_character":35},"in_reply_to":"5f7c97a3_369d5b58","updated":"2018-07-12 05:16:09.000000000","message":"Done","commit_id":"519d75dda306333dac07f875aa7079537162f011"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b7455c50ceb77a2c57dbc373fd32f5780db082f8","unresolved":false,"context_lines":[{"line_number":2797,"context_line":"            \u0027id\u0027: share_instance_access_data2_id,"},{"line_number":2798,"context_line":"            \u0027share_instance_id\u0027: self.share_instance_data[\u0027id\u0027],"},{"line_number":2799,"context_line":"            \u0027access_id\u0027: \u0027test_id\u0027,"},{"line_number":2800,"context_line":"            \u0027deleted\u0027: \u0027False\u0027"},{"line_number":2801,"context_line":"        }"},{"line_number":2802,"context_line":"        share_instance_access_table \u003d utils.load_table("},{"line_number":2803,"context_line":"            \u0027share_instance_access_map\u0027, engine)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_56757732","line":2800,"range":{"start_line":2800,"start_character":23,"end_line":2800,"end_character":30},"updated":"2018-07-11 21:37:00.000000000","message":"share_instance_access_data2_id\n\ncorresponding share_access_data has been marked deleted","commit_id":"519d75dda306333dac07f875aa7079537162f011"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"62d95ba6ece96ca883e10f61f8108db0c28d6296","unresolved":false,"context_lines":[{"line_number":2797,"context_line":"            \u0027id\u0027: share_instance_access_data2_id,"},{"line_number":2798,"context_line":"            \u0027share_instance_id\u0027: self.share_instance_data[\u0027id\u0027],"},{"line_number":2799,"context_line":"            \u0027access_id\u0027: \u0027test_id\u0027,"},{"line_number":2800,"context_line":"            \u0027deleted\u0027: \u0027False\u0027"},{"line_number":2801,"context_line":"        }"},{"line_number":2802,"context_line":"        share_instance_access_table \u003d utils.load_table("},{"line_number":2803,"context_line":"            \u0027share_instance_access_map\u0027, engine)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_823664e8","line":2800,"range":{"start_line":2800,"start_character":23,"end_line":2800,"end_character":30},"in_reply_to":"5f7c97a3_56757732","updated":"2018-07-12 05:16:09.000000000","message":"Done","commit_id":"519d75dda306333dac07f875aa7079537162f011"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"b7455c50ceb77a2c57dbc373fd32f5780db082f8","unresolved":false,"context_lines":[{"line_number":2816,"context_line":"            self.test_case.assertTrue(hasattr(rule, \u0027priority\u0027))"},{"line_number":2817,"context_line":"            self.test_case.assertEqual(100, rule[\u0027priority\u0027])"},{"line_number":2818,"context_line":""},{"line_number":2819,"context_line":"        share_access_data \u003d {"},{"line_number":2820,"context_line":"            \u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":2821,"context_line":"            \u0027share_id\u0027: self.share_data[\u0027id\u0027],"},{"line_number":2822,"context_line":"            \u0027access_type\u0027: \u0027fake\u0027,"},{"line_number":2823,"context_line":"            \u0027access_to\u0027: \u0027alice\u0027,"},{"line_number":2824,"context_line":"            \u0027deleted\u0027: \u0027False\u0027,"},{"line_number":2825,"context_line":"            \u0027priority\u0027: 150,"},{"line_number":2826,"context_line":"        }"},{"line_number":2827,"context_line":"        engine.execute(sam_table.insert(share_access_data))"},{"line_number":2828,"context_line":"        share_instance_access_data \u003d {"},{"line_number":2829,"context_line":"            \u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":2830,"context_line":"            \u0027share_instance_id\u0027: self.share_instance_data[\u0027id\u0027],"},{"line_number":2831,"context_line":"            \u0027access_id\u0027: share_access_data[\u0027id\u0027],"},{"line_number":2832,"context_line":"            \u0027deleted\u0027: \u0027False\u0027,"},{"line_number":2833,"context_line":"            \u0027state\u0027: \u0027active\u0027"},{"line_number":2834,"context_line":"        }"},{"line_number":2835,"context_line":"        share_instance_access_table \u003d utils.load_table("},{"line_number":2836,"context_line":"            \u0027share_instance_access_map\u0027, engine)"},{"line_number":2837,"context_line":"        engine.execute(share_instance_access_table.insert("},{"line_number":2838,"context_line":"            share_instance_access_data))"},{"line_number":2839,"context_line":""},{"line_number":2840,"context_line":"        sam \u003d engine.execute(sam_table.select().where("},{"line_number":2841,"context_line":"            share_access_data[\u0027id\u0027] \u003d\u003d sam_table.c.id)).first()"},{"line_number":2842,"context_line":"        self.test_case.assertEqual("},{"line_number":2843,"context_line":"            share_access_data[\u0027priority\u0027], sam[\u0027priority\u0027])"},{"line_number":2844,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_b6008b6b","line":2841,"range":{"start_line":2819,"start_character":0,"end_line":2841,"end_character":63},"updated":"2018-07-11 21:37:00.000000000","message":"Add a comment above that you\u0027re testing that inserts work fine after an upgrade","commit_id":"519d75dda306333dac07f875aa7079537162f011"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"62d95ba6ece96ca883e10f61f8108db0c28d6296","unresolved":false,"context_lines":[{"line_number":2816,"context_line":"            self.test_case.assertTrue(hasattr(rule, \u0027priority\u0027))"},{"line_number":2817,"context_line":"            self.test_case.assertEqual(100, rule[\u0027priority\u0027])"},{"line_number":2818,"context_line":""},{"line_number":2819,"context_line":"        share_access_data \u003d {"},{"line_number":2820,"context_line":"            \u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":2821,"context_line":"            \u0027share_id\u0027: self.share_data[\u0027id\u0027],"},{"line_number":2822,"context_line":"            \u0027access_type\u0027: \u0027fake\u0027,"},{"line_number":2823,"context_line":"            \u0027access_to\u0027: \u0027alice\u0027,"},{"line_number":2824,"context_line":"            \u0027deleted\u0027: \u0027False\u0027,"},{"line_number":2825,"context_line":"            \u0027priority\u0027: 150,"},{"line_number":2826,"context_line":"        }"},{"line_number":2827,"context_line":"        engine.execute(sam_table.insert(share_access_data))"},{"line_number":2828,"context_line":"        share_instance_access_data \u003d {"},{"line_number":2829,"context_line":"            \u0027id\u0027: uuidutils.generate_uuid(),"},{"line_number":2830,"context_line":"            \u0027share_instance_id\u0027: self.share_instance_data[\u0027id\u0027],"},{"line_number":2831,"context_line":"            \u0027access_id\u0027: share_access_data[\u0027id\u0027],"},{"line_number":2832,"context_line":"            \u0027deleted\u0027: \u0027False\u0027,"},{"line_number":2833,"context_line":"            \u0027state\u0027: \u0027active\u0027"},{"line_number":2834,"context_line":"        }"},{"line_number":2835,"context_line":"        share_instance_access_table \u003d utils.load_table("},{"line_number":2836,"context_line":"            \u0027share_instance_access_map\u0027, engine)"},{"line_number":2837,"context_line":"        engine.execute(share_instance_access_table.insert("},{"line_number":2838,"context_line":"            share_instance_access_data))"},{"line_number":2839,"context_line":""},{"line_number":2840,"context_line":"        sam \u003d engine.execute(sam_table.select().where("},{"line_number":2841,"context_line":"            share_access_data[\u0027id\u0027] \u003d\u003d sam_table.c.id)).first()"},{"line_number":2842,"context_line":"        self.test_case.assertEqual("},{"line_number":2843,"context_line":"            share_access_data[\u0027priority\u0027], sam[\u0027priority\u0027])"},{"line_number":2844,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"5f7c97a3_622d488e","line":2841,"range":{"start_line":2819,"start_character":0,"end_line":2841,"end_character":63},"in_reply_to":"5f7c97a3_b6008b6b","updated":"2018-07-12 05:16:09.000000000","message":"Done","commit_id":"519d75dda306333dac07f875aa7079537162f011"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"8ac00c8df3b7882a3539a6c9e92754d5364bcf4f","unresolved":false,"context_lines":[{"line_number":2867,"context_line":""},{"line_number":2868,"context_line":"    def check_downgrade(self, engine):"},{"line_number":2869,"context_line":"        sam_table \u003d utils.load_table(\u0027share_access_map\u0027, engine)"},{"line_number":2870,"context_line":"        for rule in engine.execute(sam_table.select()):"},{"line_number":2871,"context_line":"            self.test_case.assertFalse(hasattr(rule, \u0027priority\u0027))"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_b3f09494","line":2871,"range":{"start_line":2870,"start_character":8,"end_line":2871,"end_character":65},"updated":"2018-07-24 03:48:38.000000000","message":"verify that the rules you inserted are still around","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"357bdab92ed8d186b62a19cb3db8bdcddfc71b3c","unresolved":false,"context_lines":[{"line_number":2867,"context_line":""},{"line_number":2868,"context_line":"    def check_downgrade(self, engine):"},{"line_number":2869,"context_line":"        sam_table \u003d utils.load_table(\u0027share_access_map\u0027, engine)"},{"line_number":2870,"context_line":"        for rule in engine.execute(sam_table.select()):"},{"line_number":2871,"context_line":"            self.test_case.assertFalse(hasattr(rule, \u0027priority\u0027))"}],"source_content_type":"text/x-python","patch_set":19,"id":"5f7c97a3_1ca1343b","line":2871,"range":{"start_line":2870,"start_character":8,"end_line":2871,"end_character":65},"in_reply_to":"5f7c97a3_b3f09494","updated":"2018-07-26 08:52:53.000000000","message":"Done","commit_id":"33c8afbca34284695346058f14ca90d6e3fa7e52"}],"releasenotes/notes/add-priority-for-access-rule-50df9923ae7f6658.yaml":[{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"bce432ccf7b9de4f41e704e0577a956e16ffa1be","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added ``priority`` field to ``access`` object, adn A new API"},{"line_number":5,"context_line":"    mircorversion 2.47 has been added, user will be allow to"},{"line_number":6,"context_line":"    call ``PATCH /share-access-rules/{access_id}`` to update the"},{"line_number":7,"context_line":"    ``priority`` field of the given access for requests with the"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"3f79a3b5_adf587cb","line":4,"updated":"2018-12-13 15:37:31.000000000","message":"typo \"adn\"","commit_id":"74ff39e077af5d2a8ee3b5be64cda15f9124bac5"},{"author":{"_account_id":7102,"name":"Thomas Bechtold","email":"thomas.bechtold@chainguard.dev","username":"toabctl"},"change_message_id":"bce432ccf7b9de4f41e704e0577a956e16ffa1be","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    call ``PATCH /share-access-rules/{access_id}`` to update the"},{"line_number":7,"context_line":"    ``priority`` field of the given access for requests with the"},{"line_number":8,"context_line":"    new microversion or greater. The valid priority value is integer"},{"line_number":9,"context_line":"    within the range of ``1 ~ 200``, where a lower number means a"},{"line_number":10,"context_line":"    higher priority. Sorting, filtering and pagination"},{"line_number":11,"context_line":"    support for ``GET /share-access-rules`` API is also added in"},{"line_number":12,"context_line":"    this microversion. The API currently supports filtering by"}],"source_content_type":"text/x-yaml","patch_set":29,"id":"3f79a3b5_2dd8974f","line":9,"updated":"2018-12-13 15:37:31.000000000","message":"just curious: How did you come up with 1-200?","commit_id":"74ff39e077af5d2a8ee3b5be64cda15f9124bac5"}]}
