)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"45081f860e91ec4a82474798c3ed459e8d6a2d3b","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     shaoxj \u003cshaoxj@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-06-12 19:30:12 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[API]The reuest descroption modification in the api of list shares"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1.This API is a method of \"GET\", bug serveral parameters are passed"},{"line_number":10,"context_line":"through the \"body\" or \"path\", eg.name,share_server_id,share_type_id,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_4a00ba01","line":7,"range":{"start_line":7,"start_character":4,"end_line":7,"end_character":6},"updated":"2018-06-12 19:14:17.000000000","message":"The header is supposed to be less than 50 characters and cannot contain misspellings, etc. since people searh on it.\nI suggest:\n\n[API] Fix request parameters in ``list shares``","commit_id":"8669b0a37693448aeba8211d69acd0cc4487c4df"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"45081f860e91ec4a82474798c3ed459e8d6a2d3b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[API]The reuest descroption modification in the api of list shares"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1.This API is a method of \"GET\", bug serveral parameters are passed"},{"line_number":10,"context_line":"through the \"body\" or \"path\", eg.name,share_server_id,share_type_id,"},{"line_number":11,"context_line":"is_public,host,share_network_id."},{"line_number":12,"context_line":"2.Shares can be filtered through two objects(metadata, extra_specs),"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_2fbf9061","line":9,"range":{"start_line":9,"start_character":57,"end_line":9,"end_character":67},"updated":"2018-06-12 19:14:17.000000000","message":"are currently documented as being passed","commit_id":"8669b0a37693448aeba8211d69acd0cc4487c4df"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"45081f860e91ec4a82474798c3ed459e8d6a2d3b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[API]The reuest descroption modification in the api of list shares"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1.This API is a method of \"GET\", bug serveral parameters are passed"},{"line_number":10,"context_line":"through the \"body\" or \"path\", eg.name,share_server_id,share_type_id,"},{"line_number":11,"context_line":"is_public,host,share_network_id."},{"line_number":12,"context_line":"2.Shares can be filtered through two objects(metadata, extra_specs),"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_af04004b","line":9,"range":{"start_line":9,"start_character":33,"end_line":9,"end_character":36},"updated":"2018-06-12 19:14:17.000000000","message":"but","commit_id":"8669b0a37693448aeba8211d69acd0cc4487c4df"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"45081f860e91ec4a82474798c3ed459e8d6a2d3b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[API]The reuest descroption modification in the api of list shares"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1.This API is a method of \"GET\", bug serveral parameters are passed"},{"line_number":10,"context_line":"through the \"body\" or \"path\", eg.name,share_server_id,share_type_id,"},{"line_number":11,"context_line":"is_public,host,share_network_id."},{"line_number":12,"context_line":"2.Shares can be filtered through two objects(metadata, extra_specs),"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_2f96b0f1","line":9,"range":{"start_line":9,"start_character":37,"end_line":9,"end_character":44},"updated":"2018-06-12 19:14:17.000000000","message":"several","commit_id":"8669b0a37693448aeba8211d69acd0cc4487c4df"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"45081f860e91ec4a82474798c3ed459e8d6a2d3b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[API]The reuest descroption modification in the api of list shares"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1.This API is a method of \"GET\", bug serveral parameters are passed"},{"line_number":10,"context_line":"through the \"body\" or \"path\", eg.name,share_server_id,share_type_id,"},{"line_number":11,"context_line":"is_public,host,share_network_id."},{"line_number":12,"context_line":"2.Shares can be filtered through two objects(metadata, extra_specs),"},{"line_number":13,"context_line":"but there is no body in the GET.These two conditions are used to filter"},{"line_number":14,"context_line":"again in the list after other conditions are filtered, which will"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"5f7c97a3_cfadbc31","line":11,"range":{"start_line":10,"start_character":30,"end_line":11,"end_character":32},"updated":"2018-06-12 19:14:17.000000000","message":"Please put spaces after the commas in this list.","commit_id":"8669b0a37693448aeba8211d69acd0cc4487c4df"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"d47a60c9c9a0875b8586f0aeaa5289eea91f1956","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     shaoxj \u003cshaoxj@inspur.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-06-20 18:59:29 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[API] The reuest descroption modification in the api of list shares"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1.This API is a method of \"GET\", but several parameters are currently"},{"line_number":10,"context_line":" documented as being passed through the \"body\" or \"path\", eg.name,"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_fe73e3b2","line":7,"range":{"start_line":7,"start_character":10,"end_line":7,"end_character":28},"updated":"2018-06-20 12:52:18.000000000","message":"These words are not spelled correctly.\n\nSuggest:\n\n [API]: Fix request description for ``list shares``","commit_id":"a660826a790c3fa1d701280755678057d099dd8d"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"d47a60c9c9a0875b8586f0aeaa5289eea91f1956","unresolved":false,"context_lines":[{"line_number":7,"context_line":"[API] The reuest descroption modification in the api of list shares"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"1.This API is a method of \"GET\", but several parameters are currently"},{"line_number":10,"context_line":" documented as being passed through the \"body\" or \"path\", eg.name,"},{"line_number":11,"context_line":" share_server_id, share_type_id, is_public, host,share_network_id."},{"line_number":12,"context_line":"2.Shares can be filtered through two objects(metadata, extra_specs),"},{"line_number":13,"context_line":"but there is no body in the GET.These two conditions are used to filter"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_1e77bfa1","line":10,"range":{"start_line":10,"start_character":58,"end_line":10,"end_character":65},"updated":"2018-06-20 12:52:18.000000000","message":"e.g. name,","commit_id":"a660826a790c3fa1d701280755678057d099dd8d"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"d47a60c9c9a0875b8586f0aeaa5289eea91f1956","unresolved":false,"context_lines":[{"line_number":9,"context_line":"1.This API is a method of \"GET\", but several parameters are currently"},{"line_number":10,"context_line":" documented as being passed through the \"body\" or \"path\", eg.name,"},{"line_number":11,"context_line":" share_server_id, share_type_id, is_public, host,share_network_id."},{"line_number":12,"context_line":"2.Shares can be filtered through two objects(metadata, extra_specs),"},{"line_number":13,"context_line":"but there is no body in the GET.These two conditions are used to filter"},{"line_number":14,"context_line":"again in the list after other conditions are filtered, which will"},{"line_number":15,"context_line":"reduce query efficiency. I don\u0027t think this is a good idear, so I"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_be548bff","line":12,"range":{"start_line":12,"start_character":37,"end_line":12,"end_character":54},"updated":"2018-06-20 12:52:18.000000000","message":"Please put space between words.","commit_id":"a660826a790c3fa1d701280755678057d099dd8d"},{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"d47a60c9c9a0875b8586f0aeaa5289eea91f1956","unresolved":false,"context_lines":[{"line_number":12,"context_line":"2.Shares can be filtered through two objects(metadata, extra_specs),"},{"line_number":13,"context_line":"but there is no body in the GET.These two conditions are used to filter"},{"line_number":14,"context_line":"again in the list after other conditions are filtered, which will"},{"line_number":15,"context_line":"reduce query efficiency. I don\u0027t think this is a good idear, so I"},{"line_number":16,"context_line":"suggest removing them."},{"line_number":17,"context_line":"3.remove metadata and extra_specs from API"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_9e398fd0","line":15,"range":{"start_line":15,"start_character":54,"end_line":15,"end_character":59},"updated":"2018-06-20 12:52:18.000000000","message":"idea","commit_id":"a660826a790c3fa1d701280755678057d099dd8d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"87334be0286114dda7135929935bed6f3992a902","unresolved":false,"context_lines":[{"line_number":12,"context_line":"2.Shares can be filtered through two objects(metadata, extra_specs),"},{"line_number":13,"context_line":"but there is no body in the GET.These two conditions are used to filter"},{"line_number":14,"context_line":"again in the list after other conditions are filtered, which will"},{"line_number":15,"context_line":"reduce query efficiency. I don\u0027t think this is a good idear, so I"},{"line_number":16,"context_line":"suggest removing them."},{"line_number":17,"context_line":"3.remove metadata and extra_specs from API"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Idf147addb4e291c3c5d3fe9b2c50242350cfd8c9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_ae5774ca","line":17,"range":{"start_line":15,"start_character":24,"end_line":17,"end_character":42},"updated":"2018-06-20 16:16:22.000000000","message":"This is a valid sentiment, however, please remember this is a published API that users may be relying upon. We cannot remove APIs at will, we\u0027re bound by contract to our users to maintain a consistent API. We have a mechanism to evolve the API however, and that is detailed here: https://docs.openstack.org/manila/latest/contributor/api_microversion_dev.html","commit_id":"a660826a790c3fa1d701280755678057d099dd8d"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7f63a630bb5f32f2b1f1bd2cc31c80c4d0f4f82d","unresolved":false,"context_lines":[{"line_number":12,"context_line":"2.Shares can be filtered through two objects(metadata, extra_specs),"},{"line_number":13,"context_line":"but there is no body in the GET.These two conditions are used to filter"},{"line_number":14,"context_line":"again in the list after other conditions are filtered, which will"},{"line_number":15,"context_line":"reduce query efficiency. I don\u0027t think this is a good idear, so I"},{"line_number":16,"context_line":"suggest removing them."},{"line_number":17,"context_line":"3.remove metadata and extra_specs from API"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Idf147addb4e291c3c5d3fe9b2c50242350cfd8c9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_c6c15582","line":17,"range":{"start_line":15,"start_character":24,"end_line":17,"end_character":42},"in_reply_to":"5f7c97a3_ae5774ca","updated":"2018-06-22 03:21:51.000000000","message":"+1 This is a usable function, we can simply get shares by extra_specs or metadata, even if is no body in the GET. If you need it in the GET, you could and it with microversion that Goutham talked about. \nThen please separate those question to different patches","commit_id":"a660826a790c3fa1d701280755678057d099dd8d"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"2a1c76f92f571e66423461ab1a17afe4b3920d33","unresolved":false,"context_lines":[{"line_number":15,"context_line":"reduce query efficiency. I don\u0027t think this is a good idear, so I"},{"line_number":16,"context_line":"suggest removing them."},{"line_number":17,"context_line":"3.remove metadata and extra_specs from API"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Idf147addb4e291c3c5d3fe9b2c50242350cfd8c9"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5f7c97a3_ae25345e","line":18,"range":{"start_line":18,"start_character":0,"end_line":18,"end_character":0},"updated":"2018-06-20 16:17:11.000000000","message":"Please file a bug with your concerns on https://bugs.launchpad.net/manila","commit_id":"a660826a790c3fa1d701280755678057d099dd8d"}],"api-ref/source/parameters.yaml":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"45081f860e91ec4a82474798c3ed459e8d6a2d3b","unresolved":false,"context_lines":[{"line_number":367,"context_line":"  in: query"},{"line_number":368,"context_line":"  required: false"},{"line_number":369,"context_line":"  type: string"},{"line_number":370,"context_line":"share_is_public:"},{"line_number":371,"context_line":"  description: |"},{"line_number":372,"context_line":"    (Since API v2.8) The level of visibility for the"},{"line_number":373,"context_line":"    share. Set to ``true`` to make share public. Set to ``false`` to"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_efcd1830","line":370,"range":{"start_line":370,"start_character":0,"end_line":370,"end_character":16},"updated":"2018-06-12 19:14:17.000000000","message":"Wouldn\u0027t it be consistent with your other changes to name this one \u0027share_is_public_query\u0027?","commit_id":"8669b0a37693448aeba8211d69acd0cc4487c4df"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"7f63a630bb5f32f2b1f1bd2cc31c80c4d0f4f82d","unresolved":false,"context_lines":[{"line_number":369,"context_line":"  type: string"},{"line_number":370,"context_line":"share_is_public:"},{"line_number":371,"context_line":"  description: |"},{"line_number":372,"context_line":"    (Since API v2.8) The level of visibility for the"},{"line_number":373,"context_line":"    share. Set to ``true`` to make share public. Set to ``false`` to"},{"line_number":374,"context_line":"    make it private. Default value is ``false``."},{"line_number":375,"context_line":"  in: query"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5f7c97a3_864cbd3f","line":372,"range":{"start_line":372,"start_character":4,"end_line":372,"end_character":20},"updated":"2018-06-22 03:21:51.000000000","message":"Using \"min_version: 2.8\" instead of \"(Since API v2.8)\"","commit_id":"a660826a790c3fa1d701280755678057d099dd8d"}],"api-ref/source/shares.inc":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"45081f860e91ec4a82474798c3ed459e8d6a2d3b","unresolved":false,"context_lines":[{"line_number":112,"context_line":"   - name: name_5"},{"line_number":113,"context_line":"   - status: status_6"},{"line_number":114,"context_line":"   - share_server_id: share_server_id"},{"line_number":115,"context_line":"   - metadata: metadata"},{"line_number":116,"context_line":"   - extra_specs: extra_specs"},{"line_number":117,"context_line":"   - share_type_id: share_type_id"},{"line_number":118,"context_line":"   - limit: limit"},{"line_number":119,"context_line":"   - offset: offset"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"5f7c97a3_aa2dce8f","side":"PARENT","line":116,"range":{"start_line":115,"start_character":0,"end_line":116,"end_character":29},"updated":"2018-06-12 19:14:17.000000000","message":"I think your point is that searching with these items in the request is inefficient, not that they are not currently *in* the request.  Removing them from the documentation is not an approriate remedy for this issue: you\u0027d need to actually remove them from the API (with community buy in and a microversion change) or figure out how to make them efficient.","commit_id":"0344ee619840057a9f11cb07cd3d3cc78a3615e7"}]}