)]}'
{"contrib/ci/post_test_hook.sh":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"98389e71919dc4ac5a8a56460341ba61c663c908","unresolved":false,"context_lines":[{"line_number":54,"context_line":"fi"},{"line_number":55,"context_line":"iniset $TEMPEST_CONFIG share backend_names $BACKENDS_NAMES"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# Override the *_api_microversion options if present"},{"line_number":58,"context_line":"MANILA_TEMPEST_MIN_API_MICROVERSION\u003d${MANILA_TEMPEST_MIN_API_MICROVERSION:-\"\"}"},{"line_number":59,"context_line":"MANILA_TEMPEST_MAX_API_MICROVERSION\u003d${MANILA_TEMPEST_MAX_API_MICROVERSION:-\"2.44\"}"},{"line_number":60,"context_line":"if [[ ! -z \"$MANILA_TEMPEST_MIN_API_MICROVERSION\" ]]; then"},{"line_number":61,"context_line":"    iniset $TEMPEST_CONFIG share min_api_microversion $MANILA_TEMPEST_MIN_API_MICROVERSION"},{"line_number":62,"context_line":"fi"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"if [[ ! -z \"$MANILA_TEMPEST_MAX_API_MICROVERSION\" ]]; then"},{"line_number":65,"context_line":"    iniset $TEMPEST_CONFIG share max_api_microversion $MANILA_TEMPEST_MAX_API_MICROVERSION"},{"line_number":66,"context_line":"fi"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"# Set two retries for CI jobs"},{"line_number":69,"context_line":"iniset $TEMPEST_CONFIG share share_creation_retry_number 2"}],"source_content_type":"text/x-sh","patch_set":3,"id":"5f7c97a3_c4d66cc5","line":66,"range":{"start_line":57,"start_character":1,"end_line":66,"end_character":2},"updated":"2018-07-15 11:29:53.000000000","message":"Naively, is there a way to determine the min and max for any branch from what we find in manila/api/openstack/api_version_request.py ?","commit_id":"4c0f0e7bfd5e2f3f106c542bfc7f85b3ad376672"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"c9c3ec7c5ac8b772c32be953bb6245684264e48c","unresolved":false,"context_lines":[{"line_number":54,"context_line":"fi"},{"line_number":55,"context_line":"iniset $TEMPEST_CONFIG share backend_names $BACKENDS_NAMES"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"# Override the *_api_microversion options if present"},{"line_number":58,"context_line":"MANILA_TEMPEST_MIN_API_MICROVERSION\u003d${MANILA_TEMPEST_MIN_API_MICROVERSION:-\"\"}"},{"line_number":59,"context_line":"MANILA_TEMPEST_MAX_API_MICROVERSION\u003d${MANILA_TEMPEST_MAX_API_MICROVERSION:-\"2.44\"}"},{"line_number":60,"context_line":"if [[ ! -z \"$MANILA_TEMPEST_MIN_API_MICROVERSION\" ]]; then"},{"line_number":61,"context_line":"    iniset $TEMPEST_CONFIG share min_api_microversion $MANILA_TEMPEST_MIN_API_MICROVERSION"},{"line_number":62,"context_line":"fi"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"if [[ ! -z \"$MANILA_TEMPEST_MAX_API_MICROVERSION\" ]]; then"},{"line_number":65,"context_line":"    iniset $TEMPEST_CONFIG share max_api_microversion $MANILA_TEMPEST_MAX_API_MICROVERSION"},{"line_number":66,"context_line":"fi"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"# Set two retries for CI jobs"},{"line_number":69,"context_line":"iniset $TEMPEST_CONFIG share share_creation_retry_number 2"}],"source_content_type":"text/x-sh","patch_set":3,"id":"5f7c97a3_feebe377","line":66,"range":{"start_line":57,"start_character":1,"end_line":66,"end_character":2},"in_reply_to":"5f7c97a3_c4d66cc5","updated":"2018-07-16 15:23:14.000000000","message":"That\u0027s a good idea, we can do that, rather than have someone edit this every time the microversion is bumped","commit_id":"4c0f0e7bfd5e2f3f106c542bfc7f85b3ad376672"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"6cc0c692cbf929ec41113ddb9907c1c000975598","unresolved":false,"context_lines":[{"line_number":64,"context_line":"MANILA_TEMPEST_MAX_API_MICROVERSION\u003d${MANILA_TEMPEST_MAX_API_MICROVERSION:-$_DEFAULT_MAX_VERSION}"},{"line_number":65,"context_line":"# Set these options in tempest.conf"},{"line_number":66,"context_line":"iniset $TEMPEST_CONFIG share min_api_microversion $MANILA_TEMPEST_MIN_API_MICROVERSION"},{"line_number":67,"context_line":"iniset $TEMPEST_CONFIG share max_api_microversion $MANILA_TEMPEST_MAX_API_MICROVERSION"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"# Set two retries for CI jobs"},{"line_number":70,"context_line":"iniset $TEMPEST_CONFIG share share_creation_retry_number 2"}],"source_content_type":"text/x-sh","patch_set":4,"id":"5f7c97a3_7d332bc5","line":67,"range":{"start_line":67,"start_character":50,"end_line":67,"end_character":86},"updated":"2018-07-18 03:27:35.000000000","message":"It will be set to the max_api_version in manila service.\nThis will get zuul error when we remove/change some APIs in manila service code.\nFor example:\nWe use new access-list API instead of old access-list API.\nOld access-list API deleted in service version 2.44\nNew access-list API added in service version 2.45\n\nNow, the manila service code (not merged) run tempest test for manila service version 2.45 (because the max_api_microversion set to current max api version 2.45)\n\nWe will get error about access-list API not found. Because the old tempest test code don\u0027t update. We send request access-list API with version 2.45, but old tempest test code still send old API to manila service.","commit_id":"2f42c984e5ec0633910156718aeca4634a284cde"},{"author":{"_account_id":15100,"name":"zhongjun","email":"jun.zhongjun2@gmail.com","username":"zhongjun2"},"change_message_id":"16e7f02de45f102f4c9eed987e1763f17c3d0cb7","unresolved":false,"context_lines":[{"line_number":64,"context_line":"MANILA_TEMPEST_MAX_API_MICROVERSION\u003d${MANILA_TEMPEST_MAX_API_MICROVERSION:-$_DEFAULT_MAX_VERSION}"},{"line_number":65,"context_line":"# Set these options in tempest.conf"},{"line_number":66,"context_line":"iniset $TEMPEST_CONFIG share min_api_microversion $MANILA_TEMPEST_MIN_API_MICROVERSION"},{"line_number":67,"context_line":"iniset $TEMPEST_CONFIG share max_api_microversion $MANILA_TEMPEST_MAX_API_MICROVERSION"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"# Set two retries for CI jobs"},{"line_number":70,"context_line":"iniset $TEMPEST_CONFIG share share_creation_retry_number 2"}],"source_content_type":"text/x-sh","patch_set":4,"id":"5f7c97a3_bdc1c351","line":67,"range":{"start_line":67,"start_character":50,"end_line":67,"end_character":86},"in_reply_to":"5f7c97a3_7d332bc5","updated":"2018-07-18 03:39:04.000000000","message":"Is it only work on stable version, not work on master version?","commit_id":"2f42c984e5ec0633910156718aeca4634a284cde"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"07361167c5acdc0c3967b0c3e8f8357be967d7ea","unresolved":false,"context_lines":[{"line_number":64,"context_line":"MANILA_TEMPEST_MAX_API_MICROVERSION\u003d${MANILA_TEMPEST_MAX_API_MICROVERSION:-$_DEFAULT_MAX_VERSION}"},{"line_number":65,"context_line":"# Set these options in tempest.conf"},{"line_number":66,"context_line":"iniset $TEMPEST_CONFIG share min_api_microversion $MANILA_TEMPEST_MIN_API_MICROVERSION"},{"line_number":67,"context_line":"iniset $TEMPEST_CONFIG share max_api_microversion $MANILA_TEMPEST_MAX_API_MICROVERSION"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"# Set two retries for CI jobs"},{"line_number":70,"context_line":"iniset $TEMPEST_CONFIG share share_creation_retry_number 2"}],"source_content_type":"text/x-sh","patch_set":4,"id":"5f7c97a3_4ba8d7d7","line":67,"range":{"start_line":67,"start_character":50,"end_line":67,"end_character":86},"in_reply_to":"5f7c97a3_bdc1c351","updated":"2018-07-18 22:40:05.000000000","message":"Attempting a fix here: https://review.openstack.org/#/c/583649/","commit_id":"2f42c984e5ec0633910156718aeca4634a284cde"}]}