)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fd39c81c81906906826b7684461ab07b31849904","unresolved":false,"context_lines":[{"line_number":11,"context_line":"network, as it was trying to map multiple ipspaces to the same VLAN"},{"line_number":12,"context_line":"port."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This fix allows the driver to use the same ipspace and VLAN port across"},{"line_number":15,"context_line":"all subnets belonging to the same neutron network."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: If9cbb34a890ee44806c404085e40cc924a1296a7"},{"line_number":18,"context_line":"Closes-Bug: #1774159"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_25a23840","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":50},"updated":"2018-09-20 23:08:34.000000000","message":"You mean same neutron subnet - a neutron network can have multiple subnets that  can be different segments.","commit_id":"12f7418622accc923d8b97ef91e732790703d406"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"44bfa53d8a6cff637e9b0ef96eb5ecaa8ef3a666","unresolved":false,"context_lines":[{"line_number":11,"context_line":"network, as it was trying to map multiple ipspaces to the same VLAN"},{"line_number":12,"context_line":"port."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This fix allows the driver to use the same ipspace and VLAN port across"},{"line_number":15,"context_line":"all subnets belonging to the same neutron network."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: If9cbb34a890ee44806c404085e40cc924a1296a7"},{"line_number":18,"context_line":"Closes-Bug: #1774159"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_b54c089e","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":50},"in_reply_to":"3f79a3b5_25a23840","updated":"2018-09-24 13:31:21.000000000","message":"The segmentation ID is defined in the neutron network and all subnets need to use the same segmentation.","commit_id":"12f7418622accc923d8b97ef91e732790703d406"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"20432224fc88c646618b78f1f1ba1b13c6a99cf6","unresolved":false,"context_lines":[{"line_number":11,"context_line":"network, as it was trying to map multiple ipspaces to the same VLAN"},{"line_number":12,"context_line":"port."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This fix allows the driver to use the same ipspace and VLAN port across"},{"line_number":15,"context_line":"all subnets belonging to the same neutron network."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: If9cbb34a890ee44806c404085e40cc924a1296a7"},{"line_number":18,"context_line":"Closes-Bug: #1774159"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f79a3b5_d21aef7a","line":15,"range":{"start_line":14,"start_character":0,"end_line":15,"end_character":50},"in_reply_to":"3f79a3b5_b54c089e","updated":"2018-09-24 19:59:27.000000000","message":"gah, thanks, I had this backwards","commit_id":"12f7418622accc923d8b97ef91e732790703d406"}],"manila/share/drivers/netapp/dataontap/client/client_cmode.py":[{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"31ff292a608803e255811e52335346979aa495a9","unresolved":false,"context_lines":[{"line_number":938,"context_line":"        return interfaces"},{"line_number":939,"context_line":""},{"line_number":940,"context_line":"    @na_utils.trace"},{"line_number":941,"context_line":"    def get_ipspace_for_vlan_port(self, vlan_node, vlan_port, vlan_id):"},{"line_number":942,"context_line":"        \"\"\"Gets IPSpace for specified VLAN\"\"\""},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"        if not self.features.IPSPACES:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_f8a474a5","line":941,"range":{"start_line":941,"start_character":8,"end_line":941,"end_character":33},"updated":"2018-09-13 18:14:32.000000000","message":"More like \"get_ipspace_name_for_vlan_port\", hints about the purpose and return value of the method. Just my thought, but not that important functionality-wise, I guess :)","commit_id":"12f7418622accc923d8b97ef91e732790703d406"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"e0e4decfd71a37b9a532d874bdc85a301707f9e0","unresolved":false,"context_lines":[{"line_number":938,"context_line":"        return interfaces"},{"line_number":939,"context_line":""},{"line_number":940,"context_line":"    @na_utils.trace"},{"line_number":941,"context_line":"    def get_ipspace_for_vlan_port(self, vlan_node, vlan_port, vlan_id):"},{"line_number":942,"context_line":"        \"\"\"Gets IPSpace for specified VLAN\"\"\""},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"        if not self.features.IPSPACES:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_b8e4f5a9","line":941,"range":{"start_line":941,"start_character":8,"end_line":941,"end_character":33},"in_reply_to":"3f79a3b5_f8a474a5","updated":"2018-10-05 20:04:59.000000000","message":"Done","commit_id":"12f7418622accc923d8b97ef91e732790703d406"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fd39c81c81906906826b7684461ab07b31849904","unresolved":false,"context_lines":[{"line_number":951,"context_line":"        api_args \u003d {\u0027node\u0027: vlan_node, \u0027port\u0027: port}"},{"line_number":952,"context_line":""},{"line_number":953,"context_line":"        try:"},{"line_number":954,"context_line":"            result \u003d self.send_request(\u0027net-port-get\u0027, api_args)"},{"line_number":955,"context_line":"        except netapp_api.NaApiError as e:"},{"line_number":956,"context_line":"            if e.code \u003d\u003d netapp_api.EOBJECTNOTFOUND:"},{"line_number":957,"context_line":"                msg \u003d \"No ipspace was found for %(port)s\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a53968f1","line":954,"range":{"start_line":954,"start_character":40,"end_line":954,"end_character":52},"updated":"2018-09-20 23:08:34.000000000","message":"This asks ONTAP if there is a port called \"vlanport-vlanid\", ex: e0d-151, so why is the debug message \"No Ipspace found\"?","commit_id":"12f7418622accc923d8b97ef91e732790703d406"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"e0e4decfd71a37b9a532d874bdc85a301707f9e0","unresolved":false,"context_lines":[{"line_number":951,"context_line":"        api_args \u003d {\u0027node\u0027: vlan_node, \u0027port\u0027: port}"},{"line_number":952,"context_line":""},{"line_number":953,"context_line":"        try:"},{"line_number":954,"context_line":"            result \u003d self.send_request(\u0027net-port-get\u0027, api_args)"},{"line_number":955,"context_line":"        except netapp_api.NaApiError as e:"},{"line_number":956,"context_line":"            if e.code \u003d\u003d netapp_api.EOBJECTNOTFOUND:"},{"line_number":957,"context_line":"                msg \u003d \"No ipspace was found for %(port)s\""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_78fe5d3a","line":954,"range":{"start_line":954,"start_character":40,"end_line":954,"end_character":52},"in_reply_to":"3f79a3b5_a53968f1","updated":"2018-10-05 20:04:59.000000000","message":"Fixed debug message below","commit_id":"12f7418622accc923d8b97ef91e732790703d406"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fd39c81c81906906826b7684461ab07b31849904","unresolved":false,"context_lines":[{"line_number":954,"context_line":"            result \u003d self.send_request(\u0027net-port-get\u0027, api_args)"},{"line_number":955,"context_line":"        except netapp_api.NaApiError as e:"},{"line_number":956,"context_line":"            if e.code \u003d\u003d netapp_api.EOBJECTNOTFOUND:"},{"line_number":957,"context_line":"                msg \u003d \"No ipspace was found for %(port)s\""},{"line_number":958,"context_line":"                msg_args \u003d {\u0027port\u0027: port}"},{"line_number":959,"context_line":"                LOG.debug(msg, msg_args)"},{"line_number":960,"context_line":"                return None"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_8536ac01","line":957,"range":{"start_line":957,"start_character":23,"end_line":957,"end_character":56},"updated":"2018-09-20 23:08:34.000000000","message":"Operators can assume this is an issue. Can you clarify?\n\n\"No pre-existing port or ipspace was found for %(port)s, will attempt to create one.\"","commit_id":"12f7418622accc923d8b97ef91e732790703d406"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"e0e4decfd71a37b9a532d874bdc85a301707f9e0","unresolved":false,"context_lines":[{"line_number":954,"context_line":"            result \u003d self.send_request(\u0027net-port-get\u0027, api_args)"},{"line_number":955,"context_line":"        except netapp_api.NaApiError as e:"},{"line_number":956,"context_line":"            if e.code \u003d\u003d netapp_api.EOBJECTNOTFOUND:"},{"line_number":957,"context_line":"                msg \u003d \"No ipspace was found for %(port)s\""},{"line_number":958,"context_line":"                msg_args \u003d {\u0027port\u0027: port}"},{"line_number":959,"context_line":"                LOG.debug(msg, msg_args)"},{"line_number":960,"context_line":"                return None"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_98fb3947","line":957,"range":{"start_line":957,"start_character":23,"end_line":957,"end_character":56},"in_reply_to":"3f79a3b5_8536ac01","updated":"2018-10-05 20:04:59.000000000","message":"Done","commit_id":"12f7418622accc923d8b97ef91e732790703d406"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fd39c81c81906906826b7684461ab07b31849904","unresolved":false,"context_lines":[{"line_number":958,"context_line":"                msg_args \u003d {\u0027port\u0027: port}"},{"line_number":959,"context_line":"                LOG.debug(msg, msg_args)"},{"line_number":960,"context_line":"                return None"},{"line_number":961,"context_line":"            else:"},{"line_number":962,"context_line":"                raise"},{"line_number":963,"context_line":""},{"line_number":964,"context_line":"        attributes \u003d result.get_child_by_name(\u0027attributes\u0027)"},{"line_number":965,"context_line":"        if not attributes:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_c5190488","line":962,"range":{"start_line":961,"start_character":12,"end_line":962,"end_character":21},"updated":"2018-09-20 23:08:34.000000000","message":"What other errors are possible?","commit_id":"12f7418622accc923d8b97ef91e732790703d406"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"e0e4decfd71a37b9a532d874bdc85a301707f9e0","unresolved":false,"context_lines":[{"line_number":958,"context_line":"                msg_args \u003d {\u0027port\u0027: port}"},{"line_number":959,"context_line":"                LOG.debug(msg, msg_args)"},{"line_number":960,"context_line":"                return None"},{"line_number":961,"context_line":"            else:"},{"line_number":962,"context_line":"                raise"},{"line_number":963,"context_line":""},{"line_number":964,"context_line":"        attributes \u003d result.get_child_by_name(\u0027attributes\u0027)"},{"line_number":965,"context_line":"        if not attributes:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_b899551f","line":962,"range":{"start_line":961,"start_character":12,"end_line":962,"end_character":21},"in_reply_to":"3f79a3b5_c5190488","updated":"2018-10-05 20:04:59.000000000","message":"Not sure, but EOBJECTNOTFOUND is the only one we don\u0027t want to raise.","commit_id":"12f7418622accc923d8b97ef91e732790703d406"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fd39c81c81906906826b7684461ab07b31849904","unresolved":false,"context_lines":[{"line_number":962,"context_line":"                raise"},{"line_number":963,"context_line":""},{"line_number":964,"context_line":"        attributes \u003d result.get_child_by_name(\u0027attributes\u0027)"},{"line_number":965,"context_line":"        if not attributes:"},{"line_number":966,"context_line":"            raise exception.NetAppException(\u0027Failed to read Vserver info\u0027)"},{"line_number":967,"context_line":""},{"line_number":968,"context_line":"        net_port_info \u003d attributes.get_child_by_name(\u0027net-port-info\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_450df43b","line":965,"range":{"start_line":965,"start_character":8,"end_line":965,"end_character":26},"updated":"2018-09-20 23:08:34.000000000","message":"Is this even possible if a port exists?","commit_id":"12f7418622accc923d8b97ef91e732790703d406"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"e0e4decfd71a37b9a532d874bdc85a301707f9e0","unresolved":false,"context_lines":[{"line_number":962,"context_line":"                raise"},{"line_number":963,"context_line":""},{"line_number":964,"context_line":"        attributes \u003d result.get_child_by_name(\u0027attributes\u0027)"},{"line_number":965,"context_line":"        if not attributes:"},{"line_number":966,"context_line":"            raise exception.NetAppException(\u0027Failed to read Vserver info\u0027)"},{"line_number":967,"context_line":""},{"line_number":968,"context_line":"        net_port_info \u003d attributes.get_child_by_name(\u0027net-port-info\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_9880199f","line":965,"range":{"start_line":965,"start_character":8,"end_line":965,"end_character":26},"in_reply_to":"3f79a3b5_450df43b","updated":"2018-10-05 20:04:59.000000000","message":"Not actually. Removed it.","commit_id":"12f7418622accc923d8b97ef91e732790703d406"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fd39c81c81906906826b7684461ab07b31849904","unresolved":false,"context_lines":[{"line_number":963,"context_line":""},{"line_number":964,"context_line":"        attributes \u003d result.get_child_by_name(\u0027attributes\u0027)"},{"line_number":965,"context_line":"        if not attributes:"},{"line_number":966,"context_line":"            raise exception.NetAppException(\u0027Failed to read Vserver info\u0027)"},{"line_number":967,"context_line":""},{"line_number":968,"context_line":"        net_port_info \u003d attributes.get_child_by_name(\u0027net-port-info\u0027)"},{"line_number":969,"context_line":"        ipspace_name \u003d net_port_info.get_child_content(\u0027ipspace\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a512c85f","line":966,"range":{"start_line":966,"start_character":59,"end_line":966,"end_character":69},"updated":"2018-09-20 23:08:34.000000000","message":"? Your ZAPI asks for port info, but the error message says \"Vserver info\"","commit_id":"12f7418622accc923d8b97ef91e732790703d406"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"e0e4decfd71a37b9a532d874bdc85a301707f9e0","unresolved":false,"context_lines":[{"line_number":963,"context_line":""},{"line_number":964,"context_line":"        attributes \u003d result.get_child_by_name(\u0027attributes\u0027)"},{"line_number":965,"context_line":"        if not attributes:"},{"line_number":966,"context_line":"            raise exception.NetAppException(\u0027Failed to read Vserver info\u0027)"},{"line_number":967,"context_line":""},{"line_number":968,"context_line":"        net_port_info \u003d attributes.get_child_by_name(\u0027net-port-info\u0027)"},{"line_number":969,"context_line":"        ipspace_name \u003d net_port_info.get_child_content(\u0027ipspace\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_588a81bc","line":966,"range":{"start_line":966,"start_character":59,"end_line":966,"end_character":69},"in_reply_to":"3f79a3b5_a512c85f","updated":"2018-10-05 20:04:59.000000000","message":"Done","commit_id":"12f7418622accc923d8b97ef91e732790703d406"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"31ff292a608803e255811e52335346979aa495a9","unresolved":false,"context_lines":[{"line_number":966,"context_line":"            raise exception.NetAppException(\u0027Failed to read Vserver info\u0027)"},{"line_number":967,"context_line":""},{"line_number":968,"context_line":"        net_port_info \u003d attributes.get_child_by_name(\u0027net-port-info\u0027)"},{"line_number":969,"context_line":"        ipspace_name \u003d net_port_info.get_child_content(\u0027ipspace\u0027)"},{"line_number":970,"context_line":""},{"line_number":971,"context_line":"        return ipspace_name"},{"line_number":972,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_bd4cb13f","line":969,"range":{"start_line":969,"start_character":23,"end_line":969,"end_character":36},"updated":"2018-09-13 18:14:32.000000000","message":"Can\u0027t \u0027net_port_info\u0027 be None just like \u0027attributes\u0027?","commit_id":"12f7418622accc923d8b97ef91e732790703d406"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"0c0e9385a7ef818165b0f21b25550cf0a38c824c","unresolved":false,"context_lines":[{"line_number":966,"context_line":"            raise exception.NetAppException(\u0027Failed to read Vserver info\u0027)"},{"line_number":967,"context_line":""},{"line_number":968,"context_line":"        net_port_info \u003d attributes.get_child_by_name(\u0027net-port-info\u0027)"},{"line_number":969,"context_line":"        ipspace_name \u003d net_port_info.get_child_content(\u0027ipspace\u0027)"},{"line_number":970,"context_line":""},{"line_number":971,"context_line":"        return ipspace_name"},{"line_number":972,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_31baf3e0","line":969,"range":{"start_line":969,"start_character":23,"end_line":969,"end_character":36},"in_reply_to":"3f79a3b5_bd4cb13f","updated":"2018-09-14 17:45:24.000000000","message":"If it has attributes, it will always have net-port-info.","commit_id":"12f7418622accc923d8b97ef91e732790703d406"}],"manila/share/drivers/netapp/dataontap/cluster_mode/lib_multi_svm.py":[{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fd39c81c81906906826b7684461ab07b31849904","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            msg \u003d _(\u0027Vserver %s already exists.\u0027)"},{"line_number":160,"context_line":"            raise exception.NetAppException(msg % vserver_name)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        # NOTE(lseki): If there\u0027s already an ipspace created for the same VLAN"},{"line_number":163,"context_line":"        # port, reuse it. It will be named after the previously created share"},{"line_number":164,"context_line":"        # server\u0027s neutron subnet id."},{"line_number":165,"context_line":"        node_name \u003d self._client.list_cluster_nodes()[0]"},{"line_number":166,"context_line":"        port \u003d self._get_node_data_port(node_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_b77bdbf1","line":163,"range":{"start_line":162,"start_character":23,"end_line":163,"end_character":24},"updated":"2018-09-20 23:08:34.000000000","message":"If there\u0027s an ipspace already, it will be named after the neutron subnet or just called \"Default\", I\u0027m not sure your approach solves https://bugs.launchpad.net/manila/+bug/1774159 (Also see line 169). \n\nA neutron network may have multiple subnets, each its own segment (different VLANs), on the backend, all of these segments need to have the same ipspace - so the problem here is the way ipspaces are being named and shared - they should be named after the neutron network, as Maurice notes, and not the subnet. Broadcast domains on the other hand must be unique to each layer-2 segment (neutron subnet). \n\nYour fix, as I understand it is: See if neutron wants the same VLAN, if yes, reuse the ipspace name from the port - but this is inconsequential, the problem states that there are two VLANs that belong to the same neutron network.","commit_id":"12f7418622accc923d8b97ef91e732790703d406"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"20432224fc88c646618b78f1f1ba1b13c6a99cf6","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            msg \u003d _(\u0027Vserver %s already exists.\u0027)"},{"line_number":160,"context_line":"            raise exception.NetAppException(msg % vserver_name)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        # NOTE(lseki): If there\u0027s already an ipspace created for the same VLAN"},{"line_number":163,"context_line":"        # port, reuse it. It will be named after the previously created share"},{"line_number":164,"context_line":"        # server\u0027s neutron subnet id."},{"line_number":165,"context_line":"        node_name \u003d self._client.list_cluster_nodes()[0]"},{"line_number":166,"context_line":"        port \u003d self._get_node_data_port(node_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_f8e4ad44","line":163,"range":{"start_line":162,"start_character":23,"end_line":163,"end_character":24},"in_reply_to":"3f79a3b5_607f9017","updated":"2018-09-24 19:59:27.000000000","message":"You\u0027re right about the segmentation ID. Network Allocations must provide both IDs to the driver - perhaps you can check if the ipspace is named after a different subnet in the same neutron network.","commit_id":"12f7418622accc923d8b97ef91e732790703d406"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"44bfa53d8a6cff637e9b0ef96eb5ecaa8ef3a666","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            msg \u003d _(\u0027Vserver %s already exists.\u0027)"},{"line_number":160,"context_line":"            raise exception.NetAppException(msg % vserver_name)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        # NOTE(lseki): If there\u0027s already an ipspace created for the same VLAN"},{"line_number":163,"context_line":"        # port, reuse it. It will be named after the previously created share"},{"line_number":164,"context_line":"        # server\u0027s neutron subnet id."},{"line_number":165,"context_line":"        node_name \u003d self._client.list_cluster_nodes()[0]"},{"line_number":166,"context_line":"        port \u003d self._get_node_data_port(node_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_607f9017","line":163,"range":{"start_line":162,"start_character":23,"end_line":163,"end_character":24},"in_reply_to":"3f79a3b5_b77bdbf1","updated":"2018-09-24 13:31:21.000000000","message":"the Segmentation ID is defined in the neutron network. All subnets from the same neutron network need to have the same segmentation ID, thus broadcast domains need to be unique to each neutron network. And as per our testing (unless we missed something), each ipspace can only have 1 broadcast domain.\n\nEach new ipspace from now on should be created using neutron_network_id (this will be fixed in next patchset) and in order to preserve backwards compatibility, every time a new share server is created and it tries to obtain the VLAN port and finds one that is already used by another ipspace (named by subnet), it will reuse it. I am checking with Lucio if there is any way we can confirm the relationship of that ipspace to be reused with the neutron_net_id (I believe that the lack of this check is what you refer by \"inconsequential\").","commit_id":"12f7418622accc923d8b97ef91e732790703d406"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"e0e4decfd71a37b9a532d874bdc85a301707f9e0","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            msg \u003d _(\u0027Vserver %s already exists.\u0027)"},{"line_number":160,"context_line":"            raise exception.NetAppException(msg % vserver_name)"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        # NOTE(lseki): If there\u0027s already an ipspace created for the same VLAN"},{"line_number":163,"context_line":"        # port, reuse it. It will be named after the previously created share"},{"line_number":164,"context_line":"        # server\u0027s neutron subnet id."},{"line_number":165,"context_line":"        node_name \u003d self._client.list_cluster_nodes()[0]"},{"line_number":166,"context_line":"        port \u003d self._get_node_data_port(node_name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_1831690b","line":163,"range":{"start_line":162,"start_character":23,"end_line":163,"end_character":24},"in_reply_to":"3f79a3b5_f8e4ad44","updated":"2018-10-05 20:04:59.000000000","message":"We looked for alternative approaches, but concluded that we always need to reuse the ipspace associated to the same VLAN.","commit_id":"12f7418622accc923d8b97ef91e732790703d406"},{"author":{"_account_id":26968,"name":"Amit O","email":"oamit.work@gmail.com","username":"amito"},"change_message_id":"31ff292a608803e255811e52335346979aa495a9","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        # NOTE(lseki): If there\u0027s already an ipspace created for the same VLAN"},{"line_number":163,"context_line":"        # port, reuse it. It will be named after the previously created share"},{"line_number":164,"context_line":"        # server\u0027s neutron subnet id."},{"line_number":165,"context_line":"        node_name \u003d self._client.list_cluster_nodes()[0]"},{"line_number":166,"context_line":"        port \u003d self._get_node_data_port(node_name)"},{"line_number":167,"context_line":"        vlan \u003d network_info[\u0027segmentation_id\u0027]"},{"line_number":168,"context_line":"        ipspace_name \u003d self._client.get_ipspace_for_vlan_port("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_984a2059","line":165,"range":{"start_line":165,"start_character":53,"end_line":165,"end_character":56},"updated":"2018-09-13 18:14:32.000000000","message":"What happens if this list is empty? Either try-except for IndexError or check the length.","commit_id":"12f7418622accc923d8b97ef91e732790703d406"},{"author":{"_account_id":17097,"name":"Tiago Pasqualini da Silva","email":"t.pasqualini@luizalabs.com","username":"tiago.pasqualini"},"change_message_id":"0c0e9385a7ef818165b0f21b25550cf0a38c824c","unresolved":false,"context_lines":[{"line_number":162,"context_line":"        # NOTE(lseki): If there\u0027s already an ipspace created for the same VLAN"},{"line_number":163,"context_line":"        # port, reuse it. It will be named after the previously created share"},{"line_number":164,"context_line":"        # server\u0027s neutron subnet id."},{"line_number":165,"context_line":"        node_name \u003d self._client.list_cluster_nodes()[0]"},{"line_number":166,"context_line":"        port \u003d self._get_node_data_port(node_name)"},{"line_number":167,"context_line":"        vlan \u003d network_info[\u0027segmentation_id\u0027]"},{"line_number":168,"context_line":"        ipspace_name \u003d self._client.get_ipspace_for_vlan_port("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_96009d04","line":165,"range":{"start_line":165,"start_character":53,"end_line":165,"end_character":56},"in_reply_to":"3f79a3b5_984a2059","updated":"2018-09-14 17:45:24.000000000","message":"This method returns the list of nodes on this ONTAP cluster. A cluster cannot work without nodes, so it will never result in an empty list. In the case this happens, it will fail somewhere at driver initialization.","commit_id":"12f7418622accc923d8b97ef91e732790703d406"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fd39c81c81906906826b7684461ab07b31849904","unresolved":false,"context_lines":[{"line_number":163,"context_line":"        # port, reuse it. It will be named after the previously created share"},{"line_number":164,"context_line":"        # server\u0027s neutron subnet id."},{"line_number":165,"context_line":"        node_name \u003d self._client.list_cluster_nodes()[0]"},{"line_number":166,"context_line":"        port \u003d self._get_node_data_port(node_name)"},{"line_number":167,"context_line":"        vlan \u003d network_info[\u0027segmentation_id\u0027]"},{"line_number":168,"context_line":"        ipspace_name \u003d self._client.get_ipspace_for_vlan_port("},{"line_number":169,"context_line":"            node_name, port, vlan) or self._create_ipspace(network_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_b74f5b68","line":166,"range":{"start_line":166,"start_character":8,"end_line":166,"end_character":50},"updated":"2018-09-20 23:08:34.000000000","message":"What if a node has two data ports and you\u0027ve created the previous port on a different port? This method is returning the first port in a matched list of ports.","commit_id":"12f7418622accc923d8b97ef91e732790703d406"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"fd39c81c81906906826b7684461ab07b31849904","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        port \u003d self._get_node_data_port(node_name)"},{"line_number":167,"context_line":"        vlan \u003d network_info[\u0027segmentation_id\u0027]"},{"line_number":168,"context_line":"        ipspace_name \u003d self._client.get_ipspace_for_vlan_port("},{"line_number":169,"context_line":"            node_name, port, vlan) or self._create_ipspace(network_info)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        LOG.debug(\u0027Vserver %s does not exist, creating.\u0027, vserver_name)"},{"line_number":172,"context_line":"        self._client.create_vserver("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_373b4bc8","line":169,"range":{"start_line":169,"start_character":38,"end_line":169,"end_character":72},"updated":"2018-09-20 23:08:34.000000000","message":"This method already reuses an existing ipspace if present; the bug (https://bugs.launchpad.net/manila/+bug/1774159) says there\u0027s a problem assigning a broadcast domain.","commit_id":"12f7418622accc923d8b97ef91e732790703d406"},{"author":{"_account_id":14567,"name":"Rodrigo Barbieri","email":"rodrigo.barbieri2010@gmail.com","username":"ganso"},"change_message_id":"44bfa53d8a6cff637e9b0ef96eb5ecaa8ef3a666","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        port \u003d self._get_node_data_port(node_name)"},{"line_number":167,"context_line":"        vlan \u003d network_info[\u0027segmentation_id\u0027]"},{"line_number":168,"context_line":"        ipspace_name \u003d self._client.get_ipspace_for_vlan_port("},{"line_number":169,"context_line":"            node_name, port, vlan) or self._create_ipspace(network_info)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        LOG.debug(\u0027Vserver %s does not exist, creating.\u0027, vserver_name)"},{"line_number":172,"context_line":"        self._client.create_vserver("}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_a0012870","line":169,"range":{"start_line":169,"start_character":38,"end_line":169,"end_character":72},"in_reply_to":"3f79a3b5_373b4bc8","updated":"2018-09-24 13:31:21.000000000","message":"not in all cases a broadcast domain should be assigned. Maybe those methods should be cleaned up / merged, as we are essentially falling in the case of reusing an existing ipspace in 2 different methods.","commit_id":"12f7418622accc923d8b97ef91e732790703d406"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"87d8e189e35446686f79e280543509786328b3f5","unresolved":false,"context_lines":[{"line_number":229,"context_line":"            return client_cmode.DEFAULT_IPSPACE"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        ipspace_name \u003d self._get_valid_ipspace_name(ipspace_id)"},{"line_number":232,"context_line":"        if not self._client.ipspace_exists(ipspace_name):"},{"line_number":233,"context_line":"            self._client.create_ipspace(ipspace_name)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        return ipspace_name"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_b8d8c6ef","line":232,"range":{"start_line":232,"start_character":8,"end_line":232,"end_character":57},"updated":"2018-10-15 12:36:51.000000000","message":"Why are you removing the guard?","commit_id":"12f7418622accc923d8b97ef91e732790703d406"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"fe492c95afc953033649d24d9a0fc0bcd6d1aa07","unresolved":false,"context_lines":[{"line_number":229,"context_line":"            return client_cmode.DEFAULT_IPSPACE"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        ipspace_name \u003d self._get_valid_ipspace_name(ipspace_id)"},{"line_number":232,"context_line":"        if not self._client.ipspace_exists(ipspace_name):"},{"line_number":233,"context_line":"            self._client.create_ipspace(ipspace_name)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        return ipspace_name"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_41f2c19c","line":232,"range":{"start_line":232,"start_character":8,"end_line":232,"end_character":57},"in_reply_to":"3f79a3b5_813d398e","updated":"2018-10-16 14:23:42.000000000","message":"Done","commit_id":"12f7418622accc923d8b97ef91e732790703d406"},{"author":{"_account_id":18058,"name":"Lucio Seki","email":"lseki@redhat.com","username":"lseki"},"change_message_id":"f1320804c6c32d5cf13ed8df5deb31bd0e9b22d5","unresolved":false,"context_lines":[{"line_number":229,"context_line":"            return client_cmode.DEFAULT_IPSPACE"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        ipspace_name \u003d self._get_valid_ipspace_name(ipspace_id)"},{"line_number":232,"context_line":"        if not self._client.ipspace_exists(ipspace_name):"},{"line_number":233,"context_line":"            self._client.create_ipspace(ipspace_name)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        return ipspace_name"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_be3d0f8e","line":232,"range":{"start_line":232,"start_character":8,"end_line":232,"end_character":57},"in_reply_to":"3f79a3b5_b8d8c6ef","updated":"2018-10-15 12:58:44.000000000","message":"Because it will never be called. This method `_create_ipspace` is called only if `get_ipspace_for_vlan_port` returns None at L168. So if this method was called, it\u0027s because there\u0027s no such ipspace yet.","commit_id":"12f7418622accc923d8b97ef91e732790703d406"},{"author":{"_account_id":18816,"name":"Maurice Escher","display_name":"carthaca","email":"maurice.escher@sap.com","username":"mapocace"},"change_message_id":"10f9ce0bc544b141e39ea26eb2f9bbbe97b81743","unresolved":false,"context_lines":[{"line_number":229,"context_line":"            return client_cmode.DEFAULT_IPSPACE"},{"line_number":230,"context_line":""},{"line_number":231,"context_line":"        ipspace_name \u003d self._get_valid_ipspace_name(ipspace_id)"},{"line_number":232,"context_line":"        if not self._client.ipspace_exists(ipspace_name):"},{"line_number":233,"context_line":"            self._client.create_ipspace(ipspace_name)"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"        return ipspace_name"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_813d398e","line":232,"range":{"start_line":232,"start_character":8,"end_line":232,"end_character":57},"in_reply_to":"3f79a3b5_be3d0f8e","updated":"2018-10-16 14:10:47.000000000","message":"Okay. Consequentially test_create_ipspace_already_present should be removed as well then.","commit_id":"12f7418622accc923d8b97ef91e732790703d406"}]}
