)]}'
{"manila/share/drivers/container/storage_helper.py":[{"author":{"_account_id":9003,"name":"Tom Barron","email":"tpb@dyncloud.net","username":"tbarron"},"change_message_id":"ed4d12ccb9fbc99b757fc4c68f2bf95a1decfbae","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        (free_size, total_size) \u003d sorted(re.findall(\"\\d+\\.\\d+|\\d+\", out),"},{"line_number":67,"context_line":"                                         reverse\u003dFalse)"},{"line_number":68,"context_line":"        return [{"},{"line_number":69,"context_line":"            \u0027pool_name\u0027: self.configuration.container_volume_group,"},{"line_number":70,"context_line":"            \u0027total_capacity_gb\u0027: float(total_size),"},{"line_number":71,"context_line":"            \u0027free_capacity_gb\u0027: float(free_size),"},{"line_number":72,"context_line":"            \u0027reserved_percentage\u0027: 0,"},{"line_number":73,"context_line":"        }, ]"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _get_lv_device(self, share):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_1a0cb9ea","line":72,"range":{"start_line":68,"start_character":0,"end_line":72,"end_character":37},"updated":"2018-09-27 12:34:04.000000000","message":"If we ever have to revisit this let\u0027s add some LOG.debug.","commit_id":"53d15d3bbe8ae5327f3c4ff1752e969afddf8d1b"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"007fdd14ab881d3bae5dc3020217502bc63bd36c","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        (free_size, total_size) \u003d sorted(re.findall(\"\\d+\\.\\d+|\\d+\", out),"},{"line_number":67,"context_line":"                                         reverse\u003dFalse)"},{"line_number":68,"context_line":"        return [{"},{"line_number":69,"context_line":"            \u0027pool_name\u0027: self.configuration.container_volume_group,"},{"line_number":70,"context_line":"            \u0027total_capacity_gb\u0027: float(total_size),"},{"line_number":71,"context_line":"            \u0027free_capacity_gb\u0027: float(free_size),"},{"line_number":72,"context_line":"            \u0027reserved_percentage\u0027: 0,"},{"line_number":73,"context_line":"        }, ]"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _get_lv_device(self, share):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_b6c6d648","line":72,"range":{"start_line":68,"start_character":0,"end_line":72,"end_character":37},"in_reply_to":"3f79a3b5_1a0cb9ea","updated":"2018-09-29 02:02:01.000000000","message":"+1","commit_id":"53d15d3bbe8ae5327f3c4ff1752e969afddf8d1b"},{"author":{"_account_id":16643,"name":"Goutham Pacha Ravi","email":"gouthampravi@gmail.com","username":"gouthamr"},"change_message_id":"45a75e38d8a5bfa3bc077ddc5e4d30d252526466","unresolved":false,"context_lines":[{"line_number":65,"context_line":""},{"line_number":66,"context_line":"        (free_size, total_size) \u003d sorted(re.findall(\"\\d+\\.\\d+|\\d+\", out),"},{"line_number":67,"context_line":"                                         reverse\u003dFalse)"},{"line_number":68,"context_line":"        return [{"},{"line_number":69,"context_line":"            \u0027pool_name\u0027: self.configuration.container_volume_group,"},{"line_number":70,"context_line":"            \u0027total_capacity_gb\u0027: float(total_size),"},{"line_number":71,"context_line":"            \u0027free_capacity_gb\u0027: float(free_size),"},{"line_number":72,"context_line":"            \u0027reserved_percentage\u0027: 0,"},{"line_number":73,"context_line":"        }, ]"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def _get_lv_device(self, share):"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_0195df3c","line":72,"range":{"start_line":68,"start_character":0,"end_line":72,"end_character":37},"in_reply_to":"3f79a3b5_b6c6d648","updated":"2018-10-01 22:49:39.000000000","message":"Tom/Xing: I partially disagree.. The scheduler\u0027s logging capability/capacity updates, and here, this is partial information; we\u0027re padding more info in the driver [1] and in the base driver [2].\n\nIf we need to log capabilities in the share manager service too, the logging changes need to be made in the base driver so all drivers can have the same debug logging.\n\n[1] https://github.com/openstack/manila/blob/fb17422/manila/share/drivers/container/driver.py#L105\n[2] https://github.com/openstack/manila/blob/fb17422/manila/share/driver.py#L1092","commit_id":"53d15d3bbe8ae5327f3c4ff1752e969afddf8d1b"}]}